summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * tabletmode: Correctly handle HW orientation changingTim Van Patten2022-11-282-36/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the tabletmode is being forced by 'tabletmode on' or 'tabletmode off', the actual HW orientation can still change between tablet and clamshell mode. When 'tabletmode reset' is issued, the device should behave correctly based on the current HW orientation. This also updates the test drivers.default.tablet_set_mode to fix spelling errors and adds comments to explain the various zassert_equal() values being checked. BRANCH=none BUG=b:256015402 TEST=./twister -v -i --coverage -p native_posix -p unit_testing \ -s zephyr/test/drivers/drivers.host_cmd ./twister -v -i --coverage -p native_posix -p unit_testing \ -s zephyr/test/drivers/drivers.default TEST='tabletmode on' in clamshell mode, convert DUT to tablet mode, 'tabletmode reset', verify DUT is in tablet mode. Change-Id: I1039bda7790e0623b013db01e673fe43fa7d8fc8 Signed-off-by: Tim Van Patten <timvp@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4006302 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Raul Rangel <rrangel@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
| * rex: Remove unused PSL pin from PSL IO pad listRajesh Kumar2022-11-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | EC reboots when hibernate command is triggered on EC console. Only LID_OPEN, ACOK_OD and MECH_PWR_BTN_ODL needs to be configured as PSL wake-up pins. The additional congifured signal GSC_EC_PWR_BTN_ODL which is the passthroug signal from H1 is causing reboot on hibernate. Hence removed the unused PSL signal from PSL configuration. BRANCH=None BUG=b:260129864 TEST=No reboot observed on hibernate using EC command. EC is coming out of hibernate state when Type-C charger is conncted. Signed-off-by: Rajesh Kumar <rajesh3.kumar@intel.com> Change-Id: I433519186f864ad939e4d6fb984c087899e2a3da Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4049896 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
| * motion_sense: avoid possible invalid memory accessBoris Mittelberg2022-11-283-2/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Returning SENSOR_CONFIG_MAX will cause out of bound read. Return one of the legal values. BUG=b:64477774 BRANCH=none TEST=make -j buildall Signed-off-by: Boris Mittelberg <bmbm@google.com> Change-Id: I1d2b407cb42da8b6fa78fb61be39d05ea1d64401 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4032916 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Ricardo Quesada <ricardoq@chromium.org> Reviewed-by: caveh jalali <caveh@chromium.org>
| * tcpmv2: pe: Add mux_set call following successful DATA_RESETScott Collyer2022-11-281-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL adds a call to set_usb_mux_with_current_data_role after performing a successful DATA_RESET. This is being added to satisfy 6.3.14 Data_Reset Message, item #3: If the Port was operating in [USB 3.2] or [USB4] reapply the port’s Rx Terminations (see [USB 3.2]). Without this call a mode entry attempt that is either not successful, or rejected by the port partner would leave the USB3.x SS lanes disconnected. This would also be the case following an Exit_Mode request from the AP when DATA_RESET is supported. BUG=b:260095516 BRANCH=none TEST=using drivers.usbc_usb4_mode integration test to verify that the mux ends up in the correct state following a DATA_RESET. Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: I3b6f9d00beb5fcc5a68c44887bde03d22b61d3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4040832 Tested-by: Scott Collyer <scollyer@chromium.org> Commit-Queue: Scott Collyer <scollyer@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
| * i8042: Send command response from priority queueDaisuke Nojiri2022-11-282-73/+139
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch also makes KEYPROTO task hold sending a scancode when it receives SETLEDS command until it returns ACK to the second byte (and leaves STATE_ATKBD_SETLEDS). This patch also removes and repositions some kblog_put calls because checking OBF and writing to DBBOUT must be done as atomically as possible to minimize the race condition. BUG=b:237981131,b:247795316 BRANCH=None TEST=Taniks. Press search+alt then 'k' 100 times. Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Change-Id: I7ccfae99b3657ead5fa9e3c337db623aaffdb0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3901253 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * moli: add power on/wakeup by HDMI monitorElsie Shih2022-11-283-6/+129
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After EC received interrupt from monitor on GPIOB4/ GPIOB5/ GPIO10. EC will power on the system. If EC received interrupt during s0ix, EC will trigger powr button to wake AP. BUG=b:239634608 BRANCH=none TEST=make BOARD=moli Signed-off-by: Elsie Shih <elsie_shih@wistron.corp-partner.google.com> Change-Id: Ia407468afc103595d33b6ce526d8e05bc66c76a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3771361 Tested-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * pujjo: add GPIO_VOLTAGE_1P8 flag supportarthur.lin2022-11-282-4/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add GPIO_VOLTAGE_1P8 flag support reference by nivviks CL:3775793 BUG=none BRANCH=none TEST=zmake build pujjo Change-Id: Id22852e5cdbaeeb03cd22dae51e080b4e9ec93bd Signed-off-by: arthur.lin <arthur.lin@lcfc.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4060126 Reviewed-by: Andrew McRae <amcrae@google.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * Xivu: modify motionsense rotate mappingmick_hsiao2022-11-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | modify base rot ref rotate mapping BUG=b:259466064 BRANCH=none TEST=rotate DUT. DUT won't switches to Tablet mode in NB mode Signed-off-by: mick_hsiao <mick_hsiao@compal.corp-partner.google.com> Change-Id: I3d0e30c0602bf5ad2b7f4637d0222917e6e0f50e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4054315 Reviewed-by: SamSP Liu <samsp_liu2@compal.corp-partner.google.com> Reviewed-by: Andrew McRae <amcrae@google.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * dibbi: Update board specific power implementationLiam Flaherty2022-11-289-677/+338
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removed battery and battery charging support, as dibbi does not have either of these. Added support for dual barrel-jack/USB-C power supplies and update USB PD policies accordingly. Added support for USB-C0 output load-switch. Made changes in dedede baseboard to allow alternate implementation of extpower_is_present with the absence of a charger chip. BUG=b:257377326 BRANCH=dedede TEST=make -j BOARD=dibbi Signed-off-by: Liam Flaherty <liamflaherty@chromium.org> Change-Id: I81d01a88caf174eb038685bf098686e8a310a9b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4054386 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Sam McNally <sammc@chromium.org> Reviewed-by: Adam Mills <adamjmills@google.com> Tested-by: Adam Mills <adamjmills@google.com>
| * build: update build cmake files for unit testsYuval Peress2022-11-256-26/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adding the unittest Zephyr component now updates the CMAKE_C_COMPILER and CMAKE_CXX_COMPILER values. This means that find_package needs to be called prior to any of the test library commands so the right compiler is set for all the libraries. Twister launcher no longer needs to set the compiler as an argument to CMake. zephyr/cmake compiler and toolchain required updates to play nice with posix/unit_testing architectures. These included: 1. Conditionally adding the -fno-PIC flag 2. Setting CMAKE_CXX_COMPILER for clang 3. Adding a unit_testing cross compile target to the llvm and host toolchain BRANCH=none BUG=none TEST=./twister Cq-Depend: chromium:4047569 Signed-off-by: Yuval Peress <peress@google.com> Change-Id: Ib1e8ddcb526a56c05ef925d4d9ab97cb65004038 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4050266 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * gaelin: Keep backlight and speaker power control for displayRaymond Chung2022-11-251-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change adds to keep backlight and speaker always on to unlock proto 2 power on validation. We'll keep following on it to figure out the correct behavior for backlight/speaker power control and implement in EC. BUG=b:249000573, b:259321814 BRANCH=None TEST="make -j BOARD=gaelin" and normal display. Change-Id: Id4c60a26f74957e57c5ea4230f70ea02660236ed Signed-off-by: Raymond Chung <raymondchung@ami.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4043947 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Derek Huang <derekhuang@google.com> Commit-Queue: Derek Huang <derekhuang@google.com>
| * corsola: Initial zephyr config for VoltorbSiyu Qin2022-11-255-1/+369
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Initial EC Zephyr config for Corsola/Voltorb. Reuse most of Kingler sources. BUG=b:256573843 BRANCH=corsola TEST=zmake build voltorb Change-Id: I9bb960a4a635baf666b82db988f4a54512a30d1b Signed-off-by: Siyu Qin <qinsiyu@huaqin.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3993603 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Mike Lee <mike5@huaqin.corp-partner.google.com>
| * nissa: use device tree for USB-C configAdam Mills2022-11-2514-162/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enable support for USB-C configuration on Nissa boards through the device tree rather than in code. BUG=b:213963699 TEST=zmake build -a; Flashed Nereid and Craask devices and verified USB-C ports working. BRANCH=main LOW_COVERAGE_REASON=Nissa specific changes. Change-Id: I2d840da5db5291066f206d9bf3d28dc0bca98307 Signed-off-by: Adam Mills <adamjmills@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4054313 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
| * zephyr: Make Renesas RAA489000 TCPC chip available for Device TreeAdam Mills2022-11-253-0/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactoring to make RAA489000 work with DT, adding the DT binding, modifying the TCPC shim to find the chip and compat. BUG=b:213963699 TEST=zmake build -a; BRANCH=main LOW_COVERAGE_REASON=Will be covered in Nissa future tests. Change-Id: I85b252a4292755a984db5b517037f26e1e9bbd61 Signed-off-by: Adam Mills <adamjmills@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4054312 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Peter Marheine <pmarheine@chromium.org> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
| * ec: IWYU Add missing includesJeremy Bettis2022-11-243-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add "chip/stm32/usb_hw.h" for usb_uint Add <stddef.h> for size_t Switch from board.h to config.h BRANCH=None BUG=b:247100970 TEST=zmake build -a TEST=./twister --clobber -v -i TEST=make -j72 buildall_only runtests TEST=zmake compare-builds Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I8d6c7cb89cd54812b90afd9ec06d81f8122fbdc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4053345 Reviewed-by: Tomasz Michalec <tmichalec@google.com> Commit-Queue: Tomasz Michalec <tmichalec@google.com> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * zephyr: skyrim: keyboard: Add KSO13 and KSO14 to pinctrlMadhurima Paruchuri2022-11-241-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As per schematic of skyrim, the KSO13 and KSO14 are functionally KSO default pins just like KSO12. To use them as similar to other KSO pins, they needs to be configured similar to KSO12. BUG=b:241734677 BRANCH=none TEST=zmake build skyrim --clobber Change-Id: Ied233ca2552a6e192c04f51b2dca9d83fc6aa310 Signed-off-by: Madhurima Paruchuri <mparuchuri@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4055740 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * zephyr: rt9490: merge charger and bc12 dt nodesTing Shen2022-11-2413-45/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Devices that using rt9490 has a warning message during build: Warning (unique_unit_address_if_enabled): /soc/i2c@f01c40/rt9490-bc12@53: duplicate unit-address (also used in node /soc/i2c@f01c40/rt9490@53) Fix the warning by merging the two conflicting nodes. BUG=none TEST=manually verified on tentacruel BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I098607b4c7321e4182b8ed37a229ee3ed2bfd973 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4010984 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Auto-Submit: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com>
| * magolor: delay one second when charger enter low power modeben chen2022-11-241-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | add delay one second waiting for charger enter low power mode BUG=b:259155418 BRANCH=none TEST=checking ec console don't power on until enter hibernate Change-Id: I56b5e1f84f32dc4dea69b0c53b45980cb9b741e7 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4050016 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * marasov: use default board_set_charge_limit implementationPeter Marheine2022-11-241-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The brya baseboard already configures the minimum current limit suitable for use with the default implementation. Delete the copy from this board. BUG=b:163093572 TEST=make buildall BRANCH=none Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: I84a0ddae7d46e70913f7d9b6753cd134bae19072 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4055000 Reviewed-by: Kyle Lin <kylelinck@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * kconfig: remove tablet mode config dependencyTing Shen2022-11-241-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Detachable device may use only GMR sensor or base attach signal to detect tablet mode. Lid angle is not required to enable tablet mode switch. Thus remove the lid angle -> table mode dependency. BUG=b:251747125 TEST=zmake build --all BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I49993bafb3f30d5eede359f509142f1618e24629 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4045300 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * pujjo: Add missing gyro config default-rangeAndrew McRae2022-11-241-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add missing default-range config properties for the lsm6dsm-gyro DTS. BUG=b:259551403 TEST=./twister -T zephyr/test/drivers BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Idaed21d75428aae93efd8d97252c63a6cded3ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4054384 Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by: Peter Marheine <pmarheine@chromium.org> Commit-Queue: Peter Marheine <pmarheine@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Tirath Ramdas <tirath@google.com>
| * marasov: Modify TypeC and TypeA configuration.Michael5 Chen12022-11-2410-253/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Depend on design, 1. Remove BC1.2 (USB_CHARGE, CHARGER_RAMP). 2. Remove TypeC port 2. 3. Change PPC to SYV682 for typeC port 1. 4. Support 2 USB TypeA ports. BUG=b:259002141,b:255184961 BRANCH=none TEST=make BOARD=marasov Signed-off-by: Michael5 Chen1 <michael5_chen1@pegatron.corp-partner.google.com> Change-Id: I8dbd75ffc8666b8931ef0e486e6e6a3ba6ac0c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4022557 Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: Kyle Lin <kylelinck@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * craask: add Fw_config structure for Keyboard backlightben chen2022-11-243-0/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Craask need to implement keyboard backlight fw config in bit 18 of cbi. Remove unused fw config and add the override ec feature function. BUG=b:257387315 BRANCH=none TEST=none. Change-Id: Iea0076b0024b9e387b392627fd4af337a0325830 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4050008 Reviewed-by: Andrew McRae <amcrae@google.com> Commit-Queue: Andrew McRae <amcrae@google.com> Tested-by: Andrew McRae <amcrae@google.com> Code-Coverage: Andrew McRae <amcrae@google.com>
| * Add default implementation of board_set_charge_limitPeter Marheine2022-11-24129-635/+111
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The majority of boards simply call charge_set_input_current_limit() from board_set_charge_limit() now that the minimum current limit and derating are available as config options. Make this the default behavior of the charge manager, overridable by boards as needed. Boards that have existing custom behavior retain it, with their versions of board_set_charge_limit() marked as __override as necessary. BUG=b:163093572 TEST=make buildall; zmake build -a BRANCH=none Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: I72475ca0e8381596cafbcda4b042c7f884ae0432 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4022857 Reviewed-by: Keith Short <keithshort@chromium.org>
| * dp-alt-mode: add safety checkBoris Mittelberg2022-11-241-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prevent possible NULL dereference BUG=b:64477774 BRANCH=none TEST=make buildall LOW_COVERAGE_REASON=No unit test infrastructure for this module Signed-off-by: Boris Mittelberg <bmbm@google.com> Change-Id: I1e42037d09ae41b8fc9acc611dd9fe2811e7f620 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4018490 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
| * Revert "zephyr: Remove CONFIG_PLATFORM_EC_WATCHDOG"Keith Short2022-11-246-7/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e04250319d222ef8505d9111ba4f03eddcaf5521. Reason for revert: Breaks drallion builds. b:260270232 Original change's description: > zephyr: Remove CONFIG_PLATFORM_EC_WATCHDOG > > Remove CONFIG_PLATFORM_EC_WATCHDOG. Use Zephyr's CONFIG_WATCHDOG option > instead. > > BUG=b:217926701 > BRANCH=none > TEST=twister -T zephyr/test/ > TEST=zmake compare-builds -a > LOW_COVERAGE_REASON=watchdog_init test not yet implemented > > Signed-off-by: Mark Hasemeyer <markhas@google.com> > > Change-Id: I7d5fedfc72ed886f94a94df9d3db14224bc6fb75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4050634 > Reviewed-by: Keith Short <keithshort@chromium.org> > Reviewed-by: Aaron Massey <aaronmassey@google.com> > Tested-by: Mark Hasemeyer <markhas@google.com> > Commit-Queue: Mark Hasemeyer <markhas@google.com> Bug: b:217926701 Change-Id: I01471b9544cc0792427b3ca6761fb07ee0432dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4053682 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Piotr Pawliczek <pawliczek@chromium.org> Tested-by: Keith Short <keithshort@chromium.org> Owners-Override: Piotr Pawliczek <pawliczek@chromium.org>
| * test: i2c: Verify I2C transfers with PEC rejectedKeith Short2022-11-241-0/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Verify that I2C transfers with PEC (packet error checking) are rejected when CONFIG_PLATFORM_EC_SMBUS_PEC=n. BUG=none BRANCH=none TEST=twister Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I6897ba3f65f28356a91f84bd872fcd013fa7b358 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4048916 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * test: i2c_passthru: Verify CONFIG_I2C_PASSTHRU_RESTRICTEDKeith Short2022-11-242-2/+124
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Verify I2C passthru commands are rejected when the CONFIG_I2C_PASSTHRU_RESTRICTED option is enabled. BUG=none BRANCH=none TEST=twister Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: If6a5e024d91a65d87362025da6c1bc0e70b212f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4048915 Reviewed-by: Simon Glass <sjg@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Tristan Honscheid <honscheid@google.com>
| * i2c_controller: Add guard for PEC transfersKeith Short2022-11-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | One path in the code was missing a guard checking CONFIG_SMBUS_PEC before checking the I2C_USE_PEC. The gcc optimizer already removed this code when CONFIG_SMBUS_PEC=n, but the coverage tool thought this path was executable. BUG=none BRANCH=none TEST=twister TEST=zmake compare-builds herobrine Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I9c5f95982ba7428fd190f98e16801886bc8aedeb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4049220 Reviewed-by: Sam Hurst <shurst@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * test: i2c_controller: Verify i2c_field_update16() errorsKeith Short2022-11-241-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Verify the error path for i2c_field_update16(). BUG=none BRANCH=none TEST=twister Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I6efb4742baafa881066e910a3fcbc16341874332 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4045153 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Yuval Peress <peress@google.com>
| * test: i2c_controller: i2c_write16Keith Short2022-11-241-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a test for the big-endian path for the i2c_write16() function. BUG=none BRANCH=none TEST=twister Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I08cae4b3fdedfe9516d3846dd01085c9fb2d3757 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4045152 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Aaron Massey <aaronmassey@google.com>
| * nissa: Configure mux resets for ANX7483Andrew McRae2022-11-243-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The ANX7483 is only turned on in S5 state and higher, and will default to a high power consumption state. Following the skyrim change, set the flag to indicate that the mux resets in G3 to ensure the USB mux code resets it to None. BUG=none TEST=Check on nivviks that the control register is set to the correct value (same as at startup) after the AP goes to G3 and is then rebooted. BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I011bcb32028de85153e4c738da999e40624a22ef Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4050001 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
| * tcpm_header: add missing RESET_FAKE callsClayton Whitelaw2022-11-231-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Each mock should be reset before each test to guarantee its state. That was missing from some of these fakes. BUG=none BRANCH=none TEST=twister Signed-off-by: Clayton Whitelaw <cawhitelaw@google.com> Change-Id: Ie10fe951d07d278147c4fda2c46da5c922eb8af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4052765 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Simon Glass <sjg@chromium.org>
| * run_device_tests.py: Resolve error in type hintBobby Casey2022-11-231-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve the error in find_section_offset's type hint, it should be Tuple(int, int) rather than (int, int) BUG=b:250028913 TEST=./test/run_device_tests.py -b bloonchipper --flasher=servo_micro BRANCH=none Signed-off-by: Bobby Casey <bobbycasey@google.com> Change-Id: I88e86b14efb0fc6f7a39d0c19c83a44d8eb0b975 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3931127 Reviewed-by: Andrea Grandi <agrandi@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * zephyr: twister: Optimization - Reduce test search scopeTristan Honscheid2022-11-231-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently we ask twister to search the entire EC directory for testcase.yaml files, which takes nearly 3 seconds according to the profiler (this figure is also influenced by how many build artifacts and other stuff a developer may have in that directory). This CL limits the search scope to directories we know have testcase.yaml files. The os.walk() phase now takes negligible time. BRANCH=None BUG=b:259442204 TEST=./twister and checking that 89 scenarios are run Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: Ibfc5ce9aa976cc3527d7c168bd0b29ff531ef46c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4031147 Reviewed-by: Yuval Peress <peress@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * baseboard: Remove unused externsJeremy Bettis2022-11-232-36/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The symbols zork_base_standard_ref and grunt_base_standard_ref are never actually defined or used anywhere. BRANCH=None BUG=b:247100970 TEST=zmake build -a TEST=./twister --clobber -v -i TEST=make -j$(nproc) buildall_only runtests TEST=zmake compare-builds Change-Id: I1425ceb38f1de45e50c98f86f4df4221602120e0 Signed-off-by: Jeremy Bettis <jbettis@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4049881 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Simon Glass <sjg@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org>
| * zephyr: Remove CONFIG_PLATFORM_EC_WATCHDOGMark Hasemeyer2022-11-236-24/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove CONFIG_PLATFORM_EC_WATCHDOG. Use Zephyr's CONFIG_WATCHDOG option instead. BUG=b:217926701 BRANCH=none TEST=twister -T zephyr/test/ TEST=zmake compare-builds -a LOW_COVERAGE_REASON=watchdog_init test not yet implemented Signed-off-by: Mark Hasemeyer <markhas@google.com> Change-Id: I7d5fedfc72ed886f94a94df9d3db14224bc6fb75 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4050634 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Aaron Massey <aaronmassey@google.com> Tested-by: Mark Hasemeyer <markhas@google.com> Commit-Queue: Mark Hasemeyer <markhas@google.com>
| * zephyr: test: Bring virtual_battery_handler() to 100% coverageTristan Honscheid2022-11-232-3/+150
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cover all remaining code paths in virtual_battery_handler() in common/virtual_battery.c BRANCH=None BUG=None TEST=./twister Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: Ib510b7c76eca7daf8e9824c486afd391ad1b5d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4036107 Commit-Queue: Aaron Massey <aaronmassey@google.com> Reviewed-by: Aaron Massey <aaronmassey@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * baseboard: Move conditional includes to endJeremy Bettis2022-11-231-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move the zephyr only headers to be last, so the others will sort correctly with clang-format. BRANCH=None BUG=b:247100970 TEST=zmake build -a TEST=./twister --clobber -v -i TEST=make -j$(nproc) buildall_only runtests TEST=zmake compare-builds Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I88211638be6ee1d3558a42e641d7c1882d7294cc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4049880 Reviewed-by: Aaron Massey <aaronmassey@google.com> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Jeremy Bettis <jbettis@chromium.org>
| * tcpm_header: add more driver call-through testsClayton Whitelaw2022-11-231-6/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These functions call the driver's implementation only if present. Added tests for both cases where the driver does and does not implement these functions. Functions tested: - tcpm_debug_accessory - tcpm_debug_detach - tcpm_hard_reset_reinit BUG=none TEST=twister, verify lines are now covered BRANCH=none Signed-off-by: Clayton Whitelaw <cawhitelaw@google.com> Change-Id: I26e1cdb74f1ed3f08065a301081561a764322bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4048912 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Yuval Peress <peress@google.com>
| * zephyr test: Exercise CT-VPD supportAbe Levkoy2022-11-236-0/+213
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Verify that the TCPM detects and connects to a charge-through VCONN-powered device. BUG=b:257341564 TEST=twister -s zephyr/test/drivers/drivers.usbc_ctvpd BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I2afe7b4c2a60fd7411e46345776b6a1e3d73a70e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4025831 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Aaron Massey <aaronmassey@google.com> Reviewed-by: Yuval Peress <peress@google.com>
| * TCPMv2: Present as Sink/UFP in CTAttached.SNKAbe Levkoy2022-11-231-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the Type-C state machine, set the data role to UFP after attaching to the charge-through port of a CT-VPD. This keeps the data role consistent with the Sink power role and conforms to USB Type-C specification release 2.2 ss 4.10.2. BUG=b:257341564 TEST=twister -s zephyr/test/drivers/drivers.usbc_ctvpd BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: Ic94145ef08c3e1ce7094891d8686ce2858a13476 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4043737 Reviewed-by: Sam Hurst <shurst@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * TCPMv2: Disallow VCONN Swap in CTAttached.SNKAbe Levkoy2022-11-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In PE_VCS_Evaluate_Swap, reject a VCONN Swap when the Type-C SM does not allow it (when the Type-C state is CTAttached.SNK). Give this setting precedence over the PE logic to allow VCONN Swap if the TCPM is VCONN Source in the general case. BUG=b:257341564 TEST=twister -s zephyr/test/drivers/drivers.usbc_ctvpd BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I2042e5ce5c7694d0efd11b6e7f3c4a14d703676d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4043736 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Sam Hurst <shurst@google.com>
| * zephyr: usb: enable pi3usb9201 driver and emulator automaticallyFabio Baltieri2022-11-2313-15/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enable the PLATFORM_EC_BC12_DETECT_PI3USB9201 and EMUL_BC12_DETECT_PI3USB9201 based on the devicetree configuration. The two drivers use the same compatible so the emulator one is set so it can only be enabled in testing. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Id4438d2af72c46ecf5c47c2d347dfb8bb74a0a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4051187 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
| * zephyr: tests, emul: add a bunch of automatic configsFabio Baltieri2022-11-2316-40/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rework various emul drivers to use an automatic Kconfig and drop few explicitly prj.conf entries, plus some that were already redundant from upstream. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I1e81e310248070dc619012f69663d044f329f249 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4047461 Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * zephyr: test: Test apreset and apshutdown console commandsTristan Honscheid2022-11-232-1/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Test the console commands `apreset` and `apshutdown` and confirm a reset/shutdown occurred. BRANCH=None BUG=None TEST=./twister Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: I63fccfdc07a940d172c70a8d24500e89004a32f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4027085 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
| * zephyr: mtlrvp: Add DC jack present GPIO interruptBernardo Perez Priego2022-11-232-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When DC jack is providing power, it takes higher supplier priority and inhibits system from charging using any other Type-C port. This CL will enable detecting DC jack connection during run time and not only initialization time. BUG=None BRANCH=None TEST=Boot MTL RVP with DC jack connected Disconnect DC jack Connect Type-C charger Type-C should charge MTL RVP Signed-off-by: Bernardo Perez Priego <bernardo.perez.priego@intel.com> Change-Id: I13b292658bbcc28e11585679f60d5c014d3da302 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4045034 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Code-Coverage: Abe Levkoy <alevkoy@chromium.org> Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
| * dps: improve option documentationPeter Marheine2022-11-231-5/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | DPS can behave badly (and is likely to do so) if the configuration doesn't match actual system characteristics. Existing platforms using DPS seems to all use the same configuration (possibly because they use the same charger), but the need for correct configuration could be made clearer. This rewords the kconfig help for DPS enablement to better describe what it will do, and what is necessary for a platform to make it work well. BUG=b:259859051 TEST=zmake build -a BRANCH=none Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: I481be89d8a00b90e15d01a5c7c8eedbbf057589e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4044793 Reviewed-by: Edward Hill <ecgh@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * cq: Build extra/rma_reset in CQJeremy Bettis2022-11-231-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The ebuild chromeos-base/ec-utils-test depends on extra/rma_reset but the EC CQ doesn't build it. Add make commands to CQ script to build extra/rma_reset. BRANCH=None BUG=b:247100970 TEST=CQ Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I540593056de9fdbea231eefa7dab27b4ad8d5f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4049882 Tested-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| * Add CONFIG_CHARGER_MIN_INPUT_CURRENT_LIMITPeter Marheine2022-11-23156-253/+243
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This splits the dual use of CONFIG_CHARGER_INPUT_CURRENT into two different symbols, changing the uses of that which are used to set a minimum current limit to be CONFIG_CHARGER_MAX_INPUT_CURRENT_LIMIT. Most boards implement this in the same way within either the board or baseboard, so handling of the new option is moved into charge_set_input_current_limit (which is called by every user of the option) and every board which repeated this pattern has the new symbol set to the same value as the old one, with the duplicated code deleted. One functional change to the charge manager is made: when charging stops, the input current limit is set to the default value (CONFIG_CHARGER_INPUT_CURRENT) rather than 0. This captures the intent that the default current is appropriate at any time, which was previously configured by individual boards' implementation of board_set_charge_limit() while still allowing the limit to be set lower as needed. To verify that all changes are appropriate, the following has been manually checked: * All boards with a change to a .c file also have a .h change * All boards without a changed .h file have a changed baseboard.h * For Zephyr projects, those with a changed .c file have config added for the minimum limit and others (only corsola) are unchanged to leave it off. This is intended to verify that each board that duplicated the MAX() logic has its configuration updated to use the shared copy, and that boards with that code in the baseboard also update their configuration. BUG=b:163093572 TEST=make buildall; zmake build -a BRANCH=none LOW_COVERAGE_REASON=added lines will soon be deleted Change-Id: Ia460a16293c1fb82aac3784fd9be57ba0985f2fe Signed-off-by: Peter Marheine <pmarheine@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4019703 Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
View Lorry Controller Status