summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* chip/mt_scp: remove gpio configurationfactory-cherry-14455.B-mainTinghan Shen2022-08-182-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The UART console is mainly for debug purpose. Remove it to prevent malicious usage of this interface. If required, a user can configure the pin mux by kernel dts. Take mt8195 as an example to enable the SCP UART in dts, scp_pins: scp { pins_scp_vreq { pinmux = <PINMUX_GPIO76__FUNC_SCP_VREQ_VAO>; bias-disable; input-enable; }; + + pins_uart { + pinmux = <PINMUX_GPIO102__FUNC_TP_UTXD1_AO>, + <PINMUX_GPIO103__FUNC_TP_URXD1_AO>; + bias-pull-up; + }; }; -- Conflicts on branch factory-cherry-14455.B-main: There's no mt818x folder on this branch. Remove changes for chip/mt_scp/mt818x/uart.c from original CL:3791283 -- BUG=none TEST=boot cherry scp ok. scp boot log still records in /var/log/cros_scp.log Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> Change-Id: I37bc65b47e7423e9def5a399ba7ceb2761dc9615 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3791283 Tested-by: TingHan Shen <tinghan.shen@mediatek.corp-partner.google.com> Reviewed-by: Wei-Shun Chang <weishunc@chromium.org> Commit-Queue: Wei-Shun Chang <weishunc@chromium.org> (cherry picked from commit 2e68f3ee03f51fb0a3f8c0cad6868b2f1fb34a5a) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3835234
* ectool: support dps enable/disable commandEric Yilun Lin2022-03-163-0/+55
| | | | | | | | | | | | | | | | | | | | | | Support dps host command for factory test. BUG=b:223937130 TEST=ectool usbpddps disable|enable BRANCH=cherry Change-Id: I050c724b5caab41644248a6f72704edbc76554a0 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3522247 Tested-by: Eric Yilun Lin <yllin@google.com> Auto-Submit: Eric Yilun Lin <yllin@google.com> Reviewed-by: Rong Chang <rongchang@chromium.org> Commit-Queue: Rong Chang <rongchang@chromium.org> (cherry picked from commit 00b93c2d75ee4b52e2a7f07230be2142a5dd486f) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3525640 Reviewed-by: Yu-An Wang <wyuang@google.com> Commit-Queue: Yu-An Wang <wyuang@google.com> Reviewed-by: Chen-Tsung Hsieh <chentsung@chromium.org> Commit-Queue: Chen-Tsung Hsieh <chentsung@chromium.org>
* primus: fix Goodix touchpad initialize failedScott Chao2022-01-132-4/+20
| | | | | | | | | | | | | | | | | | | Goodix touchpad AVDD need to pull low to 0V when poweroff. Setting PS2 module in GPIO.inc will let AVDD have 0.9V offset. So we need to enable PS2 module later than PLTRST# to avoid the 0.9V offset. BUG=b:214150759 BRANCH=none TEST=make -j BOARD=primus TEST=verified by Goodix Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: I49869d26262948f7f7242ebe494eef86e459a42c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3376688 Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* volmar: Modify USB type-c configurationYu-An Chen2022-01-135-224/+30
| | | | | | | | | | | | | | | Change C0 TCPM to RT1715 Change C1 PPC to syv682x Remove C2 function BUG=b:211891086 BRANCH=none TEST=boot on kano, check pd 0 can switch to 20V Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: I12c07e19e969a1a7c31fc357e2d8ab0ee50093f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3385875 Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* zephyr: battery: Separate battery conf from chargerRajesh Kumar2022-01-133-11/+13
| | | | | | | | | | | | | | | | | | | | | | Removing dependecy of PLATFORM_EC_BATTERY_FUEL_GAUGE from PLATFORM_EC_CHARGER by moving this out from 'if PLATFORM_EC_CHARGER' zephyr/shim/src/battery.c belongs to PLATFORM_EC_BATTERY, and it should be part of source if PLATFORM_EC_BATTERY conf is enabled instead of PLATFORM_EC_BATTERY_FUEL_GAUGE. BUG=none BRANCH=none TEST=zmake testall TEST=zephyr/shim/src/battery.c and common/battery_fuel_gauge.c is included in source list and compilation is successful if we enable battery without enabling charger. Signed-off-by: Rajesh Kumar <rajesh3.kumar@intel.com> Change-Id: I419502281e8f22c710119a76eacf4e3bfca3a3ca Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3384477 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* volmar: Add battery AP19B8MYu-An Chen2022-01-132-1/+31
| | | | | | | | | | | | | Add battery AP19B8M for early stage support BUG=b:213127419 BRANCH=none TEST=make BOARD=volmar Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: If4aa3075d6d892be8378d4cb056ddaed46427fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3385876 Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* zephyr: adc: switch to using io-channelsDawid Niedzwiecki2022-01-1319-75/+75
| | | | | | | | | | | | | | | | | | | | | | | There is a special property named "io-channels" which can be used to specify ADC module and channel. Switch to use the "io-channels" property in the named-adc-channels node instead of custom "channel" property. The "io-channels" also specifies the ADC module, so there is no more need of choosing "cros-ec,adc" in dts files. BUG=b:213210342 TEST=zmake testall && make sure the 'adc' console command shows correct values BRANCH=main Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: I8b5b6a46ad6141fb0446cb9051cfd4eaa0c732fe Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3379806 Tested-by: Dawid Niedźwiecki <dn@semihalf.com> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* power: Change power_signal_get_level prototype to override_protoBernardo Perez Priego2022-01-131-1/+1
| | | | | | | | | | | | | | | | | Observed issue where function was not being overridden when building Madoo with Zephyr EC, also __override_proto seems more consistent. BUG=b:203184102 BRANCH=None TEST=`make -j buildall` Tested on Madoo, observed overridable function is called. Signed-off-by: Bernardo Perez Priego <bernardo.perez.priego@intel.com> Change-Id: I0083270036648ec16ac6fbcc433013aa17675220 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3363438 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* scout: Enable mics on boards without EC_MIC_OE in ROStefan Adolfsson2022-01-131-0/+6
| | | | | | | | | | | | | | | | RW firmware does not initialize GPIOs, so the GPIO needs to be set explicitly. BUG=b:214228751 BRANCH=puff TEST=Measure EC_MIC_OE with oscilloscope. Change-Id: Ifbc77b18ef11816fd2f443abb9ac6b502524c1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3386837 Reviewed-by: Joe Tessler <jrt@chromium.org> Auto-Submit: Stefan Adolfsson <sadolfsson@chromium.org> Tested-by: Stefan Adolfsson <sadolfsson@chromium.org> Commit-Queue: Stefan Adolfsson <sadolfsson@chromium.org>
* docs/fingerprint: Update JLink installation instructionsTom Hughes2022-01-131-13/+20
| | | | | | | | | | | | | | JLink can now be installed in the chroot with portage. BRANCH=none BUG=b:178132109 TEST=view in gitiles Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Ief8e64e10c9ff1f8cfdc528dce6bca34d3973f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3369648 Reviewed-by: Josie Nordrum <josienordrum@google.com> Reviewed-by: Bobby Casey <bobbycasey@google.com>
* guybrush: Use ioex gpio save and restore functionsRob Barnes2022-01-131-23/+22
| | | | | | | | | | | | | | | Use common ioex_save_gpio_state and ioex_restore_gpio_state functions to save and restore gpio state after ioexpander is reset. BUG=b:211062040 BRANCH=None TEST=gpio state restored on nipperkin. USBA0/1 works after hibernate and wake from AC. Change-Id: I548adb46b5d96b0712382e0fac68b6854ed0af0f Signed-off-by: Rob Barnes <robbarnes@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3368322 Reviewed-by: Diana Z <dzigterman@chromium.org>
* ioexpander: Introduce GPIO save and restore functionsRob Barnes2022-01-132-0/+74
| | | | | | | | | | | | | | Add common ioexpander functions for saving a restoring GPIO state. This is useful for restoring GPIO after the ioexpander is reset. BUG=b:211452276 BRANCH=None TEST=ioexpander state restored on nipperkin Change-Id: Id81c5457f1c33fdf7490a963317e11a2b9441831 Signed-off-by: Rob Barnes <robbarnes@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3368321 Reviewed-by: Diana Z <dzigterman@chromium.org>
* zephyr: Add qcom.c to test/driversJeremy Bettis2022-01-134-43/+101
| | | | | | | | | | | | | | | | Add the necessary Kconfigs to make qcom.c get included into test/drivers as well as required gpios and stubs and other dependencies. BRANCH=None BUG=b:214256453 TEST=zmake testall Change-Id: Ief5ab7e1e30810946ef4967ae65fa48e4c4a9220 Signed-off-by: Jeremy Bettis <jbettis@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3384479 Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org>
* stm32/hwtimer32: Clear status register after counter is setPatryk Duda2022-01-131-0/+13
| | | | | | | | | | | | | | | | | | | | Whenever a timer interrupt occurs, the status register is checked for overflow and the overflow status is passed to process_timers(), which increments clksrc_high. When setting the clock to a new time, we don't want the previous overflow state to trigger this process. To avoid this problem, just clear status register when new value is assigned to counter. To avoid race between updating counter and clearing status, operation is performed when counters are disabled. BUG=b:200828093 BRANCH=none TEST=make -j buildall Signed-off-by: Patryk Duda <pdk@semihalf.com> Change-Id: Ief65ac86fcf5c164f99855cc08c96c2ceddb29ea Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3347657 Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* clock-stm32h7: Check if deep sleep time is less than watchdog periodPatryk Duda2022-01-131-0/+9
| | | | | | | | | | | | | | | | If we go to deep sleep for longer than CONFIG_WATCHDOG_PERIOD_MS, then watchdog will wake us from sleep which is not what we want. Please note that there will be no information where watchodg was triggered, because timers are stopped in stop mode. BUG=b:200828093 BRANCH=none TEST=make -j buildall Signed-off-by: Patryk Duda <pdk@semihalf.com> Change-Id: Icc9bbf14c7dbfad4cb614efb6f01948b07c6c89a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3347654 Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* clock-stm32f4: Check if deep sleep time is less than watchdog periodPatryk Duda2022-01-131-0/+9
| | | | | | | | | | | | | | | | If we go to deep sleep for longer than CONFIG_WATCHDOG_PERIOD_MS, then watchdog will wake us from sleep which is not what we want. Please note that there will be no information where watchodg was triggered, because timers are stopped in stop mode. BUG=b:200828093 BRANCH=none TEST=make -j buildall Signed-off-by: Patryk Duda <pdk@semihalf.com> Change-Id: I8714517ee2093e07de8d40e064224d11466d6d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3347653 Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* zephyr: kingler: add missing GPIO enum-nameEric Yilun Lin2022-01-131-0/+1
| | | | | | | | | | | | | | | | This was missing in the previous GPIO dts config. BUG=b:203739613 TEST=zmake BRANCH=none Change-Id: I5bde321ebad973cd8d400cd17c6dfaa452efd262 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3384123 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com> Auto-Submit: Eric Yilun Lin <yllin@google.com>
* zephyr: kingler: add isl9238 node in dtsEric Yilun Lin2022-01-131-0/+6
| | | | | | | | | | | | | | | | This is not needed yet, just for consistency, and easier for migrating to dts config in the future. BUG=b:203739613 TEST=zmake BRANCH=none Change-Id: I44710aa155a31c9475884560ebd457edc7f7479e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3384122 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com> Auto-Submit: Eric Yilun Lin <yllin@google.com>
* zephyr: kingler: enable PSLEric Yilun Lin2022-01-131-0/+1
| | | | | | | | | | | | | | | | We use the VSBY to wake EC so enable this config. BUG=b:203739613 TEST=make BRANCH=none Change-Id: If8b2e2d524d599586f5a5ad77f3cb3ce12e1f371 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3384121 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com> Auto-Submit: Eric Yilun Lin <yllin@google.com>
* volmar: Remove unused adc channelYu-An Chen2022-01-136-94/+4
| | | | | | | | | | | | | Remove unused adc channel BUG=b:211891086 BRANCH=none TEST=make BOARD=volmar Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: Ie6fafd1c6538c2c4f87e3c18857fc6f0f2a83a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3382610 Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* docs/fingerprint: Add FPMCU RAM and Flash docTom Hughes2022-01-133-0/+114
| | | | | | | | | | | | | | | This document provides details on the RAM and Flash available on each of the FPMCUs, as well as the Flash layout. BRANCH=none BUG=b:213510520 TEST=view in gitiles Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Id34399327baaeeac8c03a5fcfe3983824e69497a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3369652 Reviewed-by: Josie Nordrum <josienordrum@google.com> Commit-Queue: Josie Nordrum <josienordrum@google.com>
* volmar: Remove als tcs4300Yu-An Chen2022-01-135-116/+3
| | | | | | | | | | | | Remove als tcs4300 function BUG=b:211891086 BRANCH=none TEST=make BOARD=volmar Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: I9c3a9426acc1d68cf6ab1d6187783b1e0f4643a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3382606 Reviewed-by: caveh jalali <caveh@chromium.org>
* Quackingstick: remove unused tcpm product idSue Chen2022-01-132-11/+0
| | | | | | | | | | | | | | | | Quackingstick doesn't use TCPM PS8755. Remove board_get_ps8xxx_product_id() in board.c for only use PS8805. BUG=b:205163599 BRANCH=trogdor TEST="ectool pdchipinfo 0" show correct device_id on rev2 board. Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I4eedf35bb3e5058992f0d14b43faf88cbeb40346 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3354787 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* zephyr: ioex: Fix crash when cros ioex drivers disabledRajesh Kumar2022-01-131-0/+3
| | | | | | | | | | | | | | | | | | EC crash in ioex_init() if the following Kconfig options are set: CONFIG_PLATFORM_EC_IOEX=y CONFIG_PLATFORM_EC_IOEX_CROS_DRV=n returning EC_SUCCESS if CONFIG_PLATFORM_EC_IOEX_CROS_DRV is not enabled. BUG=none BRANCH=none TEST=zmake testall Signed-off-by: Rajesh Kumar <rajesh3.kumar@intel.com> Change-Id: I51e83b14e46efd605e23922c9025a1aaa03f1098 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3384475 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* brya: fix the formula of adapter wattageWill Tsai2022-01-131-1/+1
| | | | | | | | | | | | | BUG=b:212359724, b:212363905 BRANCH=none TEST=make -j BOARD=gimble Signed-off-by: Will Tsai <will_tsai@wistron.corp-partner.google.com> Change-Id: I8f2ee2a5e0bce9d1a231070fb284f231c47814cc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3382607 Reviewed-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* nissa: Remove PPC, fix task event sendAndrew McRae2022-01-134-12/+27
| | | | | | | | | | | | | | | | | | | | Remove PPC references. Fix task event send to charger task. Add support for checking port count in interrupts. Fix PPC config conditional so that other options are available. Sometimes there still seems to be a loop when the board is restarted with a battery and power from a servo on port 0, but this may be a servo issue. BUG=b:213835377 TEST=zmake configure -b nivviks; flash and run BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I3fcd53f32a9fba894018538e12458ec9ae811075 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3379790 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* ec: Exclude more flaky tests from coverageJeremy Bettis2022-01-131-0/+9
| | | | | | | | | | | | | | | | | | These ~20 tests cover a different number of lines on different runs. Until the test can be changed to be stable or another test can added cover all those flaky lines. BRANCH=None BUG=b:213374060 TEST=Ran make test-coverage over and over Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I2a8ef218bc3172a71777ff222b2b5a8e6c231a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3384480 Tested-by: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Kshitij Shah <tij@google.com> Commit-Queue: Kshitij Shah <tij@google.com>
* ec: Add .gdb_history to .gitignoreJeremy Bettis2022-01-121-0/+1
| | | | | | | | | | | | | | | | Add .gdb_history to .gitignore. BRANCH=None BUG=None TEST=None Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: Ibb52970914fe8e68aa7b1bc6700a03aae3a6bc42 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3384481 Tested-by: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
* zephyr: Change power_common tests to avoid tasksJeremy Bettis2022-01-126-92/+71
| | | | | | | | | | | | | | | | | | | | | | | | Change test_power_exit_hard_off and test_power_reboot_ap_at_g3 to run before ec_app_main, to avoid background tasks. Remove force_power_state from stubs. I plan to remove more code from stubs and replace it with real code from qcom.c, and force_power_state is one of the things that needs to be deleted. BRANCH=None BUG=b:214256453 TEST=zmake testall Change-Id: I022344b1352e0daebf3d12ba623bc78b79f6f2ff Signed-off-by: Jeremy Bettis <jbettis@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3384478 Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Aaron Massey <aaronmassey@google.com> Commit-Queue: Aaron Massey <aaronmassey@google.com>
* zephyr: Update power policy for API changeKeith Short2022-01-122-6/+6
| | | | | | | | | | | | | | | | | Upstream Zephyr modified the prototype for pm_policy_get_next_state(). Update both the npcx and ite implementations to match the new API. BUG=none BRANCH=none TEST=zmake testall TEST=On Volteer (NPCX), verify entry into deep sleep after suspending the AP. Cq-Depend: chromium:3380765 Change-Id: I4e0e2f59ade77aa052841fa4c1866b05c081ea0c Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3384476 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* zephyr: zmake: Add a README.md file generated from command structureJack Rosenthal2022-01-126-3/+384
| | | | | | | | | | | | | | | | | | | Generate a readme file from the command structure and arguments. This file gets checked that it matches the generated contents in the commit queue using a new command "zmake generate-readme --diff". Right now this file only has the commands, but could possibly be extended in the future, for example, to document `BUILD.py` functions. BUG=b:180609783 BRANCH=none TEST=View readme in gitiles TEST=Added unit tests Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: Ie8ed39b30ce2a58c91b2cf8e48b0426fb9b4f2e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3382480 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: zmake: Clean up metavar for subcommand positionalJack Rosenthal2022-01-121-1/+5
| | | | | | | | | | | | | | Setting a metavar here clears up the usage text slightly. Also expand out on that help string slightly. BUG=b:180609783 BRANCH=none TEST=output of "zmake --help" Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I44c65ddaaa19beec0bc485771f199882262fa60a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3382479 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: zmake: Separate out the argument parser from main functionJack Rosenthal2022-01-121-11/+21
| | | | | | | | | | | | | | | | Move the code which generates the argument parser to a separate function, get_argparser. This is intended that we can access the argument parser to generate documentation about zmake's options and subcommands. BUG=b:180609783 BRANCH=none TEST=unit tests pass Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I1f14aa4e298d0ec47fb51e7b3bfad52bab990e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3382478 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* ec: Don't generate coverage for test_run_mutistepJeremy Bettis2022-01-121-0/+2
| | | | | | | | | | | | | | | | | | Tests that use test_run_mutistep have persistent data between runs, and are flaky. Exclude them from the coverage report. BRANCH=None BUG=b:213374060 TEST=while : ; do make clobber &>/dev/null ; \ make -j8 test-coverage &>/dev/null; \ lcov --summary build/coverage/lcov.info; done Change-Id: Ie509191095941532d3c134ca4e35cd1a7633dd10 Signed-off-by: Jeremy Bettis <jbettis@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3381537 Reviewed-by: Kshitij Shah <tij@google.com> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: Use SYS_INIT to setup espiJeremy Bettis2022-01-123-14/+4
| | | | | | | | | | | | | | | | | | | | | | | Move zephyr_shim_setup_espi call from ec_app_main to SYS_INIT at priority APPLICATION-0. The hook update_mapped_memory in common/temp_sensor.c calls host_get_memmap, which if CONFIG_HOSTCMD_X86 calls lpc_get_memmap_range which calls espi_read_lpc_request, which will fail if zephyr_shim_setup_espi() hasn't been called yet. Hooks are started in SYS_INIT at priority APPLICATION-1. BRANCH=None BUG=b:214099043 TEST=zephyr/test/drivers with some local mods Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I0938b757232e2eb983fcf3014d3ab532e64aa699 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3381900 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: docs: Remove news section from README.mdJack Rosenthal2022-01-121-9/+0
| | | | | | | | | | | | | | | | | This section hasn't been updated in a long time, and the only thing here is extremely irrelevant today (how to build with Zephyr v2.4). Delete the section so we don't cause any confusion. BUG=none BRANCH=none TEST=view in gitiles Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I85682e6708751e6f4e867fa8a22391b8d5261b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3381048 Reviewed-by: Yuval Peress <peress@google.com> Commit-Queue: Yuval Peress <peress@google.com>
* scout: set microphone enable high per defaultStefan Adolfsson2022-01-121-0/+1
| | | | | | | | | | | | | | | | | Just trusting the pull-ups seems to not be enough. We are still seeing some missing microphones during acoustic testig. EE recommends to pull it high from the EC. BUG=b:214228751 BRANCH=puff TEST=Measure EC_MIC_OE with oscilloscope and sent before and after pictures to EE. Change-Id: I9d67b1841341679531ca415990b7b1fcec9ebc0c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3382983 Reviewed-by: Joe Tessler <jrt@chromium.org> Tested-by: Joe Tessler <jrt@chromium.org> Commit-Queue: Stefan Adolfsson <sadolfsson@chromium.org>
* krabby/kingler: set HPD pin to 1.8VTing Shen2022-01-122-2/+2
| | | | | | | | | | | | | | | | This is a typo in the gpio spreadsheet. Should be 1.8V for both devices. BUG=none TEST=`gpioset ec_ap_dp_hpd_odl 0|1` works BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: Ie7246256b5d1ca2763122fad1cacf8e8ea0dfdf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3382101 Tested-by: Ting Shen <phoenixshen@chromium.org> Auto-Submit: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com>
* phaser: add psl code back for some sku requestarthur.lin2022-01-121-1/+90
| | | | | | | | | | | | | | | | | Add the the PSL code to the phaser's board.c file, and use sku id to distinguish for enter PSL or not. BUG=b:203442963 BRANCH=None TEST=make buildall -j In Phaser, keep KSI1, KSI2, and KSI3 on when system in hibernate In Laser, only KSI2(powered by H1) on when system in hibernate. Signed-off-by: arthur.lin <arthur.lin@lcfc.corp-partner.google.com> Change-Id: I55ee776d5fd4c500511ee14f0715c3850a4e16d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3372133 Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Henry Sun <henrysun@google.com>
* Krabby: enable base sensor icm42607Ting Shen2022-01-123-24/+26
| | | | | | | | | | | | | | BUG=b:211845298 TEST=1) zmake 2) accelread 1 BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I7f463821fb6ebcf8afa7d42bf70ff8e6375aae47 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3246995 Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* common/tablet_modet: Fix EC command tabletmode reset statusSiyu Qin2022-01-121-0/+6
| | | | | | | | | | | | | | | | | | | | EC console command "tabletmode on" will lock the table mode status, when the project use TABLET_TRIGGER_BASE to set table mode. Add a variable to store tablet mode to sovle this problem. BUG=b:205611452 BRANCH=trogdor TEST=1.Use detachable keyboard attach to DUT 2.Enter "tabletmode on" in EC console 3.Enter "tabletmode reset" in EC console Then the system can switch to "tablet disable" mode. Change-Id: Ifb9fbbe2c0c0fb6201af0a7fc6f2541a4ff74ff2 Signed-off-by: Siyu Qin <qinsiyu@huaqin.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3269867 Reviewed-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com> Reviewed-by: Wai-Hong Tam <waihong@google.com> Reviewed-by: Bob Moragues <moragues@chromium.org>
* redrix: Disable haptic pad LRA if battery is over currentDevin Lu2022-01-123-1/+30
| | | | | | | | | | | | | | | | This patch adds a protection method to turn off haptic pad LRA while battery overloading. Since the haptic pad LRA has around 20W while clicking. To prevent battery over current we are disabling the LRA temporarily. BUG=b:207459805 BRANCH=none TEST=Verify system is not brownout on heavy loading. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: I5b82e8042e56a6f58241ff6cf629c4cf4d49c3c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3353047 Reviewed-by: caveh jalali <caveh@chromium.org>
* zephyr: docs: Use project names for zmake commandsJack Rosenthal2022-01-123-13/+13
| | | | | | | | | | | | | | | | Switch documentation referring to the project path of a zmake build to project name. Project path is still technically supported, but only for project directories with exactly one project defined, which will become fewer and fewer as we start launching real EC projects. BUG=b:193815337 BRANCH=none TEST=view in gitiles Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: Ia2c50363874b8997a8308bbf304f9773965086c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3381044 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* zephyr: docs: Drop "-t zephyr" from configure commandJack Rosenthal2022-01-121-11/+1
| | | | | | | | | | | | | | | | "-t zephyr" was needed at one point for folks building outside of the chromiumos chroot only. Today, zmake can automatically detect which toolchains are available and select the most appropriate one, so we can remove the extra steps here. BUG=b:178731498 BRANCH=none TEST=view in gitiles Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I9a70027a1183782566ca4bc37f3e63e142f71b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3381043 Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: docs: Cleanup notes about updating the chrootJack Rosenthal2022-01-121-18/+6
| | | | | | | | | | | | | | | | | | This was written before Zmake's re-exec logic, which was the primary reason we cautioned people to update the chroot or manually install zephyr-build-tools so often. Today, an update_chroot is still necessary for a toolchain update, but this happens far less often and does not need noted here. BUG=b:197636145 BRANCH=none TEST=view in gitiles Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I8e06ffa38f3501f5f2da5e390e3d55c3b1a5b3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3381042 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* zephyr: brya: cleanup gpio.dtsRajesh Kumar2022-01-121-5/+0
| | | | | | | | | | | | | Deleted non required new line from named-gpios BUG=none BRANCH=none TEST=zmake testall Signed-off-by: Rajesh Kumar <rajesh3.kumar@intel.com> Change-Id: If4a46e3417d08abbb70c1065064ea4a08624d4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3378886 Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: brya: Enable keyboard configurationRajesh Kumar2022-01-124-1/+22
| | | | | | | | | | | | | | | | Enable keypad, keyboard backlight and volume button on brya BUG=b:212541307 BRANCH=none TEST=zmake testall TEST=EC console command "kblight" and Volume up/down keys Signed-off-by: Rajesh Kumar <rajesh3.kumar@intel.com> Change-Id: Ie8ed496b82ef1d6dc2f30f69a45432c56d389680 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3362502 Reviewed-by: Aaron Massey <aaronmassey@google.com> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* krabby: enable CBITing Shen2022-01-124-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | BUG=b:213434576 TEST=Test cbi read/write on Krabby $ cbi set 0 3 1 (0 means BOARD_VERSION), Verify BOARD_VERSION changed $ version 22-01-06 19:14:08.043 Chip: ite it81202 bx 22-01-06 19:14:08.046 Board: 3 uart:~$ cbi 22-01-06 19:14:31.002 [245.250030 CBI Reading board info] 22-01-06 19:14:31.006 CBI_VERSION: 0x0000 22-01-06 19:14:31.008 TOTAL_SIZE: 14 22-01-06 19:14:31.010 BOARD_VERSION: 3 (0x3) BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I00a3cc304b95a0072e62f3cd264465053bb5c33f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3369643 Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Auto-Submit: Ting Shen <phoenixshen@chromium.org>
* dojo: NVME power sequence controlTommy Chung2022-01-122-7/+14
| | | | | | | | | | | | | | | NVME power should be turned on when system starts up while turned off when shutting down. BUG=b:211528578, b:207744114 BRANCH=none TEST=make sure the NVME power sequence control correct. Signed-off-by: Tommy Chung <tommy.chung@quanta.corp-partner.google.com> Change-Id: Ida0197d71073984efd4cb78963277b5b5c2eeaf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3369168 Reviewed-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* dojo: Update battery, gpio configs and rename all commentsTommy Chung2022-01-124-93/+113
| | | | | | | | | | | | | | | | | Update battery, gpio configs and rename all comments for dojo. For battery config, the battery and gauge specs are attached in the bug tracker. For gpio config, since this is the new created board variant, the BOARD_CONFIGs should be removed. BUG=b:213000777 BRANCH=none TEST=make sure all battery charging, discharging, cut-off work. Signed-off-by: Tommy Chung <tommy.chung@quanta.corp-partner.google.com> Change-Id: I4c426c86740125520a9b163872386dfb9535607d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3364059 Reviewed-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org>
View Lorry Controller Status