| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=b:172020503
TEST=make buildall
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Iea7d3c0400cc7af8bbad109d6adbbf18e73714a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3952907
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clang warns:
error: initializer element is not a compile-time constant
There is an upstream LLVM review with proposed fix:
https://reviews.llvm.org/D76096.
In the meantime, we will work around it.
BRANCH=none
BUG=b:172020503, b:202062363
TEST=./util/compare_build.sh -b all -j 120
=> MATCH
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: If48c7bd9544c0fae0a889693122673016e1ba183
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3953254
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If you have a lot of twister-out dirs, the config_option_check.py
script gets really slow.
BRANCH=None
BUG=None
TEST=util/config_option_check.py with 20 twister-out.* dirs
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Ia246d610bad4a1aa9923140c8d424262209ff340
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3957260
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=b:234181908
TEST=./test/run_device_tests.py --board bloonchipper -t exception
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I4d5651be6048af357b68956097deea255551a6db
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3932262
Reviewed-by: Andrea Grandi <agrandi@google.com>
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=b:234181908
TEST=./test/run_device_tests.py --board bloonchipper abort
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Ic92cacdf018bbc8454ed4c7f72546a3ed4d7e4fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3933257
Reviewed-by: Andrea Grandi <agrandi@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
_exit() is called by libc functions such as abort() or exit(). This
implementation replaces the one from newlib's libnosys.
BRANCH=none
BUG=b:234181908
TEST=make buildall
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I1d8f65fa206b3544a2772f38be854ee905532ad3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3933256
Reviewed-by: Andrea Grandi <agrandi@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When building with clang it warns:
chip/mchp/lpc.c:966:9: error: implicit conversion from enumeration type
'enum ec_error_list' to different enumeration type 'enum ec_status'
[-Werror,-Wenum-conversion]
return EC_SUCCESS;
~~~~~~ ^~~~~~~~~~
BRANCH=none
BUG=b:172020503
TEST=CC=clang make BOARD=reef_mchp
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I680cea90f72d3743ef4b92e13e57e63557cba702
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3953490
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Host tests that use C++ need to link against the C++ standard library.
Using the C++ compiler when linking will include the C++ standard
library automatically (-lc++ for clang and lstdc++ for g++).
BRANCH=none
BUG=b:234181908
TEST=CQ passes
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I690eb8b14b0bd73085a3da1b8c9f97f948ccd63b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3953261
Reviewed-by: Andrea Grandi <agrandi@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When EFS2 enabled, EC calculates the RW hash twice during boot. One
in vboot_main() and another one in the init hook vboot_hash_init().
The second hash calculation is performed in a deferred task, and it's
very slow on Krabby (~2 seconds), greatly affects boot time.
Remove the second calculation since it seems unnecessary.
BUG=b:239378639
TEST=1) manually tested sw sync on EFS2(krabby) and EFS1(coachz) device.
2) pass zephyr tests
3) boot speed improved on krabby
BRANCH=none
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I32584524451ba261557e84e420a5869bf5fafc2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3935121
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create the initial EC image for the zombie variant by copying the
herobrine reference board EC files into a new directory named for
the variant.
(Auto-Generated by create_initial_ec_image.sh version 1.5.0).
BUG=b:249180463
BRANCH=None
TEST=make BOARD=zombie
Signed-off-by: Maulik Vaghela <maulikvaghela@google.com>
Change-Id: I556132feb4a2ddd80e0cda9645532f4caf5268d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3946398
Tested-by: Bob Moragues <moragues@chromium.org>
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Commit-Queue: Bob Moragues <moragues@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 48ed43a6f372ea3588ccc7e14ff5da1501050216.
Reason for revert: charger_task need set_mode function to prevent error.
Original change's description:
> rt9490: remove set_mode function
>
> The flags we implemented is not used anywhere in the codebase.
>
> BUG=none
> TEST=zmake
> BRANCH=none
>
> Signed-off-by: Ting Shen <phoenixshen@google.com>
> Change-Id: I72b01806463aec903b1bfe23bb1c12a58a97265d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3896556
> Tested-by: Ting Shen <phoenixshen@chromium.org>
> Reviewed-by: Eric Yilun Lin <yllin@google.com>
> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
> Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Bug: none
Change-Id: I5a3942111dbe2e707c34f79a7e5d170be635d69e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3949076
Reviewed-by: Sung-Chi Li <lschyi@chromium.org>
Auto-Submit: Eric Yilun Lin <yllin@google.com>
Code-Coverage: Sung-Chi Li <lschyi@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@google.com>
Tested-by: Eric Yilun Lin <yllin@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Set up the partner emulator (and create the associated suite
boilerplate) to not support VCONN. Verify that the TCPM will
unilaterally enable VCONN in this scenario.
BUG=b:251485312
TEST=twister -s zephyr/test/drivers/drivers.usbc_vconn_swap
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: Id6b6aa76a1f8e171cd74e6e6c36a44c60c531687
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3949579
Reviewed-by: Aaron Massey <aaronmassey@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the PD partner emulator, allow users to disable support for sourcing
VCONN. Support the VCONN_Swap -> Not_Supported message flow when VCONN
is not supported.
BUG=b:251485312
TEST=./twister -T test/zephyr
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: I833fb3927fd999bf81dcc0cd0aea3697db1346c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3949578
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Tomasz Michalec <tmichalec@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After a Hard Reset and when initializing a PD partner emulator
structure, set the VCONN role to be consistent with the power role.
BUG=none
TEST=twister -T zephyr/test
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: I6545d5febbbf6cd66fc8b9f17b5a3310f31772c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3949572
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Tomasz Michalec <tmichalec@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid errors like:
cc1plus: warning: ‘-Werror=’ argument
‘-Werror=implicit-function-declaration’ is not valid for C++
when compiling for target host (i.e. 'make hosttests').
As of gcc 9.2, implicit-function-declaration is only valid
for regular C code compilation. cc1plus rejects this flag.
BRANCH=none
BUG=b:234181908
TEST='make buildall' no longer complains
Change-Id: I8531c1e69a387f27d9a85be75e2e884f75950faa
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3949585
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test doesn't provide the ap_rst_l signal, so it causes a code
reset.
BRANCH=None
BUG=None
TEST=./twister
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Id8dded19f99d33de427f7e12fe66677f1f850ae3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3946033
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These macros are easier to read and use than the underlying pragmas.
BRANCH=none
BUG=b:172020503
TEST=make buildall
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I2f67cbb3f83230b7e1a6a4512471bbd2bec0498f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3872552
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes we get coverage reports where it appears that the coverage
data is all shifted off by one line, leaving many comments and blank
lines uncovered. For example see
http://goto.google.com/cros-ec-coverage/firmware-zephyr-cov-postsubmit/R108-15179.0.0-72225-8800548096768350721/lcov_rpt/common/keyboard_scan.c.gcov.html
In looking at that example, I discovered that for brya, in ro
only, when looking at the preprocessor output, the lines get shifted.
BRANCH=None
BUG=b:253131248
TEST=So many gcc -E runs
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I6e852548cb954ed3ee3c47088ed275bc32892753
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3949582
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Al Semjonovs <asemjonovs@google.com>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Al Semjonovs <asemjonovs@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The vivaldi keyboard of skyrim is different to the common config.
So we adjust it.
BUG=b:251363105
BRANCH=none
TEST=top row functions work correctly
LOW_COVERAGE_REASON=Skyrim board tests not created yet: b/247151116
Signed-off-by: FelixTW_Chang <felixtw_chang@compal.corp-partner.google.com>
Change-Id: Id5b0bd3c35f8f10ff061b73bcb07ff7e185f45ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3935509
Reviewed-by: Bhanu Prakash Maiya <bhanumaiya@google.com>
Commit-Queue: Diana Z <dzigterman@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Isaac Lee <isaaclee@google.com>
Code-Coverage: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a test that verifies a call to sleep_start_suspend() propagates a
timeout deferred call to board/chip-specific timeout handlers after some
delay. Also verifies that this timeout event is idempotent with respect
to calling the handlers.
BRANCH=none
BUG=b:252887178
TEST=twister -s zephyr/test/drivers/drivers.power_host_sleep
Signed-off-by: Aaron Massey <aaronmassey@google.com>
Change-Id: If9f20912942f25a217c4f0952eb6512958ba3e44
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3949625
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bb_retimer_set_usb3() function is no longer used.
Set USB_MUX_FLAG_CAN_IDLE in usb_mux.flags instead.
BRANCH=none
BUG=b:245753005
TEST='make buildall' passes
Change-Id: I2ca48ae6e641ac7a8243a0ddac198d7234241d52
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3914996
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Boris Mittelberg <bmbm@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the TCPM as VCONN Source, use EC_CMD_USB_PD_CONTROL to initiate a
VCONN Swap. Verify that the TCPM is not VCONN Source afterward.
BUG=b:251485312
TEST=twister -s zephyr/test/drivers/drivers.usbc_vconn_swap
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: Ifa5bc067270f0744d74b0f7004b8820ba4f8b778
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3949613
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the logic of the spi_flash_reg.c from common/ to a separate
directory. Also, move the tests. Update the build.mk system to still
build this in the same manner as well as CMake to use it as a library.
BRANCH=none
BUG=b:246839061
TEST=make BOARD=dooly
TEST=zmake build hoglin
TEST=./twister -T common
Signed-off-by: Yuval Peress <peress@google.com>
Change-Id: Icc6b4fce1619c2c6a86c040f30390b7788171a9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3935025
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Aaron Massey <aaronmassey@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's always enabled in the core/<core>/core_config.h files. The
following script demonstrates that it's enabled in all boards:
for board in `make print-boards`; do
make print-configs board="${board}" | grep -q CONFIG_SOFTWARE_PANIC
if [ $? -ne 0 ]; then
echo "${board} failed"
exit 1
fi
done
BRANCH=none
BUG=none
TEST=make buildall
Cq-Depend: chromium:3943248
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: If683b244f17b48bedf3699f2b24e83b5ad6e849e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3933255
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=b:172020503
TEST=./util/build_with_clang.py
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I965583d9d147617b1f560cfd4cc78cedd6c39bb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3947823
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Validate shmem console command
BUG=None
BRANCH=NONE
TEST=./twister -T zephyr/test
Signed-off-by: Al Semjonovs <asemjonovs@google.com>
Change-Id: Ic17cd5bd2448a45795b6525502565a7fceb06b08
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3949472
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When building with clang, it now warns if there is an unpacked struct
nested in a packed struct:
include/ec_commands.h:3053:4: error: field within 'struct
ec_params_motion_sense::(unnamed at include/ec_commands.h:3044:3)' is
less aligned than 'union ec_params_motion_sense::(anonymous at
include/ec_commands.h:3053:4)' and is usually due to 'struct
ec_params_motion_sense::(unnamed at include/ec_commands.h:3044:3)' being
packed, which can lead to unaligned accesses
[-Werror,-Wunaligned-access]
union {
^
See https://github.com/llvm/llvm-project/issues/55520.
BRANCH=none
BUG=b:172020503
TEST=./util/compare_build.sh -b all -j 120
=> MATCH
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I5c89746d7e2e93183f4706376e6cda0be4589c01
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3946036
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fan speed displayed as part of temps command is the ratio
of FAN_OFF and FAN_MAX wrt corresponding sensor temperature
that tells the amount of cooling the respective sensor expects.
This value of fan speed misinterprets as the actual fan_duty.
Modify the output of temps command accordingly.
CPU Console:
localhost ~ # ectool temps all
--sensor name -------- temperature -------- ratio (fan_off and fan_max)
--
memory 310 K (= 37 C) 8% (308K and 333K)
charger 305 K (= 32 C) 0% (308K and 333K)
ambient 306 K (= 33 C) 0% (308K and 333K)
ectool temps command description
temps <sensorid>
Print temperature and expected fan ratio (based on
temperature, fan_off and fan max value).
BUG=b:246929159
TEST=make buildall -j, make -j BOARD=gimble, check temps
command description, verify ectool temps all command output
in gimble, redrix, brya and nivviks
BRANCH=none
Signed-off-by: Harsha B R <harsha.b.r@intel.com>
Change-Id: I96286ec7e110ebe64e277d5cfa27e3f489c5893e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3915760
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Zephyr now requires that drivers that use kernel APIs to explicitly
include kernel.h.
BUG=none
BRANCH=none
TEST=zmake build -a
TEST=twister
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I9e2fc39a1645511ac9ce7c8043cff90652c4cd99
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3949614
Reviewed-by: Aaron Massey <aaronmassey@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Skyrim is at a stage where this CONFIG can be removed.
BRANCH=None
BUG=b:215404321
TEST=zmake build skyrim; boot up on a D4 skyrim
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I12a1bbb42d49a836547e4d5f580b274c97204ade
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3949612
Reviewed-by: Jonathon Murphy <jpmurphy@google.com>
Commit-Queue: Jonathon Murphy <jpmurphy@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a test that verifies the EC_CMD_HOST_SLEEP_EVENT host command may be
invoked with HOST_SLEEP_EVENT_S3_RESUME host sleep event where the
chip-specific host sleep event handler propagates the number of sleep
transitions that have taken place to the host.
BRANCH=none
BUG=b:252887178
TEST=twister -s zephyr/test/drivers/drivers.power_host_sleep
Signed-off-by: Aaron Massey <aaronmassey@google.com>
Change-Id: Ib9584fcedac7c0e2ee33e2137be4076875aacfa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3947526
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a test that verifies the EC_CMD_HOST_SLEEP_EVENT host command may be
invoked with HOST_SLEEP_EVENT_S3_SUSPEND host sleep event and
subsequently propagates the appropriate sleep context to the
chip-specific host sleep event handler.
BRANCH=none
BUG=b:252887178
TEST=twister -s zephyr/test/drivers/drivers.power_host_sleep
Signed-off-by: Aaron Massey <aaronmassey@google.com>
Change-Id: If58665b5ef33c028443cd55082f2a211199e1002
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3947525
Reviewed-by: Sam Hurst <shurst@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a test that verifies the EC_CMD_HOST_SLEEP_EVENT host command may be
invoked with an invalid sleep event and not return an error to the
caller. Also verify that this invocation results in the bad event being
propagated down to chip specific event handler with zero sleep
transitions.
Also adds a new test target for validating the power/host_sleep.c code.
BRANCH=none
BUG=b:252887178
TEST=twister -s zephyr/test/drivers/drivers.power_host_sleep
Signed-off-by: Aaron Massey <aaronmassey@google.com>
Change-Id: I0f177dc660746740b5380254583df426c9b903ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3947524
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Al Semjonovs <asemjonovs@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When building with clang it warns:
chip/stm32/clock-stm32l4.c:400:9: error: explicitly assigning value of
variable of type 'uint32_t' (aka 'unsigned int') to itself
[-Werror,-Wself-assign]
val = val;
~~~ ^ ~~~
BRANCH=none
BUG=b:172020503
TEST=CC=clang make BOARD=hyperdebug
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Ie4fae7251747d27b96ed08c3ef166fddd5411b9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3947822
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When building with clang it warns:
common/i2c_peripheral.c:30:9: error: implicit conversion from
enumeration type 'enum ec_error_list' to different enumeration type
'enum ec_status' [-Werror,-Wenum-conversion]
return EC_SUCCESS;
~~~~~~ ^~~~~~~~~~
BRANCH=none
BUG=b:172020503
TEST=none
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Ifd3507a4bf08a768ad7e84abcafaf2ebc69503b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3946037
Reviewed-by: Eric Yilun Lin <yllin@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In EC terminology, "host" refers to the target platform on top of the
EC. It only makes sense to build the host utilities for the host board,
not the board running the EC firmware.
BRANCH=none
BUG=b:252817153
TEST=make buildall
Force-Relevant-Builds: all
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I255024c6b2fa8cababdfbed6501730d5dd6308a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3943248
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The CMakeLists in the test drivers tests maintained code to be backwards
compatible with zmake. Since we haven't supported invoking tests in
zmake for some time this is dead CMake code.
Remove it.
BRANCH=none
BUG=none
TEST=CQ
Signed-off-by: Aaron Massey <aaronmassey@google.com>
Change-Id: I556c443f176f3a64af4c33711f2def5006434956
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3942834
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change request by power team.
AC PROCHOT 3.5A
DC PROCHOT 6.5A
BUG=b:253068153
BRANCH=none
TEST=Power team verified PROCHOT function as expected behavior.
Signed-off-by: jimmy.wu <jimmy.wu@lcfc.corp-partner.google.com>
Change-Id: I008a733fd9a4bb6d57146f86c7cf02fbb268a3c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3948005
Reviewed-by: Shou-Chieh Hsu <shouchieh@chromium.org>
Commit-Queue: Shou-Chieh Hsu <shouchieh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Validate 'feat' console command output
BUG=None
BRANCH=NONE
TEST=./twister -T zephyr/test
Signed-off-by: Al Semjonovs <asemjonovs@google.com>
Change-Id: If8c5c102e3e1da6b8f0ce284a674e61ea88fe16c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3947528
Reviewed-by: Simon Glass <sjg@chromium.org>
Commit-Queue: Simon Glass <sjg@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the test build, the "test_mockable_noreturn" helper adds the
"__attribute__((weak))" attribute to allow overriding functions. It
should still keep the "noreturn" attribute to be consistent with the
non-test build. Otherwise, a function declared with "noreturn" that
calls one of the functions that uses "test_mockable_noreturn" will fail
to compile with:
error: function declared 'noreturn' should not return
[-Werror,-Winvalid-noreturn]
BRANCH=none
BUG=b:234181908
TEST=./util/compare_build.sh -b all
=> MATCH
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I6ebfc78b7b07e19f9305a22fbfeccf62b4000667
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3933258
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The dependency on chromite fails on gitlab, so remove it.
BRANCH=None
BUG=None
TEST=Ran some commands
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I15ef7d77c91f91b4e36fd94bd45cd8d35fa2da74
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3946032
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Aaron Massey <aaronmassey@google.com>
Reviewed-by: Aaron Massey <aaronmassey@google.com>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now have an API for putting muxes in idle mode which can be used
instead of board specific code, so switch to it.
BRANCH=none
BUG=b:245753005
TEST='make buildall' passes
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Change-Id: I00d7d2b26d736e9615fa562a786a9271f314d7d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3914991
Reviewed-by: Boris Mittelberg <bmbm@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid flakes due to timeout.
BUG=none
TEST=twister -s zephyr/test/drivers/drivers.usbc_alt_mode
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: I7f73ebfda60af558885c84aa0b7c0878bc2cd5bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3945691
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Verify that TCPM will become VCONN Source if it can after attaching as
not VCONN Source.
BUG=b:251485312
TEST=twister -s zephyr/test/drivers/drivers.usbc_vconn_swap
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: Icd094f1cdc1d8ab320bf18edb112182532385618
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3943260
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=b:236389226,b:176500425
TEST=./util/clangd_config.py bloonchipper
TEST=./util/clangd_config.py --os auto bloonchipper
TEST=./util/clangd_config.py --os ec bloonchipper
TEST=./util/clangd_config.py --os zephyr bloonchipper
# Expect error
TEST=./util/clangd_config.py herobrine
# Expect error
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: Iee6c7d8626f046f4950bce48f5a5be0b84f4eeeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3931851
Reviewed-by: Andrea Grandi <agrandi@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=b:236389226,b:176500425
TEST=./util/clangd_config.py bloonchipper
TEST=make -j16 all-ide-compile-cmds
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: Ied9b16e543f1d8113b7c0535d7aaa397518fa3ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3931850
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-by: Andrea Grandi <agrandi@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added new tool to merge lcov files using one file as the template and
including only lines that are present in the template file.
The name is because you use the template file like a "stencil" and the
matching coverage shows through. Not great, but it's not really a
"set intersect" or a "merge" either.
Switch firmware_builder.py and gitlab to use the new tool in place of
the filename filtering.
See
https://jbettis.users.x20web.corp.google.com/www/herobrine_rpt/index.html
for updated coverage output.
BRANCH=None
BUG=None
TEST=Ran firmware_builder.py locally.
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I0e9672c346971b0df4602b0adce27fea6367c6b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3943261
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Corsola want to track coverage of 2 models, so add kingler to the special
boards list.
BRANCH=None
BUG=None
TEST=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I7135c453d2e22cff92939de59871a1af3c1f9ef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3946718
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The use of this variable collides with another use of the variable.
Since cryptoc was introduced, the print-tests target wouldn't work
correctly for boards that used cryptoc. Instead of printing the
test target symbolic name, it would print the full path to all test
executable targets.
BRANCH=none
BUG=b:169156874,b:236389226,b:176500425
TEST=make BOARD=bloonchipper print-tests
# Check that the full path isn't shown
TEST=make BOARD=bloonchipper tests
# Ensure that cryptoc is being built for tests
TEST=make host-fp
# Ensure cryptoc is being built
TEST=make BOARD=bloonchipper
# Ensure cryptoc is being built
TEST=./util/compare_build.sh -bfp
# verdict was match
Change-Id: Ia0c0aa9b57c224395df6e2e5551fbc71b7db00fa
Signed-off-by: Craig Hesling <hesling@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3937046
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RVP uses MAX6818 to digitize the apreset physical button.
The EC SYS_RESET_L is connected to input of the digitizer.
From MAX6818 Data sheet, range of 'Debounce Duration' is
Minimum - 20 ms, Typical - 40 ms, Maximum - 80 ms.
Hence, configured appropriate sys-reset-delay in dts configuration.
BUG=none
BRANCH=none
TEST=zmake build mtlrvpp_npcx
EC console command 'apreset' is working and triggers a warm reboot.
Signed-off-by: Rajesh Kumar <rajesh3.kumar@intel.com>
Change-Id: I7530aa6c3933ac26b59770b6b0db7e3f305dc00f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3939619
Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Reviewed-by: Brandon Breitenstein <brandon.breitenstein@intel.corp-partner.google.com>
Reviewed-by: Al Semjonovs <asemjonovs@google.com>
|