summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* charge_manager: don't send new power request when DPS enabledfirmware-cr50-stab-mp-14300.B-mainfirmware-cr50-stab-14294.B-mainEric Yilun Lin2021-10-191-12/+22
| | | | | | | | | | | | | | | | | | | | | DPS would control the PD sink voltage dynamically, so charge_manager doesn't need to send a new power request if it's not sinking the max voltage. Also, merge two new powe requests into one to prevent from sending multiple requests at one time. BUG=b:169532537 TEST=enable DPS, and won't send consecutive DP requests when switching voltage BRANCH=main Change-Id: Ib706f4feb5c6434d71b9576f299898a12613aded Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3229049 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com>
* dps: reset PD voltage when dps disabled.Eric Yilun Lin2021-10-191-0/+3
| | | | | | | | | | | | | | | | To enforce the PD voltage back to the default value, we have to force a new request. BUG=b:169532537 TEST=dps dis, and a new PD request is issued BRANCH=asurada Change-Id: I4c7d1d6019a9095099dc992411890e394c71b820 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3229048 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com>
* PRESUBMIT: Add third_party/bmi220 to excluded license checkTom Hughes2021-10-191-0/+1
| | | | | | | | | | | | | The cros_license_check presubmit is complaining. BRANCH=none BUG=b:172020503, b:188373185, b:193945779 TEST=none Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I9e1f33e427271df4cec340fc3bc0369ee2c9faa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3229799 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* chip/mchp: Fix license textTom Hughes2021-10-195-5/+5
| | | | | | | | | | | | | The cros_license_check presubmit is complaining. BRANCH=none BUG=b:172020503 TEST=none Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I56657835cb96492e4984f7734e96b8436c3a543b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3229798 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* tree: Files should end with single newlineTom Hughes2021-10-18154-158/+2
| | | | | | | | | | | | | | | | | | | | | | | One of the checks that runs as part of "repo upload" looks for a single newline at the end of each file. I'm getting warnings about this when I touch files that do not follow this, even though I didn't add the extra newlines. This commit fixes all files by running the following: for f in $(find . -name '*.[ch]'); do printf '%s\n' "$(cat ${f})" > ${f}; done BRANCH=none BUG=b:172020503 TEST=./util/compare_build.sh -b all -j 120 => MATCH Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Ia3ece5b64b549d21ca11708791368002bb6e9b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3229797 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* zephyr: Test accelgyro_bmi260.c for unsupported operationsTristan Honscheid2021-10-182-4/+51
| | | | | | | | | | | | | | | | | Add a test that covers parts of the code where we validate sensor types. Also made a modification to accelgyro_bmi260.c where I moved the sensor type check up to the top of the func so we fail before trying to set the data rate (which doesn't work for magnetometers). BRANCH=None BUG=b:184856157 TEST=zmake configure --test zephyr/test/drivers Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: I170087b8bfdc1212972d00010c90789967a6415b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3229076 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: ppc: sn5s330: Add test for func_set1 retry loopYuval Peress2021-10-189-0/+262
| | | | | | | | | | | | | | | Add a basic test that ensures that the func_set1 register write is attempted at least one more time on an initial failure. BRANCH=none BUG=b:203364783 TEST=zmake configure --test zephyr/test/drivers Signed-off-by: Yuval Peress <peress@google.com> Change-Id: Ib06794de0af29fb44e4cb550c7b1ef3c2667af0e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3229005 Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* core/cortex-m0: Function only used when CONFIG_TASK_PROFILING is definedTom Hughes2021-10-181-0/+2
| | | | | | | | | | | | | | | | | When compiling with clang, it warns: core/cortex-m0/task.c:182:19: error: unused function 'get_interrupt_context' [-Werror,-Wunused-function] static inline int get_interrupt_context(void) BRANCH=none BUG=b:172020503 TEST=make buildall -j Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I914a2a8f950a340c570f5d105859a80be3efb82a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3229479 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
* board/zinger: Include definition from usb_pd.hTom Hughes2021-10-182-2/+5
| | | | | | | | | | | | | | | | Rather than adding an extern for pd_rx_handler() in board/zinger/board.c, add the definition to the usb_pd.h header. BRANCH=none BUG=b:172020503 TEST=./util/compare_build.sh -b all -j 120 => MATCH Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I5472b2d0bce416d4a296d425efa5d72e9aa548e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3227264 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* chip/stm32: Include gpio_chip.h when using gpio_interruptTom Hughes2021-10-188-0/+8
| | | | | | | | | | | | | | | These files call gpio_interrupt(), but were not including the function declaration. BRANCH=none BUG=b:172020503 TEST=./util/compare_build.sh -b all -j 120 => MATCH Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Iaaedce2a4668dd05581aaa237344cd520c7eb715 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3227263 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* chip/npcx: Remove unused GPIO interrupt functionTom Hughes2021-10-181-1/+0
| | | | | | | | | | | | | | | | | | | | When the interrupt handlers are made static (see followup commits), the compiler complains that this function is unused (there is no corresponding DECLARE_IRQ): chip/npcx/gpio-npcx9.c:182:15: error: '__gpio_wk2fg_interrupt' defined but not used [-Werror=unused-function] GPIO_IRQ_FUNC(__gpio_wk2fg_interrupt, WUI_INT(MIWU_TABLE_2, MIWU_GROUP_6)); BRANCH=none BUG=b:172020503 TEST=./util/compare_build.sh -b all -j 120 => MATCH Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I3f58cdcb9b2e113fb9dd079a3e157bf8336b71d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3227262 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* zephyr test: ppc: Add sleep TODOsAbe Levkoy2021-10-181-0/+12
| | | | | | | | | | | | | | | | This test currently sleeps to give the driver time to handle interrupts. The test should instead schedule the driver immediately and simulate the passage of time to the driver. Add TODOs to track sleeps that should be replaced. BUG=b:201420132 TEST=zmake configure --test zephyr/test/drivers BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I179dcdd92c04e543a2f2ec0da6ec70bd4aa36ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3227260 Reviewed-by: Yuval Peress <peress@google.com>
* zephyr test: SYV682 VCONN_OC interruptAbe Levkoy2021-10-183-3/+75
| | | | | | | | | | | | | | Simulate VCONN OC and verify that the driver handles it as expected. Increase syv682x.c line coverage 65.4% -> 68.8%. BUG=b:190519131 TEST=zmake configure --test zephyr/test/drivers BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: Ifa9ff4129ef0f158e2f59314dbf62ee53b6180e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3219870 Reviewed-by: Yuval Peress <peress@google.com>
* bugzzy : LCD current setting on MP3372YongBeum.Ha2021-10-182-0/+33
| | | | | | | | | | | | | | | In order to meet the specification of LCD brightness, it is necessary to set the current value of the LCD controller. BUG=b:202344727 BRANCH=None TEST=make -j BOARD=bugzzy Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com> Change-Id: I4a688613681e9a68d9bb4c9103ddbf342c416d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3217483 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* bugzzy : Change charging currentYongBeum.Ha2021-10-182-0/+28
| | | | | | | | | | | | | | change charging current to reduce skin temperature. BUG=b:197776876 BRANCH=None TEST=make -j BOARD=bugzzy Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com> Change-Id: I8a20455d92446ce1606f9e262f6715bf8721adc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3220905 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* zephyr: hayato: disable using printkDawid Niedzwiecki2021-10-181-1/+0
| | | | | | | | | | | | | | | | CL:3206988 in Zephyr fixes the issue with HARD_RESET during PD negotiation so use shell_* functions instead of printk. BUG=b:193585176 TEST=Verify connecting a charger doesn't cause HARD_RESET BRANCH=main Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: Iba021931c0c5df6c8fea1ba589bc7454e777da24 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3226463 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Ruibin Chang <Ruibin.Chang@ite.com.tw> Commit-Queue: Dawid Niedzwiecki <dawidn@google.com>
* Cret: Change charging currentjohnwc_yeh2021-10-172-0/+26
| | | | | | | | | | | | | | | | | | | | | | | experimental for ThermalQual 1. In S3 and S5, charge current follow battery request. 2. In S0: a) charge current set to 1100mA. b) If battery request lower 1100mA, charge current follow battery request. BUG=b:188458703 BRANCH=dedede TEST=Test on Cret, charge current be change to 1.1A Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Change-Id: Ib62f65ba3b1e2bfbc3875e1c5b26927eb67dfbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3226280 Reviewed-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* zephyr: shim: drop unused entries from pwm_map.hFabio Baltieri2021-10-164-6/+0
| | | | | | | | | | | | | | | | Drop few entries from the various platforms pwm_map.h files. None of these seems to be used. BRANCH=none BUG=b:177452529 TEST=build and run on volteer TEST=gerrit cq Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I47d1283341e4750cd010dbe0eff8d959ce90ccde Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3222848 Commit-Queue: Yuval Peress <peress@google.com> Reviewed-by: Yuval Peress <peress@google.com>
* tree: Make all console commands staticTom Hughes2021-10-1517-33/+35
| | | | | | | | | | | | | | Almost all of the console commands were already static. This change makes all of them static for consistency. BRANCH=none BUG=b:172020503 TEST=make buildall -j Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I0ac46358b6fbafa65504c648ce4de0365cdbf723 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3224372 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* taeko: Improvement: Disable tcpc1 if no ps8815 db for early boardreno.wang2021-10-151-12/+114
| | | | | | | | | | | | | | | | | | | | It improve ec keep sensing ps8815 if no db is plugged. It's olny used for early board (board id = 0). 1. Add DB detection policy for board w/o plugging DB. It can make sure system can power on and won't be blocked by TCPC1. 2. Add draft PS8815 reset timing. The others should check b/194618663. 3. Follow CL:3095438, mux HPD interface change, to update BUG=b:197585292 BRANCH=None TEST=make -j BOARD=taeko; test dut can power on w/ and w/o TCPC1 DB Signed-off-by: reno.wang <reno.wang@lcfc.corp-partner.google.com> Change-Id: I7fd115baa95d455b282e4ee5bfdf8ee25524e140 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3133463 Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* primus: add prochot definesWill Tsai2021-10-153-0/+12
| | | | | | | | | | | | | | | | Already moved prochot function into baseboard folder. So remove prochot function in primus. BUG=b:198722634 BRANCH=none TEST=make -j BOARD=primus Signed-off-by: Will Tsai <will_tsai@wistron.corp-partner.google.com> Change-Id: I8abe44f7a20df74e97eb672390ff1e53cbc14fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3208327 Tested-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Reviewed-by: Boris Mittelberg <bmbm@google.com> Commit-Queue: Boris Mittelberg <bmbm@google.com>
* gimble: control prochotScott Chao2021-10-153-1/+13
| | | | | | | | | | | | | BUG=b:198689488 BRANCH=none TEST=make -j BOARD=gimble Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: I87c05cc9c1cac2671d8c722df5dec6db352f9e05 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3210249 Tested-by: Will Tsai <will_tsai@wistron.corp-partner.google.com> Commit-Queue: Boris Mittelberg <bmbm@google.com> Reviewed-by: Boris Mittelberg <bmbm@google.com>
* tree: Make all host commands staticTom Hughes2021-10-1513-28/+39
| | | | | | | | | | | | | | Almost all of the host commands were already static. This change makes all of them static for consistency. BRANCH=none BUG=b:172020503 TEST=make buildall -j Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I8330e85e6d64a039f08d7620eed1fe897f436567 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3221786 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* core/cortex-m: Invert if statement for readabilityTom Hughes2021-10-151-3/+3
| | | | | | | | | | | | BRANCH=none BUG=b:172020503 TEST=./util/compare_build.sh -b all -j 120 => MATCH Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I39f9d35b22d25c923a768bf86b3a16413b9f0a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3219871 Reviewed-by: Keith Short <keithshort@chromium.org>
* sn5s330: Set RCP threshold to 3 mV for PP1Scott Collyer2021-10-152-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL adjusts the RCP (reverse current protection) voltage threshold for PP1 to 3 mV when in ideal diode mode. This change fixes an issue on honeybuns for port C0 when connecting to M1 based host machines and charging at higher VBUS values ( > 15V). BRANCH=quiche BUG=b:199339421 TEST=verfied bit 4 of function set 10 register is clear > ppc 0 dump FUNC_SET1 [50h] = 0x05 FUNC_SET2 [51h] = 0x18 FUNC_SET3 [52h] = 0x68 FUNC_SET4 [53h] = 0xfc FUNC_SET5 [54h] = 0x37 FUNC_SET6 [55h] = 0xc1 FUNC_SET7 [56h] = 0x70 FUNC_SET8 [57h] = 0xbd FUNC_SET9 [58h] = 0x34 FUNC_SET10 [59h] = 0x60 ODM partner verified this change fixed the ~3% devices that were failing and did interop testing with other host machines to verify no regressions. Those results are linked in the buganizer issue. Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: Id798debc11f8586acc6c9feef104478375ee4fea Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3219573 Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Scott Collyer <scollyer@chromium.org>
* brya: add control prochot featureWill Tsai2021-10-153-0/+264
| | | | | | | | | | | | | BUG=b:198689488 BRANCH=none TEST=make -j BOARD=gimble Signed-off-by: Will Tsai <will_tsai@wistron.corp-partner.google.com> Change-Id: I4be2dc8505baffaa8b7d0c9b6949711aca370778 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3201831 Tested-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Commit-Queue: Boris Mittelberg <bmbm@google.com> Reviewed-by: Boris Mittelberg <bmbm@google.com>
* zephyr: add support for virtual batteryMichał Barnaś2021-10-159-10/+32
| | | | | | | | | | | | | | | | | | Add Kconfigs to enable virtual battery and set virtual battery address. Change named-i2c from I2C_PORT_VIRTUAL to I2C_PORT_VIRTUAL_BATTERY. BRANCH=main BUG=b:185480578 TEST=When virtual battery is enabled, compilation fails if no virtual battery port is defined in device tree. TEST=Enable virtual battery and verify that its handlers are called properly. Change-Id: Ic88da28dc443beb89a32868d201072f39abb3a86 Signed-off-by: Michał Barnaś <mb@semihalf.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3207991 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* cherry: powercycle VBUS after AP XHCI doneTing Shen2021-10-152-3/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | Implement VBUS cycle according to USB Type-C Spec R2.0: 10.3.1 Hub Downstream Facing Port State Descriptions 10.3.1.1 DSPORT.Powered-off A hub may provide power to its downstream ports all of the time to support power applications from a USB port. Such hubs must ensure that Enhanced SuperSpeed devices on its downstream-facing ports attempt Enhanced SuperSpeed connection once upstream VBUS is seen by the hub. The recommended method to achieve this is to cycle VBUS off for a duration or by actively discharging so that it is seen to be off by the downstream device. BUG=b:200772411 TEST=manually BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I674391622698b6e241b0a97063b3abbc8550e365 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3195205 Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* zephyr: drivers: add TCPCI CC related testsTomasz Michalec2021-10-151-1/+240
| | | | | | | | | | | | | | | | | | | This patch adds unit tests for following driver/tcpm/tcpci.c functions: - tcpci_tcpm_get_cc() - tcpci_tcpm_set_cc() - tcpci_tcpm_set_polarity() - tcpci_tcpm_set_vconn() BUG=b:184857030 BRANCH=none TEST=make configure --test zephyr/test/drivers Signed-off-by: Tomasz Michalec <tm@semihalf.com> Change-Id: I91208fa5093677db612358c804f29fb8b359b820 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3220336 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Tested-by: Tomasz Michalec <tmichalec@google.com> Commit-Queue: Tomasz Michalec <tmichalec@google.com>
* zephyr: drivers: add TCPCI test suiteTomasz Michalec2021-10-154-3/+172
| | | | | | | | | | | | | | | | | TCPCI emulator is added in tcpc_config for port 0. In this patch init and release of driver/tcpm/tcpci.c functions are tested. BUG=b:184857030 BRANCH=none TEST=make configure --test zephyr/test/drivers Signed-off-by: Tomasz Michalec <tm@semihalf.com> Change-Id: Ie36838c9562d5d1480699b7ab0ae3a04e3485d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3205360 Reviewed-by: Yuval Peress <peress@google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Tested-by: Tomasz Michalec <tmichalec@google.com> Commit-Queue: Tomasz Michalec <tmichalec@google.com>
* quackingstick: remove unused taskSue Chen2021-10-151-4/+1
| | | | | | | | | | | | | | Quackingstick have only one port type-C so remove unused C1 task. BUG=b:201263032 BRANCH=none TEST=none Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I8064a2bfcb8ecb50a84080904161a1721961ef5e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3217479 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* core/cortex-m: Use original __data_lma_start when compiling with gccstabilize-14285.B-mainTom Hughes2021-10-151-0/+7
| | | | | | | | | | | | | | | | | | | | https://crrev.com/c/3169964 changed __data_lma_start from "." to LOADADDR(.data) to fix dartmonkey when compiling with clang. This changed the LMA address on some boards, such as voxel. Even though the new address looks correct (matches start of .data section), we are seeing an exception on voxel during startup. For now, keep clang and gcc separate until we can diagnose the issue. BRANCH=none BUG=b:172020503, b:202863352 TEST=make buildall -j Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I8313210c89559a6159f311821a18e7b310a3ada6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3224378 Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org> Tested-by: caveh jalali <caveh@chromium.org>
* Felwinter: modify BB-retimer configureLeo-Tsai2021-10-152-3/+4
| | | | | | | | | | | | | | | configure BB-retimer I2c address to sync with intel BBR FW BUG=b:198122468 BRANCH=none TEST=build make -j BOARD=Felwinter pass Signed-off-by: Leo-Tsai <leocx_tsai@compal.corp-partner.google.com> Change-Id: I4481fe404236a41b2f391d9cbcb290385b93008f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3210253 Reviewed-by: Ko Ko <ko_ko@compal.corp-partner.google.com> Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* charge: respect PDO current maximum limitEric Yilun Lin2021-10-153-0/+37
| | | | | | | | | | | | | | | | | | | | | | The current input limit setting doesn't respect the PDO's current limit (e.g. when the current limit is less than CONFIG_INPUT_CURRENT_LIMIT) and this might cause the over-draining the charger. BUG=b:172878439 TEST=1) make buildall 2) modified servo-v4 which only broadcast PDOs with 250mA current limit and ensure the goroh won't sink more than 250mA. (while the CONFIG_INPUT_CURRENT_LIMIT is 512mA) BRANCH=main Change-Id: I09f8e6fb39a072ee38ea09a5c9898984f4122513 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3220037 Commit-Queue: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* jelboz/jelboz360: The type-C PDO "PD_MAX_POWER_MW" change to 45WMichael5 Chen12021-10-151-0/+2
| | | | | | | | | | | | | | The type-C PDO "PD_MAX_POWER_MW" change to 45W from 65W. BUG=b:202760336 BRANCH=zork TEST=manual Check PDO using command "ectool usbpdpower" Signed-off-by: Michael5 Chen1 <michael5_chen1@pegatron.corp-partner.google.com> Change-Id: I448ed37ce892f097aa7a2297868cf22195c8571e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3217476 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* zephyr test: Clean up commentAbe Levkoy2021-10-141-2/+1
| | | | | | | | | | | | | Move comment to its proper location. BUG=none TEST=zmake configure --test zephyr/test/drivers BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I1b2858121ee6aefc5babaea87efb55b50dd279aa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3219589 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* Zephyr: Increase default eSPI configDiana Z2021-10-141-2/+2
| | | | | | | | | | | | | | | | The ECOS repo allows eSPI to run in quad mode at the maximum speed. Allow the same configuration here for zephyr. BRANCH=None BUG=b:195137794 TEST=on guybrush, verify bootblock sees us go to quad mode. With zephyr ESPICFG fix applied, see that we're in quad mode with 33 MHz Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I18b4ea340dd97c2da4f984776a5b004a8db877ea Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3221771 Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* nipperkin: update led placementZick Wei2021-10-141-4/+4
| | | | | | | | | | | | | | | | | | | Nipperkin has led on both USB-C0 and USB-C1 side, this patch update USB-C0 and USB-C1 led placement on DUT: USB-C0 is left port. USB-C1 is right port. BUG=none BRANCH=none TEST=verify led behavior same as ectool led command. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Ibfee7b8921efc8ead8612b8212e5dc1b41f94424 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3211324 Reviewed-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Diana Z <dzigterman@chromium.org>
* nipperkin: Set rpm deviation to 1%Zick Wei2021-10-141-0/+1
| | | | | | | | | | | | | BUG=none BRANCH=none TEST=none Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Id6feb968e2f21cd1723c0f5f4d6ddf91003af0fb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3197895 Reviewed-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Diana Z <dzigterman@chromium.org>
* nipperkin: update thermal tableZick Wei2021-10-143-0/+150
| | | | | | | | | | | | | | Implement fan curve for nipperkin. BUG=b:202475154 BRANCH=none TEST=verify fan curve work as intended. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I3fb160f20533f09ab831465a2455846853829bda Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3197894 Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Diana Z <dzigterman@chromium.org>
* corsola: remove references to asurada inside source codeTing Shen2021-10-1416-410/+38
| | | | | | | | | | | | | | | | | | | - Remove IS_DEFINED(BOARD_XXX) and board_get_version() calls, assume the default board is Hayato rev 4+. - Remove dynamic g-sensor probing, default to icm426xx. BUG=b:202808130 TEST=1) make BOARD=krabby 2) zmake -D -l DEBUG configure -b zephyr/projects/corsola/krabby/ 3) `ag '(asurada|hayato)' -i` in the board folders shows no match BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I15e4dbb81970052e5b524c4aff9f51ff4c9d89c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3222519 Reviewed-by: Rong Chang <rongchang@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* krabby: enable zephyr buildTing Shen2021-10-1415-0/+1226
| | | | | | | | | | | | | | | Copy from asurada/hayato, will cleanup in following CLs. BUG=b:202808130 TEST=zmake -D -l DEBUG configure -b zephyr/projects/corsola/krabby/ BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I667ed99bd418997e932ca272daed936db54988f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3219882 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* krabby: initial ECTing Shen2021-10-1421-0/+2286
| | | | | | | | | | | | | | | | | | Start from copying Asurada board. Modified baseboard name in krabby/build.mk and copyright header. Will cleanup in following CLs. BUG=b:202808130 TEST=make BOARD=krabby BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I200c8dec7714dfacc38aad1edbf236c1a6268e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3218585 Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* Revert "primus: control prochot"Scott Chao2021-10-145-220/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit f5ba5ec8361d7dadefb3860a05bf80e4ad230a44. Reason for revert: Revert this CL due to we have new design in brya baseboard. https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3201831 Original change's description: > primus: control prochot > > BUG=b:198722634 > BRANCH=none > TEST=make -j BOARD=primus > TEST=verified by power team > > Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> > Change-Id: I777f803b91f0449317f0185a6ca77348de3835bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3096806 > Reviewed-by: caveh jalali <caveh@chromium.org> > Commit-Queue: caveh jalali <caveh@chromium.org> Bug: b:198722634 Change-Id: Ibd9426f2719f008159344b0917424611ae7b4a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3220725 Auto-Submit: Scott Chao <scott_chao@wistron.corp-partner.google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Scott Chao <scott_chao@wistron.corp-partner.google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Tested-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
* zephyr test: SYV682X HC_OV interruptAbe Levkoy2021-10-142-1/+35
| | | | | | | | | | | | | | | | Test high-voltage over-current interrupts. Verify that the driver restores the power path until the over-current limit is reached. Increase coverage of syv682x.c: line 47.5->55.1%; branch 13.2->15.5%. BUG=b:190519131 TEST=zmake configure --test zephyr/test/drivers BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I84f2eb31796eec4e2106f29f52ee49c9e9662928 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3214776 Commit-Queue: Yuval Peress <peress@google.com> Reviewed-by: Yuval Peress <peress@google.com>
* anahera: Enable keyboard factory scanningDevin Lu2021-10-132-0/+24
| | | | | | | | | | | | | | This patch adds the factory keyboard connector test. BUG=b:202914217 BRANCH=none TEST=Short keyboard pins and make sure "ectool kbfactorytest" works. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: I9d06b8a44e6274e27f6ce96e23b48de799eaad61 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3220039 Reviewed-by: Boris Mittelberg <bmbm@google.com> Commit-Queue: Boris Mittelberg <bmbm@google.com>
* redrix: Enable keyboard factory scanningDevin Lu2021-10-132-0/+25
| | | | | | | | | | | | | | This patch adds the factory keyboard connector test. BUG=b:202914217 BRANCH=none TEST=Short keyboard pins and make sure "ectool kbfactorytest" works. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: I941767c928d71cd04087ff40fa53427f49ae4802 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3220038 Reviewed-by: Boris Mittelberg <bmbm@google.com> Commit-Queue: Boris Mittelberg <bmbm@google.com>
* core/cortex-m[0]: Work around clang inline-asm warningTom Hughes2021-10-132-4/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | clang warns that we're clobbering a reserved register: inline asm clobber list contains reserved registers: R7 [-Werror,-Winline-asm]. According to https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html#Clobbers-and-Scratch-Registers: When the compiler selects which registers to use to represent input and output operands, it does not use any of the clobbered registers. Before this change, the only remaining registers for the compiler to use to hold the values represented by the symbolic names "pregs" and "pstack" are R0 and R12. After this change, this still holds on clang, since it won't clobber the reserved register R7 even if it's not on the clobber list. BRANCH=none BUG=b:172020503 TEST=make V=1 CC=arm-none-eabi-clang BOARD=elm TEST=./util/compare_build.sh -b all -j 120 => MATCH Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I5182ef24f4465d68c97f4160a45cd479fe52e017 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3193273 Reviewed-by: Keith Short <keithshort@chromium.org>
* galtic360: Add battery 50wh(3S1P)Michael5 Chen12021-10-133-0/+77
| | | | | | | | | | | | | | | | | | Add battery 50wh for galtic360 BUG=b:194961842 BRANCH=dedede TEST=manual 1. Check battery found on EC console 2. Check battery cutoff function on EC console 3. Check battery charging FET status when battery full 4. Battery charge from 0% to 100%. Signed-off-by: Michael5 Chen1 <michael5_chen1@pegatron.corp-partner.google.com> Change-Id: I87381fb585a0a82af5280a04867df4c98ee4d528 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3161856 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* chip/stm32: Avoid out of bounds array access on TCPCI_MSG_TX_BIST_MODE_2Tom Hughes2021-10-131-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | clang warns: chip/stm32/ucpd-stm32gx.c:797:5: error: array index 582424 is past the end of the array (which contains 7 elements) [-Werror,-Warray-bounds] ucpd_txorderset[TX_ORDERSET_SOP]; ^ ~~~~~~~~~~~~~~~ chip/stm32/ucpd-stm32gx.c:127:1: note: array 'ucpd_txorderset' declared here static int ucpd_txorderset[] = { The if clause handles SOP -> Cable Reset and the only type that does not handle is TCPCI_MSG_TX_BIST_MODE_2. That case is a "don't care" for sync packets as it's just a continuous 1/0 bit pattern. BRANCH=none BUG=b:172020503 TEST=make CC=arm-none-eabi-clang BOARD=baklava Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Ia2b73bcbf7eabe2de480633d4e65b8df55137e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3198206 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Scott Collyer <scollyer@chromium.org>
View Lorry Controller Status