summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* gitlab: Only run CI in main and coverage branchesfirmware-dedede-13606.458.B-masterJeremy Bettis2023-01-041-0/+5
| | | | | | | | | | | | | | | | | | | | | | This workflow rule will prevent this CI config from running unless the branch name is "main" or "coverage". It will have to be cherry-picked into all the other branches to make them stop running sadly. BRANCH=None BUG=b:244766499 TEST=Used yaml validator at https://gitlab.com/zephyr-ec/ec/-/ci/editor?branch_name=main&tab=2 Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I536de3e3fdbca1c48505e61de5737f865bd0e233 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3872545 Reviewed-by: Simon Glass <sjg@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Simon Glass <sjg@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> (cherry picked from commit 15612bc4af40cb2a824ff2590508df29f27fbf56) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4133146
* magolor: delay one second when charger enter low power modeben chen2022-12-301-0/+2
| | | | | | | | | | | | | | | | | | | | add delay one second waiting for charger enter low power mode BUG=b:259155418 BRANCH=none TEST=checking ec console don't power on until enter hibernate Change-Id: I56b5e1f84f32dc4dea69b0c53b45980cb9b741e7 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4050016 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> (cherry picked from commit bd967de4a3322c2539ea86287fcb8e68e3ba9cff) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4127240 Reviewed-by: Ivan Chen <yulunchen@google.com> Auto-Submit: Shou-Chieh Hsu <shouchieh@chromium.org> Tested-by: Shou-Chieh Hsu <shouchieh@chromium.org> Commit-Queue: Ivan Chen <yulunchen@google.com>
* Merge remote-tracking branch cros/main into firmware-dedede-13606.B-masterAseda Aboagye2022-04-29127-472/+3016
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Relevant changes: git log --oneline 61f735f5f0..a588afd712 -- baseboard/dedede board/beadrix board/beetley board/blipper board/boten board/bugzzy board/corori2 board/cret board/drawcia board/drawcia_riscv board/galtic board/kracko board/lantis board/madoo board/magolor board/metaknight board/pirika board/sasuke board/sasukette board/storo board/waddledee board/waddledoo board/wheelie common/charge_state_v2.c common/mkbp_* common/ocpc.c common/usbc/usb_tc_drp_acc_trysrc_sm.c common/usbc/usb_sm.c common/usbc/*_pd_* common/usbc/dp_alt_mode.c common/usbc/usb_prl_sm.c common/usbc/usb_pe_drp_sm.c common/usb_charger.c common/usb_common.c common/usbc_ocp.c driver/charger/sm5803.* driver/charger/isl923x.* driver/tcpm/raa489000.* driver/tcpm/it83* include/power/icelake.h include/intel_x86.h power/icelake.c power/intel_x86.c util/getversion.sh a588afd712 Storo: Increase pd_task stack size 4a5f4708c3 ISL923x: Disable input regulation with function BRANCH=None BUG=b:230833524 b:224616537 TEST=`make -j buildall` Signed-off-by: Aseda Aboagye <aaboagye@google.com> Change-Id: I60dba502c4b8a05c9def2803035f71c71c0527af
| * Storo: Increase pd_task stack sizemike2022-04-291-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Stack of pd_task may be overflow during some FAFT test, enlarge the stack size to avoid system boot. BUG=b:230833524 BRANCH=dedede TEST=test firmware_FwScreenCloseLid,firmware_FwScreenPressPower and platform_ServoPowerStateController.USBPluggedin pass Signed-off-by: mike <mike5@huaqin.corp-partner.google.com> Change-Id: Ia087d5b6238d4343d1dec9a5c9cdf6c4bb581636 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3615695 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
| * zephyr:test: Add ping message support/testAl Semjonovs2022-04-293-0/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Add ping message support to emulator and verify it via test case. BUG=b:23062456 BRANCH=NONE TEST=zmake test test-drivers Signed-off-by: Al Semjonovs <asemjonovs@google.com> Change-Id: Ic71b71ef728469282966c8e00168b9a2d21a8621 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3612204 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
| * nissa: correct the order of sensor array entriesDeepti Deshatty2022-04-292-51/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If using LPC interface, entries in the motion_sensor array should be maintained in certain order. i.e first entries must be accelerometers and then gyroscope. update_sense_data() which updates the sensor data to AP, expects motion_sensor array entries in this order. BUG=b:229577857 BRANCH=none TEST=TAST test hardware.SensorAccel passed on Nivviks Change-Id: I1a674cc7431db87ca230aa0589ac9df933bf6001 Signed-off-by: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3612830 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Andrew McRae <amcrae@google.com>
| * zephyr: shim: update the pm_policy_state_lock_is_active APIFabio Baltieri2022-04-292-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update the pm_policy_state_lock_is_active() calls to add the new argument introduced in: 69b28bfd07 pm: policy: Consider substates for state lock functions Setting the second argument to PM_ALL_SUBSTATES should maintain the current behavior. BRANCH=none BUG=none TEST=zmake testall Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Cq-Depend: chromium:3614848 Change-Id: Ia39d346367f2baf165b609776b3571415b241417 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3613914 Reviewed-by: Yuval Peress <peress@google.com>
| * zephyr: shim: update to the new pwm_set Zephyr APIFabio Baltieri2022-04-298-66/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The PWM api have been changed to drop the _pin_ name, and also to remove the _usec and _msec variants and only use nsec as an argument. Change all internal PWM drivers to work in nsec and use the new APIs. BRANCH=none BUG=none TEST=flash brya, check the pwm frequency on the scope TEST=zmake testall Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Cq-Depend: chromium:3613455, chromium:3613464, chromium:3614845 Change-Id: I30ab1420820846409a87497badf37bc69c61c148 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3613907 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
| * tcpm/it8xxx2: determine retry count by protocol versionTing Shen2022-04-291-5/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace the hard-coded retry count by dynamically checking protocol version. This is required to pass PD2.0 related tests. BUG=b:229700747 TEST=pass compliance test TEST.PD.PROT.ALL.01 BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I749649e6d6360295824179dfdc939a0aa2d6ea38 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3613161 Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Ruibin Chang <Ruibin.Chang@ite.com.tw>
| * cherry: use board_rt1718s_pd_set_frs_enable insteadEric Yilun Lin2022-04-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | move the board_pd_set_frs_enable to board_rt1718s_pd_set_frs_enable. Let the driver handling FRS GPIO disabling rather than TCPM. BUG=none TEST=on cherry, test FRS works with 9V, 5V with several FRS hubs BRANCH=cherry Change-Id: Ie3856824aeebeca461acfae99b89e881224f5edb Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3602115 Tested-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com>
| * kingler: enable FRS on C1Eric Yilun Lin2022-04-291-5/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | RT1718S_GPIO1: EN_SNK -> 0 when FRS signal rx RT1718S_GPIO2: EN_SRC -> 1 when FRS signal rx RT1718S_GPIO3: EN_FRS -> 1 when FRS enabled BUG=b:223086905 TEST=Able to do FRS when initially sinking with 20V/5V BRANCH=none Change-Id: I3d8dcfcb72a5f320c692a145d3779a6144d04332 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3506876 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Tested-by: Eric Yilun Lin <yllin@google.com> Auto-Submit: Eric Yilun Lin <yllin@google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com>
| * rt1718s: fix re-entry FRS stateEric Yilun Lin2022-04-291-7/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | RT1718S FRS RX interrupt may re-raise sometimes even if there's only one RX signal on CC lines. We filtered the second FRS RX in case of breaking the state machine since the state machine had entered the FRS AMS already. Also, ensure that the FRS AMS states are entered only when the FRS is enabled. Sometimes the FRS Rx interrupt will raise when FRS is disabled. BUG=b:223086905 TEST=success to 5V sink-to-source FRS on kingler BRANCH=none Change-Id: I12de944849041bcb42a9d35c981fafb35f9f6bd8 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3593761 Tested-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com>
| * zephyr: Do not shutdown alt mode for sysjumpAndrew McRae2022-04-291-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Do not shutdown USB PD alt mode before a sysjump. When the shell console command 'sysjump' is used, the the task ID is invalid, causing the EC the hang waiting for the invalid task. TCMPv2 does not require the pre-sysjump preparation any more, since most connections now start in ErrorRecovery. This was previously required for situations when a monitor was connected, and the connection was required to be maintained across sysjump restarts. Now that the connection starts in ErrorRecovery, the monitor connection will be restarted. Previous behaviour is maintained for backwards compatibility, and this is only turned off for Zephyr based systems. BUG=b:230572489 TEST=zmake build nivviks; flash & run BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Ib541105a3f1a1fd8b83b6363063df10981c84fed Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3616364 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
| * test: add tests for motion sense offset host commandYuval Peress2022-04-293-0/+155
| | | | | | | | | | | | | | | | | | | | | | BRANCH=none BUG=b:224614211 TEST=zmake test test-drivers Signed-off-by: Yuval Peress <peress@google.com> Change-Id: Ic114226fc04859df72312c2f7684451912337f2c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3607056 Reviewed-by: Keith Short <keithshort@chromium.org>
| * dood: Add CONFIG_USB_PD_RESET_MIN_BATT_SOCYu-An Chen2022-04-291-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | Add CONFIG_USB_PD_RESET_MIN_BATT_SOC to prevent pd reset when battery soc under 2% BUG=b:229541865 BRANCH=octopus TEST=make BOARD=dood Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: If3583b586dd9de3c41b4a332787aff207f4441c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3612828 Reviewed-by: Diana Z <dzigterman@chromium.org>
| * Felwinter : Fix keyboard backlight flashs when EC cold reset.Logan_Liao2022-04-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch modify that board initial keyboard backlight pwm setting to fix KB backlight flash when EC run initial task. BUG=b:230277336 BRANCH=none TEST=felwinter keyboard backlight no flash when EC cold reset. Signed-off-by: Logan_Liao <logan_Liao@compal.corp-partner.google.com> Change-Id: Iecd0c09cc967abde29cdf8f6ee2fe841e4ad7d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3612829 Reviewed-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Commit-Queue: Logan Liao <logan_liao@compal.corp-partner.google.com> Reviewed-by: Ko Ko <ko_ko@compal.corp-partner.google.com> Reviewed-by: caveh jalali <caveh@chromium.org> Tested-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Reviewed-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com>
| * zephyr: villager: Add led-id property in color-nodesParth Malkan2022-04-291-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | led-id property is needed in color nodes to identify the color nodes based on the led-id in case of multi leds. BUG=b:227528898 TEST=zmake build villager BRANCH=none Signed-off-by: Parth Malkan <parthmalkan@google.com> Cq-Depend: chromium:3612219 Change-Id: I6e9c7e788ab351af05a10a8d34b38f83f21946f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3609113 Reviewed-by: Wai-Hong Tam <waihong@google.com>
| * zephyr: LED: Enable multi LED supportParth Malkan2022-04-294-41/+88
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enable variants with multiple LEDs (power LEDs, dual port battery LEDs) to define policy using devicetree and use common LED driver for execution. BUG=b:227528898 TEST=zmake build lazor, configured blue and amber LEDs of Lazor as left and right and tested dual port battery LED behavior. crrev.com/c/3612713 BRANCH=none Cq-Depend: chromium:3609114, chromium:3609113, chromium:3609112 Signed-off-by: Parth Malkan <parthmalkan@google.com> Change-Id: I52d69a6e6c30cf5a8f99fff623fe342e0aba3863 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3612219 Reviewed-by: Wai-Hong Tam <waihong@google.com>
| * zephyr: lazor: Add led-id property in color-nodesParth Malkan2022-04-291-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | led-id property is needed in color nodes to identify the color nodes based on the led-id in case of multi leds. BUG=b:227528898 TEST=zmake build lazor BRANCH=none Signed-off-by: Parth Malkan <parthmalkan@google.com> Cq-Depend: chromium:3612219 Change-Id: I0748538f5b28fc1959164195a9353e8047098019 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3609112 Reviewed-by: Wai-Hong Tam <waihong@google.com>
| * zephyr: LED: Add led-id and charge port propertiesParth Malkan2022-04-291-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Charge port property is to match the policy node with active charge port. led-id property is used as a link between color nodes and pins nodes in case of multi-LEDs BUG=b:227528898 TEST=zmake build lazor BRANCH=none Signed-off-by: Parth Malkan <parthmalkan@google.com> Cq-Depend: chromium:3612219 Change-Id: I27711e74e0208ebeb77044285af9500b3a3f40c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3609114 Reviewed-by: Wai-Hong Tam <waihong@google.com>
| * volteer: Enable PROCHOT gate based on C10Keith Short2022-04-289-6/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Enable PROCHOT gating based on the C10 state for all Volteer boards that support monitoring the C10 signal from the PCH. BUG=b:185810479 BRANCH=volteer TEST=Observer AP enters C10 state, EC skips turning on the fans. Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I9adc1902b97a2a85b351c88d1d9c44ed17d1056a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3615480 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
| * throttle_ap: Add option to gate PROCHOT based on C10Keith Short2022-04-287-12/+112
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For some x86 boards, the PROCHOT signal is not valid once the AP enters the C10 state. Add an option to gate PROCHOT detection if the C10 state is asserted. When the AP exits C10, the EC rechecks the PROCHOT state. Note that only the Volteer baseboard enables the PROCHOT interrupt, so it is the only board that is updated to call throttle_ap_config_prochot(). All gpio.inc files that connect to throttle_ap_prochot_input_interrupt() all use the pin name EC_PROCHOT_IN_L. Confirmed with these searches: $ grep -r "GPIO_INT.*throttle_ap_prochot_input_interrupt" . \ | wc -l 31 $ grep -r "EC_PROCHOT_IN_L.*throttle_ap_prochot_input_interrupt" . \ | wc -l 31 $ grep -r "gpio_enable_interrupt.*EC_PROCHOT_IN_L" . ./baseboard/volteer/power.c: \ gpio_enable_interrupt(GPIO_EC_PROCHOT_IN_L); BUG=b:185810479 BRANCH=volteer TEST=make buildall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I73fb328675d9faade13fe0192570dc838de028a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3615479 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
| * zephyr: shim: update all pwms nodes to include frequency/periodFabio Baltieri2022-04-2827-49/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update all pwms entries to include a frequency/period specification, so that it can be used by higher level drivers. BRANCH=none BUG=b:230093078 TEST=zmake testall Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I6965f19a688a4cc85fbb0d2dac78c4bed34c8cef Cq-Depend: chromium:3613422 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3602882 Reviewed-by: Wai-Hong Tam <waihong@google.com>
| * zephyr: mtlrvp: Enable seven segment display driverRajesh Kumar2022-04-282-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This Enables MAX695X seven segment display driver for MTL RVP. Port80 information and power sequencing states can be displayed on the 7-segment so that we can observe this information without connecting a debugger. BUG=b:230641535 BRANCH=none TEST=zmake build mtlrvpp_npcx Power Seq state and Port80 information is observed on 7-Segment display. Signed-off-by: Rajesh Kumar <rajesh3.kumar@intel.com> Change-Id: Ib7b4b13051a1640187ef371f86c3ccf67d1307ae Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3611469 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Yuval Peress <peress@google.com>
| * Revert "zmake: Add .pylintrc and some fixes for pylint"Mike Frysinger2022-04-282-7/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0ab6c10da0394f2887a26b1ac7c696baed801517. Reason for revert: This is utilizing internal project & system paths that are not guaranteed to be stable or be used by people. Original change's description: > zmake: Add .pylintrc and some fixes for pylint > > With this .pylintrc, and these tweaks, there are no errors reported by > cros lint. Many warnings, but no errors. > > Added a pylint call to run_tests.sh. It only checks for errors, once we > get the warnings cleaned up, we should change it to call cros lint > instead. > > BRANCH=None > BUG=b:217969201 > TEST=run_tests.sh > > Change-Id: I1ad75fda3d6f818f1d1c66654823bac97ce09942 > Signed-off-by: Jeremy Bettis <jbettis@google.com> > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3449124 > Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> > Commit-Queue: Jeremy Bettis <jbettis@chromium.org> > Tested-by: Jeremy Bettis <jbettis@chromium.org> Bug: b:217969201 Change-Id: I6e4115e8e3649e345dc01c4d898c7f718feac66f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3612962 Tested-by: Mike Frysinger <vapier@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
| * chip/host: Fix -Wstrict-prototypes warningManoj Gupta2022-04-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ToT clang is complaining about missing 'void' in function prototype. chip/host/system.c:136:45: error: function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] test_mockable uintptr_t get_panic_data_start() ^ void BUG=b:230345382 TEST=CQ, llvm tot test BRANCH=none Signed-off-by: Manoj Gupta <manojgupta@google.com> Change-Id: I5c9faab7c0d5ca743d001afb6fe359378974bf8e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3615029 Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org> Auto-Submit: Manoj Gupta <manojgupta@chromium.org>
| * nissa: don't control HDMI sub-board S5 railsPeter Marheine2022-04-281-8/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The EN_S5_RAILS input to the HDMI sub-board is not actually connected to anything (it is enabled as long as the S5 3.3V rail from the mainboard is provided to the sub-board), so it doesn't need to be controlled by the EC. If the EC is asserting EN_S5_RAILS to the sub-board when attempting to hibernate, hibernate fails because it is latched back off by the asserted signal (anytime the AP is in S5 or higher power state). Since hibernate should work in S5 as well as G3, we can simply stop controlling that EC output and the sub-board will continue to work normally. BUG=b:226325993 TEST=Nereid sb_1 (SUB_USB_C1_INT_ODL) remains high when AP is on with sub-board 3 in use, and the sub-board remains powered (the USB port on it works). BRANCH=none Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: Idd6c0a37249d1e85a8fd0ffc763a31cee452f9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3612982 Reviewed-by: Andrew McRae <amcrae@google.com>
| * crota: change orientation matrix to motion sensorsPeter Chi2022-04-281-3/+3
| | | | | | | | | | | | | | | | | | | | | | BUG=b:230411931 BRANCH=none TEST=make -j BOARD=crota Signed-off-by: Peter Chi <peter_chi@wistron.corp-partner.google.com> Change-Id: I284552b8dae26cef10b6bad0bdd35a2b0b12d837 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3607475 Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
| * zephyr: kingler: enable PD_VBUS_MEASUREEric Yilun Lin2022-04-282-3/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | kingler has two VBUS ADC from TCPC: C0: ANX3447 VBUS ADC C1: RT1718S VBUS ADC BUG=b:203739613 TEST=vbus reading is correct. BRANCH=none Change-Id: I99b8b0098446f4ee271ba79cd67d2f30f3b86663 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3397146 Auto-Submit: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com> Reviewed-by: Rong Chang <rongchang@chromium.org>
| * rt1739: more workaround at initTing Shen2022-04-282-15/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix the VBUS to VIN_LV leakage and Sink OCP as described in b:228941287 comment#4 BUG=b:228941287 TEST=manually BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: Ic90b297df7f797b0c43a7b91163cbf5033168351 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3588077 Commit-Queue: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com> Tested-by: Ting Shen <phoenixshen@chromium.org>
| * tcpc/rt1718s: disable FRS until valid FRS VBUS dropEric Yilun Lin2022-04-283-7/+114
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `rt1718s_set_frs_enable` does three things: 1. enable/disable FRS RX detection 2. enable/disable auto asserting EN_SRC when FRS happened 3. enable/disable EN_FRS RT1718S EN_SRC GPIO auto-enablement is only working when EN_FRS is asserted and the VBUS drop below Vsafe5VMax. However, some of the FRS hubs have a higher capacitance, and this makes the VBUS discharging slowly, and currently, EN_FRS is disabled after we got FRS RX signal on CC line, and it might happen before the VBUS discharged to Vsafe5VMax, and the FRS won't source in that case because EN_FRS was deasserted at the moment. Also, some of the PPC (e.g. nx20p348x and hl5099) requiring the EN_FRS asserting longer even after the EN_SRC asserted (power is sourcing), so that the VBUS can be maintained. To fix these issues, we defer deasserting the EN_FRS for 5ms after RT1718S reports VBUS valid low (4.75V), and EN_SRC is asserted. The 5ms is recommended by HL5099 vendor to maintain the VBUS. BUG=b:223086905 b/228422539 TEST=kingler C1 FRS works BRANCH=none Change-Id: Idc1fc8614b30275b825a655d7af821c1a1c99ee0 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3544748 Auto-Submit: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Tested-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org>
| * tcpm/anx7477: support TCPCI get_vbus_voltageEric Yilun Lin2022-04-283-25/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix anx7447_get_vbus_voltage which was using raw ADC value, and the new implementation let it report the real reading in mV, and move the common VBUS calculation to the header so both tcpci and anx7447 can benefit from it. Also, unguarded the function by dropping VBUS_DETECT_TCPC macro. BUG=b:203739613 TEST=uart:~$ vbus VBUS C0 = 20200 mV VBUS C1 = 0 mV BRANCH=none Change-Id: I61a8eecf1f77a7c87b2ef435af6809821388e66a Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3397145 Tested-by: Eric Yilun Lin <yllin@google.com> Auto-Submit: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com>
| * zephyr: Kconfig: modify the dependency for battery APIwen zhang2022-04-283-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | port the PLATFORM_EC_HOSTCMD_BATTERY_V2 and auto-enable if the PLATFORM_EC_BATTERY_V2 is set BUG=b:222629048 BRANCH=none TEST=ectool battery works well when battery is discharging Change-Id: I4345e34bc2777c4a9830a3e1b9d0184c8704f09d Signed-off-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3503075 Reviewed-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: zanxi chen <chenzanxi@huaqin.corp-partner.google.com>
| * zephyr: ap_pwrseq: Sync CPU state with signalsAndrew McRae2022-04-283-4/+138
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synchronize the CPU state by checking the power signals. BUG=b:227970724 TEST=zmake build nivviks; flash & run BRANCH=none Cq-Depend: chromium:3607315 Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Ice983c9be114076d5925ef94a2b1f9a6e6742506 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3586792 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
| * moli: change BB retimer i2c addressScott Chao2022-04-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | BUG=b:230443753 BRANCH=none TEST=make -j BOARD=moli Change-Id: I9a25bdaa5e41e81ea64eccac250c77c7d70ba730 Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3608389 Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
| * zephyr: ap_pwrseq: Set VW signals valid at init timeAndrew McRae2022-04-271-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | If the VW signals are present, mark them as valid. BUG=b:229044143 TEST=zmake build nivviks; flash & run BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I6a9e8cd5c9bc545ed501bbf4ca04e7c82187d1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3607315 Reviewed-by: Bernardo Perez Priego <bernardo.perez.priego@intel.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
| * zephyr: LED: Generate pins count from each nodeParth Malkan2022-04-273-12/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds a pins count variable to generate pins count for each node instead of using a constant. In case of multi-LEDs, pins count for each node will not be the same, so this change is required. BUG=b:227528898 TEST=zmake build lazor, test manually on Lazor BRANCH=none Signed-off-by: Parth Malkan <parthmalkan@google.com> Change-Id: I3ca5d010a8ca78dd196ab0625c474bd65cad4060 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3612202 Reviewed-by: Wai-Hong Tam <waihong@google.com>
| * ec: Fix "-Wstrict-prototypes" warningManoj Gupta2022-04-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add 'void' to a few functions that are triggering "-Wstrict-prototypes" warning with ToT llvm. BUG=b:230345382 TEST=CQ, tot llvm BRANCH=none Signed-off-by: Manoj Gupta <manojgupta@google.com> Change-Id: I6ce862cf9909cec65db463e2f7d6c4b9d03e1304 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3611723 Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Tom Hughes <tomhughes@chromium.org> Auto-Submit: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: Tom Hughes <tomhughes@chromium.org>
| * zephyr: LED: Change system state node match logicParth Malkan2022-04-271-55/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In case of multi-LEDs, there could be more than one node that matches the current system state and represents different LEDs. This patch changes node match logic to iterate through all the nodes instead of breaking at the first match. BUG=b:227528898 TEST=zmake build lazor, test manually on Lazor BRANCH=none Signed-off-by: Parth Malkan <parthmalkan@google.com> Change-Id: I5e11e3a75050110563521fcd84b5f96fd51921c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3609116 Reviewed-by: Wai-Hong Tam <waihong@google.com>
| * Revert "Quackingstick: Turn off LED before enter EC hibernate"Knox Chiou2022-04-271-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 12c333e6029fb77caf8d5d2e32fabcbcfd667b44. Reason for revert: CL:3598690 would solve the issue b/228570817 Original change's description: > Quackingstick: Turn off LED before enter EC hibernate > > Turn off LED in board_hibernate. > > BUG=b:228570817 > BRANCH=trogdor > TEST=make sure LED off after run hibernate in ec console > > Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> > Change-Id: I7081d92f662215fd0fea845e6dd44584a4281231 > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3581233 > Reviewed-by: Bob Moragues <moragues@chromium.org> > Commit-Queue: Bob Moragues <moragues@chromium.org> Bug: b:228570817 Change-Id: I5482a8d8a31c26a9b8f67c9faffea88575b6a22e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3607417 Auto-Submit: Knox Chiou <knoxchiou@chromium.org> Tested-by: Knox Chiou <knoxchiou@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Wai-Hong Tam <waihong@google.com>
| * ec: Mock out mkbp_send_event in kasa test.Jeremy Bettis2022-04-271-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Very rarely, the kasa test triggers 52 lines of coverage in common/mkbp_event.c, with the entry point mkbp_send_event(). Add an empty implementation of that function to prevent any code from calling into common/mkbp_event.c. BRANCH=None BUG=b:230610934 TEST=Ran kasa test 50 times Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I5adee0b44ce65af6dc2abddb57b004af7388d12f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3610685 Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Al Semjonovs <asemjonovs@google.com> Commit-Queue: Al Semjonovs <asemjonovs@google.com> Tested-by: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
| * zephyr: mtlrvp: Enable Vboot EFS2Brandon Breitenstein2022-04-271-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enable EFS2 to enable TCPMv2 and image verification BUG=b:229073490 BRANCH=none TEST=zmake mtlrvpp_npcx and verify Type-C port functionality Signed-off-by: Brandon Breitenstein <brandon.breitenstein@intel.com> Change-Id: I405f9e762acd25ff15505055cbde6cac147780b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3607059 Reviewed-by: RAJESH KUMAR <rajesh3.kumar@intel.com> Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Sam Hurst <shurst@google.com>
| * zephyr: mchp: Add mec1727 board specific configurationmartin yan2022-04-275-0/+347
| | | | | | | | | | | | | | | | | | | | | | | | | | Add mec1727 board specific configuration BUG=none BRANCH=main TEST=zmake testall Signed-off-by: martin yan <martin.yan@microchip.corp-partner.google.com> Change-Id: Ia39f959329d7be86b926fa8017a1f6527523ed69 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3606923 Reviewed-by: Yuval Peress <peress@google.com>
| * zephyr: mchp: Remove shim flash read APImartin yan2022-04-272-10/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | Remove shim flash read API, use flash read API from zephyr main driver BUG=none BRANCH=main TEST=zmake testall Signed-off-by: martin yan <martin.yan@microchip.corp-partner.google.com> Change-Id: I2375131ab6d9be50e9207ff34791d392c8950656 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3606922 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
| * zephyr: attach_src_snk test correct assumesAaron Massey2022-04-271-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Several mistaken zassume calls were being made that were supposed to be zasserts. Correct these to zassert. BRANCH=none BUG=None TEST=zmake test test-drivers Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: Idd0d99e00de11752550bd0c752d0879635957003 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3598174 Reviewed-by: Al Semjonovs <asemjonovs@google.com> Commit-Queue: Al Semjonovs <asemjonovs@google.com>
| * zephyr: mchp: Modify shim gpio includemartin yan2022-04-272-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Modify shim gpio include directory, not from zephyr main driver BUG=none BRANCH=main TEST=zmake testall Signed-off-by: martin yan <martin.yan@microchip.corp-partner.google.com> Change-Id: I3329945bcf91a972c706fd8523f3b83d6cd08653 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3606919 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Wai-Hong Tam <waihong@google.com>
| * zephyr:test: Add GOTO_MIN test caseAl Semjonovs2022-04-271-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | Send GOTO_MIN request and verify PD negotiation completes BUG=b:230470062 BRANCH=NONE TEST=zmake test test-drivers Signed-off-by: Al Semjonovs <asemjonovs@google.com> Change-Id: Ib13fc4f31476f2863a5cbd30c4da17b37293c129 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3607062 Reviewed-by: Tristan Honscheid <honscheid@google.com>
| * zephyr:test: Add GOTO_MIN supportAl Semjonovs2022-04-271-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | Add GOTO_MIN support to sink emulator BUG=b:230470062 BRANCH=NONE TEST=zmake test test-drivers Signed-off-by: Al Semjonovs <asemjonovs@google.com> Change-Id: I249bb04032d09aaf1f9a66ca0b57b615740e7445 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3607061 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
| * nissa: Initial zephyr config for craaskSue Chen2022-04-2711-1/+1399
| | | | | | | | | | | | | | | | | | | | | | | | | | Initial EC Zephyr config for Nissa/Craask. BUG=none TEST=zmake build craask BRANCH=none Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: Ic9b4d6d42b8a92edf8181532faeb09d6b7fca6d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3607909 Reviewed-by: Andrew McRae <amcrae@google.com>
| * burnet: Replace 2nd source base accel sensorDevin Lu2022-04-272-27/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | This patch replaces 2nd source base accelerometer to ICM-42607. BUG=b:230553688 BRANCH=firmware-kukui-12573.B TEST=On Burnet. Sensor works. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: Ia5456f2f87d644821371ac0ffdea16c07a5c3fff Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3508936 Reviewed-by: Eric Yilun Lin <yllin@google.com>
View Lorry Controller Status