summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* zephyr: docs: add SS Mux and Retimer documentationSam Hurst2022-09-261-0/+93
| | | | | | | | | | | | | | | Document the Retimer Kconfig.retimer and SS Mux Kconfig.usbc_ss_mux options BUG=b:208437225 TEST=Browse doc in gerrit BRANCH=main Signed-off-by: Sam Hurst <shurst@google.com> Change-Id: I55fc6b247357e8f7a90111c209eaffc6f925bf2e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3451008 Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: docs: add PPC documentationSam Hurst2022-09-261-0/+69
| | | | | | | | | | | | | | Document the PPC Kconfig.ppc options BUG=b:208437225 TEST=Browse doc in gerrit BRANCH=main Signed-off-by: Sam Hurst <shurst@google.com> Change-Id: I35ebfc7929438e49d6fbaa82c16d204956277de4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3451257 Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* test: Add tags for system testsAaron Massey2022-09-261-0/+6
| | | | | | | | | | | | | | | | | The common system code tests should contain tags so they can be selected to be run with the -t option. Add the common and system tags to the drivers testcase yaml BRANCH=none BUG=b:248106876 TEST=./twister --clobber -i -t system TEST=./twister --clobber -i -t common Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I5a378cbea359a4771b0b33f35aadf2cd6016c6fd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3914143 Reviewed-by: Keith Short <keithshort@chromium.org>
* test: Cover all sysjump console command linesAaron Massey2022-09-262-4/+113
| | | | | | | | | | | | | | | | Test all reachable lines in the in sysjump console command. Mocked out functions that seem too complicated to fully validate in native posix at the moment, such as jump_to_image(); BRANCH=none BUG=b:248106876 TEST=./twister --clobber -i -s zephyr/test/drivers/drivers.system Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I0c39cc33e70f0a215eb9af92889a66c81b7b5259 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3914142 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Sam Hurst <shurst@google.com>
* zephyr: #ifdef code in `common/timer.c` not used in ZephyrTristan Honscheid2022-09-261-19/+22
| | | | | | | | | | | | | | | | Several functions in `common/timer.c` are not used in Zephyr-based builds. Exclude these with `#ifndef CONFIG_ZEPHYR`. BRANCH=None BUG=b:247608485 TEST=./twister LOW_COVERAGE_REASON=No new code; Minor re-org of non-Zephyr functions Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: I2858f8b9b59b279f8b786abca26a3b2471db59cc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3910979 Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* Revert "common: replace safe_memcmp with cryptoc version"Jeremy Bettis2022-09-267-15/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 85554f0a843daa1c85ba252c7a27a389968d347b. Reason for revert: Broke gitlab (https://gitlab.com/zephyr-ec/ec/-/pipelines/651162463) and also CQ emerge builds (https://ci.chromium.org/ui/p/chromeos/builders/postsubmit/nissa-postsubmit/16030/overview) Original change's description: > common: replace safe_memcmp with cryptoc version > > We now have to always link against cryptoc, but it does not increase > code size on our most constrained boards: > > Before and after both show: > > Smallest free spaces in RO flash (bytes): > pdeval-stm32f072: 88 > servo_v4 : 104 > fusb307bgevb: 156 > > Smallest free spaces in RW flash (bytes): > volteer : 516 > bobba : 712 > meep : 716 > > Tightest boards' RW RAM images, bytes free: > whiskers : 212 > minimuffin: 284 > zinger : 284 > > BRANCH=none > BUG=b:169156874 > TEST=make buildall > > Signed-off-by: Tom Hughes <tomhughes@chromium.org> > Change-Id: I98422eccb3e903bd82ddb386087dd2d55d1f845e > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2424068 > Reviewed-by: Denis Brockus <dbrockus@chromium.org> > Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Bug: b:169156874 Change-Id: I794ae31f9e217677471b0ff164fadc9623571a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3919500 Commit-Queue: Raul Rangel <rrangel@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Raul Rangel <rrangel@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
* Frostflow : Initial BOARDLogan_Liao2022-09-2613-0/+728
| | | | | | | | | | | | | | | | | | This patch initial Frostflow board base on Skyrim. LOW_COVERAGE_REASON=New device specific configuration BUG=b:246870960 BRANCH=none TEST=zmake build frostflow success. Change-Id: Ic4ca453a74dec4bbd390e856844ced5c02991775 Signed-off-by: Logan_Liao <logan_Liao@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3915744 Commit-Queue: Bob Moragues <moragues@chromium.org> Tested-by: Bob Moragues <moragues@chromium.org> Code-Coverage: Bob Moragues <moragues@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org> Reviewed-by: Logan Liao <logan_liao@compal.corp-partner.google.com>
* rex: Add support for C1 USB3 daughter boardScott Collyer2022-09-265-31/+105
| | | | | | | | | | | | | | | | | | | | | | | This CL adds the configs required to support the USB3 C1 daughter board. In addition, the usbc support functions were updated to support C1. BRANCH=none BUG=b:240434243 TEST=zmake build rex Verified that C1 can attach and negotiate PD contract in both sink and source power roles. LOW_COVERAGE_REASON=This module does not currently have test coverage. b/247796816 has been opened to track the effort to add project specific tests for Rex. Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: I0782cf918b39b50713ca96d92d135e3122ac61c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3877665 Tested-by: Scott Collyer <scollyer@chromium.org> Commit-Queue: Scott Collyer <scollyer@chromium.org> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: rex: Enable keyboard backlightRajesh Kumar2022-09-261-0/+13
| | | | | | | | | | | | | | | | This enables keyboard backlight dts configuration for rex platform. BRANCH=none BUG=none TEST=zmake build rex; Tested using EC console command 'kblight' Signed-off-by: Rajesh kumar <rajesh3.kumar@intel.com> Change-Id: I6ecffecda9d10333dee1a94b0ce35ff58ac1f53b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3917422 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Tristan Honscheid <honscheid@google.com> Reviewed-by: Scott Collyer <scollyer@chromium.org>
* zephyr: test: kingler: remove duplicated dts nodesFabio Baltieri2022-09-261-2/+2
| | | | | | | | | | | | | | | | | | Fixes: devicetree error: ././common.dts:59 (column 22): parse error: /named-i2c-ports/sensor: duplicate node name The check has been introduced recently upstream. BRANCH=none BUG=none TEST=./twister -v -T zephyr/test/kingler -c Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Cq-Depend: chromium:3912957 Change-Id: I95035c5aef51df3f9cd91883b4a805dcc787874b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3919030 Reviewed-by: Jonathon Murphy <jpmurphy@google.com>
* common: replace safe_memcmp with cryptoc versionTom Hughes2022-09-267-34/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We now have to always link against cryptoc, but it does not increase code size on our most constrained boards: Before and after both show: Smallest free spaces in RO flash (bytes): pdeval-stm32f072: 88 servo_v4 : 104 fusb307bgevb: 156 Smallest free spaces in RW flash (bytes): volteer : 516 bobba : 712 meep : 716 Tightest boards' RW RAM images, bytes free: whiskers : 212 minimuffin: 284 zinger : 284 BRANCH=none BUG=b:169156874 TEST=make buildall Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I98422eccb3e903bd82ddb386087dd2d55d1f845e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2424068 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: create fakes for the shimmed tasksKeith Short2022-09-268-5/+69
| | | | | | | | | | | | | | | Many tests don't actually require the shimmed tasks. Create stub task entries and fakes for the task API. This allows tests to disable CONFIG_SHIMMED_TASKS. BUG=none BRANCH=none TEST=./twister Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I2da33bc76189447d09e01587e4c8ef496890d3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3916580 Reviewed-by: Tristan Honscheid <honscheid@google.com>
* zephyr: tests: Create test_utils libraryKeith Short2022-09-269-5/+17
| | | | | | | | | | | | | | | Create a common library that can be shared by all tests. Currently defines the FFF globals. BUG=none BRANCH=none TEST=twister Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: Iaff8bcf428c24fcb2aebdc56ad54c96586c17d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3916579 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* winterhold: modified fw config structureJosh Tsai2022-09-264-91/+43
| | | | | | | | | | | | | | | | | | | | | | winterhold only need to implement keyboard backlight fw config in cbi. Remove unused fw config and add the override ec feature function BRANCH=none BUG=b:242241410 TEST=zmake build --coverage winterhold TEST=when cbi fw_config set to 0x02, the ec feature EC_FEATURE_PWM_KEYB is set to 1 LOW_COVERAGE_REASON=no unit tests for skyrim yet Signed-off-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com> Change-Id: I349b64b72bb7bff9f07cab3d3feeb0a50b893aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3891566 Reviewed-by: Diana Z <dzigterman@chromium.org> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Code-Coverage: Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Diana Z <dzigterman@chromium.org>
* test: usbc_ppc: functions called with bad argsAaron Massey2022-09-261-0/+61
| | | | | | | | | | | | | | | Add test that verifies the various functions used by herobrine in the usbc ppc common code return appropriate values. BRANCH=none BUG=b:247854991 TEST=twister --clobber -i -s zephyr/test/drivers/drivers.usbc_ppc Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I08e3741a496a5eea508d2324c3de453630eaf964 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3906616 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* usbc_ppc: Enable console logs for testsAaron Massey2022-09-262-7/+12
| | | | | | | | | | | | | | | | | | | | | The usbc_ppc common code originally disabled console logging as it seemingly made the amtpon board fail. However, whatever reason this may have been no longer seems to be the case. Enable common code usbc_ppc console logs on tests. BRANCH=none BUG=b:247854991 TEST=twister --clobber -i -s zephyr/test/drivers/drivers.usbc_ppc TEST=make tests BOARD=ampton -j TEST=make runhosttests -j Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I73a4208bbb6b4841a0ccb3dccf8aa97cd2e2fd67 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3908160 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Al Semjonovs <asemjonovs@google.com> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* test: Add initial common usbc ppc testAaron Massey2022-09-265-0/+72
| | | | | | | | | | | | | | | | | | | Add initial common usbc ppc tests which verify the log output from the ppc_dump console command. BRANCH=none BUG=b:247854991 TEST=twister --clobber -i -s zephyr/test/drivers/drivers.usbc_ppc Signed-off-by: Aaron Massey <aaronmassey@google.com> Cq-Depend: chromium:3908160 Change-Id: I1fb244b0b64a4d06ff0c2ec75aebb4bf85e548f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3906615 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Aaron Massey <aaronmassey@google.com> Reviewed-by: Yuval Peress <peress@google.com> Commit-Queue: Aaron Massey <aaronmassey@google.com>
* zephyr: docs: add PD documentationSam Hurst2022-09-261-0/+131
| | | | | | | | | | | | | | Document the PD Kconfig.pd options and sub-options BUG=b:208437225 TEST=Browse doc in gerrit BRANCH=main Signed-off-by: Sam Hurst <shurst@google.com> Change-Id: I2a6e1e193637bc5089b6f77e135745e27c46c7b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3451256 Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: dts: fix a bunch of duplicate node nameFabio Baltieri2022-09-268-112/+86
| | | | | | | | | | | | | | | | | Upstream Zephyr recently introduced a change to detect duplicate dts node names, as that is against the devicetree specs. Fix various internal dts files by deduplicating few nodes and merging some aliases blocks. BRANCH=none BUG=none TEST=zmake build <board> Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I8697a8dfc93748d90d11cada6b0b0b9bb3a74fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3916394 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
* rt9490: implement get/set_optionEric Yilun Lin2022-09-262-0/+26
| | | | | | | | | | | | | | | | | | | RT9490 doesn't support charger options, but we still need to implement this function in case of the charger_task reports charge problem and it caused the busy charger_task. BUG=b:246704732 TEST=no charge_problem at the krabby's console BRANCH=none Change-Id: I2a2518d9ef501a1ee9a80603a54772ad5c2bf990 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3906518 Tested-by: Eric Yilun Lin <yllin@google.com> Auto-Submit: Eric Yilun Lin <yllin@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org>
* zephyr: fix doubled named-gpios nodeDawid Niedzwiecki2022-09-261-4/+4
| | | | | | | | | | | | | | | | One of the named-gpios node is doubled by mistake. Change the port and pin to unused ones. BUG=b:240619570 TEST=./twister -T zephyr/test/ BRANCH=main Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: Idff71c59bb8f9b95b223d0c13d3fcd5a5d3e45cf Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3913398 Reviewed-by: Tristan Honscheid <honscheid@google.com> Commit-Queue: Dawid Niedzwiecki <dawidn@google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: krabby: usb_config.c refactorTing Shen2022-09-266-277/+155
| | | | | | | | | | | | | | | | | | | split usb_config.c into common part and ppc/bc12 config BUG=none TEST=zmake {krabby,tentacruel} BRANCH=none LOW_COVERAGE_REASON=test code CL:3902757 wip Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: If871072bbbf073df20eb71fa1d2ca8dd47ce636a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3902756 Commit-Queue: Ting Shen <phoenixshen@chromium.org> Code-Coverage: Ting Shen <phoenixshen@chromium.org> Code-Coverage: Chen-Tsung Hsieh <chentsung@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com> Tested-by: Ting Shen <phoenixshen@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* yaviks: add fan supportZick Wei2022-09-264-2/+71
| | | | | | | | | | | | | | BUG=b:241964549 BRANCH=none TEST=Probe PWM work intended. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I6545e145676549494e7e2fa2a49019de36f8da42 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3915761 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Commit-Queue: Andrew McRae <amcrae@google.com> Reviewed-by: Devin Lu <devin.lu@quantatw.com> Code-Coverage: Andrew McRae <amcrae@google.com>
* zephyr: cleanup: ite: Remove deprecated sectionsTim Lin2022-09-261-11/+0
| | | | | | | | | | | | | | | | | | 1. BBRAM driver has already been moved to upstream zephyr, so this node can be dropped. 2. 'label' of SHI is deprecated. BUG=none BRANCH=none TEST=zmake build it8xxx2_evb --clobber TEST=BBRAM test: The chip reset flags can be saved after rebooting. Signed-off-by: Tim Lin <tim2.lin@ite.corp-partner.google.com> Change-Id: I3c79cd8bc1cda74091d9a1dd11e39fba20f6914b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3359159 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Peter Marheine <pmarheine@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com>
* zephyr/usbc: disable DRD support by defaultPeter Marheine2022-09-265-5/+11
| | | | | | | | | | | | | | | | | | | | | EC-OS config.h disables CONFIG_USB_PD_USB32_DRD by default, so update the Zephyr kconfig to match. Most devices are DFP-only, but the USB3.2 DRD option is currently only used on devices that support USB4 and only affects reported capabilities in Enter_USB messages so this misconfiguration will usually not be noticed. Existing projects that support USB4 and either don't disable DRD support explicitly or enable it in EC-OS builds are changed to explicitly enable this option, to avoid unexpected configuration changes for those projects. BUG=none TEST=zmake testall BRANCH=none Change-Id: Ib2191b960aed77ab2801c27a60c48cb4339cf558 Signed-off-by: Peter Marheine <pmarheine@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3915745 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* c2d2,servo_micro,servo_v4,servo_v4p1,sweetberry: add OWNERSMatthew Blecker2022-09-245-0/+13
| | | | | | | | | | | | BRANCH=none BUG=none TEST=none Signed-off-by: Matthew Blecker <matthewb@chromium.org> Change-Id: Id907f9b4f8db252abedb7e0ce56ccc92aaeb3516 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3916926 Reviewed-by: Brian Nemec <bnemec@google.com> Commit-Queue: Brian Nemec <bnemec@google.com>
* test: Reset system_is_locked fakeAaron Massey2022-09-231-0/+1
| | | | | | | | | | | | | | | | | The fff_reset_rule neglected to reset the system_is_locked fake despite it being declared within the same source file. Invoke RESET_FAKE(system_is_locked) in the fff_reset_rule. BRANCH=none BUG=none TEST=./twister --clobber -i -T zephyr/test/drivers Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I9f569ba5d85a2ba8a0555150454d57a472f32906 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3914141 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* test: system_hibernate() pathsAaron Massey2022-09-234-1/+47
| | | | | | | | | | | | | | | Verify all potential code paths in system_hibernate() call the appropriate functions with correct values. BRANCH=none BUG=b:248106876 TEST=./twister --clobber -i -s zephyr/test/drivers/drivers.system Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: Ic7593c8cec8d7a9f552e0d75864d8e640d2bb038 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3914988 Reviewed-by: Wai-Hong Tam <waihong@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* test: system_common_pre_init() w/ watchdog panicAaron Massey2022-09-231-0/+14
| | | | | | | | | | | | | | | | Verify system_common_pre_init() sets the panic reason to be PANIC_SW_WATCHDOG when the EC_RESET_FLAG_WATCHDOG is present in the reset flags. BRANCH=none BUG=b:248106876 TEST=./twister --clobber -i -s zephyr/test/drivers/drivers.system Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I9ec29e20751eebe756eaabdeec1b30b9df47c7c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3914987 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Tristan Honscheid <honscheid@google.com>
* test: system get_program_memory_addr invalid argsAaron Massey2022-09-231-0/+5
| | | | | | | | | | | | | | | Verify get_program_memory_addr() returns an INVALID_ADDR error code when called with invalid arguments. BRANCH=none BUG=b:248106876 TEST=./twister --clobber -i -s zephyr/test/drivers/drivers.system Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I9684f8bcf47a20a492f0e55b1193dd5a14645072 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3914050 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: tests: Test `common/timer.c` console commandsTristan Honscheid2022-09-231-0/+48
| | | | | | | | | | | | | | Test two console commands, gettime and timerinfo. BRANCH=None BUG=b:247608485 TEST=./twister Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: Iecd55f003aacc3ce68e63c3f41de3e327aa39c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3910978 Reviewed-by: Yuval Peress <peress@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: tests: Test timer_init() in common/timer.cTristan Honscheid2022-09-236-1/+107
| | | | | | | | | | | | | | | Test the timer initialization function. Add some mocks for the board-level functions and the jump tag API. BRANCH=None BUG=b:247608485 TEST=./twister Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: I7edeca26e93f18c467618691967299f411507166 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3910977 Reviewed-by: Tomasz Michalec <tmichalec@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* test: CBI version enabled system_get_board_versionAaron Massey2022-09-236-15/+76
| | | | | | | | | | | | | | | | | | Verify system_get_board_version() returns appropriate values when CBI board version is enabled. Also splits out the default test for board version when CBI board version is not enabled. BRANCH=none BUG=b:248106876 TEST=./twister --clobber -i -s zephyr/test/drivers/drivers.system TEST=./twister --clobber -i -s zephyr/test/drivers/drivers.system_board_version_cbi Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I7544d67e8d2a8435fb256f90aa26958cff357805 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3914182 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Al Semjonovs <asemjonovs@google.com>
* util/lock: Fix license headersTom Hughes2022-09-237-204/+24
| | | | | | | | | | | BRANCH=none BUG=b:248361020 TEST=CQ passes Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Ie3067e40c40f2734a4c35cfaf0552cadf132eaf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3914986 Reviewed-by: Diana Z <dzigterman@chromium.org>
* test: system_get_sku_id() calls board_get_sku_id()Aaron Massey2022-09-233-8/+26
| | | | | | | | | | | | | | | | Verify that system_get_sku_id() returns a sku id provided by a board-provided function when CONFIG_HOST_CMD_AP_SET_SKUID is not enabled. BRANCH=none BUG=b:248106876 TEST=./twister --clobber -i -s zephyr/test/drivers/drivers.system Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: Ic4aee4bf51c351ebf43b8df95a2e27dd75d4eb96 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3911313 Reviewed-by: Yuval Peress <peress@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: Add test for Steelix alt motion sensorswen zhang2022-09-237-0/+152
| | | | | | | | | | | | | | | Add test for Steelix alt motion sensors in Kingler board. BUG=b:246657828 TEST=./twister --coverage -v -i -T zephyr/test/kingler BRANCH=none Change-Id: I76f5a1841607c5d873f244ea27912ae360bb6472 Signed-off-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3893616 Reviewed-by: Mike Lee <mike5@huaqin.corp-partner.google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* steelix: Add second sources for motion sensorwen zhang2022-09-236-3/+198
| | | | | | | | | | | | | | | | | Add LSM6DSM and LIS2DW12 for Steelix, enable the alternative motion sensors by checking SSFC. BUG=b:246657828 TEST=1.zmake build steelix 2.ectool motionsense can get the alt_sensor data BRANCH=none Change-Id: I911bf1d8b0e100739c93b151beaa48963d5597f8 Signed-off-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3861819 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Mike Lee <mike5@huaqin.corp-partner.google.com>
* Skyrim: Remove workaround board checkDiana Z2022-09-221-8/+1
| | | | | | | | | | | | | | | | | | The workaround for the MP2845A will be needed for all boards until the MP2845B is available. Remove the board version check and revisit when new chips are available. LOW_COVERAGE_REASON=no unit tests for skyrim yet, b/247151116 BRANCH=None BUG=b:244457125 TEST=zmake build skyrim Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I3d7fee2b783697f10b70ce2889f10ba296dd9f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3914049 Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Keith Short <keithshort@chromium.org>
* test: Split common/system.c from default driversAaron Massey2022-09-226-4/+17
| | | | | | | | | | | | | | | | To facilitate faster and more hermetic testing, split the tests for the common system code as as another test binary. BRANCH=none BUG=b:248106876 TEST=./twister --clobber -i -s zephyr/test/drivers/drivers.default TEST=./twister --clobber -i -s zephyr/test/drivers/drivers.system Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I563e06602967d810730642a936296ca5853a3a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3910910 Reviewed-by: Tristan Honscheid <honscheid@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* test: use structs initialized in mock for assertionsFiras Sammoura2022-09-223-18/+11
| | | | | | | | | | | | | | | | | Use the structs initialized in rollback_latest_mock.c to test assert the correct outcome from get_latest_rollback function in test/rollback_secret.c. Add extern declaration in rollback_latest_mock.h in order to use these structs in test/rollback_secret.c. BRANCH=None BUG=b:242720910 TEST=make run-rollback_secret TEST=make runhosttests Signed-off-by: Firas Sammoura <fsammoura@google.com> Change-Id: Ieceb267806d9dc56a968757738e5f736e9108983 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3914291 Reviewed-by: Bobby Casey <bobbycasey@google.com>
* test: Add test for rollback_get_secretFiras Sammoura2022-09-229-1/+201
| | | | | | | | | | | | | | | | Add tests for rollback_get_secret when the get_latest_rollback fails, returns a trivial secret, and returns a real secret. BRANCH=None BUG=b:242720910 TEST=make run-rollback_secret TEST=make runhosttests Signed-off-by: Firas Sammoura <fsammoura@google.com> Change-Id: I992daf7af3e80dcc4b20412037f792e125866af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3900486 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Bobby Casey <bobbycasey@google.com>
* zephyr: enable sysrq and accelspoof commands for herobrine ECJoseph S. Barrera III2022-09-221-4/+2
| | | | | | | | | | | | | | | | The syseq and accelspoof commands were disabled on Lazor, which used a NPCX796FC with only 192KB code RAM. Herobrine uses the NPCX993F which has 256KB, which is sufficient to re-enable the commands. BUG=b:234771417 BRANCH=None TEST=Tested on herobrine. EC now shows both restored commands. Signed-off-by: Joseph S. Barrera III <joebar@chromium.org> Change-Id: I3deee2ec524a83174415c2ca8207e913eaf5b078 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3914745 Reviewed-by: Wai-Hong Tam <waihong@google.com> Reviewed-by: Douglas Anderson <dianders@chromium.org>
* test: Link usbc_alt_mode AP driven tests by configAaron Massey2022-09-224-124/+162
| | | | | | | | | | | | | | | | | | | | | The usbc_alt_mode test suite contained tests that should be skipped when the EC is configured to enter alternate modes without direction from the AP. Currently this is handled by skipping tests at runtime based on an enabled config, but it can be done statically. Refactor the usbc alt mode test suite to conditionally compile/link tests that require AP driven alternate mode entry. BRANCH=none BUG=b:236075587 TEST=zephyr/test/drivers/drivers.usbc_alt_mode TEST=zephyr/test/drivers/drivers.usbc_alt_mode_ec_entry Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: Id42b5a62f0dd88f2bea8b1f5288bf441db80e7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3906739 Reviewed-by: Yuval Peress <peress@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* test: Verify DP mode exit via PD info host cmdsAaron Massey2022-09-221-0/+43
| | | | | | | | | | | | | | | | Test that after entering DisplayPort alternative mode, the PD info request EC_CMD_PD_SET_AMODE can be used make the DPM exit the DisplayPort alternate mode. BRANCH=none BUG=b:236075275 TEST=twister --clobber -i -s zephyr/test/drivers/drivers.usbc_alt_mode Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I763e92fd6267b6720601c930571cb449c49ba091 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3896637 Reviewed-by: Yuval Peress <peress@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* anx7483: Mark tuning data as constant.Keith Short2022-09-221-4/+4
| | | | | | | | | | | | | | | The tuning data is not modified at runtime. Mark as constant to save RAM space. LOW_COVERAGE_REASON=anx7483 driver does not yet have tests b:248086547 BUG=none BRANCH=none TEST=zmake build -a Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I9bb80d804ceea5c54f02c2a2ee9f02c25009ba83 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3906614 Reviewed-by: Diana Z <dzigterman@chromium.org>
* intelrvp: Enable port80 moduleRajesh Kumar2022-09-221-0/+1
| | | | | | | | | | | | | | | | This enables port80 module, a way to report progress of the AP's boot status and dump POST code. BRANCH=none BUG=none TEST=Observed EC dumps Port80 POST code and 'port80' console command works. Signed-off-by: Rajesh Kumar <rajesh3.kumar@intel.com> Change-Id: I6e826685d283c6a0de2f6e6197cdad8440697fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3908156 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Yuval Peress <peress@google.com>
* yaviks: add 3S batteries supportZick Wei2022-09-221-0/+6
| | | | | | | | | | | | | | | Add batteries Cosmx si03058xl and SMP highpower_si03058xl into yaviks EC. BUG=b:245441421 BRANCH=none TEST=verify battery can discharge, charge, cut-off. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Ic820d4d7387706c0b46657c90cfeaaf398cfcaae Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3912396 Reviewed-by: Andrew McRae <amcrae@google.com> Reviewed-by: Devin Lu <devin.lu@quantatw.com>
* zephyr/battery: add new batteriesZick Wei2022-09-223-0/+110
| | | | | | | | | | | | | | | Add smp highpower_si03058xl and cosmx si03058xl battery setting. BUG=b:245441421 BRANCH=none TEST=verify EC can recognize batteries on yaviks Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I829def877744f6cad24033858cdba50f21742bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3844808 Reviewed-by: Devin Lu <devin.lu@quantatw.com> Reviewed-by: Andrew McRae <amcrae@google.com>
* kinox: modify OBP pointer valueMatt Wang2022-09-222-11/+11
| | | | | | | | | | | | | | The 170w and 230w OBP value change to ADC 2816mv and 2815mv. Because of the ADC converter max is 2816mv. BUG=b:247009142,b:211806236 BRANCH=none TEST=The 90w/170w/230w can successfully boot to OS. Signed-off-by: Matt Wang <matt_wang@compal.corp-partner.google.com> Change-Id: I6222cece83c2ae3e559aacb9f29842655fc68845 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3905447 Reviewed-by: Ricky Chang <rickytlchang@chromium.org>
* zephyr: test add rt9490 bc12 testTing Shen2022-09-223-1/+103
| | | | | | | | | | | | | | BUG=b:244233556 TEST=./twister -T zephyr/test/drivers/ BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I091c1dd6c292c22d86670079113bea4820669ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3901856 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
View Lorry Controller Status