summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* kalista: Increase fan to reduce throttling.firmware-kalista-11343.BRichard Yeh2023-01-301-59/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Chromebox for Meetings (CfM) devices are videoconferencing appliances. Discovering that a significant fraction of our fleet was throttling the CPU due to temperature, resulting in bad video quality, we have decided that these devices should never throttle. The present change reduces the temperature thresholds at which we increase fan speeds. For most of the time, when the CfM is idle, we expect no or little change in fan speeds. During calls, the CfM CPU can exceed 60 C, and the sensors controlling the fan are typically 10-20 degrees C cooler than the CPU, so we set the maximum-fan temperature to 50-55 C in an attempt to arrest any temperature increase before the CPU reaches throttling temperatures. We add fan tables to enable hysteresis in the fan speed setting. Fan RPMs are chosen to span the min-to-max range, while avoiding 50 Hz and 60 Hz line frequencies. fizz and kalista boards are shared with non-CfM versions, while the other boards are CfM-only. Since those boards are several years old, we plan to build these firmware changes only into CfM-branch releases, not all fizz and kalista devices. Additional details at go/cfm-overheating . Temperature traces with load testing on both top-of-tree and firmware with this change are shown at go/cfm-overheating#heading=h.ykpzxotgnu2j BRANCH=update-fan-tables BUG=b:252966838,b:191187610,chromium:1383859 TEST=Confirmed validity of settings with `ectool thermalset`. Built firmware, flashed to endeavour and excelsior (fizz), verified that fan turns on earlier. This does not completely prevent throttling from 47.25 W to 15.00 W on Kaby Lake boards (endeavour, fizz, kalista), but it does prevent dropping below 15.00 W. Comet Lake boards (ambassador, genesis, moonbuggy, scout) start at 15.00 W and rarely throttle anyway. Change-Id: I9259b05bcfa1bf4e6433df74913668424d005dbd Signed-off-by: Richard Yeh <rcy@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4060608 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> (cherry picked from commit 8f58bfa1e80614670ff8029334f52731eeafe1dc) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4201306 Reviewed-by: Kyle Williams <kdgwill@chromium.org>
* fan: Rewrite and test the most common custom fan_percent_to_rpm.Richard Yeh2023-01-303-13/+237
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | temp_ratio_to_rpm_hysteresis uses a sorted fan_table containing a mapping of temp_ratio (percent, 0-100) to fan rpm. This clarifies the relationship of temperature to fan speed, while reducing the number of static variables. The existing temp_ratio expressing the percentage of cooling needed (temperature from temp_fan_off to temp_fan_max) suggests the possibility that a proportional-integral-derivative (PID) feedback controller might have been considered; but the default implementation is purely linear (mapping to fan speed from min to max) and this stepwise one just enables hysteresis --- different speeds when the board is warming up than when cooling down. The hysteresis attempts to avoid oscillations in temperature and fan speed. This refactoring is in preparation for reusing this implementation for {ambassador, genesis, moonbuggy, scout}. {kalista, berknip, chronicler, dewatt, endeavour, ezkinil, fizz} define CONFIG_FAN_RPM_CUSTOM and use this or nearly this implementation of a fan_percent_to_rpm with hysteresis. {chronicler} also performs boxcar smoothing of the input. {osiris}, which has two fans, and {jinlon, redrix, and other boards with multiple sensors}, use a similar but not exactly the same implementation, and would need additional abstraction. See: https://source.chromium.org/search?q=f:ec%2Fb%20fan_step%20-f:board.c BRANCH=refactor-fan-percent-to-rpm BUG=b:252966838,b:191187610,chromium:1383859 TEST=make -j run-fan && make -j buildall && make -j runhosttests Signed-off-by: Richard Yeh <rcy@google.com> Change-Id: I50ad4d78ac1145f92573a417646c1f57b8945463 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4021951 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org> (cherry picked from commit 62c3a651befeb8d9b3ad03994b23b579d92c20d8) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4198534 Reviewed-by: Kyle Williams <kdgwill@chromium.org>
* Clear OWNERS for factory/firmware branchBrian Norris2021-09-102-10/+1
| | | | | | | | | | | | BUG=none TEST=none Change-Id: I0f03f432ada1064ffba9595be78ca7ab4d25ecd1 Signed-off-by: Brian Norris <briannorris@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3155189 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Owners-Override: Jora Jacobi <jora@google.com> Tested-by: Jack Rosenthal <jrosenth@chromium.org>
* stm32: Fix manual interrupt clearing functionCraig Hesling2020-03-161-1/+3
| | | | | | | | | | | | | | | | | | | | | This fixes a bug in gpio_clear_pending_interrupt, where all pending interrupts are unintentionally cleared. This is not in the code path for normal gpio interrupt handlers, since the normal interrupt clearing occurs in gpio_interrupt (right below this function). BRANCH=none BUG=chromium:1059520 TEST=none Signed-off-by: Craig Hesling <hesling@chromium.org> Change-Id: I4d6fe7947f4d76cf3b57dfbf3bb926e41851c80c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2101208 Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> (cherry picked from commit c2c2c083fef813e3e3c70f8c13a1418717ba682d) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2106676
* driver: bmi160: Check enable_fifo flags before processing FIFOGwendal Grignou2019-05-081-13/+13
| | | | | | | | | | | | | | | | | | | | | | If there is an interrupt pending after we suspend the BMI160, we will try to collect length from the FIFO, but the FIFO is suspended. Bring back enable_fifo flags check before processing the FIFO. It has been move after gathering the length in CL:1128555 BUG=b:127321764,b:131272795 BRANCH=master TEST=Using flip_flop.sh script at b/131272795#comment2 Check the messages "unexpected empty FIFO" disappear. Change-Id: Iaab1a7f3607b902acd92b75c926365d7eb09fd5e Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1585420 Reviewed-by: Enrico Granata <egranata@chromium.org> (cherry picked from commit d17cd2add14f1f1e32bd58d51d60a2c93f17f055) Reviewed-on: https://chromium-review.googlesource.com/1585471 (cherry picked from commit 2cc3e7ce65016520162198c0cafa30ef54271c21) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1597648
* Kalista: PMIC TPS650830 VR1 setting for hang up issueSue Chen2019-03-262-0/+10
| | | | | | | | | | | | | | | | | | | The issue was found from Fizz series. (BUG=b:128960577) Set PMIC register V100ACNT (0x37) to 0x1B [1:0] : 11b Forced PWM Operation. [5:4] : 01b Output Voltage Selet Vnom (1V) To improve +V1P00A ripple around 18mV. BUG=none BRANCH=firmware-kalista-11343.B TEST=make buildall -j Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I1c348712a5e2d5661cb1211c83fb17f329f61b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1538101 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Sue Chen <sue.chen@quanta.corp-partner.google.com> Tested-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
* Kalista: Set LED in HOOK_INITSue Chen2019-03-261-0/+15
| | | | | | | | | | | | | | | | | It needs to initialize the LED because the LED would be off after sysjump. BUG=b:129116318 BRANCH=kalista TEST=make buildall -j, use EC console sysjump to check if the led function is fine Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I31931b8bb56c5f037854009b10cdbc3a1d17b27b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1534903 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: David Huang <David.Huang@quantatw.com> Commit-Queue: David Huang <David.Huang@quantatw.com>
* karma: correct the fan_tableSue Chen2019-02-271-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | The CL:1379417 added the wrong fan table,which filled the temperature (Celsius) in the "on" and "off" columns. However, it should be the percent. The correct fan_table: on off RPM step0 1 0 step1 36 1 2180 step2 62 58 2680 step3 68 63 3300 step4 75 69 3760 step5 81 76 4220 step6 88 83 4660 step7 98 91 4900 BUG=b:118387189 BRANCH=kalista TEST=check fan target speed in each step are right, make -j buildall pass Change-Id: Ic420029d4d3d29bf426747ecc7592dce077f975f Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/1485032 Reviewed-by: David Huang <David.Huang@quantatw.com> Reviewed-by: Vincent Wang <vwang@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* OZ554: set power up sequence.Ryan Zhang2019-02-272-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Spec says backlight should be turned on after 500ms after eDP signals are ready. 2. There's no way to get exact eDP ready time, therefore, give one second delay. power up __/---------------- eDP ______/------------ backlight _____________/----- |- t1 -| : >=500 ms |- t2 -| : 1 second is enough BUG=b:120237453 BRANCH=ToT TEST=Test results is in crosbug 120237453, comment #31 Signed-off-by: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com> Change-Id: I63e4536a9d8a7e5febf4ee76f05cbe7c014c7faa Reviewed-on: https://chromium-review.googlesource.com/1389975 Commit-Ready: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com> Tested-by: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> (cherry picked from commit 219b09e87f61ffb410fe1a1dbaed4983460fefb4) Reviewed-on: https://chromium-review.googlesource.com/c/1490792 Commit-Queue: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com>
* Karma: Add PANEL_LM_SSK1 panel settings to OZ554Sue Chen2019-01-303-3/+41
| | | | | | | | | | | | | | | | | | | GPIOC5, GPIO01 and GPIOB1 are used for panel id. Register 0x02: setting LED current to 55(mA) (offset = 2, data = 0x55) BUG=b/120237453 BRANCH=kalista TEST=make buildall Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I6668d0930d150c0a10ab70d6539f1415ea231e8a Reviewed-on: https://chromium-review.googlesource.com/c/1416072 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
* oz554: Add oz554_set_config APISue Chen2019-01-302-5/+32
| | | | | | | | | | | | | | | | | This patch adds oz554_set_config API and oz554_board_init callback so that oz554 initialization can be customized by each board. Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> BUG=b/120237453 BRANCH=kalista TEST=make buildall Change-Id: I44e83e4cd25eb0794009b621e96d962a97a84fbb Reviewed-on: https://chromium-review.googlesource.com/c/1443859 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
* USB-PD: Disable Vconn on SRC_DISCONNECTDaisuke Nojiri2019-01-161-1/+4
| | | | | | | | | | | | | | | | | | | | | | Currently, source only devices do not turn off Vconn when a partner is disconnected. This causes the polarity detection to be disabled. This patch turns off Vconn on SRC_DISCONNECT for !CONFIG_USB_PD_DUAL_ROLE boards. Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> BUG=b/122861749 BRANCH=Kalista TEST=Plug in an ethernet dongle via a USB-C-to-A adapter. Replug it upside down and verify Ethernet is turned on on both sides. Change-Id: I4ac303f2121d9e4114ce7097db304e4f65f27ae0 Reviewed-on: https://chromium-review.googlesource.com/c/1412992 Tested-by: David Huang <David.Huang@quantatw.com> Reviewed-by: David Huang <David.Huang@quantatw.com> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: David Huang <David.Huang@quantatw.com>
* oz554: Keep interrupt always enabledDaisuke Nojiri2019-01-081-8/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | OZ554ALN asserts the interrupt when it's ready for writing settings and settings are cleared when it's turned off (i.e. S3/S5). Therefore, we do not need to toggle the interrupt on power state transitions. This patch makes the interrupt enabled on HOOK_INIT. It's assumed the device doesn't have a lid. For clamshell devices, different interrupt & power control scheme may be needed. Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> BUG=b/120237453 BRANCH=Kalista TEST=Verified display backlight is turned on/off as system changes power states (s0/s3/s5) with sysjump enabled. Change-Id: Ia911993abd76c09e79025ea454e456781b5b2fc1 Reviewed-on: https://chromium-review.googlesource.com/c/1400081 Reviewed-by: David Huang <David.Huang@quantatw.com> Reviewed-by: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: David Huang <David.Huang@quantatw.com> Commit-Queue: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com> Tested-by: David Huang <David.Huang@quantatw.com> Tested-by: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com>
* Karma: add new GPIORyan Zhang2019-01-081-1/+1
| | | | | | | | | | | | | | | | | | EC_PANEL_EDID_WRITE_EN_L is used as EDID write protect. HIGH: not able to write EDID LOW : able to write EDID BUG=b:118656999 BRANCH=master TEST=`ectool gpioset EC_PANEL_EDID_WRITE_EN_L 0` can write EDID `ectool gpioset EC_PANEL_EDID_WRITE_EN_L 1` can not write EDID Change-Id: Ide7d6650544fae7f6abd06ab8653e3053362687f Reviewed-on: https://chromium-review.googlesource.com/c/1389985 Reviewed-by: David Wu <david_wu@quanta.corp-partner.google.com> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: David Huang <David.Huang@quantatw.com> Tested-by: David Huang <David.Huang@quantatw.com>
* system: Make system_can_boot_ap return true for AC-only systemsDaisuke Nojiri2018-12-251-16/+14
| | | | | | | | | | | | | | | | | | | | | | | | | This patch makes system_can_boot_ap return true for systems which can be powered only by a fixed AC power (e.g. barrel jack AC adapter). Such systems do not need to check a battery percentage or AC power. Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> BUG=none BRANCH=none TEST=buildall Change-Id: Icd59b508e944c43253d416da78d0f1a87fedb13d Reviewed-on: https://chromium-review.googlesource.com/1301935 Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> (cherry picked from commit 84f85644089a74ad62ef12cfeb1592285f971b40) Reviewed-on: https://chromium-review.googlesource.com/c/1389984 Reviewed-by: David Wu <david_wu@quanta.corp-partner.google.com> Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> Tested-by: David Wu <david_wu@quanta.corp-partner.google.com> Tested-by: David Huang <David.Huang@quantatw.com> Commit-Queue: David Huang <David.Huang@quantatw.com>
* karma: fix ec build errorZhuohao Lee2018-12-243-116/+0
| | | | | | | | | This patch fixes the build error which is caused by the cherry-pick CL:1385767. BUG=b:121546793 BRANCH=firmware-kalista-11343.B TEST=build pass
* USB-PD: Don't make charge_manager save log if it's not presentDaisuke Nojiri2018-12-241-0/+2
| | | | | | | | | | | | | | | | | | | | | | | Currently, pd_log assumes charge manager exists, thus, build fails if CONFIG_CHARGE_MANAGER is undefined because charge_manager_save_log is missing. This patch fixes it. Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> BUG=none BRANCH=none TEST=buildall Change-Id: I36156e7b376717a53e8a2cab7483b5150b4f2d61 Reviewed-on: https://chromium-review.googlesource.com/1300615 Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> (cherry picked from commit f234b0aeb2d51f13de683ed6400f3e07aa4b717c) Reviewed-on: https://chromium-review.googlesource.com/c/1389983 Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> Commit-Queue: Zhuohao Lee <zhuohao@chromium.org> Tested-by: Zhuohao Lee <zhuohao@chromium.org>
* karma: update thermal tableSue Chen2018-12-221-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | on off RPM step0 0 step1 30 5 2180 step2 49 46 2680 step3 53 50 3300 step4 58 54 3760 step5 63 59 4220 step6 68 64 4660 step7 75 70 4900 Prochot degree: active when t >= 81C release when t <= 77C Shutdown degree: when t >= 82C BUG=b:121154903 BRANCH=firmware-kalista-11343.B TEST=fan target speed follows table, make -j buildall pass Change-Id: I80a0b05cf1b693114fe664e5961973ed550fcc19 Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/1388228 Commit-Queue: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com> Tested-by: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* Karma: Enable 3A power supply over USB-C portDaisuke Nojiri2018-12-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | This patch makes Karma supply 3A over the USB-C port. Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> BUG=b:120794301 BRANCH=none TEST=Verify 5V,3A supplied to Samus, Pixel phone, and Sona. Change-Id: I7b955d470cde9cf5ca44acf685f91cfcadd201ca Reviewed-on: https://chromium-review.googlesource.com/1370933 Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> (cherry picked from commit a24524664282e7447acf16270af431738c320dff) Reviewed-on: https://chromium-review.googlesource.com/c/1388226 Commit-Queue: David Wu <david_wu@quanta.corp-partner.google.com> Commit-Queue: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com> Reviewed-by: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com>
* Kalista: Remove charger and USB-PD DRP supportDaisuke Nojiri2018-12-214-154/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Kalista doesn't have a battery, thus, doesn't need to manage charging or monitor battery status. Kalista is always a source device. Its USB-C doesn't need to toggle. Since it's not a mobile device, it doesn't need to put a TCPC in low power mode. * Charge Pixel phone via USB-C port at 1.5A, 5V * Display picture on HDMI monitor via Hoho * HP 240s (DRP monitor) * USB3 flash driver via USB-C to A dongle - Suzy-Q doesn't work (as expected) Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> BUG=b:111571989,b:118386334 BRANCH=none TEST=See above. Change-Id: I5771d77483472f918072e339311fb1c392df5d5d Reviewed-on: https://chromium-review.googlesource.com/c/1385905 Commit-Queue: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com> Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: David Wu <david_wu@quanta.corp-partner.google.com>
* oz554: Move oz554 driver code to common directoryDaisuke Nojiri2018-12-216-0/+127
| | | | | | | | | | | | | | | | | | | | | This patch moves oz554 LED driver code from Karma. Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> BUG=none BRANCH=none TEST=buildall Change-Id: Ia2808563b9c113e5ea3376f9327dff2578e20906 Reviewed-on: https://chromium-review.googlesource.com/1366015 Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> (cherry picked from commit 145f3271f7459f7a2fec6ba941f14c1ae00c14a6) Reviewed-on: https://chromium-review.googlesource.com/c/1385767 Commit-Queue: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: David Wu <david_wu@quanta.corp-partner.google.com>
* USB-PD: Fix build errors for non-DRPDaisuke Nojiri2018-12-211-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | This patch fixes build errors for devices which don't use DRP ports. pd_restart_tcpc is called within DRP context. So, the static definition has to be excluded accordingly. Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> BUG= BRANCH=none TEST=buildall Change-Id: I51decb0a2071230da3cdd91139f77d94b685ca5f Reviewed-on: https://chromium-review.googlesource.com/1300616 Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> (cherry picked from commit 160005b62144ea0569c23faa8214d27480f51ae0) Reviewed-on: https://chromium-review.googlesource.com/c/1385904 Commit-Queue: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: David Wu <david_wu@quanta.corp-partner.google.com>
* Kalista: Write panel settings to OZ554Tino Liu2018-12-204-1/+117
| | | | | | | | | | | | | | | | | | | GPIO44 is used for panel backlight enable interrupt. If EC receive rising interrupt, write panel settings to OZ554. BUG=b:120237453 BRANCH=none TEST=make buildall pass, panel can show screen properly Change-Id: I45cd12b5b334db39fa989ab435240d272dc39d7c Signed-off-by: Tino Liu <tino.liu@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/1351909 Commit-Ready: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com> Tested-by: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> (cherry picked from commit ef17e123c89b45cc6ee6ceaaf2a047f29ee60980) Reviewed-on: https://chromium-review.googlesource.com/c/1385766 Commit-Queue: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com>
* npcx7_evb: illustrate the flash configuration of npcx7m6fcCHLin2018-12-042-4/+18
| | | | | | | | | | | | | | | | | | | | | | | | | There are only 512 Kbytes of internal flash in npcx7m6fc, which is different from previous npcx7 chips with internal flash. This CL illustrates how to set the flash type and flash size when chip variant is npcx7m6fc. This CL also sets the BOARD_VERSION number according to the chip variant. Manually changing the BORAD_VERSION number is no longer need when we want to build the npcx7_evb board image of different chip variants. BRANCH=none BUG=none TEST=No build errors for make buildall. TEST=Switch to different chip variant in build.mk; build and flash the image; make sure each EC image can boot up on EVB of different chip variant. Change-Id: I430a39fae8c9516c0f22b0fe9868403a60b80d4a Signed-off-by: CHLin <CHLIN56@nuvoton.com> Reviewed-on: https://chromium-review.googlesource.com/1351918 Commit-Ready: CH Lin <chlin56@nuvoton.com> Tested-by: CH Lin <chlin56@nuvoton.com> Reviewed-by: Jett Rink <jettrink@chromium.org>
* nocturne: Log base power fault cause.Aseda Aboagye2018-12-041-1/+2
| | | | | | | | | | | | | | | | | | | | A base power fault can be triggered by either the eFuse or the USB protection chip. This commit logs the source of the base power fault. BUG=none BRANCH=firmware-nocturne-10984.B TEST=make -j buildall Change-Id: I1082d56fef2c0b1b2963f2af98216e455e7ab958 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/1358747 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> (cherry picked from commit 7836cdd6e6ce3ab11d49add01a91a59aa03057de) Reviewed-on: https://chromium-review.googlesource.com/1360073 Commit-Ready: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* cr50_fuzz: Disable this fuzz target until chromeos-ec is fixed.Allen Webb2018-12-041-1/+2
| | | | | | | | | | | | BRANCH=None BUG=chromium:911310 TEST=USE="ubsan asan fuzzer" ./build_packages \ --board=amd64-generic --skip_chroot_upgrade chromeos-ec Change-Id: Ib2ffc7035d0f6912834709bb8a5f6b3c11a2c67a Signed-off-by: Allen Webb <allenwebb@google.com> Reviewed-on: https://chromium-review.googlesource.com/1359652 Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
* servo_micro: Increase maximum I2C-over-USB write and read sizes.Matthew Blecker2018-12-041-0/+35
| | | | | | | | | | | | BRANCH=none BUG=b:79684405 TEST=This makes block_write_size up to 254B in iteflash work, and makes 256B verification reads work. Change-Id: I887f0eaacc87428a4646007520f27bdf5aaa231a Signed-off-by: Matthew Blecker <matthewb@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1351517 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* wov: Modify wov_set_gain to update gain params in wov_confScott Collyer2018-12-041-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | The function wov_set_gain would only pass along the desired channel gain values to the apm, but did not update channel gain parameters of wov_conf. This CL modifies this function to also update those parameters so they can be saved an retrieved by the audio codec. BRANCH=none BUG=b:116766596 TEST=On cheza verifed recording works using the following kernel commands and the loading the audio file into audacity. amixer -c 0 cset iface=MIXER,name='MultiMedia1 Mixer SEC_MI2S_TX' on amixer -c0 cset numid=27 30,30 arecord -D hw:0,0 -f dat /tmp/rec.wav -d 5 Change-Id: I2d0e1e386769bb25754a684b391362c4ea02b39b Signed-off-by: Scott Collyer <scollyer@google.com> Reviewed-on: https://chromium-review.googlesource.com/1356183 Commit-Ready: Scott Collyer <scollyer@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: CH Lin <chlin56@nuvoton.com> Reviewed-by: Wai-Hong Tam <waihong@google.com>
* wov: Split i2s_set_config into 2 functionsScott Collyer2018-12-042-11/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | This API was intended to be used to set both the I2S format and BCLK rate. However, the audio codec API has separate methods to set each of these parameters. This CL splits wov_i2s_set_config() into 2 functions: wov_i2s_set_fmt() - called by codec_i2s_set_fmt host command wov_i2s_set_bclk() - called by codec_i2s_set_bclk host command BRANCH=none BUG=b:116766596 TEST=On cheza verifed recording works using the following kernel commands and the loading the audio file into audacity. amixer -c 0 cset iface=MIXER,name='MultiMedia1 Mixer SEC_MI2S_TX' on amixer -c0 cset numid=27 30,30 arecord -D hw:0,0 -f dat /tmp/rec.wav -d 5 Change-Id: Id840ecf1b4c00762091d71b6cc10b00acc774eb2 Signed-off-by: Scott Collyer <scollyer@google.com> Reviewed-on: https://chromium-review.googlesource.com/1356182 Commit-Ready: Scott Collyer <scollyer@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: CH Lin <chlin56@nuvoton.com> Reviewed-by: Wai-Hong Tam <waihong@google.com>
* wov: Fix mispelling of wov_conf right_chan_gainScott Collyer2018-12-042-2/+2
| | | | | | | | | | | | | | | | The struct member right_chan_gain was spelled rigth_chan_gain. BRANCH=none BUG=b:116766596 TEST=make BOARD=cheza Change-Id: I0051ab5442315afbc7b51172a254358d6217b225 Signed-off-by: Scott Collyer <scollyer@google.com> Reviewed-on: https://chromium-review.googlesource.com/1356181 Commit-Ready: Scott Collyer <scollyer@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: CH Lin <chlin56@nuvoton.com> Reviewed-by: Wai-Hong Tam <waihong@google.com>
* wov: Detect I2S overrun/underrun burstsScott Collyer2018-12-041-0/+46
| | | | | | | | | | | | | | | | | | | This CL adds logic to detect when bursts of I2S overrun/underruns are ocurring. If this condiditon is ocurring then the ISR may consume all of the EC processing power resulint in watchdog events. BRANCH=none BUG=b:116766596 TEST=On Cheza, had BCLK on EC set 2x higher than AP. Without this CL, would consistently trigger watchdog reset. With CL, underrun storm is detected based on console print and watchdog reset no longer occurs. Change-Id: Ia398d5b36525a63d3341bf42fd3f6d12d93d41e0 Signed-off-by: Scott Collyer <scollyer@google.com> Reviewed-on: https://chromium-review.googlesource.com/1356180 Commit-Ready: Scott Collyer <scollyer@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com>
* ISH-i2c: support 1MHz, clock stretch, restartKyoung Kim2018-12-033-84/+158
| | | | | | | | | | | | | | | | | | | | | | - Support for 2 or more bytes size of command register in slave device. - Adjust parameters for FAST and FAST+ modes. - added Restart and SCL stretch BUG=b:113238573 TEST=test with FAST/FAST+ mode Elan TrackPad slave device. Use i2c_xfer() API inside a test task which GPIO interrupt (Elan device's INT line) wakes. Change-Id: I1ebcef90d85d6ede90bb8687e20058bdf31bf4e8 Signed-off-by: Kyoung Kim <kyoung.il.kim@intel.com> Reviewed-on: https://chromium-review.googlesource.com/996799 Commit-Ready: Caveh Jalali <caveh@google.com> Commit-Ready: Kyoung Il Kim <kyoung.il.kim@intel.com> Tested-by: Kyoung Il Kim <kyoung.il.kim@intel.com> Reviewed-by: Caveh Jalali <caveh@google.com> Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Kyoung Il Kim <kyoung.il.kim@intel.com>
* ec3po: use a copy of the logger objectMary Ruthven2018-12-032-2/+8
| | | | | | | | | | | | | | | | | | | | | Use a copy of the console and interpreter logger objects, so modifying the log level for one console does not affect the others. With this change you can enable the debug log level on the cr50 console without enabling debug for the ec console. The ec console prints a lot more messages than cr50, so it can be difficult to debug cr50 console issues if both consoles are set to debug. BUG=none BRANCH=none TEST=verify setting cr50 loglevel does not affect the ec loglevel. Change-Id: I529bf686443bf9df004e209e880f811608eef6a8 Signed-off-by: Mary Ruthven <mruthven@google.com> Reviewed-on: https://chromium-review.googlesource.com/1355967 Commit-Ready: Mary Ruthven <mruthven@chromium.org> Tested-by: Mary Ruthven <mruthven@chromium.org> Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
* Kasumi: add new batteryryan.zhang2018-12-032-0/+29
| | | | | | | | | | | | | | | | Kasumi new battery: Murata KT00304012 BUG=b:120248691 BRANCH=grunt TEST=`make buildall` PASS except cr50 and kukui. All battery parameters are good. Signed-off-by: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com> Change-Id: Ieb4213d455a32bd4ab48ae85ac824bb13d9326ee Reviewed-on: https://chromium-review.googlesource.com/1355643 Commit-Ready: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com> Tested-by: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com> Reviewed-by: Edward Hill <ecgh@chromium.org>
* Ampton: change the port0 mux to PS8751James_Chao2018-12-035-6/+46
| | | | | | | | | | | | | | | | | Due to the DP measurement eye-diagram and pre-emphasize fail, we change the mux to PS8751 on the type-c port in mainboard. BUG=b:118728290,b:119840612 BRANCH=octopus TEST=FAFT pass and check the mux function working on EVT. Change-Id: I1817686f09f6aa9a557907b279ab61c889335d9e Signed-off-by: James_Chao <james_chao@asus.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/1343642 Commit-Ready: James Chao <james_chao@asus.corp-partner.google.com> Tested-by: James Chao <james_chao@asus.corp-partner.google.com> Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* PD: Ensure SVID parsing doesn't exceed packet boundariesDiana Z2018-12-031-2/+10
| | | | | | | | | | | | | | | | | | | | | When responding to DiscSVID requests, most port partners will include an SVID value of 0 to indicate the end of the SVIDs. However, not all dongles follow this rule and their packet may end with a VDO containing two non-zero SVIDs. In this scenario, we should stop parsing when we reach the end of the valid packet region to avoid finding junk SVIDs. BRANCH=coral,eve,fizz,glados,gru,grunt,nami,nocturne,oak,octopus,poppy, reef,samus,scarlet,smaug BUG=b:116764439 TEST=on bobba360, verified there were no regressions in SVID parsing with well-behaving dongles (hoho - 2 VDOs, apple - 2 VDOs, DA200 - 1VDO, 7magic - 1 VDO) Change-Id: Id2b40ba918439aeb214efb43837dd995ff0b9d86 Signed-off-by: Diana Z <dzigterman@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1355364 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Todd Broch <tbroch@chromium.org>
* Octopus: allow data role swapping in RODiana Z2018-12-031-11/+3
| | | | | | | | | | | | | | | | | | | | Since we keep our data role in the BBRAM flags now, it should be safe to allow the EC to perform a data roll swap in RO. This change primarily affects unlocked systems which allow PD communication in RO, and especially affects developers who have software sync disabled and use powered usb dongles for display. BRANCH=octopus BUG=b:116764439 TEST=disabled software sync on a bobba360 and confirmed a powered hub could reliably display, enabled software sync and put the EC into hibernate, waking it with a powered hub, confirming data role swap in RO had no adverse affects or hard resets Change-Id: If56e408afa17c8c9eeeb033d977c25710390fe32 Signed-off-by: Diana Z <dzigterman@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1355371 Reviewed-by: Jett Rink <jettrink@chromium.org>
* chgstv2: Fix battery_near_full() with full batteryEdward Hill2018-12-031-1/+1
| | | | | | | | | | | | | | | | | Use charge_get_percent() instead of curr.batt.state_of_charge in battery_near_full() to ensure battery_near_full() will always return 1 when the battery is full and not accepting current (is_full == 1). BUG=b:119886140 BRANCH=grunt TEST=Delan shows "full" LED when battery FULL bit set Change-Id: Ib8f0f1f19b105cee979a365db61113ea276feebf Signed-off-by: Edward Hill <ecgh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1352068 Tested-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com> Reviewed-by: Jett Rink <jettrink@chromium.org>
* Nami: Add battery AP18F4M for Bard and EkkoDavid Huang2018-12-032-8/+51
| | | | | | | | | | | | | | | | | | Add AP18F4M battery config and discharge fet status for Bard and Ekko. Battery type is encoded in SKU_ID[24:31]. Akali/Akali360 have been shipped with SKU_ID[24:31] equal to zero. BRANCH=nami BUG=b:112564628, b:119522898 TEST=Make sure battery cut-off by console command "cutoff" and use "chgstate" to check battery present is YES after resume from cut-off. Change-Id: I55df5d212b834649f1c05425541b808fb4900e87 Signed-off-by: David Huang <David.Huang@quantatw.com> Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/1319731 (cherry picked from commit ac1838fa0d8384b70aa08bc8574e95261f8b7953) Reviewed-on: https://chromium-review.googlesource.com/1356179
* cr50_fuzz: Add self test.Allen Webb2018-12-031-0/+44
| | | | | | | | | | | | | | | This adds an initialization step that sanity checks the fuzz target to make sure the model is working as intended. BRANCH=None BUG=chromium:876582 TEST=sudo emerge libprotobuf-mutator && make -j buildfuzztests && ./build/host/cr50_fuzz/cr50_fuzz.exe Change-Id: I3961a7ff05b4876992af447a2104bcfa0a496562 Signed-off-by: Allen Webb <allenwebb@google.com> Reviewed-on: https://chromium-review.googlesource.com/1347012 Reviewed-by: Mattias Nissler <mnissler@chromium.org>
* cr50_fuzz: Add libprotobuf-mutator support.Allen Webb2018-12-0310-61/+1025
| | | | | | | | | | | | | | | | | | This uses protocol buffers to model what actions can be taken with pinweaver at a higher level of abstraction than the raw requests to greatly increase the coverage that can be achieved by fuzzing, while still allowing for invalid inputs to be checked. BRANCH=none BUG=chromium:876582 TEST=sudo emerge libprotobuf-mutator && make -j buildfuzztests && ./build/host/cr50_fuzz/cr50_fuzz.exe Change-Id: Ie7ce569650ca06866f277f36eae61df2684de60c Signed-off-by: Allen Webb <allenwebb@google.com> Reviewed-on: https://chromium-review.googlesource.com/1184107 Reviewed-by: Mattias Nissler <mnissler@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org>
* gsctool: verbose flag should print debug messagesJoel Kitching2018-12-031-8/+11
| | | | | | | | | | | | | | | | | Currently the verbose flag is stored in `verbose_mode` but never used. Print conditionally on this flag within a new `debug` function. BUG=None TEST=try running various commands with --verbose check for verbose output BRANCH=master Change-Id: Iadaf1a91ea1b02b0638e6364077c2c148f26e03c Reviewed-on: https://chromium-review.googlesource.com/1351926 Commit-Ready: Joel Kitching <kitching@chromium.org> Tested-by: Joel Kitching <kitching@chromium.org> Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
* gsctool: correct a typoJoel Kitching2018-12-031-1/+1
| | | | | | | | | | | | BUG=None TEST=check for correct output with --help flag BRANCH=master Change-Id: Idf0448791e3d043313bc1291810d71d3f4846a6a Reviewed-on: https://chromium-review.googlesource.com/1351925 Commit-Ready: Joel Kitching <kitching@chromium.org> Tested-by: Joel Kitching <kitching@chromium.org> Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
* sensor: Adjust max_frequency based on EC performanceGwendal Grignou2018-12-0316-20/+46
| | | | | | | | | | | | | | | | | | | | | | Put in max_frequency a value that the sensor AND the EC support. BRANCH=none BUG=b:118205424,b:118851581,chromium:615059 TEST=Compile. Check all max sensors frequencies have been altered with: for i in $(grep -rh max_frequency board | cut -d '=' -f 2 | sort | \ uniq | grep FREQ | sed 's/FREQ.*//') ; do echo -n $i ; git show | grep -q $i || break; echo check done Check on nocturne accel max frequency is still correct. Change-Id: I848396d9f150a2e94d430a8feeafc1087a6bf2c3 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1352063 Commit-Ready: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Jesse Schettler <jschettler@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Justin TerAvest <teravest@chromium.org>
* power/rk3399: Remove unused power_seq_versionPhilip Chen2018-12-013-19/+13
| | | | | | | | | | | | | | | | | | The current power_seq_version 1 is only for Scarlet rev0, which is not supported anymore. BUG=b:119617491 BRANCH=scarlet TEST=manually test on dru, confirm S5->S0->S5 and S0->S3->S0 still work fine TEST=buildall Change-Id: I0784cecddd3911f057998eb21b8edb5c577431e5 Signed-off-by: Philip Chen <philipchen@google.com> Reviewed-on: https://chromium-review.googlesource.com/1337464 Commit-Ready: Philip Chen <philipchen@chromium.org> Tested-by: Philip Chen <philipchen@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com>
* Delete unused MAX_BYTES_IN_ONE_READING from usb_i2c.cMatthew Blecker2018-12-011-1/+0
| | | | | | | | | | | BRANCH=none BUG=none TEST="make buildall" succeeds Change-Id: Idd18342501826b72193d81cbd1b924d184c7fbec Signed-off-by: Matthew Blecker <matthewb@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1355969 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* tablet_mode: Fix tablet mode for tablet devicesNicolas Boichat2018-12-018-22/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Tablet devices would normally only define CONFIG_TABLET_MODE_SWITCH, and not CONFIG_TABLET_MODE, and define a tablet_get_mode function which always returns 1. Since 09a5e0a9398 "dptf: Get rid of CONFIG_DPTF_DEVICE_ORIENTATION", tablet_mode.h, when CONFIG_TABLET_MODE is not set, would define an _inline_ tablet_get_mode function which would always return 0, causing tablets to always be in laptop mode. Fix this by: - Removing the inline in tablet_mode.h. - Add CONFIG_TABLET_MODE to all our tablets (after removing the inline, compilation fails if CONFIG_TABLET_MODE_SWITCH is set, but not CONFIG_TABLET_MODE). - Remove tablet_get_mode from board/*/board.c, as the default mode is tablet, anyway. BRANCH=none BUG=b:120252451 TEST=Boot kukui, onscreen keyboard works TEST=No code size increase: build/kukui/RW/space_free_flash shrank by 36 bytes: (23968 to 23932) build/kukui/RW/space_free_ram shrank by 4 bytes: (10356 to 10352) build/rainier/RW/space_free_flash shrank by 36 bytes: (44296 to 44260) build/rainier/RW/space_free_ram shrank by 4 bytes: (12948 to 12944) build/scarlet/RW/space_free_flash shrank by 36 bytes: (28128 to 28092) build/scarlet/RW/space_free_ram shrank by 4 bytes: (10532 to 10528) Change-Id: Ifea0412bb32f1d701ad2040ad62a5c812705b14a Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1355645 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org>
* motion_sense: Remove global fifo_flush_needed, redundantstabilize-octopus-11316.38.Bstabilize-octopus-11316.37.Bstabilize-11316.37.Bstabilize-11316.35.BGwendal Grignou2018-11-291-7/+4
| | | | | | | | | | | | | | Instead, use the event flag. BUG=b:73557414 BRANCH=scarlet,poppy TEST=Compile. Change-Id: Ic1b123edb6f67012f38b1022d492492175b5d59d Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1128551 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Alexandru M Stan <amstan@chromium.org>
* octopus: remove OCM erase commandJett Rink2018-11-292-15/+0
| | | | | | | | | | | | | | We haven't need the OCM erase command for anlogix TCPCs for a while since they are being shipped with the OCM pre-erased BRANCH=octopus BUG=b:109882250 TEST=buildall Change-Id: Ic4d2fa1e40037e01d5ed03116e8ceb14840f0ea9 Signed-off-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1352057 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
* Nami: Remove local oem variableDaisuke Nojiri2018-11-291-5/+1
| | | | | | | | | | | | | | | | | oem is also defined as a global in board.c. This removes a local variable of the same name to avoid confusion. Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> BUG=none BRANCH=none TEST=Verify LEDs' behavior doesn't change on Sona. Change-Id: I5e4d2e44f8770d6cdbac368ce93b8a6a0a0af83b Reviewed-on: https://chromium-review.googlesource.com/1354491 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
View Lorry Controller Status