| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Change-Id: I0f03f432ada1064ffba9595be78ca7ab4d25ecd1
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3155193
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Owners-Override: Jora Jacobi <jora@google.com>
Tested-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL defines I2C command white list, which are allowed though
system is locked. A unit of whitelist is a pair of slave address and
command ID. As of this CL, Kip has a Battery CT Label query command (0x70) at
0x0b slave address in whitelist.
BUG=b:119534901
BRANCH=kip
TEST=manually ran ectool.
$ flashrom -p ec wp-status
..
WP: write protect is enabled.
$ ectool --ascii i2cxfer 0 0 0 0
EC result 4 (ACCESS_DENIED)
$ ectool --ascii i2cxfer 0 0x0b 15 0x70
\x106EGXDN2RY7V09V
Change-Id: I63dee7d8f8c2b11fb54bf7c85ee903ce59bb2013
Signed-off-by: Namyoon Woo <namyoon@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1588492
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to change
We should add a discharge OCP table for Kip14 new battery and use
BOARDID to identify Kip14,then we can choose OCP table of Kip14.
When battery discharge current is over throttle,we set the prochot
pin so change THROTTLE_SOFT to THROTTLE_HARD.
BUG=chrome-os-partner:41579
BRANCH=kip
TEST=check frequency of cpu down when battery discharge current are over
own setting in Kip14 and Kip.
Change-Id: Ia56f3728d841ef56d1a5d76c3dd7d6429005f3ea
Signed-off-by: Bruce Wan <Bruce.Wan@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/282133
Reviewed-by: Mohammed Habibulla <moch@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=master
BUG=chrome-os-partner:29139
TEST=Buiid an EC FW image and run on Rambi to test if key loss is
improved and any side effect somes with this change. Need more test
units to confirm this.
Signed-off-by: Kenji Chen <kenji.chen@intel.com>
Change-Id: I2399e33d2ca3defe8cd9b1f94ab0af1db7f84635
Reviewed-on: https://chromium-review.googlesource.com/225557
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
(cherry picked from commit 8a1f1b045a2bffc0c3bf3941709acf4ba99d32e7)
Reviewed-on: https://chromium-review.googlesource.com/226701
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Factory test process need lid switch no function or keep lid opened
BUG=chrome-os-partner:33281
BRANCH=kip
TEST=Run command "ectool forcelidopen 1" and "reboot". Then lid close
quickly, the system boot as lid opened.
Deault value or run command "ectool forcelidopen 0" make the device normal.
Change-Id: I407a28c6900a1f8aa9d3b01d4e83f6c4e1e88012
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/225334
Reviewed-by: Chih-Wei Tsai <adam.tsai@quantatw.com>
Tested-by: Chih-Wei Tsai <adam.tsai@quantatw.com>
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We want to power cycle the cellular modem on AP reboot because the modem does
not handle the kernel/USB reboot well. This is a board specific hack that keys
in on the LPC bus reset caused by the AP reboot to power cycle the modem.
BUG=chrome-os-partner:31217
BRANCH=kip
TEST=(1) Verify reboot is sane -- no panic from EC/Kernel.
(2) Verify that modem does not disappear from USB across DUT reboots. This
is a flaky failure -- reboot the DUT >200 times.
Change-Id: I86dd6df908f215f18780cdc439d656e98e398cf1
Signed-off-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/212143
Reviewed-by: Randall Spangler <rspangler@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The keyscan task is not needed on Tiny.
BUG=chrome-os-partner:29504
BRANCH=None
TEST=Verify power button works correctly and keyscan
task isn't listed under 'taskinfo'.
Change-Id: I34e8782aa4aeffe700c914826287ff1dfefcd186
Signed-off-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/203104
Reviewed-by: Randall Spangler <rspangler@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allow devices to send power button keyboard events without
having an internal keyboard defined.
BUG=chrome-os-partner:29504
BRANCH=None
TEST=Build and run on a peppy. Verify keyboard protocol
messages are still sent for the power button using evtest.
Change-Id: Ibfaa1a779552bdc5a643911703e7900bbc1d51d7
Signed-off-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/203103
Reviewed-by: Randall Spangler <rspangler@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This sets the adapter current limit to 90% of the rating for a
40W adapter. The earlier limit was based on a 33W adapter which
was not used.
BUG=chrome-os-partner:23833
BRANCH=ToT
TEST=With a 20-80% charged battery run 4000 fish (search for
WebGl Aquarium) with backlight at 100%. Verify ChargerCurrent
is around the limit with 'adc' command on EC serial console.
Change-Id: I6279d0a3502142348b79425e56cfc25bf75432b5
Signed-off-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/204893
Reviewed-by: Todd Broch <tbroch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This sets the adapter current limit to 90% of the rating for a
40W adapter. The earlier limit was based on a 33W adapter which
was not used.
BUG=chrome-os-partner:23833
BRANCH=None
TEST=With a 20-80% charged battery run 4000 fish (search for
WebGl Aquarium) with backlight at 100%. Verify ChargerCurrent
is around the limit with 'adc' command on EC serial console.
Change-Id: I4e2270dd1cb774681383105d88869dc7022a9fb7
Signed-off-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/204932
Reviewed-by: Todd Broch <tbroch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We won't to see the corner case when plugging in adpater.
if battery want to charge, we want to see the amber led directly
when plugging in adapter, not white to amber.
if battery into fully charged, we want to see the white led directly
when plugging in adapter, not amber to white.
BUG=None
BRANCH=rambi
TEST=manual
Check battery LED show amber directly when plugging in adpater,
if battery needs to charge.
Check battery LED show white directly when plugging in adpater,
if battery into fully charged.
Check battery LED show white directly when plugging in adpater,
if battery near full.
Change-Id: I08e6c9ea32dc90599a974d7b5fadaf59f549cc77
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/203932
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents erratic blinking of the charging
LED while in G3.
BUG=chrome-os-partner:29577
BRANCH=enguarde
TEST=Shutdown machine and type 'dsleep 0' in
the serial console to force deep sleep mode.
Verify the charging LED doesn't flash erratically.
Change-Id: Ibc6af84f9f35e4ba3893269d9a306e4b5e99f70a
Signed-off-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/203850
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents erratic blinking of the charging
LED while in G3.
BUG=chrome-os-partner:29577
BRANCH=expresso
TEST=Shutdown machine and type 'dsleep 0' in
the serial console to force deep sleep mode.
Verify the charging LED doesn't flash erratically.
Change-Id: I4912cde058f54266a2701155d08817f648bc72de
Signed-off-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/203802
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents erratic blinking of the charging
LED while in G3.
BUG=chrome-os-partner:29577
BRANCH=ToT
TEST=Shutdown machine and type 'dsleep 0' in
the serial console to force deep sleep mode.
Verify the charging LED doesn't flash erratically.
Change-Id: I6bdbf324ac9189a5f135523318d171df9d476b0d
Signed-off-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/203862
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
BRANCH=rambi
TEST=make buildall -j and ectool led power off/white work normally.
Signed-off-by: Aaron Weng <aaron.weng@quantatw.com>
Change-Id: I86aa3cabf7c38e449c241ad058eb31497ec64e8e
Reviewed-on: https://chromium-review.googlesource.com/202905
Reviewed-by: Dave Parker <dparker@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chrome-os-partner:29077
BRANCH=rambi
TEST=make buildall -j and power led can be operated normally.
Change-Id: Iaf69859fdaa6e511d8e19810f38bed85209a226c
Signed-off-by: Aaron Weng <aaron.weng@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/202655
Reviewed-by: Dave Parker <dparker@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
BRANCH=gnawty
TEST=To check the battery can be charging normally.
Signed-off-by: Jimmy Lin <jimmy.Lin@quantatw.com>
Change-Id: I8e76e454bb4be66ce44b9aa80c9971afa1448e50
Reviewed-on: https://chromium-review.googlesource.com/202211
Tested-by: 挺倫 林 <jimmy.lin@quantatw.com>
Reviewed-by: Dave Parker <dparker@chromium.org>
Commit-Queue: Dave Parker <dparker@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According Battery pack SPEC, the battery shipping mode
set condition must be meet below items.
1.AC adaptor attached.
2.The each cell voltage is under 4000mV.
BUG=chrome-os-partner:29077
BRANCH=rambi
TEST=The battery pack can be set shipping mode and wake up
from shipping mode success by ectool batterycutoff command.
Change-Id: I80439040021a82e5635c22546f725a70b47a863f
Signed-off-by: Aaron Weng <aaron.weng@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/201815
Reviewed-by: Dave Parker <dparker@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chrome-os-partner:29024
BRANCH=gnawty
TEST=We try to used the 10 ms and 13 ms delay.
But the T11 still fail.The 15 ms is minimum pass criteria.
Change-Id: I96cb3a6c72d25db02aafcd07e366f12f389f91c9
Signed-off-by: Jimmy Lin <jimmy.Lin@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/202030
Reviewed-by: Dave Parker <dparker@chromium.org>
Commit-Queue: Dave Parker <dparker@chromium.org>
Tested-by: Dave Parker <dparker@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Copy, paste, and rename of Rambi. Customization will be done
in follow-up patches.
BUG=None
BRANCH=None
TEST=make buildall -j
Change-Id: I43397bc6bc2155613b6e02b47fa6febaa439b376
Signed-off-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/198321
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add battery present pin.
BUG=none
BRANCH=rambi
TEST=manual
To check the system reset normally without battery attached.
Change-Id: Id3ed19a3464045cc56d8bd7674cb2d6fb67df013
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/200193
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According battery physical led is orange color.
So we change the color setting to orange.
BUG=none
BRANCH=rambi
TEST=tested battery charging led color.
Signed-off-by: Aaron Weng <aaron.weng@quantatw.com>
Change-Id: I06cb3c1f6f3ca6c230acba1670760f5172447ff6
Reviewed-on: https://chromium-review.googlesource.com/200024
Tested-by: Aaron Weng <aaron.weng@quantatw.com>
Reviewed-by: Dave Parker <dparker@chromium.org>
Commit-Queue: Aaron Weng <aaron.weng@quantatw.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the battery presense GPIO.
BUG=chrome-os-partner:28713
BRANCH=rambi
TEST=To check the system reset normally without battery attached.
Change-Id: Id21cc7dd624719b686d7d23bbcae50b4cbe8dc31
Signed-off-by: Aaron Weng <aaron.weng@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/199288
Reviewed-by: Dave Parker <dparker@chromium.org>
Commit-Queue: Dave Parker <dparker@chromium.org>
Tested-by: Dave Parker <dparker@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chrome-os-partner:28448
BRANCH=rambi
TEST=To check the battery can be charging normally.
Change-Id: I3c23b464b53e9449a462b130ecd0ee5dffa570f2
Signed-off-by: Aaron Weng <Aaron.Weng@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/198149
Reviewed-by: Aaron Weng <aaron.weng@quantatw.com>
Reviewed-by: Dave Parker <dparker@chromium.org>
Commit-Queue: Dave Parker <dparker@chromium.org>
Tested-by: Dave Parker <dparker@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes bug in which the keyboard remains disabled after resuming.
The problem occurs when the lidangle_keyscan_update() occurs after
the CHIPSET_RESUME hook triggers and before chipset state is
CHIPSET_STATE_ON, and the lid angle is in range to disable the
keyboard.
The fix is to not use a hook at all on chipset resume, and instead
just keep track of the last chipset state locally in
lidangle_keyscan_update(). That way we guarantee that when the
AP is turned on, the next time we check for lidangle keyscanning
state, it will enable the keyboard.
BUG=chrome-os-partner:28480
BRANCH=rambi
TEST=tested on a glimmer:
Added a hook to detect chipset resume in lid_angle.c:
static void enable_keyboard(void)
{
hook_fired = 1;
}
DECLARE_HOOK(HOOK_CHIPSET_RESUME, enable_keyboard, HOOK_PRIO_DEFAULT);
Then in lidangle_keyscan_update() added:
if (hook_fired && !chipset_in_state(CHIPSET_STATE_ON))
ccprintf("Hook fired, but chipset state still reads off\n");
hook_fired = 0;
Using this code, I used the lid switch on the servo board to open
and close the lid repeatedly until I saw the printf above.
Without this CL, when the printf is shown, the keyboard remains
disabled in S0. With this CL, the keyboard is enabled in S0.
Change-Id: Iac017a6468d46e0f011ec9d84a8c73b89622d8cc
Signed-off-by: Alec Berg <alecaberg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/198285
Reviewed-by: Randall Spangler <rspangler@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Base on customer's request, change LED behavior
BRANCH=clapper
BUG=none
TEST=Use battfake to verify each case
Signed-off-by: Carry Chen <CarryBK_Chen@compal.com>
Change-Id: Icecd40d54ec28cdd242129cb862510914ef7616a
Reviewed-on: https://chromium-review.googlesource.com/197486
Reviewed-by: Antonie Cheng <Antonie_Cheng@compal.com>
Commit-Queue: Antonie Cheng <Antonie_Cheng@compal.com>
Tested-by: Antonie Cheng <Antonie_Cheng@compal.com>
Reviewed-by: Dave Parker <dparker@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Quawks boards need a pure hardware protection mechanism to
shutdown/reset system even if EC is hanged. This is done using the
ALERT# pin of TMP432 thermal IC.
So EC programs TMP432 with specified temperature limit value every time
when system is booted, to make sure this mechanism works as expected.
BUG=chrome-os-partner:28184
BRANCH=rambi
TEST=Run "make -j buildall" and "make -j BOARD=quawks tests".
Tested by thermal engineers that system will shutdown when
specified temperature is reached.
Change-Id: I485852409153c036488eac2ae9c0a8fe4e2c5b61
Signed-off-by: Kenneth Lo <Kenneth_Lo@asus.com>
Reviewed-on: https://chromium-review.googlesource.com/195120
Reviewed-by: Randall Spangler <rspangler@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In some cases, the system will boot to S0 from the point of view of
the EC, but PLTRST# will never deassert. Work around this by waiting
50 ms for PLTRST# to deassert. If it doesn't, force the chipset all
the way down by deasserting RSMRST#, then pulse the power button to
turn it back on.
Also add a powerfail debug command to simulate this failure event, so
that the recovery process can be tested.
Add API to the LPC module to get the state of PLTRST#, and to the
power button state machine to force it released when we shut down the
chipset and and force another power button pulse as we reset the
chipset.
BUG=chrome-os-partner:28422
BRANCH=baytrail
TEST=1. Boot system. Should boot normally. Shut system down.
2. powerfail
3. Boot system. On the EC console, should see the system come up,
go back down through G3S5, then come back up. From the user's
point of view, it just boots.
1. Boot system. Should boot normally. (That is, powerfail is not sticky)
Change-Id: Ia7df629a2e2f017e411432d7e224a3c5eb95f8b8
Original-Change-Id: Ia57f196606f79b9f2fce7d9cd109ab932c3571aa
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/197534
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Commit-Queue: Shawn Nematbakhsh <shawnn@chromium.org>
Tested-by: Shawn Nematbakhsh <shawnn@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only support write function.
BUG=chrome-os-partner:25145
BRANCH=glimmer
TEST=clean correspondence register to 0,
run "ectool batteryparam set 0 0x1234", and check the register.
The register change to 0x1234. Command "ectool batteryparam set 0 0x1234"
return 2 because we have no get function.
Change-Id: I2d8c66fc41ddb45c45ff993eaed1e067689b1268
Signed-off-by: Henry Hsu <Henry.Hsu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/196973
Reviewed-by: Dave Parker <dparker@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The EC and host have different ways of computing and presenting the
battery charge level. This change adjusts the charge levels at which
the charging LED indicates a full and low battery to match what is
presented to the user in the host UI.
(Ported from [4e470aa]Squawks: Adjust charge thresholds for altering LED
behavior)
BUG=chrome-os-partner:27449
BRANCH=rambi
TEST=Run "battfake 91" which charging, verify charging LED turns green
and the UI reports 96%.
Run "battfake 90" which charging, verify charging LED turns orange
and the UI reports 94%.
Run "battfake 13" while discharging, verify charging LED blinks
amber (1 sec on, 1 sec off) and the UI reports 10%.
Change-Id: Ib89dc4750fc4af91d0a7e706fa8c76c21823dfe8
Signed-off-by: Kenneth Lo <Kenneth_Lo@asus.com>
Reviewed-on: https://chromium-review.googlesource.com/196156
Reviewed-by: Charles Yu <charles.yu@intel.com>
Reviewed-by: Dave Parker <dparker@chromium.org>
Commit-Queue: Dave Parker <dparker@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also adds 'battparam' console command.
BUG=chrome-os-partner:25145
BRANCH=ToT
TEST=Run 'ectool batteryparam set 0 0x1234'
'ectool batteryparam get 0'
and on the console:
'battparam 0'
'battparam 0 0x1234'
on a board that implements parameter 0.
Change-Id: Ib2812f57f2484309d613b23dab12ad43e0417bd2
Signed-off-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/195824
Reviewed-by: Randall Spangler <rspangler@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a temporary fix to enable the accelerometers
by hard-coding the power enable high until the CL
to control and reset the accelerometers is landed.
BUG=chrome-os-partner:27577
BRANCH=None
TEST=Manual. Run on glimmer. Verify accelerometers
work and are polled at the correct rate in S0 and S3
with console 'lidangle on' command.
Change-Id: I619deffe6b5d1edb35c022cd0071310e2c2f1e3d
Signed-off-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/194901
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Boards can define the config option and implement a
battery_cut_off() function to put their battery into "ship mode."
Works with the existing "batterycutoff" host command. When using
the host command, the battery is cut off 5 seconds after the
system is shut down to minimize filessystem corruption issues.
Also includes a "battcutoff" console command that requires AC
power be removed. Cut off is immediate in this case.
BUG=chrome-os-partner:28190
BRANCH=ToT
TEST=Run 'ectool batterycutoff' and the console 'battcutoff'
commands on a board using the CONFIG_BATTERY_CUT_OFF option.
Verify the battery is cut off by pressing the power button >5 seconds
after shutting down.
Change-Id: I4d99a2e5aec53906416677ea44b41123b2957815
Signed-off-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/196133
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Vic Yang <victoryang@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1.Copy Rambi setting to init board.
2.Add entries for 'gnawty' in following two files.
util/flash.ec
chip/lm4/openocd/lm4x_cmds.tcl
3.Modify below battery paramemters to support 3 cell battery.
input_current/charge_volatge/charge_current/temperature
4.Check the Battery of cutoff function works normally in gnawty.
5.Modify the temp_sensors of name and location.
6.Add power and battery of LED control for gnawty.
BUG=none
BRANCH=gnawty
TEST=Run "make BOARD=gnawty" and "make buildall -j" to build
code and ec.bin can be generated.
Signed-off-by: Jimmy Lin <jimmy.Lin@quantatw.com>
Change-Id: I5720838ef623ee3e0cb40710aeebb53599c3551d
Reviewed-on: https://chromium-review.googlesource.com/195821
Reviewed-by: Dave Parker <dparker@chromium.org>
Commit-Queue: Dave Parker <dparker@chromium.org>
Tested-by: Dave Parker <dparker@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a temporary fix to enable the accelerometers
by hard-coding the power enable high until the CL
to control and reset the accelerometers is landed.
BUG=chrome-os-partner:24894
BRANCH=None
TEST=Manual. Run on clapper. Verify accelerometers
work and are polled at the correct rate in S0 and S3
with console 'lidangle on' command.
Change-Id: I947d4dee5d6dece4a32c9625d828e599b3167b01
Signed-off-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/194902
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
BRANCH=rambi
TEST=Run util/flash_ec on clapper
Change-Id: Ib388af6800ae208934d5b026a63f0567d31ef86e
Signed-off-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/196226
Reviewed-by: Randall Spangler <rspangler@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add some configurations for swanky, include OpenOCD and util/flash_ec.
BUG=none
BRANCH=swanky
TEST=none
Change-Id: Ibede079dcb304e0cf599df37d192a1d986549806
Signed-off-by: Henry Hsu <Henry.Hsu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/196191
Reviewed-by: Dave Parker <dparker@chromium.org>
Commit-Queue: Dave Parker <dparker@chromium.org>
Tested-by: Dave Parker <dparker@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The EC and host have different ways of computing and presenting
the battery charge level. This change adjusts the charge levels
at which the charging LED indicates a full and low battery to
match what is presented to the user in the host UI.
BUG=chrome-os-partner:27743,chrome-os-partner:27746
BRANCH=rambi,tot
TEST=Run "battfake 91" which charging, verify charging LED turns
green and the UI reports 95%.
Run "battfake 13" while discharging, verify charging LED blinks
amber (1 sec on, 1 sec off) and the UI reports 10%.
Change-Id: I326731c46e61a953b445cd9eda875d7dab3da4dd
Original-Change-Id: I203c90a65e4aa2907a14077a9276674ecfa292f2
Signed-off-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/194347
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/195847
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pull up adapter id pin will save power since we disable adapter id
function.
BUG=chrome-os-partner:28156
BRANCH=glimmer
TEST=flash ec, hard reset, and run command "ectool gipoget
ADAPTER_ID". It shows that GPIO ADAPTER_ID = 1.
Change-Id: I37ee64f1b493e35e0181a636212c856b7755427a
Signed-off-by: Henry Hsu <Henry.Hsu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/195717
Reviewed-by: Dave Parker <dparker@chromium.org>
Commit-Queue: Dave Parker <dparker@chromium.org>
Tested-by: Dave Parker <dparker@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a clearer name for the intent of the function to
override the charging parameters requested by the battery.
This also disabmiguates this function with a new host command
to get and set arbitrary vendor parameters in the battery.
BUG=chrome-os-partner:25145
BRANCH=ToT
TEST=`make buildall -j`
Change-Id: I1e8762d359c0e91c5b2a539553d22c12c9850c03
Signed-off-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/195823
Reviewed-by: Randall Spangler <rspangler@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, you could use EC_CMD_ACPI_QUERY_EVENT to read events that
were masked off (that is, events which would not generate SCI/SMI/wake
signals). The handlers for those signals on the host would still act
on the masked-off events - for example, causing unwanted power button
keypresses/releases.
Now, EC_CMD_ACPI_QUERY_EVENT will only return events which are unmasked.
This does not affect storing of events at event generation time.
Events are still queued; they won't be dropped until the host attempts
to read the next event. This gives the host a chance to set a mask
later in boot (but before querying any events) to capture events which
happened early in the boot process.
BUG=chrome-os-partner:26574
BRANCH=rambi
TEST=At EC console, type 'hostevent set 0x80' but don't press enter.
Hold down the power button; UI starts fading to white.
Press enter at the EC console to issue the hostevent command.
System should continue shutting down, not fade back as if the
power button were released.
Orig-Change-Id: Id2cb14b0979f49cdd42424b9a61b310a2bb506f5
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/194935
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
(cherry picked from commit d899fdaaeef175e97923b954342dad3a33c5c387)
Change-Id: I69f495809a72bda77841ed16c041d0c3dbe198c2
Reviewed-on: https://chromium-review.googlesource.com/195566
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Commit-Queue: Randall Spangler <rspangler@chromium.org>
Tested-by: Randall Spangler <rspangler@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
identify adapters and adjust the charger limit for each adapter.
re-factored for adapter over rating.
re-factored for battery over current.
BUG=chrome-os-partner:27798
BRANCH=rambi
TEST=manual
build ec and flash to kip board.
verify adapters can be identified.
check AP can be throttle when battery over current.
check AP can be throttle when adapter over rating.
Change-Id: I1339f55d8ed523acf9543ee8acd7c7e3c9c99e9c
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/194891
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactored keyboard scan enable/disable flag such that it is a mask of
potential disable sources. When all disable sources are off, scanning is
enabled, otherwise scanning is disabled. This fixes a recently introduced
bug in which enabling/disabling keyboard scanning due to lid angle in S3
was interfering with enabling/disabling keyboard scanning due to power
button. This also allows for easy expansion for future causes for disabling
keyboard scanning.
BUG=chrome-os-partner:27851
BRANCH=rambi
TEST=Manual tests with a glimmer. Used the ksstate console command to
check state of keyboard scanning under all permutations of power button
pressed/unpressed, lid switch open/closed, and lid angle in tablet position
vs. laptop positon.
Change-Id: Ied4c5ebb94510b1078cd81d71373c0f1bd0d6678
Signed-off-by: Alec Berg <alecaberg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/194097
Reviewed-by: Randall Spangler <rspangler@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a sub-command to the motionsense host command (0x2b) for getting/setting
the lid angle at which the keyboard is disabled as a wake source in S3. The
value can be anywhere from 0 to 360 degrees, default set to 180. Note, this
only takes affect for boards that have CONFIG_LID_ANGLE_KEY_SCAN defined.
Modified ectool motionsense command to use new host sub-command.
Also modified the lid angle measurement in the EC to be in the range [0, 360],
instead of [-180, 180], and changed casting of lid angle as an int to round
to nearest.
BUG=none
BRANCH=rambi
TEST=Tested on a glimmer:
Using default keyboard disable lid angle of 180, made sure that when lid
angle is past 180, key presses do not wake system, and when lid angle is
less than 180, key presses do wake up system.
Used ectool motionsense kb_wake to set the keyboard disable lid angle to 0.
Made sure that keyboard never wakes up the system. Set keyboard disable lid
angle to 360 and made sure that the keyboard always wakes up the system.
Change-Id: I437164c6e38c29169ef6e20e86c9cf2a1c78f86e
Signed-off-by: Alec Berg <alecaberg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/193663
Reviewed-by: Randall Spangler <rspangler@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chrome-os-partner:27003
BRANCH=None
TEST=make buildall -j
Change-Id: I2af28640db8b35de922ca60eeb176afe3e0dcb64
Signed-off-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/193725
Reviewed-by: Randall Spangler <rspangler@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added arg to ectool motionsense command to print the active flag.
BUG=none
BRANCH=rambi
TEST=Tested ectool command on glimmer
Change-Id: I4066302d388857b2646a4ee778aa7f671e9b7d2a
Signed-off-by: Alec Berg <alecaberg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/193630
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only change fan rpm each step.
on off RPM(FAN_ID low) RPM(FAN_ID high)
42 35 4050 4150
48 39 4400 4600
63 53 5100 5600
BUG=chrome-os-partner:25076
BRANCH=glimmer
TEST=modify thermal sensor read function, the fan works fine with
the above table.
Change-Id: I59365c516c5c50d458ac576e307c8a7fb4aa64c6
Signed-off-by: Henry Hsu <Henry.Hsu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/193381
Reviewed-by: Dave Parker <dparker@chromium.org>
Commit-Queue: Dave Parker <dparker@chromium.org>
Tested-by: Dave Parker <dparker@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added ability to disable the keyboard to wake from suspend when the lid
is outside a certain angle range.
BUG=none
BRANCH=None
TEST=Tested on a clapper:
In S3, verified that when the lid is open past ~180 deg, the keyboard
does not wake the machine. Also verified that if you align hinge with
gravity, the keyboard enabled/disabled status remains the same (since
we can't actually trust the lid angle value).
Change-Id: I349e0fbc8def41f0280e2fb40af24fab4d465e3c
Signed-off-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/193409
Reviewed-by: Alec Berg <alecaberg@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chrome-os-partner:27736
BRANCH=ToT
TEST=Charge battery. Check that charging LED doesn't
occasionally blink amber.
Change-Id: I57d9d432bce4ed28678dddc43fa5166905525557
Signed-off-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/193338
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the host somehow fails to see an edge on the keyboard IRQ line, it
won't read the 8042 data register. The EC won't ever send another
IRQ, because it only does so after filling the register. So the
keyboard will hang.
Work around this with a retry mechanism. If the AP hasn't responded
after 3 additional keyboard events, generate another IRQ. So a stuck
key will get unstuck if you tap it a few times. That's reasonable,
and matches what people do already if they have a sticky key due to
crud accumulating in the keyboard.
I've tested this when the system is booted to the OS. I don't see any
additional IRQs generated on the EC console ("KB extra IRQ"), so the
host is keeping up with the keyboard input stream.
If I'm in dev or recovery mode and bang on the keyboard right after
powering the system on (when the BIOS isn't yet paying attention to
the keyboard), I can see extra IRQs generated. This shows the retry
mechanism is working. The extra IRQs have no negative effect on the
boot process, and the keyboard works normally when the OS does
eventually boot.
BUG=chrome-os-partner:27222
BRANCH=rambi
TEST=Bang on the keyboard like a monkey. Keyboard should still work.
Change-Id: I6faff3f42f541d5f8d939a8ae7ba1c9867812ae6
Original-Change-Id: Idd41b2d133267f48f959bca0cf062a18ca6551fb
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/193363
Reviewed-by: Shawn Nematbakhsh <shawnn@chromium.org>
Commit-Queue: Shawn Nematbakhsh <shawnn@chromium.org>
Tested-by: Shawn Nematbakhsh <shawnn@chromium.org>
|