| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Change-Id: I0f03f432ada1064ffba9595be78ca7ab4d25ecd1
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3155203
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Owners-Override: Jora Jacobi <jora@google.com>
Tested-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm planning to add functionality to the kernel which periodically
dumps the EC console log and concatenates it so we can use it in bug
reports and feedback. However, stitching together logs collected
using the existing SNAPSHOT/READ commands is difficult. This adds a
new version of READ which acts mostly the same but will only give you
the difference between the two most recent snapshots when you pass
the corresponding argument.
BRANCH=ToT
BUG=chromium:492721
TEST=On lulu with kernel interface, cat
/sys/kernel/debug/cros_ec/console_log
and verify that the most recent bit of the log is printed,
use spammy commands like 'accelinfo on' and make sure nothing breaks,
check that 'ectool console' behavior has not changed
Change-Id: Ib8216caa917715820c3e265400f0db2125e8808b
Signed-off-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/273581
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
(cherry picked from commit 35e37cdf432c3c6260779dcb6222060db178b971)
Reviewed-on: https://chromium-review.googlesource.com/312740
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We allow reading the EC console via case-closed debugging on locked
systems, so we should also allow reading it via host command. The
original reason for denying this (EC printing keystrokes) no longer
exists; we don't print keyboard matrix changes by default anymore.
BUG=chromium:479223
BRANCH=none (well, could apply this anywhere...)
TEST=on a system with both hard and soft WP enabled in the EC,
'ectool console' works instead of failing with access denied.
Change-Id: Ie111bc130dd3f17cd4b658718d00d299786e3434
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/266701
Reviewed-by: Alec Berg <alecaberg@chromium.org>
Reviewed-by: Sameer Nanda <snanda@chromium.org>
(cherry picked from commit 2e0cc436b1f4cd60cdae8c4041b479d38ef8d774)
Reviewed-on: https://chromium-review.googlesource.com/312716
Commit-Queue: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable the workaround for power sequencing failures by pulsing
RTCRST to the PCH if it fails to sequence out of S5 state.
BUG=chrome-os-partner:46520
BRANCH=lulu
TEST=Confirm RTCRST asserts if SLP_S5 does not deassert and then system can
power on normally.
Change-Id: I29a7e9b120882f6b2303bf285a9ee6b63a9a628c
Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
Signed-off-by: Grover Yen <Grover_Yen@wistron.com>
Reviewed-on: https://chromium-review.googlesource.com/309927
Tested-by: Sean Chiang <sean_fs_chiang@wistron.com>
Commit-Queue: Sean Chiang <sean_fs_chiang@wistron.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update thermal settings according to "Meridian thermal table x02.xlsx"
BUG=chrome-os-partner:40324
BRANCH=firmware-lulu-6301.136.B
TEST=Flash EC firmware and apply thermalget, thermaltest command in
console to confirm thermal/fan setting.
Change-Id: I374acd61600a8a96d6b81a75d92397306ab22bf0
Signed-off-by: Grover Yen <Grover_Yen@wistron.com>
Reviewed-on: https://chromium-review.googlesource.com/280425
Reviewed-by: Mohammed Habibulla <moch@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update thermal settings according to "Meridian thermal table x01.xlsx"
BUG=chrome-os-partner:40324
BRANCH=none
TEST=Flash EC firmware and apply thermalget, thermalset command in
console to confirm thermal/fan settings.
Change-Id: Id72d035f31cc6043914059128ec67bcf72136a73
Signed-off-by: Grover Yen <Grover_Yen@wistron.com>
Reviewed-on: https://chromium-review.googlesource.com/273640
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Sean Chiang <sean_fs_chiang@wistron.com>
Commit-Queue: Sean Chiang <sean_fs_chiang@wistron.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify battery cutoff command
BRANCH=gandof
BUG=chrome-os-partner:40077
TEST=Use "ectool batterycutoff at-shutdown" to check power off DC mode
can't be power on.
Change-Id: I0d670a4577f499a1a52f2969c625640c5b7c3856
Signed-off-by: David Huang <David.Huang@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/272130
Tested-by: Grace Kao <grace.kao@intel.com>
Reviewed-by: David Wu <david_wu@quantatw.com>
Commit-Queue: David Wu <david_wu@quantatw.com>
Reviewed-by: Mohammed Habibulla <moch@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify for fix battery.c typo
BRANCH=gandof
BUG=chrome-os-partner:39858
TEST=Use "make buildall -j" to check build pass.
Change-Id: Ib10bde3368c0497cdd8126c4e7207dedc33d342c
Signed-off-by: David Huang <David.Huang@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/270602
Reviewed-by: Mohammed Habibulla <moch@google.com>
Commit-Queue: David Wu <david_wu@quantatw.com>
Tested-by: David Wu <david_wu@quantatw.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify power LED and battery LED color define for fit gandof LED color.
BRANCH=gandof
BUG=chrome-os-partner:40035
TEST=Use "ectool led battery green/yellow" "ectool led power white" to check LED color.
Change-Id: I87d1e61046d771d1cbe4ba26ee99f898eb1a182d
Signed-off-by: David Huang <David.Huang@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/270291
Reviewed-by: Mohammed Habibulla <moch@google.com>
Reviewed-by: Grace Kao <grace.kao@intel.com>
Commit-Queue: Grace Kao <grace.kao@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify battery cutoff command and wake up command for gandof battery.
BRANCH=gandof
BUG=chrome-os-partner:39858
TEST=1. Insert cutoff battery and adapter.
2. Plug out adapter.
3. Check system shutdown or not.
Change-Id: I574291de3558b66ca2bc6bbec264b4b7fea335b2
Signed-off-by: David Huang <David.Huang@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/269610
Reviewed-by: Mohammed Habibulla <moch@google.com>
Commit-Queue: David Wu <david_wu@quantatw.com>
Tested-by: David Wu <david_wu@quantatw.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify LED control for Power LED control is defferent with Battery LED.
BRANCH=gandof
BUG=chrome-os-partner:39860
TEST=Power on to check power LED and battery LED status.
Change-Id: I71a43b513cdd05da9d8e207286a9b19ea56df931
Signed-off-by: David Huang <David.Huang@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/269868
Reviewed-by: Mohammed Habibulla <moch@google.com>
Commit-Queue: David Wu <david_wu@quantatw.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify PWM define for support keyboard backlight control.
BRANCH=gandof
BUG=chrome-os-partner:39874
TEST=Use "pwmduty" or "ectool pwmsetkblight" to set keyboard backight
duty.
Signed-off-by: David Huang <David.Huang@quantatw.com>
Change-Id: Ie33c23c2a85e8cec65ed6c141396dfe834aa6d5f
Reviewed-on: https://chromium-review.googlesource.com/269861
Reviewed-by: Mohammed Habibulla <moch@google.com>
Commit-Queue: David Wu <david_wu@quantatw.com>
Tested-by: David Wu <david_wu@quantatw.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify LED pin define for gandof.
BRANCH=gandof
BUG=chrome-os-partner:39860
TEST=Power on to check power LED and battery LED status.
Change-Id: Ibb762f8724d0ced3ec3cd3a411c1a3984a096371
Signed-off-by: David Huang <David.Huang@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/269620
Reviewed-by: Mohammed Habibulla <moch@google.com>
Commit-Queue: David Wu <david_wu@quantatw.com>
Tested-by: David Wu <david_wu@quantatw.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add USB control pin for Gandof.
BRANCH=gandof
BUG=chrome-os-partner:39641
TEST=Insert USB device to USB 3.0 port to check device function.
Change-Id: I7e73fd5f086442da765a9d77d35717bff3b1b294
Signed-off-by: David Huang <David.Huang@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/267645
Reviewed-by: Mohammed Habibulla <moch@google.com>
Commit-Queue: David Wu <david_wu@quantatw.com>
Tested-by: David Wu <david_wu@quantatw.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Follow Chrome-OS lucid-sleep-requirements; as Wi-Fi need to be
wake-up source, WLAN_DISABLE#1 (low-active) need to be high in S3.
EC PJ4 (WLAN_DISABLE#1) controls 7260 W_DISABLE#1
BUG=chrome-os-partner:39288
BRANCH=none
TEST=Check WLAN_DISABLE#1 (EC PJ4) being high when S3
Change-Id: I05638984d3151e53f1d1904f5cc05373776bb5a8
Reviewed-on: https://chromium-review.googlesource.com/267820
Reviewed-by: Mohammed Habibulla <moch@google.com>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>
Commit-Queue: Harry Pan <harry.pan@intel.com>
Tested-by: Harry Pan <harry.pan@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Follow Chrome-OS hardware requirement of wake source, BT controller
need to remain powering-on.
WLAN_EN controls overall BT/WLAN power enabling
BUG=chrome-os-partner:39077
BRANCH=none
TEST=Check WLAN_EN being high when S3
Change-Id: I96ec6fb5b4c20f45e1ae49d1679a8d447d637d2e
Signed-off-by: Harry Pan <harry.pan@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/266830
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Copy Yuna setting to init board.
BUG=none
BRANCH=gandof
TEST=Run "make BOARD=gandof" and "make buildall -j" to build code
and ec.bin can be generated.
Change-Id: I5f6332a0af60fddce068fb8d59cd4a3420869da7
Signed-off-by: David Huang <David.Huang@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/264247
Reviewed-by: Mohammed Habibulla <moch@google.com>
Commit-Queue: David Wu <david_wu@quantatw.com>
Tested-by: David Wu <david_wu@quantatw.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change battery error LED behavior from "500ms on, 500ms off" to
"1 second on, 3 seconds off"
BUG=chrome-os-partner:35115
BRANCH=none
TEST=Detach battery to simulate battery error
and then confirm LED behavior.
Change-Id: I16d469ca7ebe27a98a9c446951165827845f02c8
Signed-off-by: Grover Yen <Grover_Yen@wistron.com>
Reviewed-on: https://chromium-review.googlesource.com/253987
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify cut-off command to meet battery spec.
BUG=chrome-os-partner:37028
BRANCH=none
TEST=Apply "batterycutoff" command of ectool to confirm.
Change-Id: I301555ea6709e3450e79f10e57a0ea4ca8276553
Signed-off-by: Grover Yen <Grover_Yen@wistron.com>
Reviewed-on: https://chromium-review.googlesource.com/250232
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify cut-off command to meet battery spec.
BUG=chrome-os-partner:37028
BRANCH=none
TEST=Apply "batterycutoff" command of ectool to confirm.
Change-Id: I09d60ac26edd52f266c4913dcd76e5dfc7841282
Signed-off-by: Grover Yen <Grover_Yen@wistron.com>
Reviewed-on: https://chromium-review.googlesource.com/250227
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apply PN6 for keyboard backlight.
BUG=chrome-os-partner:35115
BRANCH=none
TEST=make -j buildall, make -j tests
Change-Id: Ie5b706f782c75854c44e104d88b7b3dd616bd1e0
Signed-off-by: Grover Yen <Grover_Yen@wistron.com>
Reviewed-on: https://chromium-review.googlesource.com/238157
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement LED control for lulu.
BUG=chrome-os-partner:35115
BRANCH=none
TEST=make -j buildall, make -j tests
Change-Id: I792586118e18b74c42643a6dcfb1f66331c225cb
Signed-off-by: Grover Yen <Grover_Yen@wistron.com>
Reviewed-on: https://chromium-review.googlesource.com/238154
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement LED control for cid.
BUG=chrome-os-partner:35115
BRANCH=none
TEST=make -j buildall, make -j tests
Change-Id: Ie86b2dd28c9c2d309d65bd09c16104e0d7817b6e
Signed-off-by: Grover Yen <Grover_Yen@wistron.com>
Reviewed-on: https://chromium-review.googlesource.com/238320
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Copy from auron with string changes.
BUG=none
BRANCH=none
TEST=make -l buildall, make -j tests
Change-Id: I1564891ecb8574e41104dced7700091708650d85
Signed-off-by: Grover Yen <Grover_Yen@wistron.com>
Reviewed-on: https://chromium-review.googlesource.com/237979
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Copy from auron with string changes.
BUG=none
BRANCH=none
TEST=make -j buildall, make -j tests
Change-Id: Ib9c894a7a06cd3840a66c448c49c848a8abc27b2
Signed-off-by: Grover Yen <Grover_Yen@wistron.com>
Reviewed-on: https://chromium-review.googlesource.com/237686
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Tj max of Broadwell should be 105C.
BUG=chrome-os-partner:34114
BRANCH=auron, paine, yuna
TEST="iotools rdmsr 0 0x1a2" return 0x690000, the Tj max should be 105C.
Change-Id: I3fe0a7a219761e259fef3b2571169561e08eb140
Signed-off-by: Henry Hsu <Henry.Hsu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/238131
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on off RPM
step0 0
step1 38 33 3200
step2 45 40 3700
step3 52 47 4000
step4 56 51 4400
step5 58 53 4900
step6 70 65 5500
step7 95 90 6500
ec shutdown point: 105
Where the temperature scale is celsius degree.
BUG=chrome-os-partner:34418
BRANCH=paine, yuna
TEST=Use the hacked code to return the fake temperature, check all the
steps with yuna. The fan behavior works properly.
Change-Id: Ibd2faecd47799bb66d4fafdda76f3db27814062a
Signed-off-by: Henry Hsu <Henry.Hsu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/237641
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Yuna, Paine define the thermal table for fan. The table is below:
on off RPM
step0 0
step1 43 37 3200
step2 48 43 3700
step3 52 47 4000
step4 56 51 4400
step5 60 55 4900
step6 70 65 5500
step7 95 90 6500
Where the temperature scale is celsius degree.
BUG=chrome-os-partner:34418
BRANCH=paine, yuna
TEST=Use the hacked code to return the fake temperature, check all the steps with yuna. The fan behavior works properly.
Change-Id: Id4f5957d63a81046539bc96a95e30b6b022803fe
Signed-off-by: Henry Hsu <Henry.Hsu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/233828
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chrome-os-partner:34411
BRANCH=Paine, Yuna
TEST=The offset between the two signals is around 13ms by using
oscilloscope to measure it.
Change-Id: I69677165e5ddea81d02464f5fcdee343862a733b
Signed-off-by: Henry Hsu <Henry.Hsu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/233860
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the parameter from the spec for 54Wh battery.
Use bat_id pin separate the two battery.
BUG=chrome-os-partner:32709
BRANCH=yuna
TEST=none
Change-Id: I7bd4c61f1d02652d1010a3efcb3f985fb66adaad
Signed-off-by: Henry Hsu <Henry.Hsu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/233116
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the parameter from the spec for 48Wh battery.
Also add the bat_id pin to identify 48Wh and 54Wh battries if yuna need
the 54Wh battery pack.
BUG=chrome-os-partner:32709
BRANCH=yuna
TEST=none
Change-Id: I7a04bf2b8c8b099d5202b6fdf23cd89aae4fd744
Signed-off-by: Henry Hsu <Henry.Hsu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/232173
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Paine use newer keyboard reset ic.
Some workaround is needed for old machine with old reset ic.
BUG=chrome-os-partner:33806
BRANCH=paine
TEST=flash the ec, the keys "3, e, d, c , ..." work in CrOS
with old machine.
Change-Id: I9167a3b0977013123e776b1cb71004e69d7dbb5a
Signed-off-by: Henry Hsu <Henry.Hsu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/230981
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Paine use newer keyboard reset ic. The keyboard column 2 should be
inverted.
BUG=chrome-os-partner:33806
BRANCH=paine
TEST=none
Change-Id: I922f51efac8e2d0a4bb33c603f0acf263cdef40f
Signed-off-by: Henry Hsu <Henry.Hsu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/230980
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement the led behavior based on customer SPEC.
Also change some point based on UI.
The UI use
percentage = remaining capacity / full charge capacity.
display percentage = (percentage - shutdown factor) / (full factor -
shutdown factor)
where shutdown factor = 0.04 and full factor = 0.97 .
If AC plug in, the UI percentage will be 100% when display
percnetage large than 97%.
The approximate value is calculated below.
UI 100% => the percnetage 0.965*0.93+0.04 = 0.93745. Use 937‰.
UI 10% => the percentage 0.104*0.93+0.04 = 0.13672. Use 137‰.
UI 3% => the percentage 0.034*.93+0.04 = 0.07016. Use 71‰.
BUG=chrome-os-partner:32802
BRANCH=paine, yuna
TEST=See below.
UI % AC battery led note
100 in blue
<=10 out amber 1s on/3s off low battery
<=3 out amber 1s on/1s off critical low battery
Change-Id: Ieff72771dbe7f8e21950be1fbfd2392129dd1ed2
Signed-off-by: Henry Hsu <Henry.Hsu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/227416
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the battery cut-off command is issued with external power present,
the battery can end up in one of the following two states:
1. The battery stays responsive but is waiting for the external power
to go away.
2. The battery decides to cut itself off right away.
In case 1, we are already avoiding charging the battery again, so we're
good. However, in case 2, the charge state machine mistakenly thinks the
battery is dead and tries to revive it. Fix this by checking if the
battery is cut off before starting to revive it.
BRANCH=None
BUG=chrome-os-partner:33372
TEST=Cut off the battery with external power connected. Wait for a while
and then disconnect external power. Check the battery is sure cut off.
Repeat for several times.
Change-Id: I9d0194446a87a47ef5c0024607a267aee3566268
Original-Change-Id: Icf343b168a556a490bc1786802a8a6e230863a28
Signed-off-by: Vic Yang <victoryang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/227521
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/229161
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
Commit-Queue: Mohammed Habibulla <moch@chromium.org>
Tested-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ifdef code than needs CONFIG_FPU (acos and friends)
BRANCH=ToT
BUG=chrome-os-partner:32050
TEST=define CONFIG_FPU on host board and use it.
Change-Id: I6bb6c280e6f8af882b52e95c1b01dd26e31d286e
Original-Change-Id: I1c4ed16c23450bb4059d26044f4c1fe45b33674e
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/226414
Reviewed-by: Alec Berg <alecaberg@chromium.org>
Reviewed-by: Sheng-liang Song <ssl@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/229170
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
Commit-Queue: Mohammed Habibulla <moch@chromium.org>
Tested-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These subcommands allow accessing sensor (accel+gyro)
over i2c.
BRANCH=ToT
BUG=chrome-os-partner:31071
TEST=Compile.
Change-Id: Ic19aac1b6f54ef844e242c5d19dfe63bf8e49d9d
Original-Change-Id: Ic6c3e9bf9c23f369de9f540c50daab7f2e4582ee
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/225653
Reviewed-on: https://chromium-review.googlesource.com/229156
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
Commit-Queue: Mohammed Habibulla <moch@chromium.org>
Tested-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When calling the ep_undefined function, the linker was not considering
it as a Thumb function and not setting the LSB in the address pointer.
This was causing an exception at runtime.
Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
BRANCH=all
BUG=none
TEST=inspect assembly
Change-Id: I176e584d36b61edd6efd6a6064482f67872be6e6
Original-Change-Id: I8f4d1e351081032e138f593f0b61294031fc09b1
Reviewed-on: https://chromium-review.googlesource.com/226093
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Commit-Queue: Vincent Palatin <vpalatin@chromium.org>
Tested-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/229160
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
Commit-Queue: Mohammed Habibulla <moch@chromium.org>
Tested-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add pwm control module for emulation board.
Signed-off-by: Dino Li <dino.li@ite.com.tw>
BRANCH=none
BUG=none
TEST=console manual test, pwm channels output correctly.
Change-Id: Ic5144c07743f859c280dbc08ec6b42eff6e661cc
Original-Change-Id: I6eb1a9e4fdcb9279e9d0cbd67f7a92afed21c889
Reviewed-on: https://chromium-review.googlesource.com/223921
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Commit-Queue: Dino Li <dino.li@ite.com.tw>
Tested-by: Dino Li <dino.li@ite.com.tw>
Reviewed-on: https://chromium-review.googlesource.com/229109
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
Commit-Queue: Mohammed Habibulla <moch@chromium.org>
Tested-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implements a new API for EC modules to define MKBP event sources
and send MKBP event to the AP. Also, a new host command
EC_CMD_GET_NEXT_EVENT is added for the AP to query the pending MKBP
events. Each event type may have custom event data sent along with the
event.
BRANCH=None
BUG=chrome-os-partner:33194
TEST=Enable MKBP event on Ryu. Set a host event from EC console, run
'ectool nextevent', and see MKBP event 0x01 (HOST_EVENT) and the set
host event.
Change-Id: Ic3ceff8b5ff6f3d8df7b74b74d535112fe4c09fb
Signed-off-by: Vic Yang <victoryang@chromium.org>
Original-Change-Id: I28a1b7e826bcc102bbe39016c9bb3e37d125664c
Reviewed-on: https://chromium-review.googlesource.com/224905
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/229107
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
Commit-Queue: Mohammed Habibulla <moch@chromium.org>
Tested-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Udelay function might get delay less than the time indicated by the
input parameter. udelay(4) sometimes get the tick like, 6->7->7->
8->8->9->A and then the udelay return. But, the sampling point of 6
could be at the end of 6(close to 7) and the point of A could be
right at the beginning of A(close to A). This function could get
delay from (us - 1) to (us + 1). This change is to ensure the delay
at least over the parameter, us.
BRANCH=master
BUG=None
TEST=Build an EC FW iamge and run on Rambi to ensure at the time
duration indicated by the parameter is elaspsed and satisfied.
Signed-off-by: Kenji Chen <kenji.chen@intel.com>
Original-Change-Id: I797f80c577d7e29e75a304aec1e02d2c750f8a23
Reviewed-on: https://chromium-review.googlesource.com/224660
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
Change-Id: Iacd0485511e9e01325bd7b11943880ea067be795
Reviewed-on: https://chromium-review.googlesource.com/229154
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
Commit-Queue: Mohammed Habibulla <moch@chromium.org>
Tested-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=master
BUG=chrome-os-partner:29139
TEST=Buiid an EC FW image and run on Rambi to test if key loss is
improved and any side effect somes with this change. Need more test
units to confirm this.
Signed-off-by: Kenji Chen <kenji.chen@intel.com>
Original-Change-Id: I2399e33d2ca3defe8cd9b1f94ab0af1db7f84635
Reviewed-on: https://chromium-review.googlesource.com/225557
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
Change-Id: Ia7acdbaec729f8ddff9228ebabbee716c012ba53
Reviewed-on: https://chromium-review.googlesource.com/229108
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
Commit-Queue: Mohammed Habibulla <moch@chromium.org>
Tested-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the USB console code would wait for up to
30 ms for the USB packet buffer to become available
for transmission, even if it was called from an interrupt
context. This doesn't work because, even if we were OK
with waiting this long in interrupt contexts, which we are
not, we rightly assert that we are not in an interrupt
context in task_wait_event, which usleep calls.
This solution is a quick fix to only wait when not called
from within an interrupt context. The correct solution
is likely to decouple the printf code from directly calling
the console driver code, instead we should place a queue
between the driver and printf logic.
Signed-off-by: Anton Staaf <robotboy@chromium.org>
BRANCH=None
BUG=None
TEST=make buildall -j
Enable USB console on discovery board and manually test.
Change-Id: I8f6f820fefc970d84db2b637a1504193be4fd9ce
Original-Change-Id: I5b6f7bbb77f75132c75935f8fda01e652a236ae0
Reviewed-on: https://chromium-review.googlesource.com/225867
Tested-by: Anton Staaf <robotboy@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Commit-Queue: Anton Staaf <robotboy@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/229155
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
Commit-Queue: Mohammed Habibulla <moch@chromium.org>
Tested-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a control transfer requests a descriptor larger than 64 bytes, we
need to do several IN transfers to get the proper packet sequence :
SETUP IN IN IN .. IN OUT(null)
Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
BRANCH=samus
BUG=chrome-os-partner:32652
TEST=set USB_STR_VERSION to "012345678901234567890123456789ABCDEF",
then do "lsusb -v" on the host and check the USB transfers
with the protocol analyzer.
Change-Id: I5ddeede41bd39acf3619a620c7046c9fcad5bc7a
Original-Change-Id: I6940095008cb2a34c6896b337c5eda4fa267adc1
Reviewed-on: https://chromium-review.googlesource.com/222700
Tested-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>
Commit-Queue: Vincent Palatin <vpalatin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/229151
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
Commit-Queue: Mohammed Habibulla <moch@chromium.org>
Tested-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The BOS (Binary Device Object Store) descriptor was added to the USB
specification (3.0) to allow a richer set of device capability
specific descriptors.
The Billboard class is meant to expose (read-only) the status of USB
devices capable of alternate mode functions. It's required to use the
BOS descriptor type and at a high level looks like:
- BOS Device Descriptor (5bytes)
- Container ID Device Capability Descriptor (20bytes)
- Billboard Device Capability Descriptor (44byte + 4 * numSVIDs)
This CL adds:
1. Ability for Get Descriptor on BOS descriptors. Note hidden behind
CONFIG_USB_BOS as these descriptors change USB device requirements
to:
- bcdUSB >= 0201
- no interface descriptors
2. structures for all BOS, Container & Billboard descriptor elements
complete w/ CamelCase.
BRANCH=none
BUG=chrome-os-partner:32652
TEST=compiles with CONFIG_USB & CONFIG_USB_BOS enabled.
Change-Id: I86c8ab80d16837b1eeb71cf83d3319da79682b08
Original-Change-Id: I1b24bc728f2ebba7d91840801d2ebe576e240e7c
Signed-off-by: Todd Broch <tbroch@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/221570
Reviewed-on: https://chromium-review.googlesource.com/229152
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
Commit-Queue: Mohammed Habibulla <moch@chromium.org>
Tested-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ectool has switched over to using getopt for command line options parsing.
This breaks temp_metrics' invocation of "ectool tmp006cal" command since
some of the coefficients are negative and therefore start with "-".
getopt treats that as another command line option causing ectool to
barf.
BUG=chromium:422160
TEST=On a Pixel issue "sudo start temp_metrics" and check
/var/log/messages to ensure that no new messages such as "init:
temp_metrics main process ended, respawning" show up.
BRANCH=none
Change-Id: I7c5a594908c20521f0eb2cbd81cdf001eb598df7
Original-Change-Id: I42232b3027ec6339814d226f1d8ab493e3420eea
Signed-off-by: Sameer Nanda <snanda@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/222845
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/229104
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
Commit-Queue: Mohammed Habibulla <moch@chromium.org>
Tested-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
charge_manager is intended to manage charge limits from various tasks
(typically PD charge tasks and USB / BC 1.2 charge tasks). These tasks
can update the charge limit of a port by calling charge_manager_update
(thread-safe function). If the charge limit has changed,
charge_manager_refresh will be queued as a deferred task, which will
select the "best" charge port and set the proper charge limit.
In order to use charge_manager, a board needs to do the following:
1. Declare PD_PORT_COUNT in usb_pd_config.h
2. Implement board_set_charge_limit
3. Implement board_set_active_charge_port
4. Call charge_manager_update whenever the available charge on a port changes.
BUG=chrome-os-partner:31361
TEST=Manual on samus_pd, with subsequent commit. Insert and remove
various chargers, check console to verify PD charger always has priority
and correct current limit is set based upon 'best' charger.
BRANCH=samus
Change-Id: Icc189523190a7e69766f2afe9ab40ce9b2c042ab
Original-Change-Id: Iede120b69e0b46ed329bcf9b7e07c39ba5e9f77b
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/222723
Reviewed-by: Alec Berg <alecaberg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/229153
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
Commit-Queue: Mohammed Habibulla <moch@chromium.org>
Tested-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Decode Pericom registers to current limits.
BUG=chrome-os-partner:32003
TEST=Manual on samus_pd. Insert 1A Apple charger, verify current limit
is correctly detected as 1A.
BRANCH=samus
Change-Id: Ib78f6c32b73d4bb7fbbf3b1dd285dfdad8c67e78
Original-Change-Id: I310d9f22cef80e97c1734e6a56f0034ebe01df31
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/222638
Reviewed-by: Alec Berg <alecaberg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/229150
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
Commit-Queue: Mohammed Habibulla <moch@chromium.org>
Tested-by: Mohammed Habibulla <moch@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Factory test process need lid switch no function or keep lid opened
BUG=chrome-os-partner:33304
BRANCH=paine,yuna
TEST=Run command "ectool forcelidopen 1" and "reboot". Then lid close
quickly, the system boot as lid opened.
Deault value or run command "ectool forcelidopen 0" make the device normal.
Change-Id: I94527b7ef7f9efe779c6b86f3eab651f99af6000
Signed-off-by: Henry Hsu <Henry.Hsu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/220740
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/227363
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the parameter from the spec.
BUG=chrome-os-partner:33083
BRANCH=paine
TEST=flash ec, the "ectool batterycutoff" works with the two battery.
Change-Id: Ifcdde2d9e2dd4fdaf3ffa2b5bb4c007fcdc3826e
Signed-off-by: Henry Hsu <Henry.Hsu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/224598
Reviewed-by: Mohammed Habibulla <moch@chromium.org>
|