summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * ectool: Remove the FAN STALLED printpoornima tom2023-02-131-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove the "Fan %d stalled!" print for the ectool command - "pwmgetfanrpm". This response fails the factory test to get the rpm value. Also, there is already indication of when fan stalled condition, when it has appeared by the print in file - common/fan.c;l=583. Hence, this print in this ectool command is unnecessary. BUG=b:268292546, b:261701530, b:266221111, b:268810195 TEST=Perform factory test BRANCH=None Change-Id: Ief479a7a2554cb59fb242ed0dd3592c1a38426de Signed-off-by: poornima tom <poornima.tom@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4236162 Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
| * omnigul: Modify power parametersLogan_Liao2023-02-131-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Base on power team modify power parameters. BUG=none BRANCH=none TEST=make BOARD=omnigul success. Change-Id: Id3823dcf67f77c1e77ead10c18debfadc54a3364 Signed-off-by: Logan_Liao <Logan_Liao@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4238059 Tested-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Kyle Lin <kylelinck@google.com> Commit-Queue: Kyle Lin <kylelinck@google.com> Reviewed-by: Logan Liao <logan_liao@compal.corp-partner.google.com>
| * microchip_xec: remove CROS_EC_RW_SIZE configurationDino Li2023-02-131-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This configuration is configured with binman's size property. BRANCH=none BUG=none TEST=build mtlrvpp_mchp. cat /generated/autoconf.h | grep CROS_EC_R #define CONFIG_CROS_EC_RO_MEM_OFF 0x0 #define CONFIG_CROS_EC_RO_SIZE 0x3F000 #define CONFIG_CROS_EC_RW_MEM_OFF 0x0 #define CONFIG_CROS_EC_RW_SIZE 0x40000 Change-Id: Ie169e6acfd6017fd6d12dcc08683d9b0eaf1bf42 Signed-off-by: Dino Li <Dino.Li@ite.com.tw> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4223682 Reviewed-by: Keith Short <keithshort@chromium.org>
| * it8xxx2: remove CROS_EC_RO_SIZE and CROS_EC_RW_SIZE configurationsDino Li2023-02-131-9/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Both configurations are configured with binman's size property. BRANCH=none BUG=none TEST=cat /generated/autoconf.h | grep CROS_EC_R #define CONFIG_CROS_EC_RO_MEM_OFF 0x0 #define CONFIG_CROS_EC_RO_SIZE 0x60000 #define CONFIG_CROS_EC_RW_MEM_OFF 0x60000 #define CONFIG_CROS_EC_RW_SIZE 0x60000 Change-Id: Idaf9fe8668657e7751c86996cb59efc320f1c259 Signed-off-by: Dino Li <Dino.Li@ite.com.tw> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4173174 Reviewed-by: Keith Short <keithshort@chromium.org>
| * crystaldrift: add keyboad config for function keyTang Qijun2023-02-132-0/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | add keyboad config for function key. BRANCH=none BUG=b:268414730 TEST=test the function key is work normal Change-Id: I0231e8cbd5440b96f8b2f3536daa710a81c655c7 Signed-off-by: Tang Qijun <qijun.tang@ecs.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4236859 Reviewed-by: Chao Gui <chaogui@google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
| * winterhold: Modify thermal configLeila Lin2023-02-122-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adjust fan tabel config to avoid the fan pulse on and off randomly when system power on. LOW_COVERAGE_REASON=no unit tests for skyrim yet, b/247151116 BRANCH=none BUG=b:268044663,b:255732503 TEST=verify the thermal config on winterhold is correct Change-Id: Ia2061b8c800a5d9f36fce4a2309d6c280b7bc55a Signed-off-by: Leila Lin <leilacy_lin@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4235045 Commit-Queue: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Tested-by: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com>
| * zephyr: test: Update RTC driver testSam Hurst2023-02-111-2/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update RTC driver test to compensate for the additional second added alarm time returned by system_get_rtc_sec(). BUG=b:261377404 BRANCH=None. TEST=twister -T zephyr/test/drivers Change-Id: I7bca42195bdbb066d214173972bc777960609641 Signed-off-by: Sam Hurst <shurst@.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4241078 Reviewed-by: Wai-Hong Tam <waihong@google.com> Tested-by: Sam Hurst <shurst@google.com> Commit-Queue: Sam Hurst <shurst@google.com>
| * zephyr: shim: Add 1 second to alarm settingSam Hurst2023-02-111-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adding 1 additional second to alarm setting because the system_get_rtc_sec() function returns the number of seconds truncated to the nearest integer. This results in missed alarms if, for example, the actualvalue is 7.99 seconds and 7 seconds is returned. BUG=b:261377404 BRANCH=None. TEST=check rtc_alarm 1 test_that ${DUT_IP} power_Resume Cq-Depend: 4241078 Change-Id: I1c07ecb8db6a3f6779c48d89cc39a2df12f92d7f Signed-off-by: Sam Hurst <shurst@.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4237580 Reviewed-by: Matthias Kaehlcke <mka@chromium.org> Tested-by: Sam Hurst <shurst@google.com> Commit-Queue: Sam Hurst <shurst@google.com> Reviewed-by: Wai-Hong Tam <waihong@google.com>
| * trogdor: Do not change the PPC SW and TCPC MUX when HPD changesWai-Hong Tam2023-02-111-22/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | During the DP-Config phase, when the DP-Config VDM is acked, the PPC SW and TCPC MUX are connected. Afterward, when the EC receives any HPD event (High, Low, or IRQ), should not change the PPC SW and TCPC MUX. Otherwise, disconnecting any of them when HPD Low makes the AUX termination disappear. BRANCH=trogdor BUG=b:247005613 TEST=Connect the device through a Type-C dongle to a monitor, unplug the monitor from the dongle, and replug it again. The monitor should detect the device and assert HPD high. Change-Id: Id890bfe8fec23109da2b36aa9662e24aec4ae32c Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4242456 Reviewed-by: Alexandru Stan <amstan@chromium.org>
| * zephyr/app/ec/chip/arm: Add memory layout definitionsPatryk Duda2023-02-111-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Introduce defines about memory layout for STM32 devices. Where possible, information is retrieved from DTS. BUG=b:239712345 BRANCH=none TEST=Compile firmware for bloonchipper. Change-Id: I9256fd85c679d4a6d98a29ad30850312c4fee0eb Signed-off-by: Patryk Duda <pdk@semihalf.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4226836 Reviewed-by: Eric Yilun Lin <yllin@google.com> Tested-by: Patryk Duda <patrykd@google.com> Commit-Queue: Patryk Duda <patrykd@google.com>
| * Kconfig: configure image size with binman's propertyDino Li2023-02-111-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since hash calculation has changed to fully calculate rw image. This change was made to allow board code to reconfigure image size with binman node to save the calculation time. The configuration of CROS_EC_RO_SIZE and CROS_EC_RW_SIZE of the chip needs to be removed to take effect. BRANCH=none BUG=none TEST=build mtlrvpp_mchp, nivviks, and yaviks. zmake compare-builds -a Signed-off-by: Dino Li <Dino.Li@ite.com.tw> Change-Id: I8d0684bf1926b54d3501385e5623b849374ffcef Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4165992 Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
| * zephyr/test: Unset CONFIG_ASSERT_TEST for driver testsRob Barnes2023-02-101-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Unset CONFIG_ASSERT_TEST for driver tests. This flag will mask assert failures in tests. BUG=b:268638354 BRANCH=None TEST=Pass driver unit tests Change-Id: I2dff6e78fe62a9fce01b2079055008925de64203 Signed-off-by: Rob Barnes <robbarnes@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4240495 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
| * zephyr/test: Move console_cmd_crash to separate testRob Barnes2023-02-106-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The console_cmd_crash test needs CONFIG_ASSERT_TEST set. Moving console_cmd_crash to be stand alone under drivers so this flag is not polluting any other tests. BUG=b:268638354 BRANCH=None TEST=Pass driver unit tests Change-Id: I5ee5de583b61c77cc483d41dc32c5a4eb0bf9585 Signed-off-by: Rob Barnes <robbarnes@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4240330 Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
| * zephyr: add comments for tcpc driverJason Yuan2023-02-102-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | added comments for tcpc driver left out from 4108942 BUG=b:254148652 TEST=none BRANCH=none Change-Id: Iaaa32b8a7bcd80be508707eabfb012728f9768b5 Signed-off-by: Jason Yuan <jasonyuan@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4238018 Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Auto-Submit: zhi cheng yuan <jasonyuan@chromium.org> Tested-by: zhi cheng yuan <jasonyuan@chromium.org>
| * tasks: Return TASK_ID_INVALID on errorRob Barnes2023-02-104-5/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Return `TASK_ID_INVALID` when `task_get_current` fails to find the current task instead of 0. 0 is a valid task id. `drivers.host_cmd_thread` test is also updated because it was dependent on this bug. By overriding `in_host_command_main` to return true when the fake main thread is running, `task_get_current` will return `TASK_ID_HOSTCMD` when the fake main thread is running. BUG=b:268477571 BRANCH=None TEST=Unit tests Change-Id: I2d5d6926cc9e2775a1c0e8141d760850bf25141b Signed-off-by: Rob Barnes <robbarnes@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4240327 Reviewed-by: Yuval Peress <peress@google.com> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
| * winterhold: Disable EC_EEPROM_CBI_WPLogan_Liao2023-02-101-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove CONFIG_PLATFORM_EC_SYSTEM_UNLOCKED. BRANCH=none BUG=b:267974153 TEST=Verify that cbi write not works on winterhold for disable factory mode. Change-Id: Iccc3744e31fff7d092b65ff0b7c3fd4f6c23a16f Signed-off-by: Logan_Liao <Logan_liao@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4236323 Tested-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Reviewed-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Commit-Queue: Logan Liao <logan_liao@compal.corp-partner.google.com>
| * cq: Don't exclude board specific code from covJeremy Bettis2023-02-101-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since we now know how to test board specific code, stop excluding it from the per-board coverage reports. BRANCH=None BUG=b:268490916 TEST=Ran report and posted diffs to bug Change-Id: Id1e2ba38a18be8f0b7fa8494d5f44df519315b6a Signed-off-by: Jeremy Bettis <jbettis@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4233935 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
| * geralt: turn off 5V before hibernatedEric Yilun Lin2023-02-101-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix immediate waking up from hibernate. Asserting EN_ULP will turn off the following in sequence: 1. PP3300_Z1 2. EC and GSC off 3. EC/GSC pull down the LID_OPEN_3V3 4. PP5000_Z1 off The leakage from PP5000_Z1 causes a pulse on LID_OPEN_3V3 in step 3~4, which is a wake source of hibernation. We set PP5000_Z1 to off before EN_ULP to fix the issue BUG=b:268448792 TEST=not waking up immediately after hibernated BRANCH=none Change-Id: I659b8e1389d69c1e863fb53f4c3e688bc65cc2cc Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4236858 Commit-Queue: Ting Shen <phoenixshen@chromium.org> Auto-Submit: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Tested-by: Eric Yilun Lin <yllin@google.com>
| * geralt: use mt8188 power sequenceEric Yilun Lin2023-02-104-5/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use MT8188 power sequence. BUG=b:267268982 TEST=* Cold reset: $ dut-control cold_reset:on sleep:0.2 cold_reset:off Result: G3 -> S0 * Long power press to shutdown: $ dut-control dut-control power_key:9.2 Result: S0 -> S5 -> G3 * Long power press to power-on but then shutdown: $ dut-control dut-control power_key:9.2 Result: G3 -> S0 -> S5 -> G3 * Short power press to power-on: $ dut-control dut-control power_key:tab Result: G3 -> S0 * Console command: apreset Result: S0 -> S0, AP reboots * Console command: apshutdown Result: S0 -> S5 -> G3 * Lid open to power-on: $ dut-control lid_open:no sleep:0.2 lid_open:yes Result: G3 -> S0 BRANCH=none Change-Id: Ifa922c1650c5f7e4ab881f17df6585993f13cc9a Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4219279 Commit-Queue: Eric Yilun Lin <yllin@google.com> Auto-Submit: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Tested-by: Eric Yilun Lin <yllin@google.com>
| * power/mt8186: support mt8188 power sequenceEric Yilun Lin2023-02-106-13/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MT8186 and MT8188 chipset have similar power sequence, so we re-use the mt8186.c. Add power signal EN_PP4200_PG_S5, which controls the PP4200 rail and which is PMIC's VCC. We turn it on/off at S5->S3/S3->S5. Also, drop cros-ec support, which is not used. BUG=b:267268982 TEST=* Cold reset: $ dut-control cold_reset:on sleep:0.2 cold_reset:off Result: G3 -> S0 * Long power press to shutdown: $ dut-control dut-control power_key:9.2 Result: S0 -> S5 -> G3 * Long power press to power-on but then shutdown: $ dut-control dut-control power_key:9.2 Result: G3 -> S0 -> S5 -> G3 * Short power press to power-on: $ dut-control dut-control power_key:tab Result: G3 -> S0 * Console command: apreset Result: S0 -> S0, AP reboots * Console command: apshutdown Result: S0 -> S5 -> G3 * Lid open to power-on: $ dut-control lid_open:no sleep:0.2 lid_open:yes Result: G3 -> S0 BRANCH=none Change-Id: I76bf3e4c4352982132e37bf952c29c4fce60f630 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4219278 Commit-Queue: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Auto-Submit: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com>
| * Frostflow : PS8811 initial setting.Logan_liao2023-02-102-5/+124
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Base on the Parade FAE, modify the PS8811 setting for 10G RX test. LOW_COVERAGE_REASON=test PS8811 retimer setting valid, use b/267711586 to tracking test. BUG=b:263458745 BRANCH=none TEST=local build for HW test 10G RX pass. Change-Id: I356eb04706866e3ededc493f8aa41c41af3f5a37 Signed-off-by: Logan_liao <Logan_Liao@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4199248 Tested-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Reviewed-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Reviewed-by: Chao Gui <chaogui@google.com> Commit-Queue: Chao Gui <chaogui@google.com>
| * it8xxx2: micro-optimize SHA256 computationPeter Marheine2023-02-091-2/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Hash performance is a significant contributor to EC boot-up time, so it's valuable to optimize the computation of firmware hashes. This change improves RW image hashing performance on Nereid, reducing time taken for `hash rw` on the console by about 15ms on average (from 1263ms to 1244ms for 384kB of data). This primarily replaces the byte swapping in SHA256_update with an inline assembly version that saves 6 instructions per word of data hashed. Calling htobe32() turns into a call into libgcc's __bswapsi2 which does implement an efficient swap, but spends several instructions reloading constant values used by the function and incurs function call overhead. This inline version saves 4 instructions by allowing the constants to be kept in registers through the entire SHA256_update (effectively hoisting the constant loads outside the loop), and 2 more in procedure call overhead. SHA256_chip_calculation is also optimized slightly: declaring the hash_ctrl local as volatile forces it to be allocated a stack slot and the read value be written to the stack (then ignored), which is unnecessary because the macro referring to the SHA1HASHCTRLR register is already a volatile read. Removing the unneeded qualifier saves 3 instructions between stack adjustment that is no longer needed (because the function now operates only on values that fit in registers) and the unneeded store that is now removed. BUG=b:260762509 TEST=`hash 0xbfffc 32` has the same value before and after this change, with manual verification that the 32 bytes of memory at 0x800bfffc are unchanged between the two builds (`md 0x800bfffc 32`). BRANCH=nissa LOW_COVERAGE_REASON=uncovered line can only run on actual hardware, not native_posix where coverage is gathered Change-Id: I99fcb2278518f6a57046985ef03a58ebb2f307a1 Signed-off-by: Peter Marheine <pmarheine@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4235298 Reviewed-by: Adam Mills <adamjmills@google.com>
| * zephyr/test/skyrim: Add alt charger testRobert Zieba2023-02-097-2/+106
| | | | | | | | | | | | | | | | | | | | | | | | | | Add alt charger test for crystaldrift and skyrim. BRANCH=none BUG=b:247151116 TEST=Ran tests and verified coverage results Change-Id: Ic186d18a2ceaf65f077ca997bc4f9e86f9901766 Signed-off-by: Robert Zieba <robertzieba@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4233934 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
| * zephyr: move usbc interrupt handler to shimJason Yuan2023-02-0970-280/+457
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | TCPC interrupt no longer uses gpio-int. Instead the shim tcpc completely handles its own interrupt. An optional config is added to allow projects to use the legacy tcpc interrupt. The program intelrvp is excluded from this CL. BUG=b:254148652 TEST=twister, usbc charging on villager, lazor, and xivu BRANCH=none Change-Id: Ieeb4fb61ca6cf8f44df212a6cf520d265cff5147 Signed-off-by: Jason Yuan <jasonyuan@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4108942 Commit-Queue: zhi cheng yuan <jasonyuan@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Tested-by: Diana Z <dzigterman@chromium.org>
| * zephyr/test/skyrim: Add fan testRobert Zieba2023-02-099-3/+147
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Add fan test and enable test for skyrim, crystaldrift and markarth variants. BRANCH=none BUG=b:247151116 TEST=Ran tests Change-Id: I7d11d28c1a864b24e06a1464160662f994509adf Signed-off-by: Robert Zieba <robertzieba@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4225008 Reviewed-by: Al Semjonovs <asemjonovs@google.com>
| * run_device_tests: Temporarily ignore long line errorsBobby Casey2023-02-091-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | run_device_tests has gotten long enough to report an error about lines being too long. Ignore this error until it is refactored. BUG=none BRANCH=none TEST=none Change-Id: I461de971f4ce0b9912895511c459c8f54a62db6d Signed-off-by: Bobby Casey <bobbycasey@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4193839 Reviewed-by: Tom Hughes <tomhughes@chromium.org>
| * run_device_tests: Add option to test with production app imageBobby Casey2023-02-091-16/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add the ability to run tests against the production application image. It should be noted that the production image does not support the "runtest" command so any tests using a production image must supply appropriate commands using pre/post test callbacks (to be added in a future CL) and/or supplying finish_regexes. Also add a test to verify this functionality. Tests using the standard application image should not have a target buildable via make, as they use the standard app) but may be run from run_device_tests.py. BUG=b:180445334 BRANCH=none TEST=run_device_tests.py -b dartmonkey Signed-off-by: Bobby Casey <bobbycasey@google.com> Change-Id: I76cc248775a4cafdfcc4278799156a291277a19b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4193835 Reviewed-by: Tom Hughes <tomhughes@chromium.org> Reviewed-by: Andrea Grandi <agrandi@google.com>
| * geralt: enable I2C PEC and I2C retry on NAKEric Yilun Lin2023-02-091-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We've seen that the i2c devices on the ports sometimes return NAK due to device busy, or too much traffic on the port. Enable the i2c controller to resend the command when NAK happens. BUG=none TEST=none BRANCH=none Change-Id: I5a26a19a864f92cf6c45c103610585891fb7bced Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4218836 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Auto-Submit: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org>
| * chgstv2: Don't clear user_current_limit on suspend or shutdownDaisuke Nojiri2023-02-091-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These hooks were introduced for Link: b/35514568 (crrev/c/37532), which has been removed from ToT. If there are boards which will rely on these hooks, the OS should explicitly clear user_current_limit before shutdown or suspend. These hooks are preventing a charge current limit from being persistent after suspend or shutdown. BUG=b:35514568, b:265372046 BRANCH=None TEST=buildall Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Change-Id: Iffc2ffdf4fbc96bc1395508b62e4f54ea63c08c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4233921 Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com>
| * jinlon: Adjust TEMP_SENSOR_4 thresholds to reduce fan speed in clamshellDevin Lu2023-02-091-14/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | BUG=b:261696880 BRANCH=firmware-hatch-12672.B TEST=Thermal team verified thermal policy is expected. Change-Id: Ia376eddaaaf8036aa244011a7cf097e8f883ca7a Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4225587 Tested-by: Devin Lu <devin.lu@quantatw.com> Commit-Queue: Devin Lu <devin.lu@quantatw.com> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
| * frostflow: modify fan tablematt_wang2023-02-092-36/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | According to the thermal team requirement modify the fan table setting. BUG=b:257149501 BRANCH=none TEST=Thermal team test pass Change-Id: Ic7eb930810f6dabee182e04a44f31f0fe65cadd8 Signed-off-by: matt_wang <matt_wang@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4230853 Reviewed-by: Diana Z <dzigterman@chromium.org> Reviewed-by: SamSP Liu <samsp_liu2@compal.corp-partner.google.com>
| * ap_pwrseq: Enable driver to use state machine APIBernardo Perez Priego2023-02-094-18/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL includes state machine API calls in AP power sequence driver implementation. BUG=b:217952699 BRANCH=none TEST=zmake build Change-Id: Ibe48608f1e09879a636a5e9ce7ac0e5a25214fe0 Signed-off-by: Bernardo Perez Priego <bernardo.perez.priego@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4162274 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
| * ap_pwrseq: Implement AP power sequencer driver underlying frameworkBernardo Perez Priego2023-02-095-0/+824
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL establishes an underlaying framework to easily add or extend AP Power Sequence routines, it is designed to follow the zephyr's State Machine Framework (SMF). This CL includes the following: - Macros definition to incorporate state machine action handlers implementation for all three levels: Application, chipset and architecture. - Devicetree binding declaration to allow creating additional powert states. - Implementation of API's to interact with state machine. BUG=b:217952699 BRANCH=none TEST=zmake build Signed-off-by: Bernardo Perez Priego <bernardo.perez.priego@intel.com> Change-Id: Ic9ee7b81795d43eea8bb1ed3d78bd2cc2f5df0e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4098524 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
| * ap_pwrseq: Implement Application Processor (AP) power sequencer driverBernardo Perez Priego2023-02-094-3/+441
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This driver provides execution context for underlaying AP power sequence framework. This CL includes driver API's implementation and declares configuration flag CONFIG_AP_PWRSEQ_DRIVER. BUG=b:217952699 BRANCH=none TEST=zmake build Signed-off-by: Bernardo Perez Priego <bernardo.perez.priego@intel.com> Change-Id: I3e0e0f405a13db4713844bd94c2a87d6eb70e176 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3645011 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
| * common/body_detection: Update reset code to prevent extra state changesRobert Zieba2023-02-091-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `body_detect_reset` calls `body_detect_change_state` even if there is no actual state change. When host notifications are enabled this can cause extraneous events that result in incorrect motion sensor timestamps as the motion sense task uses the time of the last MKBP event to update timestamps in the FIFO. BRANCH=none BUG=b:263841660 TEST=Ran CtsSensorTestCases Change-Id: I4c7233019baf3496b802ca19156351babd7f3b94 Signed-off-by: Robert Zieba <robertzieba@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4214672 Commit-Queue: Gwendal Grignou <gwendal@chromium.org> Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
| * yaviks: reduce RW image size (64KB)Dino Li2023-02-082-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This saves ~95 ms of boot time. There is 20KB left after applying this change. BRANCH=none BUG=b:260762509 TEST=saved ~95 ms of boot time on yaviks. Change-Id: I2c285fc6aed5dc8cb3a5ba9f5885a778854164e0 Signed-off-by: Dino Li <Dino.Li@ite.com.tw> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4165998 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
| * zephyr: Add flash definitions required by EC for STM32Patryk Duda2023-02-084-0/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | BUG=b:239712345 BRANCH=none TEST=Compile firmware for bloonchipper. Change-Id: Ia5801040a8811d73961b4bf0132c34248c5bdd66 Signed-off-by: Patryk Duda <pdk@semihalf.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4226835 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Tested-by: Patryk Duda <patrykd@google.com> Commit-Queue: Patryk Duda <patrykd@google.com>
| * chip/stm32: Fix for opting out of flash supportJes B. Klinke2023-02-081-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | Adapt dfu_bootmanager_main.c to compile without flash support. BUG=b:192262089 TEST=make BOARD=hyperdebug Change-Id: I9ceca733062b46ed7087ef7725bc1f6ac68c6b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4193071 Commit-Queue: Jes Klinke <jbk@chromium.org> Reviewed-by: Brian Nemec <bnemec@google.com> Tested-by: Jes Klinke <jbk@chromium.org>
| * ppc/rt1739: implement dead battery bootTing Shen2023-02-082-3/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If rt1739 seems to be the only power source of the system, don't turn off its HV sink path. BUG=b:267412033 TEST=Verify that PPC is able to supply power in follow scenarios: 1) power on without battery 2) sysjump without battery 3) ec reset without battery BRANCH=none LOW_COVERAGE_REASON=early bringup Change-Id: I13d291edfc78f6e1491b3c4a0d8e2e661925004d Signed-off-by: Ting Shen <phoenixshen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4225988 Commit-Queue: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com> Tested-by: Ting Shen <phoenixshen@chromium.org>
| * Casta : Change charging voltage and currentYongBeum.Ha2023-02-081-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | Change charging voltage(8600mV) and current(3200mA). BUG=b:266123223 BRANCH=firmware-octopus-11297.B TEST=build, update and check charging voltage and current Change-Id: Ib7b520fbb355ac7ad73634e21271569ed5073d10 Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4199245 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
| * Omnigul: implement keyboard matrixfelixtw_chang2023-02-085-2/+241
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | enable customization define, implement customization matrix. BRANCH=none BUG=b:267817382 TEST=make -j BOARD=omnigul pass Change-Id: Ie1a555ef77a2fa6bad17150a7c20b0cc1133b5a2 Signed-off-by: felixtw_chang <felixtw_chang@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4220796 Reviewed-by: Kyle Lin <kylelinck@google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Commit-Queue: Kyle Lin <kylelinck@google.com>
| * Nautilus : Change charging voltage and currentYongBeum.Ha2023-02-081-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Change charging voltage(8600mV) and current(3200mA). BUG=b:266123223 BRANCH=firmware-octopus-11297.B TEST=build, update and check charging voltage and current Change-Id: I589692ae43231b2af61a7ced129b5340a5cbd041 Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4199247 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Henry Sun <henrysun@google.com>
| * test: Check TPM_SEED is reset after rebootFiras Sammoura2023-02-086-0/+118
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a unit test to check that TPM_SEED is reset after the FPMCU is rebooted. BRANCH=None BUG=b:143471027 TEST=test/run_device_tests.py -b dartmonkey -t tpm_seed_clear TEST=test/run_device_tests.py -b bloonchipper -t tpm_seed_clear Change-Id: I478c8ffcfc75c8188438d56958f0bf16f752efef Signed-off-by: Firas Sammoura <fsammoura@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4199160 Reviewed-by: Tom Hughes <tomhughes@chromium.org>
| * docs: Add missing sudo to commandTom Hughes2023-02-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | BRANCH=none BUG=none TEST=run "JLinkRemoteServerCLExe -select USB" Cannot connect to J-Link. Retrying in 5 seconds.. TEST=run "sudo JLinkRemoteServerCLExe -select USB" -> success Change-Id: If701bacfc4ce04d778be0f6800b4bb266866f1af Signed-off-by: Tom Hughes <tomhughes@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4228735 Reviewed-by: Firas Sammoura <fsammoura@google.com>
| * zephyr: zmake: Limit modules by defaultJack Rosenthal2023-02-082-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most builds only require the EC module, and for ARM boards, they require the CMSIS module as well. Default to just the EC module, and turn on CMSIS for nuvoton/mchp. BUG=b:268050548 BRANCH=none TEST=zmake build -a => version strings have less modules than usual Change-Id: Iddf24c159edf1a9c13671eaa478ea30f402d52c7 Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4228737 Reviewed-by: Aaron Massey <aaronmassey@google.com> Commit-Queue: Aaron Massey <aaronmassey@google.com>
| * TCPMv2: Obsolete AMODE commandsDiana Z2023-02-078-213/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The AMODE host commands were created to support GFU mode, which we do not support in TCPMv2. Move these host commands to a TCPMv1 only file and remove references to them from the unit tests. BRANCH=None BUG=b:267562375 TEST=./twister -T ./zephyr/test Change-Id: I7bafcd8eded1f8eca4082560172aee91ebd7ff24 Signed-off-by: Diana Z <dzigterman@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4221975 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
| * TCPM: Separate Discovery into its own moduleDiana Z2023-02-079-432/+491
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Discovery can be a separate feature from DFP mode entry, as any data role can run discovery in PD 3.0. Additionally, boards may want to enable discovery separate from full EC mode entry so put this feature behind a new CONFIG indicating its scope. BRANCH=None BUG=b:266714542 LOW_COVERAGE_REASON=only moving functions to a new file, b/267964449 filed to track expanding the testing of these functions later TEST=./twister -T ./zephyr/test, run on both nipperkin (ECOS) and skyrim (zephyr) to confirm cable and device identities are being reported correctly Change-Id: I84a08eaf4775ed427112d62777ff38f8a914a750 Signed-off-by: Diana Z <dzigterman@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4211268 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
| * TCPMv2: Gate DP module support on a CONFIGDiana Z2023-02-0717-36/+220
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a CONFIG option to gate DP mode support within the embedded controller. By default, turn the DP module off if the AP is controlling the VDMs for mode entry. For modules which do not implement the DP config option, the header now defines stubs for DP specific functions to use. This obsoletes some of the stub functions from older unit tests. BRANCH=None BUG=b:266714542 TEST=on skyrim, compile with DP disabled and observe 3162 bytes saved, run zmake compare-builds -a and util/compare_build.sh -b all, ./twister -T ./zephyr/test passes (note: ECOS compare builds needed all assert statements removed to pass, as they grab the line number, zephyr compare builds passed before HC mode entry was revamped) Change-Id: I9619eb5d34e418f1972c4bf16d4cf9c8d551eac5 Signed-off-by: Diana Z <dzigterman@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4201454 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
| * run_device_tests: Add explicit function to power cycle the boardBobby Casey2023-02-071-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | BUG=b:180445334 BRANCH=none TEST=run_device_tests.py -b dartmonkey -t system_is_locked_wp_off TEST=run_device_tests.py -b dartmonkey -t system_is_locked_wp_on TEST=run_device_tests.py -b dartmonkey -t flash_physical TEST=run_device_tests.py -b dartmonkey -t flash_write_protect Change-Id: I4bee052e1766ff1eb09123cb494ea59d857fef18 Signed-off-by: Bobby Casey <bobbycasey@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4121374 Reviewed-by: Tom Hughes <tomhughes@chromium.org> Reviewed-by: Andrea Grandi <agrandi@google.com>
| * zephyr/test/skyrim: Add variant specific logsRobert Zieba2023-02-075-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Register crystaldrift, markarth, and skyrim logs to match what the board code does. BRANCH=none BUG=b:247151116 TEST=Ran tests Change-Id: If92ce6e8e01a160ab75056952f23f69a3079022b Signed-off-by: Robert Zieba <robertzieba@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4225007 Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Diana Z <dzigterman@chromium.org>
View Lorry Controller Status