summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* {ambassador,genesis,moonbuggy,scout}: Increase fan to reduce throttling.firmware-puff-13324.B-masterRichard Yeh2023-01-318-8/+152
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Chromebox for Meetings (CfM) devices are videoconferencing appliances. Discovering that a significant fraction of our fleet was throttling the CPU due to temperature, resulting in bad video quality, we have decided that these devices should never throttle. The present change reduces the temperature thresholds at which we increase fan speeds. For most of the time, when the CfM is idle, we expect no or little change in fan speeds. During calls, the CfM CPU can exceed 60 C, and the sensors controlling the fan are typically 10-20 degrees C cooler than the CPU, so we set the maximum-fan temperature to 50-55 C in an attempt to arrest any temperature increase before the CPU reaches throttling temperatures. We add fan tables to enable hysteresis in the fan speed setting. Fan RPMs are chosen to span the min-to-max range, while avoiding 50 Hz and 60 Hz line frequencies. fizz and kalista boards are shared with non-CfM versions, while the other boards are CfM-only. Since those boards are several years old, we plan to build these firmware changes only into CfM-branch releases, not all fizz and kalista devices. Additional details at go/cfm-overheating . Temperature traces with load testing on both top-of-tree and firmware with this change are shown at go/cfm-overheating#heading=h.ykpzxotgnu2j BRANCH=update-fan-tables BUG=b:252966838,b:191187610,chromium:1383859 TEST=Confirmed validity of settings with `ectool thermalset`. Built firmware, flashed to endeavour and excelsior (fizz), verified that fan turns on earlier. This does not completely prevent throttling from 47.25 W to 15.00 W on Kaby Lake boards (endeavour, fizz, kalista), but it does prevent dropping below 15.00 W. Comet Lake boards (ambassador, genesis, moonbuggy, scout) start at 15.00 W and rarely throttle anyway. Signed-off-by: Richard Yeh <rcy@google.com> Change-Id: I7f23583ca1b85d3b8b9da43918880f68b41538c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4060610 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> (cherry picked from commit 5e2e4a52a1b2d5231285a7ff5081f291b8adad1a) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4200717 Reviewed-by: Kyle Williams <kdgwill@chromium.org>
* fan: Rewrite and test the most common custom fan_percent_to_rpm.Richard Yeh2023-01-313-13/+237
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | temp_ratio_to_rpm_hysteresis uses a sorted fan_table containing a mapping of temp_ratio (percent, 0-100) to fan rpm. This clarifies the relationship of temperature to fan speed, while reducing the number of static variables. The existing temp_ratio expressing the percentage of cooling needed (temperature from temp_fan_off to temp_fan_max) suggests the possibility that a proportional-integral-derivative (PID) feedback controller might have been considered; but the default implementation is purely linear (mapping to fan speed from min to max) and this stepwise one just enables hysteresis --- different speeds when the board is warming up than when cooling down. The hysteresis attempts to avoid oscillations in temperature and fan speed. This refactoring is in preparation for reusing this implementation for {ambassador, genesis, moonbuggy, scout}. {kalista, berknip, chronicler, dewatt, endeavour, ezkinil, fizz} define CONFIG_FAN_RPM_CUSTOM and use this or nearly this implementation of a fan_percent_to_rpm with hysteresis. {chronicler} also performs boxcar smoothing of the input. {osiris}, which has two fans, and {jinlon, redrix, and other boards with multiple sensors}, use a similar but not exactly the same implementation, and would need additional abstraction. See: https://source.chromium.org/search?q=f:ec%2Fb%20fan_step%20-f:board.c BRANCH=refactor-fan-percent-to-rpm BUG=b:252966838,b:191187610,chromium:1383859 TEST=make -j run-fan && make -j buildall && make -j runhosttests Signed-off-by: Richard Yeh <rcy@google.com> Change-Id: I50ad4d78ac1145f92573a417646c1f57b8945463 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4021951 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org> (cherry picked from commit 62c3a651befeb8d9b3ad03994b23b579d92c20d8) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4197674 Reviewed-by: Kyle Williams <kdgwill@chromium.org>
* moonbuggy: assert/deassert RESET when entering/exiting S5Pablo Ceballos2022-11-171-0/+12
| | | | | | | | | | | | | | BUG=b:244123022 BRANCH=puff TEST=Boot and reboot moonbuggy successfully. Change-Id: I835e21a9f3d17a5337e142bd7405d95c3f1493b0 Signed-off-by: Pablo Ceballos <pceballos@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3960925 Reviewed-by: Chris Gerber <gerb@google.com> Reviewed-by: Bruce Goodwin <bgoodwin@chromium.org> Commit-Queue: Pablo Ceballos <pceballos@chromium.org> Tested-by: Pablo Ceballos <pceballos@chromium.org>
* power: Don't set the AP_IDLE flag if a power failure occurredPablo Ceballos2022-08-163-1/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | The AP_IDLE flag prevents the AP from automatically starting up. This is normally applied when the device has shut down cleanly. If the device has experienced power loss and has not shut down cleanly, the AP power state should be restored when power is restored. With some power supplies, the voltage drops slowly when the AC power is disconnected. This can cause the EC to detect that there is a power failure on some higher voltage rails while it continues to be powered for a short while from a lower voltage rail. In such a scenario, the EC can actually have enough time to complete all of the S0->S3->S5 power state transitions and trigger the chipset_shutdown hook that sets the AP_IDLE flag. BUG=b:239979405 TEST=Manually tested AC hotplug behavior on moonbuggy board BRANCH=none Change-Id: I82ec3c481fc62c79b5798b4d52f025a2825546f4 Signed-off-by: Pablo Ceballos <pceballos@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3824925 Tested-by: Pablo Ceballos <pceballos@chromium.org> Auto-Submit: Pablo Ceballos <pceballos@chromium.org> Reviewed-by: Bruce Goodwin <bgoodwin@chromium.org> Commit-Queue: Bruce Goodwin <bgoodwin@chromium.org>
* moonbuggy: enable ADS control interruptben chen2022-06-241-0/+5
| | | | | | | | | | | | | | | | | | | | | enable interrupt handle power sequence control pin 5v: ADS_5VS_V2_ADP_PRESENT_L 12v: BJ_ADP_PRESENT_L BUG=b:211546881 BRANCH=cros/main TEST=build BOARD PASS and EE check is PASS. Change-Id: Iab2d83a3b6ea2248bbae3d786ac2910c06ac1c4d Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3711519 Reviewed-by: Keith Short <keithshort@chromium.org> (cherry picked from commit 1e103abc014688f70f7c1c704e64611381fa5855) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3719291 Tested-by: Pablo Ceballos <pceballos@chromium.org> Reviewed-by: Rehan Ghori <rehang@chromium.org> Commit-Queue: Pablo Ceballos <pceballos@chromium.org>
* dooly: update GPIO status in HOOK_INITZick Wei2022-06-131-0/+2
| | | | | | | | | | | | | | | | | Set GPIO_EC_PCH_RTCRST to low in HOOK_INIT. BUG=b:234105289 BRANCH=puff TEST=make sure tool can keep going when EC cold boot with specific RO and RW firmware version. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I93cadf278df36bf78e7ee797683a642980428a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3676898 Reviewed-by: Andrew McRae <amcrae@google.com> (cherry picked from commit 9d0b435e90b4583f04c36af97baf2bb006df16d3) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3686011 Commit-Queue: Andrew McRae <amcrae@google.com>
* moonbuggy: Change blue LED to whitePablo Ceballos2022-05-203-18/+18
| | | | | | | | | | | | | | BUG=None TEST=ectool led power query BRANCH=puff Change-Id: Id04390dd43b93955350c04ceb3e446c37662d270 Signed-off-by: Pablo Ceballos <pceballos@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3655290 Reviewed-by: Joe Tessler <jrt@chromium.org> Auto-Submit: Pablo Ceballos <pceballos@chromium.org> Tested-by: Pablo Ceballos <pceballos@chromium.org> Commit-Queue: Joe Tessler <jrt@chromium.org>
* Scout: delay 1s to initialize ambient light sensorSue Chen2022-04-112-2/+4
| | | | | | | | | | | | | | | | | | Let sensor only active in S0 and set CONFIG_MOTION_SENSE_RESUME_DELAY_US 1000 msec for ALS sensor is powered by PP3300_S. BUG=b:228772482 BRANCH=puff TEST=ALS sensor function pass Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I52120834d60d3786789f893edea65522f7b5c20b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3581360 Reviewed-by: Joe Tessler <jrt@chromium.org> Commit-Queue: Joe Tessler <jrt@chromium.org> (cherry picked from commit 42a726797086af9f2f51cb8ae58afbb7f9b40114) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3581817
* moonbuggy: Update GPIOsPablo Ceballos2022-04-015-54/+30
| | | | | | | | | | | | | | | | | | | | | | | | Implement the GPIOs that have been changed from genesis. - Removed several USB A ports - Added ADB I2C - Removed USB_C0_TCPC and USB_C0_TCPPC I2C - Added various misc pins: HDMI_DATA_EN_DB, EN_USB_C0_5V_OUT, SBU_C0_FAULT_ODL - Fixed typo in the name of EN_AC_JACK_CHARGER_EC_L - Only support red and blue LED BUG=None TEST=moonbuggy boots BRANCH=None Change-Id: I98256236b83ffd21bd989b0aba4eaab6b38cee69 Signed-off-by: Pablo Ceballos <pceballos@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3539346 Tested-by: Pablo Ceballos <pceballos@chromium.org> Reviewed-by: Joe Tessler <jrt@chromium.org> Commit-Queue: Pablo Ceballos <pceballos@chromium.org> Feels: Pablo Ceballos <pceballos@chromium.org>
* scout: use SUSPEND and RESUME hooks for TPU powerPeter Marheine2022-03-243-29/+15
| | | | | | | | | | | | | | | | | | | | | | The changes in commit 4481408005a325a7246cefe15d305eb1975c8fac were unnecessarily complex, since HOOK_CHIPSET_RESUME is called on transition to S0 from either S3 or S0ix, and HOOK_CHIPSET_SUSPEND is similarly called when dropping from S0 to either of S3 or S0ix. BUG=b:200923497 TEST=make BOARD=puff BRANCH=puff Change-Id: If3d79ceadf60dac120c5014b0f98fb744e9d6fab Signed-off-by: Peter Marheine <pmarheine@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3544168 Reviewed-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Tested-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Reviewed-by: Joe Tessler <jrt@chromium.org> (cherry picked from commit 1ef7c65756987c0788f305f99a2c46208ccdcb8c) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3544758 Auto-Submit: Sue Chen <sue.chen@quanta.corp-partner.google.com> Commit-Queue: Joe Tessler <jrt@chromium.org>
* Scout: Power off TPU and IMX8 in S0ixSue Chen2022-03-224-1/+31
| | | | | | | | | | | | | | | | | | | | Turn off PP3300_TPU_A_EN and EC_IMX8_EN in S0ix. EC_IMX8_EN is for PP5000_MX8M. BUG=b:200923497 BRANCH=puff TEST=check power consumption in suspend. (cherry picked from commit fefd5cbd40938c5def7eaf7df30502dbf788722c) Signed-off-by: Joe Tessler <jrt@google.com> Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I9bd4bfa945cb95d62fc104670089e51f7bbb40ae Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3539777 Tested-by: Joe Tessler <jrt@chromium.org> Auto-Submit: Joe Tessler <jrt@chromium.org> Reviewed-by: Stefan Adolfsson <sadolfsson@chromium.org> Commit-Queue: Joe Tessler <jrt@chromium.org>
* driver/mp3385: update delay timingZick Wei2022-03-011-1/+1
| | | | | | | | | | | | | BUG=b:220957460 BRANCH=puff TEST=verified IC power on sequence meet spec on dooly. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I74f6462672a9a6f7a4313c5fa0d3e32e0952136f (cherry picked from commit fccf463cd9bd6e3f4220b244a24ab6dee5639949) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3487374 Reviewed-by: Andrew McRae <amcrae@google.com> Commit-Queue: Andrew McRae <amcrae@google.com>
* moonbuggy: supports ADS control handler functionBen Chen2022-01-183-6/+52
| | | | | | | | | | | | | | | | | Add ADS control handlers 12v/5v services. BUG=b:211546881 BRANCH=cros/main TEST=build BOARD PASS and EE check is PASS. Change-Id: I8bd5db4572423a2f272789a67538e62a5bb08f85 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3369165 Reviewed-by: Joe Tessler <jrt@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org> (cherry picked from commit 83b28157895642cb6925e6354dbfbc3851379999) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3378990
* scout: Enable mics on boards without EC_MIC_OE in ROStefan Adolfsson2022-01-131-0/+6
| | | | | | | | | | | | | | | | RW firmware does not initialize GPIOs, so the GPIO needs to be set explicitly. BUG=b:214228751 BRANCH=puff TEST=Measure EC_MIC_OE with oscilloscope. Change-Id: Ifbc77b18ef11816fd2f443abb9ac6b502524c1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3386840 Reviewed-by: Joe Tessler <jrt@chromium.org> Commit-Queue: Stefan Adolfsson <sadolfsson@chromium.org> Tested-by: Stefan Adolfsson <sadolfsson@chromium.org> Auto-Submit: Stefan Adolfsson <sadolfsson@chromium.org>
* scout: set microphone enable high per defaultStefan Adolfsson2022-01-131-0/+1
| | | | | | | | | | | | | | | | | | Just trusting the pull-ups seems to not be enough. We are still seeing some missing microphones during acoustic testig. EE recommends to pull it high from the EC. BUG=b:214228751 BRANCH=puff TEST=Measure EC_MIC_OE with oscilloscope and sent before and after pictures to EE. Change-Id: I9d67b1841341679531ca415990b7b1fcec9ebc0c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3382980 Reviewed-by: Bruce Goodwin <bgoodwin@chromium.org> Reviewed-by: Joe Tessler <jrt@chromium.org> Tested-by: Joe Tessler <jrt@chromium.org> Commit-Queue: Stefan Adolfsson <sadolfsson@chromium.org>
* Scout: update fan_rpmSue Chen2022-01-131-2/+2
| | | | | | | | | | | | | | | | | | | | | | fan_rpm: rpm_min = 2400 rpm_start = 2400 rpm_max = 5300 BUG=b:195602767, b:210821390 BRANCH=puff TEST=thermal test pass Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I7e46a08e2ad4ef0c759e3dfedb516246774967e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3367716 Reviewed-by: Joe Tessler <jrt@chromium.org> (cherry picked from commit 229723e49cef20809c0ca0fca520d63c0cfd0e24) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3372201 Tested-by: Joe Tessler <jrt@chromium.org> Auto-Submit: Joe Tessler <jrt@chromium.org> Reviewed-by: Rehan Ghori <rehang@chromium.org> Commit-Queue: Rehan Ghori <rehang@chromium.org>
* dooly: support led driver mp3385Zick Wei2021-12-213-3/+58
| | | | | | | | | | | | | | | | This patch add support mp3385 as second source led backlight ic. BUG=b:208722790 BRANCH=puff TEST=verify backlight ic setting different by SSFC. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I88c5b9e4c13afe61812c0f51b944b6525d6959c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3329188 Reviewed-by: Andrew McRae <amcrae@google.com> (cherry picked from commit 8637afa2123785ae0e3ffc4a35de273c79c304c4) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3347359
* cleanup: driver/led: oz554 and mp3385Zick Wei2021-12-218-22/+21
| | | | | | | | | | | | | | | | Cleanup oz554 and mp3385 low level driver, for more compatible with boards. BUG=b:208722790 BRANCH=none TEST=make BOARD=dooly, make BOARD=karma Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Ia0169099c0315843fbd5b567b4538aa823f02a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3329187 Reviewed-by: Andrew McRae <amcrae@google.com> (cherry picked from commit d6a4b19c732a9b690baa12a90614b1506a2e61c5) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3347358
* dooly: add ssfc led fieldZick Wei2021-12-212-2/+23
| | | | | | | | | | | | | | | Dooly need add ssfc led field for second source led ic. BUG=b:208722790 BRANCH=puff TEST=make BOARD=dooly Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I501710c2d92bba484a4848dee6f43cfc6f428e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3329182 Reviewed-by: Andrew McRae <amcrae@google.com> (cherry picked from commit bb144c51ff198ea1907b65068e33dd4f90c6aa7c) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3347357
* driver/led: add mp3385 low level driverZick Wei2021-12-214-0/+169
| | | | | | | | | | | | | | Add led driver ic mp3385 low level driver. BUG=b:208722790 BRANCH=none TEST=make buildall Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: If6dc272f2420fd7c0bfcd98274a1dcdb35c45748 (cherry picked from commit 1e40ebebf5de09c119812521b1d10f7c42241f51) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3347356 Reviewed-by: Andrew McRae <amcrae@google.com>
* dooly: change EC_PCH_RTCRST default settingZick Wei2021-12-211-1/+1
| | | | | | | | | | | | | | | | | Dooly set EC_PCH_RTCRST as ODR originally which will not trigger RTCRST signal when device not power on, change setting to push-pull to ensure RTC could be trigger. BUG=b:210562965 BRANCH=puff TEST=make BOARD=dooly Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I13b187bf2709863cf8475c8eab18afd09651c638 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3337961 Reviewed-by: Peter Marheine <pmarheine@chromium.org> (cherry picked from commit 299ce6b412b3b59738ed2428a725111a319269d5) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3350265
* cbi: add Second Source Factory Cache (SSFC) CBI fieldMarco Chen2021-12-136-2/+226
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SSFC field will be leveraged to record what second source is used in the DUT by probing components in the factory or RMA. Firmware code should refer to this field to judge what driver should be configured for a specific component. For example, the board code can arrange what sensor driver should be set into motion_sensors array if there are multiple sources of base or lid sensor. As the definition of FW_CONFIG, it describe which "features" the firmware code should enable or disable. For example, whether lid / base sensors should be enabled or not but not care about what second source is in this DUT. BRANCH=none BUG=b:163285687 TEST=call `cbi-util` to create the cbi image with SSFC and show created content. TEST=`make buildall -j` TEST=`make runhosttests -j` Change-Id: Icb4aa00ae47ab025198e7fd5edd6aab96a4bf53e Signed-off-by: Marco Chen <marcochen@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2344268 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: Jett Rink <jettrink@chromium.org> (cherry picked from commit 0212d4a3ce01452ddaba46f076f90e9a5e90e589) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3322221 Reviewed-by: Andrew McRae <amcrae@google.com> Tested-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Commit-Queue: Zick Wei <zick.wei@quanta.corp-partner.google.com>
* dooly: fix incorrect I2C data pin mappingsPeter Marheine2021-12-071-7/+49
| | | | | | | | | | | | | | | | | | | | | The data lines defined for the I2C buses associated with USB-C port 1 seem to have been copied from port 0 and while the clock line pins were updated, the data lines were not. This change corrects the data lines to refer to the correct pins. BUG=b:208485991 TEST=builds BRANCH=none Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: Ic093e9a4c305cef5e8b5661e8443adf90d1faa7b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3306767 Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Andrew McRae <amcrae@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3312812 Tested-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Commit-Queue: Andrew McRae <amcrae@google.com>
* Scout: Add board_led_auto_controlSue Chen2021-11-301-0/+10
| | | | | | | | | | | | | | | | | | | | | | | Check power state to change led status while receive the auto contorl command. BUG=b:198405130 BRANCH=puff TEST="ectool led power auto" can show correct led behavior immediately. Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I84c37cf7efd69c3442bd9733ad3813edddb0d1aa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3289575 Reviewed-by: Joe Tessler <jrt@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Joe Tessler <jrt@chromium.org> (cherry picked from commit cb2b8bc5a8806ff452e38d2275a55e8d4246d301) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3309107 Tested-by: Joe Tessler <jrt@chromium.org> Auto-Submit: Joe Tessler <jrt@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
* led_common: Add board_led_auto_controlSue Chen2021-11-302-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | Some projects have only power led won't change the led state immediately as the auto command is called for they only check the led state while the power state is changed. Add board_led_auto_control to let them check led state while receive the auto control command. BUG=b:198405130 BRANCH=none TEST=make buildall Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I8befb1b3044b6ee788cc36b21f682a3450f31185 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3288539 Reviewed-by: Joe Tessler <jrt@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Joe Tessler <jrt@chromium.org> (cherry picked from commit bccca05bf8101e6c11443d9ff085c53f95c50a1d) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3309106 Tested-by: Joe Tessler <jrt@chromium.org> Auto-Submit: Joe Tessler <jrt@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
* Scout: Add EN_LOAD_SWITCH in S0 railSue Chen2021-11-242-2/+4
| | | | | | | | | | | | | | | | | | | Clear ADC alternate pin GPIO42 (ADC3). Set EN_LOAD_SWITCH (GPIO42) high in S0, set it low when leave S0. BUG=b:204384355 BRANCH=puff TEST=EN_LOAD_SWITCH status is correct in every state. Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I5c4414ceaff97cdd3f5ddf14fd578cac66fae192 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3261188 Reviewed-by: Joe Tessler <jrt@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> (cherry picked from commit 9548d4102490b0a80d597499b7f4f3c2f4a3577d) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3299812 Commit-Queue: Joe Tessler <jrt@chromium.org>
* moonbuggy: modify LED pwm output typeBen Chen2021-11-033-21/+23
| | | | | | | | | | | | | | | | | | | | | | | Modify moonbuggy LED colors to red and blue. Also set the PWM configuration to active low. BUG=b:204504054 BRANCH=cros/main TEST=factory software PE test is PASS Change-Id: I9e79b007a8ab376b290ec441ffd3bb33338145e8 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3255121 Reviewed-by: Joe Tessler <jrt@chromium.org> Reviewed-by: Matthew Ziegelbaum <ziegs@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Joe Tessler <jrt@chromium.org> (cherry picked from commit fd1ac67b8cbaf12b245c4eb0e9544705cb5d3a65) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3260185 Tested-by: Joe Tessler <jrt@chromium.org> Auto-Submit: Joe Tessler <jrt@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
* Scout: disable ALS interrupt on known-bad hardwareJoe Tessler2021-10-272-7/+35
| | | | | | | | | | | | | | | | | | Prototype, Pre-EVT, and EVT board versions incorrectly use a 1.8V interrupt line, which sends a constant interrupt signal (active low) and eventually triggers a watchdog reset. This change ensures the interrupt remains disables for those known-bad board revision. BUG=b:203224828 TEST=Flash on EVT hardware; confirm no boot loop BRANCH=puff Signed-off-by: Joe Tessler <jrt@chromium.org> Change-Id: Ib959c197219b87024ef8fe2e01350b155ab95f44 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3245321 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* Scout: Change the setting of the GPIOs connected to ALSSue Chen2021-10-271-13/+13
| | | | | | | | | | | | | | | | | | | SCL/DAT change to 1.8V EC_RGB_INT_L change to 3.3V BUG=b:203224828 BRANCH=puff TEST="watch -n 1 ectool motionsense" can read als data Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3236387 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Joe Tessler <jrt@chromium.org> Change-Id: Iaf0d439d572f16d242123ca73883f417284db4b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3245320 Tested-by: Joe Tessler <jrt@chromium.org> Auto-Submit: Joe Tessler <jrt@chromium.org> Commit-Queue: Joe Tessler <jrt@chromium.org>
* Reland "Scout: Add light sensor ALS TCS3400"Joe Tessler2021-10-274-4/+135
| | | | | | | | | | | | | | | It was a hardware problem! BUG=b:203224828 TEST=Flash on modified HW BRANCH=puff This reverts commit f50ba38ce9a0e2c58a631003abdaff18f561e7b3. Signed-off-by: Joe Tessler <jrt@chromium.org> Change-Id: I5304ceff565a7a349d29bedef0c88ffeeaa78941 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3245319 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* Revert "Scout: Add light sensor ALS TCS3400"Matthew Ziegelbaum2021-10-154-135/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d72a1796e9b1ba8c722d2d323bf2544b8151d610. Reason for revert: EC crashes if you actually connect the ALS board to the mainboard. Original change's description: > Scout: Add light sensor ALS TCS3400 > > Enable interrupt pin EC_RGB_INT_L and motion_sense_task to > read light sensor als_tcs3400 data. > > BUG=b:187667126 > BRANCH=puff > TEST="ectool motionsense" can read data from tcs3400. > > Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> > Change-Id: I498c58b2c3309c66dfa9c8bc76bb4b7da1179a3b > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3045025 > Tested-by: Joe Tessler <jrt@chromium.org> > Reviewed-by: Joe Tessler <jrt@chromium.org> > Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> > Commit-Queue: Joe Tessler <jrt@chromium.org> > (cherry picked from commit 425146285cd32817f3db6b58a649067173e90aee) > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3219977 Bug: b:187667126 Change-Id: I9506c2874fcc30c80211504a6e6336cc0dd3f590 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3227026 Auto-Submit: Matthew Ziegelbaum <ziegs@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Joe Tessler <jrt@chromium.org>
* Scout: Add light sensor ALS TCS3400Sue Chen2021-10-134-4/+135
| | | | | | | | | | | | | | | | | | | Enable interrupt pin EC_RGB_INT_L and motion_sense_task to read light sensor als_tcs3400 data. BUG=b:187667126 BRANCH=puff TEST="ectool motionsense" can read data from tcs3400. Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I498c58b2c3309c66dfa9c8bc76bb4b7da1179a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3045025 Tested-by: Joe Tessler <jrt@chromium.org> Reviewed-by: Joe Tessler <jrt@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Joe Tessler <jrt@chromium.org> (cherry picked from commit 425146285cd32817f3db6b58a649067173e90aee) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3219977
* dooly: update setting to prevent power leakageZick Wei2021-10-082-2/+18
| | | | | | | | | | | | | | | | | | We found a power leakage in G3 caused by EC_EDID_WP_DISABLE_L, this patch updates gpio status to prevent power leakage. BUG=b:200710471, b:202309235 BRANCH=puff TEST=verify EC_EDID_WP_DISABLE_L status in G3 and S0. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Ic1a01306a6ee43360dbd5041a9ead95802efae58 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3207766 Reviewed-by: Andrew McRae <amcrae@google.com> Reviewed-by: Devin Lu <Devin.Lu@quantatw.com> Commit-Queue: Andrew McRae <amcrae@google.com> (cherry picked from commit 2259b3526def9f0a0d63e5f6d8d1a29b9eb65774) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3211168
* Scout: Update thermal table and add the 2nd temp sensorSue Chen2021-09-133-6/+22
| | | | | | | | | | | | | | | | | | Enable ADC1 to read TEMP_SENSOR_2 and update thermal table for theset 2 temp sensors. BUG=b:195602767 BRANCH=none TEST=none Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I626aab0aabf1f094b97bd72f93afa783553c1d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3038010 Reviewed-by: Jeff Chase <jnchase@google.com> (cherry picked from commit 88128f6080ed52dc1855313fa38c7318cc7f2730) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3143409 Commit-Queue: Jeff Chase <jnchase@google.com> Reviewed-by: Joe Tessler <jrt@chromium.org>
* Scout: LED PWM channels' IO type change to push-pullSue Chen2021-09-131-4/+2
| | | | | | | | | | | | | | Remove open-drain flags in led pwm ch.0 and ch.2 BUG=b/199263665 BRANCH=puff TEST=none Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: Iba5c9832eaf5e216888d5be3c39cf828a8db92a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3135515 Commit-Queue: Jeff Chase <jnchase@google.com> Reviewed-by: Joe Tessler <jrt@chromium.org>
* Clear OWNERS for factory/firmware branchBrian Norris2021-09-107-21/+0
| | | | | | | | | | | | BUG=none TEST=none Change-Id: I0f03f432ada1064ffba9595be78ca7ab4d25ecd1 Signed-off-by: Brian Norris <briannorris@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3155226 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Owners-Override: Jora Jacobi <jora@google.com> Tested-by: Jack Rosenthal <jrosenth@chromium.org>
* Moonbuggy: Update thermal tableSue Chen2021-09-091-5/+5
| | | | | | | | | | | | | | BUG=b:188596619 BRANCH=puff TEST=none Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I79f79ef06c98dd3e83ba17b65aaf3ce1bc6de071 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3152097 Tested-by: Joe Tessler <jrt@chromium.org> Auto-Submit: Joe Tessler <jrt@chromium.org> Reviewed-by: Jeff Chase <jnchase@google.com> Commit-Queue: Jeff Chase <jnchase@google.com>
* Scout: Fix LED behavior at initSue Chen2021-09-081-0/+7
| | | | | | | | | | | | | | | Check power state to change LED state while initialize the LEDs. BUG=none BRANCH=puff TEST=Check the LED behavior is correct. Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I1da47c1763c7ee928cf23df3358ccfc9b3a3d2c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3135514 Reviewed-by: Jeff Chase <jnchase@google.com> Reviewed-by: Joe Tessler <jrt@chromium.org> Commit-Queue: Joe Tessler <jrt@chromium.org>
* moonbuggy: copy genesis firmwareRehan Ghori2021-08-207-0/+1453
| | | | | | | | | | | | | | | | Starting point for moonbuggy firmware which is a fork of genesis firmware. BRANCH=none BUG=b:191356135 TEST=none Change-Id: I3d35cb781be9fdeb2534e205e3eb753090534dcd Signed-off-by: Rehan Ghori <rehang@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3093205 Reviewed-by: Joe Tessler <jrt@chromium.org> Tested-by: Rehan Ghori <rehang@chromium.org> Auto-Submit: Rehan Ghori <rehang@chromium.org> Commit-Queue: Rehan Ghori <rehang@chromium.org>
* dooly: refactor tcs3400_translate_to_xyz()Nikolai Artemiev2021-08-041-57/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | Refactor tcs3400_translate_to_xyz(): simplify calculations, reduce code duplication, avoid integer overflow, and guard against division by zero. Previously there were several places where integer values could overflow, such as converting 16-bit unsigned integers to fp_t values and multiplications with results exceeding the range of fp_t. In practice operations would overflow when holding a phone flashlight in front of the light sensor. BUG=b:179960346 BRANCH=none TEST=Flashed EC and tested sensor with a phone flashlight. Logging output values from old/new implementations showed no changes, except when the old implementation overflowed. Signed-off-by: Nikolai Artemiev <nartemiev@google.com> Change-Id: I52c37414b5205beaefa2111b1737b0eb22b7235a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3007377 Reviewed-by: Gwendal Grignou <gwendal@chromium.org> Commit-Queue: Gwendal Grignou <gwendal@chromium.org> (cherry picked from commit 9e38a616f13b99f70d042a8c569f77c58d8ac5ef) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3066829 Commit-Queue: Zick Wei <zick.wei@quanta.corp-partner.google.com>
* genesis: update usb-a gpios, remove dead codeJeff Chase2021-07-233-73/+19
| | | | | | | | | | | | | | | | | | | | Genesis only has three USB-A ports so update GPIOs and power handling. Also remove unused thermal table. BRANCH=puff BUG=b:192008266 TEST=boot; charge phone on each USB port, monitor GPIOs Change-Id: Ie3e5991f41caffa0b0a55adfd293e03befa80ce5 Signed-off-by: Jeff Chase <jnchase@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3045536 Reviewed-by: Joe Tessler <jrt@chromium.org> Commit-Queue: Joe Tessler <jrt@chromium.org> (cherry picked from commit b00e78a45275dc44245ebf8c91b8209388004d8b) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3047384 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
* Genesis: Fix LED behavior at initSue Chen2021-07-201-0/+7
| | | | | | | | | | | | | | | | | | | | Check power state to change LED state while initialize the LEDs. BUG=b:188740216 BRANCH=puff TEST=Check the LED behavior is correct. Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: Ibe50f4c7835821dd24872f5ab8ec3a882251e9e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2905673 Reviewed-by: Joe Tessler <jrt@chromium.org> Commit-Queue: Joe Tessler <jrt@chromium.org> (cherry picked from commit c53a15ef71b1a69ef0feb82479f49882a6894b1a) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3041176 Tested-by: Joe Tessler <jrt@chromium.org> Auto-Submit: Joe Tessler <jrt@chromium.org> Reviewed-by: Jeff Chase <jnchase@google.com> Commit-Queue: Jeff Chase <jnchase@google.com>
* Genesis: LED PWM channels' IO type change to push-pullSue Chen2021-07-201-4/+2
| | | | | | | | | | | | | | | | | | | | Remove open-drain flags in led pwm ch.0 and ch.2 BUG=b:188740216 BRANCH=puff TEST=none Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I6bd0df05f683fe841f1cb96b8a46793d93ec57f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2905159 Reviewed-by: Joe Tessler <jrt@chromium.org> Commit-Queue: Joe Tessler <jrt@chromium.org> (cherry picked from commit 1dfa395b6617be354a2a2161758bcf20ff87033a) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3041175 Tested-by: Joe Tessler <jrt@chromium.org> Auto-Submit: Joe Tessler <jrt@chromium.org> Reviewed-by: Jeff Chase <jnchase@google.com> Commit-Queue: Jeff Chase <jnchase@google.com>
* scout: merge bringup changesJeff Chase2021-06-295-288/+35
| | | | | | | | | | | | | | | | | - Update GPIOs - Toggle 12V power rails on S0 BRANCH=none BUG=b:187078663 TEST=boot scout Signed-off-by: Jeff Chase <jnchase@google.com> Change-Id: Iac2525df80880d5d2053993dccb982da011c0161 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2991899 Reviewed-by: Joe Tessler <jrt@chromium.org> Commit-Queue: Joe Tessler <jrt@chromium.org> (cherry picked from commit d0d08e1f15c5396709d709718a0a5dfc168c7063) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2993472
* scout: copy genesis EC firmwareJeff Chase2021-06-297-0/+1502
| | | | | | | | | | | | BRANCH=firmware-puff-13324.B BUG=b:187081076 TEST=boot scout Signed-off-by: Jeff Chase <jnchase@google.com> Change-Id: I269d51dc364d43b578f013929db629c43cbd31cb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2993471 Reviewed-by: Joe Tessler <jrt@chromium.org> Commit-Queue: Joe Tessler <jrt@chromium.org>
* Genesis: Update thermal tableDavid Huang2021-06-241-8/+8
| | | | | | | | | | | | | | | | Update new thermal table BUG=b:181627614 BRANCH=master TEST=Thermal team verified thermal policy is expected. Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com> Change-Id: Id7be64d22a3fce230952ec6a68094c08d245c6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2985259 Tested-by: Joe Tessler <jrt@chromium.org> Auto-Submit: Joe Tessler <jrt@chromium.org> Reviewed-by: Jeff Chase <jnchase@google.com> Commit-Queue: Jeff Chase <jnchase@google.com>
* dooly: fix lux overflowZick Wei2021-05-221-19/+25
| | | | | | | | | | | | | | | | | | | | | | We saw under some low light environment lux will switch between 0 to extreme high value, wich will cause display backlight flash, this CL fix this issue due there is overflow in calculation. BUG=b:188205311 BRANCH=puff TEST=make sure panel backlight not flash in low light environment. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I47680e0c84d84f183fd5c2b973429e9964539049 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2909095 Tested-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Tested-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-by: Gwendal Grignou <gwendal@chromium.org> Commit-Queue: Gwendal Grignou <gwendal@chromium.org> (cherry picked from commit d4ee99609cd07a7e5c08669036d19dd740788796) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2912404
* common: motionsense fifo: Reset the initialized bits after commitYuval Peress2021-05-052-2/+13
| | | | | | | | | | | | | | | | | | | | | | | | | Previously once we had one sample from a sensor, we considered the fifo initialized. Meaning we would use our computed next timestamp to spread the timestamps. This was causing issues with some devices that ended up causing the timestamps to run ahead. Reset next_timestamp_initialized back to 0 after each commit. This will allow repeated timestamps but only if a driver stages/commits the same timestamp twice. Staging the same timestamp with only a single commit will still work as before (which is the expected path). BRANCH=none BUG=b:168335284 TEST=make run-motion_sense_fifo Signed-off-by: Yuval Peress <peress@chromium.org> Change-Id: Ib7c566f69d7c1e4e898050b67105555dd05376e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2871055 Reviewed-by: Gwendal Grignou <gwendal@chromium.org> (cherry picked from commit bc9660a4b3e8bab1d729cb42e0f27ac968a4f457) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2875117 Tested-by: Gwendal Grignou <gwendal@chromium.org> Commit-Queue: Gwendal Grignou <gwendal@chromium.org>
* dooly: update ALS lux equationZick Wei2021-04-131-39/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous equation in CL:2771482, would cause lux = 0 on some ALS board in specific ambient light , we worked with vendor and update the lux equation: Lux = LuxScalar * (DGFn * ((C * Ccoefn) + (R * Rcoefn) + (G * Gcoefn) + (B * Bcoefn)) / (Atime*Again)) Lux = MAX(0, Lux) If (G+B)/C < 0.692 n=1 If (G+B)/C >= 0.692 and < 1.012 n=2 else n=3 LuxScalar = 1.00 Coeffs n=1(Lo) n=2(Med) n=3(Hi) Ccoef 0.009 0.202 -0.661 Rcoef 0.056 - 1.1 1.334 GCoef 2.735 8.692 1.095 BCoef -1.903 -7.068 -1.821 DGF 799.797 801.347 795.574 BUG=b:184238881 BRANCH=puff TEST=verify equation works as intended. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Ic9e41579c37544496f54a4faeb1a0d0aeea8f7c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2822388 Reviewed-by: Andrew McRae <amcrae@chromium.org> Commit-Queue: Andrew McRae <amcrae@chromium.org>
* dooly: extend prochot latch timeZick Wei2021-04-111-1/+15
| | | | | | | | | | | | | | | This patch extend CPU prochot latch time to 60ms, when OCP protect triggered to pass safety requirement. BUG=b:184812462 BRANCH=puff TEST=verify CPU prochot can latch 60ms when OCP triggered. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I41721670d6fac9266bad546fc86b0c1e0f46b183 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2813893 Reviewed-by: Andrew McRae <amcrae@chromium.org> Commit-Queue: Andrew McRae <amcrae@chromium.org>
View Lorry Controller Status