| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Smaller project specific devicetree changes are merged into the overlay
file. Some shared devicetree nodes have been merged into program
directory.
BUG=b:254097911
TEST=Ran zmake compare-builds
BRANCH=none
Change-Id: Ie17e2854aaaffd29712054e41e3299d9328ce2cc
Signed-off-by: Jason Yuan <jasonyuan@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4072139
Tested-by: zhi cheng yuan <jasonyuan@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Commit-Queue: zhi cheng yuan <jasonyuan@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As per schematic of Kingler, the KSO13 and KSO14 are functionally
KSO default pins just like KSO12. To use them as similar to
other KSO pins, they needs to be configured similar to KSO12.
BUG=b:241734677
BRANCH=none
TEST=zmake build kingler --clobber
Change-Id: Ifcff2a86197da00b930f01e754cdc52823912002
Signed-off-by: Madhurima Paruchuri <mparuchuri@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4053371
Reviewed-by: Eric Yilun Lin <yllin@google.com>
Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Renamed proj.conf to program.conf and project.conf based
on level the file is situated. Added project.overlay to
projects. Converted device tree file extensions from .dts
to .dtsi. Moved project specific files to it's dedicated
folder. Updated the way device tree config is passed to
register method in BUILD.py along with some adhoc refactoring.
BRANCH=none
BUG=b:260323505
TEST=zmake build rex --clobber
Change-Id: Idd6ebfa5873c9a650d9dc86d428c8e139508d74b
Signed-off-by: Madhurima Paruchuri <mparuchuri@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4053367
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fill 'suite' of variant of test results
Add 'builder_name' as part of rdb call
BUG=None
BRANCH=NONE
TEST=./twister -T zephyr/test
led get-build 8796116379492448401 | led edit-recipe-bundle | led launch
https://ci.chromium.org/ui/inv/task-chromeos-swarming.appspot.com-5ee286eb4540b911/test-results
Signed-off-by: Al Semjonovs <asemjonovs@google.com>
Change-Id: Ie949994936e7d9a656fe5629cd3ac3766f5d103f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4043343
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Zhihui Xie <zhihuixie@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To avoid duplication, and follow the new project organization rule.
BUG=b:254097516
TEST=zmake compare-builds tentacruel magikarp krabby
TEST=./twister -T ./zephyr/test
BRANCH=none
Change-Id: I28bb757fddfcb9655e49a13b64408a88e29b2ba9
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4075455
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Tested-by: Eric Yilun Lin <yllin@google.com>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Auto-Submit: Eric Yilun Lin <yllin@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove all the bring-up features.
BUG=b:261362766
TEST=zmake build tentacruel --clobber
BRANCH=firmware-corsola-15194.B
Change-Id: Iec0deae9eb74bc98b203ee334ed7382c1940b774
Signed-off-by: jeffrey <jeffrey_lin@pegatron.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4076008
Reviewed-by: Eric Yilun Lin <yllin@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently sub board work when cbi fw_config exist,
in some condition fw_config may not set which cause
sub board not functional.
yaviks only has one sub board,
this CL ignore fw_config, let sub board always functional.
BUG=b:260780060
BRANCH=none
TEST=make sure USBC1 port work without fw_config.
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: I3f33829525344d7867031e68a24d4e8b065c8ba2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4011005
Tested-by: Andrew McRae <amcrae@google.com>
Reviewed-by: Andrew McRae <amcrae@google.com>
Code-Coverage: Andrew McRae <amcrae@google.com>
Commit-Queue: Andrew McRae <amcrae@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Follow up CL:4059932, there are some code related
to USBC port number, move those code to sub_board.c.
BUG=b:260780060
BRANCH=none
TEST=zmake build yaviks
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: If2daa30df5c3bbea6804e9c3cc5c0dbc8421d74e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4060785
Reviewed-by: Andrew McRae <amcrae@google.com>
Code-Coverage: Andrew McRae <amcrae@google.com>
Commit-Queue: Andrew McRae <amcrae@google.com>
Tested-by: Andrew McRae <amcrae@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In some situations, the S0S0ix power state is entered multiple times
ahead of a resume to the point that the kernel sends a host event
indicating the resume, where the SCI and SMI hostevent masks are
restored. When the masks are cleared more than once, the previous
backups are overwritten by the already-cleared values, and the original
masks are lost.
BUG=b:261318939
TEST=hostevent SCI mask is restored after S0ix with a touchpad click
while the lid is closed
BRANCH=nissa
Change-Id: I8e93ed79a745f7f4c525fb7a8a419198d086448f
Signed-off-by: Sam McNally <sammc@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4075654
Reviewed-by: Andrew McRae <amcrae@google.com>
Code-Coverage: Andrew McRae <amcrae@google.com>
Commit-Queue: Andrew McRae <amcrae@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create the initial EC image for the gladios variant by copying
the brask reference board EC files into a new directory named for
the variant.
(Auto-Generated by create_initial_ec_image.sh version 1.5.0).
BUG=b:239513596
BRANCH=None
TEST=make BOARD=gladios
Signed-off-by: Tommy Chung <tommy.chung@quanta.corp-partner.google.com>
Change-Id: I6af21a20a3044a371882e0bc644e6aea86558bdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4022082
Reviewed-by: Ricky Chang <rickytlchang@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds test coverage for the power-on-blocked case added in
commit 43a7c919bbe845c5cb45e5eb3535ae43d1f49dc5.
BUG=b:234049176,b:242627237,b:260909787
TEST=./twister -T zephyr/test
BRANCH=nissa
Change-Id: I62825bd7a43fcc914fa8c2236ed2bd73851e1aaa
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4074989
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Andrew McRae <amcrae@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The interrupt should be triggered with GPIO_INT_EDGE_FALLING only.
BUG=none
TEST=boot tentacruel
BRANCH=none
Change-Id: I039b6bac228a017434b918169562ee349c972c16
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4074804
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Tested-by: Eric Yilun Lin <yllin@google.com>
Commit-Queue: Eric Yilun Lin <yllin@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To avoid duplication, and follow the new project organization rule.
BUG=b:254097516
TEST=tentacruel boots
BRANCH=none
Change-Id: Iea4a7b3ad0d5c5f5a91701de31eccd77be234fec
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4075845
Tested-by: Eric Yilun Lin <yllin@google.com>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit c8325ba18b9f4d5b1f3f3bc739e83d8f591308cf.
Reason for revert: broke at least 9 cq builds (https://ci.chromium.org/ui/p/chromeos/builders/cq/cq-orchestrator/b8795833246203447793/overview)
Original change's description:
> ec: Support logging system boot time info
>
> This CL add support logging system boot time and hostcommand to get
> boot time info.
> EC logs elapsed time (in micro second) info since boot for different
> signal events,that can be used to calculate system boot time in cold
> boot and warm boot scenarios.
>
> Below are the events when EC logs time info
>
> ARAIL EC turns on A-RAIL
> RSMRST EC releases RSMRST#
> ESPIRST ESPIRST received
> PLTRST_LOW PLTRST# asserted
> PLTRST_HIGH PLTRST# deasserted
> EC_CUR_TIME EC current time
> cnt increments on every warm reboot and reset to 0 on
> cold reboot
>
> BUG=b:249163956
> BRANCH=none
> TEST='ectool boottime' AP console command is used to fetch data
> 'reboot' on AP console to trigger warm reboot
> 'apshutdown' on EC console to trigger cold reboot
>
> Signed-off-by: Rajesh Kumar <rajesh3.kumar@intel.com>
> Change-Id: I15fedbde252e0452270ef0e3fd4391bf624169f1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3794612
> Reviewed-by: Boris Mittelberg <bmbm@google.com>
> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Bug: b:249163956
Change-Id: Ie83026c4a3a38c3dd24522901233f06e03430a54
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4077335
Reviewed-by: Jonathon Murphy <jpmurphy@google.com>
Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org>
Tested-by: Piotr Pawliczek <pawliczek@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL add support logging system boot time and hostcommand to get
boot time info.
EC logs elapsed time (in micro second) info since boot for different
signal events,that can be used to calculate system boot time in cold
boot and warm boot scenarios.
Below are the events when EC logs time info
ARAIL EC turns on A-RAIL
RSMRST EC releases RSMRST#
ESPIRST ESPIRST received
PLTRST_LOW PLTRST# asserted
PLTRST_HIGH PLTRST# deasserted
EC_CUR_TIME EC current time
cnt increments on every warm reboot and reset to 0 on
cold reboot
BUG=b:249163956
BRANCH=none
TEST='ectool boottime' AP console command is used to fetch data
'reboot' on AP console to trigger warm reboot
'apshutdown' on EC console to trigger cold reboot
Signed-off-by: Rajesh Kumar <rajesh3.kumar@intel.com>
Change-Id: I15fedbde252e0452270ef0e3fd4391bf624169f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3794612
Reviewed-by: Boris Mittelberg <bmbm@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove toolchain workarounds for C++ header files
location and GNU_SOURCE as they are fixed in clang.
BRANCH=none
BUG=b:254916723, b:234507656, b:241489000
TEST=./util/compare_build.sh -b all -j 120
Change-Id: I8e1cd634c1085803fddcc2dec8f5667453a5e0e6
Signed-off-by: Manoj Gupta <manojgupta@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4074063
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously #line was added to config to fix off-by-one errors in
the coverage reports. This came up again, and this time adding the #line
directive to common.h fixed it.
I hope I can find the root cause eventually to stop playing wack-a-mole.
BRANCH=None
BUG=b:260765255,b:258344465
TEST=Ran build_firmware.py with coverage
Change-Id: Ic32bbb34db441ce4fa6c52370ea44eb925cd2d1c
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4076150
Commit-Queue: Tristan Honscheid <honscheid@google.com>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Tristan Honscheid <honscheid@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add GPIO_VOLTAGE_1P8 and GPIO_SEL_1P8V used in common code.
In MEC1727, GPIO_VOLTAGE_1P8 feature is not supported in GPIO control
register, GPIO driver will skip this bit configuration, but MEC1727
supports a group of GPIOs with 1.8V power rail, 1.8V design will be
considered and supported in board circuit design state.
BUG=none
BRANCH=main
TEST=zmake build -a
Change-Id: Iba27772048c1d88781baeb2b876ab772aa4bebf8
Signed-off-by: martin yan <martin.yan@microchip.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4067373
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Reviewed-by: Tristan Honscheid <honscheid@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tests comparing complex types must define
TEST_OPERATOR_INHIBIT_PRINT_EVAL prior to any standard comparison.
The format string may be populated with any string. For example:
TEST_EQ(foo, bar, "");
BUG=b:226561385
BRANCH=none
TEST=make BOARD=bloonchipper tests
TEST=make runhosttest
Signed-off-by: Bobby Casey <bobbycasey@google.com>
Change-Id: I82f7457b95939870980bc082593e42581585eec3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3993972
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Commit-Queue: Andrea Grandi <agrandi@google.com>
Reviewed-by: Andrea Grandi <agrandi@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Resolve power leakage following nivviks.
CL : 3788018
BUG=b:260679055
TEST=zmake build xivu
BRANCH=none
Change-Id: I67b80d60f2f22ffdb4d7e623deafd1b803652665
Signed-off-by: FelixTW_Chang <felixtw_chang@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4074754
Reviewed-by: Andrew McRae <amcrae@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: SamSP Liu <samsp_liu2@compal.corp-partner.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add below 3 batteries:
lgc,ap19b8k
panasonic,ap19b5k
smp,ap18c7k
BRANCH=corsola
BUG=b:259913834
TEST=zmake build voltorb
Change-Id: Ib8c43dc068900d5774ff964abb548ceba7af109f
Signed-off-by: Siyu Qin <qinsiyu@huaqin.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4066247
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It tests when the selected PDO is aligned to the
system power and the efficient PDO.
1. renames dps.c to dps_config.c
2. adds dps_selection.c
BUG=b:257200275 b:243840939
TEST=./twister -T test
BRANCH=none
Change-Id: Ie4f5e7171a922e63cbb276177a98024e11351245
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4060443
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Tested-by: Eric Yilun Lin <yllin@google.com>
Commit-Queue: Eric Yilun Lin <yllin@google.com>
Auto-Submit: Eric Yilun Lin <yllin@google.com>
Reviewed-by: Sung-Chi Li <lschyi@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Import below 3 batteries:
lgc,ap19b8k
panasonic,ap19b5k
smp,ap18c7k
BRANCH=corsola
BUG=b:259913834
TEST=no errors observed, battery status is correct
Change-Id: I9acc4993c57d963e9f6f9f1d866980371f54613c
Signed-off-by: Siyu Qin <qinsiyu@huaqin.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4058886
Reviewed-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents the system from booting the AP if there's not enough power
according to configuration. Although there is similar logic in the power
button task, typical AP configuration is to boot directly after entry to
S5, meaning both are needed:
* From G3, this new path gates whether the system boots (matching
similar logic in the legacy power sequencing code) by preventing
transition to S5.
* From S5 (as in after shutdown and not yet having gone to G3), the
power button gates booting.
BUG=b:234049176,b:242627237,b:260909787
TEST=On craask, modify MIN_POWER settings to prevent hibernate during
testing and fake low battery; verify that an instrumented version
of charge_prevent_power_on indicates that the battery is too low
to boot, although the "factory override" still allows this DUT to
boot (because hardware WP is off).
BRANCH=nissa
Change-Id: I9cce0817dec8ffb59c133dbe54e63037542e5e55
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4066722
Commit-Queue: Andrew McRae <amcrae@google.com>
Tested-by: Andrew McRae <amcrae@google.com>
Reviewed-by: Andrew McRae <amcrae@google.com>
Code-Coverage: Andrew McRae <amcrae@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CL:4054762 will cause USBC1 port malfunction when plug in adapter,
this CL read charger pmode during init
and use in pd_is_valid_input_voltage().
BUG=none
BRANCH=none
TEST=On yaviks, USBC1 charge normal with adapter.
LOW_COVERAGE_REASON=no emulator for SM5803 yet
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: I15308bc1101d4c0cff2558729e56324ec6108522
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4066726
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-by: Devin Lu <devin.lu@quantatw.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initialize PS8811 retimer for USB-A0 and USB-A1. Print an error if
retimer does not respond to i2c read.
BUG=b:237517617
BRANCH=None
TEST=PS8811 is detected on the console.
Change-Id: I7f7bf9f6cb030141bc5de6018353b8ffb6d11686
Signed-off-by: Raymond Chung <raymondchung@ami.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4060626
Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to get everything to run in parallel, just migrate most of the
test logic to a makefile, and call make from the python script.
When building locally, this saved 30% of the time, and got the same
coverage metrics, so I assume the same tests and builds were run.
BRANCH=None
BUG=None
TEST=Ran builder locally, compared metrics with prior commit.
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I7429c35e4a30ad05e092d5aa73d523f3c676e8e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4068492
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change request by power team.
AC PROCHOT 5A
DC PROCHOT 6.57A
BUG=b:260378925
BRANCH=none
TEST=Power team verified PROCHOT function as expected behavior.
Signed-off-by: matt_wang <matt_wang@compal.corp-partner.google.com>
Change-Id: I0eb712cc93c2cd9553b10f817a01a8ad9fc41466
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4059934
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch allow the Skyrim board's project if using the isl9238 charger
can change the charger prochot threshold.
BUG=b:260378925
BRANCH=none
TEST=zmake build skyrim success
LOW_COVERAGE_REASON=no unit test for skyrim board yet: b/247151116
Signed-off-by: Matt Wang <matt_wang@compal.corp-partner.google.com>
Change-Id: I69a786e934518eeab7ec1f940bf73d46f76dfd01
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4054910
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify ac prochot to use the common config
BUG=b:260378925
BRANCH=none
TEST=zmake build skyrim success
LOW_COVERAGE_REASON=no unit test for skyrim board yet: b/247151116
Signed-off-by: matt_wang <matt_wang@compal.corp-partner.google.com>
Change-Id: I214018136f02fb7b01dfd24ec13ec981dbad296f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4059909
Reviewed-by: Diana Z <dzigterman@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Code-Coverage: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FW_CONFIG field to defined for AUDIO CODEC.
0:ALC5682_VS
1:ALC5682_VD
BUG=b:255871229
BRANCH=none
TEST=zmake build xivu
Signed-off-by: ridden_liu <ridden_liu@compal.corp-partner.google.com>
Change-Id: If8029ca04c5308d62b9c12a79a0c0b37f65735af
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4068924
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-by: SamSP Liu <samsp_liu2@compal.corp-partner.google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Copy the zephyr include rules into .clang-format so that our pre-submit
scripts will force include files to be ordered by the rules that the
zephyr project uses.
BRANCH=None
BUG=b:247100970
TEST=CQ
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I22f6e4dfdabcf941d15d0da4bf3987e33577ff64
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3902441
Reviewed-by: Diana Z <dzigterman@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove CONFIG_PLATFORM_EC_BYPASS_CBI_EEPROM_WP_CHECK
Remove CONFIG_PLATFORM_EC_SYSTEM_UNLOCKED
BUG=b:244409551
BRANCH=none
TEST=zmake build pujjo
Change-Id: I2b051372766ad4eacdd5f4188d0642d43ca314ba
Signed-off-by: tony.tang <tony.tang@lcfc.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4066723
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Commit-Queue: Peter Marheine <pmarheine@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Andrew McRae <amcrae@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were some more files that snuck in unsorted.
BRANCH=None
BUG=b:247100970
TEST=zmake build -a
TEST=./twister --clobber -v -i
TEST=make -j72 buildall_only runtests
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I9a9cfecf292111543a197fd0e48651a652f42038
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4072136
Commit-Queue: Aaron Massey <aaronmassey@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Aaron Massey <aaronmassey@google.com>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove CONFIG_PLATFORM_EC_WATCHDOG. Use Zephyr's CONFIG_WATCHDOG option
instead.
BUG=b:217926701
BRANCH=none
TEST=./twister -T zephyr/test/
TEST=zmake compare-builds -a
TEST=emerge-drallion chromeos-ish && make BOARD=drallion_ish
LOW_COVERAGE_REASON=watchdog_init test not yet implemented
Signed-off-by: Mark Hasemeyer <markhas@google.com>
Cq-Depend: chromium:4067356
Change-Id: I2b7578f6918cb3b0c4317492662ba3fc949f43e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4064392
Reviewed-by: Keith Short <keithshort@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Aaron Massey <aaronmassey@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Verify that TCPM enables FRS signal reception when it establishes a PD
connection with a Sink that supports FRS in its Sink Capabilities.
BUG=b:260630630
TEST=twister -s zephyr/test/drivers/drivers.usbc_frs
BRANCH=none
Change-Id: I1ec44e93687e0e3ea4714ddf2ccb27f4ac39a550
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4063187
Reviewed-by: Yuval Peress <peress@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were some more files that snuck in unsorted.
BRANCH=None
BUG=b:247100970
TEST=zmake build -a
TEST=./twister --clobber -v -i
TEST=make -j72 buildall_only runtests
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I34d876c1fd4190cec4a2c84e89d7caca5d64de79
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4068490
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Tristan Honscheid <honscheid@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The HPD state is a field of the DP-Status VDO. The DP-Status VDO is
embedded in either the DP-Status VDM or the Attention VDM.
The DP-Status happens before the DP-Config. The pin assignment of the
PD partner hasn't been set up yet. Passing through the HPD to the DP
PHY is too early. Racing it may fail the link-training. Should wait
until the DP-Config is done.
BRANCH=None
BUG=b:247005613
LOW_COVERAGE_REASON=No existing test for the board-specific code
TEST=Connect the device through a Type-C dongle to a monitor and verify
the screen. Try the combinations:
* Plug C0 monitor -> plug C0 dongle -> screen on C0 monitor
* Plug C0 dongle -> plug C0 monitor -> screen on C0 monitor
-> unplug C0 monitor -> plug C0 monitor -> screen on C0 monitor
* Plug C0 dongle -> plug C0 monitor -> screen on C0 monitor
-> plug C1 dongle -> -> plug C1 monitor -> no screen on C1 monitor
-> unplug C0 monitor -> replug C1 monitor -> screen on C0 monitor
* Plug C0 dongle -> plug C1 dongle -> plug C1 monitor
-> screen on C1 monitor -> unplug C1 dongle -> plug C0 monitor
-> screen on C0 monitor
Change-Id: I9387568e2a36f3d44ba2efc78f9fcc2b64bd03fd
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4043350
Reviewed-by: Eric Yilun Lin <yllin@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The hardware block diagram is like:
AUX termination
|
+----+--- TCPC MUX --- PPC SW --- Type-C connector (port-0)
DP PHY -- DP MUX
+----+--- TCPC MUX --- PPC SW --- Type-C connector (port-1)
|
AUX termination
The current implementation muxes the path end-to-end on a HPD high
event.
The dependencies are:
* Chromebook muxing the AUX channel depends on a HPD high event,
* DP sink raising HPD depends on a cable connection detected (auto-
probe),
* Successful probe of a cable connection depends on AUX termination,
which cause a dead-lock.
This change breaks the dead-lock. During the DP-Config phase, when the
DP-Config VDM is acked, connect the PPC SW and TCPC MUX, but leave the
DP MUX disconnected. So the DP sink can detect the correct AUX
termination. The DP port selection mux is not enabled yet so no signal
passes through to the DP PHY.
As the TCPC MUX is enabled in the DP-Config phase, we can't use the TCPC
MUX status as the condition to check if the DP path is muxable. Change
it to the DP selection mux.
BRANCH=None
BUG=b:247005613
LOW_COVERAGE_REASON=No existing test for the board-specific code
TEST=Together with the next CL.
Connect the device through a Type-C dongle to a monitor and verify
the screen. Try the combinations:
* Plug C0 monitor -> plug C0 dongle -> screen on C0 monitor
* Plug C0 dongle -> plug C0 monitor -> screen on C0 monitor
-> unplug C0 monitor -> plug C0 monitor -> screen on C0 monitor
* Plug C0 dongle -> plug C0 monitor -> screen on C0 monitor
-> plug C1 dongle -> -> plug C1 monitor -> no screen on C1 monitor
-> unplug C0 monitor -> replug C1 monitor -> screen on C0 monitor
* Plug C0 dongle -> plug C1 dongle -> plug C1 monitor
-> screen on C1 monitor -> unplug C1 dongle -> plug C0 monitor
-> screen on C0 monitor
Change-Id: I5a5e08dc26ebaa22ff7a3cfc0828ed2e01df3995
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4039144
Reviewed-by: Eric Yilun Lin <yllin@google.com>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously #line was added to config_chip to fix off-by-one errors in
the coverage reports. This came up again, and this time adding the #line
directive to config.h fixed it. That seems like a better place anyway
since nearly every file includes it.
BRANCH=None
BUG=b:260765255
TEST=Ran build_firmware.py with coverage to verify 291 lines of
incorrectly marked lines of code removed.
Change-Id: I647887df1373708e7c2e70cce777de7f1458875d
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4071386
Commit-Queue: Yuval Peress <peress@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To use the twister wrapper in GNU make and have the jobserver get passed
down to twister, we need to keep the file descriptors open.
BRANCH=None
BUG=None
TEST=Wrote makefile and added +./twister to it.
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I900c509e3c3736f4cea8a30bb9975627071ed816
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4068491
Reviewed-by: Tristan Honscheid <honscheid@google.com>
Commit-Queue: Tristan Honscheid <honscheid@google.com>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To set the PROCHOT# assertion threshold for adapter overcurrent
and battery over discharging current conditions.
BUG=b:260378925
BRANCH=none
TEST=Winterhold verified PROCHOT function as expected behavior.
Signed-off-by: matt_wang <matt_wang@compal.corp-partner.google.com>
Change-Id: If3c63d277dbfe5aea065e7f5ca156082f9993243
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4063629
Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Zombie form factor is clamshell, modify the zombie dts files
and config for the sku.
BRANCH=none
BUG=b:260362050
TEST=$accelinfo
Motion sensors count = 0
Change-Id: I74e17642a7d8f1760595c04bed3355ca518fe713
Signed-off-by: Tang Qijun <qijun.tang@ecs.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4063091
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Reviewed-by: Aamir Bohra <aamirbohra@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Commit-Queue: Bob Moragues <moragues@chromium.org>
Commit-Queue: Aamir Bohra <aamirbohra@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The MediaTek SCP firmware code has long lived under a restricted private
sub-repository checked out under private-mt-scp/, however its revision
was never tracked in the version string.
Add support for it to getversion.sh. It now shows up as an additional
"private-mt-scp:vBLAH-HASH".
BRANCH=none
BUG=none
TEST=make BOARD=asurada_scp && strings build/cherry_scp/ec.obj | grep private-mt-scp:
TEST=make BOARD=cherry_scp && strings build/cherry_scp/ec.obj | grep private-mt-scp:
TEST=make BOARD=corsola_scp && strings build/cherry_scp/ec.obj | grep private-mt-scp:
TEST=make BOARD=kukui_scp && strings build/cherry_scp/ec.obj | grep private-mt-scp:
Change-Id: Id363f4c08f1c4a3d857eb8da19c472a88660dc24
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4060784
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Craask need to implement FW_KB_NUMERIC_PAD config in
bit 16 of cbi fw_config.Enable/Disable keypad control
by FW_KB_NUMERIC_PAD flag.
BUG=b:257387315,b:259498529
BRANCH=none
TEST=check keypad workable by FW_KB_NUMERIC_PAD flags.
Change-Id: I94b153d065db20e8619cd13f21877a11e76ea430
Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4059911
Tested-by: Andrew McRae <amcrae@google.com>
Reviewed-by: Andrew McRae <amcrae@google.com>
Code-Coverage: Andrew McRae <amcrae@google.com>
Commit-Queue: Andrew McRae <amcrae@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We will need the amount of noise for body detection.
The amount of noise in accelometer will depends on several thing, e.g.,
power mode
Add get_rms_noise() function to get the root mean square
of noise in lis2dw12.
LOW_COVERAGE_REASON=no unit test for body_detection yet: b/259754018
BRANCH=None
BUG=b:236668095
TEST=zmake build winterhold
Change-Id: Ic7e99902e010f6ec0441abff6bb3684a63cfd471
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4060290
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Tested-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sort all includes in board with the clang-format rules used by
the zephyr project.
BRANCH=None
BUG=b:247100970
TEST=zmake build -a
TEST=./twister --clobber -v -i
TEST=make -j72 buildall_only runtests
TEST=zmake compare-builds -a
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I6ad72b167cbb768a64c338fa633eb4bf5a401897
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4060360
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test the get_panic_data_write() implementation used in device builds
Also remove an unreachable `else` statement from the function (The jump
data version cannot be anything other than 1, 2, or 3 since we check
that a few lines above)
BRANCH=None
BUG=None
TEST=./twister
Signed-off-by: Tristan Honscheid <honscheid@google.com>
Change-Id: Ie83cf3c655662498ef6a487d51d39c65d790de2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4052122
Commit-Queue: Tristan Honscheid <honscheid@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Tested-by: Tristan Honscheid <honscheid@google.com>
Reviewed-by: Tomasz Michalec <tmichalec@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test various `crash` subcommands that cause different types of fatal
errors. Not all were possible to test due to limitations with running
these on a PC. Also had to make a tweak to the busy loops in the
watchdog and hang subcommands so that they don't interfere with the
simulated sys clock in native_posix. Add a public wrapper function for
calling the crash command outside of the shell interface so we don't
mess up its internal state when the command doesn't return.
BUG=None
BRANCH=None
TEST=./twister
Signed-off-by: Tristan Honscheid <honscheid@google.com>
Change-Id: I393e26441d44c0a5edaf1359413efe6280703add
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4053360
Reviewed-by: Keith Short <keithshort@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The version of get_panic_data_write() that currently gets compiled in is
controlled by an `#ifdef CONFIG_BOARD_NATIVE_POSIX` block, which means
that the actual implementation used in device builds (over 30 SLOCs) is
unreachable in testing, in favor of a stub that directly returns the
pdata_ptr pointer.
This CL removes the stub native posix version of the function and makes the
real version test_mockable. Then, all test binaries that were relying on
the removed stub definition are supplied with a mocked version of
get_panic_data_write() that behaves the same way the stub did by
returning pdata_ptr directly. This frees a new test binary to test the
actual implementation.
BRANCH=None
BUG=None
TEST=./twister
Signed-off-by: Tristan Honscheid <honscheid@google.com>
Change-Id: I8228acb0147b3b3843d302c272d8715d925fddd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4052121
Commit-Queue: Aaron Massey <aaronmassey@google.com>
Reviewed-by: Aaron Massey <aaronmassey@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Tested-by: Tristan Honscheid <honscheid@google.com>
Auto-Submit: Tristan Honscheid <honscheid@google.com>
|