summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Clear OWNERS for factory/firmware branchfirmware-swanky-5216.238.BBrian Norris2021-09-101-0/+1
| | | | | | | | | | | | BUG=none TEST=none Change-Id: I0f03f432ada1064ffba9595be78ca7ab4d25ecd1 Signed-off-by: Brian Norris <briannorris@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3155261 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Owners-Override: Jora Jacobi <jora@google.com> Tested-by: Jack Rosenthal <jrosenth@chromium.org>
* CHERRY-PICK: Swanky: Support force lid openAaron Weng2014-11-183-1/+56
| | | | | | | | | | | | | | | | | | | | Factory test process need lid switch no function or keep lid opened BUG=chrome-os-partner:33850 BRANCH=swanky TEST=Run command "ectool forcelidopen 1" and "reboot". Then lid close quickly, the system boot as lid opened. Deault value or run command "ectool forcelidopen 0" make the device normal. Change-Id: Ic6bc15f7b885844562ae181da94b2caf6fe51077 Origin-Change-Id: I94527b7ef7f9efe779c6b86f3eab651f99af6000 Signed-off-by: Aaron Weng <Aaron.Weng@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/220740 Reviewed-by: Mohammed Habibulla <moch@chromium.org> Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/230122 Commit-Queue: Aaron Weng <aaron.weng@quantatw.com> Tested-by: Aaron Weng <aaron.weng@quantatw.com>
* EC:KBC: Wait until LPC host senses the IRQ and gets the character.Kenji Chen2014-10-301-1/+6
| | | | | | | | | | | | | | | BRANCH=master BUG=chrome-os-partner:29139 TEST=Buiid an EC FW image and run on Rambi to test if key loss is improved and any side effect somes with this change. Need more test units to confirm this. Signed-off-by: Kenji Chen <kenji.chen@intel.com> Change-Id: I2399e33d2ca3defe8cd9b1f94ab0af1db7f84635 Reviewed-on: https://chromium-review.googlesource.com/225557 Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-by: Mohammed Habibulla <moch@chromium.org> (cherry picked from commit 8a1f1b045a2bffc0c3bf3941709acf4ba99d32e7) Reviewed-on: https://chromium-review.googlesource.com/226653
* Gnawty: Change battery LED to flash orange when battery lowJimmy Lin2014-07-102-4/+10
| | | | | | | | | | | | | | | | | | | | | | | | | BUG=chrome-os-partner:29937 BRANCH=gnawty TEST=manual Low Battery Case: To config Battery LED blinks orange during low Battery(=<13%), Check battery LED show amber directly when plugging in adpater. Critical Battery Case: To config Battery LED blinks orange during Critical Battery(=<7%), Check battery LED show amber directly when plugging in adpater. Battery full Case: To config Battery LED blinks full during Battery near full(=>95%), Check battery LED show blue directly when plugging in adpater. Change-Id: I6bcb205c48508b05f460d87511c85d3dec002dd5 Signed-off-by: Jimmy Lin <jimmy.Lin@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/207304 Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Queue: Dave Parker <dparker@chromium.org> Tested-by: Dave Parker <dparker@chromium.org>
* Turn battery level thresholds into CONFIG optionsJimmy Lin2014-07-103-15/+33
| | | | | | | | | | | | | | | | | | | | | | | | Allow boards to set the almost_full, low, critical, and shutdown battery levels as CONFIG options. BUG=None BRANCH=tot,gnawty TEST=manual Add: CONFIG_BATTERY_LEVEL_NEAR_FULL CONFIG_BATTERY_LEVEL_LOW CONFIG_BATTERY_LEVEL_CRITICAL CONFIG_BATTERY_LEVEL_SHUTDOWN values in a board.h and verify notifications are sent to the host at the modified value. Change-Id: Ia4df2fb3f23602e5b84ec0d9d62ebbd3e218c7a6 Signed-off-by: Jimmy Lin <jimmy.Lin@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/207101 Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Queue: Dave Parker <dparker@chromium.org> Tested-by: Dave Parker <dparker@chromium.org>
* Swanky: Supports Power LED blinking in S3 mode.Aaron Weng2014-07-081-3/+35
| | | | | | | | | | | | | | | | | | To implement the power led blinks in S3 mode when lid is open. BUG=chrome-os-partner:30107 BRANCH=rambi TEST=make buildall -j and check the power led behavior is correct on S3 and S0/S5 mode. Signed-off-by: Aaron Weng <aaron.weng@quantatw.com> Change-Id: I3a7a6d6e7e9cd11d2ecd352945c5f0f64bdbb048 Reviewed-on: https://chromium-review.googlesource.com/206084 Commit-Queue: Aaron Weng <aaron.weng@quantatw.com> Tested-by: Aaron Weng <aaron.weng@quantatw.com> Reviewed-by: Dave Parker <dparker@chromium.org>
* winky : Disabled kbd's column 2 invert to fix non-working kbd.yoojin2014-07-081-1/+0
| | | | | | | | | | | | | | | | | | | | | | KBD didn't work partly because holeless reset ic was changed. KBD's Column 2 line was inverted. So, KBD's Column 2 invert should be disable. BUG=chrome-os-partner:30086 TEST=emerge-winky chromeos-ec Check to wake up system by power button. Check function key on S0. Change-Id: I0e125362512361c5c908c74a0b139a40d018b104 Reviewed-on: https://chromium-review.googlesource.com/205913 Reviewed-by: YongBeum Ha <ybha@samsung.com> Tested-by: YongBeum Ha <ybha@samsung.com> Reviewed-by: Mohammed Habibulla <moch@chromium.org> Reviewed-by: yoojin lee <yoojin7.lee@samsung.com> Tested-by: yoojin lee <yoojin7.lee@samsung.com> Reviewed-by: Vincent Palatin <vpalatin@chromium.org> Commit-Queue: YongBeum Ha <ybha@samsung.com>
* winky : Skip to check temperature by diassert PWROKyoojin2014-07-081-0/+1
| | | | | | | | | | | | | | | | | | | | EC reset by i2c fail. EC should ignore to check temperature when PWROK was diasserted and thermal sensor was off BUG=chrome-os-partner:29907 TEST=emerge-winky chromeos-ec Check system boot on winky and temperature on S0. Change-Id: I52cab9470b1b82ea257020f95f62cc67099788f1 Reviewed-on: https://chromium-review.googlesource.com/205902 Reviewed-by: YongBeum Ha <ybha@samsung.com> Reviewed-by: yoojin lee <yoojin7.lee@samsung.com> Tested-by: YongBeum Ha <ybha@samsung.com> Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-by: Mohammed Habibulla <moch@chromium.org> Commit-Queue: yoojin lee <yoojin7.lee@samsung.com> Tested-by: yoojin lee <yoojin7.lee@samsung.com>
* BayTrail: Set the default USB charge mode to CDPDave Parker2014-07-0712-0/+12
| | | | | | | | | | | | | | | | This reflects the reality of what we have been doing already. The earlier default mode of SDP2 was actually CDP due to an inversion in the ILIM control line. BUG=chrome-os-partner:29053 BRANCH=None TEST=Boot a baytrail board and verify that the 'usbchargemode' command indicates CDP charging. Change-Id: Ia061d45512d1f90c68fd02b3197c414961b78a7c Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/205813 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* USB Power: Add config option to set default charge modeDave Parker2014-07-072-2/+12
| | | | | | | | | | | | | BUG=chrome-os-partner:29053 BRANCH=ToT TEST=Set a default change mode other than SDP2 in a board config. Verify the 'usbchargemode' console command indicates the ports are operating in that mode. Signed-off-by: Dave Parker <dparker@chromium.org> Change-Id: I4a65d8b6ad14ff3d1f12b644960bbf401027f8df Reviewed-on: https://chromium-review.googlesource.com/205812 Reviewed-by: Vic Yang <victoryang@chromium.org>
* USB Power: Invert ILIM control line with 'smart simple' chargingDave Parker2014-07-071-3/+3
| | | | | | | | | | | | | | | | | The ILIM control line is inverted before reaching the USB charge controllers when they are cross-connected to allow only one port to deliver the HIGH current limit at a time. BUG=chrome-os-partner:29053 BRANCH=ToT TEST=Verify, with a multimeter, that ILIM (pin 4) on a TPS2546 is 3.3V when the chargemode is set to CDP Change-Id: Idd89dcfc117f1f3393ded1887e8d1cb27ba367ad Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/205811 Reviewed-by: Vic Yang <victoryang@chromium.org> Reviewed-by: Randall Spangler <rspangler@chromium.org>
* Tiny: Remove keyscan taskDave Parker2014-06-271-2/+1
| | | | | | | | | | | | | | The keyscan task is not needed on Tiny. BUG=chrome-os-partner:29504 BRANCH=None TEST=Verify power button works correctly and keyscan task isn't listed under 'taskinfo'. Change-Id: I34e8782aa4aeffe700c914826287ff1dfefcd186 Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/203104 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* Config: Allow keyproto task to run without keyscan definedDave Parker2014-06-261-5/+0
| | | | | | | | | | | | | | | Allow devices to send power button keyboard events without having an internal keyboard defined. BUG=chrome-os-partner:29504 BRANCH=None TEST=Build and run on a peppy. Verify keyboard protocol messages are still sent for the power button using evtest. Change-Id: Ibfaa1a779552bdc5a643911703e7900bbc1d51d7 Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/203103 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* Rambi: Increase adapter input current limit to 1894mADave Parker2014-06-201-1/+1
| | | | | | | | | | | | | | | | | This sets the adapter current limit to 90% of the rating for a 40W adapter. The earlier limit was based on a 33W adapter which was not used. BUG=chrome-os-partner:23833 BRANCH=ToT TEST=With a 20-80% charged battery run 4000 fish (search for WebGl Aquarium) with backlight at 100%. Verify ChargerCurrent is around the limit with 'adc' command on EC serial console. Change-Id: I6279d0a3502142348b79425e56cfc25bf75432b5 Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/204893 Reviewed-by: Todd Broch <tbroch@chromium.org>
* Expresso: Increase adapter input current limit to 1894mADave Parker2014-06-201-1/+1
| | | | | | | | | | | | | | | | | This sets the adapter current limit to 90% of the rating for a 40W adapter. The earlier limit was based on a 33W adapter which was not used. BUG=chrome-os-partner:23833 BRANCH=None TEST=With a 20-80% charged battery run 4000 fish (search for WebGl Aquarium) with backlight at 100%. Verify ChargerCurrent is around the limit with 'adc' command on EC serial console. Change-Id: I4e2270dd1cb774681383105d88869dc7022a9fb7 Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/204932 Reviewed-by: Todd Broch <tbroch@chromium.org>
* Kip: Modify battery LED behavior.Devin Lu2014-06-171-6/+9
| | | | | | | | | | | | | | | | | | | | | | | We won't to see the corner case when plugging in adpater. if battery want to charge, we want to see the amber led directly when plugging in adapter, not white to amber. if battery into fully charged, we want to see the white led directly when plugging in adapter, not amber to white. BUG=None BRANCH=rambi TEST=manual Check battery LED show amber directly when plugging in adpater, if battery needs to charge. Check battery LED show white directly when plugging in adpater, if battery into fully charged. Check battery LED show white directly when plugging in adpater, if battery near full. Change-Id: I08e6c9ea32dc90599a974d7b5fadaf59f549cc77 Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/203932
* Enguarde: Enable PWM module in deep sleepDave Parker2014-06-141-0/+1
| | | | | | | | | | | | | | | This prevents erratic blinking of the charging LED while in G3. BUG=chrome-os-partner:29577 BRANCH=enguarde TEST=Shutdown machine and type 'dsleep 0' in the serial console to force deep sleep mode. Verify the charging LED doesn't flash erratically. Change-Id: Ibc6af84f9f35e4ba3893269d9a306e4b5e99f70a Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/203850
* Expresso: Enable PWM module in deep sleepDave Parker2014-06-141-0/+1
| | | | | | | | | | | | | | | This prevents erratic blinking of the charging LED while in G3. BUG=chrome-os-partner:29577 BRANCH=expresso TEST=Shutdown machine and type 'dsleep 0' in the serial console to force deep sleep mode. Verify the charging LED doesn't flash erratically. Change-Id: I4912cde058f54266a2701155d08817f648bc72de Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/203802
* Rambi: Enable PWM module in deep sleepDave Parker2014-06-141-0/+1
| | | | | | | | | | | | | | | This prevents erratic blinking of the charging LED while in G3. BUG=chrome-os-partner:29577 BRANCH=ToT TEST=Shutdown machine and type 'dsleep 0' in the serial console to force deep sleep mode. Verify the charging LED doesn't flash erratically. Change-Id: I6bdbf324ac9189a5f135523318d171df9d476b0d Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/203862
* Swanky: Support ectool to control power led on/off.Aaron Weng2014-06-091-4/+15
| | | | | | | | | | | BUG=None BRANCH=rambi TEST=make buildall -j and ectool led power off/white work normally. Signed-off-by: Aaron Weng <aaron.weng@quantatw.com> Change-Id: I86aa3cabf7c38e449c241ad058eb31497ec64e8e Reviewed-on: https://chromium-review.googlesource.com/202905 Reviewed-by: Dave Parker <dparker@chromium.org>
* Swanky: To implement power led.Aaron Weng2014-06-064-5/+36
| | | | | | | | | | | BUG=chrome-os-partner:29077 BRANCH=rambi TEST=make buildall -j and power led can be operated normally. Change-Id: Iaf69859fdaa6e511d8e19810f38bed85209a226c Signed-off-by: Aaron Weng <aaron.weng@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/202655 Reviewed-by: Dave Parker <dparker@chromium.org>
* Gnawty:Update 3 cell battery parameter to meet SPEC.Jimmy Lin2014-05-301-2/+2
| | | | | | | | | | | | | | BUG=none BRANCH=gnawty TEST=To check the battery can be charging normally. Signed-off-by: Jimmy Lin <jimmy.Lin@quantatw.com> Change-Id: I8e76e454bb4be66ce44b9aa80c9971afa1448e50 Reviewed-on: https://chromium-review.googlesource.com/202211 Tested-by: 挺倫 林 <jimmy.lin@quantatw.com> Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Queue: Dave Parker <dparker@chromium.org>
* Swanky: To implement battery shipping mode.Aaron Weng2014-05-301-6/+76
| | | | | | | | | | | | | | | | | According Battery pack SPEC, the battery shipping mode set condition must be meet below items. 1.AC adaptor attached. 2.The each cell voltage is under 4000mV. BUG=chrome-os-partner:29077 BRANCH=rambi TEST=The battery pack can be set shipping mode and wake up from shipping mode success by ectool batterycutoff command. Change-Id: I80439040021a82e5635c22546f725a70b47a863f Signed-off-by: Aaron Weng <aaron.weng@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/201815 Reviewed-by: Dave Parker <dparker@chromium.org>
* Gnawty:Add 15 ms delay before turning off PP3300_DX at S0->S3.Jimmy Lin2014-05-291-1/+11
| | | | | | | | | | | | | | BUG=chrome-os-partner:29024 BRANCH=gnawty TEST=We try to used the 10 ms and 13 ms delay. But the T11 still fail.The 15 ms is minimum pass criteria. Change-Id: I96cb3a6c72d25db02aafcd07e366f12f389f91c9 Signed-off-by: Jimmy Lin <jimmy.Lin@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/202030 Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Queue: Dave Parker <dparker@chromium.org> Tested-by: Dave Parker <dparker@chromium.org>
* Add 'tiny' board based on RambiDave Parker2014-05-268-0/+649
| | | | | | | | | | | | | | Copy, paste, and rename of Rambi. Customization will be done in follow-up patches. BUG=None BRANCH=None TEST=make buildall -j Change-Id: I43397bc6bc2155613b6e02b47fa6febaa439b376 Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/198321 Reviewed-by: Mohammed Habibulla <moch@chromium.org>
* Kip: fix for EC has very slow reset.Devin Lu2014-05-232-0/+3
| | | | | | | | | | | | | | Add battery present pin. BUG=none BRANCH=rambi TEST=manual To check the system reset normally without battery attached. Change-Id: Id3ed19a3464045cc56d8bd7674cb2d6fb67df013 Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/200193
* Swanky: To change battery charging led color.Aaron Weng2014-05-162-14/+14
| | | | | | | | | | | | | | | | According battery physical led is orange color. So we change the color setting to orange. BUG=none BRANCH=rambi TEST=tested battery charging led color. Signed-off-by: Aaron Weng <aaron.weng@quantatw.com> Change-Id: I06cb3c1f6f3ca6c230acba1670760f5172447ff6 Reviewed-on: https://chromium-review.googlesource.com/200024 Tested-by: Aaron Weng <aaron.weng@quantatw.com> Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Queue: Aaron Weng <aaron.weng@quantatw.com>
* Swanky: fix for EC has very slow reset.Aaron Weng2014-05-122-0/+3
| | | | | | | | | | | | | | | Add the battery presense GPIO. BUG=chrome-os-partner:28713 BRANCH=rambi TEST=To check the system reset normally without battery attached. Change-Id: Id21cc7dd624719b686d7d23bbcae50b4cbe8dc31 Signed-off-by: Aaron Weng <aaron.weng@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/199288 Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Queue: Dave Parker <dparker@chromium.org> Tested-by: Dave Parker <dparker@chromium.org>
* Swanky: Initial 3 cell battery parameter.Aaron Weng2014-05-081-6/+6
| | | | | | | | | | | | | | BUG=chrome-os-partner:28448 BRANCH=rambi TEST=To check the battery can be charging normally. Change-Id: I3c23b464b53e9449a462b130ecd0ee5dffa570f2 Signed-off-by: Aaron Weng <Aaron.Weng@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/198149 Reviewed-by: Aaron Weng <aaron.weng@quantatw.com> Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Queue: Dave Parker <dparker@chromium.org> Tested-by: Dave Parker <dparker@chromium.org>
* clapper: glimmer: fix for keyboard occasionally disabled on wakeAlec Berg2014-05-061-11/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes bug in which the keyboard remains disabled after resuming. The problem occurs when the lidangle_keyscan_update() occurs after the CHIPSET_RESUME hook triggers and before chipset state is CHIPSET_STATE_ON, and the lid angle is in range to disable the keyboard. The fix is to not use a hook at all on chipset resume, and instead just keep track of the last chipset state locally in lidangle_keyscan_update(). That way we guarantee that when the AP is turned on, the next time we check for lidangle keyscanning state, it will enable the keyboard. BUG=chrome-os-partner:28480 BRANCH=rambi TEST=tested on a glimmer: Added a hook to detect chipset resume in lid_angle.c: static void enable_keyboard(void) { hook_fired = 1; } DECLARE_HOOK(HOOK_CHIPSET_RESUME, enable_keyboard, HOOK_PRIO_DEFAULT); Then in lidangle_keyscan_update() added: if (hook_fired && !chipset_in_state(CHIPSET_STATE_ON)) ccprintf("Hook fired, but chipset state still reads off\n"); hook_fired = 0; Using this code, I used the lid switch on the servo board to open and close the lid repeatedly until I saw the printf above. Without this CL, when the printf is shown, the keyboard remains disabled in S0. With this CL, the keyboard is enabled in S0. Change-Id: Iac017a6468d46e0f011ec9d84a8c73b89622d8cc Signed-off-by: Alec Berg <alecaberg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/198285 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* Clapper: Modify battery LED's behaviorgit-CarryBK_Chen.compal.com2014-05-061-12/+12
| | | | | | | | | | | | | | | | Base on customer's request, change LED behavior BRANCH=clapper BUG=none TEST=Use battfake to verify each case Signed-off-by: Carry Chen <CarryBK_Chen@compal.com> Change-Id: Icecd40d54ec28cdd242129cb862510914ef7616a Reviewed-on: https://chromium-review.googlesource.com/197486 Reviewed-by: Antonie Cheng <Antonie_Cheng@compal.com> Commit-Queue: Antonie Cheng <Antonie_Cheng@compal.com> Tested-by: Antonie Cheng <Antonie_Cheng@compal.com> Reviewed-by: Dave Parker <dparker@chromium.org>
* Quawks: Add pure hardware shutdown mechanism.Kenneth Lo2014-04-302-1/+48
| | | | | | | | | | | | | | | | | | | | Quawks boards need a pure hardware protection mechanism to shutdown/reset system even if EC is hanged. This is done using the ALERT# pin of TMP432 thermal IC. So EC programs TMP432 with specified temperature limit value every time when system is booted, to make sure this mechanism works as expected. BUG=chrome-os-partner:28184 BRANCH=rambi TEST=Run "make -j buildall" and "make -j BOARD=quawks tests". Tested by thermal engineers that system will shutdown when specified temperature is reached. Change-Id: I485852409153c036488eac2ae9c0a8fe4e2c5b61 Signed-off-by: Kenneth Lo <Kenneth_Lo@asus.com> Reviewed-on: https://chromium-review.googlesource.com/195120 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* baytrail: Workaround for stuck boot processRandall Spangler2014-04-295-13/+116
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In some cases, the system will boot to S0 from the point of view of the EC, but PLTRST# will never deassert. Work around this by waiting 50 ms for PLTRST# to deassert. If it doesn't, force the chipset all the way down by deasserting RSMRST#, then pulse the power button to turn it back on. Also add a powerfail debug command to simulate this failure event, so that the recovery process can be tested. Add API to the LPC module to get the state of PLTRST#, and to the power button state machine to force it released when we shut down the chipset and and force another power button pulse as we reset the chipset. BUG=chrome-os-partner:28422 BRANCH=baytrail TEST=1. Boot system. Should boot normally. Shut system down. 2. powerfail 3. Boot system. On the EC console, should see the system come up, go back down through G3S5, then come back up. From the user's point of view, it just boots. 1. Boot system. Should boot normally. (That is, powerfail is not sticky) Change-Id: Ia7df629a2e2f017e411432d7e224a3c5eb95f8b8 Original-Change-Id: Ia57f196606f79b9f2fce7d9cd109ab932c3571aa Signed-off-by: Randall Spangler <rspangler@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/197534 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Commit-Queue: Shawn Nematbakhsh <shawnn@chromium.org> Tested-by: Shawn Nematbakhsh <shawnn@chromium.org>
* Glimmer: Support write first use day functionHenry Hsu2014-04-252-0/+41
| | | | | | | | | | | | | | | | Only support write function. BUG=chrome-os-partner:25145 BRANCH=glimmer TEST=clean correspondence register to 0, run "ectool batteryparam set 0 0x1234", and check the register. The register change to 0x1234. Command "ectool batteryparam set 0 0x1234" return 2 because we have no get function. Change-Id: I2d8c66fc41ddb45c45ff993eaed1e067689b1268 Signed-off-by: Henry Hsu <Henry.Hsu@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/196973 Reviewed-by: Dave Parker <dparker@chromium.org>
* Quawks: Adjust charge thresholds for altering LED behaviorKenneth Lo2014-04-241-5/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | The EC and host have different ways of computing and presenting the battery charge level. This change adjusts the charge levels at which the charging LED indicates a full and low battery to match what is presented to the user in the host UI. (Ported from [4e470aa]Squawks: Adjust charge thresholds for altering LED behavior) BUG=chrome-os-partner:27449 BRANCH=rambi TEST=Run "battfake 91" which charging, verify charging LED turns green and the UI reports 96%. Run "battfake 90" which charging, verify charging LED turns orange and the UI reports 94%. Run "battfake 13" while discharging, verify charging LED blinks amber (1 sec on, 1 sec off) and the UI reports 10%. Change-Id: Ib89dc4750fc4af91d0a7e706fa8c76c21823dfe8 Signed-off-by: Kenneth Lo <Kenneth_Lo@asus.com> Reviewed-on: https://chromium-review.googlesource.com/196156 Reviewed-by: Charles Yu <charles.yu@intel.com> Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Queue: Dave Parker <dparker@chromium.org>
* Add host command to set battery vendor parametersDave Parker2014-04-245-0/+179
| | | | | | | | | | | | | | | | | | Also adds 'battparam' console command. BUG=chrome-os-partner:25145 BRANCH=ToT TEST=Run 'ectool batteryparam set 0 0x1234' 'ectool batteryparam get 0' and on the console: 'battparam 0' 'battparam 0 0x1234' on a board that implements parameter 0. Change-Id: Ib2812f57f2484309d613b23dab12ad43e0417bd2 Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/195824 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* Glimmer: Hard-code accelerometer power enableDave Parker2014-04-242-5/+4
| | | | | | | | | | | | | | | | This is a temporary fix to enable the accelerometers by hard-coding the power enable high until the CL to control and reset the accelerometers is landed. BUG=chrome-os-partner:27577 BRANCH=None TEST=Manual. Run on glimmer. Verify accelerometers work and are polled at the correct rate in S0 and S3 with console 'lidangle on' command. Change-Id: I619deffe6b5d1edb35c022cd0071310e2c2f1e3d Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/194901
* Move battery cutoff to a shared command with config optionDave Parker2014-04-233-0/+93
| | | | | | | | | | | | | | | | | | | | | | | | | Boards can define the config option and implement a battery_cut_off() function to put their battery into "ship mode." Works with the existing "batterycutoff" host command. When using the host command, the battery is cut off 5 seconds after the system is shut down to minimize filessystem corruption issues. Also includes a "battcutoff" console command that requires AC power be removed. Cut off is immediate in this case. BUG=chrome-os-partner:28190 BRANCH=ToT TEST=Run 'ectool batterycutoff' and the console 'battcutoff' commands on a board using the CONFIG_BATTERY_CUT_OFF option. Verify the battery is cut off by pressing the power button >5 seconds after shutting down. Change-Id: I4d99a2e5aec53906416677ea44b41123b2957815 Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/196133 Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-by: Vic Yang <victoryang@chromium.org>
* Gnawty: Init boardJimmy Lin2014-04-237-0/+721
| | | | | | | | | | | | | | | | | | | | | | | | | 1.Copy Rambi setting to init board. 2.Add entries for 'gnawty' in following two files. util/flash.ec chip/lm4/openocd/lm4x_cmds.tcl 3.Modify below battery paramemters to support 3 cell battery. input_current/charge_volatge/charge_current/temperature 4.Check the Battery of cutoff function works normally in gnawty. 5.Modify the temp_sensors of name and location. 6.Add power and battery of LED control for gnawty. BUG=none BRANCH=gnawty TEST=Run "make BOARD=gnawty" and "make buildall -j" to build code and ec.bin can be generated. Signed-off-by: Jimmy Lin <jimmy.Lin@quantatw.com> Change-Id: I5720838ef623ee3e0cb40710aeebb53599c3551d Reviewed-on: https://chromium-review.googlesource.com/195821 Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Queue: Dave Parker <dparker@chromium.org> Tested-by: Dave Parker <dparker@chromium.org>
* Clapper: Hard-code accelerometer power enableDave Parker2014-04-232-5/+4
| | | | | | | | | | | | | | | | This is a temporary fix to enable the accelerometers by hard-coding the power enable high until the CL to control and reset the accelerometers is landed. BUG=chrome-os-partner:24894 BRANCH=None TEST=Manual. Run on clapper. Verify accelerometers work and are polled at the correct rate in S0 and S3 with console 'lidangle on' command. Change-Id: I947d4dee5d6dece4a32c9625d828e599b3167b01 Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/194902
* Make board names in flash_ec less prone to conflictsChromeOS Developer2014-04-221-8/+47
| | | | | | | | | | | BUG=None BRANCH=rambi TEST=Run util/flash_ec on clapper Change-Id: Ib388af6800ae208934d5b026a63f0567d31ef86e Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/196226 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* Swanky: Add OpenOCD and flash tool configurationsHenry Hsu2014-04-222-1/+14
| | | | | | | | | | | | | | | Add some configurations for swanky, include OpenOCD and util/flash_ec. BUG=none BRANCH=swanky TEST=none Change-Id: Ibede079dcb304e0cf599df37d192a1d986549806 Signed-off-by: Henry Hsu <Henry.Hsu@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/196191 Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Queue: Dave Parker <dparker@chromium.org> Tested-by: Dave Parker <dparker@chromium.org>
* Squawks: Adjust charge thresholds for altering LED behaviorDave Parker2014-04-211-5/+12
| | | | | | | | | | | | | | | | | | | | | The EC and host have different ways of computing and presenting the battery charge level. This change adjusts the charge levels at which the charging LED indicates a full and low battery to match what is presented to the user in the host UI. BUG=chrome-os-partner:27743,chrome-os-partner:27746 BRANCH=rambi,tot TEST=Run "battfake 91" which charging, verify charging LED turns green and the UI reports 95%. Run "battfake 13" while discharging, verify charging LED blinks amber (1 sec on, 1 sec off) and the UI reports 10%. Change-Id: I326731c46e61a953b445cd9eda875d7dab3da4dd Original-Change-Id: I203c90a65e4aa2907a14077a9276674ecfa292f2 Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/194347 Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/195847
* Glimmer: Change ADAPTER_ID pin to highHenry Hsu2014-04-212-0/+2
| | | | | | | | | | | | | | | | | Pull up adapter id pin will save power since we disable adapter id function. BUG=chrome-os-partner:28156 BRANCH=glimmer TEST=flash ec, hard reset, and run command "ectool gipoget ADAPTER_ID". It shows that GPIO ADAPTER_ID = 1. Change-Id: I37ee64f1b493e35e0181a636212c856b7755427a Signed-off-by: Henry Hsu <Henry.Hsu@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/195717 Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Queue: Dave Parker <dparker@chromium.org> Tested-by: Dave Parker <dparker@chromium.org>
* Rename battery_vendor_params() to battery_override_params()Dave Parker2014-04-216-16/+16
| | | | | | | | | | | | | | | | This is a clearer name for the intent of the function to override the charging parameters requested by the battery. This also disabmiguates this function with a new host command to get and set arbitrary vendor parameters in the battery. BUG=chrome-os-partner:25145 BRANCH=ToT TEST=`make buildall -j` Change-Id: I1e8762d359c0e91c5b2a539553d22c12c9850c03 Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/195823 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* lpc: ACPI query-next-event drops masked eventsRandall Spangler2014-04-182-6/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, you could use EC_CMD_ACPI_QUERY_EVENT to read events that were masked off (that is, events which would not generate SCI/SMI/wake signals). The handlers for those signals on the host would still act on the masked-off events - for example, causing unwanted power button keypresses/releases. Now, EC_CMD_ACPI_QUERY_EVENT will only return events which are unmasked. This does not affect storing of events at event generation time. Events are still queued; they won't be dropped until the host attempts to read the next event. This gives the host a chance to set a mask later in boot (but before querying any events) to capture events which happened early in the boot process. BUG=chrome-os-partner:26574 BRANCH=rambi TEST=At EC console, type 'hostevent set 0x80' but don't press enter. Hold down the power button; UI starts fading to white. Press enter at the EC console to issue the hostevent command. System should continue shutting down, not fade back as if the power button were released. Orig-Change-Id: Id2cb14b0979f49cdd42424b9a61b310a2bb506f5 Signed-off-by: Randall Spangler <rspangler@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/194935 Reviewed-by: Duncan Laurie <dlaurie@chromium.org> (cherry picked from commit d899fdaaeef175e97923b954342dad3a33c5c387) Change-Id: I69f495809a72bda77841ed16c041d0c3dbe198c2 Reviewed-on: https://chromium-review.googlesource.com/195566 Reviewed-by: Randall Spangler <rspangler@chromium.org> Commit-Queue: Randall Spangler <rspangler@chromium.org> Tested-by: Randall Spangler <rspangler@chromium.org>
* Kip: identify adapters and adjust the charger input currentDevin Lu2014-04-177-0/+323
| | | | | | | | | | | | | | | | | | | identify adapters and adjust the charger limit for each adapter. re-factored for adapter over rating. re-factored for battery over current. BUG=chrome-os-partner:27798 BRANCH=rambi TEST=manual build ec and flash to kip board. verify adapters can be identified. check AP can be throttle when battery over current. check AP can be throttle when adapter over rating. Change-Id: I1339f55d8ed523acf9543ee8acd7c7e3c9c99e9c Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/194891
* Refactored keyboard scan enable flag to allow for multiple disable reasonsAlec Berg2014-04-117-62/+77
| | | | | | | | | | | | | | | | | | | | | | Refactored keyboard scan enable/disable flag such that it is a mask of potential disable sources. When all disable sources are off, scanning is enabled, otherwise scanning is disabled. This fixes a recently introduced bug in which enabling/disabling keyboard scanning due to lid angle in S3 was interfering with enabling/disabling keyboard scanning due to power button. This also allows for easy expansion for future causes for disabling keyboard scanning. BUG=chrome-os-partner:27851 BRANCH=rambi TEST=Manual tests with a glimmer. Used the ksstate console command to check state of keyboard scanning under all permutations of power button pressed/unpressed, lid switch open/closed, and lid angle in tablet position vs. laptop positon. Change-Id: Ied4c5ebb94510b1078cd81d71373c0f1bd0d6678 Signed-off-by: Alec Berg <alecaberg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/194097 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* accel: Add host cmd for setting lid angle threshold for disabling keyboard wakeAlec Berg2014-04-1010-41/+173
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Added a sub-command to the motionsense host command (0x2b) for getting/setting the lid angle at which the keyboard is disabled as a wake source in S3. The value can be anywhere from 0 to 360 degrees, default set to 180. Note, this only takes affect for boards that have CONFIG_LID_ANGLE_KEY_SCAN defined. Modified ectool motionsense command to use new host sub-command. Also modified the lid angle measurement in the EC to be in the range [0, 360], instead of [-180, 180], and changed casting of lid angle as an int to round to nearest. BUG=none BRANCH=rambi TEST=Tested on a glimmer: Using default keyboard disable lid angle of 180, made sure that when lid angle is past 180, key presses do not wake system, and when lid angle is less than 180, key presses do wake up system. Used ectool motionsense kb_wake to set the keyboard disable lid angle to 0. Made sure that keyboard never wakes up the system. Set keyboard disable lid angle to 360 and made sure that the keyboard always wakes up the system. Change-Id: I437164c6e38c29169ef6e20e86c9cf2a1c78f86e Signed-off-by: Alec Berg <alecaberg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/193663 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* Add expresso board, copied from rambiDave Parker2014-04-098-1/+650
| | | | | | | | | | | BUG=chrome-os-partner:27003 BRANCH=None TEST=make buildall -j Change-Id: I2af28640db8b35de922ca60eeb176afe3e0dcb64 Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/193725 Reviewed-by: Randall Spangler <rspangler@chromium.org>
View Lorry Controller Status