summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Clear OWNERS for factory/firmware branchfirmware-winky-5216.265.BBrian Norris2021-09-101-0/+1
| | | | | | | | | | | | BUG=none TEST=none Change-Id: I0f03f432ada1064ffba9595be78ca7ab4d25ecd1 Signed-off-by: Brian Norris <briannorris@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3155288 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Owners-Override: Jora Jacobi <jora@google.com> Tested-by: Jack Rosenthal <jrosenth@chromium.org>
* winky : Show correct infomation in battery commandSteven Jian2015-03-111-0/+6
| | | | | | | | | | | | | The I-desired is old value, should be override by platform driver. BUG=chrome-os-partner:35017 BRANCH=winky TEST=test_that IP f:.*firmware_ECCharging/control Change-Id: Ia55d5595e2dd52d45045042b8d22cde55e53b9b5 Signed-off-by: Steven Jian <steven.jian@intel.com> Reviewed-on: https://chromium-review.googlesource.com/257790 Reviewed-by: Shawn N <shawnn@chromium.org>
* EC:KBC: Wait until LPC host senses the IRQ and gets the character.Kenji Chen2014-10-281-1/+6
| | | | | | | | | | | | BRANCH=master BUG=chrome-os-partner:29139 TEST=Buiid an EC FW image and run on Rambi to test if key loss is improved and any side effect somes with this change. Need more test units to confirm this. Signed-off-by: Kenji Chen <kenji.chen@intel.com> Change-Id: I2399e33d2ca3defe8cd9b1f94ab0af1db7f84635 Reviewed-on: https://chromium-review.googlesource.com/226010 Reviewed-by: Mohammed Habibulla <moch@chromium.org>
* winky : Change stack size in charge taskyoojin2014-08-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | System was reset by stack overflow in charger task, when battery i2c communication is failed. Winky system needs a minimum of 520 byte to use stack in charger task. So, stack size in charger task should be changed to 640 byte. BUG=chrome-os-partner:31568 TEST=emerge-winky chromeos-ec Check stack size in charger task Change-Id: I130aecbdb973f1a2e7f18a46e49625844ffc827a Reviewed-on: https://chromium-review.googlesource.com/213996 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Mohammed Habibulla <moch@chromium.org> Reviewed-by: YongBeum Ha <ybha@samsung.com> Commit-Queue: YongBeum Ha <ybha@samsung.com> Tested-by: YongBeum Ha <ybha@samsung.com> (cherry picked from commit 2899e7d5bdf76dcc6e8dfda32fa725c0aa17ab8a) Reviewed-on: https://chromium-review.googlesource.com/214091 Tested-by: Bernie Thompson <bhthompson@chromium.org>
* winky : Add to change charging currunt on near full charge.YB.Ha2014-08-081-1/+2
| | | | | | | | | | | | | | | | | PWR_STATE_CHARGE_NEAR_FULL also need to change charging current by FCC * 0.6 for battery safety and charging time. BUG=chrome-os-partner:31146 TEST=emerge-winky chromeos-ec Check charging current by i2c register. Change-Id: I1c0ea803c663dcc4147a31a3af33864b592bf89b Reviewed-on: https://chromium-review.googlesource.com/211554 Reviewed-by: yoojin lee <yoojin7.lee@samsung.com> Reviewed-by: Mohammed Habibulla <moch@chromium.org> Reviewed-by: YongBeum Ha <ybha@samsung.com> Commit-Queue: YongBeum Ha <ybha@samsung.com> Tested-by: YongBeum Ha <ybha@samsung.com>
* winky : Fix the method to read full battery capacityYB.Ha2014-08-081-1/+3
| | | | | | | | | | | | | | | 'struct batt_params' has no member named 'full_capacity' BUG=chrome-os-partner:31146 TEST=emerge-winky chromeos-ec Check charging current by i2c register. Change-Id: Idaeb5fcd6c322c552793fc955e64d669c0b09fa4 Reviewed-on: https://chromium-review.googlesource.com/211561 Reviewed-by: yoojin lee <yoojin7.lee@samsung.com> Reviewed-by: Mohammed Habibulla <moch@chromium.org> Commit-Queue: yoojin lee <yoojin7.lee@samsung.com> Tested-by: yoojin lee <yoojin7.lee@samsung.com>
* Winky : Generate battery error if low voltage for more than 2 hoursYB.Ha2014-08-081-0/+9
| | | | | | | | | | | | | | | | | | | | Stop to charge and enter battery error state when system keeps low voltage for more than 2hours. Battery error state by this reason is cleared only once when battery was reconnected. BUG=chrome-os-partner:30951 TEST=emerge-winky chromeos-ec Check to stop and start charging by low voltage during 2hours. Change-Id: I0bf22c165d676b3d7637dd78c01db21b6d658874 Reviewed-on: https://chromium-review.googlesource.com/211124 Reviewed-by: Mohammed Habibulla <moch@chromium.org> Reviewed-by: yoojin lee <yoojin7.lee@samsung.com> Commit-Queue: yoojin lee <yoojin7.lee@samsung.com> Tested-by: yoojin lee <yoojin7.lee@samsung.com>
* winky : Change charging currentYB.Ha2014-08-081-0/+8
| | | | | | | | | | | | | | | | Charging current should be changed by FCC * 0.6 for battery safety and charging time. BUG=chrome-os-partner:31146 TEST=emerge-winky chromeos-ec Check charging current by i2c register. Change-Id: I56bc565934f5788e169a9d345fe180623cc27226 Reviewed-on: https://chromium-review.googlesource.com/211123 Reviewed-by: Mohammed Habibulla <moch@chromium.org> Reviewed-by: yoojin lee <yoojin7.lee@samsung.com> Tested-by: yoojin lee <yoojin7.lee@samsung.com> Commit-Queue: yoojin lee <yoojin7.lee@samsung.com>
* Winky : Charging start and stop by battery overtemperatureYB.Ha2014-08-081-1/+25
| | | | | | | | | | | | | | | | | | Charging start temperature : T<0 or T≥45 Charging stop temperature : T<0 or T≥60 Start condition of charge : 0≤T<45 BUG=chrome-os-partner:30951 TEST=emerge-winky chromeos-ec Check to stop and start charging by overtemperature. Change-Id: If73df8423c3d997598a49fcbc2926b290958c829 Reviewed-on: https://chromium-review.googlesource.com/211081 Reviewed-by: yoojin lee <yoojin7.lee@samsung.com> Reviewed-by: Mohammed Habibulla <moch@chromium.org> Commit-Queue: yoojin lee <yoojin7.lee@samsung.com> Tested-by: yoojin lee <yoojin7.lee@samsung.com>
* Winky : Check battery error by overvoltageYB.Ha2014-08-084-5/+53
| | | | | | | | | | | | | | | | | | | | | | Stop to charge and enter battery error state when battery pack voltage is higher than charging voltage. Battery error state by overvoltage is cleared only once when battery was reconnected. Battery error should be checked before translate battery flags. BUG=chrome-os-partner:30951 TEST=emerge-winky chromeos-ec Check battery error state by over voltage. Change-Id: I485d3be9f75bf32e0f2769401eeab8ec887f83ae Reviewed-on: https://chromium-review.googlesource.com/210016 Reviewed-by: yoojin lee <yoojin7.lee@samsung.com> Tested-by: yoojin lee <yoojin7.lee@samsung.com> Reviewed-by: Mohammed Habibulla <moch@chromium.org> Commit-Queue: yoojin lee <yoojin7.lee@samsung.com>
* Winky : Change temperature for stop discharging to meet spec.yoojin2014-08-051-2/+2
| | | | | | | | | | | | | | | | | | Winky system needs to change over-temperature conditions on discharging state to meet spec. Spec : T <= -20 or T >= 70 BUG=chrome-os-partner:31144 TEST=emerge-winky chromeos-ec Check to stop discharging by over temperature. Change-Id: I8372f99072bccafbbfab91c2873564c15c33189d Reviewed-on: https://chromium-review.googlesource.com/211067 Reviewed-by: YongBeum Ha <ybha@samsung.com> Tested-by: YongBeum Ha <ybha@samsung.com> Reviewed-by: Mohammed Habibulla <moch@chromium.org> Commit-Queue: YongBeum Ha <ybha@samsung.com>
* Winky : Change power sequence for RSMRST# on BYT-Myoojin2014-08-051-0/+1
| | | | | | | | | | | | | | | | | | | | | RSMRST# has to come 10us after the P1.0V is stable. Before, RSMRST# was high before P1.0V_AUX and P1.8V_AUX high. So, 1.1ms Delay was added on EC code. On this, RSMRST# is high after all SUS_Rails up. (P3.3V_AUX, P1.0V_AUX and P1.8V_AUX) BUG=chrome-os-partner:31116 TEST=emerge-winky chromeos-ec Measure signal waveforms in power up sequence. Change-Id: I55af36a6f4f2e7ea44ddf6b576df54f55cd3c8b0 Reviewed-on: https://chromium-review.googlesource.com/210954 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: YongBeum Ha <ybha@samsung.com> Tested-by: YongBeum Ha <ybha@samsung.com> Commit-Queue: YongBeum Ha <ybha@samsung.com>
* Winky : Change power sequence for Core well stable on BYT-Myoojin2014-08-051-3/+3
| | | | | | | | | | | | | | | | | | | Winky included PCIe device. Intel BYT-M spec. : Core well stable to DRAM_CORE_PWROK and PMC_CORE_PWROK assertion for power rails needed by PCIe devices is minimum 99ms. BUG=chrome-os-partner:31116 TEST=emerge-winky chromeos-ec Measure signal waveforms in power up sequence. Change-Id: I2afde9f1216b360c926c254f98d64124d2dbf080 Reviewed-on: https://chromium-review.googlesource.com/210952 Reviewed-by: YongBeum Ha <ybha@samsung.com> Tested-by: YongBeum Ha <ybha@samsung.com> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Commit-Queue: YongBeum Ha <ybha@samsung.com>
* Cloned from Rambi to Cranky with only string changesRoger Smith2014-07-318-0/+652
| | | | | | | | | | | | | | BUG=None TEST=Compiled BRANCH=rambi-5216.B Signed-off-by: Roger Smith <rogers@ami.com> Change-Id: I96554f67f23c528bfda50bfcd599521e9d51d809 Reviewed-on: https://chromium-review.googlesource.com/210482 Reviewed-by: Shawn Nematbakhsh <shawnn@chromium.org> Reviewed-by: Roger Smith <rogers@ami.com> Commit-Queue: Roger Smith <rogers@ami.com> Tested-by: Roger Smith <rogers@ami.com>
* Winky : Check battery responsive during 3minyoojin2014-07-313-1/+13
| | | | | | | | | | | | | | | | | | | | | | It's too short to check battery responsive during 30sec to winky system. Samsung spec is 3min to check i2c communication is failed. So, EC checks i2c communication during setting time when battery is inserted. BUG=chrome-os-partner:30951 TEST=emerge-winky chromeos-ec Check battery responsive with defect battery. Change-Id: Id37aa5bc6d8faef330fed2f65aeb76f6df7e66f4 Reviewed-on: https://chromium-review.googlesource.com/210018 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Mohammed Habibulla <moch@chromium.org> Reviewed-by: yoojin lee <yoojin7.lee@samsung.com> Commit-Queue: yoojin lee <yoojin7.lee@samsung.com> Tested-by: yoojin lee <yoojin7.lee@samsung.com>
* Winky : Update charge voltage for NVDC to meet spec.yoojin2014-07-303-0/+13
| | | | | | | | | | | | | | | | | | | | Set the charge voltage(0x15) in non-charging state. When EC set charge voltage below 4096mA, charge voltage of charger was actually 9008mA(POR). POR can not ensure battery stability. BUG=chrome-os-partner:30194 TEST=emerge-winky chromeos-ec Check charger values was set normally by read i2c. To check the battery can be charging normally. Change-Id: Ib90bc91bad7f726b893056c9c705415f51001e00 Reviewed-on: https://chromium-review.googlesource.com/206449 Reviewed-by: YongBeum Ha <ybha@samsung.com> Tested-by: YongBeum Ha <ybha@samsung.com> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Commit-Queue: YongBeum Ha <ybha@samsung.com>
* winky : Add to retry i2c by fail i2c communication.yoojin2014-07-243-2/+24
| | | | | | | | | | | | | | | | | | | | | | When battery was charging, battery current sometimes set to 256mA by fail i2c communication. So, EC should check i2c communication fail a few more times. When EC checks continual i2c fail 3 times, abnormal current was not occured. BUG=chrome-os-partner:30242 TEST=emerge-winky chromeos-ec Check battery current when battery was charging. Change-Id: Ibcff8b461a3cf0f547b2e1f7e85b7121a0fd543d Reviewed-on: https://chromium-review.googlesource.com/208921 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: yoojin lee <yoojin7.lee@samsung.com> Commit-Queue: yoojin lee <yoojin7.lee@samsung.com> Tested-by: yoojin lee <yoojin7.lee@samsung.com> Reviewed-by: YongBeum Ha <ybha@samsung.com> Tested-by: YongBeum Ha <ybha@samsung.com>
* Winky : Notify host about removed batteryyoojin2014-07-231-0/+8
| | | | | | | | | | | | | | | | | | | | | When battery was removed, battery tray icon did not change as removed battery. It just kept charging-icon. So, when battery is removed, battery present & charge & discharge flag should be clear and notified host. BUG=chrome-os-partner:30608 TEST=emerge-winky chromeos-ec Check battery tray icon when battery was removed. Change-Id: I0114839e8814194b82e11feedacf1008c22bc6f1 Reviewed-on: https://chromium-review.googlesource.com/208301 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Mohammed Habibulla <moch@chromium.org> Reviewed-by: YongBeum Ha <ybha@samsung.com> Commit-Queue: YongBeum Ha <ybha@samsung.com> Tested-by: YongBeum Ha <ybha@samsung.com>
* Winky : Update battery information to meet specyoojin2014-07-231-4/+4
| | | | | | | | | | | | | | BUG=chrome-os-partner:30194 TEST=emerge-winky chromeos-ec To check the battery can be charging normally. Change-Id: I46ee684deb52f25665aa27ffa26e3f1551b71d1a Reviewed-on: https://chromium-review.googlesource.com/209490 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Mohammed Habibulla <moch@chromium.org> Reviewed-by: YongBeum Ha <ybha@samsung.com> Commit-Queue: YongBeum Ha <ybha@samsung.com> Tested-by: YongBeum Ha <ybha@samsung.com>
* winky : Update input current to meet spec.yoojin2014-07-221-1/+1
| | | | | | | | | | | | | | | BUG=chrome-os-partner:30194 TEST=emerge-winky chromeos-ec Check input current was set normally. To check the battery can be charging normally. Change-Id: I24a622cdb71f1c18ad3985db43ccd5566ce4801f Reviewed-on: https://chromium-review.googlesource.com/208924 Reviewed-by: YongBeum Ha <ybha@samsung.com> Tested-by: YongBeum Ha <ybha@samsung.com> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Mohammed Habibulla <moch@chromium.org> Commit-Queue: YongBeum Ha <ybha@samsung.com>
* BayTrail: Add support for battery cutoff at-shutdownDave Parker2014-07-154-60/+146
| | | | | | | | | | | | | | | | | | | | | | | | | | This change brings over support from ToT for the 'at-shutdown' option to "ectool batterycutoff" A board wishing to use the common command should define: CONFIG_BATTERY_CUT_OFF in its board.h, implement "int board_cut_off_battery(void)" and remove any other EC_CMD_BATTERY_CUT_OFF command handlers. BUG=chrome-os-partner:28190 BRANCH=None TEST=Run the following commands and verify on the serial console that the battery is cut off at the appropriate time. Console: cutoff cutoff at-shutdown ectool (from both ToT and Rambi branch) ectool batterycutoff ectool batterycutoff at-shutdown Change-Id: I9071b0250181af5a31ff2eea71f9a142df0470d3 Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/207982 Reviewed-by: Vic Yang <victoryang@chromium.org>
* winky : 3 Color LEDyoojin2014-07-143-2/+130
| | | | | | | | | | | | | | | | | | | | | | | | 3 Color LED for samsung spec. * Scenario - BLUE : System on - GREEN : System off and Battery full-charged - RED : System off and Battery charging * EC only controlled green & red LED. Blue LED was controlled by HW. So, when system on, EC sould turn off green & red LED. BUG=chrome-os-partner:30089 TEST=emerge-winky chromeos-ec Check LED status as 3color LED scenario. Change-Id: Icc2375c2dd3bbbbbe73c23eb8972e9c2049e648d Reviewed-on: https://chromium-review.googlesource.com/205934 Reviewed-by: YongBeum Ha <ybha@samsung.com> Tested-by: YongBeum Ha <ybha@samsung.com> Reviewed-by: Mohammed Habibulla <moch@chromium.org> Commit-Queue: YongBeum Ha <ybha@samsung.com>
* winky : Enable battery detectyoojin2014-07-122-0/+3
| | | | | | | | | | | | | | | | | | Enable to detect battery as GPIO. And BAT_DETECT was moved to PB4 from PV1 BD'. BUG=chrome-os-partner:25417 TEST=emerge-winky chromeos-ec Check battery error when battery was removed. Change-Id: Idfe1bb955248a8515f3618d67ac08f9d973190b1 Reviewed-on: https://chromium-review.googlesource.com/206441 Reviewed-by: YongBeum Ha <ybha@samsung.com> Tested-by: YongBeum Ha <ybha@samsung.com> Reviewed-by: yoojin lee <yoojin7.lee@samsung.com> Tested-by: yoojin lee <yoojin7.lee@samsung.com> Reviewed-by: Mohammed Habibulla <moch@chromium.org> Commit-Queue: YongBeum Ha <ybha@samsung.com>
* Gnawty: Change battery LED to flash orange when battery lowJimmy Lin2014-07-102-4/+10
| | | | | | | | | | | | | | | | | | | | | | | | | BUG=chrome-os-partner:29937 BRANCH=gnawty TEST=manual Low Battery Case: To config Battery LED blinks orange during low Battery(=<13%), Check battery LED show amber directly when plugging in adpater. Critical Battery Case: To config Battery LED blinks orange during Critical Battery(=<7%), Check battery LED show amber directly when plugging in adpater. Battery full Case: To config Battery LED blinks full during Battery near full(=>95%), Check battery LED show blue directly when plugging in adpater. Change-Id: I6bcb205c48508b05f460d87511c85d3dec002dd5 Signed-off-by: Jimmy Lin <jimmy.Lin@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/207304 Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Queue: Dave Parker <dparker@chromium.org> Tested-by: Dave Parker <dparker@chromium.org>
* Turn battery level thresholds into CONFIG optionsJimmy Lin2014-07-103-15/+33
| | | | | | | | | | | | | | | | | | | | | | | | Allow boards to set the almost_full, low, critical, and shutdown battery levels as CONFIG options. BUG=None BRANCH=tot,gnawty TEST=manual Add: CONFIG_BATTERY_LEVEL_NEAR_FULL CONFIG_BATTERY_LEVEL_LOW CONFIG_BATTERY_LEVEL_CRITICAL CONFIG_BATTERY_LEVEL_SHUTDOWN values in a board.h and verify notifications are sent to the host at the modified value. Change-Id: Ia4df2fb3f23602e5b84ec0d9d62ebbd3e218c7a6 Signed-off-by: Jimmy Lin <jimmy.Lin@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/207101 Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Queue: Dave Parker <dparker@chromium.org> Tested-by: Dave Parker <dparker@chromium.org>
* Swanky: Supports Power LED blinking in S3 mode.Aaron Weng2014-07-081-3/+35
| | | | | | | | | | | | | | | | | | To implement the power led blinks in S3 mode when lid is open. BUG=chrome-os-partner:30107 BRANCH=rambi TEST=make buildall -j and check the power led behavior is correct on S3 and S0/S5 mode. Signed-off-by: Aaron Weng <aaron.weng@quantatw.com> Change-Id: I3a7a6d6e7e9cd11d2ecd352945c5f0f64bdbb048 Reviewed-on: https://chromium-review.googlesource.com/206084 Commit-Queue: Aaron Weng <aaron.weng@quantatw.com> Tested-by: Aaron Weng <aaron.weng@quantatw.com> Reviewed-by: Dave Parker <dparker@chromium.org>
* winky : Disabled kbd's column 2 invert to fix non-working kbd.yoojin2014-07-081-1/+0
| | | | | | | | | | | | | | | | | | | | | | KBD didn't work partly because holeless reset ic was changed. KBD's Column 2 line was inverted. So, KBD's Column 2 invert should be disable. BUG=chrome-os-partner:30086 TEST=emerge-winky chromeos-ec Check to wake up system by power button. Check function key on S0. Change-Id: I0e125362512361c5c908c74a0b139a40d018b104 Reviewed-on: https://chromium-review.googlesource.com/205913 Reviewed-by: YongBeum Ha <ybha@samsung.com> Tested-by: YongBeum Ha <ybha@samsung.com> Reviewed-by: Mohammed Habibulla <moch@chromium.org> Reviewed-by: yoojin lee <yoojin7.lee@samsung.com> Tested-by: yoojin lee <yoojin7.lee@samsung.com> Reviewed-by: Vincent Palatin <vpalatin@chromium.org> Commit-Queue: YongBeum Ha <ybha@samsung.com>
* winky : Skip to check temperature by diassert PWROKyoojin2014-07-081-0/+1
| | | | | | | | | | | | | | | | | | | | EC reset by i2c fail. EC should ignore to check temperature when PWROK was diasserted and thermal sensor was off BUG=chrome-os-partner:29907 TEST=emerge-winky chromeos-ec Check system boot on winky and temperature on S0. Change-Id: I52cab9470b1b82ea257020f95f62cc67099788f1 Reviewed-on: https://chromium-review.googlesource.com/205902 Reviewed-by: YongBeum Ha <ybha@samsung.com> Reviewed-by: yoojin lee <yoojin7.lee@samsung.com> Tested-by: YongBeum Ha <ybha@samsung.com> Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-by: Mohammed Habibulla <moch@chromium.org> Commit-Queue: yoojin lee <yoojin7.lee@samsung.com> Tested-by: yoojin lee <yoojin7.lee@samsung.com>
* BayTrail: Set the default USB charge mode to CDPDave Parker2014-07-0712-0/+12
| | | | | | | | | | | | | | | | This reflects the reality of what we have been doing already. The earlier default mode of SDP2 was actually CDP due to an inversion in the ILIM control line. BUG=chrome-os-partner:29053 BRANCH=None TEST=Boot a baytrail board and verify that the 'usbchargemode' command indicates CDP charging. Change-Id: Ia061d45512d1f90c68fd02b3197c414961b78a7c Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/205813 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* USB Power: Add config option to set default charge modeDave Parker2014-07-072-2/+12
| | | | | | | | | | | | | BUG=chrome-os-partner:29053 BRANCH=ToT TEST=Set a default change mode other than SDP2 in a board config. Verify the 'usbchargemode' console command indicates the ports are operating in that mode. Signed-off-by: Dave Parker <dparker@chromium.org> Change-Id: I4a65d8b6ad14ff3d1f12b644960bbf401027f8df Reviewed-on: https://chromium-review.googlesource.com/205812 Reviewed-by: Vic Yang <victoryang@chromium.org>
* USB Power: Invert ILIM control line with 'smart simple' chargingDave Parker2014-07-071-3/+3
| | | | | | | | | | | | | | | | | The ILIM control line is inverted before reaching the USB charge controllers when they are cross-connected to allow only one port to deliver the HIGH current limit at a time. BUG=chrome-os-partner:29053 BRANCH=ToT TEST=Verify, with a multimeter, that ILIM (pin 4) on a TPS2546 is 3.3V when the chargemode is set to CDP Change-Id: Idd89dcfc117f1f3393ded1887e8d1cb27ba367ad Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/205811 Reviewed-by: Vic Yang <victoryang@chromium.org> Reviewed-by: Randall Spangler <rspangler@chromium.org>
* Tiny: Remove keyscan taskDave Parker2014-06-271-2/+1
| | | | | | | | | | | | | | The keyscan task is not needed on Tiny. BUG=chrome-os-partner:29504 BRANCH=None TEST=Verify power button works correctly and keyscan task isn't listed under 'taskinfo'. Change-Id: I34e8782aa4aeffe700c914826287ff1dfefcd186 Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/203104 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* Config: Allow keyproto task to run without keyscan definedDave Parker2014-06-261-5/+0
| | | | | | | | | | | | | | | Allow devices to send power button keyboard events without having an internal keyboard defined. BUG=chrome-os-partner:29504 BRANCH=None TEST=Build and run on a peppy. Verify keyboard protocol messages are still sent for the power button using evtest. Change-Id: Ibfaa1a779552bdc5a643911703e7900bbc1d51d7 Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/203103 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* Rambi: Increase adapter input current limit to 1894mADave Parker2014-06-201-1/+1
| | | | | | | | | | | | | | | | | This sets the adapter current limit to 90% of the rating for a 40W adapter. The earlier limit was based on a 33W adapter which was not used. BUG=chrome-os-partner:23833 BRANCH=ToT TEST=With a 20-80% charged battery run 4000 fish (search for WebGl Aquarium) with backlight at 100%. Verify ChargerCurrent is around the limit with 'adc' command on EC serial console. Change-Id: I6279d0a3502142348b79425e56cfc25bf75432b5 Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/204893 Reviewed-by: Todd Broch <tbroch@chromium.org>
* Expresso: Increase adapter input current limit to 1894mADave Parker2014-06-201-1/+1
| | | | | | | | | | | | | | | | | This sets the adapter current limit to 90% of the rating for a 40W adapter. The earlier limit was based on a 33W adapter which was not used. BUG=chrome-os-partner:23833 BRANCH=None TEST=With a 20-80% charged battery run 4000 fish (search for WebGl Aquarium) with backlight at 100%. Verify ChargerCurrent is around the limit with 'adc' command on EC serial console. Change-Id: I4e2270dd1cb774681383105d88869dc7022a9fb7 Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/204932 Reviewed-by: Todd Broch <tbroch@chromium.org>
* Kip: Modify battery LED behavior.Devin Lu2014-06-171-6/+9
| | | | | | | | | | | | | | | | | | | | | | | We won't to see the corner case when plugging in adpater. if battery want to charge, we want to see the amber led directly when plugging in adapter, not white to amber. if battery into fully charged, we want to see the white led directly when plugging in adapter, not amber to white. BUG=None BRANCH=rambi TEST=manual Check battery LED show amber directly when plugging in adpater, if battery needs to charge. Check battery LED show white directly when plugging in adpater, if battery into fully charged. Check battery LED show white directly when plugging in adpater, if battery near full. Change-Id: I08e6c9ea32dc90599a974d7b5fadaf59f549cc77 Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/203932
* Enguarde: Enable PWM module in deep sleepDave Parker2014-06-141-0/+1
| | | | | | | | | | | | | | | This prevents erratic blinking of the charging LED while in G3. BUG=chrome-os-partner:29577 BRANCH=enguarde TEST=Shutdown machine and type 'dsleep 0' in the serial console to force deep sleep mode. Verify the charging LED doesn't flash erratically. Change-Id: Ibc6af84f9f35e4ba3893269d9a306e4b5e99f70a Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/203850
* Expresso: Enable PWM module in deep sleepDave Parker2014-06-141-0/+1
| | | | | | | | | | | | | | | This prevents erratic blinking of the charging LED while in G3. BUG=chrome-os-partner:29577 BRANCH=expresso TEST=Shutdown machine and type 'dsleep 0' in the serial console to force deep sleep mode. Verify the charging LED doesn't flash erratically. Change-Id: I4912cde058f54266a2701155d08817f648bc72de Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/203802
* Rambi: Enable PWM module in deep sleepDave Parker2014-06-141-0/+1
| | | | | | | | | | | | | | | This prevents erratic blinking of the charging LED while in G3. BUG=chrome-os-partner:29577 BRANCH=ToT TEST=Shutdown machine and type 'dsleep 0' in the serial console to force deep sleep mode. Verify the charging LED doesn't flash erratically. Change-Id: I6bdbf324ac9189a5f135523318d171df9d476b0d Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/203862
* Swanky: Support ectool to control power led on/off.Aaron Weng2014-06-091-4/+15
| | | | | | | | | | | BUG=None BRANCH=rambi TEST=make buildall -j and ectool led power off/white work normally. Signed-off-by: Aaron Weng <aaron.weng@quantatw.com> Change-Id: I86aa3cabf7c38e449c241ad058eb31497ec64e8e Reviewed-on: https://chromium-review.googlesource.com/202905 Reviewed-by: Dave Parker <dparker@chromium.org>
* Swanky: To implement power led.Aaron Weng2014-06-064-5/+36
| | | | | | | | | | | BUG=chrome-os-partner:29077 BRANCH=rambi TEST=make buildall -j and power led can be operated normally. Change-Id: Iaf69859fdaa6e511d8e19810f38bed85209a226c Signed-off-by: Aaron Weng <aaron.weng@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/202655 Reviewed-by: Dave Parker <dparker@chromium.org>
* Gnawty:Update 3 cell battery parameter to meet SPEC.Jimmy Lin2014-05-301-2/+2
| | | | | | | | | | | | | | BUG=none BRANCH=gnawty TEST=To check the battery can be charging normally. Signed-off-by: Jimmy Lin <jimmy.Lin@quantatw.com> Change-Id: I8e76e454bb4be66ce44b9aa80c9971afa1448e50 Reviewed-on: https://chromium-review.googlesource.com/202211 Tested-by: 挺倫 林 <jimmy.lin@quantatw.com> Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Queue: Dave Parker <dparker@chromium.org>
* Swanky: To implement battery shipping mode.Aaron Weng2014-05-301-6/+76
| | | | | | | | | | | | | | | | | According Battery pack SPEC, the battery shipping mode set condition must be meet below items. 1.AC adaptor attached. 2.The each cell voltage is under 4000mV. BUG=chrome-os-partner:29077 BRANCH=rambi TEST=The battery pack can be set shipping mode and wake up from shipping mode success by ectool batterycutoff command. Change-Id: I80439040021a82e5635c22546f725a70b47a863f Signed-off-by: Aaron Weng <aaron.weng@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/201815 Reviewed-by: Dave Parker <dparker@chromium.org>
* Gnawty:Add 15 ms delay before turning off PP3300_DX at S0->S3.Jimmy Lin2014-05-291-1/+11
| | | | | | | | | | | | | | BUG=chrome-os-partner:29024 BRANCH=gnawty TEST=We try to used the 10 ms and 13 ms delay. But the T11 still fail.The 15 ms is minimum pass criteria. Change-Id: I96cb3a6c72d25db02aafcd07e366f12f389f91c9 Signed-off-by: Jimmy Lin <jimmy.Lin@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/202030 Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Queue: Dave Parker <dparker@chromium.org> Tested-by: Dave Parker <dparker@chromium.org>
* Add 'tiny' board based on RambiDave Parker2014-05-268-0/+649
| | | | | | | | | | | | | | Copy, paste, and rename of Rambi. Customization will be done in follow-up patches. BUG=None BRANCH=None TEST=make buildall -j Change-Id: I43397bc6bc2155613b6e02b47fa6febaa439b376 Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/198321 Reviewed-by: Mohammed Habibulla <moch@chromium.org>
* Kip: fix for EC has very slow reset.Devin Lu2014-05-232-0/+3
| | | | | | | | | | | | | | Add battery present pin. BUG=none BRANCH=rambi TEST=manual To check the system reset normally without battery attached. Change-Id: Id3ed19a3464045cc56d8bd7674cb2d6fb67df013 Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/200193
* Swanky: To change battery charging led color.Aaron Weng2014-05-162-14/+14
| | | | | | | | | | | | | | | | According battery physical led is orange color. So we change the color setting to orange. BUG=none BRANCH=rambi TEST=tested battery charging led color. Signed-off-by: Aaron Weng <aaron.weng@quantatw.com> Change-Id: I06cb3c1f6f3ca6c230acba1670760f5172447ff6 Reviewed-on: https://chromium-review.googlesource.com/200024 Tested-by: Aaron Weng <aaron.weng@quantatw.com> Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Queue: Aaron Weng <aaron.weng@quantatw.com>
* Swanky: fix for EC has very slow reset.Aaron Weng2014-05-122-0/+3
| | | | | | | | | | | | | | | Add the battery presense GPIO. BUG=chrome-os-partner:28713 BRANCH=rambi TEST=To check the system reset normally without battery attached. Change-Id: Id21cc7dd624719b686d7d23bbcae50b4cbe8dc31 Signed-off-by: Aaron Weng <aaron.weng@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/199288 Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Queue: Dave Parker <dparker@chromium.org> Tested-by: Dave Parker <dparker@chromium.org>
* Swanky: Initial 3 cell battery parameter.Aaron Weng2014-05-081-6/+6
| | | | | | | | | | | | | | BUG=chrome-os-partner:28448 BRANCH=rambi TEST=To check the battery can be charging normally. Change-Id: I3c23b464b53e9449a462b130ecd0ee5dffa570f2 Signed-off-by: Aaron Weng <Aaron.Weng@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/198149 Reviewed-by: Aaron Weng <aaron.weng@quantatw.com> Reviewed-by: Dave Parker <dparker@chromium.org> Commit-Queue: Dave Parker <dparker@chromium.org> Tested-by: Dave Parker <dparker@chromium.org>
* clapper: glimmer: fix for keyboard occasionally disabled on wakeAlec Berg2014-05-061-11/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes bug in which the keyboard remains disabled after resuming. The problem occurs when the lidangle_keyscan_update() occurs after the CHIPSET_RESUME hook triggers and before chipset state is CHIPSET_STATE_ON, and the lid angle is in range to disable the keyboard. The fix is to not use a hook at all on chipset resume, and instead just keep track of the last chipset state locally in lidangle_keyscan_update(). That way we guarantee that when the AP is turned on, the next time we check for lidangle keyscanning state, it will enable the keyboard. BUG=chrome-os-partner:28480 BRANCH=rambi TEST=tested on a glimmer: Added a hook to detect chipset resume in lid_angle.c: static void enable_keyboard(void) { hook_fired = 1; } DECLARE_HOOK(HOOK_CHIPSET_RESUME, enable_keyboard, HOOK_PRIO_DEFAULT); Then in lidangle_keyscan_update() added: if (hook_fired && !chipset_in_state(CHIPSET_STATE_ON)) ccprintf("Hook fired, but chipset state still reads off\n"); hook_fired = 0; Using this code, I used the lid switch on the servo board to open and close the lid repeatedly until I saw the printf above. Without this CL, when the printf is shown, the keyboard remains disabled in S0. With this CL, the keyboard is enabled in S0. Change-Id: Iac017a6468d46e0f011ec9d84a8c73b89622d8cc Signed-off-by: Alec Berg <alecaberg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/198285 Reviewed-by: Randall Spangler <rspangler@chromium.org>
View Lorry Controller Status