summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* i2c_master: extend i2c_xfer_no_retry to also support large writestabilize-13605.B-masterTing Shen2020-11-178-40/+51
| | | | | | | | | | | | | | | | | This CL extends CONFIG_I2C_XFER_LARGE_READ to also support large (greater than 255 bytes) write. Related config name is also updated to reflect the behavior change, BUG=b:169651794 TEST=flash fw successfully on Zed. BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: Icb889013da01f48708cd0227207561b8186bac63 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2537412 Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* mkbp_event: Always mark MKBP interrupt as inactive before setting it againPatryk Duda2020-11-171-3/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes issue with sensors data not flowing to the AP after ChromeOS reboot. Issue occurs when ChromeOS doesn't disable sensor FIFO interrupt. During ChromeOS reboot, EC sends MKBP event to host, but event can't be served. Hook task calls force_mkbp_if_events(), scheduled by activate_mkbp_with_events(). Called function sets state.interrupt to INTERRUPT_INACTIVE and calls active_mkbp_with_events() to set MKBP interrupt again (again force_mkbp_if_events() is scheduled). This is repeated 2 times only (limited by state.failed_attempts). After 3 attempts to generate MKBP interrupt force_mkbp_if_events() function is not changing state.interrupt to INTERRUPT_INACTIVE. As a result calling activate_mkbp_with_events() doesn't set MKBP interrupt and doesn't schedule force_mkbp_if_events() to be called by hook task. When ChromeOS is running, EC is not able to send MKBP interrupt again, because it is blocked by INTERRUPT_ACTIVE state. The only way to change interrupt state is call EC_CMD_GET_NEXT_EVENT host command which will eventually call set_inactive_if_no_events(). This host command is called by host only when it receives MKBP interrupt. This patch fixes vicious circle by setting state.interrupt to INTERRUPT_INACTIVE in force_mkbp_if_events() always and calling activate_mkbp_with_events() only when failed_attempts counter doesn't exceed limit. It is safe to mark interrupt state as INACTIVE, because force_mkbp_with_events() function can be only scheduled by activate_mkbp_with_event() which will set interrupt state to ACTIVE (if there are still events waiting). Furthermore, failed_attempts counter is only reset when AP actually pulls all of the events or number of attempts is exceeded. BUG=b:162254118 BRANCH=none TEST=Flash EC ToT on eve. Boot ChromeOS then reboot it. Switch to developer console and check if sensors works by calling following command: 'local_test_runner -waituntilready false hardware.SensorRing' Signed-off-by: Patryk Duda <pdk@semihalf.com> Change-Id: Ic6acf44770aba8d5d00f070de256751128171205 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2527171 Reviewed-by: Jett Rink <jettrink@chromium.org>
* Metaknight: Support USB-AYu-An Chen2020-11-173-6/+22
| | | | | | | | | | | | | | | | config USB-A pin define, and enable USB SMART function BUG=b:169615752 BRANCH=master TEST=make BOARD=metaknight Signed-off-by: Yu-An.Chen@quanta.corp-partner.google.com Change-Id: I1a4d45952f40304ea8374991dc4ee2e648e566c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2505404 Tested-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Reviewed-by: Henry Sun <henrysun@google.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Diana Z <dzigterman@chromium.org> Auto-Submit: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
* fw_update: Pass bytes into `wr_command` functionYilin Yang2020-11-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | In `wr_command` function, we use `bytearray` to wrap the bytes argument. However, if we pass a `str` type to `bytearray` constructor, we need to specify the encoding. In this case, we need to use `bytes` here. BUG=b:172978731 BRANCH=master TEST=1. cros_workon --host start hdctools ec-devutils 2. sudo emerge hdctools ec-devutils 3. The fix applies into chroot TEST=ODM verifies in their side Signed-off-by: kerker <kerker@chromium.org> Change-Id: I57609c36e639cd6bd116b6f2f3a1baff02312070 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2543567 Tested-by: Henry Sun <henrysun@google.com> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Henry Sun <henrysun@google.com>
* TCPM: Add OCP moduleDiana Z2020-11-1710-198/+281
| | | | | | | | | | | | | | | | | | | | Currently, the overcurrent protection is tracked in the PPC code. However, as different chips are able to report overcurrent move this code into a generic module. Logic for not sourcing Vbus or Vconn on latched ports moves into the TC layer, and an overridable board overcurrent function is provided for boards which have no special actions to take. BRANCH=None BUG=b:171501161 TEST=make -j buildall; TCPMv2 tested with following drawcia patch Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I75919e345a5b0bce4a0b67432a13515e7716cf6a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2532676 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* chip/mt8192_scp: update memory mapTzung-Bi Shih2020-11-171-5/+5
| | | | | | | | | | | | | | | | Updates memory maps. SCP view 0x1000_0000 maps to AP view 0x5000_0000. SCP view 0xf000_0000 maps to AP view 0x6000_0000. BRANCH=none BUG=b:156222459 TEST=make BOARD=asurada_scp Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org> Change-Id: Ia837af7ee00bd6d4ec21be7533037667f680d29d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2531754 Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
* chip/mt8192_scp: remove confusing commentsTzung-Bi Shih2020-11-171-2/+1
| | | | | | | | | | | | BRANCH=none BUG=b:156222508 BUG=b:156222459 TEST=make BOARD=asurada_scp Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org> Change-Id: Icda539485e630c2e14a38e182f3b3c3a2959cec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2534435 Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
* asurada_scp: add MPU settingsTzung-Bi Shih2020-11-172-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | SRAM (for most code, data): {0, 0x0ffc00} SRAM (for IPI shared buffer): {0x0ffc00, 0x100000} For AP domain: {0x60000000, 0x70000000} For SCP sys: {0x70000000, 0x80000000} BRANCH=none BUG=b:156222508 BUG=b:156222459 TEST=make BOARD=asurada_scp Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org> Change-Id: I0939f973d924b8e031635cdb90cdee749a694eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2526851 Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
* chip/mt8192_scp: support RAM cacheTzung-Bi Shih2020-11-175-0/+212
| | | | | | | | | | | | | | | | | Supports RAM cache for: - L2TCM - System DRAM BRANCH=none BUG=b:156222459 BUG=b:156222508 BUG=b:172886808 TEST=manually check assembly code Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org> Change-Id: I3fd3d8f858a172bf26dfec6a5c6c403d73164039 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2513414 Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
* common: embed IPI shared buffer address in ELFTzung-Bi Shih2020-11-172-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Embeds IPI shared buffer address in ELF. Creates a NOBITS segment for holding the address. E.g.: $ /opt/coreboot-sdk/bin/riscv64-elf-readelf -l build/asurada_scp/ec.obj Program Headers: Type Offset VirtAddr PhysAddr FileSiz MemSiz Flg Align LOAD 0x001000 0x00000000 0x00000000 0x08180 0x08180 R E 0x1000 LOAD 0x009180 0x00008180 0x00057fff 0x00001 0x00001 RW 0x1000 LOAD 0x000db0 0x000ffdb0 0x000ffdb0 0x00000 0x00250 RW 0x1000 LOAD 0x00a000 0x50000000 0x50000000 0x00180 0x00180 R E 0x1000 Section to Segment mapping: Segment Sections... 00 .image.RW 01 .padding 02 .ipi_buffer 03 .image.RW.dram The .ipi_buffer is at 0x000ffdb0 and its size 0x00250. BRANCH=none BUG=b:156222508 BUG=b:156222459 TEST=make BOARD=asurada_scp Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org> Change-Id: I574fafcfaa990da8c42388554945da6725e12264 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2534230 Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
* asurada_scp: re-layout memory regionsTzung-Bi Shih2020-11-171-13/+10
| | | | | | | | | | | | | | | | | Uses the bottom-most (288 + 8) * 2 bytes for IPI shared buffer. - IPI ID (4 bytes) - IPI payload length (4 bytes) - IPI payload (288 bytes) BRANCH=none BUG=b:156222508 BUG=b:156222459 TEST=make BOARD=asurada_scp Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org> Change-Id: Iaec5977c602e92ff66e416d67a3d1b78b729173d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2519244 Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
* system: Add EC_REBOOT_COLD_AP_OFF commandPi-Hsun Shih2020-11-173-3/+12
| | | | | | | | | | | | | | | | | | | | | | | | Add EC_REBOOT_COLD_AP_OFF as a command of EC_CMD_REBOOT_EC host command, that would cold reboot EC without booting AP. BUG=chromium:1121907 TEST=With CL:2422025 CL:2459802, echo 1 > /var/lib/power_manager/reset_ec_on_next_shutdown click shutdown on UI and observe that EC is rebooted and AP is still off. TEST=With CL:2422025 CL:2459802, echo 1 > /var/lib/power_manager/reset_ec_on_next_shutdown dbus-send --system --print-reply --dest=org.chromium.PowerManager \ /org/chromium/PowerManager \ org.chromium.PowerManager.RequestRestart \ int32:0 string:test observe that EC is rebooted. Change-Id: Ifccff3831d785091b7c99def0e43a0d20bfc412b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2428361 Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> Tested-by: Pi-Hsun Shih <pihsun@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* Fleex: enable 2nd ppc source syv682xMatt_Wang2020-11-173-3/+63
| | | | | | | | | | | | | | | | | This patch adds 2nd ppc source syv682x base on GPIO97 status. BUG=b:160139798 BRANCH=octopus TEST=The GPIO97 high can switch PPC from NPX to syv682x code. Change-Id: If813ed6993338981417d7271bf0920f15bdb5e1a Signed-off-by: Matt_Wang <Matt_Wang@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2291451 Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Marco Chen <marcochen@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Tested-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Commit-Queue: Matt Wang <matt_wang@compal.corp-partner.google.com>
* TCPMv2: Fix compiler dependency of USB_PD_TRY_SRCScott Collyer2020-11-171-5/+4
| | | | | | | | | | | | | | | | | | This CL fixes a couple minor issues where usb_tc_drp_acc_trysrc_sm.c won't compile correctly unless CONFIG_USB_PD_TRY_SRC is defined. This fix takes advantage of the __maybe_unused pragma so that #ifdef guards are not required. BRANCH=None BUG=b:169812364 TEST=Build quiche without CONFIG_USB_PD_TRY_SRC defined. Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: Ibe8fc5fb765162d4b006b619b907aa35b5e1e73a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2531182 Tested-by: Scott Collyer <scollyer@chromium.org> Commit-Queue: Scott Collyer <scollyer@chromium.org> Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* Waddledoo: Define CONFIG_CHIP_INIT_ROM_REGIONDiana Z2020-11-171-4/+7
| | | | | | | | | | | | | | | | Waddledoo is almost out of space on ToT, so move the init data region to free up some flash. BRANCH=None BUG=None TEST=make -j buildall; see that we report 1.6k free flash space for Doo now Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I9eb713777c9767475933a603dd57e88fa33ea46a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2540388 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* drobit: Iinital TCPC configurationsJacky Wang2020-11-173-224/+26
| | | | | | | | | | | | | | | | | | Base on schematic, Update TCPC configurations. 1. The TCPC using rt1715 for C0 and C1. 2. Change PPC from sn5s330 to syv682x for C0. 3. Support retimer Intel Burnside Bridge for C0 and C1. BUG=b:172305295 BRANCH=firmware-volteer-13521.B TEST=make BOARD=drobit Check TCPC init ready and PPC init'd Signed-off-by: Jacky Wang <jacky5_wang@pegatron.corp-partner.google.com> Change-Id: I0e81ca5077f20104f62dbb80abe1aa347e91b765 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2534430 Reviewed-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* shuboz: Remove daughter board OPT2Michael5 Chen2020-11-173-172/+11
| | | | | | | | | | | | | | | | | Depend on schematic, remove DB OPT2. BUG=b:172129786 BRANCH=none TEST=make BOARD=shuboz Check EC log (TCPC init ready and ppc init'd). Check TypeC function (PD and USB device). Check TypeA USB device detect. Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com> Change-Id: I13345c22890bd6281e50d29bef1562ca67b75f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2513409 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org>
* dooly: update gpioZick Wei2020-11-171-1/+3
| | | | | | | | | | | | | | | | | | | | This patch add a gpio to allow EC disable EDID rom write protect, which will only be use in factory script. low: disable write protect, EC can access EDID rom. high: enable write protect, EC can't access EDID rom. BUG=b:171822443 BRANCH=puff TEST=make BOARD=dooly Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I6ad94dcda14a524e2b3b1d58d6593dfc022d2002 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2535902 Reviewed-by: Edward O'Callaghan <quasisec@chromium.org> Reviewed-by: Andrew McRae <amcrae@chromium.org> Commit-Queue: Andrew McRae <amcrae@chromium.org>
* Coachz: Update the hall sensor GPIOs and interruptsWai-Hong Tam2020-11-173-6/+12
| | | | | | | | | | | | | | | | | | | | | Reflect the hall sensor change on the next hardware revision: * Wire GPIOD2, i.e. LID_OPEN_EC, to the lid hall sensor * Use GPIO73 as lid 360 detection * Different netnames * No reserse dock detection Add an empty interrupt for the kickstand hall sensors. Enable CONFIG_GMR_TABLET_MODE to handle lid 360. BRANCH=Trogdor BUG=b:168714440 TEST=Built the image correctly. Change-Id: I1eb35f6190c696e5a2598ef3ed7614c585c1173d Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2543110 Reviewed-by: Alexandru M Stan <amstan@chromium.org>
* Trogdor: Do not suppress CC_EVENT channel messagesWai-Hong Tam2020-11-171-1/+1
| | | | | | | | | | | | | | | The messages on CC_EVENT are not too noisy. They help debug. Do not suppress it. BRANCH=Trogdor BUG=b:168714440 TEST=Checked the CC_EVENT messages showing up, like [0.063848 event set 0x0000000000002000] Change-Id: I1036ce52ccea22ced73e7e0127b8777ca016325f Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2543109 Reviewed-by: Alexandru M Stan <amstan@chromium.org>
* Casta : Support Multi-ChargerYongBeum.Ha2020-11-1713-83/+129
| | | | | | | | | | | | | | | Casta needs to support 2 chargers(ISL9238 & BQ25710) BUG=b:168122776 BRANCH=firmware-octopus-11297.B TEST=None Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com> Change-Id: I18758acbd0920132c2958bf9d238b4eac3fb5b73 Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2428354 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
* genvif: field output ordering to be like specDenis Brockus2020-11-171-48/+48
| | | | | | | | | | | | | | BUG=b:172293518 BRANCH=none TEST=verify XML output Signed-off-by: Denis Brockus <dbrockus@google.com> Change-Id: Ibf433a6d6472c2c3a4422f4a9d757196be7884ce Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2538258 Tested-by: Denis Brockus <dbrockus@chromium.org> Auto-Submit: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* Ezkinil: Update thermal table and fan tableSue Chen2020-11-161-14/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Control the fan speed by the temperature read by TEMP_SENSOR_SOC. thermal_soc: fan_off = 32C, fan_on = 75C fan_rpm: min = 3200, start = 3200, max = 6000 fan_table: on off rpm 0 1(32C) 0 9(36C) 1(32C) 3200 21(41C) 16(35C) 3500 28(44C) 29(39C) 3900 37(48C) 42(43C) 4200 47(52C) 55(47C) 4600 56(56C) 68(51C) 5100 72(63C) 84(58C) 5500 BUG=b:153937447 BRANCH=zork TEST=none Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I97195bb027d292b0240bdcc140393f87399e7a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2528729 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* elemi: Remove unused daughterboard configurationDevin Lu2020-11-162-187/+20
| | | | | | | | | | | | | | This patch remove unused daughterboard configuration since Elemi only support USB3 active doughterboard. BUG=b:173033778 BRANCH=firmware-volteer-13521.B-master TEST=Make sure daughterboard C1 port still works. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: I1fd856488652aa0be8d4f1ed171609c0fcfedf8d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2534438 Reviewed-by: Keith Short <keithshort@chromium.org>
* Dorp: Add CosMX B00C4473A9D0002 batteryDevin Lu2020-11-162-0/+30
| | | | | | | | | | | BUG=b:173334879 BRANCH=firmware-octopus-11297.B TEST=Test on charging/discharging/battery cut off pass. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: Ib204522d91d53cd82837e1c4a77ddcd1659ff640 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2537828 Reviewed-by: Diana Z <dzigterman@chromium.org>
* Lazor: Add a new SKU ID 6 for LimozeenWai-Hong Tam2020-11-161-5/+5
| | | | | | | | | | | | | | Add a new SKU ID 6 for Limozeen. BRANCH=Trogdor BUG=b:172019576, b:173320369 TEST=Built the image. Change-Id: Ieecf67a8fcbd97d059f8c8b525e3acbd3651963d Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2541142 Reviewed-by: Stephen Boyd <swboyd@chromium.org> Commit-Queue: Douglas Anderson <dianders@chromium.org>
* zephyr/tests: add zmake file for crc testJett Rink2020-11-161-0/+9
| | | | | | | | | | | | | | The zmake file allows us to use the zmake program to easily build this test BRANCH=none BUG=none TEST=use `zmake configure -b -B /tmp/build zephyr/test/crc` Signed-off-by: Jett Rink <jettrink@chromium.org> Change-Id: If1928c8c6705b4e8905e2f84eee896158a7510e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2540732 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* drawcia: Add Batteries CFET mask & val fieldDevin Lu2020-11-161-0/+18
| | | | | | | | | | | | | | This commit add the charge FET (CFET) field for OCPC. BUG=b:173174333 BRANCH=none TEST=On Drawcia. Cutoff battery and verify that CFET disable status is reflected after attached charger. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: Ifcd6fcedd8422e3b7af292c473a17328edf3d5c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2539228 Reviewed-by: Diana Z <dzigterman@chromium.org>
* drawlat: Add CosMX B00C4473A9D0002 batteryDevin Lu2020-11-162-0/+30
| | | | | | | | | | | BUG=b:173174333 BRANCH=none TEST=Test on charging/discharging/battery cut off pass. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: Ide3560ccbbbc0c65d5c3c72d8ed184d21271b860 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2537523 Reviewed-by: Diana Z <dzigterman@chromium.org>
* Lazor: Remove the bring-up featuresWai-Hong Tam2020-11-161-6/+0
| | | | | | | | | | | | | Remove all the bring-up features. BRANCH=None BUG=b:169736149 TEST=Built the image. Change-Id: Ic1175c11ffede2e1267c88b1932724b5c34a2424 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2538263 Reviewed-by: Stephen Boyd <swboyd@chromium.org>
* Trogdor: Move CONFIG_CMD_AP_RESET_LOG out of bringup listWai-Hong Tam2020-11-165-4/+1
| | | | | | | | | | | | | Move this CONFIG from bringup to production. BRANCH=None BUG=b:169736149 TEST=Built the image. Change-Id: I490499f3a85f91c6f07a0e099b8c0738bf0eb787 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2538262 Reviewed-by: Stephen Boyd <swboyd@chromium.org>
* PRESUBMIT: skip license check for third_party codeTom Hughes2020-11-161-0/+6
| | | | | | | | | | | | | | Intentionally including the directories separately since it's possible third party code added in the future could use the standard license. BRANCH=none BUG=b:169276911 TEST=CQ passes Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I238aa216c01a6b7749290e7287d4b9d4745da52b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2537011 Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
* lantis: Initial EC imageTony Huang2020-11-168-0/+1586
| | | | | | | | | | | | | | | | | | | Create the initial EC image for the lantis variant by copying the drawcia reference board EC files into a new directory named for the variant. (Auto-Generated by create_initial_ec_image.sh version 1.2.0). BUG=b:171546871 BRANCH=none TEST=make BOARD=lantis Signed-off-by: Tony Huang <tony-huang@quanta.corp-partner.google.com> Change-Id: I01eeb9dda6110f72aba4b253ac2ecca57f12bdd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2534437 Tested-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-by: Henry Sun <henrysun@google.com> Commit-Queue: Henry Sun <henrysun@google.com>
* shuboz: Config the EC battery setting.Michael5 Chen2020-11-163-90/+16
| | | | | | | | | | | | | | | | | Config the EC battery setting depend on battery spec. BUG=b:172182110 BRANCH=none TEST=make BOARD=shuboz Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com> Change-Id: I40323cf432c8ba379f5f644f9386640aa8355893 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2513412 Reviewed-by: Isaac Lee <isaaclee@google.com> Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Peter Marheine <pmarheine@chromium.org> Reviewed-by: Bhanu Prakash Maiya <bhanumaiya@google.com>
* Fennel: disable keyboard at tablet mode when in S3Mike Lee2020-11-162-0/+14
| | | | | | | | | | | | | | | | when in S3 and tablet mode, keyboard scan should be disabled and machine should not be waked up if user press keyboard BUG=b:173155379 BRANCH=firmware-kukui-12573.B TEST=put machine in tablet mode, use 'powerd_dbus_suspend' to let machine enter S3, press any key of keyboard cannot wake up machine Signed-off-by: Mike Lee <mike5@huaqin.corp-partner.google.com> Change-Id: I5e68d55e2d89aeab9b3920e3be520882c3b0e5bd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2537730 Reviewed-by: Chen-Tsung Hsieh <chentsung@chromium.org> Commit-Queue: Chen-Tsung Hsieh <chentsung@chromium.org>
* Zephyr: Migrate i2c implementation to chip family specific fileYuval Peress2020-11-162-1/+2
| | | | | | | | | | | | | | This change simply moves the i2c.c shim to i2c-npcx7.c. BRANCH=none BUG=none TEST=builds with zmake for volteer Signed-off-by: Yuval Peress <peress@chromium.org> Change-Id: Ic410787dcf2693dda71681f739c0b74cd47770da Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2532964 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Commit-Queue: Paul Fagerburg <pfagerburg@chromium.org>
* galtic: Initial EC imageMichael5 Chen2020-11-168-0/+1422
| | | | | | | | | | | | | | | | | | Create the initial EC image for the galtic variant by copying the waddledee reference board EC files into a new directory named for the variant. (Auto-Generated by create_initial_ec_image.sh version 1.2.0). BUG=b:172781886 BRANCH=none TEST=make BOARD=galtic Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com> Change-Id: Iad25f89a85e76132fa3175be6c963a40f2c0399e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2525256 Reviewed-by: Jacky Wang <jacky5_wang@pegatron.corp-partner.google.com> Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
* Metaknight: Add battery PC-VP-BP144Yu-An Chen2020-11-162-20/+22
| | | | | | | | | | | | | | Support new battery PC-VP-BP144 BUG=b:172390536 BRANCH=master TEST=Make sure battery can cutoff by console "cutoff" or "ectool batterycutoff" and resume by plug in adapter. Signed-off-by: yu-an.chen@quanta.corp-partner.google.com Change-Id: I11db98f37a27afd513a0f5adf04ff57a5eb2fbfe Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2526040 Reviewed-by: Diana Z <dzigterman@chromium.org>
* Tcpmv2: Handle transmission delay after Vccon swapPoornima Tom2020-11-141-0/+7
| | | | | | | | | | | | | | | | | | | While in PE state - PE_VCS_Send_Ps_Rdy_Swap,after successful vconn swap, it is expected to reset cable & receive the Accept/Reject Response. In case of more transmission delays, response_timer must be set, inorder to set the PE_FLAGS_TX_COMPLETE flag. BRANCH=None BUG=none TEST=Tested on ADL-RVP Signed-off-by: Poornima Tom <poornima.tom@intel.com> Change-Id: Ia7f7f183ad51c7500b4dc4629e6d2b17dddc8163 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2505399 Tested-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* sc7180: Fix forever loop if not enough power to boot APWai-Hong Tam2020-11-141-2/+5
| | | | | | | | | | | | | | | | | | | | When the power supply is not enough (<10W adapter and no battery) to boot AP, should clear the boot_from_off flag and go back to S5; otherwise, the boot_from_off flag will trigger the power-on again. Also do the same on power_on() sequence failed. Increase the delay of checking power, such that the messages are not too noisy. BRANCH=None BUG=b:167155164 TEST=Unplugged the battery, plugged a <10W adapter, checked the "Not enough power to boot (-1 %, 7500 mW)" message just showed 10x. Change-Id: Id7c5e66dab62bc71d3e2e00b3be172e13a146ed5 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2536554 Reviewed-by: Stephen Boyd <swboyd@chromium.org>
* zephyr: fix issue with set_event hanging before tasks startJett Rink2020-11-132-6/+44
| | | | | | | | | | | | | | Initialize the kernel objects before application code as a chance to run. This ensures that any event that is set before tasks start will get delivered (and won't crash the kernel). BRANCH=none BUG=none TEST=included unit test Signed-off-by: Jett Rink <jettrink@chromium.org> Change-Id: I84ecfddbe706e7e1860f310571851ee8dedd07d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2535984
* boten: add motion sensor interrupt config and matricesjerry2.huang2020-11-132-3/+18
| | | | | | | | | | | | | | | Add config for boten motion sensor's interrupt and matrices for rotate BUG=b:172290264 BRANCH=none TEST=buildall, flash ec to dut and boot to check the ectool command motionsense work normally. Signed-off-by: jerry2.huang <jerry2.huang@lcfc.corp-partner.google.com> Change-Id: I89e3f5d1c5e460ed26126c5d0489afde7c7843f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2515430 Reviewed-by: Henry Sun <henrysun@google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
* dirinboz: enable keyboard factory scanZick Wei2020-11-132-0/+24
| | | | | | | | | | | | | | This patch add for factory keyboard connector test. BUG=none BRANCH=zork TEST=short keyboard pins and make sure "ectool kbfactorytest" works. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Ia05e19d43205e3dae01898ef8a46f2d6266014bf Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2525251 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* common: motion_sense: Add spoofing activityChing-Kang Yen2020-11-136-34/+167
| | | | | | | | | | | | | | | | | | | | | | | | | | make spoof command able to spoof activity state: ectool motionsense spoof -- NUM activity ACT [EN] [0/1] This commit also remove unused parameter |sensor_num| from list_activities, set_activity, get_activity in ectool. BRANCH=None BUG=b:123434029 TEST=buildall TEST=ectool motionsense spoof 4 activity 4 1 0 ectool motionsense spoof 4 activity 4 ectool motionsense get_activity 4 ectool motionsense spoof 4 activity 4 1 1 ectool motionsense get_activity 4 ectool motionsense spoof 4 activity 4 0 ectool motionsense get_activity 4 ectool motionsense spoof 4 activity 4 1 ectool motionsense get_activity 4 Signed-off-by: Ching-Kang Yen <chingkang@chromium.org> Change-Id: I819c156ae7fe50c5cf6216d0f44012d192fb528e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2477393 Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
* dooly: update accel sensor matrixZick Wei2020-11-131-1/+7
| | | | | | | | | | | | | | | | This patch update accel sensor matrix for dooly. BUG=b:169636434 BRANCH=puff TEST=verify "ectool motionsense" in VT2, sensor value as intended. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: If957f7387b3c830b1f4a71e9490f677761ebd336 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2534233 Tested-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Reviewed-by: Andrew McRae <amcrae@chromium.org> Commit-Queue: Andrew McRae <amcrae@chromium.org>
* zephyr: forward cros_crc8 to zephyrs crc8 implJett Rink2020-11-137-0/+86
| | | | | | | | | | | | | | | Shim in support for crc8 used in CBI, I2C, and other applications within platform/ec BRANCH=none BUG=b:168032589 TEST=add unit test for platform/ec and zephyr based CRC8 approaches and verify they both pass. Signed-off-by: Jett Rink <jettrink@chromium.org> Change-Id: I9b6112cb83dab81a44a1ac020d4efb1b7bb1df5f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2532692 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* crc8: rename crc8 to cros_crc8 to to avoid zephyr conflictJett Rink2020-11-139-33/+35
| | | | | | | | | | | | | | | | | Zephyr already provides a robust implementation for crc8, but it conflicts with platform/ec's name of crc8. Rename platform/ec to use cros_crc8 instead since it is a special case of zephyr crc8 implementation. BRANCH=none BUG=b:168032589 TEST=builds. Just a rename Signed-off-by: Jett Rink <jettrink@chromium.org> Change-Id: I2dc509fe1c1d8c2a4cdec3943b63f29429919137 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2532691 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* crc32: rename test crc32->crc to allow for crc8Jett Rink2020-11-1310-10/+10
| | | | | | | | | | | | | | | Instead of creating a new test for crc8, just make the existing crc32 test more generic. BRANCH=none BUG=none TEST=none Signed-off-by: Jett Rink <jettrink@chromium.org> Change-Id: Ie630d4991d4e2c7dc441842c39d63fc0281ac809 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2532690 Reviewed-by: Tom Hughes <tomhughes@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* firmware_builder: add hardware test buildsJett Rink2020-11-131-2/+13
| | | | | | | | | | | | | | | | | We were not building the hardware test images as part for the test step. This replicate functionality in the chromeos-ec ebuid (via cros-ec eclass). I put a note in that ebuild to update this script if there are any changes in the future. BRANCH=none BUG=chromium:1147953 TEST=verify that firmware_builder.py --metrics /tmp/m test failed the same was the cq-orchestrator failed Signed-off-by: Jett Rink <jettrink@chromium.org> Change-Id: I20937381da41d933261926d02d45b80d3920443b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2535310 Reviewed-by: LaMont Jones <lamontjones@chromium.org>
* genvif: add genvif.h to dependsDenis Brockus2020-11-121-1/+1
| | | | | | | | | | | | | | | BUG=b:172293518 BRANCH=none TEST=make buildall Signed-off-by: Denis Brockus <dbrockus@google.com> Change-Id: Ib2d1443f19667beadca36b3ce726f02e4d0084b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2535671 Commit-Queue: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Abe Levkoy <alevkoy@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org> Auto-Submit: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>