summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* tcpmv2: Fix pd_set_suspend CC openstabilize-13768.B-mainEdward Hill2021-02-031-43/+45
| | | | | | | | | | | | | | | | | | | | | | | system_common_shutdown -> handle_pending_reboot was assuming that once pd_set_suspend returned, CC open had been achieved. This was not true, because pd_is_port_enabled saw get_state_tc return TC_DISABLED while tc_cc_open_entry was still waiting for its cflush to finish. Add TC_FLAGS_SUSPENDED to fix this, and ensure CC open timing is correct. Use tc_pause_event_loop in tc_disabled_run instead of task_wait_event(-1), to align with tc_low_power_mode_run. In tc_run, don't keep entering TC_DISABLED if we are already there. BUG=b:174526198 BRANCH=zork TEST=ectool reboot_ec cold at-shutdown Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I5db6da787049361dac43d1f03b7c1fea770dfb85 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2666523 Reviewed-by: Diana Z <dzigterman@chromium.org>
* make/util: Modularize util make var buildingCraig Hesling2021-02-034-22/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The key objectives are to * allow util targets to be added from outside of util/build.mk (for adding tools per board, like ectool_servo) * allow for easier conditioning of tool inclusion (for auto adding tools based on characteristic, like CHIP_NPCX) * reduce the number of tools being built (we can remove irrelevant tools for some boards, like removing stm32mon for npcx boards or iteflash for stm32 boards) We have tons of boards in EC now. This takes a significant amount of time to build, so we should be a bit more careful when adding utils for all boards. This and subsequent changes sets the precedent for selectivity. This shifts the initialization/control to the board and baseboard's build.mk and allows the util/build.mk to add items to these variables. Ideally, we would use multiple variables to aggregate the utils selection from the three sources (baseboard/build.mk, board/build.mk, and util/build.mk), but I don't think the addition complexity is currently warranted. BRANCH=none BUG=b:176500425 TEST=# Check all output artifacts from before and after this CL. make clobber make buildall STATIC_VERSION=1 -j mv build build-orig # Apply the change make clobber make buildall STATIC_VERSION=1 -j diff <(find build-orig | sed 's/build-orig//' | sort) <(find build | sed 's/build//' | sort) # Nothing should be different Signed-off-by: Craig Hesling <hesling@chromium.org> Change-Id: I23153850eda10fc1c88d386b9f3cd8296df9c6f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2606511 Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* copano: Config the GPIO setting for lid and tablet modeJacky Wang2021-02-031-2/+2
| | | | | | | | | | | | | | 1. Swap EC_LID_OPEN and TABLET_MODE_L GPIO setting. BUG=b:178953622 BRANCH=firmware-volteer-13672.B TEST=make BOARD=copano 1. Verified pass with factory test. Signed-off-by: Jacky Wang <jacky5_wang@pegatron.corp-partner.google.com> Change-Id: I38181719d46a543a3a7580aa6c96bce608b18462 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2662233 Reviewed-by: Keith Short <keithshort@chromium.org>
* Metaknight: Add thermal tableYu-An Chen2021-02-032-0/+38
| | | | | | | | | | | | | Add setup_thermal for setting thermal table BUG=b:178678269 BRANCH=main TEST=thermal team verify value on AP Signed-off-by: yu-an.chen@quanta.corp-partner.google.com Change-Id: I8b55a6e8c488e3a5eee713e6d73f908def3bec00 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2666558 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* TCPMv2: Store the cable's PD revision after soft reset SOP'Ayushee Shah2021-02-031-0/+11
| | | | | | | | | | | | | | | | | On soft reset SOP', the cable's PD revision is lost causing Thunderbolt and USB4 devices to downgrade. Hence, this patch retains the cable revision by storing it again after a soft reset SOP'. BUG=b:173725284 BRANCH=None TEST=No downgrade seen with USB4 with 100 continuous hotplugs Signed-off-by: Ayushee Shah <ayushee.shah@intel.com> Change-Id: I4498c6b397503058e5c4c2bce91e7d31960f6395 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2669418 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
* stm32: assume no vbnvJack Rosenthal2021-02-034-40/+2
| | | | | | | | | | | | | | | | | | CONFIG_HOSTCMD_VBNV_CONTEXT is deprecated and removed. Cleanup preprocessor statements to assume it's never defined. This makes CONFIG_STM32_RESET_FLAGS_EXTENDED obsolete, since it's now always defined, so that gets removed too. BUG=b:178689388 BRANCH=none TEST=buildall Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: Id040ce2ceca95ecde37de0014aafdbfd3087e00d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2668688 Reviewed-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Craig Hesling <hesling@chromium.org>
* voxel: Add keyboard backlight support by FW_CONFIGBen Chen2021-02-032-2/+19
| | | | | | | | | | | | | | switch keyboard backlight enable/disable by fw_config BIT14 BUG=b:162632407 BRANCH=none TEST=Set FW_CONFIG to 0x4000 and make sure "ectool inventory" had keyboard backlight present. Change-Id: I766b5179340c155a98fb854bba66e93f820d1e6b Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2662935 Reviewed-by: Keith Short <keithshort@chromium.org>
* grunt: Disable SBU on hibernateEdward Hill2021-02-031-0/+7
| | | | | | | | | | | | | | | | If CCD not active, set port 0 SBU_EN=0 to avoid power leakage during hibernation. BUG=b:175674973 BRANCH=grunt TEST=no power leakage during hibernate Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I05b8079aebc1282b9bb955bbf153c0fc2399bee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2668063 Tested-by: Peichao Wang <pwang12@lenovo.corp-partner.google.com> Reviewed-by: Mary Ruthven <mruthven@chromium.org> Reviewed-by: Peichao Wang <pwang12@lenovo.corp-partner.google.com>
* Lazor: modify KX022 standard matrix and I2C addressSue Chen2021-02-031-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | The position of KX022 on the lid (screen face up): ^ +z lid_standard_ref_kx022= | -- -- | | -1, 0, 0 | +x <----- | 0, -1, 0 | / | 0, 0, 1 | / -- -- +y < The address changes to 8-bit address 0x3C (7-bit: 0x1E) BUG=b:175663607 BRANCH=trogdor TEST=ectool motionsense display correctly on rework DUT with KX022 and ICM40608. Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: Iee87a9ce578e0d2fe6f06995f87057a16e38631f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2666559 Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Wai-Hong Tam <waihong@google.com>
* zephyr: driver: add cros_system driver and chip-reset causeWealian Liao2021-02-026-0/+159
| | | | | | | | | | | | | | | | | | | This CL introduces cros_system driver. Currently, Zephyr doesn't have the system related API (e.g., reset cause, system reset). Add a cros_system driver to put those system chip drivers. This CL adds reset cause function initially. BUG=b:178101173 BRANCH=None. TEST=zmake testall TEST=check reset cause by powerup, reset_pin, debug_rst, watchdog_rst Cq-Depend: chromium:2661921 Signed-off-by: Wealian Liao <whliao@nuvoton.corp-partner.google.com> Change-Id: I7c956c2a9c10f3be913400bb33d2f4002dcbabb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2657912 Reviewed-by: Simon Glass <sjg@chromium.org> Commit-Queue: Simon Glass <sjg@chromium.org>
* zephyr: add STATIC_IF* that work with KconfigYuval Peress2021-02-021-0/+20
| | | | | | | | | | | | | | | | | | | | This change adds implementations of STATIC_IF and STATIC_IF_NOT that work with Zephyr's Kconfig values. Note that when using COND_CODE_1 both extern and static have to be wrapped with parenthesis since COND_CODE_1 requires them and will strip them. BRANCH=none BUG=b:176828988, b:174481378 TEST=zmake testall TEST=make runhosttests Signed-off-by: Yuval Peress <peress@chromium.org> Change-Id: Ib7f61758fc34acf2f609cb395cfa33ce7c71d759 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2668869 Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
* README: Run mdformatTom Hughes2021-02-021-2/+2
| | | | | | | | | | | | BRANCH=none BUG=b:178648877 TEST=view in gitiles Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Ia1736c4fef0b76c752393462808b5af1da15801e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2668977 Commit-Queue: Diana Z <dzigterman@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* ec_commands: mark VBNV CONTEXT commands as deprecatedJack Rosenthal2021-02-021-1/+9
| | | | | | | | | | | | | | | | No current devices implement these commands, but there's still some external code (e.g., in depthcharge) that reference the constants. Mark it deprecated and we can remove once it's gone elsewhere. BUG=b:178689388 BRANCH=none TEST=buildall Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I221c18da588ee7cffced22563f3ea960aa9e7c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2668693 Reviewed-by: Edward Hill <ecgh@chromium.org>
* zephyr: remove BBRM_DATA_INDEX_VBNVCNTXTJack Rosenthal2021-02-021-2/+0
| | | | | | | | | | | | | No current devices use vbnv in EC BBRAM... delete. BUG=b:178689388 BRANCH=none TEST=zmake testall Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: Ie24e979c3879832cfba1ff7f468619f68377a4b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2668691 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* npcx: remove VBNVCNTXT storage in bbramJack Rosenthal2021-02-022-14/+5
| | | | | | | | | | | | | | Nothing uses this anymore, we can free up these indexes for future use. BUG=b:178689388 BRANCH=none TEST=buildall Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: Id7df3091edc3a8d8d07ebdfb0347a26a51389163 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2668690 Reviewed-by: Edward Hill <ecgh@chromium.org>
* it83xx: deprecate BRAM_IDX_NVCONTEXTJack Rosenthal2021-02-022-13/+1
| | | | | | | | | | | | | | | Unused, as VBNV storage in EC bbram is gone. This makes inxedexs 0x10 to 0x1F in bbram available for future use. BUG=b:178689388 BRANCH=none TEST=buildall Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I013bc2885f06aa853b1fbdabe98d9e5658811e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2668689 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* Add basic gitlab integrationSimon Glass2021-02-022-0/+57
| | | | | | | | | | | | | | | Add a configuration file so that new commits can be tested by gitlab. Also add a basic README for the Zephyr EC. BUG=b:178731498 BRANCH=none TEST=follow instructions in README.md Change-Id: Ibc3b4c5859e0b2e45ecd1c1518e096bc8272d155 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2657103 Reviewed-by: Yuval Peress <peress@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* RAA489000 : Change Charge Voltage StepYongBeum.Ha2021-02-021-1/+1
| | | | | | | | | | | | | Chagne CHARGE_V_STEP from 64mV to 8mV BUG=b:179098188 BRANCH=none TEST=make -j BOARD=sasuke Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com> Change-Id: Ia6e221cf4f91c8684c5ab152022ca767146da59b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2666311 Reviewed-by: Diana Z <dzigterman@chromium.org>
* sasuke : tune usb_eq and usb_gain on port 1YongBeum.Ha2021-02-021-0/+69
| | | | | | | | | | | | | | tune usb_eq and usb_gain on port 1 BUG=b:176862264 BRANCH=None TEST=make -j BOARD=sasuke update ec and check usb eq register Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com> Change-Id: Ief9bc8d545e94d2e4726ed61d12739e7e872aabc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2649895 Reviewed-by: Diana Z <dzigterman@chromium.org>
* nb7v904m : add function to tune eq and gainYongBeum.Ha2021-02-023-17/+86
| | | | | | | | | | | | | | add function to tune usb eq and gain BUG=b:176862264 BRANCH=None TEST=make -j BOARD=sasuke Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com> Change-Id: I50ff040643cd2635968c5cfb988998ad3a82a836 Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2649894 Reviewed-by: Diana Z <dzigterman@chromium.org>
* TCPMv2: Exit modes consistently on detachDiana Z2021-02-021-28/+16
| | | | | | | | | | | | | | | | | | | Currently, the TC can miss exiting modes during a power transition to S5 with a sinking DP dongle. Correct this and simplify the number of call locations needed by putting any mode exit on detach in the existing detach handler. BRANCH=None BUG=b:176213187 TEST=on drawcia, verify HPD is de-asserted when: - unplugging sinking DP dongle in S0 - unplugging sourcing DP dongle in S0 - powering off to S5 with sinking DP dongle Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I2f7f3b09c4fd875e26d6c5e71de1b3250526dbe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2662212 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* Jelboz360: Config the rotation matrix setting for X axis.Jacky Wang2021-02-021-2/+2
| | | | | | | | | | | | | | | | 1. Correct the rotation matrix for X axis direction. BUG=b:178451001 BRANCH=firmware-zork-13434.B TEST=make BOARD=shuboz 1. Using "ectool motionsense" check x/y/z value. 2. Using "ectool motionsense lid_angle" check angle. Signed-off-by: Jacky Wang <jacky5_wang@pegatron.corp-partner.google.com> Change-Id: I7e6b7742b6b306e7e34b961518de19cb366a26dc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2662864 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* pchg: Notify host of only device detection in suspendDaisuke Nojiri2021-02-021-11/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, pchg sends a host event for any event including charging update. This will prevent the host from staying in S3 while charging a peripheral device. This patch makes pchg notify the host only a device attach or detach event when the system is in S3/S0ix. Tested resume on detach as follows: 1. Verify system can suspend with a stylus attached. 2. Detach a stylus. 3. Verify system resumes. Tested resume on attach as follows: 1. Suspend with a stylus detached. 2. Attach a stylus. 3. Verify system resumes. BUG=b:177664326,b:173235954 BRANCH=trogdor TEST=CoachZ. See above. Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Change-Id: Icf7c6c46f94f27f1f24eb2ac9634d317bc14f4d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2665407 Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
* ps8815: Add workaround for incorrect CC linesKeith Short2021-02-022-1/+57
| | | | | | | | | | | | | | | | | | Add code to disable internal Rp detection in the PS8815 prior to presenting Rp. BUG=b:178664884 BRANCH=volteer TEST=make buildall TEST=Connect SNK devices to Delbin and observe PD contract established reliably. TEST=Connect dual-role USB-DP monitor, observe display comes up. Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: Ic1f58a7fc0e01a4c19c8d1de7fafda0b5d4551c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2659678 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
* COIL: Update documentation with appropriate branch namesDossym Nurmukhanov2021-02-021-11/+11
| | | | | | | | | | | | | | Branch names have changed as part of go/coil initiative. BUG=b:165682717 BRANCH=none TEST=none Signed-off-by: dossym@chromium.org Change-Id: I901984a7786ca31d4b8d85492fc4a7953080c6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2667026 Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* Remove CONFIG_HOSTCMD_VBNV_CONTEXTJack Rosenthal2021-02-023-46/+0
| | | | | | | | | | | | | | This is no longer set by any boards, and we don't intend to use it on future projects again. BUG=b:178689388 BRANCH=none TEST=buildall Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I7aa64d52bc197778873e7eb880961c37fb9f34e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2657721 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* zephyr: Enable base support for real-time-clock (RTC)Simon Glass2021-02-026-1/+246
| | | | | | | | | | | | | | | | | | | | | | | | Add Kconfig options for the various RTC features. Add stubs for the actual implementation, to be implemented using Zephyr API calls to the RTC driver, when available. The duplication of RTC functions across different chips can be addressed in b/179055201 Also add the <init.h> header to zephyr_host_command.h since otherwise we get a build error. It seems better to have the header there than in the files that use DECLARE_CONSOLE_COMMAND(). BUG=b:178230662, b:179055201 BRANCH=none TEST=build volteer for zephyr, try rtc and rtc_alarm command make BOARD=volteer -j8 Change-Id: I036b1f3d91543a357ad779e475a03584759a3de4 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2645570 Reviewed-by: Yuval Peress <peress@chromium.org> Commit-Queue: Yuval Peress <peress@chromium.org>
* asurada: remove IT5205H_OVP configTing Shen2021-02-021-1/+0
| | | | | | | | | | | | | | BUG=none TEST=`mux config:0, port:0, rv:36` disappear BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I514601b5c6e82805b861b9ca345052a76fcebb74 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2662513 Tested-by: Ting Shen <phoenixshen@chromium.org> Auto-Submit: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@chromium.org>
* voxel: disable tablet mode by fw_configBen Chen2021-02-022-15/+24
| | | | | | | | | | | | | Disable/Enable tablet mode by fw_config BUG=b:178456852 BRANCH=cros/main TEST=`make buildall` PASS Change-Id: I829b2486f63430ef7bf59bf582b914d33dae71c0 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2649885 Reviewed-by: Keith Short <keithshort@chromium.org>
* voxel: Remove CONFIG_SYSTEM_UNLOCKEDBen Chen2021-02-021-2/+0
| | | | | | | | | | | | | | Progressed enough in development that we no longer need to force an unlocked state on the EC. BRANCH=None BUG=b:178569971 TEST=make -j buildall Change-Id: I6574acc424509dec027c18898d1fe060b770ae03 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2663095 Reviewed-by: Keith Short <keithshort@chromium.org>
* Juniper: Fix juniper accel icm matrix.David Huang2021-02-021-1/+1
| | | | | | | | | | | | | Fix Juniper accel icm matrix. BUG=None BRANCH=kukui TEST=Check CTS-V accelerometer measurement tests pass. Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com> Change-Id: I6c9313b0efb6fc913016660a91c949db51b6f1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2662220 Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* copano: Config the rotation matrix setting for X axis.Jacky Wang2021-02-021-2/+2
| | | | | | | | | | | | | | | | 1. Correct the rotation matrix for X axis direction. BUG=b:176393206 BRANCH=firmware-volteer-13672.B TEST=make BOARD=copano 1. Using "ectool motionsense" check x/y/z value. 2. Using "ectool motionsense lid_angle" check angle. Signed-off-by: Jacky Wang <jacky5_wang@pegatron.corp-partner.google.com> Change-Id: Ic31b17419aed98a72eaa0a05a4b6f36127d62e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2662228 Reviewed-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* eldrid: update thermal tableScott Chao2021-02-021-14/+14
| | | | | | | | | | | | | | Update thermal table for settings provided by thermal team on 2021-01-29. BUG=b:178768749 BRANCH=firmware-volteer-13672.B-master TEST=make buildall TEST=test pass by thermal team Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: I60c3211b80ede4877c3469820519b2d62f2efbe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2620719 Reviewed-by: Keith Short <keithshort@chromium.org>
* aleena: Fix aleena accel icm matrix.David Huang2021-02-021-1/+1
| | | | | | | | | | | | | Fix aleena accel icm matrix. BUG=None BRANCH=grunt TEST=Check CTS-V accelerometer measurement tests pass. Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com> Change-Id: Ic340aa5df4e4121986c99828ac3a88b8ac68708f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2662219 Reviewed-by: Keith Short <keithshort@chromium.org>
* bb_retimer: add forward decl for usb_muxCaveh Jalali2021-02-011-0/+2
| | | | | | | | | | | | | | | This adds a forward declaration for struct usb_mux used in a function prototype. BRANCH=none BUG=none TEST=buildall passes Change-Id: I81b198c5bacacece565b2ec8797f2672654e4b1c Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2654739 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* util: Make sure hooks do not show external diff toolSimon Glass2021-02-012-2/+4
| | | | | | | | | | | | | | | | | At present when I 'repo upload' it opens meld and shows me all the changes I have made, sometimes many times. Add the --no-ext-diff flag to two up the pre-submit scripts to fix this. BUG=none BRANCH=none TEST=repo upload... see that meld does not run Signed-off-by: Simon Glass <sjg@chromium.org> Change-Id: Id48cc1654f681e19052298c1ab98911883c19318 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2665297 Reviewed-by: Mike Frysinger <vapier@chromium.org>
* dedede : adjust PCH_PWROK signalYongBeum.Ha2021-02-011-0/+1
| | | | | | | | | | | | | | Set PCH_PWROK to low when SLP_S3 is asserted BUG=b:178052179 BRANCH=none TEST=make -j BOARD=sasuke Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com> Change-Id: I6a1dcc146668334026bb01af06d1a11f9d2d6903 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2652829 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* Boten: Use cached Vbus presence for Vbus checkDiana Z2021-02-011-4/+1
| | | | | | | | | | | | | | | | Use the TCPCI driver cached Vbus presence when checking for Vbus. This avoids unnecessary TCPC wakes when tasks are querying our Vbus presence. BRANCH=None BUG=b:178173274 TEST=on boten, watch EC console and observe TCPC does not show repeated wakeups when C0 is in low power mode Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I1cf13c1fad95c559d1fa999852efd4c162a85be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2665007 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* zephyr: fix shimming pd interrupt taskDawid Niedzwiecki2021-02-011-3/+3
| | | | | | | | | | | | | | | | | PD interrupt task - pd_interrupt_handler_task function takes the port number from passed parameter(function argument), so pass a proper value. BUG=b:175434113 BRANCH=none TEST=build volteer on zephyr, run and see if connecting a charger to port 1 causes tcpc calls Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: I2cdf242275ba73b389a68f504e1995d6af710110 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2662988 Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* firmware_builder: style cleanupKevin Shelton2021-02-011-4/+8
| | | | | | | | | | | | | | | Apply style conformance changes in preparation for logic changes (formatting changes programmatically applied via yapf). BUG=b:176926834 TEST=None BRANCH=None Change-Id: If5236c068bbefa765c47c81a8580d35a89aef6d9 Signed-off-by: Kevin Shelton <kmshelton@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2664766 Commit-Queue: LaMont Jones <lamontjones@chromium.org> Reviewed-by: LaMont Jones <lamontjones@chromium.org>
* volteer: stub in fan for ZephyrKeith Short2021-02-015-0/+50
| | | | | | | | | | | | | | | | | Enable the PWM channel used for the cooling fan. This change forces the fan speed to 50% to provide active cooling until temperature sensors and a Zephyr fan API are available. BUG=b:174851463 BRANCH=none TEST=make buildall, zmake testall TEST=Load zephyr on Volteer, verify fan turns on when the AP is powered. Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: Iaad82e4c83ccfcda3d4cc33be6fcd550930c4caa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2637995 Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* volteer: enable keyboard backlight in ZephyrKeith Short2021-02-013-0/+15
| | | | | | | | | | | | | | | Enable the keyboard backlight for Zephyr builds on the Volteer board. BUG=b:17760430, b:177851031 BRANCH=none TEST=make buildall, zmake testall TEST=Run "kblight" command on Volteer Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I3414170c8579ee1f48bea391d9748bb382b867ba Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2657405 Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: Add keyboard backlight supportKeith Short2021-02-013-0/+34
| | | | | | | | | | | | | | Add KConfig options for keyboard backlight support. BUG=b:17760430, b:177851031 BRANCH=none TEST=make buildall, zmake testall TEST=Run "kblight" command on Volteer Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I7da36a7a685285562152e560f3dbe5da1b1ba04f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2636483 Reviewed-by: Simon Glass <sjg@chromium.org>
* zephyr: Add help for keyboard protocol select.Keith Short2021-02-011-0/+5
| | | | | | | | | | | | | | Add additional help to the keyboard protocol selection. BUG=b:167405015 BRANCH=none TEST=make buildall TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I2c01484c91a76f5e3551da1f3638ec7e5d6796e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2657404 Reviewed-by: Simon Glass <sjg@chromium.org>
* zephyr: move keyboard KConfig into separate fileKeith Short2021-02-012-58/+62
| | | | | | | | | | | | | | | | Reorganinze KConfig options related to keyboard support into a separate file. BUG=b:167405015 BRANCH=none TEST=make buildall TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I6052f9b0c9be85265f0d42ac69f855d9f6854b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2657403 Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* volteer: Add LED support for zephyr buildKeith Short2021-02-014-10/+15
| | | | | | | | | | | | | | | | Add LED support to zephyr builds on Volteer. BUG=b:174851299 BRANCH=none TEST=make buildall TEST=zmake testall TEST=Verify power and charging LEDs on Volteer. Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I5c39d407ee0d1aca91cbbd721b82073f0163f34f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2657402 Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: Add PWM LED supportKeith Short2021-02-018-0/+115
| | | | | | | | | | | | | | | Enable CONFIG_LED_COMMON and CONFIG_LED_PWM options for Zephyr BUG=b:174851299 BRANCH=none TEST=make buildall TEST=zmake testall TEST=Verify power and charging LEDs on Volteer. Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I90d5272921a254a1651baffbff00864f3ff02b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2636482 Reviewed-by: Simon Glass <sjg@chromium.org>
* ps8xxx: add forward declare usb_muxCaveh Jalali2021-02-011-0/+2
| | | | | | | | | | | | | | | This adds a forward declaration for struct usb_mux used in a function prototype. BRANCH=none BUG=none TEST=buildall passes Change-Id: I647c11b86dbed180bdd025063468ecdb651fd8a7 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2654738 Reviewed-by: Simon Glass <sjg@chromium.org> Commit-Queue: Simon Glass <sjg@chromium.org>
* zephyr: Add battery-backed RAM constants for npcxYuval Peress2021-02-011-0/+40
| | | | | | | | | | | | | | | | | Bring in the battery-backed RAM layout for npcx. This change includes a TODO to migrate these values to devicetree registers but since system.c is on the critical path, this will be a good step in the right direction. BRANCH=none BUG=b:176828988, b:174481378 TEST=zmake testall Signed-off-by: Yuval Peress <peress@chromium.org> Change-Id: Ib84bf4f680c74a95a8549f57c30dab7fca3db42c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2659681 Commit-Queue: Simon Glass <sjg@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org>
* zephyr: kohaku: Add required GPIOs for flash.c/system.cYuval Peress2021-02-011-0/+2
| | | | | | | | | | | | | | | | Add the required GPIO_* values for building with flash.c and system.c. BRANCH=none BUG=b:176828988, b:174481378 TEST=zmake testall Signed-off-by: Yuval Peress <peress@chromium.org> Change-Id: I5e1813c48e0847b89681461edc1f98869e98075d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2659680 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> Commit-Queue: Simon Glass <sjg@chromium.org>
View Lorry Controller Status