summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* hayato: Fix gyro sensor rotation mistakeMichael5 Chen12021-08-201-10/+12
| | | | | | | | | | | | | | | Because rotation matrix will be overwritten by function "update_rotation_matrix" when AP SW SYNC. Modify update_rotation_matrix condition to fix it. BUG=b:193752214 BRANCH=asurada TEST=Run "watch ectool motionsense lid_angle" Signed-off-by: Michael5 Chen1 <michael5_chen1@pegatron.corp-partner.google.com> Change-Id: Ia39265ed7acc1f3cb2cbd2fa3971a8dc65362779 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3106633 Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* Corori: Implement new battery parametersearlwang2021-08-202-79/+20
| | | | | | | | | | | | | | | | | Crori support C21N2018 new battery. This patch makes EC configure battery parameters differently based on battery name. BUG=b:196506846 BRANCH=keeby TEST=make -j BOARD=corori Signed-off-by: earlwang <earl_wang@compal.corp-partner.google.com> Change-Id: I4495cfcd4ba018f8934bdd651d0e776dcb4cc12e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3098115 Reviewed-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* Driblee: Initialize the vivaldi keyboardjohnwc_yeh2021-08-202-27/+3
| | | | | | | | | | | | | | | | Initialize vivaldi keyboard. BUG=b:195810621 BRANCH=keeby TEST=make BOARD=driblee Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Change-Id: If6041bb6a35b35cb8ce5750c1047d23a6978bad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3099385 Tested-by: Matt Wang <matt_wang@compal.corp-partner.google.com> Reviewed-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* driver: bmi260: integrate body detectionGwendal Grignou2021-08-201-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | Body detection is accelerometer agnostics. It was added in BMI260, but not finalized. Add list_activity function to enable/disable body detection. BRANCH=volteer BUG=b:195908820 TEST=Check cros-ec-activity is loaded. Enable proximity event: echo 1 > events/in_proximity_change_either_en Load iio_event_monitor, check we get events when moving device on lap to floor: Event: time: 925239910373, type: proximity, channel: 0, evtype: change, direction: falling Event: time: 945020001791, type: proximity, channel: 0, evtype: change, direction: rising ... Change-Id: I423c7044761d2addac36d435781ea19c1f1b18ed Signed-off-by: Gwendal Grignou <gwendal@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3097151 Tested-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-by: Ching-Kang Yen <chingkang@chromium.org> Commit-Queue: Gwendal Grignou <gwendal@chromium.org>
* spherion: enable USMEric Yilun Lin2021-08-202-1/+13
| | | | | | | | | | | | | | | | | | Ultrasonic Module(USM) is used for noise cancelling the buzzing sound while charging. The sound is louder if we have USB peripheral connected. We only enable this function in S0, and disable it in S3 because the power consumption is significant. BUG=b:185978753 TEST=make buildall BRANCH=asurada Change-Id: Ic2bfbf5a1364f5da6d776a1be56abb66934f9496 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3105905 Tested-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com>
* Mrbland: set TCPC product id as PS8805Siyu Qin2021-08-201-5/+1
| | | | | | | | | | | | | | | | Mrbland will only support TCPC PS8805, set the product id to PS8805 directly, following homestar. BRANCH=trogdor BUG=b:194737342 TEST=emerge-strongbad chromeos-ec Change-Id: I95a0dffb03d3448ba8f94ed27a96f4ec09ce586c Signed-off-by: Siyu Qin <qinsiyu@huaqin.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3090507 Reviewed-by: Bob Moragues <moragues@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Bob Moragues <moragues@chromium.org>
* Mrbland: Remove GMR_TABLET_MODE DEFINESiyu Qin2021-08-201-3/+0
| | | | | | | | | | | | | | | Mrbland has no GMR sensor for 360 tablet mode when keyboard attached, following homestar. BRANCH=Trogdor BUG=b:193475186 TEST=make -j BOARD=mrbland Change-Id: I1a449ab02c6b874b877efcef1f695ff6a4ec45b4 Signed-off-by: Siyu Qin <qinsiyu@huaqin.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3090505 Reviewed-by: Bob Moragues <moragues@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com>
* Mrbland: Remove CONFIG_DEVICE_EVENT DEFINESiyu Qin2021-08-201-1/+0
| | | | | | | | | | | | | | Follow homestar, mrbland doesn't have WLC and doesn't need it. BRANCH=trogdor BUG=None TEST=make BOARD=mrbland Signed-off-by: Siyu Qin <qinsiyu@huaqin.corp-partner.google.com> Change-Id: Ia6d30344219b44df3f4e5aa3c5d4ae760c577edd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3090228 Reviewed-by: Bob Moragues <moragues@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com>
* corori: Removed USB-A port 1 configurationMatt_Wang2021-08-203-18/+12
| | | | | | | | | | | | | | | | | Due to corori only support a USB-A port 0, so remove the USB-A port 1 configuration in board layer. BUG=b:197173555 BRANCH=keeby TEST=make BOARD=corori Signed-off-by: Matt_Wang <Matt_Wang@compal.corp-partner.google.com> Change-Id: I4fed93d7780a18ec627da7ef7e1935fdce240fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3105921 Tested-by: Matt Wang <matt_wang@compal.corp-partner.google.com> Commit-Queue: Matt Wang <matt_wang@compal.corp-partner.google.com> Reviewed-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* nipperkin: add battery supportZick Wei2021-08-202-71/+35
| | | | | | | | | | | | | | This patch add Cosmx and Simplo battery on nipperkin. BUG=b:196748143 BRANCH=none TEST=make BOARD=nipperkin Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I45718d0cab4527651e0369e3c6396b134c01dd4b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3097245 Reviewed-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-by: Rob Barnes <robbarnes@google.com>
* bugzzy : modify ECYongBeum.Ha2021-08-205-202/+399
| | | | | | | | | | | | | | Modify EC for buggzy based on schemetics. BUG=b:192521391,b:194554146 BRANCH=None TEST=make -j BOARD=bugzzy Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com> Change-Id: Ia0dad01f71c9a3db671427aadde286d18b2c1677 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3068484 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* mchp: Support RPM-PWM Fan controlmartin yan2021-08-202-4/+15
| | | | | | | | | | | | | | | | | | | Support RPM based Fan Control Algorithm via RPM-PWM hardware block BUG=none BRANCH=none TEST=Tested on ADL RVP and MCHP1727 MECC system via UART console faninfo, fanduty and fanset 1: Verify fan RPM from 3000 to 9000; 2: Verify 2-pole fan expected tach output (100Hz~300Hz) per RPM setting; 3: Verify expected PWM duty (3%~100%) per PWM duty setting; 4: Limit: can not reach 10000 RPM since RPM reaches 9000 in max as PWM duty is set as 100%; Signed-off-by: martin yan <martin.yan@microchip.corp-partner.google.com> Change-Id: Ib41a06a734821c9f70a45e25e2020c6492c61563 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3100926 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* zephyr: drop IS_ZEPHYR_VERSION macroJack Rosenthal2021-08-191-9/+0
| | | | | | | | | | | | | | As noted in the bug, this macro is an antipattern. Drop it. BUG=b:197159539 BRANCH=none TEST=zmake testall Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I2fa6515149ff31ae650ed4f3fdc65b111f62c5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3104788 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* mchp: Update RPM-PWM registers and configurationmartin yan2021-08-193-12/+23
| | | | | | | | | | | | | | | Update RPM-PWM block's registers and configuration as POR, RPM based Fan Control Algorithm via RPM-PWM hardware block is not supported or validated in previous mchp projects. BUG=none BRANCH=none TEST=Tested on ADL RVP and MCHP1727 MECC system via UART console Signed-off-by: martin yan <martin.yan@microchip.corp-partner.google.com> Change-Id: Ibe15dfbec4f2c2d4558d27c8b101345ad81a09f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3100925 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* run_host_test: some cleanupsJack Rosenthal2021-08-191-21/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | Chris suggested some good cleanups in CL:3105736, but this was just a firmware-branch cherry pick of a CL from >1yr ago. Making these changes on ToT instead. Summary of the changes: - Remove obsolete __future__ import since we only run on Python 3 now. - Use explicit 0, 1, 2, 3 exit codes for success, failure, timeout, and unexpected termination (respectively). This lets us drop a property. - Read from the process in unicode mode, since we just end up decoding later anyway. - verbose argument changed from counter to boolean since there's no additional behavior created by passing multiple times. BUG=none BRANCH=none TEST=make buildall -j32 Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: Ibc9de7d45f5ac1242429481c6bc5f303cdef6b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3107925 Commit-Queue: Chris McDonald <cjmcdonald@chromium.org> Reviewed-by: Chris McDonald <cjmcdonald@chromium.org>
* zephyr: zmake: organize the commit hashes a bit betterJack Rosenthal2021-08-192-4/+10
| | | | | | | | | | | | | | | | | | - Put EC repo first, since that's probably the most useful commit hash. - Put Zephyr kernel second, since that's probably the second most useful commit hash. - Put all other modules after that, alphasorted. BUG=b:184832251 BRANCH=none TEST=updated unit tests Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: Id14e9706980d733637e29643dd355aaa82a51fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3105265 Reviewed-by: Yuval Peress <peress@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: pull in the version string from zmakeJack Rosenthal2021-08-197-27/+180
| | | | | | | | | | | | | | | | | | | | | | Zmake computes a version string and stores it in FRID/FWID, but this was never plumbed all the way out into the version functionality in the OS, which was reporting the version generated by util/getversion.sh. Add a mechanism to generate the version header from zmake and replace the getversion.sh generation with that. BUG=b:184832251 BRANCH=none TEST=provided unit tests TEST=get this version string on posix-ec: posix-ec_v2.6.73347-cmsis:c3bd20,ec:c814a9,hal_stm32:f8ff8d,os:efe095 2021-08-18 14:10:18 jrosenth@germania Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: Idec1c5f8b5f014126706e4fdc1f3d158edf40a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3104625 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* Revert "storo: update EC thermal table"Mike Lee2021-08-192-37/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 9193fc043f70b7fa657e30605ec18b1f548b2ac8. Reason for revert: Because this CL affects the boot problem of ac only Original change's description: > storo: update EC thermal table > > Update EC thermal table for throttle and shutdown point. > > BUG=b:194967456 > BRANCH=dedede > TEST=make BOARD=storo and verify function pass by thermal team. > > Signed-off-by: mike <mike5@huaqin.corp-partner.google.com> > Change-Id: Ia5f78111c40aee613bfba5e96ce0af93cb7c81e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3062706 > Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> > Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Bug: b:197199689 Change-Id: I59374bf9a95abf606d11575456fefafdbd84507c Signed-off-by: Mike Lee <mike5@huaqin.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3106908 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* Corori: Removed PD port 1 configurationjohnwc_yeh2021-08-194-112/+2
| | | | | | | | | | | | | | | | | Due to corori only support a USB PD port 0 on MB side, so remove the PD port 1 configuration in board layer. BUG=b:197044392 BRANCH=keeby TEST=make BOARD=corori Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Change-Id: I8627ac564a75b111ec65a1a6af72d01e3e8c62af Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3105913 Tested-by: Matt Wang <matt_wang@compal.corp-partner.google.com> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* wormdingler: Initial EC imageSiyu Qin2021-08-199-0/+1598
| | | | | | | | | | | | | | | | | | Create the initial EC image for the wormdingler variant by copying the homestar reference board EC files into a new directory named for the variant. BUG=b:196748140 BRANCH=trogdor TEST=make BOARD=wormdingler Verify build and powered on homestar board Signed-off-by: Siyu Qin <qinsiyu@huaqin.corp-partner.google.com> Change-Id: I3afdff08d1a7683cdc057dff87ee022dc6633266 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3096811 Reviewed-by: Bob Moragues <moragues@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Wai-Hong Tam <waihong@google.com>
* zephyr: riscv: linker: correct __image_sizeDino Li2021-08-191-2/+1
| | | | | | | | | | | | | | | | | | | | With CL:3088970, the _image_rom_size has been able to provide correct image size. So configure __image_size = _image_rom_size; BRANCH=none BUG=b:195954913 TEST=software sync is successfully. Signed-off-by: Dino Li <Dino.Li@ite.com.tw> Cq-Depend: chromium:3088970 Change-Id: I23a2f33aa15df7a8469d5591dc8d310d0313be92 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3105912 Tested-by: Dino Li <Dino.Li@ite.com.tw> Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* Fennel: pull sensor SPI_NSS to low in S5wen zhang2021-08-191-0/+3
| | | | | | | | | | | | | | | | | There is a leakage after changing the BMI160 to ICM42607 We should pull the sensor SPI_NSS to low in S5 to prevent a leakage BUG=b:196943908 BRANCH=kukui TEST=1.make BOARD=fennel. 2.the power consumption of ICM42607 in S5 is good. 3.the power consumption of BMI160 is still good after the change. Change-Id: I52b6a0da2087766c107b53b46bf4e685870a5f9b Signed-off-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3105906 Reviewed-by: Shou-Chieh Hsu <shouchieh@chromium.org> Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* zephyr: drop IS_ZEPHYR_VERSION usages from npcx espi driverJack Rosenthal2021-08-191-25/+0
| | | | | | | | | | | | | | | This code was added after v2.5 was already dropped from the tree. These macros are not necessary. BUG=b:197159539 BRANCH=none TEST=zmake testall Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: Idbbf3d6431542a707f5abe954b56838a4b18403b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3104787 Commit-Queue: Yuval Peress <peress@chromium.org> Reviewed-by: Yuval Peress <peress@chromium.org>
* zephyr: shim: map correct PLATFORM_EC_* to CONFIG_Denis Brockus2021-08-191-6/+6
| | | | | | | | | | | | | | | | Was using the values of invalid PLATFORM_EC_ defines BUG=none BRANCH=none TEST=zmake configure -b $PROJ_HAYATO Signed-off-by: Denis Brockus <dbrockus@google.com> Change-Id: I86ab2ff1e1018732e0b4bbaaaebe6786c38cc644 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3105486 Tested-by: Denis Brockus <dbrockus@chromium.org> Auto-Submit: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Yuval Peress <peress@chromium.org> Reviewed-by: Yuval Peress <peress@chromium.org>
* treeya: add skuid 0xbe, 0xbf for treeya360arthur.lin2021-08-191-4/+7
| | | | | | | | | | | | | | | | Add skuid 0xbe(190), 0xbf(191) for treeya360 new audio codec sku. BRANCH=grunt BUG=b:185972050 TEST=make buildall -j Signed-off-by: arthur.lin <arthur.lin@lcfc.corp-partner.google.com> Change-Id: I8d9fb10af1d4ec5abb146561172180c23d327226 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3088958 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org>
* chip/mt_scp: enable mt8195 cache on shared DRAMTinghan Shen2021-08-191-0/+4
| | | | | | | | | | | | | BRANCH=none BUG=b:184793035 BUG=b:196756955 TEST=make BOARD=cherry_scp Change-Id: I3b026ae0a14b9317cbfff1aa5838e5c3c7811420 Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3062704 Reviewed-by: Tzung-Bi Shih <tzungbi@chromium.org> Commit-Queue: Tzung-Bi Shih <tzungbi@chromium.org>
* chip/mt_scp: restore fmeter valueTinghan Shen2021-08-191-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fmeter is used to measure the clock speed on SoC. SCP uses the fmeter with different config compared to kernel side clock driver. Restore the fmeter value to prevent wrong fmeter result for clock driver. BUG=b:184793035 TEST=check fmeter result by following commands echo 0 > /proc/sys/kernel/printk clkdbg() { echo $@ > /proc/clkdbg; cat /proc/clkdbg; } clkdbg set_parent vdec_sel mainpll_d4 clkdbg set_parent venc_sel univpll_d4 clkdbg fmeter WAS: 64: hf_fvenc_ck : 312000 65: hf_fvdec_ck : 273000 IS: 64: hf_fvenc_ck : 624000 65: hf_fvdec_ck : 546000 Change-Id: If4d93b9b4e05258d0ad5f96953a99fd74acb6070 Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3063107 Reviewed-by: Tzung-Bi Shih <tzungbi@chromium.org> Commit-Queue: Tzung-Bi Shih <tzungbi@chromium.org>
* primus: fix led behaviorScott Chao2021-08-191-1/+6
| | | | | | | | | | | | | Power led and logo led should not turn on when S5/G3. BUG=b:195516469 BRANCH=none TEST=make -j BOARD=primus Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: I489126425768e8e75d2918db8ce20c1b0f19654d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3103031 Reviewed-by: Boris Mittelberg <bmbm@google.com>
* sm5803: Replace is_acok methodstabilize-14163.B-mainDevin Lu2021-08-191-28/+12
| | | | | | | | | | | | | | | | Since the CHARGER_MODE_SINK bit is not truly ACOK if discharging on ac. Also the VCHGPWR will drop to zero if discharging on ac. This patch replace is_acok method to avoid AC off while discharging on ac. BUG=b:194990808, b:196998260 BRANCH=dedede TEST=Make sure ectool chargecontrol discharge works. Attached charger to make sure AC is ON. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: I7ee72da26b99c8bcb8fbd8c878c930506a244e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3081039 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* zephyr: herobrine: Enable shell helpKeith Short2021-08-181-0/+1
| | | | | | | | | | | | | | | Enable the shell help on Herobrine. BUG=b:192253134 BRANCH=none TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I64388ed56182f4e361bc03239101ca2fbbf32851 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3098591 Reviewed-by: Wai-Hong Tam <waihong@google.com> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: Disable console help stringsKeith Short2021-08-183-3/+24
| | | | | | | | | | | | | | | | | | Add support for disabling the console command help strings. With CONFIG_SHELL_HELP=n, 2000 bytes saved on Volteer BUG=none BRANCH=none TEST=zmake testall TEST=Verify console on Volteer with and without CONFIG_SHELL_HELP enabled. Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I2186828f28691182f673851ac27d207b4a4a6f44 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3093492 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: reduce code duplication of console shimKeith Short2021-08-182-33/+39
| | | | | | | | | | | | | | | | | | Change the console command shim to pass in a struct, reducing the amount of duplicated code. This change saves 500 bytes on Volteer BUG=none BRANCH=none TEST=zmake testall TEST=verify console on Volteer Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I2da374b9a3b3b78a3e7b66d5c31f4ed2131aef01 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3093491 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
* TCPM: Remove enum pd_msg_typeAbe Levkoy2021-08-1821-65/+57
| | | | | | | | | | | | | Convert usages of this enum to tcpm_sop_type. BUG=b:155476419 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I5fed273d72e7ad0e191db0cb0d121b70bdd9ecdb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3104291 Reviewed-by: Keith Short <keithshort@chromium.org>
* TCPM: Rename enum tcpm_transmit_typeAbe Levkoy2021-08-1854-213/+249
| | | | | | | | | | | | | | | Rename tcpm_transmit_type to tcpm_sop_type to reflect that it can be used for Rx as well. Describe it in comments. This prepares to consolidate enum pd_msg_type into this enum. BUG=b:155476419 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: Ife97d4ad51c48f2e832b94e007954919e236a309 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3104290 Reviewed-by: Keith Short <keithshort@chromium.org>
* herobrine_npcx9: Make WARM_RESET and POWER_GOOD power signalsWai-Hong Tam2021-08-182-8/+5
| | | | | | | | | | | | | | | | | | Herobrine uses the SPI mux to separate the SPI bus from the AP when programming the AP firmware. Overdriving signals on WARM_RESET is not needed. Make the WARM_RESET and POWER_GOOD GPIOs like normal power signals. BRANCH=None BUG=b:187098628 TEST=Booted AP properly. Flashed the AP firmware, even AP is off. Change-Id: Ie8e42de8174bc71c29424697810e46a2367e3e54 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3105006 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Stephen Boyd <swboyd@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* driblee: modify thermistor defineMatt_Wang2021-08-181-2/+1
| | | | | | | | | | | | | | | | | | Remove CONFIG_THROTTLE_AP, CONFIG_THERMISTOR_NCP15WB and add CONFIG_THERMISTOR for driblee. BUG=b:196922071 BRANCH=keeby TEST=make BOARD=driblee Signed-off-by: Matt_Wang <Matt_Wang@compal.corp-partner.google.com> Change-Id: I6a412c116c7c7aa2e35865573e3027a456419901 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3102690 Tested-by: Matt Wang <matt_wang@compal.corp-partner.google.com> Reviewed-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* driblee: Increase the length of Battery Model stringMatt_Wang2021-08-181-0/+3
| | | | | | | | | | | | | | | | | | | | | Some battery model names that differ only beyond the 7th character, which cannot be differentiated with the current limitation of 8 characters per battery string. Introduce a new hostcmd version that allows longer battery strings and enable it on Driblee. BUG=b:196910958 BRANCH=keeby TEST=make BOARD=driblee Signed-off-by: Matt_Wang <Matt_Wang@compal.corp-partner.google.com> Change-Id: Ie52f5a35ddc48d66ad9422c0a414493e34ef888a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3102337 Tested-by: Matt Wang <matt_wang@compal.corp-partner.google.com> Reviewed-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* driblee: Initial EC image set gpioMatt_Wang2021-08-183-19/+28
| | | | | | | | | | | | | | | | Initial gpio for driblee. BUG=b:196922068 BRANCH=keeby TEST=make BOARD=driblee Signed-off-by: Matt_Wang <Matt_Wang@compal.corp-partner.google.com> Change-Id: Id6c14a5f5e8a039345d4ffb8974e8c240ccb015e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3099552 Tested-by: Matt Wang <matt_wang@compal.corp-partner.google.com> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
* driblee/raa489000: Control ASGATE stateMatt_Wang2021-08-182-2/+11
| | | | | | | | | | | | | | | | | | | | | | | | | There is 0.1V leakage from Charger to Vbus when a charger is removed in S5. Control ASGATE state to prevent the leakage. This commit uses the charger side registers to control the ASGATE when selecting our active charge port. This is done in addition to the existing implementation which uses the TCPCI registers to control ASGATE. BUG=b:196923271 BRANCH=keeby TEST=make BOARD=driblee Signed-off-by: Matt_Wang <Matt_Wang@compal.corp-partner.google.com> Change-Id: I9c43941fd1795e28456a959d0e46f8268e8ac071 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3102341 Tested-by: Matt Wang <matt_wang@compal.corp-partner.google.com> Tested-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com> Reviewed-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* driblee: Removed PD port 1 configuration and modified HDMI gpio settingMatt_Wang2021-08-184-117/+50
| | | | | | | | | | | | | | | | | | | Due to cret only support a USB PD port 0 on MB side, so remove the PD port 1 configuration in board layer. Also change the GPIOF5 and GPIO92 to HDMI function. BUG=b:186393859,b:185009499 BRANCH=kebby TEST=make BOARD=driblee Signed-off-by: Matt_Wang <Matt_Wang@compal.corp-partner.google.com> Change-Id: Ie4d7286d4b1c1a081bc0ca1be866d8d06c55adae Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3099428 Tested-by: Matt Wang <matt_wang@compal.corp-partner.google.com> Reviewed-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* primus: fix battery setting and add Simplo batteryScott Chao2021-08-182-5/+32
| | | | | | | | | | | | | | | - Follow Sunwoda spec to correct the setting. - Add Simplo battery. BUG=b:195568649 BRANCH=none TEST=make -j BOARD=primus TEST=ectool batterycutoff works. Change-Id: Ic9b44916a7bcbbc8497aa2a91f580d503dd1291b Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3102334 Reviewed-by: Boris Mittelberg <bmbm@google.com>
* herobrine_npcx9: Detect the Refresh key at row 3Wai-Hong Tam2021-08-182-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | Herobrine uses the Vivaldi keyboard. The Refresh key is at T2 (col:2, row:3), instead of T3 (col:2, row:2). The code filters out the Refresh key and check any boot key remaining, like the Esc key. Misconfiguring it fails the recovery boot, as EC detects a redundant key pressed. BRANCH=None BUG=b:196885613 TEST=Pressed Refresh (T2) + Esc and booted EC. Checked the message: [0.005749 KB boot key mask 1] which showed the Esc key was recognized. Without this CL, the message won't show up, as a redundant key (T2 not recognized as Refresh) is pressed. Both EC-OS and Zephyr images behave the same. Change-Id: Iee82d7d4d6b3301ac342abc384488842a9858b7e Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3102287 Reviewed-by: Philip Chen <philipchen@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: Add support for CONFIG_KEYBOARD_REFRESH_ROW3Wai-Hong Tam2021-08-182-0/+13
| | | | | | | | | | | | | Add Kconfig option for CONFIG_KEYBOARD_REFRESH_ROW3. BRANCH=None BUG=b:196885613 TEST=zmake testall Change-Id: Idd55e5bc3af4aab95aa9577b49eb3d8eb5e90630 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3102286 Reviewed-by: Keith Short <keithshort@chromium.org>
* Mrbland: Add the support for ICM42607Siyu Qin2021-08-183-4/+103
| | | | | | | | | | | | | | | | BMI160 is going to EOL, so we intend to import ICM42607 to make 2 sources compatible for Mrbland. BUG=b:196287196 BRANCH=trogdor TEST=1.make BOARD=mrbland 2.ectool motionsense can get the sensor data Change-Id: Ie1b4c6722b460339a38ef48aeae1018f6c008949 Signed-off-by: Siyu Qin <qinsiyu@huaqin.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3089082 Reviewed-by: Bob Moragues <moragues@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com>
* Mrbland: Remove on-body detection and gesture detectionSiyu Qin2021-08-181-9/+1
| | | | | | | | | | | | | | | | | When import the second source sensor ICM42607, the on-body detection and gesture detection functions will course proccess going to null pointer. Mrbland does not require these features, so just remove the related macro. BUG=b:196287196 BRANCH=trogdor TEST=make BOARD=mrbland Signed-off-by: Siyu Qin <qinsiyu@huaqin.corp-partner.google.com> Change-Id: I7a6be7efe0c57c73ebdad0fb462eea0eb516ad61 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3088969 Reviewed-by: Bob Moragues <moragues@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com>
* dedede: moving buttons and switches to use MKBPBoris Mittelberg2021-08-181-0/+1
| | | | | | | | | | | | | | | | | | Switching config option to route buttons and switches over MKBP instead of 8042 driver BRANCH=main,dedede BUG=b:170966461 TEST=manual tested on Madoo Cq-Depend: chromium:3094530 Signed-off-by: Boris Mittelberg <bmbm@google.com> Change-Id: I5c82ee09a64b1971e63547220ca20c1226cb5ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3069163 Reviewed-by: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Tested-by: Nick Vaccaro <nvaccaro@google.com> Commit-Queue: Paul Fagerburg <pfagerburg@chromium.org>
* driblee: modify LED behaviorMatt_Wang2021-08-183-37/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | modify LED behavior for driblee Power LED: System S0: White System S0ix: Blinking white (1 sec on, 1 sec off) System S5/G3: Off. Battery LED: DC mode: System S0: off. System S5/G3: Off. System battery low: Blinking Amber (1 sec on, 1 sec off). AC mode: Charging: Amber. Full charged: White. Battery low or AC only: Blinking Amber (1 sec on, 1 sec off). BUG=b:196910961 BRANCH=keeby TEST=make BOARD=driblee Signed-off-by: Matt_Wang <Matt_Wang@compal.corp-partner.google.com> Change-Id: Iddd6d74a8073d8b409340a2585c45776e10388aa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3102331 Tested-by: Matt Wang <matt_wang@compal.corp-partner.google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* Driblee: Initial EC image setup battery parameterjohnwc_yeh2021-08-182-54/+577
| | | | | | | | | | | | | | Setup battery parameter for driblee. BUG=b:196910958 BRANCH=keeby TEST=make BOARD=driblee Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Change-Id: I6196138c5546beb2a724921c2c1add03a7cd4ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3099426 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* driblee: Disable motionsensorMatt_Wang2021-08-184-297/+1
| | | | | | | | | | | | | | | | Driblee only 180 SKU so remove the motionsensor code. BUG=b:196929676 BRANCH=keeby TEST=make BOARD=driblee Signed-off-by: Matt_Wang <Matt_Wang@compal.corp-partner.google.com> Change-Id: I76fff7ad4f15ec3fb74268ae91c15e495e7ce4a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3102686 Tested-by: Matt Wang <matt_wang@compal.corp-partner.google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* adlrvp: Increase EC clock frequencypoornima tom2021-08-181-0/+4
| | | | | | | | | | | | | | | | | With all four PD tasks enabled, ADLRVP board was rebooting with WDT errors. On increasing the frequency from 48MHZ to 96MHZ, the issue got resolved. BUG=b:195406641 BRANCH=None TEST=ADL P RVP booting fine without any WDT errors Signed-off-by: poornima tom <poornima.tom@intel.com> Change-Id: I7f8ea030c2a9837f4468e2bcdd9fc6de00c33eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3067290 Reviewed-by: Vijay Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Dino Li <Dino.Li@ite.com.tw> Reviewed-by: caveh jalali <caveh@chromium.org>