| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
One of the checks that runs as part of "repo upload" looks for a single
newline at the end of each file. I'm getting warnings about this when I
touch files that do not follow this, even though I didn't add the extra
newlines.
This commit fixes all files by running the following:
for f in $(find . -name '*.[ch]');
do printf '%s\n' "$(cat ${f})" > ${f};
done
BRANCH=none
BUG=b:172020503
TEST=./util/compare_build.sh -b all -j 120
=> MATCH
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Ia3ece5b64b549d21ca11708791368002bb6e9b0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3229797
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a test that covers parts of the code where we validate sensor types.
Also made a modification to accelgyro_bmi260.c where I moved the sensor
type check up to the top of the func so we fail before trying to set
the data rate (which doesn't work for magnetometers).
BRANCH=None
BUG=b:184856157
TEST=zmake configure --test zephyr/test/drivers
Signed-off-by: Tristan Honscheid <honscheid@google.com>
Change-Id: I170087b8bfdc1212972d00010c90789967a6415b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3229076
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a basic test that ensures that the func_set1 register write is
attempted at least one more time on an initial failure.
BRANCH=none
BUG=b:203364783
TEST=zmake configure --test zephyr/test/drivers
Signed-off-by: Yuval Peress <peress@google.com>
Change-Id: Ib06794de0af29fb44e4cb550c7b1ef3c2667af0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3229005
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When compiling with clang, it warns:
core/cortex-m0/task.c:182:19: error: unused function 'get_interrupt_context'
[-Werror,-Wunused-function]
static inline int get_interrupt_context(void)
BRANCH=none
BUG=b:172020503
TEST=make buildall -j
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I914a2a8f950a340c570f5d105859a80be3efb82a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3229479
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than adding an extern for pd_rx_handler() in
board/zinger/board.c, add the definition to the usb_pd.h header.
BRANCH=none
BUG=b:172020503
TEST=./util/compare_build.sh -b all -j 120
=> MATCH
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I5472b2d0bce416d4a296d425efa5d72e9aa548e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3227264
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files call gpio_interrupt(), but were not including the function
declaration.
BRANCH=none
BUG=b:172020503
TEST=./util/compare_build.sh -b all -j 120
=> MATCH
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Iaaedce2a4668dd05581aaa237344cd520c7eb715
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3227263
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the interrupt handlers are made static (see followup commits), the
compiler complains that this function is unused (there is no
corresponding DECLARE_IRQ):
chip/npcx/gpio-npcx9.c:182:15: error: '__gpio_wk2fg_interrupt' defined
but not used [-Werror=unused-function]
GPIO_IRQ_FUNC(__gpio_wk2fg_interrupt, WUI_INT(MIWU_TABLE_2, MIWU_GROUP_6));
BRANCH=none
BUG=b:172020503
TEST=./util/compare_build.sh -b all -j 120
=> MATCH
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I3f58cdcb9b2e113fb9dd079a3e157bf8336b71d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3227262
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test currently sleeps to give the driver time to handle interrupts.
The test should instead schedule the driver immediately and simulate the
passage of time to the driver. Add TODOs to track sleeps that should be
replaced.
BUG=b:201420132
TEST=zmake configure --test zephyr/test/drivers
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: I179dcdd92c04e543a2f2ec0da6ec70bd4aa36ccb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3227260
Reviewed-by: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Simulate VCONN OC and verify that the driver handles it as expected.
Increase syv682x.c line coverage 65.4% -> 68.8%.
BUG=b:190519131
TEST=zmake configure --test zephyr/test/drivers
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: Ifa9ff4129ef0f158e2f59314dbf62ee53b6180e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3219870
Reviewed-by: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to meet the specification of LCD brightness,
it is necessary to set the current value of the LCD controller.
BUG=b:202344727
BRANCH=None
TEST=make -j BOARD=bugzzy
Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com>
Change-Id: I4a688613681e9a68d9bb4c9103ddbf342c416d17
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3217483
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
change charging current to reduce skin temperature.
BUG=b:197776876
BRANCH=None
TEST=make -j BOARD=bugzzy
Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com>
Change-Id: I8a20455d92446ce1606f9e262f6715bf8721adc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3220905
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CL:3206988 in Zephyr fixes the issue with HARD_RESET during
PD negotiation so use shell_* functions instead of printk.
BUG=b:193585176
TEST=Verify connecting a charger doesn't cause HARD_RESET
BRANCH=main
Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com>
Change-Id: Iba021931c0c5df6c8fea1ba589bc7454e777da24
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3226463
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Ruibin Chang <Ruibin.Chang@ite.com.tw>
Commit-Queue: Dawid Niedzwiecki <dawidn@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
experimental for ThermalQual
1. In S3 and S5, charge current follow battery request.
2. In S0:
a) charge current set to 1100mA.
b) If battery request lower 1100mA, charge current
follow battery request.
BUG=b:188458703
BRANCH=dedede
TEST=Test on Cret, charge current be change to 1.1A
Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com>
Change-Id: Ib62f65ba3b1e2bfbc3875e1c5b26927eb67dfbf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3226280
Reviewed-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com>
Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Drop few entries from the various platforms pwm_map.h files. None of
these seems to be used.
BRANCH=none
BUG=b:177452529
TEST=build and run on volteer
TEST=gerrit cq
Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
Change-Id: I47d1283341e4750cd010dbe0eff8d959ce90ccde
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3222848
Commit-Queue: Yuval Peress <peress@google.com>
Reviewed-by: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Almost all of the console commands were already static. This change
makes all of them static for consistency.
BRANCH=none
BUG=b:172020503
TEST=make buildall -j
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I0ac46358b6fbafa65504c648ce4de0365cdbf723
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3224372
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It improve ec keep sensing ps8815 if no db is plugged. It's olny used
for early board (board id = 0).
1. Add DB detection policy for board w/o plugging DB. It can make sure
system can power on and won't be blocked by TCPC1.
2. Add draft PS8815 reset timing. The others should check b/194618663.
3. Follow CL:3095438, mux HPD interface change, to update
BUG=b:197585292
BRANCH=None
TEST=make -j BOARD=taeko; test dut can power on w/ and w/o TCPC1 DB
Signed-off-by: reno.wang <reno.wang@lcfc.corp-partner.google.com>
Change-Id: I7fd115baa95d455b282e4ee5bfdf8ee25524e140
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3133463
Reviewed-by: Boris Mittelberg <bmbm@google.com>
Reviewed-by: caveh jalali <caveh@chromium.org>
Commit-Queue: caveh jalali <caveh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Already moved prochot function into baseboard folder. So remove prochot
function in primus.
BUG=b:198722634
BRANCH=none
TEST=make -j BOARD=primus
Signed-off-by: Will Tsai <will_tsai@wistron.corp-partner.google.com>
Change-Id: I8abe44f7a20df74e97eb672390ff1e53cbc14fa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3208327
Tested-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Reviewed-by: Boris Mittelberg <bmbm@google.com>
Commit-Queue: Boris Mittelberg <bmbm@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:198689488
BRANCH=none
TEST=make -j BOARD=gimble
Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Change-Id: I87c05cc9c1cac2671d8c722df5dec6db352f9e05
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3210249
Tested-by: Will Tsai <will_tsai@wistron.corp-partner.google.com>
Commit-Queue: Boris Mittelberg <bmbm@google.com>
Reviewed-by: Boris Mittelberg <bmbm@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Almost all of the host commands were already static. This change makes
all of them static for consistency.
BRANCH=none
BUG=b:172020503
TEST=make buildall -j
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I8330e85e6d64a039f08d7620eed1fe897f436567
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3221786
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=b:172020503
TEST=./util/compare_build.sh -b all -j 120
=> MATCH
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I39f9d35b22d25c923a768bf86b3a16413b9f0a4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3219871
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adjusts the RCP (reverse current protection) voltage threshold
for PP1 to 3 mV when in ideal diode mode. This change fixes an issue
on honeybuns for port C0 when connecting to M1 based host machines and
charging at higher VBUS values ( > 15V).
BRANCH=quiche
BUG=b:199339421
TEST=verfied bit 4 of function set 10 register is clear
> ppc 0 dump
FUNC_SET1 [50h] = 0x05
FUNC_SET2 [51h] = 0x18
FUNC_SET3 [52h] = 0x68
FUNC_SET4 [53h] = 0xfc
FUNC_SET5 [54h] = 0x37
FUNC_SET6 [55h] = 0xc1
FUNC_SET7 [56h] = 0x70
FUNC_SET8 [57h] = 0xbd
FUNC_SET9 [58h] = 0x34
FUNC_SET10 [59h] = 0x60
ODM partner verified this change fixed the ~3% devices that were
failing and did interop testing with other host machines to verify no
regressions. Those results are linked in the buganizer issue.
Signed-off-by: Scott Collyer <scollyer@google.com>
Change-Id: Id798debc11f8586acc6c9feef104478375ee4fea
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3219573
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Scott Collyer <scollyer@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:198689488
BRANCH=none
TEST=make -j BOARD=gimble
Signed-off-by: Will Tsai <will_tsai@wistron.corp-partner.google.com>
Change-Id: I4be2dc8505baffaa8b7d0c9b6949711aca370778
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3201831
Tested-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Commit-Queue: Boris Mittelberg <bmbm@google.com>
Reviewed-by: Boris Mittelberg <bmbm@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add Kconfigs to enable virtual battery and set virtual battery address.
Change named-i2c from I2C_PORT_VIRTUAL to I2C_PORT_VIRTUAL_BATTERY.
BRANCH=main
BUG=b:185480578
TEST=When virtual battery is enabled, compilation fails if no
virtual battery port is defined in device tree.
TEST=Enable virtual battery and verify that its handlers
are called properly.
Change-Id: Ic88da28dc443beb89a32868d201072f39abb3a86
Signed-off-by: Michał Barnaś <mb@semihalf.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3207991
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement VBUS cycle according to USB Type-C Spec R2.0:
10.3.1 Hub Downstream Facing Port State Descriptions
10.3.1.1 DSPORT.Powered-off
A hub may provide power to its downstream ports all of the time to
support power applications from a USB port. Such hubs must ensure that
Enhanced SuperSpeed devices on its downstream-facing ports attempt
Enhanced SuperSpeed connection once upstream VBUS is seen by the hub.
The recommended method to achieve this is to cycle VBUS off for a
duration or by actively discharging so that it is seen to be off by the
downstream device.
BUG=b:200772411
TEST=manually
BRANCH=main
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I674391622698b6e241b0a97063b3abbc8550e365
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3195205
Reviewed-by: Eric Yilun Lin <yllin@google.com>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds unit tests for following driver/tcpm/tcpci.c functions:
- tcpci_tcpm_get_cc()
- tcpci_tcpm_set_cc()
- tcpci_tcpm_set_polarity()
- tcpci_tcpm_set_vconn()
BUG=b:184857030
BRANCH=none
TEST=make configure --test zephyr/test/drivers
Signed-off-by: Tomasz Michalec <tm@semihalf.com>
Change-Id: I91208fa5093677db612358c804f29fb8b359b820
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3220336
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Tested-by: Tomasz Michalec <tmichalec@google.com>
Commit-Queue: Tomasz Michalec <tmichalec@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TCPCI emulator is added in tcpc_config for port 0. In this patch init
and release of driver/tcpm/tcpci.c functions are tested.
BUG=b:184857030
BRANCH=none
TEST=make configure --test zephyr/test/drivers
Signed-off-by: Tomasz Michalec <tm@semihalf.com>
Change-Id: Ie36838c9562d5d1480699b7ab0ae3a04e3485d76
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3205360
Reviewed-by: Yuval Peress <peress@google.com>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Tested-by: Tomasz Michalec <tmichalec@google.com>
Commit-Queue: Tomasz Michalec <tmichalec@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Quackingstick have only one port type-C so remove unused C1
task.
BUG=b:201263032
BRANCH=none
TEST=none
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Change-Id: I8064a2bfcb8ecb50a84080904161a1721961ef5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3217479
Reviewed-by: Wai-Hong Tam <waihong@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://crrev.com/c/3169964 changed __data_lma_start from "." to
LOADADDR(.data) to fix dartmonkey when compiling with clang. This
changed the LMA address on some boards, such as voxel. Even though the
new address looks correct (matches start of .data section), we are
seeing an exception on voxel during startup. For now, keep clang and gcc
separate until we can diagnose the issue.
BRANCH=none
BUG=b:172020503, b:202863352
TEST=make buildall -j
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I8313210c89559a6159f311821a18e7b310a3ada6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3224378
Reviewed-by: caveh jalali <caveh@chromium.org>
Commit-Queue: caveh jalali <caveh@chromium.org>
Tested-by: caveh jalali <caveh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
configure BB-retimer I2c address to sync with intel BBR FW
BUG=b:198122468
BRANCH=none
TEST=build make -j BOARD=Felwinter pass
Signed-off-by: Leo-Tsai <leocx_tsai@compal.corp-partner.google.com>
Change-Id: I4481fe404236a41b2f391d9cbcb290385b93008f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3210253
Reviewed-by: Ko Ko <ko_ko@compal.corp-partner.google.com>
Reviewed-by: caveh jalali <caveh@chromium.org>
Commit-Queue: caveh jalali <caveh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current input limit setting doesn't respect the PDO's
current limit (e.g. when the current limit is less than
CONFIG_INPUT_CURRENT_LIMIT) and this might cause the over-draining
the charger.
BUG=b:172878439
TEST=1) make buildall
2) modified servo-v4 which only broadcast PDOs with 250mA current
limit and ensure the goroh won't sink more than 250mA.
(while the CONFIG_INPUT_CURRENT_LIMIT is 512mA)
BRANCH=main
Change-Id: I09f8e6fb39a072ee38ea09a5c9898984f4122513
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3220037
Commit-Queue: Eric Yilun Lin <yllin@google.com>
Tested-by: Eric Yilun Lin <yllin@google.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The type-C PDO "PD_MAX_POWER_MW" change to 45W from 65W.
BUG=b:202760336
BRANCH=zork
TEST=manual
Check PDO using command "ectool usbpdpower"
Signed-off-by: Michael5 Chen1 <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: I448ed37ce892f097aa7a2297868cf22195c8571e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3217476
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move comment to its proper location.
BUG=none
TEST=zmake configure --test zephyr/test/drivers
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: I1b2858121ee6aefc5babaea87efb55b50dd279aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3219589
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ECOS repo allows eSPI to run in quad mode at the maximum speed.
Allow the same configuration here for zephyr.
BRANCH=None
BUG=b:195137794
TEST=on guybrush, verify bootblock sees us go to quad mode. With zephyr
ESPICFG fix applied, see that we're in quad mode with 33 MHz
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I18b4ea340dd97c2da4f984776a5b004a8db877ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3221771
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nipperkin has led on both USB-C0 and USB-C1 side,
this patch update USB-C0 and USB-C1 led placement
on DUT:
USB-C0 is left port.
USB-C1 is right port.
BUG=none
BRANCH=none
TEST=verify led behavior same as ectool led command.
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: Ibfee7b8921efc8ead8612b8212e5dc1b41f94424
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3211324
Reviewed-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
BRANCH=none
TEST=none
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: Id6feb968e2f21cd1723c0f5f4d6ddf91003af0fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3197895
Reviewed-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement fan curve for nipperkin.
BUG=b:202475154
BRANCH=none
TEST=verify fan curve work as intended.
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: I3fb160f20533f09ab831465a2455846853829bda
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3197894
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove IS_DEFINED(BOARD_XXX) and board_get_version() calls, assume the
default board is Hayato rev 4+.
- Remove dynamic g-sensor probing, default to icm426xx.
BUG=b:202808130
TEST=1) make BOARD=krabby
2) zmake -D -l DEBUG configure -b zephyr/projects/corsola/krabby/
3) `ag '(asurada|hayato)' -i` in the board folders shows no match
BRANCH=main
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I15e4dbb81970052e5b524c4aff9f51ff4c9d89c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3222519
Reviewed-by: Rong Chang <rongchang@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Copy from asurada/hayato, will cleanup in following CLs.
BUG=b:202808130
TEST=zmake -D -l DEBUG configure -b zephyr/projects/corsola/krabby/
BRANCH=main
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I667ed99bd418997e932ca272daed936db54988f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3219882
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Start from copying Asurada board.
Modified baseboard name in krabby/build.mk and copyright header.
Will cleanup in following CLs.
BUG=b:202808130
TEST=make BOARD=krabby
BRANCH=main
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I200c8dec7714dfacc38aad1edbf236c1a6268e0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3218585
Reviewed-by: Eric Yilun Lin <yllin@google.com>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit f5ba5ec8361d7dadefb3860a05bf80e4ad230a44.
Reason for revert: Revert this CL due to we have new design in brya baseboard. https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3201831
Original change's description:
> primus: control prochot
>
> BUG=b:198722634
> BRANCH=none
> TEST=make -j BOARD=primus
> TEST=verified by power team
>
> Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
> Change-Id: I777f803b91f0449317f0185a6ca77348de3835bc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3096806
> Reviewed-by: caveh jalali <caveh@chromium.org>
> Commit-Queue: caveh jalali <caveh@chromium.org>
Bug: b:198722634
Change-Id: Ibd9426f2719f008159344b0917424611ae7b4a4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3220725
Auto-Submit: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Tested-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test high-voltage over-current interrupts. Verify that the driver
restores the power path until the over-current limit is reached.
Increase coverage of syv682x.c: line 47.5->55.1%; branch 13.2->15.5%.
BUG=b:190519131
TEST=zmake configure --test zephyr/test/drivers
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: I84f2eb31796eec4e2106f29f52ee49c9e9662928
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3214776
Commit-Queue: Yuval Peress <peress@google.com>
Reviewed-by: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds the factory keyboard connector test.
BUG=b:202914217
BRANCH=none
TEST=Short keyboard pins and make sure "ectool kbfactorytest" works.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: I9d06b8a44e6274e27f6ce96e23b48de799eaad61
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3220039
Reviewed-by: Boris Mittelberg <bmbm@google.com>
Commit-Queue: Boris Mittelberg <bmbm@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds the factory keyboard connector test.
BUG=b:202914217
BRANCH=none
TEST=Short keyboard pins and make sure "ectool kbfactorytest" works.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: I941767c928d71cd04087ff40fa53427f49ae4802
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3220038
Reviewed-by: Boris Mittelberg <bmbm@google.com>
Commit-Queue: Boris Mittelberg <bmbm@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clang warns that we're clobbering a reserved register:
inline asm clobber list contains reserved registers: R7
[-Werror,-Winline-asm].
According to
https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html#Clobbers-and-Scratch-Registers:
When the compiler selects which registers to use to represent input and
output operands, it does not use any of the clobbered registers.
Before this change, the only remaining registers for the compiler to use
to hold the values represented by the symbolic names "pregs" and
"pstack" are R0 and R12. After this change, this still holds on clang,
since it won't clobber the reserved register R7 even if it's not on the
clobber list.
BRANCH=none
BUG=b:172020503
TEST=make V=1 CC=arm-none-eabi-clang BOARD=elm
TEST=./util/compare_build.sh -b all -j 120
=> MATCH
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I5182ef24f4465d68c97f4160a45cd479fe52e017
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3193273
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add battery 50wh for galtic360
BUG=b:194961842
BRANCH=dedede
TEST=manual
1. Check battery found on EC console
2. Check battery cutoff function on EC console
3. Check battery charging FET status when battery full
4. Battery charge from 0% to 100%.
Signed-off-by: Michael5 Chen1 <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: I87381fb585a0a82af5280a04867df4c98ee4d528
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3161856
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clang warns:
chip/stm32/ucpd-stm32gx.c:797:5: error: array index 582424 is past the
end of the array (which contains 7 elements) [-Werror,-Warray-bounds]
ucpd_txorderset[TX_ORDERSET_SOP];
^ ~~~~~~~~~~~~~~~
chip/stm32/ucpd-stm32gx.c:127:1: note: array 'ucpd_txorderset' declared
here
static int ucpd_txorderset[] = {
The if clause handles SOP -> Cable Reset and the only type that does not
handle is TCPCI_MSG_TX_BIST_MODE_2. That case is a "don't care" for sync
packets as it's just a continuous 1/0 bit pattern.
BRANCH=none
BUG=b:172020503
TEST=make CC=arm-none-eabi-clang BOARD=baklava
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Ia2b73bcbf7eabe2de480633d4e65b8df55137e2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3198206
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Scott Collyer <scollyer@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without this change, the code compiles and links when using clang, but
does not boot.
__data_lma_start should be the LMA address of the .data section and is
used in core/cortex-m/init.S to copy the data from the LMA address into
the VMA address (flash to RAM). Before this change, examining the smap
and map files shows that __data_lma_start (0x0800bcdc) does not match
the LMA address of the .data section (0x800bce0):
build/dartmonkey/RO/ec.RO.smap:
0800bcdc R __data_lma_start
build/dartmonkey/RO/ec.RO.map
VMA LMA Size Align Out In Symbol
24003538 800bce0 68 8 .data
After the change, the LMA addresses match and the board boots correctly:
build/dartmonkey/RO/ec.RO.smap:
0800bce0 A __data_lma_start
build/dartmonkey/RO/ec.RO.map
VMA LMA Size Align Out In Symbol
24003538 800bce0 68 8 .data
When comparing the behavior of this change with gcc, we find that many
boards match, but some do not (see TEST line). Looking at a few of the
boards that do not match, there appears to be a one-byte difference in
the RO portion. Investigating further on voxel:
Original address from build/voxel/RO/ec.RO.smap:
100a2e20 R __data_lma_start
New address from build/voxel/RO/ec.RO.smap after applying this change:
100a2e60 A __data_lma_start
In both cases, when using objdump on RO.elf, .data's LMA address starts
at 100a2e60, so this change appears to be correct:
arm-none-eabi-objdump -h
/tmp/compare_build.Ltgh/ec-53a576c00f1b0d609d23a68a83e0340a14ee8fe5/build/voxel/RO/ec.RO.elf
Sections:
Idx Name Size VMA LMA File off Algn
3 .data 00000538 200b8368 100a2e60 00058368 2**3
CONTENTS, ALLOC, LOAD, DATA
arm-none-eabi-objdump -h
/tmp/compare_build.Ltgh/ec-f0c36b07d9efa2f5b12e5de7e794d723e8468e26/build/voxel/RO/ec.RO.elf
Sections:
Idx Name Size VMA LMA File off Algn
5 .data 00000538 200b8368 100a2e60 00058368 2**3
CONTENTS, ALLOC, LOAD, DATA
BRANCH=none
BUG=b:172020503, b:202863352
TEST=make buildall
TEST=make CC=arm-none-eabi-clang BOARD=dartmonkey
TEST=./util/compare_build.sh -b all -j 150
All boards match, EXCEPT:
adlrvpp_npcx akemi aleena ambassador anahera atlas berknip bloog
bobba boldar brask brya bugzzy cappy2 careena casta chronicler
coachz collis copano coral corori dalboz delbin dewatt dirinboz dood
dooly dratini driblee drobit drobit_ecmodeentry eldrid elemi
endeavour eve ezkinil felwinter fizz fleex foob garg genesis gimble
grunt gumboz guybrush hatch helios herobrine_npcx9 homestar jinlon
kano karma kindred kingoftown kohaku lalala lazor liara lick lindar
lux madoo magolor marzipan meep metaknight moonbuggy morphius
mrbland mushu nami nautilus nightfury nipperkin nocturne npcx7_evb
npcx9_evb npcx_evb_arm npcx_evb nuwani palkia pazquel phaser pompom
poppy primus puff quackingstick rammus redrix reef sasuke scout
shuboz soraka stryke taeko treeya trembyle trogdor vilboz voema
volet volteer_npcx797fc voxel voxel_ecmodeentry voxel_npcx797fc
waddledoo2 woomax wormdingler yorp
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Icd3df244e202a50a577f21ffa4f8202eb3f8b8d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3169964
Reviewed-by: Eric Yilun Lin <yllin@google.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=b:202789410
TEST=zmake configure --test zephyr/test/drivers
Signed-off-by: Yuval Peress <peress@google.com>
Change-Id: Ie61e0549f65a27eede00920763cc61207b6046be
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3218254
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=b:202789410
TEST=zmake configure --test zephyr/test/drivers
Signed-off-by: Yuval Peress <peress@google.com>
Change-Id: Ib676f08661e24b3b2277316bfc04228a4bb4b2a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3218253
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The call to cros_cbi_ssfc_get_parent_field_value() was returning 0
for error which is also a valid value. This was also fixed so it is
possible to distinguish between an error and a value.
BRANCH=none
BUG=b:202789410
TEST=zmake configure --test zephyr/test/drivers
Signed-off-by: Yuval Peress <peress@google.com>
Change-Id: Id58de2cd5f3d87a66cd48fc8b2bd3853d0dce649
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3218252
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|