| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch updates the LEDs behavior.
Change as below:
1. battery error:
Original - Blinking white quickly. (0.5 sec ON, 0.5 sec OFF)
New - Blinking amber quickly. (0.5 sec ON, 0.5 sec OFF)
2. battery low:
Original - Blinking white slowly on right side led.
(1 sec ON, 1 sec OFF)
New - Blinking amber slowly on both side leds.
(1 sec ON, 1 sec OFF)
BUG=b:208912133
BRANCH=none
TEST=Verify LEDs worked indeed.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: I2ce233d57eb168b47d8dbcb724890e6e5f196f77
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3314261
Commit-Queue: Boris Mittelberg <bmbm@google.com>
Reviewed-by: Boris Mittelberg <bmbm@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The step size of minimum system voltage for bq25710 is 256mv and bq25720
is 100mv.
BRANCH=none
BUG=b:209343612
TEST=buildall passes
Signed-off-by: reno.wang <reno.wang@lcfc.corp-partner.google.com>
Change-Id: I1b07a2a5122703046ef4158b6eae645c4861fdc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3315766
Reviewed-by: Boris Mittelberg <bmbm@google.com>
Commit-Queue: Boris Mittelberg <bmbm@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enables TCPC based VCONN control for port C1 (ps8815).
BUG=None
BRANCH=none
TEST=TBT monitor detected on typec port 1
Signed-off-by: Sugnan Prabhu S <sugnan.prabhu.s@intel.com>
Change-Id: I2f8beea567f5ff7e66d046aa5c539d7ab7bfcf2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3306084
Tested-by: Abhijeet Rao <abhijeet.rao@intel.com>
Reviewed-by: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com>
Reviewed-by: Abhijeet Rao <abhijeet.rao@intel.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move replacement of alternate devices, ppc in this case, to a new
separate file. This will allow handling different chips based on
board versions, cbi fields, etc. in one place.
BUG=b:202451919
TEST=zmake testall & Make sure PD works on Herobrine on both ports
BRANCH=main
Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com>
Change-Id: I27fd01ee74523a18083f77a92c1051058cf7c814
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3289206
Commit-Queue: Keith Short <keithshort@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The improvements include:
-Use better names for SSFC related things.
-Do not call checking SSFC and replacing alternate sensors automatically.
Let the board-code call the replacement, since it is very specific
operation.
BUG=b:202451919
TEST=zmake testall & test if an alternate sensors are used as it is done
in CL:3310639
BRANCH=main
Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com>
Change-Id: I77a720d5b2ce09ea85902b681c5266d44eb6d144
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3289205
Commit-Queue: Keith Short <keithshort@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove a function to probe all alternate motion sensors, but prepare a
function to probe a specific sensor. It introduces more flexibility.
Also, create a separated header file motionsense_sensors_defs.h with
definitions needed in board.h.
BUG=b:202451919
TEST=zmake testall & test if an alternate sensors are used as it is done
in CL:3310639
BRANCH=main
Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com>
Change-Id: Ibfab10cbff39e17c8a86aad0c6d7c5897285a0a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3289415
Commit-Queue: Keith Short <keithshort@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The EC chip provides a default label for every I2C bus. Override the
default label with a label matching the schematic net name.
Typing "i2c scan <tab>" on Herobrine now shows the following labels:
uart:~$ i2c scan
I2C_SENSOR I2C_EEPROM I2C_RTC I2C_USB_C1_PD I2C_USB_C0_PD
I2C_POWER
BUG=none
BRANCH=none
TEST=Boot Zephyr on herobrine, verify the new I2C bus labels
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I41c4bfbffca5ee49b66d6ffbfc0a6d73ea06db8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3300665
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The label property was stored in the name field of i2c_ports[]. However
the name field is only used by the legacy I2C console commands and not
used by Zephyr builds.
Remove the label property from named-i2c-ports and remove the name field
from i2c_ports[] for Zephyr builds, saving a modest amount of flash
space.
BUG=none
BRANCH=none
TEST=zmake testall
TEST=Boot zephyr on Herobrine, verify I2C console commands still
functional.
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I22c743c4e362d05d51432fa67f5be16989d39574
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3300664
Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify lid_standard_ref to
0, 1, 0
-1, 0, 0
0, 0, 1
BUG=b:208865381
BRANCH=none
TEST=The display orientation is correct on the BMI160
board.
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Change-Id: Ica254ebe7e805771f7a6a2514196a7123a7908d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3316163
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Reviewed-by: Bob Moragues <moragues@chromium.org>
Commit-Queue: Bob Moragues <moragues@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For Herobrine board version 1, pin GPIOB7 is unused
and GPIOB6 is configured as input (HiZ).
BRANCH=main
BUG=b:202008595
TEST=Built the Zephyr image. Needs testing when
version 1 boards are available.
Signed-off-by: Sam Hurst <shurst@google.org>
Change-Id: Ia18dda97b65122ed768fe89f64f0857da4356b89
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3315752
Tested-by: Sam Hurst <shurst@google.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
Commit-Queue: Sam Hurst <shurst@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a static assert to catch DPTF being used without temp sensors
defined in the dts.
Disable DPTF on nivviks.
This fixes a build error on gitlab.
https://gitlab.com/zephyr-ec/ec/-/pipelines/422163729
BRANCH=None
BUG=b:201000681
TEST=zmake configure --build nivviks
Change-Id: I273a7267783f119391d1d739c598ed2a059d1286
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3317781
Reviewed-by: Yuval Peress <peress@google.com>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In some angle, dut should keep clamshell mode, but change to tablet mode
and lock keyboard because of wrong y/z axis setting. This CL is used to
correct it.
BRANCH=none
BUG=b:201504044
TEST=make -j BOARD=taeko, verify base sensor's x/y/z via checking
ectool motionsense.
Signed-off-by: reno.wang <reno.wang@lcfc.corp-partner.google.com>
Change-Id: Id3d48b184b7e20744961f4219bbae1be06136ddf
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3306765
Reviewed-by: Boris Mittelberg <bmbm@google.com>
Reviewed-by: YH Lin <yueherngl@chromium.org>
Reviewed-by: Parth Malkan <parthmalkan@google.com>
Commit-Queue: Boris Mittelberg <bmbm@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify LED behavior to meet the revised specification
BUG=b:193600290
BRANCH=none
TEST=make -j BOARD=gimble
Signed-off-by: Will Tsai <will_tsai@wistron.corp-partner.google.com>
Change-Id: I3961b8083d30e582320cad1e4852746367e9a0a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3312514
Reviewed-by: Boris Mittelberg <bmbm@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add SMP L20M3PG2 battery.
BUG=b:203739613
TEST=zmake testall
BRANCH=none
Change-Id: I86c39e5cbe3a9b9aed19781d30528e3f43effcf5
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3312506
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@google.com>
Tested-by: Eric Yilun Lin <yllin@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The noise is related to the LCD panel and brightness PWM.
Change the PWM frequency of the panel backlight to 20kHz,
the display is normal, and no noise can be heard.
BUG=b:207585489
BRANCH=trogdor
TEST=No noise can be heard when booting into the operating
system, and the screen display is normal.
Signed-off-by: Tang Qijun <qijun.tang@ecs.corp-partner.google.com>
Change-Id: I2ba8f7530743bbd1ee6f462be8f79c621eb3217a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3301560
Commit-Queue: Bob Moragues <moragues@chromium.org>
Tested-by: Bob Moragues <moragues@chromium.org>
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Reviewed-by: Alexandru M Stan <amstan@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When CONFIG_PLATFORM_EC_HOSTCMD is not enabled we want to silently drop
the handler routines from the build. The current approach works for gcc
but not for clang.
Use an exported function instead.
BUG=b:208648337
BRANCH=none
TEST=CQ and gitlab
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I63f74e8081556c726472782f60bddbbfbc3e9bf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3313320
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the initial new board checklist for Zephyr ECs.
BUG=b:207403708
BRANCH=none
TEST=View docs using gerrit preview/browse
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I1e2585709eaf9b1f9db4f57c9ae665797b3e5608
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3296745
Reviewed-by: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support setting CONTROL_3[BUSY] in the SYV682x emulator. Verify that
writes fail if this bit stays set for too long but succeed if it clears
quickly.
BUG=b:190519131
TEST=zmake configure --test zephyr/test/drivers
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: I58386f73c8df20239b3eaf13f8eab37be0b11bbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3315225
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since PP5000_HDMI is enabled by EN_PP5000_U, which means that it's
still turned on when power state S5, VOLUP_BTN_ODL_HDMI_HPD will be
asserted when HDMI is plugged in. If we report this to CPU through
EC_AP_USB_C1_HDMI_HPD, there will be leakage current on CPU side
which might lead to unabling to power on the system.
BUG=none
BRANCH=dedede
TEST=make sure that EC_AP_USB_C1_HDMI_HPD is deasserted when power
state S5 and HDMI plugged in, while it can work when system resume.
Signed-off-by: Tommy Chung <tommy.chung@quanta.corp-partner.google.com>
Change-Id: I67d1af60b74343611e0ca6f54773216cf4caa895
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3306791
Reviewed-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In PR:40802, the UART driver uses the pm_constraint counter to indicate
if the UART Tx is still ongoing or not. The pm policy should check the
counter with the pm_constraint_get function to determine if the system
can enter the suspend state or stay in the active one.
BUG=none
BRANCH=none
TEST=pass "zmake testall"
TEST=build npcx9_evb and volteer with PR:40802, make sure they can
boot up and enter deep sleep. Make sure the console messages don't
break.
Signed-off-by: Jun Lin <CHLin56@nuvoton.com>
Signed-off-by: Wealian Liao <WHLIAO@nuvoton.com>
Change-Id: I0803d9bb8454825a7ae876abaac58c65e7db1550
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3306790
Tested-by: CH Lin <chlin56@nuvoton.com>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix conflicting configuration for backlight lid.
CONFIG_PLATFORM_EC_BACKLIGHT_LID will be enabled by default,
no need to enable explicitly, removing this from prj.conf.
BUG=b:208787653
BRANCH=none
TEST=zmake configure -B ~/tmp/brya/ brya -b
Signed-off-by: Rajesh Kumar <rajesh3.kumar@intel.com>
Change-Id: Ia44ae2c51b913817b1b7ac31aa1cb16ef623aa27
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3313322
Reviewed-by: Divya S Sasidharan <divya.s.sasidharan@intel.com>
Reviewed-by: Tanu Malhotra <tanu.malhotra@intel.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Scarlet is tight on flash space and enabling LTO buys us a a bunch
space (~10 KB).
BUG=b:208889220
BRANCH=none
TEST=RO: 9996 bytes in flash and 10772 bytes in RAM still available
RW: 21916 bytes in flash and 10764 bytes in RAM still available
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: Ifec28beadc94971f951c86b9ae3504e6f0aada0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3313650
Reviewed-by: Evan Green <evgreen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add ADC channels for temperature sensors for nivviks.
BUG=b:201000681
TEST=zmake configure -b nivviks
BRANCH=none
Cq-Depend: chromium:3310024
Signed-off-by: Andrew McRae <amcrae@google.com>
Change-Id: I2c4e8da3a3902934f8fbeea46723dad42f479630
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3312809
Commit-Queue: Keith Short <keithshort@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use FFF framework instead of ztest_* API in usb_mux test.
BUG=none
BRANCH=none
TEST=make configure --test zephyr/test/drivers
Signed-off-by: Tomasz Michalec <tm@semihalf.com>
Change-Id: I6c42f8f60d0b4bfb5a852e53539ffb9fb9424b10
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3306363
Commit-Queue: Tomasz Michalec <tmichalec@google.com>
Tested-by: Tomasz Michalec <tmichalec@google.com>
Reviewed-by: Tristan Honscheid <honscheid@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the AP SoC default configuration out of the base Zephyr it8xxx2
board to the project configuration.
BUG=b:208739197
TEST=zmake configure -b krabby; zmake configure -b kingler
BRANCH=none
Signed-off-by: Andrew McRae <amcrae@google.com>
Change-Id: Ia111f6ab592d0782902f91cd70ebfc7693c4a398
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3312511
Reviewed-by: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now BUILD_HOST_COMMAND macro accepts params argument to setup parameters
of host command. New variants of BUILD_HOST_COMMAND are added:
- BUILD_HOST_COMMAND_RESPONSE
- BUILD_HOST_COMMAND_PARAMS
- BUILD_HOST_COMMAND_SIMPLE
They allow to declare host command with only response, params or
neither.
The response_size field is intentionally set to 0, because this is
default value. Command returning data should update this field.
BUG=none
BRANCH=none
TEST=make configure --test zephyr/test/drivers
Signed-off-by: Tomasz Michalec <tm@semihalf.com>
Change-Id: I31021db3790dfa3e0ad15128daf455d14a9c071c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3310858
Tested-by: Tomasz Michalec <tmichalec@google.com>
Commit-Queue: Tomasz Michalec <tmichalec@google.com>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable CONFIG_ADC_CHANNELS_RUNTIME_CONFIG for brya
and fixed compilation error in zephyr shim.
BUG=b:208785542
BRANCH=none
TEST=zmake configure -B ~/tmp/brya/ brya -b
Signed-off-by: Rajesh Kumar <rajesh3.kumar@intel.com>
Change-Id: I69e89091aece1125d499f192a6124bf5277b8def
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3313321
Reviewed-by: Divya S Sasidharan <divya.s.sasidharan@intel.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Tanu Malhotra <tanu.malhotra@intel.com>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initial EC Zephyr config for Nissa/Nivviks.
Not all GPIOs have been defined yet.
V2 - reworked to use a single project directory.
V3 - renaming.
BUG=b:201000681
TEST=make -j buildall; cd zephyr; zmake configure -b nivviks
BRANCH=none
Cq-Depend: chromium:3312397
Change-Id: I2b3f7ee77dc8365fac10b8fb7a4eec65d827bed1
Signed-off-by: Andrew McRae <amcrae@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3310024
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than assume the eSPI controller the ECOS shim should bind to is
called espi0, instead get a chosen cros-ec,espi device at build-time.
BUG=b:205615358
TEST=zmake testall
BRANCH=none
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Change-Id: I46f43494e64af0550c4f54f716a63d16a1f96651
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3312503
Commit-Queue: Keith Short <keithshort@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds a cros-ec,adc chosen node to the device tree, to be used
by the ADC shim to locate the device to which all analog channels are
bound (rather than assuming it is named adc0). It also makes the
configuration happen at compile-time, saving some runtime indirection and
failing faster (at build rather than runtime) if misconfigured.
BUG=b:205615358
TEST=zmake testall
BRANCH=none
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Change-Id: I71bdf7329b76eb4cda06478f27bb76418e6b0b78
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3308335
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to correctly sequence HPD sets with the AP, allow the HPD set
to wait on an ACK from the AP before proceeding.
BRANCH=None
BUG=b:202137658
TEST=on brya, validate retimer and virtual mux are kept in sync as
expected
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I368c3290b69d627829a70847876d7b47a8c36948
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3232293
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Verify the sn5s330 driver set_sbu api correctly sets registers.
BRANCH=none
BUG=b:203364783
TEST=zmake configure --test test-drivers
Signed-off-by: Aaron Massey <aaronmassey@google.com>
Change-Id: I4a63d8c093653829d4fe46de193a0bd7f571ae3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3311881
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tell zmake to search for the checkout path of the main branch (see the
dependencies) instead of the v2.7 checkout path.
Update the GitLab configuration to download main instead of
chromeos-v2.7.
BUG=b:205884929
BRANCH=none
TEST=zmake testall
TEST=https://gitlab.com/zephyr-ec/ec/-/pipelines/420535963
Cq-Depend: chrome-internal:4299651
Change-Id: Ie7a2b7784606d0fc2455dab3c21ec3b49f073b06
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3310534
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Zephyr upstream added NCT38XX GPIO support except for TCPC
functionality. The NCT38XX GPIO & TCPC share the same alert pin. The
alert should be handled at the same position.
This CL adds nct38xx_get_gpio_device_from_port() for Cros NCT38XX alert
handler. It can connect Cros TCPC alert & Zephyr NCT38XX GPIO alter
handler. So we can process the GPIO & TCPC alert at Cros task. The
following is the TCPC binding example:
usbc {
compatible = "named-usbc-ports";
#address-cells = <1>;
#size-cells = <0>;
port0: usbc-port@0 {
reg = <0>;
tcpc {
compatible = "nuvoton,nct38xx";
gpio-dev = <&nct3807_gpio>;
};
};
};
BUG=b:203672150
BRANCH=none
TEST=test GPIO interrupt on NCT38XX
Cq-Depend: chromium:3297249
Signed-off-by: Wealian Liao <whliao@nuvoton.corp-partner.google.com>
Change-Id: Iec355ccb581590d24cc9fcc809449b3654014a40
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3271801
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add new zephyr enum bindings for new GPIOs for nivviks.
BUG=b:201000681
TEST=make -j buildall
BRANCH=none
Signed-off-by: Andrew McRae <amcrae@google.com>
Change-Id: I5fa334c461d4c11e3618199e31e6db2754a88d46
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3312397
Commit-Queue: Keith Short <keithshort@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Console buffer should write chars at location of tail index and then
increment index, not otherwise. It fixes reading buffer before first
buffer overwrite (start condition with empty buffer is head_idx == 0 and
tail_idx == 0, first char was written to index 1 not 0, so uninitialized
char at index 0 (head_idx) could be read).
It fixes not reading last char by EC_CMD_CONSOLE_READ host command.
Empty buffer condition is head_idx == tail_idx. It was impossible to
read last char if it was pointed by tail_idx. Because of that tail_idx
should point past last written char.
BUG=none
BRANCH=none
TEST=make configure --test zephyr/test/drivers
TEST="ectool console" on volteer; logs usually ends with newline; after
this change extra newline should be printed (last char in buffer)
Signed-off-by: Tomasz Michalec <tm@semihalf.com>
Change-Id: I056b95533580db3724897d04d8863a78e73c2b2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3310857
Commit-Queue: Tomasz Michalec <tmichalec@google.com>
Tested-by: Tomasz Michalec <tmichalec@google.com>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Set CONFIG_SYV682X_HV_ILIM to 5.5A on brask.
BUG=b:207810000
BRANCH=none
TEST=Use i2cxfer check syv682x setting.
Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com>
Change-Id: Ice496d7065af33576cb06880e05aac1c52f598a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3310027
Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
Reviewed-by: Eric Herrmann <eherrmann@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable PD_PREFER_LOW_VOLTAGE to select PDO which is lower voltage if
there are two PDOs with same max power. It can have higher power
efficiency.
BUG=b:208394216
BRANCH=None
TEST=make -j BOARD=taeko
Signed-off-by: reno.wang <reno.wang@lcfc.corp-partner.google.com>
Change-Id: I61348f44a5ec7798dfbf94914f40a0fc4e280998
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3247511
Reviewed-by: Boris Mittelberg <bmbm@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add PLATFORM_EC_USBC_PPC_RT1718S, and PLATFORM_EC_USB_PD_TCPM_RT1718S.
BUG=b:203739613
TEST=zmake testall
BRANCH=none
Change-Id: I663bbb29f38dfc925675a6f1beddeb3c976722fe
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3310017
Commit-Queue: Eric Yilun Lin <yllin@google.com>
Tested-by: Eric Yilun Lin <yllin@google.com>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to meet the specification of LCD brightness,
it is necessary to set the current value of the LCD controller.
BUG=b:202344727
BRANCH=None
TEST=make -j BOARD=bugzzy
Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com>
Change-Id: I3299707fdb653cd1c28494781307972ee750c6b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3306770
Reviewed-by: Henry Sun <henrysun@google.com>
Commit-Queue: Henry Sun <henrysun@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update board files for redrix to use new coefficients for als and
rgb sensor.
BUG=b:196313037
BRANCH=main
TEST='make -j BOARD=redrix' in EC repo, verified builds succeed.
Change-Id: I1d90a414daecec24f5139a7acb8150e195166502
Signed-off-by: Isaac Lee <isaaclee@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3268040
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Reviewed-by: YH Lin <yueherngl@chromium.org>
Tested-by: Fang (Annabelle) Liu <afliu@google.com>
Tested-by: Devin Lu <Devin.Lu@quantatw.com>
Commit-Queue: YH Lin <yueherngl@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enabling LTO buys us about 10K of flash, which will probably hold out
this board on ToT for much longer.
BUG=b:208691054
BRANCH=none
TEST=RO: 10176 bytes in flash and 8768 bytes in RAM still available
RW: 18308 bytes in flash and 8768 bytes in RAM still available
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I7c10e10d8bc9aa7b4f86c70909974a16334fa905
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3311885
Commit-Queue: Evan Green <evgreen@chromium.org>
Reviewed-by: Evan Green <evgreen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Verify set_vbus_source_current_limit function correctly sets registers.
BRANCH=none
BUG=b:203364783
TEST=zmake configure --test test-drivers
TEST=make runhosttests
Signed-off-by: Aaron Massey <aaronmassey@google.com>
Change-Id: I076eb8df42f56a9ed6a7f71df42abec8adc768f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3311880
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable tachometer for fan.
BRANCH=none
BUG=none
TEST=on board it8xxx2_evb,
console cmd "fanset 3000" -> fan spin and "faninfo"
Actual: 3150 rpm
Target: 3000 rpm
Duty: 36%%
Status: 2 (locked)
Mode: rpm
Auto: no
Enable: yes
Cq-Depend: chromium:3307946
Change-Id: I876649ad9c5d75ffaa064b13b3defe39e74bb418
Signed-off-by: Ruibin Chang <Ruibin.Chang@ite.com.tw>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3255094
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Leverage pwm and fan settings from cros_ec/main:it8xxx2_evb.
And this is convenient to check pwm or fan channel waveform in
the same pin.
Pwm output 324Hz isn't enough to turn on the fan, so set it to 30000Hz.
And we use 324Hz to test pwm maximum output in EC power saving mode.
BRANCH=none
BUG=none
TEST=zmake board it8xxx2_evb
Signed-off-by: Ruibin Chang <Ruibin.Chang@ite.com.tw>
Change-Id: I0e5c023a634f9a936c29b6bec399d86e66edffeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3310020
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable monitoring of the SLP_S5 virtual wire to allow for residency in
the S4 state on volteer platforms.
BRANCH=None
BUG=b:204947672
TEST=hiberman hibernate --test-keys on volteer, plus some reboots
Signed-off-by: Evan Green <evgreen@chromium.org>
Change-Id: I06431bd780aa28db57eaeb00c43522d337cd3a1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3289944
Commit-Queue: Keith Short <keithshort@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add SLP_S5_SIGNAL_L as a power signal we start observing and reporting
changes on for alderlake. Note that without
CONFIG_HOSTCMD_ESPI_VW_SLP_S5, no software actually responds to changes
on this line. Additionally, without the above config switched on,
SLP_S5_SIGNAL_L defaults to SLP_S4_SIGNAL_L, so we're actually watching
VW_SLP_S4 and reporting it as SLP_S5_DEASSERTED. There's nothing
technically wrong with this (since nobody takes any action now on the
new signal anyway). But to keep things comprehensible I'll add a
dependency on the change that flips on VW_SLP_S5 support, where we'll
actually start watching, reporting on, and responding to VW_SLP_S5
under its correct power signal name.
BRANCH=None
BUG=b:204947672
TEST=hiberman hibernate --test-keys on volteer
Cq-Depend: chromium:3289944
Signed-off-by: Evan Green <evgreen@chromium.org>
Change-Id: I23191e2a422f1813c2a3d72614f2d7503aacde20
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3310528
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable the configs on Alderlake systems to pay attention
to SLP_S5 virtual wire changes, and begin advertising S4 residency to
the AP.
BRANCH=None
BUG=b:204947672
TEST=hiberman hibernate --test-keys on volteer
Signed-off-by: Evan Green <evgreen@chromium.org>
Change-Id: I9a4d999e38ec48cef8ed46833ad780be3c3a5568
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3286185
Commit-Queue: Keith Short <keithshort@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add SLP_S5 as a power signal to watch and generate interrupts for when
it changes. This change doesn't really do anything by itself since
there's no software which observes and responds to these changes.
Additionally, without CONFIG_HOSTCMD_ESPI_VW_SLP_S5, SLP_S5_SIGNAL_L is
defined to SLP_S4_SIGNAL_L, so we're actually reporting changes of
VW_SLP_S4 under this new power signal. In the next CL, we'll wire up
the common SLP_S5 power signal to this virtual wire so that the
power state machine can actually see changes on this line. A Cq-Depend
line is added, though not technically necessary, to indicate this
somewhat mind-melting state is only transient.
BRANCH=None
BUG=b:204947672
TEST=hiberman hibernate --test-keys on volteer
Cq-Depend: chromium:3286185
Signed-off-by: Evan Green <evgreen@chromium.org>
Change-Id: I77b1aad508eeae3b3f8b307d02cb98460341e6bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3310527
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change `zmake configure --coverage --build` to only build the
all.libraries target (instead of failing as it does now), and generate
an lcov file.
Change `zmake coverage` to skip non-test projects. It hasn't actually
been useful to have a coverage report that includes all projects.
Change .gitlab-ci.yml commands from
build tests & boards coverage, merge, remove zephyr dirs, remove
non-board files, generate report
to build tests, merge, remove zephyr dirs, build board coverage, remove
zephyr dirs, merge with tests, remove non-board files, generate report.
This should increase coverage numbers, because we won't include #ifdefs
that both the board and tests don't use, but other boards do use. This
does not fix the problem of a test having an #ifdef that the board
doesn't have, but those should be smaller, and easier to fix.
Before: https://gitlab.com/zephyr-ec/ec/-/pipelines/420506965/builds
After: https://gitlab.com/zephyr-ec/ec/-/pipelines/420547936/builds
BRANCH=None
BUG=b:207689703
TEST=Pushed to gitlab coverage branch
Change-Id: Ifad0d098e5db9ef0ee55b760aaa7a8da9d006387
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3310533
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Tristan Honscheid <honscheid@google.com>
Reviewed-by: Tristan Honscheid <honscheid@google.com>
|