summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* anahera: Configure FRS GPIOs for PPCDevin Lu2022-02-152-2/+4
| | | | | | | | | | | BRANCH=none BUG=b:218754289 TEST=buildall Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: I31c70c307861366f541d35b1a9e3307dce17f638 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3455104 Reviewed-by: caveh jalali <caveh@chromium.org>
* zephyr: Update docs in test/driversAndrew McRae2022-02-151-4/+4
| | | | | | | | | | | | | | | Update README.md in test/drivers to remove deprecated target. BUG=none TEST=none BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Ia268508859cb14473bd7ac0a4001a18938a4661c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3463102 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: eeprom: use Zephry EEPROM driverDawid Niedzwiecki2022-02-1515-15/+82
| | | | | | | | | | | | | | | | | | | | | | Start using the Zephyr EEPROM driver. ECs use M24C02 EEPROM that can be handled with AT24 driver. Remove wp-gpios property from EEPROM nodes because it points to GPIO that is used to set WP, not read. The WP status is set by other board components. The change increases usage of flash by 712 bytes and RAM by 32 bytes. BUG=b:211779766 TEST=verify CBI can be read and set with 'cbi' console commands e.g. 'cbi' to read all CBI and 'cbi set 2 10 4' to set SKU to 10 BRANCH=main Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: Iddaf28fbcfb4c0e047c82b10e819b2ca2702b68a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3405040 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Dawid Niedzwiecki <dawidn@google.com>
* krabby: increase stack sizeTing Shen2022-02-151-0/+7
| | | | | | | | | | | | | BUG=none TEST=`taskinfo`, verify that all tasks has <90% stack usage. BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I9cd769b96bc7f79de628817fae00b2c908230451 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3455323 Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* moli: Initial EC imageRaihow Shi2022-02-1513-0/+1609
| | | | | | | | | | | | | | | | Create the initial EC image for the moli variant by copying the brask reference board EC files into a new directory named for the variant. (Auto-Generated by create_initial_ec_image.sh version 1.5.0). BUG=b:214439135 BRANCH=None TEST=make BOARD=moli Signed-off-by: Raihow Shi <raihow_shi@wistron.corp-partner.google.com> Change-Id: I6a6a86973280ec493292bc64e0fd6e661a2b7622 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3450008 Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
* volmar: Remove unused pwm and update LED behaviorYu-An Chen2022-02-154-118/+65
| | | | | | | | | | | | | Remove unused pwm and update LED behavior BUG=b:211891086 BRANCH=none TEST=Check LED status in each state Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: I55c6d5aa82515072c5461809fb463d52f2368718 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3460766 Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* zephyr: subsys/ap_pwrseq: Add espi callback handlingDivya Sasidharan2022-02-156-0/+134
| | | | | | | | | | | | | | | Change of power signals over espi (SLP_S3/S4/S5) would change the power sequence state machine. BUG=b:203446068 BRANCH=None TEST=zmake testall; verified prints to indicate SLP signal changes during boot. Change-Id: Icabcddfabf687470f5266a7d537343691877c198 Signed-off-by: Divya Sasidharan <divya.s.sasidharan@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3378975 Reviewed-by: Andrew McRae <amcrae@google.com>
* rammus: Disable HC debug by defaultGwendal Grignou2022-02-151-0/+8
| | | | | | | | | | | | | | | | Similar to commit 27e8d040b368 ("nocturne: Disable HC debug by default"). When sensors are in use, host queries EC often. BUG=b:205354460 TEST=compile. Apply change in rammus branch, check on DUT that host command messages are gone. BRANCH=rammus Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Change-Id: Ia828428ab940a0c7faa627fa3655b4f7ce5cd9b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3456704 Reviewed-by: Ricardo Quesada <ricardoq@chromium.org>
* zephyr: subsys/ap_pwrseq: Add shutdown sequence and console commandsDivya Sasidharan2022-02-157-4/+165
| | | | | | | | | | | | | | | | * This adds shutdown handling without monitoring signals. * Adds console commands apreset, powerup, apshutdown, powerinfo for debug. BUG=b:203446068 BRANCH=None TEST=zmake testall; make buildall; tested on brya, AP goes to G3 with apshutdown command, boots up with reboot. Change-Id: I89e0fd90371c84d8538e0fdb7258841038217a9b Signed-off-by: Divya Sasidharan <divya.s.sasidharan@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3378893 Reviewed-by: Andrew McRae <amcrae@google.com>
* volmar: Update FW_CONFIG fieldYu-An Chen2022-02-141-3/+3
| | | | | | | | | | | | | This patch update the FW_CONFIG field for volmar BUG=b:213162351 BRANCH=brya TEST=check system boot Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: Ic9a65a0745213358139af35e161685aa1ed2f0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3460773 Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* volmar: Remove retimer configYu-An Chen2022-02-144-85/+8
| | | | | | | | | | | | | Remove retimer config BUG=b:211891086 BRANCH=none TEST=Check usb3/usb2/dp working Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: Iec9982a43923e7d36cfd5db7804db5aab2deaedc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3454622 Reviewed-by: Boris Mittelberg <bmbm@google.com> Commit-Queue: caveh jalali <caveh@chromium.org>
* volmar: Remove GPIO_ID_1_EC_KB_BL_ENYu-An Chen2022-02-141-2/+0
| | | | | | | | | | | | | Remove GPIO_ID_1_EC_KB_BL_EN due to outdated BUG=b:211891086 BRANCH=none TEST=make BOARD=volmar Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: Ia6fe7d01563b6f840c72679f16f4d172fe76b084 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3460769 Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* volmar: Add battery AP18C8KYu-An Chen2022-02-142-0/+29
| | | | | | | | | | | | | Add battery AP18C8K BUG=b:218976941 BRANCH=none TEST=Check battery charge/discharge/cutoff working Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: I76bf826e1df7e0fdd837592324c5100df67ad3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3460764 Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* volmar: Add battery COSMX AP20CBLYu-An Chen2022-02-142-1/+33
| | | | | | | | | | | | | | | | Add battery COSMX AP20CBL BUG=b:218976941 BRANCH=none TEST=Check battery charge/discharge/cutoff working Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: I2db979d34e9b225ff643cbe56be3e7b544cd2052 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3455103 Tested-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Auto-Submit: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* brya: Add genvif overridesCaveh Jalali2022-02-141-3/+148
| | | | | | | | | | | | | | | | | | | | | | | | | | This adds VIF overrides to describe brya's USB setup. The override values are largely based on https://issuetracker.google.com/214339085#comment4 BRANCH=none BUG=b:214191903 TEST=buildall passes imported resulting build/brya/brya_vif.xml into VifEditor 3.2.3.0. there were no highlighted (error) fields. exported file and compared against input: there were no material differences. the only strangeness is that due to how genvif is implemented, it places SrcPdoList, SnkPdoList toward the end of component elements instead of in the middle - this needs to be taken into account when comparing the output of these utilities. Change-Id: I3776b4fae7b614dba61ca0c57e69701add75b502 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3428926 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* genvif: Add "vif:" namespaceCaveh Jalali2022-02-148-705/+705
| | | | | | | | | | | | | | This updates genvif to use the XML "vif:" namespace for VIF files. This makes genvif output consistent with usb.org's VifEditor 3.2.3.0 utility. BRANCH=none BUG=b:217284675 TEST=buildall passes Signed-off-by: Caveh Jalali <caveh@chromium.org> Change-Id: I072f4b726aad03dcc383d6038ddc00feebfcfd65 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3454865 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* genvif: Add section commentsCaveh Jalali2022-02-142-2/+109
| | | | | | | | | | | | | | | This updates genvif to produce section comments in its generated VIF file. This makes genvif output consistent with usb.org's VifEditor 3.2.3.0 utility. BRANCH=none BUG=b:217284675 TEST=buildall passes Change-Id: I259963cc3ac77764917832db44cf4e6609ade08e Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3428931 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* zephyr: Fix comment referencing functionAndrew McRae2022-02-141-1/+1
| | | | | | | | | | | | | | | Reference the Zephyr GPIO API instead of the legacy API. BUG=b:216466985 TEST=zmake testall BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Ifd6bb8e0974ead5f99b3bf3c49a35683dc2bb043 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3459582 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* Quackingstick: fix led behavior while battery errorSue Chen2022-02-141-1/+1
| | | | | | | | | | | | | | | | Fix the period from LED_HALF_ONE_SEC to LED_ONE_SEC when state is PWR_STATE_ERROR. BUG=b:216080496 BRANCH=trogdor TEST=LED behavior is correct when battery error. Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: If633a6aa05570501c615dd55a49d691b1b4e1618 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3460772 Tested-by: Kuen Liu <kuen.liu@quanta.corp-partner.google.com> Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Wai-Hong Tam <waihong@google.com>
* zephyr: subsys/ap_pwrseq: Add inbuilt power sequencing supportDivya Sasidharan2022-02-1413-0/+884
| | | | | | | | | | | | | | | | | | | | | | | | | Add inbuilt AP power sequencing support. This patch adds power up sequence for AP. Built on top of below reference: https://github.com/zephyrproject-rtos/zephyr/pull/29245 TODO: * b:216764983: Create separate .yaml for common and chipset specific GPIOS. * b:217952699: Subsys to driver model, override to callback implementation change. BUG=b:203446068 BRANCH=None TEST=zmake testall; make buildall; brya boots up to S0 and display is up. Change-Id: I84ce803d4e1b4594dc3f61bd2d8bcd1f94fd2be8 Signed-off-by: Divya Sasidharan <divya.s.sasidharan@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3377810 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Reviewed-by: Andrew McRae <amcrae@google.com>
* Zephyr: Allow RSMRST delay to be set for AMDDiana Z2022-02-141-7/+8
| | | | | | | | | | | | | | | AMD platforms also use the RSMRST delay configuration, so allow it to be set for either AMD or Intel. BRANCH=None BUG=b:218867363 TEST=zmake testall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Ib399640023b7091ddfbc2a79e3a9127f80cd895f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3456684 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* zephyr: Restore legacy GPIO testsAndrew McRae2022-02-141-1/+66
| | | | | | | | | | | | | | To ensure full coverage, restore tests of legacy GPIO API. BUG=b:219368141 TEST=zmake configure --test test/drivers BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I819d63612b12054bc12acc89e851e22ac1eb0833 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3460763 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: test: Verify attach snk then src usbAaron Massey2022-02-141-2/+154
| | | | | | | | | | | | | | Attach the sink then attach the source and verify PD_INFO host command responses using default values. BRANCH=none BUG=b:209907615 TEST=zmake configure --test test-drivers Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I8971f6859d5d928c47a875256feb0b38014a2bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3452937 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* zephyr: test: Use defined constants for src/snkAaron Massey2022-02-141-25/+28
| | | | | | | | | | | | | | | Instead of asserting with known values for ports and measures, pin these values to constants that are used throughout the test with names that indicate their meaning. BRANCH=none BUG=b:209907615 TEST=zmake configure --test test-drivers Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: Ie06e4abdde3cbc4fc38dc76ba27dd94eb66b33a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3452936 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* zephyr: test: Unify split src then snk usb testsAaron Massey2022-02-141-202/+16
| | | | | | | | | | | | | | | | | | | | The attach src then snk integration tests were too concise by only doing a single assertion per test, where each member of the struct returned by the PD info host command contained its own test. This resulted in unnecessary boilerplate and redundant executions of the PD info host command. Combine tests to verify entire response for each invocation of the PD info host command. BRANCH=none BUG=b:209907615 TEST=zmake configure --test test-drivers Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: Ie1d1bdd863c518c67eae94fac94c0c759a4c59b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3453166 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* guybrush: Set min charger for power on to 65WRob Barnes2022-02-141-2/+2
| | | | | | | | | | | | | | Guybrush cannot boot to OS reliably when charger is <65W and no battery is connected. BUG=b:202754460 BRANCH=guybrush TEST=500 reboot cycles with 65W charger and no battery Change-Id: Ie0453f85f683dc741f1d5cb0750399ee6d32da34 Signed-off-by: Rob Barnes <robbarnes@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3457943 Reviewed-by: Diana Z <dzigterman@chromium.org>
* Reland "zephyr: zmake: Drop support for building by project directory"Jack Rosenthal2022-02-143-17/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 59e9e0544ec4e449b11267053e5525d6de372a39. With the CL in the CQ depend, this should now be safe to land. Original change's description: > Revert "zephyr: zmake: Drop support for building by project directory" > > This reverts commit 848a4a66b61a656d0bd0739526656f67213ee66e. > > Reason for revert: broke trogdor-zephyr > https://ci.chromium.org/p/chromeos/builders/postsubmit/trogdor-zephyr-postsubmit > > Original change's description: > > zephyr: zmake: Drop support for building by project directory > > > > This has been deprecated since November, and all code and > > documentation has been updated to no longer mention building by > > project directory path. Therefore, let's drop support for it. > > > > BUG=b:218868887 > > BRANCH=none > > TEST=unit tests pass > > > > Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> > > Change-Id: I4f0762df289a413007a8409c6a39026db8056937 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3452934 > > Reviewed-by: Jeremy Bettis <jbettis@chromium.org> > > Bug: b:218868887 > Change-Id: I59f593aef0b9490a35b22c65d50bf5f978e56eb1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3454742 > Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> > Tested-by: Jack Rosenthal <jrosenth@chromium.org> > Reviewed-by: Evan Benn <evanbenn@chromium.org> > Tested-by: Evan Benn <evanbenn@chromium.org> > Owners-Override: Evan Benn <evanbenn@chromium.org> Change-Id: I6f6e5a7594225b18ddc00c922c34ee87ee709420 Cq-Depend: chromium:3452985 Bug: b:218868887 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3456705 Tested-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
* nissa/nereid: implement board_set_active_charge_portPeter Marheine2022-02-141-1/+50
| | | | | | | | | | | | | | | This change makes the Nereid charger actually be enabled when the charger task requests it, allowing the battery to charge. BUG=b:201000844 TEST=battery now charges at ~4400 mA when charging from port C0 with PD contract for 3A at 20V, stops charging with `chgoverride -2` BRANCH=none Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: If22f10954c71a2d2f7f5007eeb115770a9723a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3449990 Reviewed-by: Andrew McRae <amcrae@google.com>
* nissa/nereid: implement pd_check_vbus_levelPeter Marheine2022-02-141-3/+23
| | | | | | | | | | | | | | | | | This function is used by USB-C code to poll whether VBUS is present on the port, and is polled in some states so it uses the cached vbus present bit provided by the charger (and actuated via interrupts) rather than doing a I2C transaction to read the analog voltage on each call. BUG=b:218747760 TEST=Nereid operates normally BRANCH=none Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: Iad45c084727bd4b148de423d64c92955290535c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3459584 Reviewed-by: Andrew McRae <amcrae@google.com>
* nissa: use Zephyr logging APIsPeter Marheine2022-02-144-16/+24
| | | | | | | | | | | | | | Rather than EC-OS-style CPRINTS macros, use Zephyr logging. The module is defined as all of the Nissa project code. BUG=none TEST=Sub-board messages still appear when running on Nereid BRANCH=none Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: Ifccc4c7442e4de2296019b8d5d1dd8a8d62c6ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3459583 Reviewed-by: Andrew McRae <amcrae@google.com>
* dt-gpionames: Update README.md and add shell scriptAndrew McRae2022-02-142-23/+67
| | | | | | | | | | | | | | SDK now has go 1.17, so update README.md Add a shell script to make it easy to run utility. BUG=b:219379591 TEST=run and check output BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Id16369b63a14c2c34381c4841a38ea8ca59a383d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3460765 Reviewed-by: Yuval Peress <peress@google.com>
* volmar: Remove unused sensorYu-An Chen2022-02-145-150/+2
| | | | | | | | | | | | Remove motion sensor task and configuration BUG=b:211891086 BRANCH=none TEST=Check system boot Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: I06cca397525b5e78449d9d8d574383d18039cae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3454466 Reviewed-by: Boris Mittelberg <bmbm@google.com>
* nissa/nereid: implement pd_power_supply_resetPeter Marheine2022-02-142-0/+19
| | | | | | | | | | | | | | | This safely resets the charger for a port when requested by the policy engine, including discharging VBUS. The implementation is borrowed from dedede. BUG=b:201000844 TEST=build and flash nereid BRANCH=none Change-Id: I6bae0828ab4e24aaeadf5ff84c888c6c52148f08 Signed-off-by: Peter Marheine <pmarheine@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3449991 Reviewed-by: Andrew McRae <amcrae@google.com>
* zephyr: Convert test code to use Zephyr GPIO APIAndrew McRae2022-02-133-75/+97
| | | | | | | | | | | | | | | | | | | | | Convert the test modules to use the Zephyr GPIO API. Several of the tests are testing the legacy API (gpio_reset() etc.) and these are only used in limited places by the common EC code. At some point it may be worth considering deprecating these tests. There should be no references to any GPIO enum-name - any references to GPIO signals are derived from the DTS node of the named-gpio entry. BUG=b:216466985 TEST=zmake testall BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I02f44f966c507c2584814aa14464cd866627198f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3450534 Reviewed-by: Sam Hurst <shurst@google.com>
* zephyr: Cache the f/w boot control bits.Andrew McRae2022-02-121-2/+5
| | | | | | | | | | | | | | | | Cache the f/w boot control bits so that they are not read multiple times. It has been observed on lazor that the bits get reset (i.e set to FF) sometime after at least one read. BUG=b:218820985 TEST=zmake configure -b lazor; flash and run BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I8901b988b27f932c584b702e66487f2c0a81a7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3454927 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* lazor: Adjust Zephyr stack sizes (from taskinfo).Andrew McRae2022-02-122-6/+7
| | | | | | | | | | | | | | | Update the stack sizes according to patch from Nuvoton. Enable the taskinfo cmd to view stack sizes, and define SOC_SERIES_NPCX7 so that new stack sizes are picked up. BUG=b:218820985 TEST=zmake configure -b lazor; flash & run BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I9305d460fd688ccaa7b6d8124fa18989268b87c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3454926 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* zephyr: Create Kconfig.ap_powerSam Hurst2022-02-123-53/+57
| | | | | | | | | | | | | | | Split AP Power Kconfig options from Kconfig.usbc and place in a separate file named Kconfig.ap_power. BUG=b:208437225 TEST=Verified Kconfig options with menuconfig BRANCH=main Signed-off-by: Sam Hurst <shurst@google.com> Change-Id: I38438ad1fb935c6afc19af936b3ee1c5995a7a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3445102 Reviewed-by: Wai-Hong Tam <waihong@google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: Add USBA for herobrine_npcx9 to device treeSam Hurst2022-02-122-5/+6
| | | | | | | | | | | | | | | | This patch removes custom USBA logic and uses device tree implementation instead. BRANCH=main BUG=b:194432779 TEST=zmake configure -b herobrine_npcx9 Signed-off-by: Sam Hurst <shurst@google.org> Change-Id: I2c75c325822ada4f06be173f3ac7c5d687c50f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3451517 Tested-by: Sam Hurst <shurst@google.com> Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Sam Hurst <shurst@google.com>
* unittest: update unit test for new genvifCaveh Jalali2022-02-122-97/+103
| | | | | | | | | | | BRANCH=none BUG=b:217284675 TEST=buildall passes Change-Id: I7fc526c1d3d1bbb10886e426a11e504d602ba044 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3454864 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* genvif: Add support for USB4 related fieldsCaveh Jalali2022-02-121-3/+58
| | | | | | | | | | | | | | | | | This adds support for 3 USB4 related fields: USB4_TBT3_Compatibility_Supported USB4_PCIe_Tunneling_Supported USB4_Max_Speed BRANCH=none BUG=b:217284675 TEST=buildall passes Change-Id: I4d39d0bd3140aeae8cc9b3c5159e4b709f53f683 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3428933 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* genvif: Add support for Alt_Mode_Adapter fieldCaveh Jalali2022-02-121-0/+14
| | | | | | | | | | | | | Type_C_Is_Alt_Mode_Adapter now a required field (since rev 3.17). BRANCH=none BUG=b:217284675 TEST=buildall passes Change-Id: I46698fb6bc5ebfb2c3a804b505077349c5f8341f Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3454863 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* genvif: Upgrade to VIF definition version 3.18Caveh Jalali2022-02-122-92/+171
| | | | | | | | | | | | | | | | | | | This updates genvif to support VIF 3.18 and brings it in sync with VIF files generated by VIFeditor v3.2.3.0. The order in which elements are generated has been changed to match VIFeditor 3.2.3.0 to simplify comparing VIF files generated by the two utilities. BRANCH=none BUG=b:217284675 TEST=buildall passes Cq-Depend: chromium:3454864 Change-Id: I5d96be03c273886b45b38f4853928653c6cccf09 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3428932 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* zmake: Add .pylintrc and some fixes for pylintJeremy Bettis2022-02-125-7/+26
| | | | | | | | | | | | | | | | | | | | With this .pylintrc, and these tweaks, there are no errors reported by cros lint. Many warnings, but no errors. Added a pylint call to run_tests.sh. It only checks for errors, once we get the warnings cleaned up, we should change it to call cros lint instead. BRANCH=None BUG=b:217969201 TEST=run_tests.sh Change-Id: I1ad75fda3d6f818f1d1c66654823bac97ce09942 Signed-off-by: Jeremy Bettis <jbettis@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3449124 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: Add better errorsJeremy Bettis2022-02-121-4/+14
| | | | | | | | | | | | | | | Only one of the backends for the shell can be enabled at once, so add BRANCH=None BUG=b:214256453 TEST=zmake testall Change-Id: I26f828334d6200b4382ebe488f1736c8fe96034a Signed-off-by: Jeremy Bettis <jbettis@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3440835 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org>
* zmake: Add timeout to ztest testJeremy Bettis2022-02-122-5/+15
| | | | | | | | | | | | | | | | | Add a timeout for all tests run by ztest, defaulting to 2 minutes. The timeout can be customized on a test by test basis by setting test_timeout_secs in the test's BUILD.py BRANCH=None BUG=b:218493723 TEST=Set timeout to 2s, and ran zmake test on the drivers test. Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I48f56a7d67c91d482094e0dc123bdacb6ffa79df Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3449123 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr test: Test SYV682 VBUS OC limitAbe Levkoy2022-02-121-0/+30
| | | | | | | | | | | | | | | Check that the driver refuses to enable VBUS after reach the limit of VBUS over-current events. BUG=b:190519131 TEST=zmake configure --test zephyr/test/drivers BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I2b223ff3342b4e8d51270f936fd3de2d8ab960fe Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3456707 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
* zephyr: Move 1 gpio into native_posix.dtsJeremy Bettis2022-02-125-3/+30
| | | | | | | | | | | | | | | | Move the entering_rw (GPIO_ENTERING_RW) into native_posix.dts, as all tests will need this once we start linking common/system.c. BRANCH=None BUG=b:214256453 TEST=zmake testall Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I57ee5c62b2ad06d0613aebe82e4af0cf1bd480f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3451270 Tested-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Tristan Honscheid <honscheid@google.com> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
* zephyr: add support for USBA in device treeSam Hurst2022-02-123-0/+34
| | | | | | | | | | | | | | | | | | This commit adds support for USBA definition in device tree. It will allow to remove board specific files which implemented the tcpc functionalities. This will unify the logic between different board in zephyr. BRANCH=main BUG=b:194432779 TEST=zmake configure -b herobrine_npcx9 Signed-off-by: Sam Hurst <shurst@google.org> Change-Id: I3f775fb284ab5a977bc63444d457d0752f73dff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3451516 Tested-by: Sam Hurst <shurst@google.com> Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Sam Hurst <shurst@google.com>
* qcom: Swap a reliable signal to confirm PMIC powerWai-Hong Tam2022-02-121-2/+2
| | | | | | | | | | | | | | | | | | | | Previously, we used the PMIC_KPD_PWR_ODL as a signal to confirm if the PMIC is powered. In the recent QC project, the KPD_PWR_N has internal pull-up to a PMIC's 1.1V rail. The 1.1V is under the Vih(min). So the EC may sample it incorrectly and may lead to a wrong decision path. The PMIC_RESIN_L signal has internal pull-up to a 1.8V. Using this signal is more reliable. BRANCH=None BUG=b:218876104 TEST=Verified the power-on and power-off sequence. Change-Id: I9217f334f2684a8b4265a44f3b10b07412a250d2 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3456706 Reviewed-by: Stephen Boyd <swboyd@chromium.org>
* genvif: Add XML start/end tag helpersCaveh Jalali2022-02-121-83/+141
| | | | | | | | | | | | | | | | | In preparation for supporting a namespace qualifier in generated VIF files, introduce and use functions to handle XML start/end tags in preference over generic string troutines. BRANCH=none BUG=b:217284675 TEST=buildall passes, verified all generated *_vif.xml files match previous build Signed-off-by: Caveh Jalali <caveh@chromium.org> Change-Id: Id6fcaaecd6da9dc7d7f5f5f7ebf7a670817702a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3454862 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
View Lorry Controller Status