summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* zephyr: fan: misc cleanupsstabilize-14528.B-mainFabio Baltieri2022-02-181-61/+94
| | | | | | | | | | | | | | | | | | | | | | Various cleanups on the fan driver: - split includes from system and application - always use braces in around if blocks - break down fan_tick_func to avoid deep indentation - drop type qualifiers (p_) - move few comments Should be no functional changes, I dropped a volatile qualifier that I don't think was necessary. BRANCH=none BUG=none TEST=build and run on volteer TEST=zmake testall Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I88206d8b9a1d1df2f50c1934d7dc93441fd59aef Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3471597 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* dojo: Set EN_KB_BL on/off while chipset resume/suspendTommy Chung2022-02-182-2/+12
| | | | | | | | | | | | | | | Since GPIO_EN_KEYBOARD_BACKLIGHT is only enabled when current_percent is not 0, enable EN_KB_BL while chipset resume on board level. (CL:3403363) BUG=none BRANCH=cherry TEST=make sure that KB BL works when chipset resume to S0. Signed-off-by: Tommy Chung <tommy.chung@quanta.corp-partner.google.com> Change-Id: Ife8c5d432754c246640794ce7e8acd55fced279b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3412627 Reviewed-by: Eric Yilun Lin <yllin@google.com>
* docs: zephyr: Provide example of motionsense DTSYuval Peress2022-02-181-6/+101
| | | | | | | | | | | | | | Add an example of the various devicetree compontents of initializing motionsense. BRANCH=none BUG=b:208437221 TEST=none Signed-off-by: Yuval Peress <peress@google.com> Change-Id: Ie2be39bd378ff8c6ccd868d916cc10a6a410e098 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3459249 Reviewed-by: Keith Short <keithshort@chromium.org>
* docs: zephyr: Add testing information about motionsenseYuval Peress2022-02-181-1/+26
| | | | | | | | | | | | | | Add some general guidelines for tests that can be run to make sure that motionsense was initialized correctly. BRANCH=none BUG=b:208437221 TEST=none Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I06c0bb77373e149bca8eaee8d08a0581bd04fcab Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3459248 Reviewed-by: Keith Short <keithshort@chromium.org>
* docs: zephyr: Add information about motionsenseYuval Peress2022-02-181-3/+5
| | | | | | | | | | | | | | Include documentation detailing that motionsense requires no board specific code as well as how to configure the motionsense task. BRANCH=none BUG=b:208437221 TEST=none Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I2a408605b734c10e872177f751bae4ad47ca8902 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3459943 Reviewed-by: Keith Short <keithshort@chromium.org>
* docs: zephyr: Add more information about motionsenseYuval Peress2022-02-181-3/+49
| | | | | | | | | | | | | | Add details about the various devicetree nodes and configuration needed for Zephyr motionsense initialization. BRANCH=none BUG=b:208437221 TEST=none Signed-off-by: Yuval Peress <peress@google.com> Change-Id: Id2b0b7622bfc387119a3977069adf673f6943e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3459942 Reviewed-by: Keith Short <keithshort@chromium.org>
* nipperkin: support thermal table v06Zick Wei2022-02-182-4/+4
| | | | | | | | | | | BUG=b:219616787 BRANCH=nipperkin TEST=verify thermal setting work as intended. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I257e97e3ef9c254b35ebf78996be9fe8f10f588f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3463100 Reviewed-by: Diana Z <dzigterman@chromium.org>
* crota: configure EC GPIO/ I2C channelPeter Chi2022-02-189-420/+131
| | | | | | | | | | | | | Remove USB C1 code. BUG=b:219176652 b:219378769 BRANCH=none TEST=make -j BOARD=crota Signed-off-by: Peter Chi <peter_chi@wistron.corp-partner.google.com> Change-Id: Ie9a0ebcda0b19818785e544df5c91fb5cf434ae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3459591 Reviewed-by: caveh jalali <caveh@chromium.org>
* Banshee: Modify ALS driveOwen_Ou2022-02-183-82/+13
| | | | | | | | | | | | | | | | | Banshee ALS dirive modify als cm32183 and remove als TCS3400 . BUG=b:208721153 BRANCH=none TEST=make -j BOARD=banshee Signed-off-by: Owen_Ou <Owen_Ou@compal.corp-partner.google.com> Change-Id: Ie836f893863a31174a06f7b388cf4defd53a7f10 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3448064 Tested-by: Owen Ou <owen_ou@compal.corp-partner.google.com> Auto-Submit: Owen Ou <owen_ou@compal.corp-partner.google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Boris Mittelberg <bmbm@google.com> Commit-Queue: Boris Mittelberg <bmbm@google.com>
* nissa: configure voltage divider on EC_VSENSE_PP3300_S5Peter Marheine2022-02-182-0/+24
| | | | | | | | | | | | | | | | | | | | | | The hardware has a divider on the EC monitoring pin for the PP3300_S5 power rail because neither of the NPCX9 nor IT8xxx2 ECs can measure the full-scale 3.3V rail. Configure it for the shim code. Zephyr doesn't support generic voltage dividers on ADC inputs, so nothing is done for those. Zephyr code that reads the ADC will need to be divider-aware if required. BUG=b:220001622 TEST=nivviks: `adc` now shows EC_VSENSE_PP3300_S5 at 3293 mV rather than 2714 mV after PP3300_S5 is turned on (`gpioset en_pp3300_s5 1`). nereid: `adc EC_VSENSE_PP300_S5` shows expected ~3300 mV when the rail is turned on. BRANCH=none Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: I10f49760196e41b295674a9120da6d2eed02e9fd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3470818 Reviewed-by: Andrew McRae <amcrae@google.com>
* zephyr: shim: drop the PWM_CH_KBLIGHT definitionFabio Baltieri2022-02-181-1/+0
| | | | | | | | | | | | | | | This is not needed anymore now that the kblight driver uses the Zephyr APIs, drop the PWM channel definition definition. BRANCH=none BUG=b:217741090 TEST=build and run, volteer TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Icc2b4c8b47c06502c06b1f48cc359a8176721e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3468506 Reviewed-by: Tristan Honscheid <honscheid@google.com>
* zephyr: replace the ecos kblight driver for a deshimmed oneFabio Baltieri2022-02-1827-88/+241
| | | | | | | | | | | | | | | | | | | | | | | Replace the ECOS pwm_kblight driver with one using the Zephyr APIs for pwm and devicetree. BRANCH=none BUG=b:217741090 TEST=build and run on volteer, play with the keyboard backlight TEST=zmake configure -b brya TEST=zmake configure -b herobrine TEST=zmake configure -b skyrim TEST=zmake configure -b lazor TEST=zmake configure -b npcx9 TEST=zmake configure -b npcx7 TEST=zmake configure -b nivviks TEST=zmake configure -b nereid Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Idb58f6bbecad4337148fd6a279ef0625247df6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3468505 Reviewed-by: Al Semjonovs <asemjonovs@google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* common: pwm: handle EC_PWM_TYPE_KB_LIGHT with the kblight APIFabio Baltieri2022-02-181-7/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change the PWM host command handling of EC_PWM_TYPE_KB_LIGHT to use the kblight APIs directly rather than the PWM ones. This makes the host command work correctly with kblight drivers that do not use the ECOS PWM APIs. Tested snippet: localhost /home/chronos/user # ectool pwmgetkblight Keyboard backlight disabled. localhost /home/chronos/user # ectool pwmgetduty kb Current PWM duty: 0 <change the backlight on the device> localhost /home/chronos/user # ectool pwmgetkblight Current keyboard backlight percent: 40 localhost /home/chronos/user # ectool pwmgetduty kb Current PWM duty: 26214 localhost /home/chronos/user # ectool pwmsetkblight 50 Keyboard backlight set. localhost /home/chronos/user # ectool pwmgetduty kb Current PWM duty: 32767 localhost /home/chronos/user # ectool pwmsetduty kb 65535 PWM set. localhost /home/chronos/user # ectool pwmgetkblight Current keyboard backlight percent: 100 BRANCH=none BUG=b:217741090 TEST=ectool kblight and pwm commands TEST=make runhosttests -j8 TEST=zmake testall Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ib73f321334ff63cd8c512d0985c3504133834ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3468504 Reviewed-by: Aaron Massey <aaronmassey@google.com>
* zephyr: test: Allocate tcpci emuls staticallyAaron Massey2022-02-181-17/+25
| | | | | | | | | | | | | | | In the src/snk tests the tcpci_src/snk_emul structs are allocated on the stack. This meant although the test was passing, it was relying on certain garbage values in memory. BRANCH=none BUG=b:209907615 TEST=zmake configure --test-drivers Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I1d8e842e415df3891ea9c9c3e274ad1255196af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3473084 Reviewed-by: Yuval Peress <peress@google.com>
* zephyr: drivers: Improve code coverage of bb_retimer.cAl Semjonovs2022-02-171-0/+26
| | | | | | | | | | | | | Add test cases to improve code coverage of bb_retimer.c BRANCH=none BUG=b:219992746 TEST=zmake -D configure --coverage --test zephyr/test/drivers/ Signed-off-by: Al Semjonovs <asemjonovs@google.com> Change-Id: Ia0efe48ac7e63bbf71cd769d4558d8e0f9f666fa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3470259 Reviewed-by: Yuval Peress <peress@google.com>
* zephyr: Create Kconfig.pd_usbc_device_typeSam Hurst2022-02-172-30/+40
| | | | | | | | | | | | | | Split PD USBC Device Type Kconfig options from Kconfig.usbc and place in a separate file named Kconfig.pd_usbc_device_type. BUG=b:194432779 TEST=Verified Kconfig options with menuconfig BRANCH=main Signed-off-by: Sam Hurst <shurst@google.com> Change-Id: Ife74d796ee6a8b838495f2eee645a49609ee59aa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3445497 Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: suppress warnings about pointers to unaligned dataMichał Barnaś2022-02-175-23/+43
| | | | | | | | | | | | | | | | | Zephyr has enabled warnings about pointers to members of packed structs. This resulted in failing compilation process. This commit supresses some warnings by using void* intermediate pointers and by using temporary variables if possible. BUG=b:210501420 BRANCH=main TEST=zmake testall && make buildall Change-Id: Ia03322e80ae2b4ba42731b066066cc466bd92baf Signed-off-by: Michał Barnaś <mb@semihalf.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3405041 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Sam Hurst <shurst@google.com>
* kinox: Initial EC imagestabilize-quickfix-14526.91.B-mainstabilize-14526.89.B-mainstabilize-14526.84.B-mainstabilize-14526.73.B-mainstabilize-14526.67.B-mainstabilize-14526.57.B-mainrelease-R100-14526.B-mainDtrain Hsu2022-02-1713-0/+1610
| | | | | | | | | | | | | | | | | | Create the initial EC image for the kinox variant by copying the brask reference board EC files into a new directory named for the variant. (Auto-Generated by create_initial_ec_image.sh version 1.5.0). BUG=b:215049181 BRANCH=None TEST=make BOARD=kinox Signed-off-by: Dtrain Hsu <dtrain_hsu@compal.corp-partner.google.com> Change-Id: I604216664a0efc690ba9cd2c0c071a0e4650b228 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3448054 Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> Commit-Queue: Zhuohao Lee <zhuohao@chromium.org>
* adlrvp: remove pull up set for EC servo uart linesDeepti Deshatty2022-02-171-1/+1
| | | | | | | | | | | | | | | Removed GPIO_PULL_UP set for the EC servo uart lines. With this change suzy-q EC logs Tx works fine on rvp. BUG=none BRANCH=none TEST=Verified Micro servo and SuzyQ EC logs on ADL-N Rvp Signed-off-by: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com> Change-Id: Id2b6be2e8d30776f42d25d353b5545e294d8f71c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3282978 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: caveh jalali <caveh@chromium.org>
* rt9490: implement dump_registersTing Shen2022-02-171-0/+34
| | | | | | | | | | | | | | | Support printing some status registers and ADCs for HW testing. BUG=b:194967754 TEST=manually run `charger dump` BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: Ic493907fe1983af974b9f7d835982944c33cdab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3351726 Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* zephyr: Create Kconfig.pd_console_cmdSam Hurst2022-02-172-50/+60
| | | | | | | | | | | | | | Split PD Console CMD Kconfig options from Kconfig.usbc and place in a separate file named Kconfig.pd_console_cmd. BUG=b:194432779 TEST=Verified Kconfig options with menuconfig BRANCH=main Signed-off-by: Sam Hurst <shurst@google.com> Change-Id: If9bea6a2bc623a6d00e26be30962d518ae93e990 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3445496 Reviewed-by: Keith Short <keithshort@chromium.org>
* nipperkin: update gpio enable/disable sequenceZick Wei2022-02-171-2/+2
| | | | | | | | | | | | | | | | We found a leakage during enable HDMI retimer, this CL update HDMI retimer enable sequence to prevent leakage. BUG=b:218975937 BRANCH=none TEST=make BOARD=nipperkin Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I9513027291ef545350c0d768b9e1aa0741e170ea Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3467377 Reviewed-by: Rob Barnes <robbarnes@google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
* redrix: Add SSFC field for 2nd LID sensorDevin Lu2022-02-175-0/+111
| | | | | | | | | | | | | This patch adds SSFC field to support the 2nd LID sensor. BUG=b:219450750 BRANCH=none TEST=On Redix. Set SSFC and make sure the LID sensor works normally. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: I5435f3d8c44745c7e53d6e8838ed31b6d798d9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3459595 Reviewed-by: caveh jalali <caveh@chromium.org>
* baseboard/brya: Add SSFC entryDevin Lu2022-02-172-0/+12
| | | | | | | | | | | | | This patch adds SSFC entry for board variants. BUG=b:219450750 BRANCH=none TEST=buildall Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: I15790834cd9a4f6b9740c097aa2de8f71e628871 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3459594 Reviewed-by: caveh jalali <caveh@chromium.org>
* vell: Set battery current Prochot# thresholdDevin Lu2022-02-171-0/+7
| | | | | | | | | | | | | | Vell battery over-discharging current is 10.5A. This patch set battery current Prochot# threshold to 10.5A. BUG=b:216391312 BRANCH=none TEST=On Vell. Check the DC PROCHOT threshold is correct. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: Ia91c61c8ff7705dec0ebf1f8c8eb8938a5ee56c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3450002 Reviewed-by: Boris Mittelberg <bmbm@google.com>
* vell: Change battery/AC current sense valueDevin Lu2022-02-171-2/+2
| | | | | | | | | | | BUG=b:216391312 BRANCH=none TEST=On Vell. Battery charging current ramp to 6.4A. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: Ie3805b5214b9ecf977e4911201504376948a9f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3450001 Reviewed-by: Boris Mittelberg <bmbm@google.com>
* nissa: correct pin definition for PP1050 monitoringPeter Marheine2022-02-174-7/+12
| | | | | | | | | | | | | | | | | This pin is used for analog monitoring of PP1050_PROC generated by the SoC, not as a power-good input. An entry is added to the named-adc enumeration because PP1050_PROC has not been used before and a legacy enum value is required even though the code using this analog channel will be Zephyr-first. BUG=b:203446068,b:219634193 TEST=EC_VSENSE_PP1050_PROD channel appears in `adc` output on Nivviks BRANCH=none Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: I26e0d7d8e3dbe0a2643b789cc5c6891ada710062 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3463101 Reviewed-by: Andrew McRae <amcrae@google.com>
* zmake: Add some python type hintsJeremy Bettis2022-02-171-60/+61
| | | | | | | | | | | | | | | | | | Some project references were not auto-completing in VSCode, so I added type hints to help. BRANCH=None BUG=None TEST=None Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I0819151f2053e0daf1012874beb72c112e7a80ef Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3462632 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: Fix broken tests when coverage is enabledJeremy Bettis2022-02-171-1/+1
| | | | | | | | | | | | | | | | | | | | | While zmake testall was passing, zmake coverage was not. Probably because of branch coverage calculation, if an if statement includes both a const portion and a non-const portion, the const portion must be first, or it won't get optimized out. BRANCH=None BUG=b:219862697 TEST=zmake -j8 coverage build/zcoverage Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I97c9aeab737702541b94b7867e02f943beb559c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3470261 Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Al Semjonovs <asemjonovs@google.com> Commit-Queue: Al Semjonovs <asemjonovs@google.com>
* driver/isl9241: Correct charger informationDevin Lu2022-02-162-6/+11
| | | | | | | | | | | | | | | This patch re-scale the maximum/minimum/step value base current sense value resistor. BUG=b:216391312 BRANCH=none TEST=buildall Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: Ic6426aa416964f2a369ecddb87ce74722527abd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3450000 Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* pazquel: Change PVC mode of DA9313 to improve high frequency noiseYunlong Jia2022-02-162-0/+33
| | | | | | | | | | | | | | | | | | | | Our team found the source of high frequency noise coming from the DA9313. Change the DA9313 PVC mode as follows: S0 -> S3 : PVC operates in auto frequency mode S3 -> S0 : PVC operates in fixed frequency mode and no more high frequency noise heard BUG=b:218973914 BRANCH=trogdor TEST=test again and no more high frequency noise heard Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com> Change-Id: If6ef403ea80dc1a006fd259d58ced7373b39c0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3455503 Reviewed-by: Bob Moragues <moragues@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Wai-Hong Tam <waihong@google.com>
* homestar/mrbland/wormdingler: Add support PS8755Siyu Qin2022-02-163-2/+7
| | | | | | | | | | | | | | | | Import PS8755 as the 2rd source for TCPC chip. BUG=b:218786366 BRANCH=trogdor TEST=make BOARD=homestar/mrbland/wormdingler -j Signed-off-by: Siyu Qin <qinsiyu@huaqin.corp-partner.google.com> Change-Id: I01185737e55bff93cea65fe0667344841231d30b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3463103 Reviewed-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com> Reviewed-by: Bob Moragues <moragues@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Wai-Hong Tam <waihong@google.com>
* Skyrim: implement battery parameterOwen_Ou2022-02-164-0/+62
| | | | | | | | | | | | | | | | | | | Setup battery parameter for skyrim. BUG=b:219670453 BRANCH=none TEST=1. zmake configure -b skyrim 2. ec can read battery info(ec log) 3. battery can charge & discharge 4. battery can cutoff Signed-off-by: Owen_Ou <Owen_Ou@compal.corp-partner.google.com> Change-Id: I94d522e75b464c55cd7b71a5e7e68493513822c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3463105 Tested-by: Owen Ou <owen_ou@compal.corp-partner.google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Diana Z <dzigterman@chromium.org>
* Skyrim: Enable RSMRST delayDiana Z2022-02-161-0/+1
| | | | | | | | | | | | | | We need to delay setting SOC_RSMRST_L high by 10ms after EN_PWR_S5 goes high, so enable CONFIG_PLATFORM_EC_POWERSEQ_RSMRST_DELAY. BRANCH=None BUG=b:218867363 TEST=on skyrim, observe correct T1 timing Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: If7a3794ebacced590d9439ba2fb60dbf2dbc3ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3456685 Reviewed-by: Keith Short <keithshort@chromium.org>
* Skyrim: Remove pull-up on 6 axis interruptDiana Z2022-02-163-3/+6
| | | | | | | | | | | | | | | Remove this pull-up as it's causing leakage. Boards should be reworked with an external pull-up for this interrupt line to work. BRANCH=None BUG=b:218536811 TEST=verify no leakage is seen on skyrim Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I959d0aee627d5dbef6c0283376955192734aeb09 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3453165 Tested-by: Charlie Costakis <ccostakis@google.com> Reviewed-by: Rob Barnes <robbarnes@google.com>
* zephyr: Create Kconfig.pd_vbus_detectionSam Hurst2022-02-162-29/+39
| | | | | | | | | | | | | | Split USBA Kconfig options from Kconfig.usbc and place in a separate file named Kconfig.pd_vbus_detection. BUG=b:194432779 TEST=Verified Kconfig options with menuconfig BRANCH=main Signed-off-by: Sam Hurst <shurst@google.com> Change-Id: I263b7f8998dc28e1c19c860830a47301ef66a578 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3446460 Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: Create Kconfig.pd_dischargeSam Hurst2022-02-162-33/+43
| | | | | | | | | | | | | | Split PD VBUS Discharge Kconfig options from Kconfig.usbc and place in a separate file named Kconfig.pd_discharge. BUG=b:194432779 TEST=Verified Kconfig options with menuconfig BRANCH=main Signed-off-by: Sam Hurst <shurst@google.com> Change-Id: I52536f70d6a0d833a0d0980f361adf0cabd6c1f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3445459 Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: Disable eeprom simulator for driver testsAndrew McRae2022-02-161-0/+1
| | | | | | | | | | | | | | | | The EEPROM simulator (enabled by default on posix builds) creates a file called eeprom.bin in the current directory. BUG=b:219832922 TEST=zmake configure --test test-drivers BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I2bea3fd27d58b08ae37a45dd6a09dacebbd3861a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3466679 Reviewed-by: Aaron Massey <aaronmassey@google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
* Reland "zephyr: Remove unused enum-name entries"Andrew McRae2022-02-1612-92/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0f6242e8bd99e0b1fe4d2f15e95bf48eb7daa516. Someone added a new reference to one of the removed enums. Reason for revert: Fixed build. BUG=b:216466985 TEST=zmake testall BRANCH=none Original change's description: > Revert "zephyr: Remove unused enum-name entries" > > This reverts commit 112bc3616b55421af4ae5003c542e9a425128650. > > Reason for revert: suspected at fault for postsubmit failures > https://ci.chromium.org/p/chromeos/builders/postsubmit/firmware-zephyr-postsubmit/14846 > > Original change's description: > > zephyr: Remove unused enum-name entries > > > > After removal of the unsupported projects, > > take another run through the enum-names to > > remove the unused entries. > > > > BUG=b:216466985 > > TEST=zmake testall > > BRANCH=none > > > > Signed-off-by: Andrew McRae <amcrae@google.com> > > Change-Id: Id652c4fda7dd64a59b3776bb52640413a31e4e3e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3446945 > > Reviewed-by: Tristan Honscheid <honscheid@google.com> > > Reviewed-by: Keith Short <keithshort@chromium.org> > > Commit-Queue: Keith Short <keithshort@chromium.org> > > Bug: b:216466985 > Change-Id: I97e4ba659b15a8860d408ec46a6629a8d292b05e > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3465516 > Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> > Tested-by: Jack Rosenthal <jrosenth@chromium.org> > Auto-Submit: Jack Rosenthal <jrosenth@chromium.org> > Reviewed-by: Keith Short <keithshort@chromium.org> > Commit-Queue: Keith Short <keithshort@chromium.org> Bug: b:216466985 Change-Id: I51284582ad8e17ab2016b65f8a31944702d70579 Signed-off-by: Andrew McRae <amcrae@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3466674 Reviewed-by: Dawid Niedzwiecki <dawidn@google.com> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* agah: update gpioZick Wei2022-02-162-8/+14
| | | | | | | | | | | | | | Update EC gpio follow schematic. BUG=b:210970640 BRANCH=none TEST=make BOARD=agah Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: If1c1ff66c8a16d9f395fb9662006768bc4cc0495 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3361699 Reviewed-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-by: caveh jalali <caveh@chromium.org>
* agah: config USBC0 port and remove dbZick Wei2022-02-169-230/+66
| | | | | | | | | | | | | | | | | | This patch update USBC0 setting: TCPC RT1716 with PPC SYV682, and remove daughter board to fit agah HW design. Will update another CL for USBC1 after function verified. BUG=b:210970640 BRANCH=none TEST=make sure USBC0 can get 60W power through servoV4 with 65W adapter. Change-Id: Ibdc1d2e4dd86a3b8383ac33622d8ca038862b721 Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3360328 Reviewed-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-by: caveh jalali <caveh@chromium.org>
* herobrine: battery: Remove '_npcx9' suffix in commentMatthias Kaehlcke2022-02-161-3/+3
| | | | | | | | | | | | | | | | The project for herobrine has been renamed from 'herobrine_npcx9' to just 'herobrine', also remove the '_npcx9' suffix from a comment in the battery info for herobrine. BRANCH=None BUG=b:215771396 TEST=zmake configure -b herobrine Change-Id: Id7d701d02fb8e5163e669c345dc71c4b07d9b32e Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3444681 Reviewed-by: Wai-Hong Tam <waihong@google.com> Reviewed-by: Bob Moragues <moragues@chromium.org>
* herobrine: Rename project to 'herobrine' (was 'herobrine_npcx9')Matthias Kaehlcke2022-02-1617-12/+12
| | | | | | | | | | | | | | | | The NPCX9 is the only EC chip that will be used by herobrine, rename the project from 'herobrine_npcx9' to 'herobrine'. BRANCH=None BUG=b:215771396 TEST=zmake configure -b herobrine Cq-Depend: chrome-internal:4546687 Change-Id: I206a65f253ce38d1b263a13df6ace90c90a0e450 Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3459518 Reviewed-by: Bob Moragues <moragues@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com>
* adlrvp: configure board specific battery type firstDeepti Deshatty2022-02-161-3/+3
| | | | | | | | | | | | | | | | | | | | board_pre_task_i2c_peripheral_init() api selects board specific battery type and charger information. Charger configure is called first and later configure battery type is called. Charger configuration uses battery type information, hence battery type needs to be configured before calling charger configuration. BUG=none BRANCH=none TEST=Verified battery fuctionality on ADL-N rvp board. Change-Id: Ie0f54fc2675721ea3f38f675eca446a32da49cf7 Signed-off-by: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3459596 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Tested-by: Deepti Deshatty <deepti.deshatty@intel.com> Reviewed-by: caveh jalali <caveh@chromium.org>
* zephyr: Create Kconfig.pd_frsSam Hurst2022-02-162-41/+51
| | | | | | | | | | | | | | Split PD FRS Kconfig options from Kconfig.usbc and place in a separate file named Kconfig.pd_frs. BUG=b:194432779 TEST=Verified Kconfig options with menuconfig BRANCH=main Signed-off-by: Sam Hurst <shurst@google.com> Change-Id: If20792ef6fe8148e77db20caa72f916086db4a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3445453 Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: Create Kconfig.pd_meas_vbusSam Hurst2022-02-162-35/+45
| | | | | | | | | | | | | | Split PD Measure VBUS Kconfig options from Kconfig.usbc and place in a separate file named Kconfig.pd_meas_vbus. BUG=b:194432779 TEST=Verified Kconfig options with menuconfig BRANCH=main Signed-off-by: Sam Hurst <shurst@google.com> Change-Id: Ic6587cfc6d419f5b9d61969d1fd78fd8efb9b019 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3445452 Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: Create Kconfig.pd_int_sharedSam Hurst2022-02-162-39/+49
| | | | | | | | | | | | | | Split PD Interrupt Shared Kconfig options from Kconfig.usbc and place in a separate file named Kconfig.pd_int_shared. BUG=b:194432779 TEST=Verified Kconfig options with menuconfig BRANCH=main Signed-off-by: Sam Hurst <shurst@google.com> Change-Id: I29164219ca8a6cf520d918d21168b928b015fb3f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3445325 Reviewed-by: Keith Short <keithshort@chromium.org>
* nissa: implement hibernate for nereidPeter Marheine2022-02-163-23/+46
| | | | | | | | | | | | | | | The board_hibernate() functions are moved out of the usbc files since hibernation isn't directly related to USB or charging. BUG=b:219808597 TEST=`hibernate` on console hibernates nereid & nivviks BRANCH=none Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: I1ff3470906e7757e62e802b9712e3f4d2616a5e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3466682 Reviewed-by: Andrew McRae <amcrae@google.com> Commit-Queue: Andrew McRae <amcrae@google.com>
* volmar: Modify USB C1 i2c port speedYu-An Chen2022-02-161-17/+0
| | | | | | | | | | | | | | | Modify the I2C frequency of I2C_PORT_USB_C1_TCPC and I2C_PORT_USB_C1_PPC from 400 kHz to 1000 kHz and disable C1_PPC dynamic speed. BUG=b:211891086 BRANCH=brya TEST=check pd 1 working Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: Ia6e20ce5ce1064add91de021f00121cf70bcfc96 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3459601 Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* zephyr: test: Verify invoke typec status host cmdAaron Massey2022-02-161-2/+15
| | | | | | | | | | | | | | To facilitate assertion failure isolation, add a test verifying only that the typec status host command can be successfully invoked. BRANCH=none BUG=b:189954415 TEST=zmake configure --test test-drivers Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I685144a6c123b24b6931783f1e0f8afc7408fd4b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3462646 Reviewed-by: Keith Short <keithshort@chromium.org>
View Lorry Controller Status