summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* nissa: Enable charger discharge on AC for testingstabilize-14588.98.B-mainstabilize-14588.14.B-mainstabilize-14588.123.B-mainrelease-R101-14588.B-mainAndrew McRae2022-03-171-0/+2
| | | | | | | | | | | | | | Both Nereid and Nivviks chargers allow discharge on AC which can be enabled for testing. BUG=b:224929764 TEST=zmake build nivviks; ectool chargecontrol discharge BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I8aa9c5ae2974b4a402cb8c634a2078fd6580e883 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3529600 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* banshee: Modify sense resistor configs of ISL9241Matt Wang2022-03-171-1/+1
| | | | | | | | | | | | | | Meet the ISL9241 spec Adapter Current Limit1(0x3F) is 20mOhm. BUG=b:222038282 BRANCH=none TEST=Charging and discharging normally on banshee Signed-off-by: Matt Wang <matt_wang@compal.corp-partner.google.com> Change-Id: I6345fb0d2b5984f9ecdb7ee475df4fc01bee4c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3529597 Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: caveh jalali <caveh@chromium.org>
* isl9241: add Control3 bit5 input current limitMatt Wang2022-03-171-0/+2
| | | | | | | | | | | | | | | | | | | | | This bit can control to enable/disable the input current limit function. ISL9241 0x4C Control3 bit5 Input Current Limit Loop Disables the input current limit loop. 0 = Enable input current limit loop (default) 1 = Disable input current limit loop BUG=b:222038282 BRANCH=none TEST=On banshee, use this bit can AC only power on the system. Signed-off-by: Matt Wang <matt_wang@compal.corp-partner.google.com> Change-Id: I12bcc968cddcdaf0e91bb6e61dd18dd14a6d07c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3522202 Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: caveh jalali <caveh@chromium.org>
* Banshee: Implement fan tableRidden_Liu2022-03-172-18/+24
| | | | | | | | | | | | | | | | | | | Modify the fan rpm min/max/start value. And modify the fan temperature setting. BUG=b:223492897 BRANCH=none TEST=make -j BOARD=banshee. Verify critical temperature of three sensors. Verify max/min of rpm. Signed-off-by: Ridden_Liu <ridden_liu@compal.corp-partner.google.com> Change-Id: I0f9745efcea10677400be5aa9d4db6eda14f0041 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3508984 Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Tested-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* nissa: Swap nivviks volume up/down buttonsAndrew McRae2022-03-172-4/+4
| | | | | | | | | | | | | | Changes to reflect actual button layout. BUG=b:224884220 TEST=zmake build nivviks; flash and run and check buttons BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I33eca0b0ebcf05a7792dccf4fad1d5a4544bed81 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3529595 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Commit-Queue: Peter Marheine <pmarheine@chromium.org>
* Banshee: change LED active port conditionLeo-Tsai2022-03-171-3/+13
| | | | | | | | | | | | | | | | | This patch is modified LEFT and RIGHT port to avoid C0 port can't set colors BUG=b:208182468,b:220954645 BRANCH=none TEST=build make -j BOARD=Banshee pass, verified the C0 port can show color after unit is charger Signed-off-by: Leo-Tsai <leocx_tsai@compal.corp-partner.google.com> Change-Id: I7ac57c9db19d3caeb647325575f35cf739d21fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3522473 Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Tested-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
* landia: Porting keyboard.Hank Xie2022-03-171-1/+22
| | | | | | | | | | | | | | | | Porting screen lock key for landia. BUG=none BRANCH=dedede TEST=make sure keyboard function of each MB works correctly. Signed-off-by: Hank Xie <hank.xie@quanta.corp-partner.google.com> Change-Id: Iee3ca1c0ad9ce519ab8e11ca218aaf1338433b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3517432 Reviewed-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-by: Tommy Chung <tommy.chung@quanta.corp-partner.google.com> Tested-by: Tommy Chung <tommy.chung@quanta.corp-partner.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
* nissa: Workaround for ADC initial read errorAndrew McRae2022-03-172-0/+20
| | | | | | | | | | | | | | | | | | | | It appears the ADC comparator initialisation breaks other ADCs that have not been read, so workaround the issue by initially reading all ADCs so that they are correctly initialised. Also add a check so that zero reads are detected and returned as an error. BUG=b:224900226 TEST=zmake build nivviks; flash and run and check ADCs work. BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Ifcbebf2ca9b9a336f10fe3659fd3452223474ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3528015 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Commit-Queue: Peter Marheine <pmarheine@chromium.org>
* ap_pwrseq: Add signal range checkingAndrew McRae2022-03-171-4/+20
| | | | | | | | | | | | | Add power signal range checking. BUG=b:225049035 TEST=zmake test test-ap_power BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Ib1ddf1b7976db3060c79cf15278d334cb297d1ae Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3531308 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* cq: Parse memory report files and add to metricsJeremy Bettis2022-03-172-34/+111
| | | | | | | | | | | | | | | | | | | | In the build stage of firmware_builder.py, parse all memsize.txt files and write the sizes to the metrics proto. Document how to run the builder manually. Formatted python code, and fixed cros lint errors. BRANCH=None BUG=b:223846977 TEST=Ran commands in README. Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: Icca1165fc3e13ec89898550e53b12440bbe053d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3530151 Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org>
* gimble: do not reset PS8815 when AC only during power onScott Chao2022-03-172-2/+6
| | | | | | | | | | | | | If EC reset PS8815 when AC only, the EN_SINK will not be assert and let SM5360 in dead battery mode. It will result in SM5360's sink power switch keep at close state. BUG=b:223315425 TEST=make -j BOARD=gimble TEST=make sure DUT can boot with AC only after EC reset Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: I98c49e19c1266243c1341732e897f72699ba858a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3521001 Reviewed-by: Boris Mittelberg <bmbm@google.com>
* Zephyr: enable motion sensors for guybrush and skyrimRobert Zieba2022-03-178-4/+200
| | | | | | | | | | | | | | | This commits adds the motionsense device tree and config changes required to enable motion sensors for guybrush and skyrim. BUG=b:214619940 TEST=Used `ectool motionsense` and `accelread` to validate sensor readings under zephyr BRANCH=none Signed-off-by: Robert Zieba <robertzieba@google.com> Change-Id: I3ef8e14eadcb07c97c616f938c78a8e1254444bc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3517676 Reviewed-by: Diana Z <dzigterman@chromium.org>
* Zephyr: Enable CONFIG_PM_DEVICE on all boardsDiana Z2022-03-176-0/+8
| | | | | | | | | | | | | | | | This config used to be automatically enabled before CL:3504555. Now, enable the config explicitly and also ensure platforms have NPCX idle stats available. BRANCH=None BUG=b:224579318 TEST=on skyrim, observe no watchdog warnings in G3 with no charger Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Icbb2ea76425dd8750a0ab25e75f65c6da268defd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3529815 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* zephyr: Pop a directory from the brya project pathJack Rosenthal2022-03-1716-0/+0
| | | | | | | | | | | | | | We aren't nesting the directory structure like ${PROGRAM}/${PROJECT} anymore. BUG=none BRANCH=none TEST=zmake build brya Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I44da0d7d43c097cd05e1e003926d302d0c3beb8b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3530959 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: Add "ghost" variant of bryaJack Rosenthal2022-03-171-1/+3
| | | | | | | | | | | | | | | | Right now using brya hardware to develop ghost EC. Initially it can be a simple rename of brya. Later we will change the charger chip, which will require a couple of DTS customizations. Eventually, this project will need to move to not be a brya variant at some point. BUG=b:222738712 BRANCH=none TEST=builds (don't have hardware for testing yet) Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I3c713e12bd0685d08ed31c40bd103c2685416d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3530958 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: zmake: Add a syntax to make simple variants of a buildJack Rosenthal2022-03-174-10/+94
| | | | | | | | | | | | | | Add a BUILD.py syntax to copy another project and make simple modifications. BUG=b:224998797 BRANCH=none TEST=provided unit test passes Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I87f0fe6b0e02c3ac34bec6de09d38e620fc293e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3530957 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* herobrine: Fix LED config for hoglinMatthias Kaehlcke2022-03-161-0/+7
| | | | | | | | | | | | | | | | | | | | | Hoglin has a single blue/red LED on the right side, adjust the LED configuration to reflect that. BUG=b:223102797 TEST=ectool led right query Brightness range for LED 4: red : 0x1 green : 0x0 blue : 0x1 yellow : 0x0 white : 0x0 amber : 0x0 BRANCH=None Change-Id: Ia005a0de2c94bfbbcf8025492a57858b78888da6 Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3530953 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* ec: Write memory usage report to fileJeremy Bettis2022-03-162-0/+5
| | | | | | | | | | | | | | | | | | Change the linker command for all board builds to pass the --print-memory-usage flag and save the results to a file. BRANCH=None BUG=b:223846977 TEST=make buildall_only -j16 Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I63733ce205a5453e7dc16809f7fd033873d67d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3530150 Tested-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Yuval Peress <peress@google.com> Commit-Queue: Yuval Peress <peress@google.com>
* zephyr: avoid duplicate IN_RANGE macroFabio Baltieri2022-03-161-0/+5
| | | | | | | | | | | | | | | | This has been added to Zephyr, avoid redefining it. BRANCH=none BUG=none TEST=zmake -j2 configure -b brya Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Cq-Depend: chromium:3519923 Change-Id: I7992c643b82648240ccbfdb77014a6bcc8034f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3528400 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> Tested-by: Jack Rosenthal <jrosenth@chromium.org>
* ap_pwrseq: Clear default debug flags.Andrew McRae2022-03-162-1/+6
| | | | | | | | | | | | | | | | Reduce the noise by not enabling all the debug mask bits. powerindebug can be used to set the mask as desired. BUG=b:201000950 TEST=xmake build nivviks BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Iae56960ecbf0bbd653df9242999aa6ed2e2cc253 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3528454 Reviewed-by: Divya S Sasidharan <divya.s.sasidharan@intel.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* zephyr: test: Attach src & snk using TCPCI rev2Aaron Massey2022-03-161-8/+18
| | | | | | | | | | | | | | | | Herobrine ports are configured with TCPCI revision 2. Switch test suites attaching src and snk using TCPCI revision 2 for all associated ports and TCPCI emulators. BRANCH=none BUG=b:209907615 TEST=zmake configure --test test-drivers Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I392c1025fecc6a988212797f03dc5aa2fff387c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3516541 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: gpio: Do not change the output state for open-drain outputsWai-Hong Tam2022-03-161-2/+16
| | | | | | | | | | | | | | | | | | | | | | In the GPIO init, for each OUTPUT GPIO, it changes its output state according to its current state. It works for a push-pull OUTPUT. But for an open drain output, its current value doesn't imply the previous output state. The current low state is either 1) the EC previously drove the pin low; 2) the EC previously high-Z'ed the pin. These 2 cases can't be differentiated, so skip overriding the output state. BRANCH=None BUG=b:224616711 TEST=Verified the EC RW can boot the AP into the logic prompt. Change-Id: Ifdd1c6bac74b80edd95e9075744e1e583d553a0e Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3530149 Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: adlrvp_npcx: setup fan controlFabio Baltieri2022-03-164-22/+41
| | | | | | | | | | | | | Setup a fan node for adlrvp_npcx. BRANCH=none BUG=none TEST=zmake -j2 configure -b adlrvp_npcx Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ib8575be3e621a8ff662d309a8658438cb5859fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3521942 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: enable unaligned access trapFabio Baltieri2022-03-162-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | ECOS used to have this by default and it's needed to pass the firmware_ECSharedMem FAFT test. This required adding arch specific config overrides to match https://github.com/zephyrproject-rtos/zephyr/blob/main/arch/Kconfig#L12 behavior. BRANCH=none BUG=b:223234903 TEST=ran on volteer, crashes without -mno-unaligned-access TEST=crash unaligned console command TEST=zmake -j2 configure -b volteer TEST=zmake -j2 configure -b it8xxx2_evb Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Cq-Depend: chromium:3519053 Change-Id: I0920128279fbc644741f1163aa1107ec9fb6b558 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3516253 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: CMakeLists: set -mno-unaligned-accessFabio Baltieri2022-03-161-0/+3
| | | | | | | | | | | | | | | | | | | | | GCC can generate unaligned access instructions by default, for example: *data = buf[1] | (buf[2] << 8) | (buf[3] << 16) | (buf[4] << 24); 0x10084ac0 <+84>: itte eq 0x10084ac2 <+86>: ldreq.w r3, [sp, #17] <-- this one 0x10084ac6 <+90>: streq r3, [r7, #0] Set -mno-unaligned-access to enforce byte access on all structures. BRANCH=none BUG=b:223234903 TEST=checked the disassembled code, ran with unaligned access trap Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I8b559806b1fe9044c7401f4f8d4126a71657c308 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3521786 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* zmake: Fix build-build-ro directories in testJeremy Bettis2022-03-161-29/+23
| | | | | | | | | | | | | | | | The correct values for iter_builds() is ro and rw, not build-ro and build-rw. BRANCH=None BUG=None TEST=run_tests.sh Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I1927f0dec54bf72ea5eef0e76d7063546c73a5fb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3526178 Tested-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
* zmake: Write ninja output to a build.log fileJeremy Bettis2022-03-162-5/+31
| | | | | | | | | | | | | | | | | | | | | | | | | In order to capture the memory usage report in the link stage, write all output from ninja to a build.log file in the build dir. For example: `zmake build herobrine` will create files in `build/zephyr/herobrine/build-ro/build.log` and `build/zephyr/herobrine/build-rw/build.log` I intend to parse this file in firmware_builder.py BRANCH=None BUG=b:223846977 TEST=zmake build herobrine; \ tail build/zephyr/herobrine/build-*/build.log Change-Id: I10e1e29e945f86bbc19adf62946ea7f3aab8fc6f Signed-off-by: Jeremy Bettis <jbettis@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3523395 Tested-by: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
* nissa: Add Nereid initial power signal configurationAndrew McRae2022-03-163-0/+195
| | | | | | | | | | | | | | | Add power signal DTS configuration for Nereid. Does not include ADC comparator support, which is dependent on an upstreamed feature. BUG=b:201000950 TEST=zmake configure -b nereid BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I43f9f1279e47cc54022a4196440f11632869d6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3499822
* ppc/rt1739: implement FRSTing Shen2022-03-162-8/+51
| | | | | | | | | | | | | | | Implement the set_frs_enable function for rt1739 driver. BUG=b:218982792 TEST=On Krabby, manually verify that PD state enters FRS mode BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: Ia1ef13ded6f25bc08a9d3d593c1201b2bf15b232 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3463086 Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* ap_pwrseq: Use interrupts to maintain power signal maskAndrew McRae2022-03-167-55/+107
| | | | | | | | | | | | | | | | | Instead of recalculating the entire power mask every change, use interrupts to update the mask. Also include signals that need to be polled (such as board provided signals) and output signals. BUG=b:201000950 TEST=zmake build nivviks BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I12b8ab1b82ac212581be8a2b6307e46b1395f001 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3516769 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Reviewed-by: Li1 Feng <li1.feng@intel.com>
* zephyr: port DPS to zephyrEric Yilun Lin2022-03-165-1/+31
| | | | | | | | | | | | | | | | Port config dynamic PDO selection to zephyr. BUG=b:206709593 TEST=enable DPS on herobrine and build BRANCH=none Change-Id: I2ee111c086625fe3b4972b490b64b68f122aefb4 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3522248 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Eric Yilun Lin <yllin@google.com> Auto-Submit: Eric Yilun Lin <yllin@google.com>
* felwinter: modify fan frequencyMatt Wang2022-03-161-2/+2
| | | | | | | | | | | | | | | Modify the Fan freq to 25k and remove the PWM_CONFIG_DSLEEP. BUG=b:198371480 BRANCH=brya TEST=Use the new fan on felwinter. It can control the fanduty by ectool or ec console command. Signed-off-by: Matt Wang <matt_wang@compal.corp-partner.google.com> Change-Id: I4e98fdb6d29c6a47c13970b5d7eaae072a8d3114 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3522468 Reviewed-by: Ko Ko <ko_ko@compal.corp-partner.google.com> Reviewed-by: caveh jalali <caveh@chromium.org>
* pinmap: Optionally use column to select pinsAndrew McRae2022-03-166-20/+36
| | | | | | | | | | | | | | Instead of using the chip name, optionally use a column designator to select the pins to process. BUG=b:221764513 TEST=go test ./...; regenerate DTS BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I4d056826f3768b34abb6ac3efcf916e48a76b2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3522250 Reviewed-by: Eizan Miyamoto <eizan@chromium.org>
* kingler: fix hibernate functionMike Lee2022-03-161-5/+5
| | | | | | | | | | | | | | | | move charger hibernate setting to the board_hibernate() BUG=b:223545482 BRANCH=none TEST=test hibernate function work normal Signed-off-by: Mike Lee <mike5@huaqin.corp-partner.google.com> Change-Id: Ia10c63d333d4fe8ab60ba6d0dcc2dc2ea659a151 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3513492 Reviewed-by: Siyu Qin <qinsiyu@huaqin.corp-partner.google.com> Tested-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com>
* ap_pwrseq: Remove overridable weak functionsAndrew McRae2022-03-165-92/+87
| | | | | | | | | | | | | | | | | Temporary hard-coded board level functions and removal of weak default functions. This will be refactored with a more extensible callback mechanism providing a more general solution. BUG=b:223923728 TEST=zmake build nivviks BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Ie4cb4683e6ad4358af7535861cebfd966ef2a456 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3516767 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Reviewed-by: Li1 Feng <li1.feng@intel.com>
* dps: ensure DPS task waited for enough timeEric Yilun Lin2022-03-161-0/+1
| | | | | | | | | | | | | | | | | | DPS task will be waken up if new srccaps received, but the DPS should wait enough time and then start the next evaluation, or we might measure the starting up current and power and the value will be underestimated. BUG=b:169532537 TEST=enable DPS, and it won't sample starting up current and power BRANCH=cherry Change-Id: I995639b4d9f88ef4eaae02ad07b49fb9b6ffee0a Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3527895 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com>
* nissa: nivviks: Enable port 1 redriverAndrew McRae2022-03-1610-11/+32
| | | | | | | | | | | | | Enable port 1 redriver for Nivviks BUG=b:219898719 TEST=zmake build nivviks BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I6012855cceb44efd34469b70199ccd70897ba6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3527894 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* krabby: increase chipset stack sizeTing Shen2022-03-161-1/+1
| | | | | | | | | | | | | | | | Chipset stack usage grows to 1148 bytes during shutdown. Allocate more space for it. BUG=b:223505924 TEST=none BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I0b80a766d8db297f73cc7182dc4f098b7e4604ee Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3524722 Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* nissa/nereid: increase some stack sizesPeter Marheine2022-03-161-1/+2
| | | | | | | | | | | | | These were overflowing when the AP booted into OS. BUG=none TEST=EC no longer crashes when AP firmware is running BRANCH=none Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: If27a8a12a3fba14a46f0dfa57fe0465b371b2d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3527475 Reviewed-by: Andrew McRae <amcrae@google.com>
* taniks: fix 71W battery tablearthur.lin2022-03-161-2/+2
| | | | | | | | | | | | | Fix 71W battery table for voltage_max. BUG=b:208724534 BRANCH=none TEST=make buildall -j Signed-off-by: arthur.lin <arthur.lin@lcfc.corp-partner.google.com> Change-Id: If50ae35b8d3bd9725a513494aa3f491f0a157d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3518773 Reviewed-by: caveh jalali <caveh@chromium.org>
* gimble: set SYV682X HV_ILIM to 5.5AElsie Shih2022-03-161-0/+2
| | | | | | | | | | | | | Set CONFIG_SYV682X_HV_ILIM to 5.5A on gimble. BUG=b:223302153 TEST=make -j BOARD=gimble Signed-off-by: Elsie Shih <elsie_shih@wistron.corp-partner.google.com> Change-Id: I13352d80d82139b9d44c1eb56dcf56b08bd45635 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3522474 Reviewed-by: caveh jalali <caveh@chromium.org> Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
* landrid: Porting keyboard.Hank Xie2022-03-163-3/+89
| | | | | | | | | | | | | | | | | Add numeric pad for landrid. Porting EC GPIO J4 for T2 refresh key for landrid BUG=b:224648672 BRANCH=dedede TEST=make sure keyboard function of each MB works correctly. Signed-off-by: Hank Xie <hank.xie@quanta.corp-partner.google.com> Change-Id: Iaba03a9bd72516a043000ffc4d6bdb49defe566f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3517431 Reviewed-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-by: Tommy Chung <tommy.chung@quanta.corp-partner.google.com> Tested-by: Tommy Chung <tommy.chung@quanta.corp-partner.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
* nissa: run sub-board detection at PRIO_INIT_I2CPeter Marheine2022-03-161-1/+3
| | | | | | | | | | | | | | | | | | | | | | | HOOK_PRIO_INIT_I2C is documented as the priority at which I2C is guaranteed to be ready, and +1 from there is also the priority at which chargers are initialized so we must use PRIO_INIT_I2C because otherwise chargers (and maybe other USB-C peripherals) won't get initialized. I noticed this when Nereid failed to charge, and the "PD port count not initialized" warning was being output. Since this is probably a serious problem, I've also added an assertion to that function to fail fast in debug builds. BUG=none TEST=nereid charges again, and does not warn about uninitialized port counts. BRANCH=none Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: If6cc0de5279bc5616813a38d8b29e3b747514049 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3526118 Reviewed-by: Andrew McRae <amcrae@google.com>
* zephyr: Update GPIO flags to match upstreamKeith Short2022-03-162-29/+25
| | | | | | | | | | | | | | | | Update the copy of the Zephyr GPIO flags the EC application uses in devicetrees. BUG=b:224821728 BRANCH=none TEST=zmake testall TEST=verify Herobrine boots the AP Cq-Depend: chromium:3519052 Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I1f194fcce5570ba10c8389d81164864102921c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3527513 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* gpio: Cleanup CONFIG_CMD_GPIO_EXTENDEDKeith Short2022-03-162-20/+13
| | | | | | | | | | | | | | | Cleanup the GPIO flag descriptios used by GPIO_CMD_GPIO_EXTENDED. This doesn't save any code size, but simplifies the logic. BUG=none BRANCH=none TEST=make buildall TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I71f0db12a2b65bcc2e2bdf6dc48fb643c5cd6c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3526272 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: Directly map GPIO flagsKeith Short2022-03-164-48/+61
| | | | | | | | | | | | | | | | Directly map legacy GPIO flags to the Zephyr equivalent when possible. The interrupt flags are still handled separately. BUG=b:224821728 BRANCH=none TEST=zmake testall TEST=compare_build.sh TEST=verify Herobrine boots the AP Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I379d95036dbf5630a0a6aed708c49cfcfc084802 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3526271 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: Fix checks for GPIO flags used in the devicetreeKeith Short2022-03-161-8/+26
| | | | | | | | | | | | | | | | | | The EC application uses some GPIO flags that are not exposed by Zephyr upstream to devicetree files. The EC application duplicates these flags so the default GPIO pin state can be set in a central location. Verify that all duplicated flags match the expected value. BUG=b:224821728 BRANCH=none TEST=zmake testall TEST=verify Herobrine boots the AP Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I1f307337aafb76e09eced8c85aaf8e7e57672e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3526270 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: Remove use of GPIO_OUT_HIGH/LOW from dts filesKeith Short2022-03-1620-204/+198
| | | | | | | | | | | | | | | | The correct Zephyr GPIO flags are GPIO_OUTPUT_HIGH and GPIO_OUTPUT_LOW. Use these flags in place of GPIO_OUT_HIGH and GPIO_OUT_LOW in all devicetree files. BUG=b:224821728 BRANCH=none TEST=zmake testall TEST=verify Herobrine boots the AP Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I3b21920a7da21973467dfcf04de5bed7a2bdb2c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3526269 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: Add some more test coverage for power signals testsAndrew McRae2022-03-162-52/+133
| | | | | | | | | | | | | Add some more coverage for power signals tests. BUG=none TEST=zmake configure --test test-ap_power BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: If2cd01749486ca9b538e25fd740d7074dcf58f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3518776 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* nissa: use the dedicated USB mux taskPeter Marheine2022-03-151-0/+2
| | | | | | | | | | | | | | The integrated muxes on ADL can take a long time to respond, so we want to unblock PD while that runs. BUG=b:223749568 TEST=task is now listed in `kernel threads` BRANCH=none Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: Ibde2ffd00eba8c72784f8d54551712210a113dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3518706 Reviewed-by: Andrew McRae <amcrae@google.com>
View Lorry Controller Status