summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* nissa: disable SYSTEM_UNLOCKEDPeter Marheine2022-06-141-1/+0
| | | | | | | | | | | | | | | Because some FAFT tests depend on it being possible to lock the system, disable PLATFORM_EC_SYSTEM_UNLOCKED so they can pass. Developers will need to disable WP if needed. BUG=b:235440351,b:235425819 TEST=.config shows PLATFORM_EC_SYSTEM_UNLOCKED now unset (was y) BRANCH=none Change-Id: I9cf5d2d4462cce130fc3ff171f6306074f878d63 Signed-off-by: Peter Marheine <pmarheine@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3702879 Reviewed-by: Andrew McRae <amcrae@google.com>
* zephyr: EEPROM_CBI_WP does not imply BYPASS_WP_CHECKPeter Marheine2022-06-131-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | Some platforms allow the EC to control CBI WP by latching the hardware WP signal on with external hardware when the EC asserts a selected GPIO, enabled with the EEPROM_CBI_WP option. Because this should be possible to use when the system is not force-unlocked by config, remove the kconfig select. This is consistent with the legacy configuration where some boards enable EEPROM_CBI_WP but not BYPASS_WP_CHECK, and not doing this causes build to fail because config.h only allows BYPASS_WP_CHECK to be enabled when the system is force-unlocked. BUG=b:235440351,b:235425819 TEST=PLATFORM_EC_BYPASS_CBI_EEPROM_WP_CHECK is now disabled on Nereid if the system is not force-unlocked. BRANCH=none Change-Id: I5c67fcb9cd564622f4f4593f358b993c4bc159b6 Signed-off-by: Peter Marheine <pmarheine@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3702878 Reviewed-by: Andrew McRae <amcrae@google.com> Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* zephyr test: SYV682x: Fix test ordering assumptionAbe Levkoy2022-06-131-10/+10
| | | | | | | | | | | | | | | | test_syv682x_vbus_enable checked "initial" state of PPC emulator based on no-longer-valid assumptions about test ordering. Test VBUS source disabling in an order-independent way in a separate test. Clarify test names. BUG=b:234886404 TEST=zmake testall; verify coverage did not change BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: Id3e43bf6ef38d5c93cedfd8dfc6dfe69c9e63137 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3690269 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* servo_v4p1/usb_pd_policy: Disable VBUS instead of power supply resetŁukasz Hajec2022-06-131-2/+3
| | | | | | | | | | | | | | | | | | This CL aligns servo_v4 and servo_v4p1 code. Based on: f10da1149896, which introduced analogous changes, please refer to its log message for full information: https://crrev.com/c/2569652 BUG=b:219864270 BRANCH=main TEST=firmware_PDTrySrc on Voxel with servov4p1 check that fakedisconnect as src and snk works on servoV4p1 Signed-off-by: Lukasz Hajec <lha@semihalf.com> Change-Id: I35770edb22b7633bb771a6070181d8e2c1bb1428 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3645121 Tested-by: Łukasz Hajec <hajec@google.com> Commit-Queue: Łukasz Hajec <hajec@google.com> Reviewed-by: Sam Hurst <shurst@google.com>
* zephyr test: SYV682x: Use zassumeAbe Levkoy2022-06-131-35/+38
| | | | | | | | | | | | | | | Replace zassert_* with zassume_* where the failure in question would be outside the scope of the containing test. Use zassume_* to validate results of _setup and _after functions. BUG=b:234886404 TEST=zmake testall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I615384d382ba2bd06ba1873fbb01bb914d3b9b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3689788 Reviewed-by: Aaron Massey <aaronmassey@google.com>
* zephyr test: SYV682x: Split up long testsAbe Levkoy2022-06-131-54/+96
| | | | | | | | | | | | | | Split large tests with multiple related checks into smaller tests with more closely related checks. BUG=b:234886404 TEST=zmake testall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: If7e6397b6165ee880fd7228bc4851edf2b1bcdda Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3689800 Reviewed-by: Aaron Massey <aaronmassey@google.com>
* zephyr: Remove ec_version.h dependency on common/system.cTristan Honscheid2022-06-134-4/+2
| | | | | | | | | | | | | | | | | | | | | | common/system.c includes ec_version.h to access its definition of CROS_FWID_MISSING_STR. However, this is just a constant placeholder for cases when an actual version string is not available. It does not need to placed into the auto-generated ec_version.h header. * Remove the code that adds the CROS_FWID_MISSING_STR definition in zmake * Place the #define macro into cros_version.h, which is included by common/system.c already. * Update zmake unit tests BRANCH=None BUG=None TEST=zmake test test-drivers Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: I8bb8406823e7860162157c1baaa21440608f3eea Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3656257 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* nissa: refactor BUILD.py for new_variantPaul Fagerburg2022-06-131-4/+4
| | | | | | | | | | | | | | | | | Add return values from registering the projects so that new_variant can easily create EC firmware for a new variant. BUG=b:198179760, b:229550821 TEST=`zmake configure -a && echo PASS` BRANCH=None Signed-off-by: Paul Fagerburg <pfagerburg@google.com> Change-Id: If83efddda9bfc278562d9b0da80efa0fd24b8810 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3703199 Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> Auto-Submit: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Tested-by: Paul Fagerburg <pfagerburg@chromium.org>
* Skyrim: Update board code namesDiana Z2022-06-131-3/+3
| | | | | | | | | | | | | | | Update the skyrim board code to reflect that these files are only used for skyrim, as guybrush has its own copy at this point. BRANCH=None BUG=None TEST=zmake build skyrim Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I01773300ab0298f87b70825b80897e72a86638c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3700707 Reviewed-by: Robert Zieba <robertzieba@google.com> Commit-Queue: Robert Zieba <robertzieba@google.com>
* Skyrim: Fill in PS8818 DB TODODiana Z2022-06-131-2/+7
| | | | | | | | | | | | | | | | Set the IN_HPD pin for the PS8818 boards when we have any sort of DP connections. BRANCH=None BUG=None TEST=on skyrim with PS FW_CONFIG set, ensure IN_HPD is set when a DP dongle is plugged in Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I12977ba7634ac7b846cc9d5420b5d93f8b882701 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3700706 Commit-Queue: Robert Zieba <robertzieba@google.com> Reviewed-by: Robert Zieba <robertzieba@google.com>
* osiris: Modify thermal and fan configurationYu-An Chen2022-06-132-125/+20
| | | | | | | | | | | | | | | | | This patch update thermal halt/alert temperature and fan minimum/start/maximum speed. BUG=b:234545460 BRANCH=none TEST=Thermal team verified thermal policy is expected. Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: I8bd473b85d92f2315b88d66732b5a50872b973c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3682990 Commit-Queue: Kenny Pan <kennypan@google.com> Reviewed-by: Kenny Pan <kennypan@google.com> Reviewed-by: caveh jalali <caveh@chromium.org> Reviewed-by: Parth Malkan <parthmalkan@google.com>
* crota: modify fan frequencyPeter Chi2022-06-131-2/+2
| | | | | | | | | | | | | | Modify fan freq to 25kHz and remove the PWM_CONFIG_DSLEEP flag. BUG=b:235552938 BRANCH=none TEST=make -j BOARD=crota Signed-off-by: Peter Chi <peter_chi@wistron.corp-partner.google.com> Change-Id: I8fa467edc6f59093c6feca9ac907e768f5fc4566 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3697762 Commit-Queue: Zhuohao Lee <zhuohao@chromium.org> Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
* taniks: set aw20198 init and scale settingarthur.lin2022-06-132-1/+12
| | | | | | | | | | | | | | Modify SWSEL bit4-7 from SW11 to SW8 to fulfill the LED module design layout. Modify RED SLn to 190(60mA) for HW change the total Sink current to 80mA. BUG=b:233986174 BRANCH=none TEST=make buildall -j Signed-off-by: arthur.lin <arthur.lin@lcfc.corp-partner.google.com> Change-Id: Id012ceea416091f8d864ccfc471bee2abb3953b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3682989 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* nivviks: VBUS Voltage Detection without any connectionAndrew McRae2022-06-112-4/+22
| | | | | | | | | | | | | | | | | Apply the fixes from b/183220414 to nivviks and craask. Enable the ASGATE when sourcing VBUS, and disable it when we are not sourcing VBUS. This will prevent current leakage. BUG=b:234375490 TEST=zmake build nivviks BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I8eb0357d139cacc4bd66c48b1c7942d1ff0782af Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3701138 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* osiris: Support factory keyboard testYu-An Chen2022-06-102-0/+27
| | | | | | | | | | | | | | | Support factory keyboard connector test BUG=b:224423318 BRANCH=none TEST=check ectool kbfactorytest pass Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: Ie2c0e5e10bd3f8713bca2e1807f8e5e60eca01fb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3686009 Commit-Queue: Parth Malkan <parthmalkan@google.com> Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: Parth Malkan <parthmalkan@google.com>
* chargesplash: Change host command number to 0x00A5Jack Rosenthal2022-06-101-1/+1
| | | | | | | | | | | | | | | EC_CMD_CHARGESPLASH is using the same number as EC_CMD_HOST_EVENT. Assign an unused number to EC_CMD_CHARGESPLASH. BUG=b:235531569 BRANCH=none TEST=CQ Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I085991ffe42c102149cb0e7a876522c76642c50e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3699312 Commit-Queue: Diana Z <dzigterman@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* zephyr: brya: change the mkbp event notificationMichał Barnaś2022-06-101-1/+1
| | | | | | | | | | | | | | | | | Fix the power button not working in the recovery screen. The depthcharge polls the gpio waiting for the mkbp events, so the power button wasn't working on the zephyr. BUG=none BRANCH=main TEST=enter recovery mode and press the power button board should shutdown correctly with 1 short press Change-Id: Ieea51cc22313d353606deb873b95cf3239d3b314 Signed-off-by: Michał Barnaś <mb@semihalf.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3688189 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* crota: correct BBR addressScott Chao2022-06-101-3/+3
| | | | | | | | | | | | | | Check the BBR FW configure XML, EC need to follow the XML to configure it. The BBR FW was downloaded in Kit 723523. BUG=b:229804436 BRANCH=none TEST=verified TBT can be recognized on port0 and port1. Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: I8ce61f0e281afabd9a082a491a7703a4a6133cee Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3697765 Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
* ps8743: Optimize power consumption in USB idle modelschyi2022-06-102-0/+53
| | | | | | | | | | | | | | | | | | | | | | | The USB mode can be disabled to save power if no USB 3 device is attached when entering S3. Disable the USB mode by altering the bit in configuration register. The determination of whether any USB 3 device is connected is conducted via checking the misc register. BUG=b:229810117 TEST=issue `powerd_dbus_suspend` then check the USB mode bit: (1) No device is attached: USB mode bit is 0 (2) Attach USB 2 device: USB mode bit is 0 (3) Attach USB 3 device: USB mode bit is 1 The USB mode bit is 1 after the system wakes up to S0 BRANCH=none Change-Id: I27f49c28e043c273456b82fd8fe4d0d1f444e3f4 Signed-off-by: lschyi <lschyi@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3697823 Commit-Queue: Sung-Chi Li <lschyi@chromium.org> Tested-by: Sung-Chi Li <lschyi@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* crota: enable FRSPeter Chi2022-06-103-2/+6
| | | | | | | | | | | | | | Also correct the GPIO assignment on IO expander. BUG=b:235453573 BRANCH=none TEST=Verified by EE Signed-off-by: Peter Chi <peter_chi@wistron.corp-partner.google.com> Change-Id: I6de9c39d065bb10dd41df70a9ead80c2a81d346a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3637399 Commit-Queue: caveh jalali <caveh@chromium.org> Reviewed-by: caveh jalali <caveh@chromium.org>
* Mithrax: Enable RGB keyboardjohnwc_yeh2022-06-103-1/+169
| | | | | | | | | | | | | | | | | | | | | | | | This patch enables the RGB keyboard module for Mithrax. localhost ~ # ectool rgbkbd 1 0x010203 EC prints: HC resp:080000000001000100000000 HC 0x13a.0:0101010203 RGBKBD: Set (0,0) to color=(1,2,3) grid=0 offset=0 BUG=b:223526803 BRANCH=None TEST=make BOARD=mithrax, gpioset EN_PP5000_LED 1, enter ectool rgbkbd <key/clear> <RGB> and watch the RGB KB color is normally. Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Change-Id: If33f6dcf2a9fb94f5a82f77b848e4e3342d49af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3670654 Reviewed-by: Ko Ko <ko_ko@compal.corp-partner.google.com> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* tcpm/anx7447: set CC debounce time to 2ms at BIST test modeXin Ji2022-06-102-1/+23
| | | | | | | | | | | | | | | | Lots of BIST data transmit on the CC line in short time may cause TCPC trigger CC status change alert to TCPM. The TCPC need increase CC debounce time to avoid wrong CC status change reported. BUG=b:229812911 BRANCH=none TEST=tested on Kingler Change-Id: Ia280590f8e17173f764b2e0b79bbe93067ac6431 Signed-off-by: Xin Ji <xji@analogix.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3697265 Commit-Queue: Eric Yilun Lin <yllin@google.com> Reviewed-by: Eric Yilun Lin <yllin@google.com>
* Nissa: define LED behavior at STATE_DISCHARGE_S0_BAT_LOW for CraaskSue Chen2022-06-101-0/+1
| | | | | | | | | | | | | STATE_DISCHARGE_S0_BAT_LOW: Amber on BUG=b:235304497 BRANCH=none TEST=check LED behavior while SOC < 10% in battery mode. Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I182dffc7a10a8053b81f3bf573f6a836f7f892c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3695853 Reviewed-by: Andrew McRae <amcrae@google.com>
* RGBKBD: Add TLC59116F driverjohnwc_yeh2022-06-105-0/+207
| | | | | | | | | | | | | | TLC59116F is a LED driver which can control 16 LEDs. BUG=b:223526803 BRANCH=None TEST=make BOARD=mithrax Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Change-Id: I24865c5af796cf918af1f361ba1a1f87bf5923f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3670621 Reviewed-by: Ko Ko <ko_ko@compal.corp-partner.google.com> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* zephyr: mchp: Support sysjump functionmartin yan2022-06-095-29/+122
| | | | | | | | | | | | | | Support sysjump function, similar mechanism as other vendor implementation BUG=none BRANCH=main TEST=Test on adlrvp_mchp project via console sysinfo and sysjump RW/RO Signed-off-by: martin yan <martin.yan@microchip.corp-partner.google.com> Change-Id: Ic5e0c32408f993de01579ac5a77b6b84a2fe5811 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3686760 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* timer.h: Avoid redefining clock_t when compiling with libcTom Hughes2022-06-092-2/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | Move the clock_t typedef to the "builtin" directory, which the directory containing headers that mirror those in the C standard library. The "builtin" directory can then be excluded when building with the standard library. include/timer.h:31:14: error: typedef redefinition with different types ('long' vs 'unsigned long') typedef long clock_t; ^ /usr/armv7m-cros-eabi/include/sys/types.h:107:19: note: previous definition is here typedef _CLOCK_T_ clock_t; ^ BRANCH=none BUG=b:234181908 TEST=./util/compare_build.sh -b all -j 120 => MATCH Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Ib2381664535781035b367b414c5f00639ce9b9af Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3691958 Reviewed-by: Edward Hill <ecgh@chromium.org>
* Skyrim: Enable S0ixDiana Z2022-06-092-0/+3
| | | | | | | | | | | | | | | Enable the configuration for S0ix, as well as tracking host sleep failures. BRANCH=None BUG=b:234499465 TEST=zmake build skyrim Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I847dd6190cb86067d364ba5372ea9a4aebc96ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3693867 Reviewed-by: Robert Zieba <robertzieba@google.com> Reviewed-by: Raul Rangel <rrangel@chromium.org>
* zephyr: mchp: Support 512KB SPI image generationmartin yan2022-06-095-13/+78
| | | | | | | | | | | | | Adjust configurations to fit SPI image generation BUG=none BRANCH=main TEST=zmake testall Signed-off-by: martin yan <martin.yan@microchip.corp-partner.google.com> Change-Id: I06da9b78fd3b3f42855ef197a37a18bc11ec3711 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3686761 Reviewed-by: Al Semjonovs <asemjonovs@google.com>
* Zephyr: Allow S0ix to be configured on non-Intel boardsDiana Z2022-06-091-8/+8
| | | | | | | | | | | | | | | Boards besides Intel may allow S0ix, so move that configuration out of the Intel-specific section of the power sequencing Kconfig. BRANCH=None BUG=b:234499465 TEST=zmake testall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I05ce493aeed002576809dc6fc45997ca47d6bcae Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3693866 Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* beadrix: Update EC gpio pin of unused pins and corrected nameTeddy Shih2022-06-094-113/+3
| | | | | | | | | | | | | | | | | | | | | Update EC GPIO setting of unused pins and corrected name according to beadrix schematics. As well, remove code of non-existing accelerometer and gyroscope setting. GPIOJ0 : lsm6dsm_interrupt -> NC (BASE_SIXAXIS_INT_L) GPIOJ1 : TP62 -> NC (PEN_DET_ODL) GPIOJ3 : EN_KB_BL -> IMVP9_PE BRANCH=main BUG=b:235010984 TEST=on beadrix, validated by beadrix working properly. Signed-off-by: Teddy Shih <teddyshih@ami.corp-partner.google.com> Change-Id: Ib225e28fc17767af6466d3bf616732827078fd6e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3688153 Commit-Queue: Ivan Chen <yulunchen@google.com> Tested-by: Ivan Chen <yulunchen@google.com> Reviewed-by: Ivan Chen <yulunchen@google.com>
* it8xxx2: The "M" extension is disabled by defaultDino Li2022-06-096-0/+67
| | | | | | | | | | | | | | | | | | | | | There is a mul instruction bug. The bug may cause instructions of writing back CPU GPR (e.g mv a0,s2) which following the mul instruction to fail. This patch disables the 'M' extension and overwrite integer multiplication and division arithmetic library routines with using hardware multiplication and division and nop instructions. This will ensure that there is no write back GPR instruction to follow mul instruction to avoid the bug. BUG=b:235297478 BRANCH=asurada,cherry,icarus TEST=- buildall - The "M" extension is disabled on cherry image (-march=rv32iac) Signed-off-by: Dino Li <Dino.Li@ite.com.tw> Change-Id: I39b34a91dd77d975b78b6756494691c6b28dc42d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3690042 Reviewed-by: Eric Yilun Lin <yllin@google.com>
* riscv: it8xxx2: pull __switch_task function into ram_code_ilm0 sectionDino Li2022-06-093-2/+5
| | | | | | | | | | | | | | | | The ram_code section will out of space once mul instruction workaround is enabled. This change pulls the function into the second ram code section. BUG=b:235297478 BRANCH=asurada,cherry,icarus TEST=- buildall - Check map file, the function is in the ram_code_ilm0 section. Signed-off-by: Dino Li <Dino.Li@ite.com.tw> Change-Id: I236caf2261a16edf25185b2442d126ec6ed7ef41 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3686728 Reviewed-by: Eric Yilun Lin <yllin@google.com>
* config: riscv: add CONFIG_RISCV_EXTENSION_M configurationDino Li2022-06-093-1/+11
| | | | | | | | | | | | | | This makes the 'M' extension to be configurable. BUG=b:235297478 BRANCH=asurada,cherry,icarus TEST=- buildall - ISA for cherry images includes "M" extension (-march=rv32imac) Signed-off-by: Dino Li <Dino.Li@ite.com.tw> Change-Id: I56957a6767378121443659a170ca33896ada67ce Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3690041 Reviewed-by: Eric Yilun Lin <yllin@google.com>
* zephyr: mchp: Remove PLATFORM_EC_WATCHDOG_WARNING_LEADING_TIME_MSmartin yan2022-06-091-1/+1
| | | | | | | | | | | | | Add WDT_XEC support back after Zephyr WDT ISR driver is updated BUG=b:234734310 BRANCH=main TEST=zmake testall Signed-off-by: martin yan <martin.yan@microchip.corp-partner.google.com> Change-Id: I9de3d94793cfd969f0445324db583c236fba0fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3686759 Reviewed-by: Yuval Peress <peress@google.com>
* aw20198: modify SWSEL setting when initarthur.lin2022-06-092-4/+28
| | | | | | | | | | | | | | Modify SWSEL(bit4-7) when init to fulfill the LED module design layout. BUG=b:233986174 BRANCH=none TEST=make buildall -j Signed-off-by: arthur.lin <arthur.lin@lcfc.corp-partner.google.com> Change-Id: Ic2baa911af9fc76e55e95eaef06f2b33934e42f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3682988 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* nereid: vbus measurement using charger ic ADCDeepti Deshatty2022-06-091-15/+12
| | | | | | | | | | | | | | implement pd_check_vbus_level() to measure vbus precisely using SM5803 vbus ADC similar to the CL:2406342 BUG=b:231419461 BRANCH=main TEST=USBC dock is detected on Nereid port1 Change-Id: If418017256d0c34c683f1d84fb46423184cc7fa0 Signed-off-by: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3670785 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* docs/fingerprint: Clean up formatting in fingerprint-factory-quick-guide.mdTom Hughes2022-06-091-27/+26
| | | | | | | | | | | | BRANCH=none BUG=b:234772776 TEST=view in gitiles Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I0a107a379367712d79a959dc40b4e6b215be8c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3687544 Reviewed-by: Bobby Casey <bobbycasey@google.com> Reviewed-by: Andrea Grandi <agrandi@google.com>
* assert.h: Remove unnecessary externTom Hughes2022-06-091-3/+3
| | | | | | | | | | | | | | | | | | | | Functions in C are extern by default; it's not necessary in a header file. The extern combined with noreturn causes a compiler error when building with C++: ./builtin/assert.h:33:8: error: an attribute list cannot appear here extern noreturn void panic_assert_fail(const char *msg, const char *func, ^~~~~~~~ BRANCH=none BUG=b:234181908 TEST=./util/compare_build.sh -b all -j 120 => MATCH Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I7a2a86e57569bc90bb1ab93d5703217eabc042a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3691957 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* kblight: Initialize on AP startupDaisuke Nojiri2022-06-081-0/+6
| | | | | | | | | | | | | | | | This patch makes keyboard backlight module initialize on chipset startup instead of on reset. This will prevent LED drivers from being accessed before they're powered. BUG=b:233323599 BRANCH=None TEST=Taniks Change-Id: Ia57acdd57663c7bfa0dc3117cbc9ab6191d34c45 Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3693054 Reviewed-by: Parth Malkan <parthmalkan@google.com> Tested-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
* Revert "zephyr: defconfig: default to LEGACY_INCLUDE_PATH=n"Yuval Peress2022-06-081-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 4e012fd31e03507c4b254e49825e0dfbf263a375. Reason for revert: Causes build issues in generated files Original change's description: > zephyr: defconfig: default to LEGACY_INCLUDE_PATH=n > > Now that the code base compiles with LEGACY_INCLUDE_PATH=n, turn the > option to no by default so that we won't add any more non prefixed > include. > > BRANCH=none > BUG=none > TEST=cq dry run > > Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> > Change-Id: Ie95e79e659e755de869c8512d0bdfdc9523e1afa > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3637580 > Reviewed-by: Yuval Peress <peress@google.com> Bug: none Change-Id: I7541df82a963b81d983510cda58bb3a78c8156d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3683927 Commit-Queue: Al Semjonovs <asemjonovs@google.com> Tested-by: Al Semjonovs <asemjonovs@google.com> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Auto-Submit: Yuval Peress <peress@google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* docs/fingerprint: Run mdformatTom Hughes2022-06-082-6/+6
| | | | | | | | | | | BRANCH=none BUG=none TEST=view in gitiles Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I20caf005a0692d7e1d89528c87bb49b7743b8199 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3696148 Reviewed-by: Andrea Grandi <agrandi@google.com>
* osiris: Update gpio configYu-An Chen2022-06-081-1/+1
| | | | | | | | | | | | | | | | | Set GPIO73 as input to prevent I/O pin leakage current. BUG=b:235020065 BRANCH=none TEST=HW team confirmed IO voltage as expected Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: I7dd1d22a4635fd55dc803c7e025ec0b3fd52c156 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3678879 Auto-Submit: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Reviewed-by: Boris Mittelberg <bmbm@google.com> Commit-Queue: Boris Mittelberg <bmbm@google.com> Tested-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
* docs/fingerprint: Add links to info on fuzz testingTom Hughes2022-06-081-0/+7
| | | | | | | | | | | | BRANCH=none BUG=none TEST=view in gitiles Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I91ca1ee518dc701b1cf49f5c5149841af8a2c2df Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3696147 Reviewed-by: Andrea Grandi <agrandi@google.com> Reviewed-by: Firas Sammoura <fsammoura@google.com>
* Makefile: Use cxx-name variable instead of hardcoding compilerfactory-guybrush-14908.B-mainTom Hughes2022-06-081-1/+1
| | | | | | | | | | | | BRANCH=none BUG=b:234181908 TEST=./util/compare_build.sh -b all -j 120 => MATCH Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Icd8bfd8d6f8d6091e1bfef36b3e45b030f8f9d9d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3681938 Reviewed-by: Edward Hill <ecgh@chromium.org>
* zephyr test: Improve SYV682x test namingAbe Levkoy2022-06-082-23/+27
| | | | | | | | | | | | | | | | The UUT for this test is the SYV682x device driver, which works for part versions A, B, and C. The (emulated) part in the devicetree is an SYV682C, but the majority of the driver interface is unaffected by the specific part. Update file, suite, and variable names to reflect this. BUG=b:234886404 TEST=zmake testall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I8024239d4f4b4aa0793ea9b1e5a4b9df126a4009 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3689799 Reviewed-by: Al Semjonovs <asemjonovs@google.com>
* zephyr test: Use fixture for SYV682x testAbe Levkoy2022-06-081-131/+166
| | | | | | | | | | | | | | Convert ZTEST to ZTEST_F. Move repeated definitions to fixture/setup function. BUG=b:234886404 TEST=zmake testall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I419c57b120ec7a17a4d70c746f75ab3d3d665225 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3689798 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* zephyr test: Format ppc_syv682c.cAbe Levkoy2022-06-081-145/+148
| | | | | | | | | | | | | Run clang-format on this test. BUG=b:234886404 TEST=zmake testall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: Id111469a400bf60a48b8e0492db9c373ced97d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3689797 Reviewed-by: Yuval Peress <peress@google.com>
* steelix: config led behaviourwen zhang2022-06-083-34/+126
| | | | | | | | | | | | | | Config the battery/power LED behaviour according to the LED SPEC BUG=b:232050545 TEST=ectool led [battery/power] {color} BRANCH=none Change-Id: I47903c3682d1ecc84a56d93b4b14e59a5eeff272 Signed-off-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3690197 Reviewed-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Mike Lee <mike5@huaqin.corp-partner.google.com>
* steelix: modify motionsense rotation matrixwen zhang2022-06-082-0/+18
| | | | | | | | | | | | | | | The rotation matrix of steelix is different from reference board inherit the motionsense_kingler.dts and modify its rotation matrix BUG=b:232050545 TEST=rotate the DUT and check the direction of the frame BRANCH=none Change-Id: Iccb02a51487564a66dd22f23dcecf5a5493498f0 Signed-off-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3686720 Reviewed-by: Mike Lee <mike5@huaqin.corp-partner.google.com> Reviewed-by: Eric Yilun Lin <yllin@google.com>
* steelix: enable tablet modewen zhang2022-06-081-1/+1
| | | | | | | | | | | | | | | Kingler enabled the tablet mode, steelix is the variant and inherit its config, we should configure the GPIO for steelix BUG=b:232050545 TEST=EC reports tablet mode when the DUT is folded over BRANCH=none Change-Id: I4ae928ef6683355f602b03a724be00023807ffed Signed-off-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3694919 Reviewed-by: Mike Lee <mike5@huaqin.corp-partner.google.com> Reviewed-by: Eric Yilun Lin <yllin@google.com>
View Lorry Controller Status