summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* corsola: set HPD level at DPStatusEric Yilun Lin2022-07-191-8/+0
| | | | | | | | | | | | | | | | | Corsola skipped the post-config for HPD level, so we have to set HPD level pin to high when the DPStatus has informed. BUG=b:238170235 TEST=able to DP out when plug a hub with HDMI port attached. BRANCH=none Change-Id: I07c2d2fe9a64497b0b82bbd0fabdea6c47aab864 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3771680 Auto-Submit: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* Nissa: Add new battery for CraaskSue Chen2022-07-193-0/+61
| | | | | | | | | | | | | New battery: AP20CBL BUG=b:230427330 BRANCH=none TEST=battery cut off test, battery detection Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I9468168301a00ca2cce46dff3e44c058ab2e4eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3771360 Reviewed-by: Andrew McRae <amcrae@google.com>
* Nissa/Craask: adjust keyboard top rowSue Chen2022-07-192-0/+30
| | | | | | | | | | | | | Adjust keyboard top row. BUG=none BRANCH=none TEST=the function of top row keys is good. Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: Ibee146ad5ade5b52ec998110e7b2efa6e92c8696 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3771323 Reviewed-by: Andrew McRae <amcrae@google.com>
* zephyr: tests: Fix bb_retimer test conflict with PD taskTomasz Michalec2022-07-191-2/+7
| | | | | | | | | | | | | | | | | | Some bb_retimer tests require to set a PD data role. When the PD task is running, it is possible that the data role changes after the test sets it. To prevent that bb_retimer tests that require specific PD data role are run before tasks are started. BUG=b:238880607 TEST=zmake -D test test-drivers BRANCH=None Signed-off-by: Tomasz Michalec <tm@semihalf.com> Change-Id: Ia5f59a5c63f5089eeb4984672a786b96b0845877 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3763902 Tested-by: Tomasz Michalec <tmichalec@google.com> Reviewed-by: Al Semjonovs <asemjonovs@google.com> Commit-Queue: Tomasz Michalec <tmichalec@google.com>
* tentacruel: Implement LED behavior with LED DTS settings.jeffrey_lin2022-07-191-32/+95
| | | | | | | | | | | | | | Implement LED DTS settings. BUG=b:237593733 TEST=use `battfake` in EC console, set battery to different level and check LED behavior matches to the DTS settings. BRANCH=None Signed-off-by: jeffrey_lin <jeffrey_lin@pegatron.corp-partner.google.com> Change-Id: I0fdd4427dd2f4455e54f7a6f6f865fd621f2d12f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3768127 Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* Xivu: Modify motionsense rotation matrixLeila Lin2022-07-191-4/+4
| | | | | | | | | | | | | | | | Modify motionsense rotation matrix for xivu project. BUG=b:237432830 BRANCH=none TEST=zmake build xivu success. Signed-off-by: Leila Lin <leilacy_lin@compal.corp-partner.google.com> Change-Id: I98722fd685ea46c24f7bc8e674699f7c1fb1c886 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3768132 Reviewed-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org> Commit-Queue: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Tested-by: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com>
* it8xxx2: temporarily disable I2C CQ modePeter Marheine2022-07-192-0/+8
| | | | | | | | | | | | | | | | The Zephyr change that added support for CQ mode has a bug that causes errors in some transaction types. Disable CQ mode until the fix for that bug lands. BUG=b:227415000 TEST=I2C errors stopped occurring BRANCH=none Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: I57e67cc592d25935494cd7a239c583b22b056568 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3771362 Commit-Queue: Andrew McRae <amcrae@google.com> Reviewed-by: Andrew McRae <amcrae@google.com>
* volmar: Update thermal policyYu-An Chen2022-07-192-16/+16
| | | | | | | | | | | | | | Modify thermal and fan configuration BUG=b:221094660 BRANCH=none TEST=Thermal team verified thermal policy is expected. Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: I9b8901d5932e843bb52bc9b0e32a97060aa3a36b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3755244 Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* Banshee: Config BBR USB3 bit for USB card port in suspend/resumejohnwc_yeh2022-07-191-0/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | For some chromebooks design, there are expansion card (typeC to typeA) communicate with TCPC through CC line, when the TypeA card connect to chromebook the USB3_Connection bit would be enable even no connect USBA device. It will increase BBR power consumption, so clear 'USB3_Connection' bit in S0ix and enable when return S0. Suspend -> Set BBR USB3 connection bit to 0 for port that is in USB3 connection. Resume -> Unplug any type-c device in suspend will wake up the system in current Chrome OS, so enable USB3_Connection bit should be perfromed for another resume case which is USB3 device still in connection. BUG=b:233975818 BRANCH=None TEST=Test on Banshee, BBR USB3 connection bit is correct in S0/S0ix state. Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Change-Id: Ie6cb5d64578663a8e93378e3c78359e7cdd19327 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3754781 Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
* rex: minimal starting projectScott Collyer2022-07-197-0/+111
| | | | | | | | | | | | | | | | This CL is mostly a copy of the minimal zephyr project as a starting point for the Rex EC project. BRANCH=none BUG=b:239451279 TEST=zmake build rex Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: I48e87e216859deace5d52faad4d6a84bf8dcf800 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3767858 Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Commit-Queue: Scott Collyer <scollyer@chromium.org>
* usb_pd_dpm: fix sink_max_pdo_requestedEric Yilun Lin2022-07-191-1/+1
| | | | | | | | | | | | | | | | | | | The operator should be a '&' for testing if the port provides max current of the PDO. BUG=b:236430560 TEST=pass TDA.2.3.1 POW SRC LOAD PC sub item: Tester could not increase the load current, Please check the UUT VBUS voltage behavior in the capture BRANCH=none Change-Id: I8e7b4662550be2eab84adcffe2bc68923e66347c Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3752433 Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com>
* BB retimer: Modify bb retimer mutexjohnwc_yeh2022-07-191-10/+25
| | | | | | | | | | | | | | Modify mutexing access to the BB_RETIMER_REG_CONNECTION_STATE register. BUG=b:233975818 BRANCH=None TEST=build make -j BOARD=Banshee pass Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Change-Id: If92c5e989ee9bc9e26305807383fac63db2d09ca Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3768134 Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
* prism: rgbkbd: Fix space key LED mappingParth Malkan2022-07-191-1/+1
| | | | | | | | | | | | | | | LED mapping for space key is off, which makes the right most LED on the space key doesn't change color. This patch fixes the mapping. BRANCH=none BUG=b:238899691 TEST=ectool --device 18d1:5022 61 0xff0000 Signed-off-by: Parth Malkan <parthmalkan@google.com> Change-Id: Ibe4fcc68a34bb5b366882bce43c2c7e2250c60da Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3770682 Reviewed-by: YH Lin <yueherngl@chromium.org> Commit-Queue: YH Lin <yueherngl@chromium.org>
* pwrseq: gpio: Use output state for GPIO get on outputsAndrew McRae2022-07-182-0/+25
| | | | | | | | | | | | | | | | | | | | | | | When retrieving the state of an output GPIO, do not read the physical level on the pin, but instead read the configured state (by reading the GPIO configuration). Open drain outputs sometimes use low voltages, and so reading the physical level on the pin may indicate a 0 for an output that has been set to 1. The stored configuration of the GPIO does not include the GPIO_ACTIVE_LOW flag, so this is explicitly checked, and the state inverted if necessary. BUG=none TEST=zmake build nivviks; flash & run BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Idb2cb1c6b1b0902189e1fd1471cf9ca30c2711dc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3769706 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* core: Add "end" to linker scriptsTom Hughes2022-07-185-0/+30
| | | | | | | | | | | | | | | _sbrk in newlib (embedded C standard library implementation) expects the "end" symbol to point to the start of free memory. BRANCH=none BUG=b:234181908 TEST=./util/compare_build.sh -j 120 => MATCH Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I9f206e2ed5f050d92b579e0b65b05be40f929093 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3766504 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* flash_fp_mcu: Add support for 5.19 kernel for bryaPatryk Duda2022-07-181-9/+21
| | | | | | | | | | | | | | | | | | | | Brya-kernelnext uses 5.19 kernel which has different name for gpio chip ('gpiochip664' instead of 'gpiochip152') and uses different gpio numbers. Update config_brya() accordingly. BUG=b:239429127 BRANCH=none TEST=Run `tast run <IP> firmware.FpFlashFpMcuHello` on brya-kernelnext and brya make sure test passes on both platforms. Change-Id: I6955f208a8a7b797e339e775a3480ff7af80e842 Signed-off-by: Patryk Duda <pdk@semihalf.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3770326 Reviewed-by: Tom Hughes <tomhughes@chromium.org> Tested-by: Patryk Duda <patrykd@google.com> Commit-Queue: Patryk Duda <patrykd@google.com>
* zephyr: drivers: kblight: Remove 'frequency' from device treeMadhurima Paruchuri2022-07-1812-17/+1
| | | | | | | | | | | | | | Remove 'frequency' from device tree as driver is consuming that information from 'period' of PWM spec BUG=b:230093078 BRANCH=none TEST=zmake testall Signed-off-by: Madhurima Paruchuri <mparuchuri@google.com> Change-Id: I8c6d3728b3c4e550f4e8969f0c440d11b9595d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3768140 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* zephyr: drivers: kblight: Use 'period' from PWM spec inplace of 'frequency'Madhurima Paruchuri2022-07-181-1/+1
| | | | | | | | | | | | | Update driver to use 'period' from PWM spec inplace of 'frequency' BUG=b:230093078 BRANCH=none TEST=zmake testall Signed-off-by: Madhurima Paruchuri <mparuchuri@google.com> Change-Id: I260e38cb1b5eb58127a8bd617b7404ef4d037670 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3768139 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* Skyrim: Apply MP2845A workaroundDiana Z2022-07-181-0/+27
| | | | | | | | | | | | | | Apply a workaround for a MP2845A problem. BRANCH=None BUG=b:238879278 TEST=on skyrim, dump register in S0 to ensure the bit is cleared Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Id21004a165afa934e13d75ca54280bed274d0e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3761365 Reviewed-by: Robert Zieba <robertzieba@google.com> Commit-Queue: Robert Zieba <robertzieba@google.com>
* zephyr: drivers: displight: Remove 'frequency' from device treeMadhurima Paruchuri2022-07-183-7/+0
| | | | | | | | | | | | | | Remove 'frequency' from device tree as driver is consuming that information from 'period' of PWM spec BUG=b:230093078 BRANCH=none TEST=zmake testall Signed-off-by: Madhurima Paruchuri <mparuchuri@google.com> Change-Id: Iac921a7d6aef079fce0f0315433a63d3925e7ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3769709 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* zephyr: motionsense: drop few label propertiesFabio Baltieri2022-07-1819-202/+22
| | | | | | | | | | | | | | Drop label property from motionsensor bindings, replace it with the node name where it was used. BRANCH=none BUG=b:239165779 TEST=zmake testall Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ie28a25feafd4e063e0c9bd90a4a2be1b815e181d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3763914 Reviewed-by: Aaron Massey <aaronmassey@google.com>
* zephyr: temp: drop label usage for temperature senorsFabio Baltieri2022-07-1814-45/+5
| | | | | | | | | | | | | | | Zephyr is moving in the direction of reemoving the label property, for identifying the temperature sensor we can use the node name directly. BRANCH=none BUG=b:239165779 TEST=zmake testall TEST=flash brya, ran the "temps" console command Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I75e47f79c74787067fe4040ba6fccb7734a33d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3763913 Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: flash: drop the label propertyFabio Baltieri2022-07-187-14/+2
| | | | | | | | | | | | | Does not look like this was used anywhere. BRANCH=none BUG=b:239165779 TEST=zmake testall Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ia196dbea753f8790fd4e52a3ee505815ebd3afd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3763910 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* pinmap: fix lint warningFabio Baltieri2022-07-181-1/+1
| | | | | | | | | | | | | | | | | Fix: /mnt/host/source/src/platform/ec/util/pinmap/pm/generate.go:195:10: should omit 2nd value from range; this loop is equivalent to `for gc := range ...` BRANCH=none BUG=none TEST=lint is happy Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ia11992c73e75e823a95660affdd6aff219a22361 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3763909 Reviewed-by: Yuval Peress <peress@google.com>
* pinmap: drop labels from adc nodesFabio Baltieri2022-07-182-2/+0
| | | | | | | | | | | | | These are not needed anymore. BRANCH=none BUG=b:239165779 TEST=go test ./... Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I140056197db8ad692b139525cc92087bfc2ab2db Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3763908 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* zephyr: adc: drop label usage for ADC channelsFabio Baltieri2022-07-1821-89/+2
| | | | | | | | | | | | | | | | | | Zephyr is moving in the direction of reemoving the label property, for the ADC usage it's redundant as we can use the node name directly. Change the shim ADC driver to use the node name and drop the label property from the binding, nodes and documentation. BRANCH=none BUG=b:239165779 TEST=zmake testall TEST=flash brya, ran the "adc" console command Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I245abe11647c0f15ff5bee3ae42cc20e1fa9faa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3763907 Reviewed-by: Al Semjonovs <asemjonovs@google.com>
* zephyr: drivers: displight: Use 'period' from PWM spec inplace of 'frequency'Madhurima Paruchuri2022-07-181-1/+1
| | | | | | | | | | | | | Update driver to use 'period' from PWM spec inplace of 'frequency' BUG=b:230093078 BRANCH=none TEST=zmake testall Signed-off-by: Madhurima Paruchuri <mparuchuri@google.com> Change-Id: I440a8b49bc3179d9f2b1462b64499374b0a9ab01 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3769708 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* crota: switch both volume buttons GPIOPeter Chi2022-07-181-2/+2
| | | | | | | | | | | BUG=b:238713881 BRANCH=none TEST=make -j BOARD=crota Signed-off-by: Peter Chi <peter_chi@wistron.corp-partner.google.com> Change-Id: If4869c06edf8b8d7134001a1fee1499c3050c023 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3756997 Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
* Joxer: modify tablet mode GPIOScott Chao2022-07-181-1/+1
| | | | | | | | | | | | | We use GPIOJ7 as TABLET_MODE_L. BUG=b:234683955 BRANCH=none TEST=zmake build joxer Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: I9d59097b2da231ac9426e26fb4471a38685f376e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3768136 Reviewed-by: Andrew McRae <amcrae@google.com>
* ap_pwrseq: set VCCST_PWRGD_OD low early in power down sequenceDeepti Deshatty2022-07-181-1/+7
| | | | | | | | | | | | | | | | | | | | | In power down sequence or in S0 to S3 transition, VCCST_PWRGD_OD is set to low in S0S3 state. This do not meet the timing requirements. Hence change sets VCCST_PWRGD_OD set to low in S0 state when SLP_S3 is found low. PWR_VCCST_PWRGD declared as open-drain signal, measures 1.05v when set to high. Hence gpio read of PWR_VCCST_PWRGD always returns 0. Use api power_signals_on() to monitor the signal status correctly. BUG=b:236664113 BRANCH=none TEST=Verify boot and S3 on nivviks Change-Id: I422cf78ba6d086af67a8e4b1ac275aa25772b430 Signed-off-by: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3754819 Reviewed-by: Li1 Feng <li1.feng@intel.com> Reviewed-by: Andrew McRae <amcrae@google.com>
* mkbp: don't queue mkbp events in S3Ting Shen2022-07-181-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | In S3, if a mkbp event is not a wake source, we should not queue it in the mkbp fifo, otherwise the system will see a bunch of outdated event after resume. mkbp_fifo_add() uses the return value from mkbp_send_event() to decide if it needs to queue the event. So we need to pass the decision through the path activate_mkbp_with_events() -> mkbp_send_event() -> mkbp_fifo_add(). BUG=b:238057993 TEST=suspend -> lidclose -> lidopen(=resume) verify that powerd does not see the lid close event. BRANCH=cherry Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I3e1c58f97020d7ee2e3b4b56f14c4cadf51bef64 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3765440 Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Mengqi Guo <mqg@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* Joxer: enable 1.8v input for 1.8v I/OScott Chao2022-07-182-1/+28
| | | | | | | | | | | | | | Follow CL:3765107 to enable 1.8v input for 1.8v I/O on joxer BRANCH=none BUG=b:236668079, b:237717730 TEST=zmake build joxer Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: I9fe95b3c76e5255d4eece570106f1b73ab1bed39 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3768129 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Reviewed-by: Andrew McRae <amcrae@google.com>
* kingler: migrate usb_mux config to dtsEric Yilun Lin2022-07-182-33/+24
| | | | | | | | | | | | | BUG=b:227359727 TEST=enable on kingler BRANCH=none Change-Id: I97e19ce15aebcd4fc8b17e67a0bc04c55127372e Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3725856 Reviewed-by: Sung-Chi Li <lschyi@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com>
* kingler: migrate ppc config to dtsEric Yilun Lin2022-07-182-10/+12
| | | | | | | | | | | | | BUG=b:227359727 TEST=enable on kingler BRANCH=none Change-Id: I5bd68c298c5c3820ae5ba62c602729e8993017d2 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3725855 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Tested-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com>
* kingler: migrate bc12 config to dtsEric Yilun Lin2022-07-182-18/+12
| | | | | | | | | | | | | BUG=b:227359727 TEST=enable on kingler BRANCH=none Change-Id: I9230593a557e7abfa8e886abf454c5a32f6026aa Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3725854 Tested-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com>
* kingler: migrate tcpc config to dtsEric Yilun Lin2022-07-182-26/+21
| | | | | | | | | | | | | BUG=b:227359727 TEST=kingler TCPC works BRANCH=none Change-Id: I38a6efecd9bc2a2b1aea34874e6a2babed4158c1 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3725853 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com>
* rt1718s: suffix comma at config definition macroEric Yilun Lin2022-07-182-2/+2
| | | | | | | | | | | | | | | | | The comma is needed after f1addb9d960dd94827f3eeb53e9654b963cd0f54, 7c114b8e1a3bb29991da70b9de394ac5d4f6c909 reverted. BUG=b:227359727 TEST=zmake build kingler BRANCH=none Change-Id: I3b35ccc0e4b1fc8620dcb876a23fa32a1b415ffb Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3768126 Tested-by: Eric Yilun Lin <yllin@google.com> Auto-Submit: Eric Yilun Lin <yllin@google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com> Reviewed-by: Sung-Chi Li <lschyi@chromium.org>
* nx20p348x: add device binding for PPCEric Yilun Lin2022-07-184-6/+50
| | | | | | | | | | | | | | | add NXP NX20P348X PPC device binding BUG=b:227359727 TEST=enable on kingler BRANCH=none Change-Id: Id050a0cb5fccf3dd0b868f374bf2849087ec6505 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3725851 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com>
* anx7447: add device binding for TCPC and USB_MUXEric Yilun Lin2022-07-186-2/+72
| | | | | | | | | | | | | | | | add anx7447 dt-bindings for TCPC and USBC MUX. BUG=b:227359727 TEST=enable on kingler, and TCPC/USBC works BRANCH=none Change-Id: Ib248d8b4bd0eee447193be0de28605da9aa8b1c9 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3725850 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
* ps8xxx: move ps8xxx_tcpc_update_hpd_status binding out of tcpciEric Yilun Lin2022-07-182-2/+2
| | | | | | | | | | | | | | | | It's more reasonable to place ps8xxx_tcpc_update_hpd_status in parade,usbc-mux-ps8xxx.yaml. BUG=none TEST=zmake testall BRANCH=none Change-Id: I950276f7d44093c602ba80940f5522d8a47dda26 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3725849 Tested-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com>
* Nereid: enable 1.8v input for 1.8v I/ODino Li2022-07-182-1/+24
| | | | | | | | | | | | | | | | | | | | | | | | | Since the I/O voltage of the following signals is 1.8 V, the 1.8V input selection is enabled. - IMU_INT_L - ACC_INT_L - EC_I2C_SENSOR_SCL - EC_I2C_SENSOR_SDA - VCCIN_AUX_VID0 - VCCIN_AUX_VID1 Note: I/O voltage of EC_PROCHOT_ODL and EC_SOC_VCCST_PWRGD_OD are 1.05V. Chose the closest voltage configuration for them. BRANCH=none BUG=b:236668079, b:237717730 TEST=The corresponding 1.8v input control bit is set to 1. Saved ~2mW on Nereid in S0/S0ix state. Signed-off-by: Dino Li <Dino.Li@ite.com.tw> Change-Id: I05a406c6cc21ff651c594fe7a64be1d91a9416cd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3765107 Reviewed-by: Andrew McRae <amcrae@google.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* kinox: disable fan full on when board initialMatt Wang2022-07-182-8/+1
| | | | | | | | | | | | | Remove fan pwm duty 100 when board initial. BUG=b:238284556 BRANCH=none TEST=Fan not rotating when board initial. Signed-off-by: Matt Wang <matt_wang@compal.corp-partner.google.com> Change-Id: Id03d958fa3badfe4e36e79ed4b2f8f12ed8230c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3759837 Reviewed-by: Ricky Chang <rickytlchang@chromium.org>
* zephyr: shim: fan: Replace multiple members of 'fan_config' structure with ↵Madhurima Paruchuri2022-07-161-19/+13
| | | | | | | | | | | | | | | | | | | 'pwm_dt_spec' Add 'pwm_dt_spec' as a member in 'fan_config' structure, replacing existing members 'pwm', 'channel', 'flags' and 'period_ns' BUG=b:230093078 BRANCH=none TEST=zmake testall TEST=check if fan_config structure has correct 'period_ns' value using gdb: gdb ./build/zephyr/${BOARD}/build-ro/zephyr/zephyr.elf p fan_config Signed-off-by: Madhurima Paruchuri <mparuchuri@google.com> Change-Id: Idc306517629cd7140aa1bb162027cf566131cff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3763021 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* docs/fingerprint: Update power numbers for latest dartmonkey releaseTom Hughes2022-07-161-11/+11
| | | | | | | | | | | | BRANCH=none BUG=none TEST=view in gitiles Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Ibd83afbb767ad90641a95822119c2eee291c5844 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3739315 Reviewed-by: Bobby Casey <bobbycasey@google.com> Reviewed-by: Andrea Grandi <agrandi@google.com>
* common/util: Add castsTom Hughes2022-07-162-2/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | When compiling against the standard library, clang complains: common/util.c:66:6: error: array subscript is of type 'char' [-Werror,-Wchar-subscripts] tolower(*s) == 'f' || tolower(*s) == 'n') { ^~~~~~~~~~~ According to POSIX: The tolower() and tolower_l() functions have as a domain a type int, the value of which is representable as an unsigned char or the value of EOF. If the argument has any other value, the behavior is undefined. https://pubs.opengroup.org/onlinepubs/9699919799/functions/tolower.html BRANCH=none BUG=b:234181908 TEST=make utils-str Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I84f4bfb647f29b24b1c3bd7f5d222275354c4698 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3765458 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
* retimer: firmware update retry onlineLi Feng2022-07-151-14/+152
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL implements error recovery for case as below. In NDA ports retimer firmware update, when NVM is updated and issued authentication, retimer takes about 5 seconds to come back. After this, host can bring the port online. Online means EC disconnects the USB mux and resumes PD port. If user requests EC to put port online without waiting 5 seconds, The operation will fail. The PD port couldn't get out of suspended state. It's disabled. This CL adds a deferred call to check if PD port is online successfully; if not, retry online again to enable the PD port. Also if the port is requested to be online but not resumed yet, except RESUME_PD, no other host requests will be allowed. As soon as port is resumed, the port can accept requestes again. BUG=b:212235056 b:211790542 BRANCH=none TEST=On Redrix NDA PD port, echo 1 > offline update NVM and authenticate; not waiting 5 seconds. echo 0 > offline The port failed to be online, after delay, deferred call is triggered. Online is tried again; port is enabled. Signed-off-by: Li Feng <li1.feng@intel.com> Change-Id: I7ec96a4dfb81e8ed2422e459a098defa4c8acf92 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3666378 Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* Skyrim: Remove guybrush supportTim Van Patten2022-07-157-946/+1
| | | | | | | | | | | | | | | Skyrim hardware is available now, so remove guybrush as a skyrim "variant". BUG=b:231996904 TEST=emerge-skyrim chromeos-zephyr TEST=zmake build skyrim BRANCH=None Signed-off-by: Tim Van Patten <timvp@google.com> Change-Id: I3da3b7a8b67664f3e076a90c570c74302b22d528 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3765445 Reviewed-by: Diana Z <dzigterman@chromium.org>
* board/garg: Free up more flash spaceTom Hughes2022-07-151-0/+1
| | | | | | | | | | | | | | | | | | | | | Before: RO: 192 bytes in flash and 30848 bytes in RAM still available RW: 284 bytes in flash and 30848 bytes in RAM still available After: RO: 736 bytes in flash and 30880 bytes in RAM still available RW: 860 bytes in flash and 30880 bytes in RAM still available BRANCH=none BUG=b:238433667 TEST=make buildall Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I0d940ab2124f657f8b70c7d96f7dd24bf67622c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3765446 Reviewed-by: Diana Z <dzigterman@chromium.org>
* TCPMv2: TBT cable entry/exit should be symmetricalLi Feng2022-07-151-30/+16
| | | | | | | | | | | | | | | | | | | | | | If SOP'/SOP'' enters TBT alt mode; then the code should have exit logic for SOP'/SOP'' too. With LRD cable, there is SOP' enter mode, but no SOP' exit mode. The LRD cable SOP' exit mode logic is added. Also only check SOP'' field in the active cable identity VDO when the cable reports it's active. BUG=none BRANCH=none TEST=on Brya, connect TBT dock with LRD cable, SOP' exit mode is sent when exit TBT alt mode. Signed-off-by: Li Feng <li1.feng@intel.com> Change-Id: Idef5a381ea3b51b4b5a5e102bd321eb8fb87dca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3746291 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
* Revert "Skyrim: Remove guybrush support"Tim Van Patten2022-07-157-0/+946
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit f9bbc1f59586878d9bbb9eac25e959e306661e67. Reason for revert: Breaks gitlab: https://gitlab.com/zephyr-ec/ec/-/jobs/2724604404 Original change's description: > Skyrim: Remove guybrush support > > Skyrim hardware is available now, so remove guybrush as a skyrim > "variant". > > BUG=b:231996904 > TEST=emerge-skyrim chromeos-zephyr > BRANCH=None > > Change-Id: Id8084000b112fe38a8f9556688e4d9c8edd68b10 > Signed-off-by: Tim Van Patten <timvp@google.com> > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3763782 > Reviewed-by: Diana Z <dzigterman@chromium.org> Bug: b:231996904 Change-Id: I046926c82ad9fdcd4c8835bf22227dbf70afed95 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3765443 Reviewed-by: Tim Van Patten <timvp@google.com> Tested-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
View Lorry Controller Status