summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* joxer: tune AP power force shutdown sequence orderstabilize-15033.B-mainWill Tsai2022-08-081-1/+1
| | | | | | | | | | | | | | | We swap the order of DSW_PWROK and RSMRST to meet the spec. BUG=b:241512065 BRANCH=none TEST=zmake build joxer, verified by EE Signed-off-by: Will Tsai <will_tsai@wistron.corp-partner.google.com> Change-Id: I3332d3af3aaeb0f647c281b77573b877e3091001 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3811081 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Reviewed-by: Li1 Feng <li1.feng@intel.com> Reviewed-by: Andrew McRae <amcrae@google.com>
* Craask: Setting few GPIOs to 1.8VSue Chen2022-08-082-2/+8
| | | | | | | | | | | | | | | | | | | Few GPIO's which operate at 1.8v need to set GPIO_VOLTAGE_1P8. This improves in EC power consumption in S0ix mode. For b/228222441, there is no difference on hardware design of these GPIOs between Nivviks and Craask so Craask also need the change CL:3702877. BUG=none BRANCH=none TEST=Verified S0ix on nivviks Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: Ie41aebf5511ab7f72cc5ffedec5b47aa9a807f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3813234 Reviewed-by: Andrew McRae <amcrae@google.com>
* Quackingstick: Move 2s delay time to battery_is_presentSue Chen2022-08-082-7/+14
| | | | | | | | | | | | | | Remove the workaround 2s in HOOK_INIT for first boot. Add 2s delay to battery_is_present() defined in board level. BUG=b:231911921 BRANCH=trogdor TEST=no power loss after the battery resume from cut off. Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: Id0f8e5beeee2934b61e21d6602419c4ca29ef2de Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3787357 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* kinox: remove unused type-c configurationJosh Tsai2022-08-081-10/+1
| | | | | | | | | | | | | | | | Due to kinox does not suuport USB4 and TBT, so remove the unused configuration BRANCH=none BUG=b:238587431 TEST=monitor can be detected after system reboot with type-c dongle Signed-off-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com> Change-Id: I8159a0e271f221e3a0d04d65f71d5b2c0b2a54d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3807179 Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: Elmo Lan <elmo_lan@compal.corp-partner.google.com> Reviewed-by: Ricky Chang <rickytlchang@chromium.org>
* mithrax: rgbkb: Fix KB BL during S0ix -> S0stabilize-15032.B-mainParth Malkan2022-08-051-8/+0
| | | | | | | | | | | | | | | Mithrax disables EC_KB_BL during suspend, which resets the LED driver and doesn't restore the KB BL state after resuming from suspend. This patch fixes the issue. BUG=b:241497661 TEST=Manual test on Mithrax BRANCH=None Signed-off-by: Parth Malkan <parthmalkan@google.com> Change-Id: I52a27d128e62acb8e6fa2849f92d787d752a9c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3811890 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* zephyr: tests: remove BUILD.py for Zephyr EC unit testsTristan Honscheid2022-08-0514-148/+11
| | | | | | | | | | | | | | | | | | | | | | | We have completed transitioning tests to Twister and verified parity in coverage reports between this and the previous version. This CL removes the BUILD.py files from our tests that declare the zmake projects and removes the call to `zmake -D test -a --no-rebuild` from `zephyr/firmware-builder.py` The `EC_ZEPHYR_MERGED` metric is now derived from Twister's coverage data instead. Made corresponding changes to `.gitlab-ci.yml` This CL was tested by comparing the total coverage and list of covered files before and after the change. BUG=b:240093007 BRANCH=None TEST=zephyr/firmware-builder.py --code-coverage {build|test|bundle} Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: I865a22a44f56760790444499c7588f7aec299374 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3811956 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Yuval Peress <peress@google.com>
* metadata: Create DIR_METADATA for the EC repoKeith Short2022-08-052-0/+26
| | | | | | | | | | | | | | | | Add a DIR_METADATA for general EC, and for the Zephyr specific files in the EC repository. BUG=b:231317150 BRANCH=none TEST=dirmd validate ./DIR_METADATA TEST=dirmd validate zephyr/DIR_METADATA Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I4e6c317b8258a1e08e42b0108d2e8516925f93dd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3813047 Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
* usbhc: Initialize usbhc state variable to READY_TO_RXParth Malkan2022-08-051-5/+2
| | | | | | | | | | | | | | | usbhc state gets initialized to Disabled, it should be initialized to READY_TO_RX, this patch fixes that. BUG=b:239103306 TEST=Tested manually on Vell with RGB and KB BL host commands after device wakes up from suspend BRANCH=None Signed-off-by: Parth Malkan <parthmalkan@google.com> Change-Id: I154667a4300bf513f320742cec881ae59985828e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3812504 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* util: remove unused includesYuval Peress2022-08-05175-14/+182
| | | | | | | | | | | | | | | | Remove these includes as they're not needed in this header. Instead, the includes should go where they're actually being used. BRANCH=none BUG=b:240574048 TEST=make buildall -j TEST=zmake build -a Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I64b10af3216654b2a20caa1cabd267661a0bca39 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3791980 Reviewed-by: Tristan Honscheid <honscheid@google.com> Commit-Queue: Tristan Honscheid <honscheid@google.com>
* zephyr: emul: get emul_port with DEVICE_DT_GETFabio Baltieri2022-08-051-1/+1
| | | | | | | | | | | | | | | | Change ap_power test to get the gpio port using the nodelabel instead of the label property. This works with upstream, where the label property is being removed. BRANCH=none BUG=none TEST=zmake testall Cq-Depend: chromium:3813331 Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I4a2752c358aac8e4a8f2e59c55982f2386b30485 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3811112 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: emul: drop i2c_label from emul configsFabio Baltieri2022-08-0515-20/+0
| | | | | | | | | | | | | | | This is not used anywhere and is causing problem with downstreaming since the label is being removed. BRANCH=none BUG=none TEST=zmake testall Cq-Depend: chromium:3813331 Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I1b900670bde540a745648eb72e7801dec74272b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3811111 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* Revert "vell: Disable BBR firmware update"Devin Lu2022-08-051-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 10bf02bbae296df6029976a397f26526ba5b9e2a. Reason for revert: b/221136387 Original change's description: > vell: Disable BBR firmware update > > Disable BBR firmware update temporally, revert this patch once > confirm BBR firmware update is ready on kernel. > > BUG=b:220634230 > BRANCH=none > TEST=On Vell. Verify usbc ports are not disabled after boot to CrOS. > > Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> > Change-Id: I44b5e317743bd7073f30140b4556c2f728c64ced > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3478978 > Reviewed-by: caveh jalali <caveh@chromium.org> Bug: b:220634230 Change-Id: I4872a72a8a0df0c8dae670aa739719bc1279848a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3813235 Commit-Queue: YH Lin <yueherngl@chromium.org> Tested-by: Devin Lu <devin.lu@quantatw.com> Reviewed-by: YH Lin <yueherngl@chromium.org>
* Revert "zephyr: Make ZEPHYR_BASE not an environment variable"Jack Rosenthal2022-08-0532-38/+73
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d16be8f98d81d7e589935d1c6c78ec4430a8960d. Reason for revert: suspected at fault for b/241489955 (suspect we're stripping ccache environment variables in ninja call) BUG=b:241489955 TEST=CQ Original change's description: > zephyr: Make ZEPHYR_BASE not an environment variable > > To minimize the amount of environment variable dependency we have, move > ZEPHYR_BASE (used to find the "Zephyr" CMake package) from an > environment variable to a CMake definition. > > This makes our only required environment variable PATH, so we can do a > complete environment scrub for all commands executed. > > BUG=b:239619222 > BRANCH=none > TEST=zmake testall > > Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> > Change-Id: Ie34a9e1f49177649cf0e54c95d73b41bd1b94992 > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3811715 > Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Bug: b:239619222 Change-Id: I9cfdb04fc61d013ba670049c5dbbeeca7de4893c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3813042 Auto-Submit: Jack Rosenthal <jrosenth@chromium.org> Tested-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Tested-by: Bob Moragues <moragues@chromium.org>
* zephyr: move charger nodes onto i2c busesDawid Niedzwiecki2022-08-0537-215/+231
| | | | | | | | | | | | | | | | Move all charger nodes onto the i2c buses from named-usbc-port nodes. The change should simplify the upstream process of the charger chips drivers. BUG=b:241062565 TEST=zmake testall; make sure charging works BRANCH=main Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: I5c8e358cc56d5fd7b5a91971d41e4269e84e949e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3805199 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* zephyr: move tcpc nodes onto i2c busesDawid Niedzwiecki2022-08-0539-421/+341
| | | | | | | | | | | | | | | | | | Move all tcpc nodes onto the i2c buses from named-usbc-port nodes. The change should simplify the upstream process of the tcpc chips drivers. BUG=b:240617928 TEST=zmake testall; make sure all TCPCs work by attaching a charger BRANCH=main Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: I9dfd1187fcb222df41bc3f129265e7dfd0e0c4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3797608 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org> Tested-by: Dawid Niedźwiecki <dn@semihalf.com>
* volmar: Remove tablet modeYu-An Chen2022-08-053-2/+6
| | | | | | | | | | | | | | | Since volmar doesn't support tablet mode, remove it to avoid unexpected triggering. BUG=b:224423318 BRANCH=none TEST=make BOARD=volmar Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: Id8533549265a7ab02355bcd6af1038d6b0d2b59d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3781950 Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: caveh jalali <caveh@chromium.org>
* Nissa/Craask: add 2nd source for LID ACCELSue Chen2022-08-056-1/+87
| | | | | | | | | | | | | | | Use ssfc bit2-3 to identify LID ACCEL sensor. 0: lis2dw12 1: bma422 BUG=b:240040384 BRANCH=none TEST=can read raw data from bma422 after setting ssfc=0x4 Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I515b808b94b344c7c2f134a4ab1ab862a69e8370 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3807187 Reviewed-by: Andrew McRae <amcrae@google.com>
* Reland "burnet: Replace 2nd source base accel sensor"Devin Lu2022-08-052-27/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0c7b1d9720377c5c6922ab9cc9d692aca6fb8bf5. Reason for revert: b/230553688 Original change's description: > Revert "burnet: Replace 2nd source base accel sensor" > > This reverts commit 2d90081520b78e1124688c914cd03b26aa543d8c. > > Reason for revert: deprecate ICM-42607 and resume ICM-40608 > > Original change's description: > > burnet: Replace 2nd source base accel sensor > > > > This patch replaces 2nd source base accelerometer to ICM-42607. > > > > BUG=b:230553688 > > BRANCH=firmware-kukui-12573.B > > TEST=On Burnet. Sensor works. > > > > Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> > > Change-Id: Ia5456f2f87d644821371ac0ffdea16c07a5c3fff > > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3508936 > > Reviewed-by: Eric Yilun Lin <yllin@google.com> > > Bug: b:230553688 > Change-Id: I4e085c55e4ed790ced3506ff9a39dae6ffb91c26 > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3737695 > Reviewed-by: Ting Shen <phoenixshen@chromium.org> > Tested-by: Devin Lu <devin.lu@quantatw.com> > Commit-Queue: Devin Lu <devin.lu@quantatw.com> Bug: b:230553688 Change-Id: I4e5ac5de21e63fb002e3424132118b2acfc8a796 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3809411 Commit-Queue: Devin Lu <devin.lu@quantatw.com> Tested-by: Devin Lu <devin.lu@quantatw.com> Reviewed-by: Chen-Tsung Hsieh <chentsung@chromium.org>
* crota: modify fan rpm range and rpm deviationPeter Chi2022-08-053-84/+129
| | | | | | | | | | | | | | | | | | | Crota's fan speed is control by four sensors, and sensor SOC has two slopes for fan speed, so we have five tables. Priority is: Charger > SOC > DDR > Ambient, and the sensor table decided on priorty sensor. Currently rpm deviation is 7%, It will cause [ectool pwmsetfanrpm 4000] and [ectool pwmgetfanrpm] not accurate. BUG=b:241191468 BRANCH=none TEST=make -j BOARD=crota Signed-off-by: Peter Chi <peter_chi@wistron.corp-partner.google.com> Change-Id: I7ea9c53f168b2ab3f050b87006adb772c9f08ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3782467 Reviewed-by: Boris Mittelberg <bmbm@google.com>
* ec: Fix stack smashing in motion_sense_fifoJeremy Bettis2022-08-043-15/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | The struct ec_response_motion_sense_fifo_info contains one of those annoying [0] arrays, therefore you need to actually allocate extra space for the data after the end of the struct. Change all allocations of struct ec_response_motion_sense_fifo_info to actually use a uint8_t[] instead that is sizeof(struct ec_response_motion_sense_fifo_info) + sizeof(uint16_t) * MAX_MOTION_SENSORS. Added comment to motion_sense_fifo_get_info() to warn people about the pointer they pass into the function. BRANCH=None BUG=b:237305991 TEST=make run-coverage-motion_sense_fifo in chroot, and gitlab docker Change-Id: I23bc3168c43ce1e4cb20584e6a455773a789ff02 Signed-off-by: Jeremy Bettis <jbettis@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3812496 Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Aaron Massey <aaronmassey@google.com>
* ec_commands: support C++ for rand_numYuval Peress2022-08-041-3/+12
| | | | | | | | | | | | | | | | Update the struct edc_response_rand_num to have a size 1 which will allow it to compile with C++. As documented, this will work because any request using ec_params_rand_num::num_rand_bytes should always set to at least 1. BRANCH=none BUG=none TEST=zmake testall Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I06d2a4032033797f9858aecc4c45e858d8f19339 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3765454 Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: shim: add all missing include/ prefixesFabio Baltieri2022-08-0492-108/+108
| | | | | | | | | | | | | | | Add all the missing include/ prefixes to the various #include around the zephyr tests so that they build with LEGACY_INCLUDE_PATH=n. BRANCH=none BUG=none TEST=zmake testall Cq-Depend: chromium:3807663 Change-Id: I81cea4f291eea61e674ef2fa61bdc60407c5f142 Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3810411 Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: Make ZEPHYR_BASE not an environment variableJack Rosenthal2022-08-0432-73/+38
| | | | | | | | | | | | | | | | | | To minimize the amount of environment variable dependency we have, move ZEPHYR_BASE (used to find the "Zephyr" CMake package) from an environment variable to a CMake definition. This makes our only required environment variable PATH, so we can do a complete environment scrub for all commands executed. BUG=b:239619222 BRANCH=none TEST=zmake testall Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: Ie34a9e1f49177649cf0e54c95d73b41bd1b94992 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3811715 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* rex: update zephyr board to correct version for P0Scott Collyer2022-08-041-1/+1
| | | | | | | | | | | | | | | | This CL sets the zephyr_board to the correct value for the EC. This version has 384kB flash space for both RO/RW instead of 256kB. BRANCH=none BUG=b:240434243 TEST=zmake build rex Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: I7a1bb5b33a8915a931dfb2aa1f4fac0ac8cbf8af Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3808540 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Commit-Queue: Scott Collyer <scollyer@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org>
* rex: Add support for battery/charging/USBC port 0Scott Collyer2022-08-0410-9/+556
| | | | | | | | | | | | | | | | | | | | This CL adds config options and dts info for battery and charging. In addition, this CL adds support for USBC port 0. Charging depends on battery and there is also a dependency on USBC support, so this blocks must be added together. BRANCH=none BUG=b:240434243 TEST=zmake build rex Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: I180dd01f4b1b6e05a83677c9e5adc59829035c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3803584 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Commit-Queue: Scott Collyer <scollyer@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
* rex: Add support for power sequencingScott Collyer2022-08-045-2/+226
| | | | | | | | | | | | | | | | | This CL adds the config options, power signals nodes, and support functions required to support power sequencing. BRANCH=none BUG=b:240434243 TEST=zmake build rex Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: I932995ddac4831bc0be3efefd7d345beef122178 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3798471 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Commit-Queue: Scott Collyer <scollyer@chromium.org>
* Felwinter/Mithrax: Correct LED behaviorjohnwc_yeh2022-08-042-2/+2
| | | | | | | | | | | | | | | Modify led_charge_lvl_2 94 to 95 BUG=b:240459097 BRANCH=None TEST=make BOARD=mithrax Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Change-Id: I30c1cca1d0f5d51538f426b17d20268ef66c8339 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3810132 Reviewed-by: Ricky Chang <rickytlchang@chromium.org> Commit-Queue: Ricky Chang <rickytlchang@chromium.org> Reviewed-by: Ko Ko <ko_ko@compal.corp-partner.google.com>
* mtlrvp: ap_pwrseq: set X86_NON_DSX_PWRSEQ_HOST_CMDLi Feng2022-08-041-0/+1
| | | | | | | | | | | | | | | Enable CONFIG_X86_NON_DSX_PWRSEQ_HOST_CMD to include native power sequencing host command file. BUG=none BRANCH=none TEST=zmake testall Signed-off-by: Li Feng <li1.feng@intel.com> Change-Id: I7f7207aaf202cc104a8920d43490eb3fec6c4cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3800326 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
* Revert "mkbp: don't queue mkbp events in S3"Ting Shen2022-08-041-8/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 524cba08cceb373050cf79c41e4f6f92ff519c5e. Reason for revert: b/241036338 we need EC_MKBP_EVENT_BUTTON queued in S3. Original change's description: > mkbp: don't queue mkbp events in S3 > > In S3, if a mkbp event is not a wake source, we should not queue it in > the mkbp fifo, otherwise the system will see a bunch of outdated event > after resume. > > mkbp_fifo_add() uses the return value from mkbp_send_event() to > decide if it needs to queue the event. So we need to pass the decision > through the path activate_mkbp_with_events() -> mkbp_send_event() -> > mkbp_fifo_add(). > > BUG=b:238057993 > TEST=suspend -> lidclose -> lidopen(=resume) > verify that powerd does not see the lid close event. > BRANCH=cherry > > Signed-off-by: Ting Shen <phoenixshen@google.com> > Change-Id: I3e1c58f97020d7ee2e3b4b56f14c4cadf51bef64 > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3765440 > Reviewed-by: Jett Rink <jettrink@chromium.org> > Commit-Queue: Ting Shen <phoenixshen@chromium.org> > Reviewed-by: Mengqi Guo <mqg@chromium.org> > Tested-by: Ting Shen <phoenixshen@chromium.org> Bug: b:238057993 Change-Id: I0b66b06d3c834641426dda24d71fc462d0030f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3807177 Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* shotzo: Remove unused featuresHank.Xie2022-08-047-509/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove unused feature as below. Volume button Fw_config G-sensor stylus Lid Tablet mode Keyboard OCPC Hibernate Cbi_ssfc Gpio: EC_SUB_IO_1_2 EC_SUB_IO_2_1 Cbi_ssfc BC1.2 Charge ramp hw BUG=b:235983675, b:241215360 BRANCH=none TEST=make BOARD=shotzo Signed-off-by: Hank Xie <hank.xie@quanta.corp-partner.google.com> Change-Id: I609a60d1ba24573383aa0a134934073d5609dcc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3686726 Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* usb_mux/anx7447: use anx7447 usb_mux driverEric Yilun Lin2022-08-044-8/+29
| | | | | | | | | | | | | | | | | | Anx7447 is not able to use tcpci_usb_mux_driver, so fix this by using anx7447_usb_mux_driver instead. Also, add property hpd-update-enable for anx7447_tcpc_update_hpd_status. BUG=b:227359727 b:238170235 TEST=Kingler C0 is able to DP out BRANCH=none Change-Id: I34d04a2d434f0140b326c9ae41b6b5c6cd8b0a80 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3801772 Commit-Queue: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Tested-by: Eric Yilun Lin <yllin@google.com>
* sm5803: Add support for board with only one charger chipHank.Xie2022-08-041-0/+6
| | | | | | | | | | | | | | | | | | Shotzo use charger sm5803 but has only one charger chip. Define CONFIG_CHARGER_SINGLE_CHIP will fail to build. To build successfully, replace CHARGER_PRIMARY with CHARGER_SOLO, and avoid the refencing of CHARGER_SECONDARY. BUG=none BRANCH=firmware-dedede-13606.B-master TEST=On shotzo. Check C0 port works fine. Signed-off-by: Hank.Xie <hank.xie@quanta.corp-partner.google.com> Change-Id: Id3460916485b0aede0c6744378e980fb4168d84c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3807184 Reviewed-by: Devin Lu <devin.lu@quantatw.com> Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* ec_memmap: Add Power source to EC MEMMAP regionpoornima tom2022-08-031-1/+5
| | | | | | | | | | | | | | | | | | | | | | For Intel Dynamic Tuning Platform Power Participant, power source(PSRC) is one of the object. This PSRC corresponds to an 8 bit value, representing the current power source as lower nibble and PD sequence number as upper nibble. PSRC information must be updated at EC and must be read by AP. As there is only a read request from AP, this component could be present in EC_MEMMAP region. Document #doc-626708, has more details. BUG=b:205928013 BRANCH=None TEST=make build_cros_ec_commands Signed-off-by: poornima tom <poornima.tom@intel.com> Change-Id: Iebfb305e95e647cbe3d83a351765b7711070981e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3545778 Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com> Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
* motion_sense_fifo: Reset timestamp only when ODR changesGwendal Grignou2022-08-034-44/+37
| | | | | | | | | | | | | | | | | | | | | Timestamp spreading is reset after each fifo commit. It prevents the fifo logic to operate when the EC takes more than a period to collect the samples. Reset timestamp spreading only when ODR changes. Move needed fields inside motion_sense_fifo to handle virtual sensors. Fixes commit bc9660a4b3e8 ("common: motionsense fifo: Reset the initialized bits after commit") BUG=b:168335284,b:237305991,b:217580259 BRANCH=all TEST=make run-motion_sense_fifo Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Change-Id: If7265079f7fc7f4e7e22dd80865305f4553df020 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3754212 Reviewed-by: Yuval Peress <peress@google.com>
* motion_sense_fifo: Move lost to motion_sensor_fifoGwendal Grignou2022-08-035-21/+19
| | | | | | | | | | | | | | Move lost field from the sensor object to inside motion_sense_fifo: It is not used anywhere else. BUG=b:237305991 BRANCH=brya TEST=make -j BOARD=crota Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Change-Id: Idfb159ed9025e859e86bb494cf5da98df9cf4a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3754211 Reviewed-by: Yuval Peress <peress@google.com>
* motion_sense_fifo: use is_new_timestampGwendal Grignou2022-08-031-2/+2
| | | | | | | | | | | | | Hide bit field inside is_new_timestamp() for consistency BUG=none BRANCH=brya TEST=make runtests Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Change-Id: Ide3c2d9beeee131c49c5dcf9a9a0055540b8e6a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3754210 Reviewed-by: Yuval Peress <peress@google.com>
* zephyr: Fix listing of test casesAl Semjonovs2022-08-031-5/+2
| | | | | | | | | | | | | Use correct ZTEST API so test cases can be listed BUG=b:240364238 BRANCH=NONE TEST=./zephyr.exe -list Signed-off-by: Al Semjonovs <asemjonovs@google.com> Change-Id: If3b603ab64421da558228e67a907039a1674ba0b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3789128 Reviewed-by: Yuval Peress <peress@google.com>
* zephyr: emul: Use EMUL_DT_INST_DEFINEAbe Levkoy2022-08-0315-74/+72
| | | | | | | | | | | | | | | | Update the emulators to use EMUL_DT_INST_DEFINE and EMUL_DT_GET instead of EMUL_DEFINE and EMUL_REG_NAME, because the latter have been removed upstream. BUG=b:224588313 TEST=zmake testall BRANCH=none Cq-Depend: chromium:3806745 Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: If358bd2bcfe9b99df0a671e2542a94deb5fad8f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3805535 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* zephyr: test: Convert system test to new ZTEST APITomasz Michalec2022-08-032-8/+6
| | | | | | | | | | | | | | | | | Enable ZTEST_NEW_API for system tests BRANCH=None BUG=b:240343510 TEST=./twister -T zephyr/test/system TEST=zmake -D test test-system Signed-off-by: Tomasz Michalec <tm@semihalf.com> Change-Id: I1b4088bdd79191a8dc6c6c1ad20a5d6b4f17781d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3790851 Tested-by: Tristan Honscheid <honscheid@google.com> Reviewed-by: Yuval Peress <peress@google.com> Commit-Queue: Tristan Honscheid <honscheid@google.com> Reviewed-by: Tristan Honscheid <honscheid@google.com>
* Zephyr test: Add BIST shared mode testDiana Z2022-08-032-0/+197
| | | | | | | | | | | | | | Add a test for BIST shared mode to ensure we're properly following our spec requirements for it. BRANCH=None BUG=b:237256250 TEST=zmake testall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: If476fb5faed328c6e9fc4c94db0484f3166b357e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3789838 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* Zephyr test: Store last 5V fixed source cap for referenceDiana Z2022-08-032-0/+20
| | | | | | | | | | | | | | | | The 5V fixed source cap may have a number of testable fields we'd be interested in, such as the power offered or static capabilities advertised. Store it for the tests to reference, and allow them to clear it when desired. BRANCH=None BUG=b:237256250 TEST=zmake testall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Ic396be8ca30ba5f1a86c1da1fe60a7a4c66dbea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3789837 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* Zephyr test: Create a shared sink connection utilityDiana Z2022-08-035-108/+77
| | | | | | | | | | | | | | Many tests are repeating essentially the same code to connect a sink. Make a common utility for them all to reference. BRANCH=None BUG=b:237256250 TEST=zmake testall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Ic7bb083992b67414e58c8b8fb932e8f7f58c8f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3789836 Reviewed-by: Aaron Massey <aaronmassey@google.com>
* pujjo: Change power LED from pwm to gpiojimmy.wu2022-08-033-26/+18
| | | | | | | | | | | | | | Remove power LED from pwm led node, change it into gpio control. BUG=b:240087038 TEST=zmake build pujjo BRANCH=none Signed-off-by: jimmy.wu <jimmy.wu@lcfc.corp-partner.google.com> Change-Id: Ic279a94f48197ff2e67542bfda4902aa9f4ab760 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3807285 Reviewed-by: Andrew McRae <amcrae@google.com>
* zephyr: test: battery: Set battery present after testTomasz Michalec2022-08-031-1/+11
| | | | | | | | | | | | | | | | Add after function for battery testsuite and set battery GPIO to present in that function. BUG=None TEST=zmake -D test test-drivers BRANCH=None Signed-off-by: Tomasz Michalec <tm@semihalf.com> Change-Id: Ie50b59b6e971df3d4aa7b93db48a27e931bd313e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3805204 Commit-Queue: Tomasz Michalec <tmichalec@google.com> Reviewed-by: Sam Hurst <shurst@google.com> Tested-by: Tomasz Michalec <tmichalec@google.com>
* zephyr: test: tcpci: Reset TCPC mux flags after testTomasz Michalec2022-08-031-1/+7
| | | | | | | | | | | | | | | | | Reset USB_MUX_FLAG_NOT_TCPC flag in usb mux associated with TCPC after TCPCI test. With this flag set, TCPC init function is changed and all alerts are masked. This may result in failing USB integration tests. BUG=None TEST=zmake -D test test-drivers BRANCH=None Signed-off-by: Tomasz Michalec <tm@semihalf.com> Change-Id: I4d819300d9474b989776bf41419d22e91fac4a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3805201 Reviewed-by: Al Semjonovs <asemjonovs@google.com> Tested-by: Tomasz Michalec <tmichalec@google.com> Commit-Queue: Tomasz Michalec <tmichalec@google.com>
* zephyr: test: ps8xxx: tcpci: Run TCPC test before tasksTomasz Michalec2022-08-032-7/+4
| | | | | | | | | | | | | | | | Move whole tcpci and ps8xxx testsuites to run before tasks. These testsuites are using drivers directly and can mess up USBC PD SM state. BUG=None TEST=zmake -D test test-drivers BRANCH=None Signed-off-by: Tomasz Michalec <tm@semihalf.com> Change-Id: I25de8d58576d766e3287286f9e154afe19af3758 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3805200 Tested-by: Tomasz Michalec <tmichalec@google.com> Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Tomasz Michalec <tmichalec@google.com>
* chip/mt_scp: add define to support av1 decoderXiaoyong Lu2022-08-031-0/+1
| | | | | | | | | | | | | | | Add define to support av1 decoder in scp: VDEC_CAP_AV1_FRAME BIT(11) BUG=b:205889935 TEST= av1/vp9/h264/vp8 fluster test pass Signed-off-by: Xiaoyong Lu <xiaoyong.lu@mediatek.corp-partner.google.com> Change-Id: I29de57ae4cb15fee30b2082c688ff446c2360fea Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3771327 Tested-by: Yunfei Dong <yunfei.dong@mediatek.corp-partner.google.com> Commit-Queue: Chen-Yu Tsai <wenst@chromium.org> Reviewed-by: Yunfei Dong <yunfei.dong@mediatek.corp-partner.google.com> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
* Banshee: Modified for fan off settingridden_liu2022-08-031-3/+3
| | | | | | | | | | | | | | | Modified for fan off setting to 50'C BUG=b:223492897 BRANCH=none TEST=Check that the fan is off when it is below 50'C Signed-off-by: ridden_liu <ridden_liu@compal.corp-partner.google.com> Change-Id: Ib3b17745df128f868f2d194df7e06638d92064c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3789208 Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Boris Mittelberg <bmbm@google.com> Tested-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
* kingler: disable BC1.2 SRC mode for rt1718slschyi2022-08-031-0/+5
| | | | | | | | | | | | | | | | | Write disable I2C packet to the register on rt1718s to disable it advertising the port as BC1.2 SRC. BUG=b:207803082 TEST=Insert BC1.2 sink device to usb port and check the BC12_SRC_FUNC register (0x6D), and the BC12_SRC_EN bit is 0 (not enabled). BRANCH=None Signed-off-by: lschyi <lschyi@google.com> Change-Id: I8520bca0062422709b542dc2805966286cc26973 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3789207 Commit-Queue: Sung-Chi Li <lschyi@chromium.org> Tested-by: Sung-Chi Li <lschyi@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com>
* zephyr: shim: add default to PLATFORM_EC_USB_PIDFabio Baltieri2022-08-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | | All Kconfig symbols are added to the binary with the GEN_ABSOLUTE_SYM_KCONFIG. This is a problem with hex symbols with a default empty value, as they end up defined to "0x", causing an obscure build failure such as: FAILED: zephyr/CMakeFiles/zephyr.dir/misc/generated/configs.c.obj /tmp/cc5ZD1EK.s: Assembler messages: /tmp/cc5ZD1EK.s:1345: Error: missing expression Setting a default for the option so that that would not break the build. BUG=none BRANCH=none TEST=drop the config for a board, build it, no assembler errors Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ib886cafdccf7d7da21b0fe90b03aa40cc55c2715 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3801901 Reviewed-by: Madhu P <mparuchuri@google.com> Reviewed-by: Scott Collyer <scollyer@chromium.org>
View Lorry Controller Status