summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* skyrim: Add rotation parameters for lid accelstabilize-15072.B-mainLeila Lin2022-08-263-2/+47
| | | | | | | | | | | | | | | Lid accel sensor rotate after board ver4. BUG=b:242934665 BRANCH=none TEST=Check the lid accel data is correct. Signed-off-by: Leila Lin <leilacy_lin@compal.corp-partner.google.com> Change-Id: I16e5736634a96c9abd0603e4b32170986e0866e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3841532 Tested-by: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Commit-Queue: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
* pujjo: config keyboard power btn ksi3.jimmy.wu2022-08-261-0/+1
| | | | | | | | | | | | | | Config keyboard power btn ksi3. BUG=b:243742226 TEST=zmake build pujjo BRANCH=none Signed-off-by: jimmy.wu <jimmy.wu@lcfc.corp-partner.google.com> Change-Id: Ib37df3b7b423c84bb6aafc60051fff5f28f2c5d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3855595 Reviewed-by: Andrew McRae <amcrae@google.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* winterhold: change C0 Port PPCLeo-Tsai2022-08-261-26/+7
| | | | | | | | | | | | | | | change C0 Port PPC from AOZ1382 to NX20P3483 BUG=b:239767904 TEST=zmake build winterhold BRANCH=none Signed-off-by: Leo-Tsai <leocx_tsai@compal.corp-partner.google.com> Change-Id: I868286415278600248e270475d666888deeabc67 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3853775 Reviewed-by: Diana Z <dzigterman@chromium.org> Reviewed-by: Isaac Lee <isaaclee@google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
* winterhold: separate zephyr config for winterholdLeo-Tsai2022-08-2611-32/+878
| | | | | | | | | | | | | separate EC Zephyr config for winterhold. BUG=b:240824572,b:243213383 TEST=zmake build winterhold and zmake build skyrim BRANCH=none Signed-off-by: Leo-Tsai <leocx_tsai@compal.corp-partner.google.com> Change-Id: Iedb5fc87a4365d29e4760e07c9bf337b10f69ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3853770 Reviewed-by: Diana Z <dzigterman@chromium.org>
* test: add basic sleeptimeout console command testsParth Malkan2022-08-263-0/+47
| | | | | | | | | | | | | | | | | Test the basic paths for the sleeptimeout command, including: 1. sleeptimeout without params 2. sleeptimeout with valid params 3. sleeptimeout with invalid params BRANCH=none BUG=b:236074223 TEST=./twister -T zephyr/test/drivers/ Signed-off-by: Parth Malkan <parthmalkan@google.com> Change-Id: I8e2acc874131042158f1df48cf7fc749d9abbaf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3857948 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Yuval Peress <peress@google.com>
* osiris: Reduce host low battery shutdown percentage to 3%Yu-An Chen2022-08-261-0/+4
| | | | | | | | | | | | | | | Reduce host low battery shutdown percentage to 3%, default is 4%. BUG=b:237624128 BRANCH=none TEST=make BOARD=osiris Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: I770ecd55be21162972bcac49063465f4bdd9252e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3853301 Reviewed-by: Parth Malkan <parthmalkan@google.com> Reviewed-by: caveh jalali <caveh@chromium.org> Reviewed-by: YH Lin <yueherngl@chromium.org>
* cryptoc: Remove abspath builtin directory workaroundCraig Hesling2022-08-251-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | The original addition of cryptoc, seen crrev.com/c/1731543, adds the absolute path to builtin/ as an include because cryptoc is compiled in a different working directory and needs access to stdlib headers. This is a bit of a workaround, since "builtin/" is already in the include path. Thus, we end up with two references to the "builtin" directory in the include path for all objects being built in EC. This fix isolates this absolute path functionality to only cryptoc and simply changes all existing include paths to absolute. The original CL that introduced cryptoc is crrev.com/c/1731543. BRANCH=none BUG=b:176500425,b:236389226 TEST=make BOARD=hatch_fp print-includes # Ensure that there is only one reference to "builtin/". make BOARD=hatch_fp V=1 build/hatch_fp/cryptoc/libcryptoc.a # Ensure that all includes are absolute and the compilation succeeds. make BOARD=hatch_fp V=1 build/hatch_fp/ec.bin # Ensure that this compiles and shows the relative path being used. Signed-off-by: Craig Hesling <hesling@chromium.org> Change-Id: I51cc4f59bed123f7dea3fecb541522347a3348cf Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3855591 Reviewed-by: Diana Z <dzigterman@chromium.org>
* zephyr: Add tasks test to ec_app testJeremy Bettis2022-08-252-1/+6
| | | | | | | | | | | | | | | | | Enable CONFIG_SHIMMED_TASKS and verify that tasks started. BRANCH=None BUG=None TEST=./twister --clobber -v -i -T zephyr/test/ec_app Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I22d9b3845b9555b63f3ffe39cc4ccdaf8f67558a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3855162 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: Remove skips from ec_app testJeremy Bettis2022-08-251-37/+16
| | | | | | | | | | | | | | | | | With the ztest new api, there is no reason for all these skips. BRANCH=None BUG=None TEST=./twister --clobber -v -i -T zephyr/test/ec_app Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: Id98c69002bafb7e0b6d5e1a544cc3d2e1fea6997 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3855161 Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Tristan Honscheid <honscheid@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org>
* zephyr: Refactor ec_app testJeremy Bettis2022-08-251-3/+8
| | | | | | | | | | | | | | | | | | | | Change the ec_app test to only call ec_app_main once by moving all setup to the suite setup function, then calling ec_app_main, and then running all the tests to verify the post-conditions. BRANCH=None BUG=None TEST=./twister --clobber -v -i -T zephyr/test/ec_app Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: If5480ce003d06a50fe0540795aede01ab95fb755 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3855160 Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> Commit-Queue: Simon Glass <sjg@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
* zephyr: Mock power sequence driverAl Semjonovs2022-08-258-4/+330
| | | | | | | | | | | | | | | Mock power sequence handling BUG=None BRANCH=NONE TEST=./twister -T zephyr/test Signed-off-by: Al Semjonovs <asemjonovs@google.com> Change-Id: I8ec3198abfb069501bed2c5aa661e31f780e2c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3833564 Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: Yuval Peress <peress@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: mock power sequence causes flaky testsAl Semjonovs2022-08-251-2/+9
| | | | | | | | | | | | | | This test becomes flaky when enabling mocked power sequence BUG=None BRANCH=NONE TEST=./twister -T zephyr/test/drivers Signed-off-by: Al Semjonovs <asemjonovs@google.com> Change-Id: If8af05e43d54902df0a9fb112d0f49141b785159 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3857946 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: Add test to cover buffer overflow cprintJeremy Bettis2022-08-251-8/+19
| | | | | | | | | | | | | | | | | | | The coverage runs in the CQ cover 3 lines of code in console.c that are not covered when running the tests locally. Add a test to explicitly cover the case where a cprint{s,f} call is to big to fit in the buffer. BRANCH=None BUG=b:242334829 TEST=./twister --clobber -v -i -T zephyr/test/drivers --coverage Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: Ifedd5f7bf6385bcb9b1f3be0f2ec562791b2c9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3857445 Reviewed-by: Yuval Peress <peress@google.com> Commit-Queue: Yuval Peress <peress@google.com> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: test: Test writing a register in virtual battery over I2C passthruWai-Hong Tam2022-08-251-1/+22
| | | | | | | | | | | | | | | | | | Add a test case to write a register to the virtual battery over I2C passthru. Write the SB_MANUFACTURER_ACCESS register, which is writable only. It simply caches the value and does nothing in the smart battery emulator. Read the data back to verify. BRANCH=None BUG=b:236131904 TEST=./twister -s zephyr/test/drivers/drivers.default Change-Id: Idfa986ec52eeda2ecf823dab27b48b7bdca6b121 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3857447 Commit-Queue: Yuval Peress <peress@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Yuval Peress <peress@google.com>
* doc: Add doc explaining how ITE EC reflashing via Servo works.Matthew Blecker2022-08-252-5/+200
| | | | | | | | | | | BRANCH=none BUG=none TEST=n/a Change-Id: I5e92f72e384854778ce6f0765fb177f7e418a17f Signed-off-by: Matthew Blecker <matthewb@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3855158 Reviewed-by: Keith Haddow <haddowk@chromium.org>
* zephyr: test: Emulate flash write and erase and add the test casesWai-Hong Tam2022-08-252-6/+151
| | | | | | | | | | | | | | | | | | | Implement the flash write and erase functions in the flash emulator. The functions call the underlying flash controller to execute. Add the simple test cases to exercise the flash write and erase, and then readback the data to compare the results. BRANCH=None BUG=b:236075787, b:236075595, b:236075283 TEST=./twister -s zephyr/test/drivers/drivers.default Change-Id: I50cb83c19382362c86a319d0feefa683f6b216bf Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3857443 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
* cryptoc: Make cryptoc include path relativeCraig Hesling2022-08-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | This helps simplify IDE language server configuration generation. This is because the absolute path generated by this line will typically be a chroot specific path, but IDEs typically run outside of the chroot. The other includes are all relative, other than libusb. The original CL that introduced cryptoc is crrev.com/c/1731543. BRANCH=none BUG=b:176500425,b:236389226 TEST=make BOARD=hatch_fp print-includes # Ensure that cryptoc include is relative, like the rest. make BOARD=hatch_fp V=1 build/hatch_fp/ec.bin # Ensure that this compiles and shows the relative path being used. Signed-off-by: Craig Hesling <hesling@chromium.org> Change-Id: I8d6fbabade75e80233b7b76114ed1d46aefa89c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3855590 Reviewed-by: Edward Hill <ecgh@chromium.org>
* test: add tests for battery cutoff host commandYuval Peress2022-08-252-1/+39
| | | | | | | | | | | | | | | | | | | Add tests for the host command by verifying: 1. Version 0 is able to cutoff power 2. Version 0 handles a failure to cutoff power (using i2c error simulation). 3. Version 1 is able to cutoff power 4. Version 1 is able to schedule a power cutoff BRANCH=none BUG=b:236075096 TEST=twister -s zephyr/test/drivers/drivers.host_cmd Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I2bdcd7090a4a025c17c2f8495e628374a3ed479d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3855589 Reviewed-by: Tomasz Michalec <tmichalec@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* tests: move host command tests to separate binaryYuval Peress2022-08-2511-6/+19
| | | | | | | | | | | | | | | | The host command tests seem to have a flake in them where adding the battery cutoff command was breaking other tests. Split them off so they can avoid the issue. BRANCH=none BUG=none TEST=twister -T zephyr/test/drivers Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I8b7f45dc4bbcb0c128a6a2c57d9b34887d97f2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3855588 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* driver/usb_mux: Rename and move `USB_MUX_ALL_CHIPS`Robert Zieba2022-08-252-20/+25
| | | | | | | | | | | | | | | | | This commit moves the `USB_MUX_ALL_CHIPS` define into ec_commands.h and renames it to `TYPEC_USB_MUX_SET_ALL_CHIPS` so that it can be used by external code. BRANCH=none BUG=b:228223774 TEST=Built and ran EC on nipperkin device Change-Id: I9363bb8c80bd949a90dc3e6834c604b7b2244e2d Signed-off-by: Robert Zieba <robertzieba@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3842198 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Diana Z <dzigterman@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* test: Cover battery status on i2c errorYuval Peress2022-08-251-1/+38
| | | | | | | | | | | | | | | Check that the command still works even if there was an I2C error. BRANCH=none BUG=none TEST=twister -s zephyr/test/drivers/drivers.default Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I7298f0ce63e031e63acbf54732118e4b6da56bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3855587 Commit-Queue: Tristan Honscheid <honscheid@google.com> Reviewed-by: Tristan Honscheid <honscheid@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* port80: Add more tests for port 80 handling.Andrew McRae2022-08-251-10/+90
| | | | | | | | | | | | | | | | | | Add tests for: - reset code processing - history array wrap - subcommand check BUG=b:243613249 TEST=./twister -T zephyr/test/drivers BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I4f543bc26b3f6d24c9ef6b81db13b56d5a83fe7e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3855585 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
* test: add tests for the i2c_portmap and check argument numberlschyi2022-08-253-0/+32
| | | | | | | | | | | | | | | | | Add tests for the console command `i2c_portmap`, and also fix the logic if the supplied argument number does not match to the function. BRANCH=none BUG=b:236074892 TEST=twister -T zephyr/test/drivers Signed-off-by: lschyi <lschyi@google.com> Change-Id: I26384d39f12e787e9c7cad63a0da6fbe54443008 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3854304 Commit-Queue: Sung-Chi Li <lschyi@chromium.org> Tested-by: Sung-Chi Li <lschyi@chromium.org> Reviewed-by: Tomasz Michalec <tmichalec@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* charger/rt9490: workaround code cleanupTing Shen2022-08-252-18/+32
| | | | | | | | | | | | | | | | | | Rearrange the workaround code and common init code: Workaround goes to zephyr/project/corsola, and limit its access to Krabby and Tentacruel only. BUG=none TEST=manually check charger works fine on tentacruel BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: Ieb7526f9e8aa36ac8457a6388f427a63ce4a105e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3853777 Reviewed-by: Eric Yilun Lin <yllin@google.com> Tested-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org>
* zephyr: Add tests for failure paths of GPIO set host commandMadhurima Paruchuri2022-08-251-1/+40
| | | | | | | | | | | | | | Add tests for the EC_CMD_GPIO_SET host command covering few failing paths BUG=b:236131899 BRANCH=none TEST=./twister -s zephyr/test/drivers/drivers.default -c Signed-off-by: Madhurima Paruchuri <mparuchuri@google.com> Change-Id: I0716675e4e43caee67ccfba9155ed9a1e8da6e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3849666 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* Pazquel360: Setup volume buttons for pazquel360 onlyTang Qijun2022-08-253-5/+24
| | | | | | | | | | | | | | Pazquel/pazquel360 share the same firmware, setup volume buttons for pazquel360 only. BUG=b:239599467 BRANCH=trogdor TEST=emerge-trogdor chromeos-ec & ectool mkbpget buttons on pazquel360 Signed-off-by: Tang Qijun <qijun.tang@ecs.corp-partner.google.com> Change-Id: I996b38b46bdc1e4a7cbc7257e72a42671d61d7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3853302 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* zephyr: test: add dps test casesEric Yilun Lin2022-08-258-9/+112
| | | | | | | | | | | | | | | | | Setup DPS test environment and add test cases for config and enablement. BUG=b:243105887 TEST=./twister -T zephyr/test/drivers/ --sub-test drivers.dps BRANCH=none Change-Id: I33d5a0c11ff58296c0faa953775220034fb13d92 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3841536 Commit-Queue: Eric Yilun Lin <yllin@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Yuval Peress <peress@google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* TCPMv2: correct Revision data handlingScott Chao2022-08-251-9/+9
| | | | | | | | | | | | | | | | | | | We should use uint to handle the incoming data. This change will avoid RMDO be negative value and result in EC always ignore power_state_chanage in PD_CTRL_GET_STATUS. BUG=b:242021185 BRANCH=none TEST=EC will return 7 bytes when get GET_STATUS ctrl command TEST=make buildall Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: Ie0a95972dc6090b844e0783d41e5ecae8c786226 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3837713 Reviewed-by: caveh jalali <caveh@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Jameson Thies <jthies@google.com> Commit-Queue: caveh jalali <caveh@chromium.org>
* pujjo: modify charge and power led control by gpio from pwmarthur.lin2022-08-255-71/+83
| | | | | | | | | | | | | | | | | | | | Modify charge and power led control by gpio from pwm. Modify led behavior to meet pujjo ux spec. BUG=b:242477978 BRANCH=none TEST=zmake build pujjo TEST= ectool led power off TEST= ectool led power white TEST= ectool led battery off TEST= ectool led battery red TEST= ectool led battery amber TEST= ectool led battery green Signed-off-by: arthur.lin <arthur.lin@lcfc.corp-partner.google.com> Change-Id: Ib3752fa3447c88c9ff10d4adc442941b072dfbb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3854303 Reviewed-by: Andrew McRae <amcrae@google.com>
* nissa: Disable port80 code loggingAndrew McRae2022-08-251-0/+1
| | | | | | | | | | | | | Disable port80 code logging. BUG=b:243607643 TEST=zmake build nereid; flash & run BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I73cd6567cb750fefdc5320b7f2e1d77836fa6c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3853309 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* port80: Add a config to avoid logging port80 codesAndrew McRae2022-08-253-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | Add a config item to disable logging all of the port80 history buffer as each code is received. Individual codes can still be logged as they are received when enabled via the console command 'port80 intprint' or using the CONFIG_PORT80_PRINT_IN_INT config item. This reduces the overhead at AP startup on the logging. It has been observed on the ITE81302 that logging the port80 codes causes significant overhead that may lead to watchdog timeouts. The port80 code history is still available via the 'port80' EC console command. BUG=b:243607643 TEST=zmake build nereid; flash & run BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I543b0391bcf474c9d040baa98ff75f6e2b9fd5a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3853308 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* emul: Correct func docs using i2c_common_emul_dataAaron Massey2022-08-2513-24/+40
| | | | | | | | | | | | | | | | | | | | When migrating to the new emulator API there were many functions replaced with ones that either required an i2c_common_emul_data pointer argument or returned one. However, the docstrings for some of these functions never got updated during the migration. Update the function docstrings to accurately describe what they actually do. BRANCH=none BUG=b:243179523 TEST=Examined header files containing "i2c_common_emul_data" TEST=./twister --clobber -T zephyr/test Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I0e67d6f64ff4b5e079c950b895a4a06b9ea092d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3843104 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* zephyr: test: Add a new vboot_hash test to hash arbitrary sizeWai-Hong Tam2022-08-251-0/+23
| | | | | | | | | | | | | | Add a new test to hash arbitrary size. It hits more coverage. BRANCH=None BUG=b:236161107 TEST=./twister -s zephyr/test/drivers/drivers.default Change-Id: Iad34de0d5969c72f130dff401b0b7bf4dc1c6fce Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3854313 Reviewed-by: Aaron Massey <aaronmassey@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: test: Choose the "cros,flash" nodeWai-Hong Tam2022-08-251-0/+7
| | | | | | | | | | | | | | | | | The flash size is retrieved from the "cros,flash" node. Originally it was 0 as the "cros,flash" node hasn't been chosen. This CL chooses the node and define its attributes. It enables more coverage as the flash size is no longer 0. BRANCH=None BUG=b:236075281 TEST=./twister -s zephyr/test/drivers/drivers.default Change-Id: Ifdfc3b03e45d3468b73c02a3496b913236f03a93 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3854312 Reviewed-by: Tristan Honscheid <honscheid@google.com>
* zephyr: test: Add flash protect host command test casesWai-Hong Tam2022-08-252-0/+158
| | | | | | | | | | | | | | | | Use GPIO emulator to change the WP_L assertion state and verify the flash protection sequence, e.g. enable/disable RO protection, enable/disable ALL protection. BRANCH=None BUG=b:236075598 TEST=./twister -s zephyr/test/drivers/drivers.default Change-Id: If287b3d302278fc9f3ccf9be287179435473721b Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3854311 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* vell: Update fan table version 5Devin Lu2022-08-251-8/+8
| | | | | | | | | | | | | BUG=b:216026302 BRANCH=none TEST=Thermal team verified thermal policy is expected. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: Ib04d4fed5f0976ee18d831f54913dfaff9921c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3853304 Tested-by: Devin Lu <devin.lu@quantatw.com> Commit-Queue: Devin Lu <devin.lu@quantatw.com> Reviewed-by: caveh jalali <caveh@chromium.org>
* port80: Add port 80 unit testsAndrew McRae2022-08-254-0/+160
| | | | | | | | | | | | | | | Add port 80 writes Zephyr unit tests. BUG=b:243613249 TEST=./twister -T zephyr/test/drivers BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I1a532f825454a8156b4aff7ac81913a93c0ba66d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3853772 Reviewed-by: Aaron Massey <aaronmassey@google.com> Commit-Queue: Aaron Massey <aaronmassey@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* rex: Make SOC_PWROK/SYS_PWROK signals TTL instead of ODScott Collyer2022-08-241-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | Both SOC_PWROK and SYS_PWROK signals are designed to be TTL outputs, but they were being configured as open drain outputs in their power signals node. In addition, this CL adds an internal pullup to SEQ_EC_ALL_SYS_PG as a work-around for the missing pullup on the board. Lastly, for the gpio flags field, 0 was replaces with GPIO_ACTIVE_HIGH for readability. BRANCH=none BUG=b:243638916 TEST=zmake build rex Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: Ifd7f88b863d5468fbcfa979d23b0071f429903d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3855156 Tested-by: Scott Collyer <scollyer@chromium.org> Commit-Queue: Scott Collyer <scollyer@chromium.org> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
* zephyr: emul: Implement flash protectionWai-Hong Tam2022-08-242-7/+72
| | | | | | | | | | | | | Implement a simple flash protection for RO and ALL. BRANCH=None BUG=b:236075598 TEST=The following CL tests the functions. Change-Id: I0eec87d7ebbf776a676103ae26df5460d3685431 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3854310 Reviewed-by: Yuval Peress <peress@google.com>
* Zephyr test: Add EC_CMD_PD_CONTROL testDiana Z2022-08-245-1/+135
| | | | | | | | | | | | | | | Add a test for EC_CMD_PD_CONTROL, which is an integral part of the TCPC update process from the AP. BRANCH=None BUG=b:243188273 TEST=./twister -T ./zephyr/test Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I8ab69c46b25d4493dfb1916f11be4ba694fe7fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3852563 Reviewed-by: Aaron Massey <aaronmassey@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* Test: Add test hooks for PD_CONTROLDiana Z2022-08-242-1/+19
| | | | | | | | | | | | | | | | | One of the PD_CONTROL sub-commands irreversibly blocks future commands from running on a system. For the purposes of unit test stability, create a test hook which can be used to clear this state. Otherwise, a test execution order dependency would be created. BRANCH=None BUG=b:243188273 TEST=./twister -T ./zephyr/test Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Ic0aacec6717e4f54dcb7f11d55fa36505fe208a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3852562 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Aaron Massey <aaronmassey@google.com>
* checkpatch: Ignore ENOSYS referencesAndrew McRae2022-08-241-0/+3
| | | | | | | | | | | | | | | Tell checkpatch to not warn on ENOSYS references. ENOSYS is used extensively in Zephyr to indicate an unsupported API function. BUG=none TEST=twister -T zephyr/test BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I14d08b4c08e3ad4458073dcfa7396615246ac550 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3853310 Reviewed-by: Keith Short <keithshort@chromium.org>
* crota: allow PROCHOT when unplugging AC adapterPeter Chi2022-08-241-0/+1
| | | | | | | | | | | | BUG=b:243609867 BRANCH=none TEST=make -j BOARD=crota Signed-off-by: Peter Chi <peter_chi@wistron.corp-partner.google.com> Change-Id: I645b5ec72b2ede9c57696be2c19c1354aac3baea Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3841542 Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* cq: Save the html report for herobrine coverageJeremy Bettis2022-08-241-1/+20
| | | | | | | | | | | | | | | | | In addition to the all boards html coverage report, also include the herobrine html in the build artifacts. BRANCH=None BUG=None TEST=Did build, looked in artifacts dir Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: Ida81797963cb1db700f7de5b4fb43acdcca490a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3854555 Reviewed-by: Yuval Peress <peress@google.com> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Yuval Peress <peress@google.com> Tested-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: test: Add tcpci_hard_reset_reinit testDevin Lu2022-08-243-0/+38
| | | | | | | | | | | | | | | | | Add coverage for tcpci_hard_reset_reinit. BUG=b:239183823 BRANCH=none TEST=twister -T zephyr/test/drivers Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: Ibc61086f7531654a2d400fa9554141538f5166ec Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3837606 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Tested-by: Devin Lu <devin.lu@quantatw.com> Commit-Queue: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* test: verify battery cut off host command v0 worksYuval Peress2022-08-243-0/+73
| | | | | | | | | | | | | | | Check both paths of the battery cut off host command (v0) by emulating an I2C failure when writing sb (address 0). BRANCH=none BUG=b:236075096 TEST=twister -s zephyr/test/drivers/drivers.default Signed-off-by: Yuval Peress <peress@google.com> Change-Id: Id50a8dc29f6f1c336287c1ae85244ef333ec623b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3853763 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr test: Add test for EC_CMD_HOST_EVENT_SET_SCI_MASKKeith Short2022-08-241-0/+44
| | | | | | | | | | | | | | Add a test for the success path of EC_CMD_HOST_EVENT_SET_SCI_MASK. BUG=b:236161287 BRANCH=none TEST=./twister -T zephyr/test/drivers/ -s drivers.default Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I9cbce646c69d16a6f234dcedd58162b948b1a6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3846278 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr test: Add test for EC_CMD_HOST_EVENT_GET_SCI_MASKKeith Short2022-08-241-0/+28
| | | | | | | | | | | | | | Add a test for the success path of EC_CMD_HOST_EVENT_GET_SCI_MASK. BUG=b:236161212 BRANCH=none TEST=./twister -T zephyr/test/drivers/ -s drivers.default Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: If77cb618239fae87e9e00f091ba25c64eb4b519b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3846277 Reviewed-by: Yuval Peress <peress@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr test: Add test for EC_CMD_HOST_EVENT_GET_BKeith Short2022-08-241-0/+27
| | | | | | | | | | | | | | Add a test for the success path of EC_CMD_HOST_EVENT_GET_B. BUG=b:236161247 BRANCH=none TEST=./twister -T zephyr/test/drivers/ -s drivers.default Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I18c56b19c34c67f3dfb3f40fdc4299a8eee3ee1b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3846276 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Tristan Honscheid <honscheid@google.com>
* zephyr test: Add test for EC_CMD_HOST_EVENT_SET_SMI_MASKKeith Short2022-08-241-4/+48
| | | | | | | | | | | | | | Add a test for the success path of EC_CMD_HOST_EVENT_SET_SMI_MASK. BUG=b:236161113 BRANCH=none TEST=./twister -T zephyr/test/drivers/ -s drivers.default Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I40fbd8c0d341a0b0484d733d75bfa32d7ea769d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3846275 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
View Lorry Controller Status