summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* gitlab: Only run CI in main and coverage branchesstabilize-15083.B-mainJeremy Bettis2022-09-081-0/+5
| | | | | | | | | | | | | | | | | | | | | | This workflow rule will prevent this CI config from running unless the branch name is "main" or "coverage". It will have to be cherry-picked into all the other branches to make them stop running sadly. BRANCH=None BUG=b:244766499 TEST=Used yaml validator at https://gitlab.com/zephyr-ec/ec/-/ci/editor?branch_name=main&tab=2 Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I536de3e3fdbca1c48505e61de5737f865bd0e233 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3872545 Reviewed-by: Simon Glass <sjg@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Simon Glass <sjg@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> (cherry picked from commit 15612bc4af40cb2a824ff2590508df29f27fbf56) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3883771
* zephyr: test: Add the flash info host command testWai-Hong Tam2022-08-301-0/+28
| | | | | | | | | | | | | | | Add the test for the flash info host command. BRANCH=None BUG=b:236075281 TEST=./twister -s zephyr/test/drivers/drivers.default Change-Id: I6534ae8fffda0b895e541f97ef1be0c5b11b865a Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3866424 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Yuval Peress <peress@google.com> Reviewed-by: Yuval Peress <peress@google.com>
* docs/ide-support.md: Add Makefile.ide to odd file typesAndrea Grandi2022-08-301-0/+1
| | | | | | | | | | | | BUG=b:236389226,b:176500425 TEST=none BRANCH=none Signed-off-by: Andrea Grandi <agrandi@google.com> Change-Id: Id299114099cb0e26c26de547287ee90618294ae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3861290 Reviewed-by: Bobby Casey <bobbycasey@google.com> Reviewed-by: Craig Hesling <hesling@chromium.org>
* Prism: Remove const keyword from rgbkbd_type variableParth Malkan2022-08-302-2/+2
| | | | | | | | | | | | | | Rgbkbd_type could be set at runtime, remove const. BUG=b:242259557 BRANCH=none TEST=None Cq-Depend: chromium:3864981, chromium:3861817, chromium:3866411 Signed-off-by: Parth Malkan <parthmalkan@google.com> Change-Id: I92bd1e326d20b272afe5bede850f6bb090e86c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3864982 Reviewed-by: YH Lin <yueherngl@chromium.org>
* Osiris: Remove const keyword from rgbkbd_type variableParth Malkan2022-08-301-1/+1
| | | | | | | | | | | | | | Rgbkbd_type could be set at runtime, remove const. BUG=b:242259557 BRANCH=none TEST=None Cq-Depend: chromium:3864982, chromium:3861817, chromium:3866411 Signed-off-by: Parth Malkan <parthmalkan@google.com> Change-Id: I63e7f034aeb3ca31cbe293e5d2c4defd8c21176e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3864981 Reviewed-by: YH Lin <yueherngl@chromium.org>
* Mithrax : Modify RGBKBD config for non-gaming SKU.Logan_Liao2022-08-303-6/+9
| | | | | | | | | | | | | | | | | | | | This patch modify RGB_type setting to distinguish gaming and non-gaming SKU. BUG=b:242259557 BRANCH=none TEST=test Mithrax without RGB keyboard that return EC_RGBKBD_TYPE_UNKNOWN. Cq-Depend: chromium:3864981, chromium:3864982, chromium:3866411 Change-Id: I3f6485319d36b2ef619d597ea75dc074838b7562 Signed-off-by: Logan_Liao <logan_Liao@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3861817 Reviewed-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Reviewed-by: YH Lin <yueherngl@chromium.org> Reviewed-by: Parth Malkan <parthmalkan@google.com> Commit-Queue: Parth Malkan <parthmalkan@google.com> Tested-by: Parth Malkan <parthmalkan@google.com> Reviewed-by: Ko Ko <ko_ko@compal.corp-partner.google.com>
* taniks: Remove const keyword from rgbkbd_type variableParth Malkan2022-08-301-1/+1
| | | | | | | | | | | | | | Rgbkbd_type could be set at runtime, remove const. BUG=b:242259557 BRANCH=none TEST=None Cq-Depend: chromium:3864982, chromium:3861817, chromium:3864981 Signed-off-by: Parth Malkan <parthmalkan@google.com> Change-Id: Ie0088fabe6837608c10315c58ad40643c12b7627 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3866411 Reviewed-by: YH Lin <yueherngl@chromium.org>
* util/flash_ec: Fix shellcheck warningsTom Hughes2022-08-301-11/+11
| | | | | | | | | | | | | | | | | | ${STM32MON_COMMAND} "${IMG}" \ ^-----------------^ SC2086: Double quote to prevent globbing and word splitting. Convert the variable to an array to split on spaces correctly: https://github.com/koalaman/shellcheck/wiki/Sc2086#exceptions. BRANCH=none BUG=b:242127759 TEST= ./util/flash_ec --board=dartmonkey Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Ia5c277cf090aa773b58403cef8a99c5cf974804d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3858400 Reviewed-by: Bobby Casey <bobbycasey@google.com>
* util/flash_ec: Fix shellcheck warningsTom Hughes2022-08-301-10/+10
| | | | | | | | | | | | | | | dev_cnt=$(lsusb -d ${DFU_DEVICE} | wc -l) ^-----------^ SC2248: Prefer double quoting even when variables don't contain special characters. BRANCH=none BUG=b:242127759 TEST=./util/flash_ec --board=dartmonkey Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Ie299348fc4aa94db2c6060c38c27fadb52525389 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3860075 Reviewed-by: Bobby Casey <bobbycasey@google.com>
* util/flash_ec: Fix shellcheck warningsTom Hughes2022-08-301-35/+35
| | | | | | | | | | | | | | | | SCRIPT_DIR="$(dirname "$SCRIPT")" ^-----^ SC2250: Prefer putting braces around variable references even when not strictly required. BRANCH=none BUG=b:242127759 TEST=./util/flash_ec --board=dartmonkey Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I95384821f047bb0599997be64843b90d55c297bd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3860074 Reviewed-by: Bobby Casey <bobbycasey@google.com>
* rex: Fix the gpio pin type for ec_edp_bl_enScott Collyer2022-08-301-1/+1
| | | | | | | | | | | | | | | | | | | | | The gpio device tree node for ec_edp_bl_en was being configured as an open-drain signal, but this should be a TTL with low as its initial state. This CL corrects this error. The GPIO spreadsheet that's being used as an input for pinmap needs to be updated. This CL provides a fix to enable the display panel to work until the tool that creates the input for pinmap is updated. BRANCH=none BUG=b:243919230 TEST=zmake build rex Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: I4f8db1e150572df58c1a97d1f509a556383eb0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3863925 Reviewed-by: Madhu P <mparuchuri@google.com> Reviewed-by: Subrata Banik <subratabanik@chromium.org> Commit-Queue: Scott Collyer <scollyer@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org>
* brya: Set fan PWM frequency to 25 KHzCaveh Jalali2022-08-301-2/+2
| | | | | | | | | | | | | | | | The brya fan spec calls for the PWM frequency to be 25 KHz. Many brya variants already use 25 KHz as this is a common PWM frequency for fans. BRANCH=none BUG=none TEST=changed fan speed with "fanduty" and confirmed resulting speed with "faninfo" and physically. Change-Id: I26d5d7fa044f1de6a7c1781abe2eadc20e72a413 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3833561 Reviewed-by: Boris Mittelberg <bmbm@google.com> Commit-Queue: Boris Mittelberg <bmbm@google.com>
* zephyr: Add `pe` and `pdcable` console command testsAl Semjonovs2022-08-301-0/+80
| | | | | | | | | | | | | | Added tests for `pe` and `pdcable` console commands BUG=b:236074967, b:236074968 BRANCH=NONE TEST=./twister -T zephyr/test Signed-off-by: Al Semjonovs <asemjonovs@google.com> Change-Id: Ie7e7ea367b12f7fc3eaa47fae9c04861ad902af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3863127 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* test: Add test for get_ikm succeedFiras Sammoura2022-08-301-0/+33
| | | | | | | | | | | | | | | Add test for get_ikm succeeds when the tmp seed is set and the rollback can successfully get the secret. BRANCH=None BUG=b:242720240 TEST=make run-fpsensor_crypto TEST=make runhosttests Signed-off-by: Firas Sammoura <fsammoura@google.com> Change-Id: I14d0887aa2ecafe4565141a89ad5fb43317cc1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3863124 Reviewed-by: Bobby Casey <bobbycasey@google.com>
* test: Add test for get ikm failure with when secret failFiras Sammoura2022-08-301-0/+23
| | | | | | | | | | | | | | | Add a test for get_ikm when the tmp seed is set and the rollback_get_secret is failing. BRANCH=None BUG=b:242720240 TEST=make run-fpsensor_crypto TEST=make runhosttests Signed-off-by: Firas Sammoura <fsammoura@google.com> Change-Id: Ida1f40943eb5fa7795a658a1c8a318036f164d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3861202 Reviewed-by: Bobby Casey <bobbycasey@google.com>
* test: Add test for get ikm failure when seed not setFiras Sammoura2022-08-302-2/+13
| | | | | | | | | | | | | | | | | | Add a test for get_ikm when the fp tpm seed is not set. Change the declaration of get_ikm function inside fpsensor_crypto.c to test_export_static such that it can be visible in the test library. Declare get_ikm as an extern function inside the test/fpsensor_crypto.c file. BRANCH=None BUG=b:242720240 TEST=make run-fpsensor_crypto TEST=make runhosttests Signed-off-by: Firas Sammoura <fsammoura@google.com> Change-Id: Ibd4993bbeb6e8d166b3d0307fd1b3c90c55cc264 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3862148 Reviewed-by: Bobby Casey <bobbycasey@google.com>
* test: Add test for fpsensor trivial key failureBobby Casey2022-08-306-2/+188
| | | | | | | | | | | | | | | | | | | Add a test for derive_positive_match_secret when compute_hmac_sha256 returns a trivial key (either 0x00 or 0xFF). This required mocking compute_hmac_sha256 to get the proper test behavior. Since other tests depend upon a proper SHA256 hash to be generated, either all key/message combinations would need to be mocked or some calls to compute_hmac_sha256 need to be passed through to hmac_SHA256. The latter option was chosen for the best flexibility moving forward. BRANCH=none BUG=b:242720910 TEST=make runhosttests Signed-off-by: Bobby Casey <bobbycasey@google.com> Change-Id: I959e23cfadb5460e62af90ffba74a0cd3b9d9a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3838935 Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* fpsensor_crypto: Abstract calls to hmac_SHA256Bobby Casey2022-08-301-4/+10
| | | | | | | | | | | | | | | For testing purposes it is desirable to have a single location where all calls to hmac_SHA256 are called. Doing so makes mocking or replacing calls much easier. BRANCH=none BUG=b:242720910 TEST=make run-fpsensor_crypto Signed-off-by: Bobby Casey <bobbycasey@google.com> Change-Id: Icc158b3e895da11d072c65a19a36f3e1b29bca14 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3838934 Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* zephyr: rex: enable CONFIG_PLATFORM_EC_SWITCHSubrata Banik2022-08-301-1/+1
| | | | | | | | | | | | | | | | | | | Fixed the following error message from AP console: error, assuming lid is always close and triggered shutdown request. BUG=b:243920003 TEST=No shutdown request has triggered while booting AP at depthcharge. Signed-off-by: Subrata Banik <subratabanik@google.com> Change-Id: I60e56912f030f6f0e3cb49282bbffc920fb389e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3864607 Reviewed-by: Ivy Jian <ivy.jian@quanta.corp-partner.google.com> Tested-by: Subrata Banik <subratabanik@chromium.org> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Commit-Queue: Subrata Banik <subratabanik@chromium.org> Reviewed-by: Kapil Porwal <kapilporwal@chromium.org> Reviewed-by: Madhu P <mparuchuri@google.com>
* driver/bmi323: Update calibration codeLeo Huang2022-08-302-228/+43
| | | | | | | | | | | | | | | | First upload of code from Bosh to simplify IMU calibration. BUG=b:240404661 TEST=in progress BRANCH=None Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Change-Id: I20c479e7ad54ce6054ecf43e0655e7a9314d6879 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3807165 Reviewed-by: HUANG Leo <leo.huang@bosch.corp-partner.google.com> Tested-by: Mike Lee <mike5@huaqin.corp-partner.google.com> Commit-Queue: Knox Chiou <knoxchiou@chromium.org> Tested-by: HUANG Leo <leo.huang@bosch.corp-partner.google.com>
* rex: Enable lid backlightMadhurima Paruchuri2022-08-301-1/+1
| | | | | | | | | | | | BRANCH=none BUG=b:243919230 TEST=zmake build rex --clobber Signed-off-by: Madhurima Paruchuri <mparuchuri@google.com> Change-Id: Ie5c360fb21564c876d9a20bce1db9fc833b8435b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3864609 Reviewed-by: Subrata Banik <subratabanik@chromium.org> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* usbc: Set VDM_SETUP_DONE on DR Swap fail due to PD 2.0B R, Harsha2022-08-301-0/+1
| | | | | | | | | | | | | | | | | | In USB PD 2.0, set VDM_SETUP_DONE flag after marking identity discovery as fail and notify kernel to avoid repeated host event generation which blocks system from entering s0ix. BUG=b:243906438 TEST=Hotplug PD 2.0 charger to DUT and check if kernel receives the corresponding notification. Check if system enters s0ix. BRANCH=none Signed-off-by: B R, Harsha <harsha.b.r@intel.com> Change-Id: I8cdd814e2c6bad4e63141bd77e2a8cd224cc688f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3858970 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com>
* dts-battery: Expand descriptions to explain useAndrew McRae2022-08-301-2/+8
| | | | | | | | | | | | | | Expand the manuf_name and device_name so that it is clear what their use and origin is for. BUG=none TEST=zmake build nissa BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I8defd0cd02eff15f4924866ca9268cad264819b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3864747 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* Xivu: Battery cut off failridden_liu2022-08-301-2/+2
| | | | | | | | | | | | | | | | Battery cut off fail. Modify manufacturerName and devicename can fix it. BUG=b:244129838 BRANCH=Xivu TEST=zmake build xivu.Xivu battery cutoff success. Signed-off-by: ridden_liu <ridden_liu@compal.corp-partner.google.com> Change-Id: I4bb9a1f5133b8849bc997a16ac01b44d8a91e17d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3864744 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Reviewed-by: SamSP Liu <samsp_liu2@compal.corp-partner.google.com> Reviewed-by: Andrew McRae <amcrae@google.com>
* tentacruel : Dynamic charging current control.jeffrey2022-08-304-1/+137
| | | | | | | | | | | | | | | | | | | | | | 1. Limit Charging Current by RT9490 thermistor. 2. Control with one minute average temperature. 3. If temperature over or under 55C and keep 5s, Charging Current will change to next level. 4. Limit Charging Current table : 3600/3000/2400/1800 BUG=b:242267801 TEST=zmake build tentacruel --clobber Use ectool temps all to check charger temperature. BRANCH=None Signed-off-by: jeffrey <jeffrey_lin@pegatron.corp-partner.google.com> Change-Id: Ib0f17e6798d36a93d571bd60d33af767ccbd2f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3840995 Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Jeffrey Lin <jeffrey_lin@pegatron.corp-partner.google.com> Tested-by: Jeffrey Lin <jeffrey_lin@pegatron.corp-partner.google.com> Reviewed-by: Jeffrey Lin <jeffrey_lin@pegatron.corp-partner.google.com>
* charger/rt9490: fix incorrect unit in ADC measurementTing Shen2022-08-301-3/+3
| | | | | | | | | | | | | | | The units returned from charger is mV/mA, no need to multiply 1000. BUG=none TEST=manually checked datasheet BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: Icdb56294b6508f684a3d0eebeeadf786f5ef2086 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3744039 Commit-Queue: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com> Tested-by: Ting Shen <phoenixshen@chromium.org>
* corsola: remove unused filesTing Shen2022-08-302-91/+0
| | | | | | | | | | | | | | | | | regulator.c: totally unused krabby/battery.c: migrated to device tree BUG=none TEST=zmake build {krabby,kingler} BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: Ia0c3c341447a68263e19f26c6e425a759c8d4768 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3860657 Commit-Queue: Eric Yilun Lin <yllin@google.com> Reviewed-by: Eric Yilun Lin <yllin@google.com> Tested-by: Ting Shen <phoenixshen@chromium.org> Auto-Submit: Ting Shen <phoenixshen@chromium.org>
* zephyr: Add test for Corsola db detectionwen zhang2022-08-307-1/+311
| | | | | | | | | | | | | | Add test for Corsola db detection in Kingler board. BUG=b:243423485 TEST=./twister --coverage -v -i -T zephyr/test/kingler BRANCH=none Change-Id: Ib91a1f5bed6c55fd00a8ba9c4b464a8dfcf457fe Signed-off-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3858962 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* winterhold: Modify LED behaviorLeila Lin2022-08-301-17/+17
| | | | | | | | | | | | | | | | | | | | | | | | | Modify LED behavior for winterhold AC mode: Full charged: off Charging: white DC mode: S0-S5: off Battery low(S0/S3): amber Battery low(S5): off Battery erroe(S0-S5): blinking Amber, 1 sec on/1 sec off BUG=b:240003377 BRANCH=none TEST=zmake build winterhold Signed-off-by: Leila Lin <leilacy_lin@compal.corp-partner.google.com> Change-Id: Ia359d90cc8dff8b025e0195be879ff3110d4ad7a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3858968 Tested-by: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com>
* [test] Exclude *fpsensor* from Zephyr migrate hookBobby Casey2022-08-301-1/+1
| | | | | | | | | | | | | | | | | | | | | Files from common/mock/fpsensor_* and include/mock/fpsensor_* were still getting caught in the precommit hook. I initially considered adding these paths to the exclusion list but it seemed to make more sense to just exclude everything with fpsensor in the name, as FPMCU presently does not support Zephyr. BRANCH=none BUG=none TEST=util/migrated_files.sh common/mock/fpsensor_state_mock.c successfully ignores the file TEST=util/migrated_files.sh common/mock/somethingelse.c successfully reports warning Signed-off-by: Bobby Casey <bobbycasey@google.com> Change-Id: I40a87c2e44a1feeec9eae43046fcbf6978190356 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3838933 Reviewed-by: Tom Hughes <tomhughes@chromium.org> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: Use DT_STRING_UPPER_TOKEN_BY_IDXTristan Honscheid2022-08-291-4/+2
| | | | | | | | | | | | | | | | Use the new DT_STRING_UPPER_TOKEN_BY_IDX() macro to create the enum of i2c ports in i2c.h. This replaces a homegrown DT macro that no longer works and is blocking downstreaming BUG=None BRANCH=NOne TEST=./twister; zmake build herobrine Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: Ib9fcea829e5e11b079bcec05d253fba52ab6915c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3864143 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* crota: modify custom fan controlPeter Chi2022-08-292-43/+51
| | | | | | | | | | | | | | | | | Sensor DDR also is a fan on/off switch: - temperature > 38°C = on - temperature < 37°C = off Record actual and target RPM every 2 minutes. BUG=b:243100667 BRANCH=none TEST=make -j BOARD=crota Signed-off-by: Peter Chi <peter_chi@wistron.corp-partner.google.com> Change-Id: I069512cf68639e597351f2bf6877d95f45094c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3826595 Reviewed-by: caveh jalali <caveh@chromium.org>
* npcx_evb: Disable TBT/USB4Abe Levkoy2022-08-292-0/+8
| | | | | | | | | | | | | | npcx_evb boards do not support TBT or USB4. Disable these configs. BUG=b:244218024 TEST=zmake build npcx7 npcx9 BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I88695fa06689c622553269f5609c05f725025e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3863290 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* it8xxx2_evb: Disable USB4/TBTAbe Levkoy2022-08-291-0/+4
| | | | | | | | | | | | | | it8xxx2_evb does not support TBT or USB4. Disable these configs. BUG=b:244218024 TEST=zmake build it8xxx2_evb BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I2e354741844af64edca79e65ca7507de6aa0a9ae Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3863289 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* lazor: Disable TBT/USB4Abe Levkoy2022-08-291-0/+2
| | | | | | | | | | | | | | | lazor does not support TBT or USB4. Disable the configs for these features. BUG=b:244218024 TEST=zmake build lazor BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: Ia3774b5f9c0938b23d6d16c70a81bc19b524334c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3863288 Commit-Queue: Wai-Hong Tam <waihong@google.com> Reviewed-by: Wai-Hong Tam <waihong@google.com>
* herobrine: Disable TBT/USB4Abe Levkoy2022-08-291-0/+2
| | | | | | | | | | | | | | herobrine does not support TBT or USB4. Disable these configs. BUG=b:244218024 TEST=zmake build -c herobrine BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I6d4f7eaeb5aaa082e8ac9a1c54889da99d6fe502 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3863287 Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Wai-Hong Tam <waihong@google.com>
* zephyr: test: Add the flash region info host command testsWai-Hong Tam2022-08-291-0/+63
| | | | | | | | | | | | | | | Add the tests for the flash region info host command. BRANCH=None BUG=b:236075788 TEST=./twister -s zephyr/test/drivers/drivers.default Change-Id: I4b86d101a8e5af8e424fc188e1b2996968d43f3a Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3858038 Reviewed-by: Yuval Peress <peress@google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* drawcia_riscv: Disable CMD_ACCELS to reduce flash sizeCaveh Jalali2022-08-291-0/+3
| | | | | | | | | | | | BRANCH=none BUG=none TEST=buildall passes Change-Id: I7c4c32d933a2d16c9dd219db73ceedf4b65edd6a Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3860647 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Reviewed-by: Boris Mittelberg <bmbm@google.com>
* TCPMv2: Release TCPC driver on port suspend requestCaveh Jalali2022-08-291-0/+1
| | | | | | | | | | | | | | | | | | | | | We need to release the TCPC driver from the TCPC when we want to suspend all operations on the TCPC. In practice, this means we disable ALERTs on the TCPC so the driver is not invoked. We introduced this functionality in TCPMv1 but it never made it to TCPMv2, so add it to TCPMv2. BUG=b:240458902 BRANCH=none TEST="pd 2 suspend ; pd 2 resume" no longer stops port 0 due to interrupt storm. /sys/class/typec shows devices are enumerated on resume. Change-Id: If6cc99a7a3392fd1ddfdf795074bc9f406b2555e Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3859101 Reviewed-by: Poornima Tom <poornima.tom@intel.corp-partner.google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Reviewed-by: Boris Mittelberg <bmbm@google.com>
* tcpm/nct38xx: Fix typo in commentCaveh Jalali2022-08-291-3/+3
| | | | | | | | | | | | | | This fixes a typo in a comment. BUG=none BRANCH=none TEST=buildall passes Change-Id: Id9370e09e32a7d9cb2ed06899a4341ef96d4ac95 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3859100 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Boris Mittelberg <bmbm@google.com>
* skyrim: Re-enable `crash` console commandRobert Zieba2022-08-291-1/+0
| | | | | | | | | | | | | | | This commit re-enables the `crash` console command. This command is required for the `firmware_ECSharedMem` FAFT test. BRANCH=none BUG=b:209512212 TEST=Verified that `crash` command works again Signed-off-by: Robert Zieba <robertzieba@google.com> Change-Id: Id331f0f2ce932dc73b633661f6ec75a7b0f51ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3862844 Commit-Queue: Diana Z <dzigterman@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* ec: Add util to sort lcov output by uncoveredJeremy Bettis2022-08-291-0/+59
| | | | | | | | | | | | | | | | | | | | | Add new utility script to sort lcov output by uncovered lines of code. When looking for an easy win, it is usually to look for files with a lot of uncovered lines, rather than a low coverage percentage. BRANCH=None BUG=None TEST=Ran it. Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I9da9a54c22176bdaa06bad1eb394f8c09bed7c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3858581 Commit-Queue: Al Semjonovs <asemjonovs@google.com> Commit-Queue: Yuval Peress <peress@google.com> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Al Semjonovs <asemjonovs@google.com> Tested-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Yuval Peress <peress@google.com> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
* rex: Add support for MKBP eventsScott Collyer2022-08-291-0/+5
| | | | | | | | | | | | | | | | This CL adds the required MKBP config options to support MKBP events BRANCH=none BUG=b:243921710 TEST=zmake build rex Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: Ie3dc0b3ceceb2a0b0e975c649180f022510bf959 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3860655 Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Commit-Queue: Scott Collyer <scollyer@chromium.org> Reviewed-by: Madhu P <mparuchuri@google.com>
* rex: Add support for USB-AScott Collyer2022-08-292-0/+8
| | | | | | | | | | | | | | | | This CL adds the required config option and the usba-port-enable-list that are required to support USB-A opertation. BRANCH=none BUG=b:243899461 TEST=zmake build rex Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: I69e685133a2b319037feb07bffa48b2f4ccaa869 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3860654 Tested-by: Scott Collyer <scollyer@chromium.org> Commit-Queue: Scott Collyer <scollyer@chromium.org> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* rex: Add PSL device tree nodesScott Collyer2022-08-291-9/+32
| | | | | | | | | | | | | | | | | This CL adds nodes required for the npcx PSL block. This CL also removes the hibernate-wake-pins entry as that is only required for having wake pins without the EC hibernate feature. BRANCH=none BUG=b:243920003,b:243353079 TEST=zmake build rex Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: Ic1470ecd25f2aff88bce45f3f869a18d95f42d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3860653 Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Commit-Queue: Scott Collyer <scollyer@chromium.org>
* rex: Enable NCT3807 GPIO expander blockScott Collyer2022-08-291-1/+3
| | | | | | | | | | | | | | | | | | This CL adds CONFIG_GPIO_NCT38X which was missing. In addition, CONFIG_PLATFORM_EC_USB_PD_TCPM_SBU was removed as the SBU isolation for C0 is discrete and not integrated to the TCPC. BRANCH=none BUG=b:243482165 TEST=zmake build rex Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: Ic19183b7b645b19d88e264ced1afb4f8dfacb066 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3852567 Commit-Queue: Scott Collyer <scollyer@chromium.org> Reviewed-by: Madhu P <mparuchuri@google.com> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Tested-by: Scott Collyer <scollyer@chromium.org>
* rex: Fix tcpc_get_alert_status functionScott Collyer2022-08-291-5/+6
| | | | | | | | | | | | | | | | | | | | There was an error in tcpc_get_alert_status where the pin level wasn't being read. This CL adds gpio_pin_get_dt() so the gpio pin level is going to be read and removes the macro that was being used and was only testing if the node existed. BRANCH=none BUG=b:243482165 TEST=zmake build rex Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: Ife8aa4ed08c2be43776e12eeb9e28a9a04036bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3855164 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Commit-Queue: Scott Collyer <scollyer@chromium.org> Reviewed-by: Madhu P <mparuchuri@google.com>
* zephyr: Add new test for vboot efs2Jeremy Bettis2022-08-299-1/+425
| | | | | | | | | | | | | | | | | | | | This covers the cases in vboot_main. Next is to move the next level down and emulate the communication with the cr50 as well. Add new test hooks to vboot/efs2.c, and the flash emul. BRANCH=None BUG=None TEST=./twister Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: Icca8dde3731a91645eabbf2bc547c84a51cb1474 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3858041 Tested-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org>
* flash_fp_mcu: Fix script on nocturnePatryk Duda2022-08-291-13/+4
| | | | | | | | | | | | | | | | | | | | Recently nocturne board switched to 5.10 kernel. It means that SPI device for nocturne with 5.10 kernel needs to be changed to /dev/spidev1.0. This change is a good opportunity to get rid of separate config for nocturne-kernelnext board. The script still supports nocturne with kernel 4.4 because ChromeOS images can have this version in other kernel slots. BUG=b:244171527 BRANCH=None TEST=Run `flash_fp_mcu --hello` on nocturne and nocturne-kernelnext. Signed-off-by: Patryk Duda <pdk@semihalf.com> Change-Id: I7c2ecdd5d8ca3d9ce438376bdea33abbaf189e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3861329 Reviewed-by: Tom Hughes <tomhughes@chromium.org> Commit-Queue: Patryk Duda <patrykd@google.com>
* zephyr: shim: led: Add led pwm period checksMadhurima Paruchuri2022-08-291-1/+19
| | | | | | | | | | | | | | | Add build asserts to make sure the led pwm period is configured right for all LEDs BUG=b:230093078 BRANCH=none TEST=zmake testall Signed-off-by: Madhurima Paruchuri <mparuchuri@google.com> Change-Id: I2fe4ee9af7c013d0f17b186baf93fc5f26fa770e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3858971 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
View Lorry Controller Status