summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* pujjo: Use SSFC bit 2-3 value to identify lid sensorstabilize-15129.B-mainarthur.lin2022-09-193-0/+53
| | | | | | | | | | | | | | | | | Use SSFC bit 2-3 value to identify lid sensor. 0: bma422 1: lis2dwl BUG=b:236922025 BRANCH=none TEST=zmake build pujjo TEST=can read raw data from bma422 after setting ssfc=0x00 TEST=can read raw data from lis2dwl after setting ssfc=0x04 Signed-off-by: arthur.lin <arthur.lin@lcfc.corp-partner.google.com> Change-Id: I9a0668407e2f770d21d7d8aab1cec717aa1074ee Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3901914 Reviewed-by: Andrew McRae <amcrae@google.com>
* Battery: align OS low battery shutdown behaviorIvan Chen2022-09-195-14/+53
| | | | | | | | | | | | | | | | | | Deprecate BATTERY_LEVEL_CRITICAL in battery logic and use CONFIG_BATT_HOST_SHUTDOWN_PERCENTAGE instead to align OS low battery shutdown behavior, and centralize the low battery threshold decision. LOW_COVERAGE_REASON=CONFIG_OCPC is per-board definition. BRANCH=none BUG=b:244253629 TEST=Verify dedede shutdown from resume on low battery. Signed-off-by: Ivan Chen <yulunchen@google.com> Change-Id: Ibab3f87f213cc23c54fb5d7dc95aa6366c98e94e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3868875 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Shou-Chieh Hsu <shouchieh@chromium.org>
* tentacruel : Modify typec port 0 configjeffrey2022-09-197-9/+260
| | | | | | | | | | | | | | | | | | Modify port 0 ppc config to syv682 and bc12 config to pi3usb9201. BUG=b:238263725 TEST=zmake build tentacruel --clobber check port 0 can work normally. BRANCH=None LOW_COVERAGE_REASON=krabby board test under developement(b/243841599) Signed-off-by: jeffrey <jeffrey_lin@pegatron.corp-partner.google.com> Change-Id: I0b183783e93090b2247e01c18ebc72b6180eb753 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3897911 Code-Coverage: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Chen-Tsung Hsieh <chentsung@chromium.org> Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* nissa/ite: Set maximum sensor frequency to 100Hz.Sam McNally2022-09-193-0/+3
| | | | | | | | | | | | BUG=b:238597720 TEST=x86 CtsSensorTestCases can pass on nereid BRANCH=none Signed-off-by: Sam McNally <sammc@chromium.org> Change-Id: Ica8304be047ccd9bef78d8b417698672df5fdcbe Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3899958 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Commit-Queue: Peter Marheine <pmarheine@chromium.org>
* pujjo: Use SSFC bit 0-1 value to identify base sensor.jimmy.wu2022-09-196-2/+120
| | | | | | | | | | | | | | | | | | 0: bmi323 1: lsm6dsm BUG=b:235866642 BRANCH=none TEST=zmake build pujjo TEST=can read raw data from bmi323 after setting ssfc=0x00 TEST=can read raw data from lsm6dsm after setting ssfc=0x01 Signed-off-by: jimmy.wu <jimmy.wu@lcfc.corp-partner.google.com> Change-Id: I668317cde8b0431ae4b454ca28e3f0d644bb8d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3881429 Reviewed-by: Andrew McRae <amcrae@google.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org> Code-Coverage: Andrew McRae <amcrae@google.com>
* zephyr: add initial shim for lsm6dsm sensoramber.chen2022-09-1911-1/+157
| | | | | | | | | | | | | | | | | Add initial shim for the lsm6dsm accel/gryo sensor BUG=none BRANCH=none TEST=zmake build pujjo Signed-off-by: amber.chen <amber.chen@lcfc.corp-partner.google.com> Change-Id: Ib1ab863bedd2575dfafcbfc1c49c54afe46a7c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3865215 Reviewed-by: Andrew McRae <amcrae@google.com> Commit-Queue: Andrew McRae <amcrae@google.com> Code-Coverage: Andrew McRae <amcrae@google.com> Tested-by: Andrew McRae <amcrae@google.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* intelrvp: enable more console command featuresLi Feng2022-09-182-3/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | Set configs for console commands history, auto complete, help. BUG=none BRANCH=none TEST=on MTL RVP console, type help, will get ec:~$ help Please press the <Tab> button to see all available commands. You can also use the <Tab> button to prompt or auto-complete all commands or its subcommands. You can try to call commands with <-h> or <--help> parameter for more information. Available commands: 8042 :Print 8042 state in one place adc :Print ADC channel(s) apreset ... Signed-off-by: Li Feng <li1.feng@intel.com> Change-Id: Ibf4dcd67c20e1137d112442b00294dd99745a72e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3877940 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* Makefile.toolchain: Need to specify full path to compiler for ebuildTom Hughes2022-09-172-2/+15
| | | | | | | | | | | | | | | | When building with portage, the build fails if we use the "unprefixed" compiler (e.g., "g++"). Explicitly use the prefixed compiler when building for the host. BRANCH=none BUG=b:246424843 TEST=emerge-hatch chromeos-ec Force-Relevant-Builds: all Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Idd40d76fd0d1d32e55947898f98b6ef1f0ca628a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3901254 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* zephyr: tests: Test Host command EC_CMD_PWM_SET_KEYBOARD_BACKLIGHTTristan Honscheid2022-09-162-0/+61
| | | | | | | | | | | | | | Test the above host command in `common/keyboard_backlight.c` BRANCH=None BUG=b:246577858 TEST=./twister Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: I4f5c6074bddd4ec78919794cc02a98ed2faa4638 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3893396 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Yuval Peress <peress@google.com>
* Skyrim: Create i2c dtsi fileDiana Z2022-09-165-1/+6
| | | | | | | | | | | | | | | Move the i2c common code into a dtsi file which the variants may include in their own dts files. BRANCH=None BUG=b:244457125 TEST=zmake build skyrim and variants Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I1b48e21c76fff8bd1f4db127aea4da2bf936c1e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3902646 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* ec_commands: Fix flexible array member with g++Tom Hughes2022-09-161-4/+4
| | | | | | | | | | | | | | | g++ gives an error when using a flexible array member as the only member of a struct, but works with the zero-length array extension. BRANCH=none BUG=b:234181908 TEST=./util/compare_build.sh -b all -j 120 => MATCH Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I89775cef72cd0adaa77c8b4f281ed0327696d4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3894404 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* usb_serial: fix console.py handling of --serialnoMatthew Blecker2022-09-161-7/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was trying to pass the optional "langid" arg to usb.util.get_string(), but was doing so as a positional argument, in the wrong position. This bug was papered over by a blanket "except:" clause that would fall back on not specifying langid. With older PyUSB versions an exception from the incorrect args would be triggered, thus the fallback was always used. PyUSB now returns garbage for the serial number from the incorrect args, so the serial number comparisons stopped working. The langid being specified was 256 / 0x100, which is in a reserved block, not specific to any real language. The get_string() invocation returns the correct serial number with or without that langid specified (using the args correctly), and servod never specifies langid in these lookups, so this removes use of langid entirely to match servod behavior and remove need for the try/except fallback. This also fixes another blanket "except:" to specify the exception it's actually intending to catch (IndexError). Finally, this adds printing of default option values in the command line help output, so that it's clear --device has a default value and will usually need to be specified too when using --serialno. (We should change or remove the default and make --device optional when using --serialno, but I'll leave that for another patch.) BRANCH=none BUG=b:243562728 TEST=With multiple servos plugged in, including multiple servo_v4p1, tested opening consoles via --serialno by itself, --device by itself, and the two options in conjunction. Signed-off-by: Matthew Blecker <matthewb@chromium.org> Change-Id: Idd731ce76c9ed9a2e067bca11ede42b782a94669 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3902449 Reviewed-by: Ziting Shen <zitingshen@google.com>
* zephyr: pwm_mock: Add support for PWM flags to mock PWM driverTristan Honscheid2022-09-166-10/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The upstream Zephyr PWM API supports passing extra flags to control PWM polarity and this feature is used in our keyboard backlight PWM driver. However, our internal PWM mock/emul doesn't support specifying flags in the device tree. This CL adds support for this. * Add a "flags" cell to cros,pwm-mock * Update references in the device tree to pass the default flag of PWM_POLARITY_NORMAL. Since this only affects the PWM mock, this was limited in scope to our test code, specifically `zephyr/test/drivers/boards/native_posix.overlay` * Update the PWM mock to store the passed flags in its state struct and add a getter function. To make use of the updated PWM mock for an upcoming test suite covering `common/keyboard_backlight.c`, I also: * Add a keyboard backlight driver to the device tree * Enable CONFIG_PWM_MOCK for all driver tests, as required by the above backlight driver. BRANCH=None BUG=None TEST=./twister LOW_COVERAGE_REASON=Minor upgrade (~6 SLOC) to an emulator Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: I6abb6aba8b7ab4f2185c2ef28868767f95f79af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3893395 Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Code-Coverage: Jeremy Bettis <jbettis@chromium.org>
* Zephyr: Set default eSPI log level to errorDiana Z2022-09-163-2/+5
| | | | | | | | | | | | | | | The eSPI shim can be quite chatty, so default it to the error level on all boards. BRANCH=None BUG=None TEST=CQ+1 pass, boot on skyrim and observe no "KB put" info prints Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Iaf9c3805a2f657e525f09cf591563395c6358c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3902030 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* bb_retimer: Fix EXT_CONNECTION_MODE reg numberstabilize-15122.B-mainCaveh Jalali2022-09-161-2/+2
| | | | | | | | | | | | | | | | According to the burnside bridge datasheet, the extended connection mode register is actually at offset 7, not 6. BRANCH=none BUG=none TEST='make BOARD=brya' passes './twister -v -T zephyr/test' passes Change-Id: If0ad1d68d58f7731c242bb7393b7c56957916ab8 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3901261 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* osiris: Discharge on AC when high MLCC noiseYu-An Chen2022-09-162-0/+72
| | | | | | | | | | | | | | | | | | | | | | Charger will work on the hybrid mode if battery full and system current over 3A. The voltage gap between the Vsys and Vbat will cause the Vsys has high ripple, Although it is normal design behaviors, But it will cause MLCC noise a bit larger than other conditions. This CL force battery discharge when battery full, So the battery MOS of NVDC charger will turn on always, it make the Vsys same as Vbat and the noise has been improved. BUG=b:246214501 TEST=check battery discharging when battery full BRANCH=none Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: I61c65efbe4d44697371f3e039c8193e0adc9ec6c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3890025 Reviewed-by: Boris Mittelberg <bmbm@google.com> Commit-Queue: YH Lin <yueherngl@chromium.org>
* Makefile: Set prefixed toolchain for hostTom Hughes2022-09-163-3/+10
| | | | | | | | | | | | | | | | When building with portage, the build fails if we use the "unprefixed" compiler (e.g., "g++"). Explicitly use the prefixed compiler when building for the host. BRANCH=none BUG=b:246424843 TEST=emerge-hatch chromeos-ec Force-Relevant-Builds: all Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I50d2b437374bf6857b19151edb5eaea24a7330c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3894407 Reviewed-by: Eric Yilun Lin <yllin@google.com>
* i2c-pseudo: Add documentation in RST and MD formats.Matthew Blecker2022-09-163-5/+594
| | | | | | | | | | | | | | | | | | | | | | | | This supplements Documentation.txt, which is plain text as used by documentation in old Linux kernel versions, with Documentation.rst, which is reStructuredText as used in the latest versions of Linux. The plain text Documentation.txt remains and will be maintained as long as backport patches are maintained. Since Chromium OS source code browsing websites such as Gitiles and Code Search can render Markdown, but not reStructuredText, Documentation.md is included as well, generated using rst2md from nb2plots (https://github.com/matthew-brett/nb2plots) which uses Sphinx (https://www.sphinx-doc.org/). BRANCH=none BUG=b:129565355 TEST=viewed the markdown doc in Gitiles using Chrome Change-Id: I332ba9098a1379b2f56efbaab84ed5498ef43d34 Signed-off-by: Matthew Blecker <matthewb@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3900487 Reviewed-by: Keith Haddow <haddowk@chromium.org> Commit-Queue: Keith Haddow <haddowk@chromium.org>
* zephyr: tests: Test host command EC_CMD_MKBP_INFO (mkbp_info.c)Tristan Honscheid2022-09-168-13/+293
| | | | | | | | | | | | | | | | | | | | | * Move a utility function in to a common source to share it between tests * Add a missing header to the KB emul header * Expose two functions to access button and switch capabilities * Reset KB emul after the keyboard scan tests since they left some keys pressed down. * Fix period in copyright headers because the presubmit hooks made me. * Test all of the branches of the EC_CMD_MKBP_INFO host command BRANCH=None BUG=b:236075259 TEST=./twister Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: I99110a5cff066bea366fce28d2a9a92811608c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3893389 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: tests: Test force_mkbp_if_events() in mkbp_event.cTristan Honscheid2022-09-163-4/+97
| | | | | | | | | | | | | | | Test the scenario where the AP does not respond to the interrupt indicating MKBP events are available. BRANCH=None BUG=b:245531291 TEST=./twister Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: I81d3da9a01012a6eceb8c001b81296c06626d295 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3891207 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* zephyr: battery shim fix misspellingZick Wei2022-09-161-1/+1
| | | | | | | | | | | | | | | Fix misspelling in battery shim. BUG=b:246504615 BRANCH=none TEST=make sure battery can exit cutoff mode. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I473bbef9e27d6ff7d409ea1fe3bec3af0bf3fa05 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3897928 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Reviewed-by: Devin Lu <devin.lu@quantatw.com> Reviewed-by: Andrew McRae <amcrae@google.com>
* Craask: Volup/dn button exchanged on ver3 USB skuSue Chen2022-09-153-6/+29
| | | | | | | | | | | | | | | | | | | | Set correct GPIO definition of VOLUP/DN_BTN_ODL to meet Craask hardware design. VOLUP_BTN_ODL -> EC GPIOA2 VOLDN_BTN_ODL -> EC GPIO93 Volup/dn button exchanged on ver3 USB sub board. BUG=none BRANCH=none TEST=Volume up/down button works correct on ver3 DUTs. Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: Ic44161ed47778a36dc473789f350250ec3be47ef Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3893308 Code-Coverage: Andrew McRae <amcrae@google.com> Reviewed-by: Andrew McRae <amcrae@google.com> Commit-Queue: Andrew McRae <amcrae@google.com>
* zmake: Remove options for boards or tests onlyJeremy Bettis2022-09-153-37/+3
| | | | | | | | | | | | | | | | Since there are no tests in zmake, no reason to filter by boards or tests only. BRANCH=None BUG=None TEST=CQ Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I628fa87d41d60437bdb1597111da2eb2928b2ada Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3896635 Tested-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Aaron Massey <aaronmassey@google.com> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
* gitlab: Shard zephyr_boards_coverage job into 5Jeremy Bettis2022-09-151-4/+9
| | | | | | | | | | | | | | | | | | The zephyr_boards_coverage job sometimes times out after 2 hours. While I think I fixed the problem with the slow runner, splitting this into shards is also a good idea. BRANCH=None BUG=b:244590155 TEST=https://gitlab.com/zephyr-ec/ec/-/pipelines/640483665 Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: If37d2ddcbd64c4f2b7e7ab240e75218ed24aece0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3896634 Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
* test: Verify DP mode entry via PD info host cmdsAaron Massey2022-09-151-0/+33
| | | | | | | | | | | | | | | Test that after discovery, the PD info request EC_CMD_PD_SET_AMODE can be used to make the DPM enter DisplayPort alternate mode. BRANCH=none BUG=b:236075275 TEST=twister --clobber -i -s zephyr/test/drivers/drivers.usbc_alt_mode Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I0fd03a309c2a192589d856d89bb9f77ec1be5aab Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3896636 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Wai-Hong Tam <waihong@google.com>
* usb_mux: fix NULL checks in the usb_mux_chainKeith Short2022-09-151-3/+3
| | | | | | | | | | | | | | | Some boards (servo_v4p1) don't assign mux devices to all type-c ports. Ensure the mux device is valid before performing mux operations. BUG=b:246828811 BRANCH=none TEST=make buildall -j Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I009593d4ee94d412c6068588121b77af18402ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3897790 Reviewed-by: Matthew Blecker <matthewb@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: Check if rdb tool is available before trying to uploadAl Semjonovs2022-09-151-1/+7
| | | | | | | | | | | | | | | | | | Check if rdb tool is available before trying to upload test results. BUG=None BRANCH=NONE TEST=in chroot ./twister -T zephyr/test outside chroot (no rdb) ./twister -T zephyr/test Signed-off-by: Al Semjonovs <asemjonovs@google.com> Change-Id: I86863c3e55aca13ccada01db083fa0192c20f0c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3900051 Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* evoker: Implement LED behaviorYu-An Chen2022-09-153-175/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | evoker has two leds that are battery led and power led. The led behavior define as following: Power led: S0 - white S3 - white 1 second, off 1 second S5 - off Battery led: Full charge - white Charge - amber Discharge - off Error - red Forced idle - red 1 second, white 1 second BUG=b:243477929 BRANCH=none TEST=zmake build evoker Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: I1f6b0c161be7e79596de11b125e8624806406767 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3775798 Reviewed-by: Bob Moragues <moragues@chromium.org> Auto-Submit: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Reviewed-by: Sam Hurst <shurst@google.com> Commit-Queue: Sam Hurst <shurst@google.com> Tested-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
* zephyr/console: Add console buffer logging backendstabilize-15120.B-mainRob Barnes2022-09-153-0/+80
| | | | | | | | | | | | | | | | | | Add a zephyr logging backend for the console buffer. This allows the AP to access the logs sent to the zephyr logging subsystem. This backend will not run in LOG_MODE_MINIMAL, so it may not be usable for some EC OS projects. BUG=b:243709788 BRANCH=None TEST='ectool console' on Skyrim in immediate and deferred logging mode. Signed-off-by: Rob Barnes <robbarnes@google.com> Change-Id: I24d9ffeb5c90c99982c70ac2bcbdc0f814b45b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3853303 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* volteer: Set PD debug level to 0 to save spaceKeith Short2022-09-151-1/+1
| | | | | | | | | | | | | | | Volteer is critically low on flash space (~32 bytes). Set the PD debug level to 0. Free RO flash space is now 2016 bytes. BUG=none BRANCH=none TEST=make BOARD=volteer Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I6844d615ee6893c1b6917907423f9be63041cb34 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3900052 Commit-Queue: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* Delbin-G: Correct the keyboard matrix value for KP_ENTERJacky_Wang2022-09-151-1/+1
| | | | | | | | | | | | | | | Correct the keyboard matrix value for enter key(keypad). BUG=b:232737379 BRANCH=firmware-volteer-13672.B TEST=make BOARD=delbin Check press KP_ENTER key will show KEY_KPENTER on evtest. Signed-off-by: Jacky_Wang <jacky5_wang@pegatron.corp-partner.google.com> Change-Id: Iadbd44c848316ce5d1a856a709d214ae7d9b3625 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3893307 Reviewed-by: Kenny Pan <kennypan@google.com> Commit-Queue: Kenny Pan <kennypan@google.com>
* zephyr: enable the chargen console command by defaultPeter Marheine2022-09-151-0/+1
| | | | | | | | | | | | | | | | This command is used by some firmware tests, and it should have a very small effect on overall EC image size (but boards can still disable it if needed). BUG=b:246007302 TEST=zmake build --all BRANCH=none Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: Id15fcd3afe7801fe279ae237e1d238bf22581910 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3897910 Commit-Queue: Al Semjonovs <asemjonovs@google.com> Reviewed-by: Al Semjonovs <asemjonovs@google.com>
* test: Verify discovery via PD info host commandsAaron Massey2022-09-151-1/+22
| | | | | | | | | | | | | | | Test that after discovery, the PD info request EC_CMD_PD_DISCOVERY command fetches appropriate values. BRANCH=none BUG=b:236075275 TEST=twister --clobber -i -s zephyr/test/drivers/drivers.usbc_alt_mode Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I90c832e34d38102df1ebe4968a6dd663858a42fa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3895513 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* evoker: Add battery PC-VP-BP153Yu-An Chen2022-09-153-1/+59
| | | | | | | | | | | | | | Support new battery PC-VP-BP153 BUG=b:246879091 BRANCH=none TEST=zmake build evoker Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: Ib4bfd9826c75877ec9dca15ed8f963f53c74bba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3897916 Reviewed-by: Sam Hurst <shurst@google.com> Commit-Queue: Sam Hurst <shurst@google.com>
* Zephyr: Clarify keyboard powerbutton assert optionsDiana Z2022-09-151-4/+4
| | | | | | | | | | | | | | Clarify the causality in the powerbutton assert options, and also clarify why one might select either option. BRANCH=None BUG=b:245626014 TEST=zmake build skyrim Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Id388200403976dc3914eae32b8ffe258d34e2521 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3896633 Reviewed-by: Jett Rink <jettrink@chromium.org>
* zephyr/console: Return number of bytes consumed by console bufferRob Barnes2022-09-153-5/+12
| | | | | | | | | | | | | | | | | | | | Return the number of bytes consumed by the console buffer. This is not the same as the number of bytes written since null bytes are not written. For now this will always be 0 or len. This change will allow callers to perform an action when the request fails, such as printing a warning or retrying. BUG=b:243709788 BRANCH=None TEST=Boot skyrim, observe buffered console, pass default.console test. Change-Id: I97bf5a0776c123abbaed84b5ca7e58e903c0f20d Signed-off-by: Rob Barnes <robbarnes@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3892209 Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr/panic: Capture extra cortex-m registersRob Barnes2022-09-152-9/+34
| | | | | | | | | | | | | | | | | | Copy callee saved registers to panic data structure. Enable extra exception info by default. Clang format affected lines. BUG=b:245591465 BRANCH=none TEST=Dump panic info on skyrim, observe extra registers Signed-off-by: Rob Barnes <robbarnes@google.com> Change-Id: I848d7e6bc35bf2b62b76182dd9d3fa87877a41fc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3880830 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* magikarp: add led behaviorelmo_lan2022-09-151-1/+19
| | | | | | | | | | | | | | add led behavior for S0 and low battery BUG=b:244373502 BRANCH=none TEST=zmake build magikarp --clobber Signed-off-by: elmo_lan <elmo_lan@compal.corp-partner.google.com> Change-Id: I953d20335d452c8a7fa266d4a2a9721e37331228 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3891427 Reviewed-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: SamSP Liu <samsp_liu2@compal.corp-partner.google.com>
* steelix: disable BRINGUPmike2022-09-151-3/+1
| | | | | | | | | | | | | | | | Remove bringup config, the bringup state is completed, and this config caused a power sequence exception. BUG=b:241540339 BRANCH=none TEST=close lid, the dut can enter suspend state; open lid, the dut can wakeup normally. Signed-off-by: mike <mike5@huaqin.corp-partner.google.com> Change-Id: Idbe7dd6eb63c8e489b64f22180ac47a452564378 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3897919 Reviewed-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com>
* zephyr: upload test results for local runsAl Semjonovs2022-09-152-0/+54
| | | | | | | | | | | | | | | Upload test results for local twister runs BUG=None BRANCH=NONE TEST=./twister -T zephyr/test --no-upload-cros-rdb; ./twister -T zephyr/test Signed-off-by: Al Semjonovs <asemjonovs@google.com> Change-Id: I1ce87ab44fcfcf5ad96f3eb7c6f097bc36643985 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3891682 Commit-Queue: Yuval Peress <peress@google.com> Reviewed-by: Yuval Peress <peress@google.com>
* kuldax: add BJ power 65w/150w based on fw configben chen2022-09-152-4/+12
| | | | | | | | | | | | | | | | | | bj_power setting of fw_cofig BIT3-4: 150W = 0, (default) 230W = 1, 65W = 2, 135W = 3 BUG=b:229035883 BRANCH=cros/main TEST=chgsup reports voltage/current according to fw config Change-Id: Iff7f5879fc31a93f7600442582c5785c706ddc7d Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3865420 Reviewed-by: David Wu <david_wu@quanta.corp-partner.google.com> Reviewed-by: caveh jalali <caveh@chromium.org>
* Skyrim: Set refresh key CONFIGsDiana Z2022-09-141-0/+2
| | | | | | | | | | | | | | | | The refresh key will be on KSI3, and we may also see this signal asserted on all columns during a recovery boot so it needs to be filtered accordingly. BRANCH=None BUG=b:245626014 TEST=on skyrim, consistently boot to recovery mode Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I9080208356f42d4d7b4a7763b1957da7daecfb8a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3896632 Commit-Queue: Robert Zieba <robertzieba@google.com> Reviewed-by: Robert Zieba <robertzieba@google.com>
* gitlab: Remove cache and checkout bydateJeremy Bettis2022-09-141-54/+40
| | | | | | | | | | | | | | | | | | | | | | | Remove the cache, since it only works with shared runners, but keep the needs tags or else Gitlab will run all the build stage jobs before starting any of the test stage jobs, and that is slower. Get the timestamp of the latest commit, and use that timestamp to checkout the corresponding cls in the zephyr and ancillary repos. Retry git clone calls because they actually fail pretty often. BRANCH=None BUG=b:244590155 TEST=Pushed to gitlab coverage branch https://gitlab.com/zephyr-ec/ec/-/pipelines/640483665 Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: Ie66d5c97349ef17eba302387c3cd525dfbaa82ba Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3894402 Reviewed-by: Tristan Honscheid <honscheid@google.com> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org>
* Move Brya PPCs into the devicetreeMiguel Delatorre2022-09-144-3/+26
| | | | | | | | | | | | | | BUG=b:236131108 TEST=zmake testall; zephyr/zmake/run_tests.sh; BRANCH=main Change-Id: Ic1b403ddacacd6f3dabb5f83141d70c2416f7e92 Signed-off-by: Miguel Delatorre <delatmiguel@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3829953 Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Adam Mills <adamjmills@google.com>
* Makefile.toolchain: Pass sysroot flag for host buildsTom Hughes2022-09-141-0/+3
| | | | | | | | | | | | | | When compiling with clang, the host build fails to find dependencies when linking (libftdi/libusb) unless sysroot is specified. BRANCH=none BUG=b:246424843 TEST=emerge-hatch chromeos-ec Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I0407853a1dee55666f2c1768d6a981101feba691 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3894405 Reviewed-by: Edward Hill <ecgh@chromium.org>
* util/getversion.sh: Fix version when not in a git repoTom Hughes2022-09-141-1/+1
| | | | | | | | | | | | | | | | | | | When building with "FEATURES="test" emerge-hatch chromeos-ec" after using "cros-workon-hatch chromeos", the working directory is not a git repository (the files are just copied), so "git describe" in getversion.sh fails and the logic falls back to creating its own version number. The test in test/version.c explicitly checks for a version that begins with "v2" and has a hash length of at least 8, so update the version string from this case to match. BRANCH=none BUG=b:246424843 TEST=FEATURES="test" emerge-hatch chromeos-ec Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Ie06f9edc2a228eef0162be10e1b1abe123ce6bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3894408 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* test: EC thinks AP can boot on low battery capstabilize-15117.86.B-mainstabilize-15117.48.B-mainstabilize-15117.111.B-mainrelease-R107-15117.B-mainAaron Massey2022-09-141-0/+41
| | | | | | | | | | | | | | | | | Verify that the EC can still determine if the AP is bootable on a low battery capacity while there is a charger connected. Also verify that the EC thinks it can't boot when it's on low battery without a charger connected. BRANCH=none BUG=b:246335162 TEST=twister --coverage --clobber -i -s zephyr/test/drivers/drivers.default Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I02be9616fe3bee9fedd716f46ccb862b2f1ef0e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3892500 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* ps8xxx: Cache get_chip_info for all portsSam Hurst2022-09-141-24/+24
| | | | | | | | | | | | | | | | | | | | | Cache get_chip_info for all ports instead of just the first port. BUG=b:245748784 TEST=Herobrine does not boot loop on updating the TCPC ps8805.0: vendor 0x1da0 product 0x8805 device 0x0002 fw_rev 0x16 ps8805.1: vendor 0x1da0 product 0x8805 device 0x0001 fw_rev 0x15 BRANCH=main LOW_COVERAGE_REASON=This is a time sensitive change and code coverage will be increased in a separate CL and is tracked by BUG=b:246762616 Signed-off-by: Sam Hurst <shurst@google.com> Change-Id: I05647a2d118dce5204f710605afab83a42652ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3888227 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Wai-Hong Tam <waihong@google.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* mock: Fix format for 2-dimensional arraysFiras Sammoura2022-09-142-21/+34
| | | | | | | | | | | | | | | | | Define default_fake_fp_positive_match_salt and trivial_fp_positive_match_salt explicitly as 2-dimensional arrays with dimensions FP_MAX_FINGER_COUNT and FP_POSITIVE_MATCH_SALT_BYTES. Include driver/fingerprint/fpsensor.h to define FP_MAX_FINGER_COUNT. BRANCH=None BUG=b:242720387 TEST=make run-fpsensor_state TEST=make runhosttests Signed-off-by: Firas Sammoura <fsammoura@google.com> Change-Id: Iaae2280179e99bd5098928976727aa9b3cca9954 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3893046 Reviewed-by: Craig Hesling <hesling@chromium.org>
* twister: Update checking if in chrootYuval Peress2022-09-141-1/+1
| | | | | | | | | | | | | | | Check the cros_chroot_version file instead of the environment variable as directed in chat. BRANCH=none BUG=b:246461298 TEST=twister -c -v Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I6b83c403e0ed3eea8c7ffb8e201c64bf1390d7ec Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3893083 Reviewed-by: Tristan Honscheid <honscheid@google.com> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
View Lorry Controller Status