summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* cortex-m mpu: illegal shift fixstabilize-15245.B-mainBoris Mittelberg2022-11-153-2/+38
| | | | | | | | | | | | | | | | Shifting left by 32 is undefined behavior. An AND operation with mask of 0xffffffff is meaningless, so just avoid it. BUG=b:64477774 BRANCH=none TEST=none Signed-off-by: Boris Mittelberg <bmbm@google.com> Change-Id: Ibcb3359f453345caee01936c074a9c0ae5aff7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4021135 Tested-by: Peter Marheine <pmarheine@chromium.org> Reviewed-by: Peter Marheine <pmarheine@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* util: Add libec supportTom Hughes2022-11-153-0/+18
| | | | | | | | | | | | | | | | | | libec needs a file descriptor for running commands. This comm_get_fd() API will allow us to use libec in ectool. Also add the necessary compile and link flags to use libec. BRANCH=none BUG=b:144959033 TEST=make buildall Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I746e0ac6b9dc30d920bbda87e581a695d83fd300 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4009404 Reviewed-by: Bobby Casey <bobbycasey@google.com> Reviewed-by: Andrea Grandi <agrandi@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* evoker: Update LED configYu-An Chen2022-11-151-0/+4
| | | | | | | | | | | | | | | Add br-color key to enable ectool led command can control LED color BUG=b:243477929 BRANCH=none TEST=manual check ectool led command working Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: I4dc46cdef96e5e26acbc8ae384f51455394149f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4022400 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Sam Hurst <shurst@google.com> Commit-Queue: Sam Hurst <shurst@google.com>
* gaelin: Initial scaler configurationRaymond Chung2022-11-153-6/+28
| | | | | | | | | | | | | | This change adds gpio and I2C settings for scaler. BUG=b:249000573, b:254063356 BRANCH=None TEST=make -j BOARD=gaelin Change-Id: If95e0b5529a46fae445343d53206ec65655f292c Signed-off-by: Raymond Chung <raymondchung@ami.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4025482 Reviewed-by: Derek Huang <derekhuang@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* craask: resolve power leakage following nivviks.Deepti Deshatty2022-11-151-0/+35
| | | | | | | | | | | | | | | | Resolve power leakage following nivviks. CL : 3788018 BUG=b:258613461 TEST=zmake build craask BRANCH=none Change-Id: I41bef1259990985820db6543fa342144f912d174 Signed-off-by: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4020016 Reviewed-by: Andrew McRae <amcrae@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Poornima Tom <poornima.tom@intel.corp-partner.google.com>
* dibbi: Update power and recovery buttonsLiam Flaherty2022-11-152-4/+14
| | | | | | | | | | | | | | | | Update the config of power and recovery buttons from waddledee reference to support dibbi. BUG=b:257377036 BRANCH=dedede TEST=make -j BOARD=dedede Signed-off-by: Liam Flaherty <liamflaherty@chromium.org> Change-Id: If66a570eca4b78db11e3177f1090ca7fb8b8634d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4025387 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Adam Mills <adamjmills@google.com> Reviewed-by: Sam McNally <sammc@chromium.org>
* update_release_branch: Add support for Zephyr based boardsAndrew McRae2022-11-151-116/+222
| | | | | | | | | | | | | | | | | | | Add support for Zephyr based projects: - Add srcbase option for source directory base (requires SDK) - Add multiple repo handling - Use appropriate defaults for Zephyr - Use correct branch name and remote branch names - Skip repo if no changes (cmsis doesn't change much) BUG=b:257145337 TEST=Run with nissa firmware branch BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I7070afd2dca11b9afe0891900d1f209b749b3525 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4015604 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* marasov: Remove ALS and Tablet functionMichael5 Chen12022-11-154-255/+10
| | | | | | | | | | | | | | | | | | Depend on design, no support ALS and tablet mode. 1. Remove ALS and Tablet function 2. Remove volume button BUG=b:258756919 BRANCH=brya TEST=make BOARD=marasov Signed-off-by: Michael5 Chen1 <michael5_chen1@pegatron.corp-partner.google.com> Change-Id: Idb74f4ebaf162e8ee3c0e67c4c587f2017377225 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4022387 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Kyle Lin <kylelinck@google.com> Reviewed-by: Kyle Lin <kylelinck@google.com> Reviewed-by: Jeffrey Lin <jeffrey_lin@pegatron.corp-partner.google.com>
* core/cortex-m0: Use EC's builtins over compiler-rtTom Hughes2022-11-152-7/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When examining code size, it appears that the builtins in compiler-rt (especially for division) are larger than the ones in the EC source code: armv7m-cros-eabi-readelf -s ./build/servo_v4p1/RW/ec.RW.elf | sort -k3 -n -r __udivsi3: 418 bytes __aeabi_uidiv: 418 bytes Compiling with clang before this change: RO: 15560 bytes in flash and 864 bytes in RAM still available on servo_v4p1 RW: 848 bytes in flash and 7144 bytes in RAM still available on servo_v4p1 After this change: RO: 16456 bytes in flash and 864 bytes in RAM still available on servo_v4p1 RW: 1232 bytes in flash and 7144 bytes in RAM still available on servo_v4p1 BRANCH=none BUG=b:256193799 TEST=make buildall Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I21eab7fba10795e7821be79d141002a009d396a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4021114 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
* board/nocturne: Enable LTOTom Hughes2022-11-152-1/+3
| | | | | | | | | | | | | BRANCH=none BUG=b:172020503 TEST=make BOARD=nocturne Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I19b0c772380336cdcd8b9d219386df21f859a7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4021113 Reviewed-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* board/gelarshie: Free up more flash spaceTom Hughes2022-11-152-1/+2
| | | | | | | | | | | | BRANCH=none BUG=b:172020503 TEST=CC=clang make BOARD=gelarshie Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Ib483bc193fea2737a1c1add0695327b014727e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4024038 Reviewed-by: Edward Hill <ecgh@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* chip/ish: fix system shutdown in D0i3Li Feng2022-11-154-40/+166
| | | | | | | | | | | | | | | | | | | | | | | | | | ISH should set PMC LTR(Latency Tolerance Reporting) for DMA operation. Without doing this, we observed system shutdown during D0i3. This CL set LTR to 2ms before DMA operation and set LTR to a large number after DMA operation is completed to enable SOC to go into the lowest possible power state. BUG=b:234136500 BRANCH=none TEST=on Nirwen platform, ISH enter D0i3 host loading case, and also stitching to coreboot case; S0i3 is hit and no shutdown. Signed-off-by: Leifu Zhao <leifu.zhao@intel.com> Signed-off-by: Li Feng <li1.feng@intel.com> Change-Id: Ib0fe907470774998dda29a40197d6c18ad6372f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4003320 Code-Coverage: Haribalaraman Ramasubramanian <haribalaraman.r@intel.corp-partner.google.com> Reviewed-by: Kyoung Kim <kyoung.il.kim@gmail.com> Reviewed-by: Haribalaraman Ramasubramanian <haribalaraman.r@intel.corp-partner.google.com> Commit-Queue: Kangheui Won <khwon@chromium.org> Tested-by: Haribalaraman Ramasubramanian <haribalaraman.r@intel.corp-partner.google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Kangheui Won <khwon@chromium.org>
* ec: IWYU Add some missing includesJeremy Bettis2022-11-143-0/+5
| | | | | | | | | | | | | | | | | | Add headers for types that are used in these headers. BRANCH=None BUG=b:247100970 TEST=CQ Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I184a7d31e8cb7e14391f0c610296884d7d124600 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4024015 Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Simon Glass <sjg@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org>
* evoker: Remove USB-A portYu-An Chen2022-11-143-16/+14
| | | | | | | | | | | | | | | | Evoker doesn't have USB-A. In here remove it. BUG=b:238571776 BRANCH=none TEST=check gpioget doesn't have USB-A related gpio name Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: I940d2d191683d14d748e014c2d2069aa02dd4d82 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4022556 Reviewed-by: Wai-Hong Tam <waihong@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Wai-Hong Tam <waihong@google.com> Reviewed-by: Bob Moragues <moragues@chromium.org>
* test: system shimYuval Peress2022-11-1410-36/+205
| | | | | | | | | | | | | | | Add tests for all error conditions that can be emulated at runtime for system.c's shim layer. BRANCH=none BUG=none TEST=twister Signed-off-by: Yuval Peress <peress@google.com> Change-Id: Id90dbe0c046e379f5bee5fe958a58e0928cfd157 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4025333 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* test: switchcap power off delayYuval Peress2022-11-141-0/+1
| | | | | | | | | | | | | | | Add 1ms power off delay to the switchcap and verify all the tests still pass. BRANCH=none BUG=none TEST=twister Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I5649e0b2559b3ae542ee6e4718361a326055c5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4025332 Reviewed-by: Tomasz Michalec <tmichalec@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* test: cover missing accessors and init in gpio shimYuval Peress2022-11-145-3/+87
| | | | | | | | | | | | | | | | | | | | | Add tests for the following: - init with custom unused pins handler that fails - calls to gpio_or_ioex_get_level() which wrap gpio_get_level() - calls to gpio_reset_port which resets the entire struct device * - calls to setting the GPIO flags using a mask. Note, tests needed to move to 'pre_main' since they now mess with initialization. BRANCH=none BUG=none TEST=twister Signed-off-by: Yuval Peress <peress@google.com> Change-Id: Ia08bc4a810874eeaf9fff0075e83ef689550d9dd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4026563 Reviewed-by: Aaron Massey <aaronmassey@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* gpio: optimize the gpio_set_flags_by_mask loopYuval Peress2022-11-141-5/+10
| | | | | | | | | | | | | | | Make use of __builtin_ctz in order to loop through 'flags' instead of checking each bit one by one. BRANCH=none BUG=none TEST=twister Signed-off-by: Yuval Peress <peress@google.com> Change-Id: If202aa650326f52927effca9bd2f685bcb869ff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4025331 Reviewed-by: Aaron Massey <aaronmassey@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* ec: IWYU Add some missing includesJeremy Bettis2022-11-148-0/+16
| | | | | | | | | | | | | | | | | | There are a few headers here that don't include the stdint or stdbool headers, but use the int or bool types defined there. BRANCH=None BUG=b:247100970 TEST=CQ Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: Idbf7e4d0c5182821fbc9fe9fb60690b12701bf75 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4022252 Commit-Queue: Simon Glass <sjg@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* util: add support for LR and PC in crash reportsRicardo Quesada2022-11-141-1/+12
| | | | | | | | | | | | | | | | Some crash reports (E.G: Coral) contain LR and PC valid registers. This CL uses them, when available, to process the PC symbol. BUG=b:259112884 TEST=crash_analyzer.py lite -m coral_113.map -f dumps_coral/ It correctly found the PC for the crashes. BRANCH=none Change-Id: I9d02a090bb4bf37dc18128cdec75e52fecb81fde Signed-off-by: ricardoq@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4022249 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* test: pi3usb9201 driver shimYuval Peress2022-11-146-1/+150
| | | | | | | | | | | | | | | | Verify that the shim layer of the pi3usb9201 handles GPIO callbacks. BRANCH=none BUG=none TEST=twister Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I19f7d48f3f2d7e066e952caa35b857d564535d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4018195 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* cq: Exclude zephyr/main/arch/posix from coverageJeremy Bettis2022-11-141-0/+1
| | | | | | | | | | | | | | | | | | | | | The code in zephyr/main/arch/posix is essentially test code, since the posix arch is only used for tests. There have been intermittent coverage changes in zephyr/main/arch/posix/posix_core.c BRANCH=None BUG=None TEST=None Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: Ib52ad05f81f709f0d95b840095fd2e12798dc9f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4020817 Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Aaron Massey <aaronmassey@google.com> Commit-Queue: Aaron Massey <aaronmassey@google.com> Tested-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* board/waddledoo: Free up flash spaceTom Hughes2022-11-142-2/+4
| | | | | | | | | | | | BRANCH=none BUG=b:172020503 TEST=CC=clang make BOARD=waddledoo Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I8b088e83c95c3874c461c3efe34345399f5074c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4024562 Reviewed-by: Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* baseboard/kukui: Free up additional flash spaceTom Hughes2022-11-141-0/+6
| | | | | | | | | | | | BRANCH=none BUG=b:172020503, b:256193799 TEST=make buildall Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I746815d69bbdab3dd95ba69f47d4c1f7494fe642 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4024040 Reviewed-by: Eric Yilun Lin <yllin@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* board/oak: Free up more flash spaceTom Hughes2022-11-142-1/+2
| | | | | | | | | | | | BRANCH=none BUG=b:172020503 TEST=CC=clang make BOARD=oak Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I234151d4b77bc27e9293a64fa02433370f0c7654 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4024570 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
* board/adlrvpp_mchp1521: Free up more flash spaceTom Hughes2022-11-142-3/+4
| | | | | | | | | | | | BRANCH=none BUG=b:172020503 TEST=CC=clang make BOARD=adlrvpp_mchp1521 Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Ie8f3b6cbcea758352ab38591d26d831d77b1084d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4024569 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* board/[kappa|terrador]: Fix compilation errorTom Hughes2022-11-142-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | When building with clang, it fails: board/kappa/led.c:132:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough] default: ^ board/terrador/board.c:304:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough] default: ^ BRANCH=none BUG=b:253644823 TEST=CC=clang make BOARD=terrador TEST=CC=clang make BOARD=kappa Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I2d343d5fd99c958194af09ec51d9800a15b170f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4024037 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* zephyr: prj.conf: drop explicit CONFIG_TACH_NPCX=yFabio Baltieri2022-11-146-16/+0
| | | | | | | | | | | | | | | These are not needed, they are set automatically when a corresponding device is enabled in the devicetree. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I79f63504723fb911e834eb2ed509580b69079744 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4023452 Reviewed-by: Tristan Honscheid <honscheid@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: prj.conf: drop explicit CONFIG_GPIO_PCA95xx=yFabio Baltieri2022-11-142-2/+0
| | | | | | | | | | | | | | | These are not needed, they are set automatically when a corresponding device is enabled in the devicetree. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I74d81e02a99267ad75a6e089b9f255d9306f4d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4023451 Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: prj.conf: drop explicit CONFIG_GPIO_NCT38XX=yFabio Baltieri2022-11-144-10/+0
| | | | | | | | | | | | | | | These are not needed, they are set automatically when a corresponding device is enabled in the devicetree. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I460c45076991b744cb55f797587ae089ad60d8c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4023450 Reviewed-by: Sam Hurst <shurst@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: Kconfig: default EEPROM_SHELL to nFabio Baltieri2022-11-1410-9/+3
| | | | | | | | | | | | | | | | Pretty much every project disables it explicitly, presumably to save flash. Flip the default to 'n' for the the whole project, delete all the explicit options. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ia55c2d1625ff2a571a41947db25b0041bc055da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4023449 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Al Semjonovs <asemjonovs@google.com>
* zephyr: move periodic temp read hook to shim layerDawid Niedzwiecki2022-11-146-18/+84
| | | | | | | | | | | | | | | | | | | | | | Some of the temperature sensor drivers declare periodic one second hook to update cached temperature measurement. Declare common hook and call the update function for every sensor. The change allows better manageing of the update calls, e.g. checking power-good pin. BUG=b:244474857 BRANCH=main TEST=skyrim doesn't spam "Recover Bus failed" in G3 Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: Ibdfe63e20c726efb738deaa23444f7d6dd87b5e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3909669 Reviewed-by: Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Tested-by: Dawid Niedzwiecki <dawidn@google.com>
* zephyr: tests: add pct2075 emulatorDawid Niedzwiecki2022-11-1410-1/+285
| | | | | | | | | | | | | | | | | | | | Add PCT2075 temperature sensor emulator. The PCT2075 doesn't support the OS pin. The emulator helps with testing code that is touched only by i2c temperature sensors. BUG=b:244474857 BRANCH=main TEST=twister -T zephyr/test/drivers Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: Iaefed4ffd50b17b59da89361abeded28456751ec Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4020414 Commit-Queue: Keith Short <keithshort@chromium.org> Tested-by: Dawid Niedzwiecki <dawidn@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: Kconfig: drop explicit CONFIG_EEPROM_AT24=yFabio Baltieri2022-11-1410-10/+0
| | | | | | | | | | | | | | | It's already automatically selected when necessary, no need to do it explicitly. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I6ec980ef4d69bb9388d4268d7b0cb6fba349aafd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4023448 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Wai-Hong Tam <waihong@google.com>
* zephyr: Kconfig: enable PLATFORM_EC_I2C automaticallyFabio Baltieri2022-11-1419-41/+5
| | | | | | | | | | | | | | | | | | | | Enable PLATFORM_EC_I2C automatically based on the presence of the named-i2c-node, select I2C automatically as well, drop all the now redundant config options and safety checks. Note that the DT_PATH check is not exactly equivalent to the DT_HAS_NAMED_I2C_PORTS_ENABLED dependency, will address that in a followup patch. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I38e9725e63a02caae8f5efb1224262ee0430efb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4023447 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: rename mediatek signal list to add the vendor prefixFabio Baltieri2022-11-143-3/+3
| | | | | | | | | | | | | | | | | | Compatibles should be prefixed by vendor name, not model number. Fixes the warning: node '/power-signal-list' compatible 'mt8186,power-signal-list' has unknown vendor prefix 'mt8186' BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I706964a0cb29e1a2eda47f422721064111f4f11b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4023444 Reviewed-by: Yuval Peress <peress@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: config: drop redundant CONFIG_ADC_SHELL config entriesFabio Baltieri2022-11-1410-30/+0
| | | | | | | | | | | | | | ADC_SHELL already defaults to "n", no need to set it explicitly. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I657f11a7ef27e724312915ec2fefe97a3ba1d552 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3999722 Reviewed-by: Sam Hurst <shurst@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* board/servo_v4: Free up more flash spaceTom Hughes2022-11-122-1/+3
| | | | | | | | | | | | BRANCH=none BUG=b:172020503 TEST=CC=clang make BOARD=servo_v4 Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I719bd93e1aaadd1591cf49c07ac65e6815de94bc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4024563 Reviewed-by: Brian Nemec <bnemec@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* test: add coverage for shim/src/tasks.cYuval Peress2022-11-124-12/+98
| | | | | | | | | | | | | | Add missing coverage for error cases and shell command. BRANCH=none BUG=none TEST=twister Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I0efa2cde8a48aafa54308813b99972c7b97d64e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4024064 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* tasks: catch errorsYuval Peress2022-11-111-3/+7
| | | | | | | | | | | | | | Add missing error handling. BRANCH=none BUG=none TEST=twister -s zephyr/test/drivers/drivers.default Signed-off-by: Yuval Peress <peress@google.com> Change-Id: Ia48d2b243c20bfe64fe1329a59378a4c85da4fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4020771 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Simon Glass <sjg@chromium.org>
* zombie: correct battery configurationTang Qijun2022-11-113-5/+56
| | | | | | | | | | | | | | | | | | | Correct battery parameters for zombie board. BRANCH=none BUG=b:258074497 TEST=1)Battery is detecting fine at EC bootup 2)Battery normal charge to full 3)Battery cutoff is working as expected Signed-off-by: Tang Qijun <qijun.tang@ecs.corp-partner.google.com> Change-Id: Ia0156343da5f5aff3dcbdcbc71382e67f096a0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4022846 Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Bob Moragues <moragues@chromium.org> Reviewed-by: Bob Moragues <moragues@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* keyboard_scan: initialize variableBoris Mittelberg2022-11-111-0/+1
| | | | | | | | | | | | | | | Avoid possible uninitialized use of poll_deadline. BUG=b:64477774 BRANCH=none TEST=make -j buildall Signed-off-by: Boris Mittelberg <bmbm@google.com> Change-Id: I92cd4bd59764c3620869262674a862d633db9dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4021134 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: caveh jalali <caveh@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* pi3usb9201 shim: Remove unneeded guardKeith Short2022-11-111-7/+0
| | | | | | | | | | | | | | | | | All boards and tests now define the BC1.1 devices in the devictree. Remove an obsolete guard. BUG=none BRANCH=none TEST=twister TEST=zmake compare-builds Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: If28f1932bb7b1febccc07475f759867a45c01299 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4023769 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Yuval Peress <peress@google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* emul_pi3usb9201: Rename compatible stringKeith Short2022-11-118-34/+18
| | | | | | | | | | | | | | | | Rename the compatible string for the PI3USB9201 emulator to match the real driver. Also move all bc12 setup into the devicetree for tests. BUG=b:218331557 BRANCH=none TEST=twister Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: Iaf15fadf20b070033a474d395ae330b4f84e4f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4023768 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Yuval Peress <peress@google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* test: usb_mux: use devicetreesKeith Short2022-11-1112-86/+131
| | | | | | | | | | | | | | | | Update the tests to use the "cros-ec,usb-mux-chain" to specify the USB muxes under test instead of hard coding via stubs. BUG=b:239457738 BRANCH=none TEST=twister Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I5a5acaf0b3815558454d4ec886e1058e4ccf36ea Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4023767 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Yuval Peress <peress@google.com>
* usb_mux shim: Set a default flags valueKeith Short2022-11-111-2/+2
| | | | | | | | | | | | | | | | | The flags property is marked as not required, set the default flag field to 0 if not specified in the devicetree. BUG=none BRANCH=none TEST=twister TEST=zmake compare-builds Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: Ibb4590645aa901bc874acb721fd0bbbb7671f409 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4023766 Reviewed-by: Yuval Peress <peress@google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* emul_bb_retimer: Rename compatible stringKeith Short2022-11-113-39/+6
| | | | | | | | | | | | | | | | | Rename the compatible string for the BB retimer emulator to match the real driver. Also removed unneeded devicetree properties from the emulator devicetree node. BUG=b:239457738 BRANCH=none TEST=twister Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I312129f5ffab9ba39394a3a2655d7ce3def5f9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4023765 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Yuval Peress <peress@google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* herobrine: Support remove USB-AYu-An Chen2022-11-111-0/+4
| | | | | | | | | | | | | | | | | Disable USB-A related init function if board doesn't have USB-A BUG=b:238571776 BRANCH=none TEST=zmake build evoker Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: I6ce2193431d040c59ca5466a42be22c877596152 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4022555 Commit-Queue: Bob Moragues <moragues@chromium.org> Reviewed-by: Bob Moragues <moragues@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Wai-Hong Tam <waihong@google.com>
* zephyr: tests: Test four function in `common/charger.c`Tristan Honscheid2022-11-111-0/+49
| | | | | | | | | | | | | | | | | | | Test the happy paths of: * `charger_set_vsys_compensation()` * `charger_is_icl_reached()` * `charger_enable_linear_charge()` * `charger_get_battery_cells()` BRANCH=None BUG=None TEST=./twister Signed-off-by: Tristan Honscheid <honscheid@google.com> Change-Id: Ia85dbe93eb2bb5528d4832c0dbdef09fe3882797 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4017487 Reviewed-by: Simon Glass <sjg@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* test: Add rng_benchmark testAndrea Grandi2022-11-119-0/+97
| | | | | | | | | | | | | | BRANCH=none BUG=b:246836252 TEST=./test/run_device_tests.py --board bloonchipper -t rng_benchmark TEST=./test/run_device_tests.py --board dartmonkey -t rng_benchmark Signed-off-by: Andrea Grandi <agrandi@google.com> Change-Id: Ib1a2a4b0fc8e3d55022e94727417c38e5e94359b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4019773 Reviewed-by: Bobby Casey <bobbycasey@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Tom Hughes <tomhughes@chromium.org>
View Lorry Controller Status