summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* battery: Follow a name convention in 'battery' console command outputstabilize-15301.B-mainMadhurima Paruchuri2023-01-021-2/+2
| | | | | | | | | | | | | | | | Refactored couple of names in 'battery' console command output to have single name convention in output BUG=none BRANCH=none TEST=Flashed on Taniks and checked output on EC console Change-Id: I080445c2c1013b9c04823ae25201c3d987f00444 Signed-off-by: Madhurima Paruchuri <mparuchuri@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4091769 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* battery: Add charge cycles to battery console command outputMadhurima Paruchuri2023-01-022-1/+16
| | | | | | | | | | | | | | | | Adding missing static information of battery to 'battery' console command which is required for FAFT Auto testing LOW_COVERAGE_REASON=Unit testing not required for mock APIs BUG=b:245344894 BRANCH=none TEST=Flashed on Taniks and checked output on EC console Change-Id: Ib14ab7caa21f5c00dc96d368b1bf923029981e60 Signed-off-by: Madhurima Paruchuri <mparuchuri@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4091767 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* corsola: power sequence teststabilize-15300.B-mainTing Shen2022-12-3011-15/+512
| | | | | | | | | | | | | | | | | | Add a test to verify mt8186 power state machine behavior. power/mt8186.c has above 90% coverage after this CL. BUG=b:256575497 TEST=./twister -v -i --coverage -p native_posix -p unit_testing BRANCH=none Change-Id: I2f274697e83dfc50f6976b8f6d137df6c69da2b9 Signed-off-by: Ting Shen <phoenixshen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4127103 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Eric Yilun Lin <yllin@google.com> Tested-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org>
* util/build_with_clang: Add burnet and krane to list of boards that fail with ↵Madhurima Paruchuri2022-12-291-2/+2
| | | | | | | | | | | | | | | | | clang The firmware CI checks are failling because of overflow of flash during build for boards Burnet and Krane BRANCH=none BUG=none TEST=none Change-Id: I535aa54144c7e198fbf08712e8f112ebfd00cd18 Signed-off-by: Madhurima Paruchuri <mparuchuri@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4128319 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* craask: support LGC batteryben chen2022-12-291-0/+3
| | | | | | | | | | | | | | add LGC battery: AP19B8M BUG=b:230445911 BRANCH=none TEST=battery cut off test, battery detection Change-Id: I842ec0cf4d2cfa38f22d1c8f7d1d521c5bdf8d09 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4128276 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Andrew McRae <amcrae@google.com>
* zephyr: shim: shim SHA256 API to adapot HW accelerator driverJun Lin2022-12-296-0/+188
| | | | | | | | | | | | | | | | | | | | | | | | Wrap Zephyr crypto_sha* driver APIs to meet the interface of Cros-EC SHA256 APIs. This CL has dependency on PR: https://github.com/zephyrproject-rtos/zephyr/pull/53031 BRANCH=none BUG=b:155771688 TEST=keep the same RW image; flash different RO images with/without hardware accelerator; verify the RW hash value is the same in the console message. TEST=in the test CL; move test patterns in test/sha256.c to zephyr/program/npcx_evb/npcx9/src/test_sha256.c; pass all test patterns. Signed-off-by: Jun Lin <CHLin56@nuvoton.com> Change-Id: I3979c088933d2caa09576f4aacc14d2ffb6f73f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4116105 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Tested-by: CH Lin <chlin56@nuvoton.com> Commit-Queue: CH Lin <chlin56@nuvoton.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* mtlrvp: config LP5 Type-C portsLi Feng2022-12-284-5/+118
| | | | | | | | | | | | | | | | | | | | | | Add board ID to check LP5, and config as below: MTL LP5 RVP: Port 0: no retimer Port 1: port not exist. Port 2: 20G HB retimer at I2C 0x56 Port 3: 40G HB retimer at I2C 0x57 BUGS=none BRANCH=none TEST=on MTL LP5 RVP, confirm all ports are using LP5 config. LOW_COVERAGE_REASON=Board level code change Signed-off-by: Li Feng <li1.feng@intel.com> Change-Id: I7d22bb4d8e3a65d77355e0b3c12f0a224a283cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3866258 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Brandon Breitenstein <brandon.breitenstein@intel.com> Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
* skyrim: save and store the io expander status when NCT38xx resetJosh-Tsai2022-12-282-3/+15
| | | | | | | | | | | | | | | | | | | | | Upstream Zephyr support the get_config and get_direction in nct38xx. Use the upstream API to implement the function which saves and stores the nct38xx gpio status when it is doing the reset. BRANCH=None BUG=b:260534665 LOW_COVERAGE_REASON=no unit test for skyrim board yet: b/247151116 TEST=Winterhold USBA is workable when wake up from battery cutoff Change-Id: I3394ed2c7f39be494bd5df9e076871d11ea0bcf0 Signed-off-by: Josh-Tsai <josh_tsai@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4115055 Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* shim/src/gpio: Add save/restore GPIO controller port configure functionJosh-Tsai2022-12-284-0/+137
| | | | | | | | | | | | | | | | | | | | | | We need to save the IO expander GPIO status before the device reset, and restore the status after the device is reset completely. create the function to save and restore the port configure BRANCH=None BUG=b:260534665 TEST=zmake build winterhold TEST=IO expander GPIOs status will not clear after tcpc reset TEST=./twister -v -i --coverage -p native_posix -p unit_testing -s external/platform/ec/zephyr/test/drivers/drivers.default Change-Id: Ic35e7e412792a56fde670de252887a9bdb557b36 Signed-off-by: Josh-Tsai <josh_tsai@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4115054 Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Keith Short <keithshort@chromium.org>
* craask: add led brightness range for amberben chen2022-12-281-1/+1
| | | | | | | | | | | | | | add led brightness range for amber color BUG=none BRANCH=none TEST=ectool led battery amber is workable. Change-Id: I7061e906d4f588ce59a30a8d6ef897a3594e057b Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4117944 Reviewed-by: Andrew McRae <amcrae@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* yaviks: update thermal table v2Zick Wei2022-12-261-14/+14
| | | | | | | | | | | | | | BUG=b:253557900 BRANCH=none TEST=verify fan steps work intended. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I2cd722b7bebe29a48fe0404a91cb8d83d6d646fa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4121806 Reviewed-by: Devin Lu <devin.lu@quantatw.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Shou-Chieh Hsu <shouchieh@chromium.org> Reviewed-by: Shou-Chieh Hsu <shouchieh@chromium.org>
* Winterhold: Modify thermal configLeila Lin2022-12-242-14/+10
| | | | | | | | | | | | | | | | | | | Use soc and amb sensor to control fan. Modify thermal config. LOW_COVERAGE_REASON=no unit tests for skyrim yet, b/247151116 BUG=b:255732503 BRANCH=none TEST=verify the thermal config on winterhold is correct Change-Id: I4a0ec0510998d9bd7623fd1c1ff86d158ff424df Signed-off-by: Leila Lin <leilacy_lin@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4113512 Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Chao Gui <chaogui@google.com> Commit-Queue: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Tested-by: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: mkbp: split the node compatible in twoFabio Baltieri2022-12-2311-24/+45
| | | | | | | | | | | | | | | | | Split the mkbp node binding in two nodes, normal and host. This adds the automatic Kconfig entries that can be used to control the option and simplify few macros. BRANCH=none BUG=none TEST=cq dry run TEST=zmake compare-builds -a Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I8a4825e616557a981a700c13517e76a3fd86ea07 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4117086 Reviewed-by: Wai-Hong Tam <waihong@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: ec-console: remove DT_PATH usagesFabio Baltieri2022-12-232-6/+10
| | | | | | | | | | | | | | | | Use a compatible lookup to find the ec-console node, add check for duplicate nodes, drop a redundant explicit setting (it defaults to y). BRANCH=none BUG=none TEST=cq dry run TEST=zmake compare-builds -a Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ie2920843e2315a866bb0244b86bfd1e2d5d24b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4116775 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Al Semjonovs <asemjonovs@google.com>
* zephyr: gpio_id: replace DT_PATH with the node pathFabio Baltieri2022-12-231-4/+4
| | | | | | | | | | | | | | | There was already a #define with the node path, may as well use it. BRANCH=none BUG=none TEST=cq dry run TEST=zmake compare-builds -a Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I69cb8d14de3b0b39e72c148797e79ba84d9733cb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4116774 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: named-i2c-ports: remove DT_PATH usagesFabio Baltieri2022-12-234-11/+15
| | | | | | | | | | | | | | | | Replace a bunch of DT_PATH usages with some common macros to access the named-i2c-ports node based on the DT compatible. BRANCH=none BUG=none TEST=cq dry run TEST=zmake compare-builds -a Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I2a817fda86b83811cd3d37abeca83048ea9b9eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4116773 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Aaron Massey <aaronmassey@google.com>
* zephyr: unused-gpios: remove DT_PATH usagesFabio Baltieri2022-12-232-20/+17
| | | | | | | | | | | | | | | | Replace a bunch of DT_PATH usages with some common macros to access the unused-gpios node based on the DT compatible. BRANCH=none BUG=none TEST=cq dry run TEST=zmake compare-builds -a Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ifb45205d5755b4ccf457df650b3f9c719e79096a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4116772 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: test: drop CONFIG_ESPI_EMUL=yFabio Baltieri2022-12-232-2/+0
| | | | | | | | | | | | | | | It's now selected automatically upstream, no need to enable it explicitly. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I93df21694661db042870ca5943a4438bdbab243f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4110953 Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* tentacruel: ppc testTing Shen2022-12-236-3/+195
| | | | | | | | | | | | | | | | This test verifies the ppc chip selecting logic on tentacruel BUG=b:243841599 TEST=twister -T zephyr/test/krabby/ BRANCH=none Change-Id: I46c7840b9a88adab24751dd207e2d9cb9c3dbd21 Signed-off-by: Ting Shen <phoenixshen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4121663 Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* brya: Add comment to i2c devicetreeJason Yuan2022-12-221-0/+4
| | | | | | | | | | | | | | | | | Comment added to duplicated node for clarity. BUG=b:216867453 TEST=none BRANCH=none Change-Id: I579eadde4c63e95dba5951d8d19df7777074bff3 Signed-off-by: Jason Yuan <jasonyuan@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4122728 Auto-Submit: zhi cheng yuan <jasonyuan@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Keith Short <keithshort@chromium.org> Tested-by: zhi cheng yuan <jasonyuan@chromium.org>
* zephyr/test/drivers: Move flash test to separate directoryPatryk Duda2022-12-226-1/+16
| | | | | | | | | | | | | | | | | | Moving flash tests to separate directory will allow to create a variant of these tests with different options enabled. BUG=b:239712345 BRANCH=none TEST=./twister -v -T zephyr/test/drivers/ --test \ external/platform/ec/zephyr/test/drivers/drivers.flash Signed-off-by: Patryk Duda <pdk@semihalf.com> Change-Id: Ifa8f350a27abe73d87794f6a4dcc13e34c7b6092 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4118761 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Tested-by: Patryk Duda <patrykd@google.com> Commit-Queue: Patryk Duda <patrykd@google.com>
* flash: Move printing information about regions to separate functionPatryk Duda2022-12-222-12/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Printing information about sectors requires information about flash size and number of sectors (or flash_bank_array in case of different sector size) to be defined in CrosEC. When using Zephyr we should use DTS or structures defined in the Zephyr flash driver (through API). Moving code that depends on CrosEC structures/defines will make easier to enable support for variable sector sizes in CrosEC with Zephyr. BUG=b:239712345 BRANCH=none TEST=make buildall -j TEST=Compile bloonchipper firmware and flash it on dragonclaw board. Run 'flashinfo' command. Make sure that the output is correct. LOW_COVERAGE_REASON=This patch only moves prints to a separate function. Coverage is low because we are only testing a case without CONFIG_FLASH_MULTIPLE_REGION enabled. Later commits add tests which will check behaviour with this option enabled, but they will use another printing function (introduced later). I've checked this manually (see TEST above). Signed-off-by: Patryk Duda <pdk@semihalf.com> Change-Id: I5b93a910b9c1c5906da1648a61f00f42e563bf25 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3932161 Reviewed-by: Keith Short <keithshort@chromium.org> Tested-by: Patryk Duda <patrykd@google.com> Commit-Queue: Patryk Duda <patrykd@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Bobby Casey <bobbycasey@google.com>
* TCPMv2: Update PE commentsAbe Levkoy2022-12-221-2/+3
| | | | | | | | | | | | | | | | Add direct spec references for PE_DRS_UFP_DFP_Accept_Swap and PE_DRS_DFP_UFP_Accept_Swap. BUG=none TEST=make buildall BRANCH=none Change-Id: Idadd5201edf1bd065c9edd364249111fd9dcf1bf Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4121102 Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* pujjo:change keyboard backlight PWM frequency to 20k Hztony.tang2022-12-221-1/+1
| | | | | | | | | | | | BUG=b:263449155 BRANCH=none TEST=zmake build pujjo Change-Id: I6c38826b7296c3239323d7c22b8ae6719ef8b0ad Signed-off-by: tony.tang <tony.tang@lcfc.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4117945 Reviewed-by: Andrew McRae <amcrae@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* yaviks: support new battery si03054xlZick Wei2022-12-221-0/+3
| | | | | | | | | | | | BUG=b:244292065 BRANCH=none TEST=verify battery charge/discharge/cut off. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I8a9b0f4cac882c8861c8d883a9b86e6b287d62aa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4113509 Reviewed-by: Andrew McRae <amcrae@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr/battery: add new battery smp si03054xlZick Wei2022-12-222-0/+55
| | | | | | | | | | | | BUG=b:244292065 BRANCH=none TEST=on yaviks, make sure battery charge, discharge, cut off. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Ibab281b0188d58ef9b020e0ce20ece020a49db54 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4113508 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Andrew McRae <amcrae@google.com>
* rt1739: rename `irq` dt prop to `frs_en_gpio`Ting Shen2022-12-222-3/+9
| | | | | | | | | | | | | | | | | | | | | Follow syv682x's convention, and reserve the name `irq` for the real irq pin. Existing devices (Krabby, Geralt) does not define this pin in their device tree, so no code change is required. BUG=none TEST=twister -T zephyr/test BRANCH=none Change-Id: If94be159c5ffd36c4f872e5740c550cf318d9e3f Signed-off-by: Ting Shen <phoenixshen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4117148 Auto-Submit: Ting Shen <phoenixshen@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Reviewed-by: Eric Yilun Lin <yllin@google.com>
* rex: fan: Add fan_init method to check if fan is present from CBIMadhurima Paruchuri2022-12-2112-8/+227
| | | | | | | | | | | | | | | | | | | fan_init method is reading FW_FAN value from CBI and deciding if fan in present for the board. The FW_FAN value is starting at bit 0 and of size 1. FW_FAN start and size values will be updated in future when CBI is used in Rex to make decisions as per information it need to support. BUG=b:244870433 BRANCH=none TEST=zmake build rex --clobber && ./twister -T zephyr/test/rex -i --coverage --clobber Change-Id: I6aa325453dca497d85099617ab20a3ddb9a08ace Signed-off-by: Madhurima Paruchuri <mparuchuri@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4111889 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: bbram: unify bbram access macrosFabio Baltieri2022-12-217-52/+72
| | | | | | | | | | | | | | | | Unify the various bbram check/size/offset macro implementation into a common set of macros, getting rid of DT_PATH usages in the process. BRANCH=none BUG=none TEST=cq dry run TEST=zmake compare-builds -a Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ib698a6c7236d327b761190aeac9d55daa9032a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4114285 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* gaelin: Apply PS8811 tuning parametersBruce Chiang2022-12-211-2/+15
| | | | | | | | | | | | | Applying tuning parameters recommended by retimer vendor. BUG=b:262806983 TEST=i2cxfer to read setting is correct. BRANCH=None Change-Id: I9dcd01c0a77d6d9986642e6aaa0aa195b4a07cfd Signed-off-by: Bruce Chiang <brucechiang@msi.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4087965 Reviewed-by: Derek Huang <derekhuang@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* Zephyr: Ensure NPCX flash write and erase reload watchdogDiana Z2022-12-201-1/+25
| | | | | | | | | | | | | | | | | | | | | | Writing to the flash during EC FW update may take some time, and the AP may be sending these commands frequently. Ensure we've reloaded the watchdog on writes to prevent a watchdog reset in the middle of FW update. Similarly, ensure we reload the watchdog during flash erase as well. Do this once per sector. LOW_COVERAGE_REASON=cros_flash currently has no coverage BRANCH=None BUG=b:261724677 TEST=on skyrim, run "chromeos-firmwareupdate --force" from the OS and ensure it completes successfully Change-Id: Iab5e02929880464e84e6636c00640efc5ce2a668 Signed-off-by: Diana Z <dzigterman@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4118799 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* panic: Publish EC_HOST_EVENT_PANIC on panicRob Barnes2022-12-207-0/+85
| | | | | | | | | | | | | | | | | | | Publish EC_HOST_EVENT_PANIC when a panic occurs. The kernel may use this event to clean up before the system is reset (e.g. sync the drive). This will be a no-op if the kernel doesn't handle it. BUG=b:258195448 BRANCH=None TEST=Observe event in kernel. Pass panic_event unit test. Change-Id: I34b9847778bf17dd113e81158bbbdf999ad2ca33 Signed-off-by: Rob Barnes <robbarnes@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4063818 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: ap_pwrseq: use DT_DRV_COMPAT properlyFabio Baltieri2022-12-205-49/+54
| | | | | | | | | | | | | | | | | Drop the unused DT_DRV_COMPAT to intel_ap_pwrseq and add those to the various signal files and use the proper, more compact, DT_INST_ macro variants. BRANCH=none BUG=none TEST=cq dry run TEST=zmake compare-builds -a Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I4666589e9ac83fcc39b0eb305abda61be7aaf973 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4097134 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Yuval Peress <peress@google.com>
* battery: Avoid read battery when cut off processarthur.lin2022-12-203-3/+52
| | | | | | | | | | | | | | | Avoid read battery data when starting battery cut off process. BUG=b:260684835 BRANCH=none TEST=zmake build -a Change-Id: I739e6c46f79a1455a8dbfdfb2c63a146296c6372 Signed-off-by: arthur.lin <arthur.lin@lcfc.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4096318 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Code-Coverage: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* it8xxx2: add hw sha256Dino Li2022-12-205-1/+149
| | | | | | | | | | | | | | | | | | | IT8XXX2 HW support sha256 calculation, and its calculation is faster than FW. Now, we add it. BUG=b:242474986 b:260762509 BRANCH=none TEST=on nereid and tentacruel enable software sync: EC calculate RW sha256 and the result is same with cr50, then jump to RW. LOW_COVERAGE_REASON=sha256 unit test not yet implemented. Disallow-Recycled-Builds: all Signed-off-by: Dino Li <Dino.Li@ite.com.tw> Signed-off-by: Ruibin Chang <Ruibin.Chang@ite.com.tw> Change-Id: I9060ae1c8f867b8e61ce781e2e14795af7f5636d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4037230 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* Winterhold: enable force buck modejohnwc_yeh2022-12-201-0/+1
| | | | | | | | | | | | | | | Enable force buck mode for isl9238c. BUG=b:257851736 BRANCH=none TEST=check ISL9238C control0 bit1 can set Change-Id: I6edd3d6905338790a063191415f673afa8d2f220 Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4095163 Reviewed-by: Diana Z <dzigterman@chromium.org> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* rex: Disable config smart dischargeLi Feng2022-12-201-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | Disable this config, use the force discharge mode for VBUS. With smart discharge config, fast role swap (FRS) test fails. After FRS, Rex becomes power source. Attached device (previous power source) sends PS_RDY request and Rex wouldn't respond. Attached device sends soft reset/hard reset. Hence disabling config smart discharge. We will enable this config once FRS failure with this config is fixed. BUG=b:241340453 BRANCH=none TEST=on Rex, FRS is working. Signed-off-by: Li Feng <li1.feng@intel.com> Change-Id: Ia60a4ec2fadc2309e41b8f4925c785b8b447cd67 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4072524 Reviewed-by: Scott Collyer <scollyer@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
* corsola: reduce the type-c port count init delay to 500msEric Yilun Lin2022-12-201-2/+2
| | | | | | | | | | | | | | | | | | | | Following chromium:4114047, the fake type-c port count can be set within a shorter timing. The pd_task is spawned around 150ms ~ 180ms after boot, so 500 ms delay should be a safe delay to prevent a failure with a fast kernel upstart. BUG=b:262898170 TEST=reboot EC for 1600 times and no HDMI output errors BRANCH=none Change-Id: I533e316104bfb7c26695bf8c55ad977e59aeba56 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4113632 Auto-Submit: Eric Yilun Lin <yllin@google.com> Commit-Queue: Knox Chiou <knoxchiou@chromium.org> Tested-by: Eric Yilun Lin <yllin@google.com> Code-Coverage: Knox Chiou <knoxchiou@chromium.org> Reviewed-by: Sung-Chi Li <lschyi@chromium.org>
* Winterhold: Change charging currentjohnwc_yeh2022-12-202-0/+23
| | | | | | | | | | | | | | | | | | | | | 1. In S3 and S5, charge current follow battery request. 2. In S0: a) charge current set to 1000mA. b) If battery request lower 1000mA, charge current follow battery request. LOW_COVERAGE_REASON=Skyrim board tests not created yet: b/247151116 BUG=b:257851736 BRANCH=None TEST=Test on winterhold, charge current be change to 1A Change-Id: Iec572b062281d5deab45c6deac1126686692083d Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4091388 Code-Coverage: Diana Z <dzigterman@chromium.org> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* charger/isl9238c: enable force buck modejohnwc_yeh2022-12-205-0/+29
| | | | | | | | | | | | | | | | | Enable force buck mode for isl9238c. LOW_COVERAGE_REASON=No isl9238c emulator BUG=b:257851736 BRANCH=none TEST=check ISL9238C control0 bit1 can set Change-Id: I9be2c2ad5f0c42797548c2e99b231244de30c51c Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4091087 Code-Coverage: Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
* Rex: Get VBUS sourcing state from PPCLi Feng2022-12-205-12/+12
| | | | | | | | | | | | | | | | | | | | | Use ppc_is_sourcing_vbus() to check VBUS sourcing state. On Rex, PPC tells if the Type-C port is sourcing VBUS or not; TCPC doesn't. Update unit test to call ppc to get vbus sourcing information. BUG=b:241340453 BRANCH=none TEST=on Rex, confirm ppc_is_sourcing_vbus() returns correctly. Also in FRS test, board_set_active_charge_port() flow is correct. TEST=./twister -T zephyr/test/rex --clobber Change-Id: I69be9c4df5d598490041a99b809e9b180fecd867 Signed-off-by: Li Feng <li1.feng@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4044053 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Scott Collyer <scollyer@chromium.org>
* PCHG: Print next event in pchg console commandDaisuke Nojiri2022-12-191-7/+17
| | | | | | | | | | | | | | This patch makes 'pchg 0' command print the next pending event. BUG=None BRANCH=None TEST=Redrix Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Change-Id: I75445b21242b6563cf742e5a97ab239da3a816a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4093115 Reviewed-by: Eric Yilun Lin <yllin@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* npcx9: SHA256: Fix the code definition of enum ncl_statusJun Lin2022-12-191-3/+3
| | | | | | | | | | | | | | | | | | | The coding of the enum ncl_status is not correctly defined in the SHA256 chip driver. This CL fixed it to meet the actual return code from the SHA ROM API. BRANCH=none BUG=b:155771688 TEST=manually dump and check the return value from SHA ROM API. Change-Id: Iee3ec5c7102ddc93f7afda6523c59393a5a0047a Signed-off-by: Jun Lin <CHLin56@nuvoton.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4113813 Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Tested-by: CH Lin <chlin56@nuvoton.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* zephyr: ap_power: add adc signal testsFabio Baltieri2022-12-192-2/+120
| | | | | | | | | | | | | | | | | | | Set one of the signal in the power sequencing test devicetree to use intel,ap-pwrseq-adc, add the comparator and adc emulation devices and add a test to specifically run the ADC power sequencing code. BRANCH=none BUG=none TEST=cq dry run TEST=./twister Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ib1a474c0218d3195565fd52d97f0e5c6932f47ab Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4111307 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Peter Marheine <pmarheine@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Andrew McRae <amcrae@google.com>
* zephyr: emul: add a voltage comparator mock driverFabio Baltieri2022-12-195-0/+166
| | | | | | | | | | | | | | | | Add a voltage comparator mock driver, this is meant to initially be used to test the adc power sequencing code. BRANCH=none BUG=none TEST=cq dry run TEST=./twister Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I3e9d9099d265b265486d1c9b9d60e618bb44ff31 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4111306 Reviewed-by: Al Semjonovs <asemjonovs@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: adc: add a dedicated NAMED_ADC_CHANNELS optionFabio Baltieri2022-12-195-12/+13
| | | | | | | | | | | | | | | | | | | | | Add a dedicated NAMED_ADC_CHANNELS option to decouple the platforms setting from the Zephyr ADC one. This allows running tests for code that uses only the Zephyr APIs without having to define named channels as well. Also allows dropping some #if guards that made no sense since they were guarding a data structure used outside of the guard. BRANCH=none BUG=none TEST=cq dry run TEST=zmake compare-builds -a Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I4193a8c41d3bfd684ec03407eee57660aba2c56c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4111644 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Sam Hurst <shurst@google.com>
* zephyr: mock: always include the include directoryFabio Baltieri2022-12-193-17/+23
| | | | | | | | | | | | | | | | | | | | | | | There's multiple emul drivers relying on include files, change the CMake include directive to always add that to the include search path. Fixes a build fail when PWM_MOCK is used but not EMUL_CROS_FLASH. Now though this ends up causing a collision since there's multiple flash_chip.h files in the system, one for every supported chip. Fix that by using a different name when running in NATIVE_POSIX, so that there's no ambiguity. Sort the build list while we are at it. BRANCH=none BUG=none TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I9858ab3ccea2631ff7b3a22ef2d1c79b4dc73b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4111305 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* corsola: bring forward the fake type-c port count init timingEric Yilun Lin2022-12-191-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | Corsola emulates HDMI MUX over the current type-c MUX stack. The EC has to fake a type-c port to pass the MUX info. However, tcpc/pd tasks are not needed for the HDMI port. We want the tasks are not initiated on starting up, and increase the type-c port counts after the tasks are launched. However, on the normal image, the kernel uptime is much faster than on the test image. There is a chance that the cros-ec-typec getting the actual type-c port counts from board_get_usb_pd_port_count(), before we are able to fake it, and this will block the HDMI mux function. BUG=b:262898170 TEST=reboot EC for 1900 times and no HDMI output errors BRANCH=none Change-Id: I8628c456c55ede796973ecbd6c720e2b2ac7d175 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4114047 Reviewed-by: Sung-Chi Li <lschyi@chromium.org> Code-Coverage: Sung-Chi Li <lschyi@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Auto-Submit: Eric Yilun Lin <yllin@google.com> Tested-by: Mike Lee <mike5@huaqin.corp-partner.google.com>
* gladios: Update fw_config for gladiosHank.Xie2022-12-192-24/+28
| | | | | | | | | | | | | | | | Update fw_config to meet gladios's fw_config table. BUG=b:243859089 BRANCH=none TEST=make BOARD=gladios Change-Id: I0e1299330841b982f43a18f3b01a00bbdd9109c6 Signed-off-by: Hank.Xie <hank.xie@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4060803 Commit-Queue: Ricky Chang <rickytlchang@chromium.org> Reviewed-by: Ricky Chang <rickytlchang@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Devin Lu <devin.lu@quantatw.com>
* gladios: Update board config for gladiosHank.Xie2022-12-199-530/+99
| | | | | | | | | | | | | | | | | | | | | Update all configs to meet gladios's board: 1. Update USBC related config (including switching from 3 ports to 1 port, changing TCPC/USBC mux to RT1715/PS8818, removing TBT) 2. Update I2C ports 3. Update gpio config 4. Remove peripheral charger BUG=b:239513596 BRANCH=none TEST=make BOARD=gladios Signed-off-by: Hank.Xie <hank.xie@quanta.corp-partner.google.com> Change-Id: Ie208196c78396c54df7721f1022d2850bac9f9cf Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4060802 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Devin Lu <devin.lu@quantatw.com> Reviewed-by: Ricky Chang <rickytlchang@chromium.org> Commit-Queue: Ricky Chang <rickytlchang@chromium.org>
View Lorry Controller Status