summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* elemi: Enable keyboard backlightstabilize-rust-13562.B-masterDevin Lu2020-10-292-0/+13
| | | | | | | | | | | | BUG=b:169409487 BRANCH=firmware-volteer-13521.B-master TEST=make sure ec console kblight can adjust keyboard backlight brightness. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: Ifbb31e76dec8b595e13717b382eef229b9dd934c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2491582 Reviewed-by: Keith Short <keithshort@chromium.org>
* elemi: Remove unused board rev 0 configurationDevin Lu2020-10-292-23/+3
| | | | | | | | | | | BUG=b:169409487 BRANCH=firmware-volteer-13521.B-master TEST=Make sure TCPC C1 port initial passed. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: Ib989947f14feccb0ef4eaad8a2fa5556a4061fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2491585 Reviewed-by: Keith Short <keithshort@chromium.org>
* elemi: Add batteries configurationDevin Lu2020-10-292-24/+51
| | | | | | | | | | | | | | | | Add batteries configuration as following: 1. Simplo 996QA193H 2. Cosmx CA407792G BUG=b:169409487 BRANCH=firmware-volteer-13521.B-master TEST=make sure battery charging, battery cutoff works. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: I637b3bf1ea3faa5a7283de80ab9cffb196264c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2484114 Reviewed-by: Keith Short <keithshort@chromium.org>
* elemi: Implement LED behaviorDevin Lu2020-10-294-117/+173
| | | | | | | | | | | | | | | | | | | | | | | | | | Elemi have two charging leds on left side and right side. Each side have two colors amber and white. The led behavior define as following: 1. Charging led: led on with charging port active, other port is off. 2. Charging: Amber. 3. Discharging: Off. 4. Battery Error: Blinking white (0.4 sec on, 0.4 sec off) 5. Fuel < 10%: Blinking white on right side port (1 sec on, 1 sec off) 6. Force idle for factory: Blinking amber (1 sec on, 1 sec off) 7. S0ix without charging state: Blinking both side LED white (1 sec on, 1 sec off) BUG=b:169409487 BRANCH=firmware-volteer-13521.B-master TEST=make sure led behavior intended. make sure ectool led left white/amber/off/auto work correctly. make sure ectool led right white/amber/off/auto work correctly. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: I9e4837ddbf300ec7a6c0e0dc8660dc157f9228aa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2484115 Reviewed-by: Keith Short <keithshort@chromium.org>
* genvif: update Is_Alt_Mode_Controller and SOP*_CapableDenis Brockus2020-10-291-5/+4
| | | | | | | | | | | | | | | | | Fix settings for Type_C_Is_Alt_Mode_Controller and SOP_P_Capable, SOP_PP_Capable BUG=b:170646602 BRANCH=none TEST=verify vif file output of genvif Signed-off-by: Denis Brockus <dbrockus@google.com> Change-Id: I933d6e19e144908a04fe2562490aabb8271a208b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2506423 Tested-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Auto-Submit: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* SM5803: Only run inits once per EC bootDiana Z2020-10-281-0/+41
| | | | | | | | | | | | | | | | | | Ensure the SM5803 inits are run only once per EC boot. This will prevent the EC from re-running the init sequence if it is sysjumping (ex. due to an EC flash). BRANCH=None BUG=b:168169691 TEST=on drawlat, unplug battery and verify running a sysjump with the AP on doesn't brown out during init (instead, it browns out later when a hard reset is sent). Verify EC resets do result in inits being run again. Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I700aabd51b45e2aff459f787c13978c6212026f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2493110 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* adlprvp: add Alderlake RVP supportPoornima Tom2020-10-2812-1/+1018
| | | | | | | | | | | | | | | | | | | | | | | Following features are enabled and verified. 1. Power sequencing 2. Host communication 3. USB TYPE-C - TCPC over PD AIC 4. H1 Close Case Debug 5. LED 6. Keyboard BRANCH=None BUG=b:169551130 TEST=Build, flash and boot the Alderlake RVP platform to OS make BOARD=adlrvpp_ite -j; sudo util/flash_ec --board=adlrvpp_ite --image=<path> Signed-off-by: Poornima Tom <poornima.tom@intel.com> Change-Id: I9d85e0cb93bc94f042f902b73ebd96a354d0f365 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2435177 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Sooraj Govindan <sooraj.govindan@intel.corp-partner.google.com> Reviewed-by: caveh jalali <caveh@chromium.org>
* usb_pd: Redo the change of DP alt-mode eventWai-Hong Tam2020-10-281-12/+4
| | | | | | | | | | | | | | | | | | | | | | The CL:1685787 changed the DP alt-mode event from the host event MODE_CHANGE to the MKBP event EC_MKBP_EVENT_DP_ALT_MODE_ENTERED. Later a refactoring CL:2132871 merged the logic of TCPMv1 and TCPMv2 stacks and accidentally changed it back to MODE_CHANGE. As TCPMv2 still used the old event. This CL redoes the first CL to use the MKBP event EC_MKBP_EVENT_DP_ALT_MODE_ENTERED. BRANCH=None BUG=chromium:786721, b:170893877 TEST=Triggered HPD L->H event in S3 and checked the new MKBP event is sent. Change-Id: I5a8f35d40ad8e724841c771738c01a381e163250 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2504476 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* genvif: Update VIF generator to v3.0.0.1+Denis Brockus2020-10-282-105/+557
| | | | | | | | | | | | | | | | | | | | | | | Some additional comment tag output was added for PDO values. Changed BC_1_2_Support to be an int instead of boolean. Added xml tag at the beginning. Added some additional fields needed for customer request. Added a comment of the structure fields that are not yet being initialized. BUG=b:170646602,b:171887601 BRANCH=none TEST=verify generated VIF files Signed-off-by: Denis Brockus <dbrockus@google.com> Change-Id: Iaf36eaa8410d50ece3c6a4bff88ab4fcab4e4c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2503493 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Auto-Submit: Denis Brockus <dbrockus@chromium.org>
* FUSB302:Implement SOP' & SOP'' in transmit functionPoornima Tom2020-10-281-0/+24
| | | | | | | | | | | | | | | | Implementation of correct tokens to be transmitted by the driver, when SOP'/SOP'' is the transmit type. This is required to establish proper communication with electronically marked cables. BRANCH=None BUG=b:171380594 TEST=Tested on ADL-RVP Signed-off-by: Poornima Tom <poornima.tom@intel.com> Change-Id: Ibd714425c2b7a63b9ba68ea92f1eaab5bd6a2e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2490683 Reviewed-by: Keith Short <keithshort@chromium.org>
* woomax: Implement EC fan control tableMichael5 Chen2020-10-284-10/+152
| | | | | | | | | | | | | | Implement EC fan control table by thermal request. BUG=b:171025573 BRANCH=firmware-zork-13434.B TEST=make BOARD=woomax Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com> Change-Id: Iafdea26ecc9f27092df92634f7d89a9b4ce8d7db Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2491940 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* test: support building base32 as a Zephyr testPaul Fagerburg2020-10-285-38/+230
| | | | | | | | | | | | | | | | With the Ztest API supported now, add the files to build the base32 unit test as a Zephyr test (instead of an EC test). BUG=b:168032590 BRANCH=None TEST=follow instructions in docs/ztest.md to build as a Zephyr test Signed-off-by: Paul Fagerburg <pfagerburg@google.com> Change-Id: I06dd7864f2de48aab5776950d4840f81728137f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2500465 Tested-by: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: Paul Fagerburg <pfagerburg@chromium.org>
* COIL: Re-name to TCPCI_I2C_PERIPHERALDiana Z2020-10-282-9/+12
| | | | | | | | | | | | | Boards which don't use a TCPM will define TCPCI_I2C_PERIPHERAL. BRANCH=None BUG=None TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: If93e533e059888e8ad5166b29c37bc2243f46947 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2481940 Reviewed-by: Jett Rink <jettrink@chromium.org>
* ps874x: fix incorrect parameter name in ps874x_tune_usb_eqTing Shen2020-10-285-7/+5
| | | | | | | | | | | | | | | | | | | First parameter was incorrectly named 'i2c_addr' in header file, but it's actually a 'port' in the implementation. Change the parameter to a usb_mux* to avoid confusion, and also align with other functions. BUG=b:170703310 TEST=make BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: Ic355b5fd03536423af841be731a93c818d87eb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2504973 Reviewed-by: Eric Yilun Lin <yllin@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* it83xx/spi: clean up unnecessary configurationtim2020-10-282-76/+36
| | | | | | | | | | | | | | | Rx valid length interrupt has been set as default, so the configuration of IT83XX_SPI_RX_VALID_INT can be removed. BUG=none BRANCH=none TEST=Boot to kernel on HAYATO and no error on the transaction of host command with EC. Change-Id: I92ab78b3e821f566053c816f51bf609394f3b199 Signed-off-by: tim <tim2.lin@ite.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2497366 Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
* it83xx: add support for IT81202BX and IT81302BXDino Li2020-10-281-2/+4
| | | | | | | | | | | | | | | | | | | | This CL applies A version's configurations to B version. They have the same HW except for new added function (eg. SPI emulate eMMC "Alternative Boot Mode") on B version. We can add new chip config option for B version in other CL if needed. BUG=none BRANCH=none TEST=Building asurada's EC image with selecting BX chip variant. Flashing the image into reworked asurada (change EC to IT81202BX) and boot to kernel. Signed-off-by: Dino Li <Dino.Li@ite.com.tw> Change-Id: I796a622df21842998ad8f808bfa189b924710649 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2501802 Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
* ec: unblock Zephyr's "native_posix"Paul Fagerburg2020-10-281-1/+4
| | | | | | | | | | | | | | | | | | Zephyr uses the "native_posix" target, which gets flagged by the inclusive language filter. Unblock this specific usage. BUG=None BRANCH=None TEST=Upload this CL without getting flagged Signed-off-by: Paul Fagerburg <pfagerburg@google.com> Change-Id: I7aa52e96262c3f1ea07dc299fb6d73a88c73f1dc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2504472 Tested-by: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Commit-Queue: Paul Fagerburg <pfagerburg@chromium.org> Auto-Submit: Paul Fagerburg <pfagerburg@chromium.org>
* tests: fix include for Zephyr ztestPaul Fagerburg2020-10-281-1/+1
| | | | | | | | | | | | | | | | | A test written for the Zephyr Ztest API needs to include ztest.h, not just ztest_assert.h BUG=b:168032590 BRANCH=None TEST=build base32 unit test for Zephyr Ztest target Signed-off-by: Paul Fagerburg <pfagerburg@google.com> Change-Id: Ib4558e724614d9684294e6f2b670942d1f0c82d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2504471 Tested-by: Paul Fagerburg <pfagerburg@chromium.org> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Auto-Submit: Paul Fagerburg <pfagerburg@chromium.org>
* zephyr: fix build breakageJack Rosenthal2020-10-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | We weren't including a header which defined _CONCAT from this file, so it's hit or miss whether the right headers were included before this one. Change to DT_CAT, which does the same thing and is already in devicetree.h. BUG=b:171820560 BRANCH=none TEST=compile for volteer: zmake configure -B ~/volteer-build projects/experimental/volteer zmake build ~/volteer-build Change-Id: Ice319bf3af32e5805fd8933dba9a72dc6c1affff Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2503786 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* woomax: Change OPT3 USB HPD from TCPC1 GPIO02 to EC GPIOB1.Michael5 Chen2020-10-273-7/+28
| | | | | | | | | | | | | | For board version 2, the OPT3 USB HPD change to EC GPIOB1. BUG=b:160579667 BRANCH=firmware-zork-13434.B TEST=make BOARD=woomax Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com> Change-Id: Ic7ea0d02bd8942779138402155e9941f36c6d9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2494601 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* asurada: remove declaration of EC_RST_ODLDino Li2020-10-271-3/+0
| | | | | | | | | | | | | | | | The EC_RST_ODL was connected to EC's pin L1 (WRST#) not GPIO L1. And on IT81202 (128-pin package), GPL1 isn't bonding with pad. This declaration will cause leakage current internally. Let's remove it. BUG=none BRANCH=none TEST=build and flash asurada,check that GPL1's setting is pulldown. Signed-off-by: Dino Li <Dino.Li@ite.com.tw> Change-Id: Ia98d28221835ea4a082a041fe78359e0cf189579 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2501804 Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* tree: Use new atomic_* implementationDawid Niedzwiecki2020-10-2751-275/+221
| | | | | | | | | | | | | | | | | | | | | | | It is done as a part of porting to Zephyr. Since the implementation of atomic functions is done for all architectures use atomic_* instead of deprecated_atomic_*. Sometimes there was a compilation error "discards 'volatile' qualifier" due to dropping "volatile" in the argument of the functions, thus some pointers casts need to be made. It shouldn't cause any issues, because we are sure about generated asm (store operation will be performed). BUG=b:169151160 BRANCH=none TEST=buildall Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: I98f590c323c3af52035e62825e8acfa358e0805a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2478949 Tested-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* asurada: ps8743: set Rx EQ to 12.8dBTing Shen2020-10-271-0/+9
| | | | | | | | | | | | | BUG=b:170703310 TEST=pass usb compliance test BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: Ieb226da91643b8bebf6eb49241c01be612f714f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2493797 Reviewed-by: Eric Yilun Lin <yllin@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* core/nds32: to avoid race conditiontim2020-10-271-3/+12
| | | | | | | | | | | | | | | | | | | | | After the program to line 628(original program), we have determined that the local variable of waiter is 0 because a task is getting the mutex lock then clearing waiter to 0(line 608). If another task enters mutex lock at this time, mtx->waiters will be written to 1 and go to sleep waiting, but the local variable of waiter is still 0. This will cause latter task which cannot be woke up when previous task leaves the mutex unlock. BUG=none BRANCH=none TEST=create two tasks and respectively access mutex_lock and mutex_unlock. There would not happen that latter task cannot be woke up when previous task leaves the mutex unlock. Change-Id: I566a14c1120716af8e9ac99e183a989274a4e72e Signed-off-by: tim <tim2.lin@ite.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2438084 Reviewed-by: Jett Rink <jettrink@chromium.org>
* Ambassador: Initial EC image.Matt Ziegelbaum2020-10-277-0/+1789
| | | | | | | | | | | | | | | | Create the initial EC image for Ambassador by copying the Puff reference board EC files into a new directory named for ambassador. BUG=b:171561264 TEST=buildall BRANCH=none Signed-off-by: Matthew Ziegelbaum <ziegs@google.com> Change-Id: I28b2de23afb9227be7e39f232b45a43a47a4b1d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2499782 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Matthew Ziegelbaum <ziegs@chromium.org> Tested-by: Matthew Ziegelbaum <ziegs@chromium.org>
* genvif: Update VIF generator to v3.0.0.1+Denis Brockus2020-10-262-810/+1412
| | | | | | | | | | | | | | | | | | | This upgrade gives a generator that produces the latest spec's XML output. More work can be done on this to produce more complete VIF files, but this is a good starting point. BUG=b:170646602 BRANCH=none TEST=verify generated VIF files Signed-off-by: Denis Brockus <dbrockus@google.com> Change-Id: Ie7a3c174a5e433c04dc168a39857cc2fcb6c28ee Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2497612 Tested-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: Jett Rink <jettrink@chromium.org> Auto-Submit: Denis Brockus <dbrockus@chromium.org>
* Only shim system.c if the cros_ec is usedYuval Peress2020-10-261-1/+1
| | | | | | | | | | | | BRANCH=none BUG=none TEST=built volteer and unit tests Change-Id: Ieedf0ffbe3137f8f6d2d7569d13ee7bff615f428 Signed-off-by: Yuval Peress <peress@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2499414 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Commit-Queue: Paul Fagerburg <pfagerburg@chromium.org>
* zephyr: include config.h before ec_commands.hPaul Fagerburg2020-10-261-0/+1
| | | | | | | | | | | | | | | | | Fixed a compiler warning for multiple definitions of BUILD_ASSERT. BUG=None BRANCH=None TEST=build, see that the warning about BUILD_ASSERT is gone. Signed-off-by: Paul Fagerburg <pfagerburg@google.com> Change-Id: I97ed721fc3a28bc29b985e335fbd223cac28eb1c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2499501 Tested-by: Paul Fagerburg <pfagerburg@chromium.org> Auto-Submit: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Yuval Peress <peress@chromium.org> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
* IO-expander: Add driver support for PCA9675Name2020-10-264-1/+172
| | | | | | | | | | | | | BRANCH=None BUG=b:169551130 TEST=make buildall -j Change-Id: If565996850c5c75f3d425e2dc7f705b624ad4cc4 Signed-off-by: pandeyan <anshuman.pandey@intel.com> Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2435172 Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: Poornima Tom <poornima.tom@intel.com>
* features: Define AP-driven mode entryAbe Levkoy2020-10-263-0/+10
| | | | | | | | | | | | | | Add EC_FEATURE_TYPEC_REQURE_AP_MODE_ENTRY. BUG=b:168030639 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I413abdfb123b3b7119fa1862b018557de81c2cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2411181 Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Diana Z <dzigterman@chromium.org>
* voxel: add Lid operates in forced modeBen Chen2020-10-261-0/+2
| | | | | | | | | | | | | | | | add define Lid force mode mask BUG=b:162940877,b:171009897 BRANCH=none TEST=Using ectool 'motionsense' verified lid angle now goes from 0 to 360 and swtiches to tablet mode after crossing 200 threshold. Change-Id: I04679d770ab8bcdf84bfd5b2b742feacdd53a743 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2477402 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* syv682x: disable smart discharge modeEric Yilun Lin2020-10-261-11/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This config was enabled on CL:2051311. However, with SDSG enabled, the i2c transactions will be blocked until channel transition finished and this takes above 50ms. The extra 50ms stops us from disabling Vconn if we unplug a SNK device which violates tVconnOff timer (35ms). This CL reverts CL:2051311, and control VBUS discharge by EC, and reduce the Vconn off time to 20ms. BUG=b:160548079, b:148870148, b:163143427 TEST=on asurada, and volteer: tested that 1. vbus is discharged within tVbussOff(650ms) when unplug a SNK device. 2. Vconn is off within tVconnOff(35ms) when unplug a SNK device 3. able to source/sink normally across plug/unplug SRC/SNK/DRP devices. 4. discharge FET is disabled when a SRC device is connected. 5. Plug two adapters respectively, and see syv682x's discharge FET are turned off for both ports. BRANCH=none Change-Id: I656c0a912b4196846de03adf2100dbb6dd89e899 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2423665 Tested-by: Keith Short <keithshort@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* Zork: Increase delay for hibernate on ACstabilize-rust-13555.B-masterEdward Hill2020-10-241-1/+1
| | | | | | | | | | | | | | | 300ms was not long enough to complete PD re-negotiation to 5V. This caused hibernate on AC to immediately wake back up. Increase delay to 900ms so we remain hibernated. BUG=b:170845706 BRANCH=zork TEST=hibernate on AC Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Ia56d74a3e84f19f936d7b48a9ee9c6df609affdf Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2494991 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* Trogdor: Do not activate g-sensors in S5Wai-Hong Tam2020-10-234-8/+8
| | | | | | | | | | | | | | | | | The g-sensors are not necessary to be active in S5; no gesture recognition in Trogdor designs. Do not activate it in S5. Though without this change, EC doesn't read the g-sensors as there is no config (zero odr) for S5. BRANCH=None BUG=b:170288119 TEST=Still read the g-sensors on S0 and S3. Change-Id: I54e8012e2674e13273e5fe9b96e9e9e6086e6490 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2492529 Reviewed-by: Stephen Boyd <swboyd@chromium.org>
* Lazor: Enable g-sensors in S3 for lid angle detectionWai-Hong Tam2020-10-231-3/+8
| | | | | | | | | | | | | | | | The mode change (tablet vs laptop mode) is a wake source from S3. Changing the lid angle triggers the mode change. Both the lid and the base g-sensors should be active in S3 for lid angle detection. BRANCH=None BUG=b:155853349 TEST=Made the device in S3, checked the reported lid angle by rotating the device and fliping the lid. Change-Id: I6351df11fc328476428f3aaa6cf9222fc2ffc391 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2492520 Reviewed-by: Stephen Boyd <swboyd@chromium.org>
* zephyr: add gpio interrupts to shimJett Rink2020-10-231-2/+78
| | | | | | | | | | | | | | | | | | | Allow each zephyr project to define the EC_CROS_GPIO_INTERRUPTS item in their gpio_map.h file to register existing platform/ec gpio irq handlers. Unfortunately this cannot go in the device tree file since the device tree does not support function pointers as a data type. BRANCH=none BUG=b:169935802 TEST=hooked up power button GPIO to platform/ec-based gpio irq Signed-off-by: Jett Rink <jettrink@chromium.org> Change-Id: I65d03fed413b270aeae502ad4267b1091582bd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2494725 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org>
* cleanup: update comment formattingJett Rink2020-10-231-6/+11
| | | | | | | | | | | | | | Put comments on a newline above fields to allow for longer comments in this file. BRANCH=none BUG=none TEST=none Signed-off-by: Jett Rink <jettrink@chromium.org> Change-Id: I89740558e7bb508f7a213cd6817ae91ad9b6f5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2495137 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* volteer: Fix spellingAbe Levkoy2020-10-231-1/+1
| | | | | | | | | | | | | | Tempurature -> temperature BUG=none TEST=make buildall BRANCH=none Change-Id: I3d8e307a572ad19b277222e9360d88b3ab94f04f Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2493414 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* voxel: Configure temperature sensorsAbe Levkoy2020-10-231-0/+3
| | | | | | | | | | | | | | Enable the ADC alternate function to reduce power usage. BUG=b:155882590 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: If5ec0c0a85cc300b2ede3187415c297e2874d438 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2493413 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* trondo: Configure temperature sensorsAbe Levkoy2020-10-231-0/+3
| | | | | | | | | | | | | | Enable the ADC alternate function to reduce power usage. BUG=b:155882590 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I15b95ce91a665efba1c2515742094a3295e6cd79 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2493412 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* todor: Configure temperature sensorsAbe Levkoy2020-10-231-0/+3
| | | | | | | | | | | | | | Enable the ADC alternate function to reduce power usage. BUG=b:155882590 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: Iff02572f02996ba2d136f0d3864e33c526dfcfa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2493411 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* terrador: Configure temperature sensorsAbe Levkoy2020-10-231-0/+3
| | | | | | | | | | | | | | Enable the ADC alternate function to reduce power usage. BUG=b:155882590 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I813868e9380dc1a1c20a3425cd198ab568becf53 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2493410 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* malefor: Configure temperature sensorsAbe Levkoy2020-10-231-0/+3
| | | | | | | | | | | | | | Enable the ADC alternate function to reduce power usage. BUG=b:155882590 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I09dd88d28ce15ea807bf68c2041621a89f4ad79b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2493409 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* lingcod: Configure temperature sensorsAbe Levkoy2020-10-231-0/+3
| | | | | | | | | | | | | | Enable the ADC alternate function to reduce power usage. BUG=b:155882590 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: If63b468efcade5b882ef7904b2c11305be016f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2493408 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* lindar: Configure temperature sensorsAbe Levkoy2020-10-231-0/+4
| | | | | | | | | | | | | | Enable the ADC alternate function to reduce power usage. BUG=b:155882590 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I65d2b2cd353fdb7d082971848f21ec53f556a5ca Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2493407 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* halvor: Configure temperature sensorsAbe Levkoy2020-10-231-0/+3
| | | | | | | | | | | | | | Enable the ADC alternate function to reduce power usage. BUG=b:155882590 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: Iafb169df1b50b0331f87dafab9438b46e109d385 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2493406 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* elemi: Configure temperature sensorsAbe Levkoy2020-10-231-0/+3
| | | | | | | | | | | | | | Enable the ADC alternate function to reduce power usage. BUG=b:155882590 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I2d76a8478bbe4fc7b1d4960edc29a7cede16cfdc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2493405 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* eldrid: Configure temperature sensorsAbe Levkoy2020-10-231-0/+3
| | | | | | | | | | | | | | Enable the ADC alternate function to reduce power usage. BUG=b:155882590 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: Ia5a980247182a6eb076a477b8f99111cc6c89ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2493404 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* delbin: Configure temperature sensorsAbe Levkoy2020-10-231-0/+3
| | | | | | | | | | | | | | Enable the ADC alternate function to reduce power usage. BUG=b:155882590 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I034f4027c11b6be03533fe216df58f8391dc3e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2493403 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* boldar: Configure temperature sensorsAbe Levkoy2020-10-231-0/+3
| | | | | | | | | | | | | | Enable the ADC alternate function to reduce power usage. BUG=b:155882590 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I29ce0b79c7165212d7089eb4f459c16587204b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2493402 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
View Lorry Controller Status