summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* cr50_rma_open: update for new open requirementsMary Ruthven2018-08-021-13/+71
| | | | | | | | | | | | | | | | | | | | Cr50 can only be opened from the AP and the device has to be in dev mode before open can be run. Update cr50_rma_open to require dev mode and run ccd open from the AP. 0.3.9 will have ccd in the prod image. Update the script, so it can enable testlab mode on prod images. BUG=none BRANCH=none TEST=run rma open process with 0.4.9 Change-Id: If14851a274233b471f8de86c9ed2a2b4808d131b Signed-off-by: Mary Ruthven <mruthven@google.com> Reviewed-on: https://chromium-review.googlesource.com/1157182 Commit-Ready: Mary Ruthven <mruthven@chromium.org> Tested-by: Mary Ruthven <mruthven@chromium.org> Reviewed-by: Mary Ruthven <mruthven@chromium.org>
* it83xx: Enable USB module's clock before set USB control registerDino Li2018-08-011-0/+7
| | | | | | | | | | | | | | | | | | | | symptom: On bip, the PPC's INT pin is always asserted after we do a EC reboot command. This is because the setting of clock gating control register will not be reset with a EC reboot command. Clock gating control register only resets by EC's WRST# pin BUG=b:111006203, b:110237505 BRANCH=none TEST=The PPC's INT pin is deasserted after EC reboot command. Change-Id: Icf62d5fb32c0d1d25aea03b7bfbcb032a60f31a1 Signed-off-by: Dino Li <Dino.Li@ite.com.tw> Reviewed-on: https://chromium-review.googlesource.com/1154855 Reviewed-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* octopus: Refactor power LED codeDiana Z2018-08-014-51/+96
| | | | | | | | | | | | | | | | | | | | | | | The upcoming work to implement the fleex power LED will require slightly different power LED behavior, so this refactors the power LED code to be more flexible. This change also sets the phaser power LED GPIO name to something more clear, and protects the code from a possible divide-by-zero condition which can be hit with undefined states. Currently, there will be prints 4 times per second that the board is in the undefined state, which should draw a developer's attention to the issue. BRANCH=None BUG=None TEST=verified power LED behaved the same on phaser in all different power states, verified that removing a state's entry in the table results in an error print to the console in that state Change-Id: I58733008e5e49d1e631d79a8631d2ca04127bd08 Signed-off-by: Diana Z <dzigterman@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1156872 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* cr50: enable RSA speedup for dcryptoAndrey Pronin2018-08-011-1/+2
| | | | | | | | | | | | | | | | Turn on CONFIG_DCRYPTO_RSA_SPEEDUP for cr50. Speeds up RSA2048 keygen by ~40%. Adds 2192 bytes to the code size. BRANCH=cr50 BUG=b:68167013 TEST=boot, login, run "trunks_client --key_create --rsa=2048 --usage=sign --key_blob=/tmp/1.key --print_time" to measure time. Change-Id: I647b17a7e16c4a74b6e55717c75fb44f332b2a54 Signed-off-by: Andrey Pronin <apronin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1159164 Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
* common/ec_ec_comm_slave: initialize seqPatrick Georgi2018-08-011-1/+1
| | | | | | | | | | Change-Id: Ibf196528fa8e16ec9bcd51151d0397f38c302d08 Signed-off-by: Patrick Georgi <pgeorgi@google.com> Found-by: Coverity Scan #182319 Reviewed-on: https://chromium-review.googlesource.com/1158564 Commit-Ready: Patrick Georgi <pgeorgi@chromium.org> Tested-by: Patrick Georgi <pgeorgi@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* common/spi_flash: don't mix up unsigned and signed typesPatrick Georgi2018-08-011-6/+6
| | | | | | | | | | Change-Id: Ib06fd16ddbe6455b0f194ee4b6c6f1c1bc8f3adc Signed-off-by: Patrick Georgi <pgeorgi@google.com> Found-by: Coverity Scan #142081, #142083 Reviewed-on: https://chromium-review.googlesource.com/1158505 Commit-Ready: Patrick Georgi <pgeorgi@chromium.org> Tested-by: Patrick Georgi <pgeorgi@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* board/twinkie: fix potential array overflowPatrick Georgi2018-08-011-1/+1
| | | | | | | | | | Change-Id: I83aaedcf82d38a5a2ed596b37a224cc0175619cb Signed-off-by: Patrick Georgi <pgeorgi@google.com> Found-by: Coverity Scan #157525 Reviewed-on: https://chromium-review.googlesource.com/1158414 Commit-Ready: Patrick Georgi <pgeorgi@chromium.org> Tested-by: Patrick Georgi <pgeorgi@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* chip/mec1322: properly compare timestampsPatrick Georgi2018-08-011-1/+1
| | | | | | | | | | | | (uint32_t)(uint32_t - uint32_t) >= 0 is always true. Change-Id: I95343379ed76e6ea338e95600006867a1835943a Signed-off-by: Patrick Georgi <pgeorgi@google.com> Found-by: Coverity Scan #142090 Reviewed-on: https://chromium-review.googlesource.com/1158413 Commit-Ready: Patrick Georgi <pgeorgi@chromium.org> Tested-by: Patrick Georgi <pgeorgi@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* charger/mt6370: Init charger IRQs.Yilun Lin2018-08-013-4/+28
| | | | | | | | | | | | | | | | | Init all the mt6370 charger IRQs. We masked out all the other IRQs except VBUS detach/attach interrupts. Also, fix GPIO typo in CHARGER_INT_ODL, it should be GPIO_INT_FALLING. TEST=make flash_ec BOARD=kukui; check gpioget CHARGER_INT_ODL = 1 BUG=b:110241788 BRANCH=None Change-Id: I57beec78d74598d161c66f25ee149b3044d020ad Signed-off-by: Yilun Lin <yllin@google.com> Reviewed-on: https://chromium-review.googlesource.com/1157726 Commit-Ready: Yilun Lin <yllin@chromium.org> Tested-by: Yilun Lin <yllin@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
* eve: Delay charge port selection until VBUS is stable or 1s has passedSam Hurst2018-08-013-0/+125
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a charge port is selected and VBUS is 5V, the inrush current causes VBUS to droop which could signal a sink disconnection. To mitigate this problem, charge port selection is delayed until VBUS is stable or 1s has passed. Before 1s has passed, PD will hopefully have negotiated a VBUS voltage of at least 9V. This CL is also a workaround for the issue outlined in b:74753447 Signed-off-by: Sam Hurst <shurst@chromium.org> BUG=b:69439094 BRANCH=None TEST=`make -j buildall` Manual tested with Belkin Express Dock and Moshi audio adapter. Test Belkin with following configuration: PORT0: PORT1: Belkin OPEN OPEN Belkin Belkin Blackcat Blackcat Belkin Belkin EC terminal output: Port 0: [654.645288 TCPC p0 Exit Low Power Mode] C0 st14 C0 st15 C0 st17 C0 st18 C0 st19 Requested 5000 V 3000 mA (for 900/900 mA) C0 st20 C0 st21 C0 st22 C0 st23 C0 st24 C0 st23 C0 st26 C0 st27 C0 st28 C0 st29 [655.375668 New chg p0] C0 st5 [655.380708 Ramp reset: st1] [655.381704 CL: p0 s8 i500 v5000] [655.392598 New chg p0] [655.393574 Ramp reset: st1] [655.394504 CL: p0 s2 i3000 v5000] C0 Req [4] 15000mV 3000mA [655.512126 New chg p0] [655.514456 Ramp reset: st1] C0 st715219 CL: p0 s0 ] C0 st8 [655.639762 Ramp reset: st1] [655.640301 CL: p0 s0 i3000 v15000] [656.688735 AC on] [657.385539 Ramp p0 st5 3000mA 3000mA] [657.471108 Battery 70% / 7h:36 to empty] [659.721858 charge_request(8800mV, 5376mA)] [660.973258 charge_request(8800mV, 3712mA)] [697.506594 Battery 71% / 1h:1 to full] Port 1: [729.384242 TCPC p1 Exit Low Power Mode] C1 st2 C1 st3 C1 st14 C1 st15 C1 st17 C1 st18 C1 st19 Requested 5000 V 3000 mA (for 900/900 mA) C1 st20 C1 st21 C1 st22 C1 st23 C1 st24 C1 st23 C1 st26 C1 st27 C1 st28 C1 st29 [730.339719 New chg p1] [730.340602 Ramp reset: st1] [C1 st5 730.341457 CL: p1 s8 i500 v5000] [730.356552 New chg p1] [730.357311 Ramp reset: st1] [730.358095 CL: p1 s2 i3000 v5000] C1 Req [4] 15000mV 3000mA [730.478577 New chg p1] [730.480986 Ramp reset: st1] [730.481829 CL:Cp1 s0 i500 v15] C1 st8 [730.607116 Ramp reset: st1] [730.607813 CL: p1 s0 i3000 v15000] [731.654877 AC on] [732.345420 Ramp p1 st5 3000mA 3000mA] [732.589802 Battery 71% / 10h:28 to empty] [734.340030 charge_request(8800mV, 5376mA)] [735.091263 charge_request(8800mV, 3712mA)] [767.879314 Battery 72% / 1h:1 to full] Tested Moshi with followint configuration: Port0: Port1: Moshi-pwr OPEN OPEN Moshi-pwr Moshi-pwr Blackcat Blackcat Moshi-pwr Moshi-audio OPEN OPEN Moshi-audio Moshi-audio Blackcat Blackcat Moshi-pwr Moshi-pwr-audio OPEN OPEN Moshi-pwr-audio Moshi-pwr-audio Blackcat Blackcat Moshi-pwr-audio Moshi EC terminal output: [2330.883267 TCPC p0 Low Power Mode] [2330.883664 TCPC p0 reset!] [2330.916049 TCPC p0 Low Power Mode] [2330.916475 TCPC p0 reset!] [2330.934010 TCPC p0 Exit Low Power Mode] C0 st14 C0 st15 C0 st17 C0 st18 C0 st19 Requested 5000 V 3000 mA (for 3000/3000 mA) C0 st20 C0 st21 C0 st22 C0 st23 C0 st24 C0 st23 C0 st26 C0 st23 C0 st27 C0 st28 C0 st29 [2332.398132 New chg p0] [2332.398883 Ramp reset: st1] [2332.399745 CL: p0 s8 i500 v5000] C0 st5 [2332.476132 New chg p0] [2332.476933 Ramp reset: st1] [2332.477705 CL: p0 s2 i3000 v5000] C0 Req [4] 15000mV 2970mA [2332.493597 New cCg p0C0 st7 ] [2332[2332.5001C0 st8 [2332.674727 Ramp reset: st1] [2332.675510 CL: p0 s0 i2970 v15000] [2333.668216 AC on] [2334.403481 Ramp p0 st5 2970mA 2970mA] [2334.450155 Battery 80% / 11h:18 to empty] [2335.448877 charge_request(8800mV, 5376mA)] [2336.699875 charge_request(8800mV, 3712mA)] [2356.466385 Battery 81% / 1h:1 to full] Change-Id: Iba909c252094c0e5ca4cf974aabcfe1eaf002efd Reviewed-on: https://chromium-review.googlesource.com/1130000 Commit-Ready: Sam Hurst <shurst@google.com> Tested-by: Sam Hurst <shurst@google.com> Reviewed-by: Duncan Laurie <dlaurie@google.com>
* DragonEgg: Add control for display backlightScott Collyer2018-08-011-0/+4
| | | | | | | | | | | | | | | BUG=b:111901516 BRANCH=none TEST=Verfifed with gpioget that this signal is high following 'lidopen' EC console command and low following 'lidclose' command. Change-Id: I34bad96c747f254b339c4a7fafb56f6d09cb61c8 Signed-off-by: Scott Collyer <scollyer@google.com> Reviewed-on: https://chromium-review.googlesource.com/1153552 Commit-Ready: Scott Collyer <scollyer@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* DragonEgg: Add smart control for USB-A port on MLBScott Collyer2018-08-013-0/+14
| | | | | | | | | | | | | | | | | | This CL adds the config options required for USB smart power control for the Type-A port on the MLB. BUG=b:111925860 BRANCH=none TEST=Tested with a USB powered fan. Verified the fan goes off after entering 'aps' on EC console, then turns on with 'powerb' command. Change-Id: I4458fd6edce0517eedf3e0191387821e1232743c Signed-off-by: Scott Collyer <scollyer@google.com> Reviewed-on: https://chromium-review.googlesource.com/1153473 Commit-Ready: Scott Collyer <scollyer@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* DragonEgg: Add vboot config options to baseboard.hScott Collyer2018-08-011-0/+5
| | | | | | | | | | | | | | | | This CL adds the config options required for VBOOT_HASH. BRANCH=none BUG=b:111892098 TEST=Verified that AP boots into depthcharge. Change-Id: I051472322d0aab2047246150a2770b34c49b0b0e Signed-off-by: Scott Collyer <scollyer@google.com> Reviewed-on: https://chromium-review.googlesource.com/1152233 Commit-Ready: Scott Collyer <scollyer@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* DragonEgg: Workaround for EC_BATT_PRES_ODL being incorrectScott Collyer2018-08-012-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The signal EC_BATT_PRES_ODL reads high unless the battery is connected and a cold reset is applied to the board. The signal is floating at ~2V and that issue is being investigated. To enable the battery to be charged, this CL replaces reading the GPIO signal with the ability to read the Operation Status register. BUG=b:111704193 BRANCH=none TEST=Verified that when connected the battery is recognized and can be charged. > battery Status: 0x0080 INIT Param flags:00000003 Temp: 0x0bd4 = 302.8 K (29.7 C) V: 0x21cc = 8652 mV V-desired: 0x2260 = 8800 mV I: 0x0beb = 3051 mA(CHG) I-desired: 0x103e = 4158 mA Charging: Allowed Also tested that after issuing cutoff command, the battery wakes up when I connect AC. Change-Id: Id591329071396bd33ade5d773c77ed584979802a Signed-off-by: Scott Collyer <scollyer@google.com> Reviewed-on: https://chromium-review.googlesource.com/1149503 Commit-Ready: Scott Collyer <scollyer@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* stats_manager: more informative nan summary outputRuben Rodriguez Buchillon2018-08-012-1/+39
| | | | | | | | | | | | | | | | | Now for the formatted output string, if any value a domain is NaN, the domains gets tagged with a * and a help text gets added at the end of the summary to highlight this issue. CQ-DEPEND=CL:1140025 BRANCH=None BUG=chromium:806146, chromium:760267 TEST=unit tests added & pass Change-Id: I30791053bb1645065fa2bfd8305cc840a4a88031 Signed-off-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1140032 Reviewed-by: Mengqi Guo <mqg@chromium.org>
* stats_manager: accept_nan supportRuben Rodriguez Buchillon2018-08-012-16/+45
| | | | | | | | | | | | | | | | | | This CL introduces a flag to StatsManager that allows for 'NaN' values to be recorded inside StatsManager. The motivation here is that if a sample fails to record it might be more desirable to record a 'NaN' than to just skip the sample, to keep timelines correct, and to not hide errors in the test-run. Also adds necessary tests for that behavior. BRANCH=None BUG=chromium:806146, chromium:760267 TEST=unit tests still pass Change-Id: If17b7f52ba4a05e9e007c73bfa5d667fe36b74b3 Signed-off-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1140031 Reviewed-by: Mengqi Guo <mqg@chromium.org>
* stats_manager: add title banner pretty-printingRuben Rodriguez Buchillon2018-08-012-6/+33
| | | | | | | | | | | | | | If a title is supplied it now gets printed centralized on top of the summary when calling SummaryToString. BRANCH=None BUG=chromium:760267 TEST=unit tests are passing Change-Id: I7c59896ebac82d2ee7b632fd18350b9b4fff2c24 Signed-off-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1140030 Reviewed-by: Mengqi Guo <mqg@chromium.org>
* stats_manager: Avoid losing dataRuben Rodriguez Buchillon2018-08-012-5/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | In the case of multiple StatsManager, we might get data clobbered. That's particularly bad on long-running tests. This CL introduces two methods to make sure output files are unique in a directory. (1) on init, the user can supply a StatsManagerID (smid) that will be prepended to all output files. E.g. if the smid is 'ec' the summary will be stored at ec_summary.txt (2) should that fail because multiple StatsManagers are using the same smid supplied (or none were supplied) a simple file rotation is done where an integer suffix keeps getting incremented until the filename is unique. E.g. if summary.txt already exists, then summary1.txt will be created. This is not threadsafe at all so the user still have to use some caution to avoid clobbering their own data. BRANCH=None BUG=chromium:760267 TEST=unit tests still all pass Change-Id: I6cc083259362ee20e0242b94ac7cbb1228a06a7a Signed-off-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1140029 Reviewed-by: Mengqi Guo <mqg@chromium.org>
* stats_manager: StatsManager returns file save locationsRuben Rodriguez Buchillon2018-08-012-19/+48
| | | | | | | | | | | | | | | | | Some test code currently duplicates knowledge by telling StatsManager where to save a file and then having to figure out where it stored the files again. This CL has StatsManager return the save locations to simplfy code. This potentially allows for informative logging on where information was stored. BRANCH=None BUG=chromium:760267 TEST=unit tests still pass Change-Id: I54b5873a4a3ddade9a73da0792c1947445759ad4 Signed-off-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1140028 Reviewed-by: Mengqi Guo <mqg@chromium.org>
* DragonEgg: Add support for Type C port 0, charging, and batteryScott Collyer2018-07-3111-0/+802
| | | | | | | | | | | | | | BRANCH=none BUG=b:111281797 TEST=make buildall Change-Id: I2f4342f2c9ddfb4a6b2debbf94c1b0589227b58c Signed-off-by: Scott Collyer <scollyer@google.com> Reviewed-on: https://chromium-review.googlesource.com/1135928 Commit-Ready: Jett Rink <jettrink@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* led_pwm: Turn off LEDs when not pulsing.Aseda Aboagye2018-07-311-0/+6
| | | | | | | | | | | | | | | | | | | | | | This commit fixes a bug where sometimes if the EC was showing battery error LED lights, one side would remain lit with the error condition. This is because it's possible that the EC decided not to pulse the LEDs anymore while in the "on" period. That coupled with showing the charging state on the active charge only, would mean that until an unplug happened, the other LED could remain lit. BUG=None BRANCH=None TEST=Flash nocturne; cutoff battery, plug AC in, verify that only the charge port LED is on. Change-Id: I3cf09d31749bc783b1507045e58b8b97968bae4b Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/1155763 Commit-Ready: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org>
* nocturne: Set OTG pins on UFP for Port 0.Aseda Aboagye2018-07-311-1/+10
| | | | | | | | | | | | | | | | | Nocturne supports OTG on port 0 only. This commit sets the ID and VBUS sense pins to high when port 0 is a UFP and low otherwise. BUG=b:111963814 BRANCH=None TEST=Flash nocturne; plug in A-to-C cable; verify that USB2_ID and USB2_VBUSSENSE are high. Change-Id: I40280b120959aa1fafe13e7e4fd63b2e201040da Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/1155984 Commit-Ready: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org>
* chgstv2: Always check batt disconnect state.Aseda Aboagye2018-07-312-4/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | When the battery is responsive, the charge state machine only checks the disconnect state if the battery requests 0 volts and 0 milliamps. Since battery disconnect state essentially means "can the battery provide a charge?" we should always check the battery disconnect state. It's possible that the battery wants a charge to recover from a short term failure, but cannot yet provide charge to the system. This commit simply changes battery_seems_to_be_disconnected to always query the disconnect state regardless of the request charge voltage and current. BUG=b:76121712 BRANCH=None TEST=Flash nocturne; cutoff battery, verify that battery is able to recover and system is able to boot. Change-Id: I91f9bdf2a54d4e16fc90c67264888342d87f9fe0 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/1152554 Commit-Ready: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org>
* grunt family: Provide pu/pd for port 1 BC1.2Jonathan Brandmeyer2018-07-314-8/+8
| | | | | | | | | | | | | | | | | | | Port 1 is provided by a daughterboard. In the event that the daughterboard is disconnected, these pins are floating. Pull them in the appropriate direction for their logic when the board is disconnected. BUG=b:111942717 BRANCH=none TEST=make -j buildall; Test startup on Careena hardware both with and without port 1 connected to the mainboard. Signed-off-by: Jonathan Brandmeyer <jbrandmeyer@chromium.org> Change-Id: Ica06ea16c2c76c624c542ba9b803197a4fd852bd Reviewed-on: https://chromium-review.googlesource.com/1155713 Commit-Ready: Jonathan Brandmeyer <jbrandmeyer@chromium.org> Tested-by: Jonathan Brandmeyer <jbrandmeyer@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org>
* careena: Correct baseboard IMU orientation.Jonathan Brandmeyer2018-07-315-29/+44
| | | | | | | | | | | | | | | | | | | | The Careena baseboard IMU principle axes are rotated relative to the Grunt reference design for manufacturability. Also, refactor common/spi_flash_reg.c to avoid a name collision with axis definitions in math_util. BRANCH=none BUG=b:111983307 TEST=make -j buldall; Observe `accelread 1` output with the base in orientations: flat, perturbed by rotation about +y, and perturbed by rotation about +x. Signed-off-by: Jonathan Brandmeyer <jbrandmeyer@chromium.org> Change-Id: Ib85d657ef47a89aaa63134b2bdf43920caf6c06e Reviewed-on: https://chromium-review.googlesource.com/1155628 Commit-Ready: Jonathan Brandmeyer <jbrandmeyer@chromium.org> Tested-by: Jonathan Brandmeyer <jbrandmeyer@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org>
* stats_manager: replace prefixes with flags in StatsManagerRuben Rodriguez Buchillon2018-07-313-51/+79
| | | | | | | | | | | | | | | | | | | | | | | | | StatsManager right now uses a '__' prefix to indicate that sample_msecs should be the first key in the summary. Additionally, there is a NOSHOW_PREFIX to potentially hide rails in the summary. This CL replaces that approach with constructor arguments to feed into the StatsManager what rails to hide, and the order to print a summary. This results in cleaner code, and less information leakage across classes as hiding & sorting becomes an implementation detail. It also adds two new unit tests to StatsManagerTest to verify this behavior works as intended. As a nit this CL also replaces AddValue with AddSample as Sample is more descriptive for the use-cases. BRANCH=None BUG=chromium:760267 TEST=manual testing, same output as before, and unittests still pass Change-Id: I52ca0d85c4600691fce8d4c74fd2a81fc4aa440f Signed-off-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1140027 Reviewed-by: Mengqi Guo <mqg@chromium.org>
* stats_manager: remove expliting printing from stats_managerRuben Rodriguez Buchillon2018-07-313-62/+64
| | | | | | | | | | | | | | | | | | StatsManager is a library shared across some modules. It shouldn't print anything itself, but rather use logging & return a formatted summary that can be printed. Also take this opportunity to replace majority of explicit print calls in powerlog with logger module. BRANCH=None BUG=chromium:760267 TEST=manual testing, output as expected still for powerlog Change-Id: I0ed2ccaa45bbd1261119a1446110beadb075c1a2 Signed-off-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1140026 Reviewed-by: Mengqi Guo <mqg@chromium.org>
* rollback: Add host command to add entropyNicolas Boichat2018-07-313-1/+129
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To generate a new secret, we add entropy (generated from local HW TRNG) to the existing secret (sha256(old secret || entropy)). This essentially re-keys the EC. On STM32H7, erasing rollback flash block can take up to 4 seconds, which exceeds the timeout of a normal host command. Therefore, ADD_ENTROPY command is asynchronous (adding the entropy itself is performed in a deferred hook), and its status must be checked repeatedly by the host. In some cases, it is critical that the old key is not left in the backup rollback block(s). For this purpose, we add a special action ADD_ENTROPY_RESET_ASYNC that adds entropy multiple times, until all the rollback blocks have been overwritten. BRANCH=none BUG=b:111190988 TEST=EC> rollbackinfo DUT> ./ectool --name=cros_fp reboot_ec RO && \ sleep 0.3 && ./ectool --name=cros_fp addentropy EC> rollbackinfo => See that that a single rollback block has been overridden TEST=Repeat with ./ectool --name=cros_fp addentropy reset => See that both rollback blocks have been overridden Change-Id: I3058b0a91591fab543ba6890f7356e671016edfa Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1132826 Reviewed-by: Nicolas Norvez <norvez@chromium.org>
* rammus: revise the gpio.inc, board.h and board.cZhuohao Lee2018-07-319-736/+320
| | | | | | | | | | | | | | | | | | | | | | | | | | | | According to the proto schematics, revise the config 1. gpio.inc: - Correct some pins assignment - Remove unused pins - Add TABLET_MODE_L, PP3300_USB_PD, EC_BRD_ID_EN, LID_ACCEL_INT_L, TP_INT, TP_INT_EN 2. board.h: - Remove unused options/code - Add PWM related options/code to support kb light - Add TABLET_SWITCH because of GMR support - Add ANX3447 support 3. board.c: - Remove unused code - Add ANX3447 support - Add temp sensor, ambient and eMMC - Add PWM kb light BUG=b:111579280 BRANCH=master TEST=emerge-rammus chromeos-ec Change-Id: Idbb1755f53c45018305a2724a14232a7cdab9acc Signed-off-by: Zhuohao Lee <zhuohao@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1149772 Reviewed-by: Furquan Shaikh <furquan@chromium.org>
* phaser: Fix ectool led on/off/auto controlsnickchen2018-07-312-20/+26
| | | | | | | | | | | | | | | | | | | | | | | | Phaser systems include power and battery LED and they were not being covered for ectool led commands. This CL adds the support for POWER_LED and BATTERT_LED, so that ectool led can control both power button led and battery led. In addition, fix "ectool led power auto" can adjust power led status immediately. BUG=b:80501031, b:110086152 BRANCH=none TEST=Verified all leds color and behavior can work as expected. ectool led battery red|amber|green|off|auto ectool led power white|off|auto make buildall pass. Change-Id: I68b31114e89786f82b5c0fa6bf437c041f5a4fd0 Signed-off-by: nickchen <nickchen@ami.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/1152343 Commit-Ready: Nick Chen <nickchen@ami.corp-partner.google.com> Tested-by: Nick Chen <nickchen@ami.corp-partner.google.com> Tested-by: Chao Ding <chao.ding@bitland.corp-partner.google.com> Reviewed-by: Chao Ding <chao.ding@bitland.corp-partner.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
* tcpm:it83xx:correct it8320 message IDRuibin Chang2018-07-311-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | A particular dongle plug-in pd port after second times didn't connect, or sometimes it could connect pd port but still has no GoodCRC error situation. We found that HW automatically generated message ID doesn't reset in start up state. And because this dongle doesn't store the received MsgID, the GoodCRC MsgID of dongle respond does not match we sending. After soft reset state, the SRC_Capability MsgID which HW generate automatically is 1 not 0. And the GoodCRC MsgID of dongle respond doesn't match we sending, so we send hard reset after soft reset retry. Finally we disable HW auto generate header, and FW manually set register to solve both issue. BUG=b:111945600 BRANCH=none TEST=Dongle hot-pluggin on Bx and Dx, message ID will reset in start up state when connect and execute soft reset. Change-Id: I6592d2397b486249ca38821bb86a2569aa9117b0 Signed-off-by: Ruibin Chang <Ruibin.Chang@ite.com.tw> Reviewed-on: https://chromium-review.googlesource.com/1152341 Reviewed-by: Jett Rink <jettrink@chromium.org>
* bip: Enable DPTF.Justin TerAvest2018-07-301-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that all three temperature sensors are available in the Bip EC image, DPTF can be enabled. From the EC log: [13.387452 DPTF sensor 0, threshold -73 C, index 0, disabled] [13.388130 DPTF sensor 0, threshold -73 C, index 1, disabled] [13.390591 DPTF sensor 1, threshold -73 C, index 0, disabled] [13.391815 DPTF sensor 1, threshold -73 C, index 1, disabled] [13.394560 DPTF sensor 2, threshold -73 C, index 0, disabled] [13.399214 DPTF sensor 2, threshold -73 C, index 1, disabled] [13.532644 DPTF sensor 2, threshold 120 C, index 0, enabled] [13.542451 DPTF sensor 2, threshold 90 C, index 1, enabled] [13.556058 DPTF sensor 2, threshold 120 C, index 0, enabled] [13.559844 DPTF sensor 2, threshold 58 C, index 1, enabled] [13.593808 DPTF sensor 1, threshold 120 C, index 0, enabled] [13.601713 DPTF sensor 1, threshold 75 C, index 1, enabled] [13.620335 DPTF sensor 1, threshold 120 C, index 0, enabled] [13.634101 DPTF sensor 1, threshold 46 C, index 1, enabled] [13.638422 DPTF sensor 0, threshold 120 C, index 0, enabled] [13.654663 DPTF sensor 0, threshold 125 C, index 1, enabled] [13.657319 DPTF sensor 0, threshold 120 C, index 0, enabled] [13.662837 DPTF sensor 0, threshold 120 C, index 1, enabled] BRANCH=None BUG=b:80145756 TEST=Built and successfully booted bip with DPTF enabled. Change-Id: I44d1705f77d34094ec64f6ac1b8e6ee4e49d463e Signed-off-by: Justin TerAvest <teravest@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1150417 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* nocturne: Tie batt disconnect state to DSG FET status.Aseda Aboagye2018-07-301-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | battery_get_disconnect_state() and the way that it is used in the EC code base essentially means "can the battery provide a charge?". This can be tied to the battery's discharge FET status. If the discharge FET is disabled, the battery cannot provide power to the system. This commit changes the decision to report the battery as disconnected to solely rely on the discharge FET status. Previously, we've seen issues where the charge FET was enabled, but the discharge FET was disabled due to a cell undervoltage issue. The EC would consider the pack as not "disconnected". However, this would signal to the system that the battery could provide charge, but in actuality it couldn't. BUG=b:76121712 BRANCH=None TEST=Flash nocturne; cutoff pack, apply AC, verify pack wakes up. Change-Id: I394278828c1c96112579ac84544655c3a1818e3d Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/1152553 Commit-Ready: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Scott Collyer <scollyer@chromium.org>
* Fleex: Update battery parameterelthanhuang2018-07-302-3/+88
| | | | | | | | | | | | | | | | | This patch makes EC configure battery parameters differently based on manufacturer name BUG=b:111330630,b:110076440 BRANCH=none TEST=Verify BYD/LGC/Simplo battery can be found via EC console Change-Id: Ic963dd203d89371dd6915992157c51398cf700d6 Signed-off-by: elthanhuang <elthan_huang@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/1148023 Commit-Ready: Jett Rink <jettrink@chromium.org> Tested-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Raymond Chou <raymond_chou@compal.corp-partner.google.com> Reviewed-by: Jett Rink <jettrink@chromium.org>
* Octopus: Avoid potential panic in LED codeVijay Hiremath2018-07-302-0/+8
| | | | | | | | | | | | | | | | | When the charge is in idle mode LED array is out of bound hence there is potential panic. Fill the LED array to defined number of LED states. BUG=b:111913899 BRANCH=none TEST=Manually tested on yorp "chgstate discharge on" doesn't panic anymore Change-Id: Ib9c52b68b0ec9440911f15b6c09e8505b2b20e95 Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com> Reviewed-on: https://chromium-review.googlesource.com/1153782 Commit-Ready: Jett Rink <jettrink@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* util/stm32mon: Fix resource leakPatrick Georgi2018-07-301-0/+1
| | | | | | | | | | Change-Id: I81941a440ae0abda226795855b67c2c9b12f6686 Signed-off-by: Patrick Georgi <pgeorgi@google.com> Found-by: Coverity Scan #58166 Reviewed-on: https://chromium-review.googlesource.com/1151125 Commit-Ready: Patrick Georgi <pgeorgi@chromium.org> Tested-by: Patrick Georgi <pgeorgi@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* util/ecst.c: Fix resource leakPatrick Georgi2018-07-301-1/+3
| | | | | | | | | | Change-Id: I3397dcaf90c8141efee170183a6e54e8430924f9 Signed-off-by: Patrick Georgi <pgeorgi@google.com> Found-by: Coverity Scan #58168 Reviewed-on: https://chromium-review.googlesource.com/1151124 Commit-Ready: Patrick Georgi <pgeorgi@chromium.org> Tested-by: Patrick Georgi <pgeorgi@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* util/ectool_keyscan: Fix resource leakPatrick Georgi2018-07-301-0/+1
| | | | | | | | | | Change-Id: I6b24df29ce3e04500947868239f7b941c659ffbb Signed-off-by: Patrick Georgi <pgeorgi@google.com> Found-by: Coverity Scan #58169 Reviewed-on: https://chromium-review.googlesource.com/1151123 Commit-Ready: Patrick Georgi <pgeorgi@chromium.org> Tested-by: Patrick Georgi <pgeorgi@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* util/cbi-util: Check pointer before using itPatrick Georgi2018-07-301-1/+3
| | | | | | | | | | Change-Id: If11de8883b001f16d7e8f859a416fbdc5ea0391a Signed-off-by: Patrick Georgi <pgeorgi@google.com> Found-by: Coverity Scan #187038 Reviewed-on: https://chromium-review.googlesource.com/1151121 Commit-Ready: Patrick Georgi <pgeorgi@chromium.org> Tested-by: Patrick Georgi <pgeorgi@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* util/cbi-util: Fix resource leaksPatrick Georgi2018-07-301-0/+3
| | | | | | | | | | Change-Id: I1bac7756df713be66011c75df7e04b0ed342b96d Signed-off-by: Patrick Georgi <pgeorgi@google.com> Found-by: Coverity Scan #187040, #187042 Reviewed-on: https://chromium-review.googlesource.com/1151120 Commit-Ready: Patrick Georgi <pgeorgi@chromium.org> Tested-by: Patrick Georgi <pgeorgi@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* util/uut: Fix resource leakPatrick Georgi2018-07-301-0/+1
| | | | | | | | | | Change-Id: I07b9a0eff390be97b3ee8adbc47dcc28bffa5ff9 Signed-off-by: Patrick Georgi <pgeorgi@google.com> Found-by: Coverity Scan #187043 Reviewed-on: https://chromium-review.googlesource.com/1151119 Commit-Ready: Patrick Georgi <pgeorgi@chromium.org> Tested-by: Patrick Georgi <pgeorgi@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* util/iteflash: Fix resource leakPatrick Georgi2018-07-301-0/+1
| | | | | | | | | | Change-Id: I68008a1ed0d33c5b8c99f7b3d4d8275970c6b04b Signed-off-by: Patrick Georgi <pgeorgi@google.com> Found-by: Coverity Scan #187193 Reviewed-on: https://chromium-review.googlesource.com/1151117 Commit-Ready: Patrick Georgi <pgeorgi@chromium.org> Tested-by: Patrick Georgi <pgeorgi@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* bip: Add charger temp sensorJustin TerAvest2018-07-305-1/+83
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The voltage used for the charger thermistor is 6.0V, which requires new tables to be created for that configuration. Additionally, the voltage rail used for measuring temperature comes from the charger LDO, which is only powered when AC is present. This was tested as below: > temps Battery : 299 K = 26 C Ambient : 300 K = 27 C Charger : 302 K = 29 C [Removed AC power] > temps Battery : 299 K = 26 C Ambient : 300 K = 27 C Charger : Not powered Not Powered BRANCH=None TEST=built, ran "temps" BUG=b:80145756,b:79932676 Change-Id: I391d2b6eaddc0f6a99f7b7ce565c245838f608f9 Signed-off-by: Justin TerAvest <teravest@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1150416 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* bq25710: Add bq25710 charger driverScott Collyer2018-07-294-0/+452
| | | | | | | | | | | | | | | | | | This CL adds a driver for the bq25710 charger chip. This is mostly copied from the bq25703 driver which is very similar. But, the bq25710 uses smbus registers instead of i2c. BUG=b:111410058 BRANCH=none TEST=make buildall Change-Id: Ic9068fdcfe91f3dd3840244ca21d2210b64c099f Signed-off-by: Scott Collyer <scollyer@google.com> Reviewed-on: https://chromium-review.googlesource.com/1135927 Commit-Ready: Scott Collyer <scollyer@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* scarlet: Bump the hard-coded battery currentPhilip Chen2018-07-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | For scarlet, the battery desired current is always overridden by charger_profile_override(). As scarlet has a dumb battery, we just need a hard-coded placeholder for the fuel gauge. 'firmware_ECCharging' test doesn't expect charger target current to go higher than battery desired current, so we need to bump this hard-coded battery desired current to pass the test. BUG=b:111837457 BRANCH=scarlet TEST=battery command shows I-desired is 4000mA TEST=firmware_ECCharging passes when battery is not full Change-Id: Ife29c6f1c65da09df8647ae9b6987ae5df8a3745 Signed-off-by: Philip Chen <philipchen@google.com> Reviewed-on: https://chromium-review.googlesource.com/1152524 Commit-Ready: Philip Chen <philipchen@chromium.org> Tested-by: Philip Chen <philipchen@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
* DragonEgg: Add power sequencing supportScott Collyer2018-07-276-10/+163
| | | | | | | | | | | | | | | | This CL enables power sequencing for DragonEgg. BRANCH=none CQ-DEPEND=Iab4423abc9102164d4f43296a279c24355445341 BUG=b:111121615 TEST=make buildall Change-Id: Id8c48a74b7b83153dc253222edc515c2488e7af5 Signed-off-by: Scott Collyer <scollyer@google.com> Reviewed-on: https://chromium-review.googlesource.com/1126407 Commit-Ready: Scott Collyer <scollyer@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org>
* icelake: Add power sequencing support for icelakeScott Collyer2018-07-275-1/+195
| | | | | | | | | | | | | | | | | This CL adds code to support x86 power sequencing for icelake. BRANCH=none CQ-DEPEND=I0bf29d69de471c64f905ee8aa070b15b4f34f2ba BUG=b:111121615,b:111853963 TEST=make buildall. Also tested on P0 and verified that AP gets to S0. Change-Id: I3513f2e598162b2362d56c33df76d16b63864bd3 Signed-off-by: Scott Collyer <scollyer@google.com> Reviewed-on: https://chromium-review.googlesource.com/1123318 Commit-Ready: Furquan Shaikh <furquan@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* bip: Add battery temp sensorJustin TerAvest2018-07-272-0/+6
| | | | | | | | | | | | | | | | | | | | Battery, ambient, and charger temperature sensors must be set up to enable CONFIG_DPTF. This change adds the temp sensor entry for the battery interface. > temps Battery : 298 K = 25 C Ambient : 301 K = 28 C BRANCH=None TEST=built, ran "temps" BUG=b:80145756,b:79932676 Change-Id: I269a39e4b9c0061aa5dff8221bc8b126b51327e6 Signed-off-by: Justin TerAvest <teravest@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1150293 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* g: speed up CCD UART processingVadim Bendebury2018-07-273-29/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | AP and EC consoles may generate a lot of bursty traffic, and cr50 UART console to USB processing is very slow: when characters become available, a hooks task callback is invoked, which retrieves received characters one at a time and queues them up to the appropriate USB transmit queue. This patch speeds up things as follows: - increases the seize of USB transmit queues for AP and EC console channels to 512 bytes. Experiments supported by code instrumentation has shown that even this is not enough to avoid underruns, but this is a good compromise between memory use and performance, these sizes could be revisited later, - moving bytes from UART TX FIFO to USB queue happens on the interrupt context when UART TX interrupt is asserted - as many characters as possible are read from the UART first, before queuing function is called, and the entire received batch is passed to the queuing function. It has to be mentioned here that presently batch processing is not necessarily much more efficient, because queuing function becomes more complicated when multiple objects are passed to it, this will have to be dealt with in a separate patch. There is still a lot of room for improvement: - functions used to queue up data are very generic, dedicated code could help a lot. - UART drivers should have methods for collecting all bytes available in receive FIFO in one invocation, - USB side of things (dequeuing data and passing it to the controller). BRANCH=cr50, cr50mp BUG=b:38448364, b:111701874 TEST=ran 'chargen' application on both AP and EC to flood the console channels and observed the flow of characters on the host site, it is pretty smooth with occasional hiccups, especially when TPM is active, before this patch it was impossible to have both stream up, both were garbled. - Verified that new account can be created and user logged in on restarts while chargen is running, i.e. TPM task gets enough processing bandwidth. - When EC is reset, there seem to be no lost characters on the console (it used to cause some garbled console output before this patch). The below output was collected on Coral: > reboot Rebooting! --- UART initialized after reboot --- [Reset cause: soft] [Image: RO, coral_v1.1.8363+2cc945d5a 2018-05-15 17:41:57 ... [0.003605 init buttons] [0.003826 Inits done] [0.004094 tablet mode disabled ] [0.008272 found batt:SMP] [0.022278 SW 0x01] [0.042247 hash start 0x00040000 0x00021994] [0.045823 Battery FET: reg 0x0018 mask 0x0018 disc 0x0000] [0.071136 kblight registered] [0.071544 PB init-on] [0.071818 USB charge p0 m0] [0.073670 ID/SKU ADC 4 = 1309 mV] [0.075630 ID/SKU ADC 3 = 852 mV] [0.076077 SKU ID: 71] [0.076335 Motion Sensor Count = 3] [0.083594 PD comm enabled] ... - did not test bitbang programming mode, it is in line for reworking for speeding up as well. - 15 iterations invocation of firmware_Cr50DevMode passes successfully on BoB Change-Id: I5883012896e78951908db8fe7c1c5d92ea6cda63 Signed-off-by: Vadim Bendebury <vbendeb@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1148655 Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-by: Mary Ruthven <mruthven@chromium.org>
* meep: create initial EC imageDiana Z2018-07-278-0/+694
| | | | | | | | | | | | | | | This image is based on yorp proto 2 from ToT and the most recent meep schematics BRANCH=none BUG=b:111543000 TEST=builds Change-Id: I42df536b26266da377efbda0db98af1ef269380b Signed-off-by: Diana Z <dzigterman@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1151545 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Justin TerAvest <teravest@chromium.org>
View Lorry Controller Status