summaryrefslogtreecommitdiff
path: root/PRESUBMIT.cfg
Commit message (Collapse)AuthorAgeFilesLines
* presubmit: Require bug in LOW_COVERAGE_REASONTristan Honscheid2023-05-161-0/+1
| | | | | | | | | | | | | | | | | Enforce having a bug listed in the LOW_COVERAGE_REASON to track the issue that impedes coverage for that specific CL. This encourages developers to go back and fix those problems. Also update the documentation. BUG=None TEST=util/check_low_coverage_reason.py Change-Id: If35f918b11771d10944e0b6e7a4aeeba84e05eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4537010 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Tristan Honscheid <honscheid@google.com> Tested-by: Tristan Honscheid <honscheid@google.com>
* ec: Replace presubmit_check.shJeremy Bettis2023-05-031-1/+3
| | | | | | | | | | | | | | | | | Replace presubmit_check.sh and zephyr_check_testcase_yaml.py with python scripts which handle PRESUBMIT_COMMIT, PRESUBMIT_FILES, and also work outside of the chroot. BUG=None TEST=on various paths Change-Id: If7ff5e5d238a5846c19894bb288e96052f99aae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4497260 Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
* pre-upload: Make BRANCH= optional, disable Signed-off-byJack Rosenthal2023-05-021-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by is useless. Gerrit enforces that contributors have signed a CLA in order to upload, and therefore, it's not necessary for contributors to acknowledge they've signed a CLA in their commit message. This would be consistent with the rest of ChromeOS. Additionally, BRANCH= is not used by the rest of the OS, and as we move our EC towards a branching model that does not depend on manual cherry picks, it's becoming less and less useful. Most commits these days have stuff like BRANCH=none, or BRANCH=i don't care stop bothering me. We could make BRANCH= optional only for commits which wish to specify it, but not a requirement to upload. BUG=b:280345831 TEST=pre-upload passes Change-Id: I1f2f728b9d6890ce2b21dbf3316afe4354ba3054 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4497661 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jack Rosenthal <jrosenth@chromium.org> Tested-by: Jack Rosenthal <jrosenth@chromium.org>
* PRESUBMIT: integrate upstream compliance check - yamllintFabio Baltieri2023-02-071-0/+1
| | | | | | | | | | | | | | | | | | | | | | Add a wrapper script to use the upstream Zephyr check_compliance.py script in the EC code base. That script has various presubmit type of checks that are used upstream, and we can reuse some of those internally as is. The wrapper handles the vpython dependencies, skips if there's no Zephyr files touched and only runs YAMLLint for now. BRANCH=none BUG=b:264661333 TEST=create some test patches to touch the non compliant files, ran the script on those Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Cq-Depend: chromium:4212763 Change-Id: Ibe77e92092013780befa54e6c02ab17101b014fb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4177231 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* PRESUBMIT: add a presubmit to check for unnecessary Kconfig optionsFabio Baltieri2023-01-111-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Add a presubmit to read the current Kconfig options and check any project config file for options that are set automatically from devicetree nodes and can be removed. Example error: ERROR: zephyr/program/nissa/xivur/project.conf:7: unnecessary config option CONFIG_PLATFORM_EC_FAN=y (depends on DT_HAS_CROS_EC_FANS_ENABLED && PLATFORM_EC) BRANCH=none BUG=none TEST=manually, creating test CLs TEST=./util/check_zephyr_project_config.py -d $( find -name '*.conf' ) TEST=./util/check_zephyr_project_config.py -d $( find -name '*.overlay' ) TEST=./util/check_zephyr_project_config.py -d $( find -name '*_defconfig' ) TEST=./util/check_zephyr_project_config_unittest.py Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I55c224b9bf96d6768460c182d2f11b6d33dcbab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4126617 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* ec: Remove all zassume usagesJeremy Bettis2022-10-311-0/+1
| | | | | | | | | | | | | | | | | | | | Since zassume is being used in scenarios where no one would use ztest_test_skip(), convert all zassumes to zasserts. BRANCH=None BUG=b:256650891 TEST=./twister Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I1dc806e25f64f8dbef6f7d10cfe2f46ea4887e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3937539 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: Aaron Massey <aaronmassey@google.com> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Aaron Massey <aaronmassey@google.com>
* util: Add a twister test tag validation scriptAaron Massey2022-09-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | While completing higher code coverage on herobrine, it has become advantageous to create small hermetic tests to facilitate verifying various enabled configs and faking of global functions. Twister test tags are a way to group run many small tests together without them being in the same directory. Add twister_tags.py which contains a mapping of tag to description and performs a presubmit check validating that all test tags in use have been described. BRANCH=none BUG=b:249146559 TEST=repo upload with test commit TEST=repo upload without test commit TEST=util/twister_tags.py -l --validate-files Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: I3ec2aea239efe474b893d7d11e24bd4b10f3c0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3919499 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* PRESUBMIT.cfg: Enable black_check and drop custom scriptJack Rosenthal2022-07-191-1/+2
| | | | | | | | | | | | | | | | | | Enable the global PRESUBMIT.cfg option for black pre-upload checks, and drop our custom script. isort checks are done by cros lint, so this was redundant in the custom script. BUG=b:238434058 BRANCH=none TEST=Run pre-upload on some recent commits Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: Ib624b619621654949019541f03ffe35ba69f78b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3770681 Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* ec: Enforce black in presubmitJeremy Bettis2022-07-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Enforce black, isort formatting in presubmit for all python files. Do not enforce flake8, because it has errors on most of the files, and it seems to be basically the same as pylint, which is already run on pre-submit. Do not enforce it in the zmake unit test script. Do enforce the formatting in the firmware_builder.py script, and do it early for faster failures in CQ runs. BRANCH=None BUG=b:238434058 TEST=None Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: If3c42b2af41fd2e68accbe2867999dc931e88872 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3749243 Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
* clang-format: Enable enforcement during pre-uploadJack Rosenthal2022-07-071-0/+1
| | | | | | | | | | | | | | | Enable the clang_format_check hook for pre-upload. BUG=b:236386294 BRANCH=none TEST=Run ~/chromiumos/src/repohooks/pre-upload.py on recent commits Only legitimate formatting errors are caught. Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: Id00fd8a7acce4105cb8f4a445067393616df5ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3751770 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
* Reland "Enable "cros lint" presubmit check"Tom Hughes2022-04-111-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a reland of commit b294077eed6da053eeca07ce5546830d5404c9a1 Now that zmake has a pylint config file, this should be safe to enable. Original change's description: > Enable "cros lint" presubmit check > > The cpplint check run by cros lint is disabled with the CPPLINT.cfg file > since it doesn't apply. Other linters, such as Python and Shell are > applicable and will be run. > > BRANCH=none > BUG=b:217969201 > TEST=none > > Signed-off-by: Tom Hughes <tomhughes@chromium.org> > Change-Id: Ie9aba283d7bf927913ff834c586ec9e8d0e9e9a1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3444587 > Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> BRANCH=none BUG=b:217969201 TEST=none Change-Id: I796a191333128c35903dd60237e677f854132c50 Signed-off-by: Jeremy Bettis <jbettis@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3581652 Reviewed-by: Tom Hughes <tomhughes@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org>
* presubmit: Add warning on edit of non-zephyr codeJeremy Bettis2022-02-241-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add presubmit to repo upload that will check that all C files in the cl are actually used in the Zephyr EC. If any of the edited files are not actually part of the Zephyr builds, print a warning message for the user. This is to satisfy the goal to prevent people from accidentally making changes in a legacy EC driver when we've already migrated that code to Zephyr. I excluded the baseboard, board, and chip dirs, since they are clearly not zephyr code. Excluded test and util since those aren't ec code. And exclude the zephyr dir, since obviously that is zephyr code. BRANCH=None BUG=b:205759844 TEST=Edited several included and not-included files and made sure the warning only applied to the non-included files. Change-Id: Ida4f6702a1408004e3a98a057c6c472247feff25 Signed-off-by: Jeremy Bettis <jbettis@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3481575 Tested-by: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* Revert "Enable "cros lint" presubmit check"Jack Rosenthal2022-02-081-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit b294077eed6da053eeca07ce5546830d5404c9a1. Reason for revert: "cros lint" is not compatible with black, which is the required formatter in the zephyr/ directory Original change's description: > Enable "cros lint" presubmit check > > The cpplint check run by cros lint is disabled with the CPPLINT.cfg file > since it doesn't apply. Other linters, such as Python and Shell are > applicable and will be run. > > BRANCH=none > BUG=b:217969201 > TEST=none > > Signed-off-by: Tom Hughes <tomhughes@chromium.org> > Change-Id: Ie9aba283d7bf927913ff834c586ec9e8d0e9e9a1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3444587 > Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Bug: b:217969201 Change-Id: If5099e67309b429feea3b4c912948512978c5287 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3449112 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> Tested-by: Jack Rosenthal <jrosenth@chromium.org>
* Enable "cros lint" presubmit checkTom Hughes2022-02-081-0/+1
| | | | | | | | | | | | | | | The cpplint check run by cros lint is disabled with the CPPLINT.cfg file since it doesn't apply. Other linters, such as Python and Shell are applicable and will be run. BRANCH=none BUG=b:217969201 TEST=none Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Ie9aba283d7bf927913ff834c586ec9e8d0e9e9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3444587 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
* PRESUBMIT: Add third_party/bmi220 to excluded license checkTom Hughes2021-10-191-0/+1
| | | | | | | | | | | | | The cros_license_check presubmit is complaining. BRANCH=none BUG=b:172020503, b:188373185, b:193945779 TEST=none Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I9e1f33e427271df4cec340fc3bc0369ee2c9faa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3229799 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* zephyr: zmake: Add pre-upload formatter suggestionsJack Rosenthal2021-09-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Zmake requires three (fairly standard) formatting and linting tools to preform validation on the source. At present, we run these as a part of run_tests.sh and report it during the commit queue run, which can be inconvenient to find out a CL needs trivial formatting changes after you've already sent it to the CQ. Running these formatting tools in pre-sumbit isn't exactly trivial: some people run repo upload from outside of the chroot and we won't necessarily have the formatting/linting tools installed, or if we do, they could be different versions that make slightly different suggestions. Therefore, we wrap the pre-upload logic like so: - If no zmake changes were made, simply exit successfully. - If we did make zmake changes, and we happen to be running in the chroot, run the formatting tools and suggest fixes if necessary. - Finally, if there's zmake changes but we're out of the chroot, report a warning and fail the pre-upload checks. BUG=b:192389533 BRANCH=none TEST=(in chroot) try to upload a CL with bad formatting, get yelled at during pre-upload TEST=(out of chroot) upload a CL with zmake changes, get told to run in the chroot TEST=(out of chroot) try and upload without zmake changes, didn't notice any pre-upload warnings Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: If307b9ce9f968b5b09ad8aeb27f4b9621e813036 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3198244 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* PRESUBMIT: skip license check for third_party codeTom Hughes2020-11-161-0/+6
| | | | | | | | | | | | | | Intentionally including the directories separately since it's possible third party code added in the future could use the standard license. BRANCH=none BUG=b:169276911 TEST=CQ passes Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I238aa216c01a6b7749290e7287d4b9d4745da52b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2537011 Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
* third_party/linux: Add overflow.h from Linux kernelTom Hughes2020-09-241-0/+3
| | | | | | | | | | | | | | | | Copied from repo: https://github.com/torvalds/linux.git commit: 5925fa68fe8244651b3f78a88c4af99190a88f0d path: include/linux/overflow.h. BRANCH=none BUG=b:144957935 TEST=make buildall -j Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Iab74359f9d2c283c4a1e67d8e633e88bb1861337 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2417007 Reviewed-by: Edward Hill <ecgh@chromium.org>
* PRESUBMIT: enable signoff_checkTom Hughes2019-11-201-0/+1
| | | | | | | | | | | | | | | The default in pre-upload.py was changed to warn about Signed-Off-By lines: https://crrev.com/c/1917972. BRANCH=none BUG=none TEST=repo upload --cbr . Change-Id: I61b2ff47f1bb25ed5499c1d02fc085f9d291a827 Signed-off-by: Tom Hughes <tomhughes@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1925708 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org>
* util: Add tool to generate cros_ec_commands.hGwendal Grignou2019-04-261-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | Add a rule to generate a new cros_ec_commands.h when ec_commands.h is modified. The rule is checked when buildall is invoked. At Presubmit stage, check a cros_ec_commands.h exists if ec_commands.h is modified. The CL author is responsible to upstream that file. BUG=chromium:945948 BRANCH=none Cq-Depend: chromium:1558853 TEST=Check manually cros_ec_commands.h is generated with make build_cros_ec_commands Check no bread crumbs are left-over when the rule fails. Check checkpatch triggers when it finds an invalid syntax in the output file. Check ../../repohooks/pre-upload.py returns a meaningful error when cros_ec_commands.h file is not present. Change-Id: Ibc8ed7165914d39b5f0bd41643932a8514768925 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1559380 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Brian Norris <briannorris@chromium.org>
* PRESUBMIT: enable kernel-doc check for include/ec_commands.hBrian Norris2018-12-121-0/+2
| | | | | | | | | | | | | | | ec_commands.h is often synced with the Linux sources, so it's nice to sanity-check it. CQ-DEPEND=CL:1336039 BRANCH=none BUG=chromium:621123 TEST=.../pre-upload.py Change-Id: I56645e613f8689c26ddf6ded1325e270be35da8a Signed-off-by: Brian Norris <briannorris@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1330107 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* presubmit_check: disable SPDX_LICENSE_TAG checkJett Rink2018-06-121-1/+1
| | | | | | | | | | | | | | The SPDX_LICENSE_TAG doesn't apply to the ec codebase since it would want us to add the SPDX-License-Identifier to every file. BRANCH=none BUG=none TEST=verified a new file does not need SPDX-License-Identifier tag Change-Id: Ie7670f52ecd7a5dd825a56a0e8dc839e66ddd6f1 Signed-off-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1098026 Reviewed-by: Mike Frysinger <vapier@chromium.org>
* PRESUBMIT: give real namesBrian Norris2018-05-021-3/+3
| | | | | | | | | | BRANCH=none BUG=none TEST=upload Change-Id: Ied1474ebc347d994a209b31d0dc715318bd2a192 Signed-off-by: Brian Norris <briannorris@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1038730
* ec:Add presubmit hook to enforce host command definitionsSam Hurst2017-02-251-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure all public and private host commands starting with EC_CMD_ and EC_PRV_CMD_ are properly formed BUG=chromium:681240 TEST=manual. Added following host commands and verified that they were flagged #define EC_CMD_TESTA 1234 #define EC_CMD_TESTB 0xabcd #define EC_CMD_TESTC 0x1ABCD #define EC_CMD_TESTD 0xXEF01 #define EC_PRV_CMD_TESTA 1234 #define EC_PRV_CMD_TESTB 0xabcd #define EC_PRV_CMD_TESTC 0x1ABCD #define EC_PRV_CMD_TESTD 0XEF01 These were also flagged by the script include/ec_commands.h:#define EC_CMD_ACPI_READ 0x80 include/ec_commands.h:#define EC_CMD_ACPI_WRITE 0x81 include/ec_commands.h:#define EC_CMD_ACPI_BURST_ENABLE 0x82 include/ec_commands.h:#define EC_CMD_ACPI_BURST_DISABLE 0x83 include/ec_commands.h:#define EC_CMD_ACPI_QUERY_EVENT 0x84 CQ-DEPEND=CL:445809 BRANCH=none Change-Id: I4630d6a887ed289a68178e8f1a8f07f5141c80bc Reviewed-on: https://chromium-review.googlesource.com/445811 Commit-Ready: Sam Hurst <shurst@google.com> Tested-by: Sam Hurst <shurst@google.com> Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-by: Shawn N <shawnn@chromium.org>
* Put a newline at the end of PRESUBMIT.cfgBill Richardson2016-10-071-1/+1
| | | | | | | | | | | | | | | | Every time I run "cat PRESUBMIT.cfg" to see what's in here, it annoys me that there's no newline at the end. This adds one. BUG=none BRANCH=none TEST=make buildall Just adding whitespace; no functional change. Change-Id: I7629312c987696fd6c7bbc986ad63222186729c0 Signed-off-by: Bill Richardson <wfrichar@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/395347 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* presubmit: Add hook to check for config options.Aseda Aboagye2015-06-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | This enables a presubmit hook to check for missing configuration options. All CONFIG_* options should be defined in include/config.h along with a brief description of what the config option does. BUG=chrome-os-partner:26304 BRANCH=none CQ-DEPEND=CL:281626 TEST=Create a commit modifying a source file with a new CONFIG_* option and watched the preupload process fail illustrating the error with the CONFIG_* option. TEST=make -j buildall tests Change-Id: I7240b386b4981dcab66811a4829d7d6ebfbf7cb1 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/281826 Reviewed-by: Randall Spangler <rspangler@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Trybot-Ready: Aseda Aboagye <aaboagye@chromium.org>
* presubmit: enable branch/checkpatch checksMike Frysinger2015-03-261-0/+5
| | | | | | | | | | | | | We're moving the hardcoded check lists out of the pre-upload script. BUG=chromium:466264 TEST=uploading a CL w/out a branch line is rejected BRANCH=None Change-Id: Ifa0f8c3b4be6a20355babb6f9d8896ac8d1fb2be Signed-off-by: Mike Frysinger <vapier@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/262490 Reviewed-by: Bill Richardson <wfrichar@chromium.org>
* Add presubmit check for unit testVic (Chun-Ju) Yang2014-02-061-0/+2
| | | | | | | | | | | | | | | | This enforces that "make buildall" runs at least once after the last file change. TEST=Try to upload without running "make buildall" TEST=Change a file without re-running "make buildall", and try to upload. BUG=None BRANCH=None Change-Id: Ia4abb3c0e17cf4d559975574f398d74c7986c89f Signed-off-by: Vic (Chun-Ju) Yang <victoryang@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/185116 Reviewed-by: Dave Parker <dparker@chromium.org>
* fix pre-submit hookVincent Palatin2011-12-081-0/+6
we are using linux style indentation, so we should not check for the presence of tabs in the common python script, checkpatch will ensure that the indentation is correct. Signed-off-by: Vincent Palatin <vpalatin@chromium.org> BUG=None. TEST="repo upload" a CL with a new line containing tab indentation. Change-Id: Ida3ef3d8274edd3e8e701e2ede43836c944cd263
View Lorry Controller Status