summaryrefslogtreecommitdiff
path: root/baseboard/dedede
Commit message (Collapse)AuthorAgeFilesLines
* x86: Make board_has_[before|after]_rsmrst overridableAseda Aboagye2020-03-261-1/+1
| | | | | | | | | | | | | | | | | | | There aren't many users of the CONFIG_* options CONFIG_BOARD_HAS_AFTER_RSMRST or CONFIG_BOARD_HAS_BEFORE_RSMRST, therefore this commit removes those CONFIG_* options and adds an empty default implementation that can be overridden by boards. BUG=b:151680590 BRANCH=None TEST=`make -j buildall` Signed-off-by: Aseda Aboagye <aaboagye@google.com> Change-Id: I3322e5ce07de19e729ca44a736b283641029c3ff Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2122628 Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org> Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
* cleanup: drop the _TYPEC part of USB device configJett Rink2020-03-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | The three USB device configurations describe more than just the Type-C layer, so remove the _TYPEC part within the define. This is also in preparation to change how the usbc build.mk includes files. This was performed with the following commands: $ git grep --name-only CONFIG_USB_TYPEC_DRP_ACC_TRYSRC | xargs perl -i -ple 's/CONFIG_USB_TYPEC_DRP_ACC_TRYSRC/CONFIG_USB_DRP_ACC_TRYSRC/g' $ git grep --name-only CONFIG_USB_TYPEC_CTVPD | xargs perl -i -ple 's/CONFIG_USB_TYPEC_CTVPD/CONFIG_USB_CTVPD/g' $ git grep --name-only CONFIG_USB_TYPEC_VPD | xargs perl -i -ple 's/CONFIG_USB_TYPEC_VPD/CONFIG_USB_VPD/g' BRANCH=none BUG=none TEST=builds Signed-off-by: Jett Rink <jettrink@chromium.org> Change-Id: I4deab784b7c3479cffd3dee7fb3ea3c8a9d6081c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2121193 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* Waddledee: Set up ADC thresholds for PP3300_A_PGOODDiana Z2020-03-262-1/+63
| | | | | | | | | | | | | | This configures the ADC threshold interrupts for ITE dedede variants, and has them set the baseboard pp3300_a_pgood flag. BUG=b:149094481 BRANCH=None TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I0a0af6f8c7093a5ce3a618cf04d25b062e6a96d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2110975 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* Waddledee: Configure DAC for PSYSDiana Z2020-03-261-5/+5
| | | | | | | | | | | | | This commit configures the DAC module in the waddledee build and sets up the PSYS output to use it. BUG=b:149094279 BRANCH=None TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I1b08e46f25ec3f14924b0ed9da17a8cd213ddacc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2110534
* Waddledee: Complete basic EC tasksDiana Z2020-03-242-5/+270
| | | | | | | | | | | | | | | This commit adds tasks to cover PD functionality, charging, and LED behavior. The charger and TCPC functionality are a part of the ITE variant code for now, but may be moved out as OEM boards are determined. BUG=b:146557556 BRANCH=None TEST=make -j buldall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I50df3caabfae5e3981d7a8b76c0a76332f7d00a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2110532 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* dedede: Check PG_VCCIO_EXT for ALL_SYS_PGOODAseda Aboagye2020-03-241-2/+4
| | | | | | | | | | | | | | | | | | According to the latest Intel documentation, ALL_SYS_PGOOD should also take into account PG_VCCIO_EXT. This commit does simply that. BUG=b:151783164 BRANCH=None TEST=Build and flash waddledoo, verify it still boots up. Signed-off-by: Aseda Aboagye <aaboagye@google.com> Change-Id: I1035f5d128d8fdece4b0c5b4642c3f7403db2170 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2116667 Tested-by: Aseda Aboagye <aaboagye@chromium.org> Tested-by: George Engelbrecht <engeg@google.com> Auto-Submit: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: George Engelbrecht <engeg@google.com>
* Dedede: Configure PROCHOT as active lowDiana Z2020-03-161-0/+1
| | | | | | | | | | | | | PROCHOT for both waddledee and waddledoo is active low. BUG=None BRANCH=None TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I047be61dcd2b59269898c1f0da696b24520915d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2101221 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* OCPC: Introduce charger enumDiana Z2020-03-161-0/+6
| | | | | | | | | | | | | | | This enum will specify which charger is primary, and the number of total charger chips for the board. This will be pre-defined for boards using a single charger chip. BUG=b:147440290 BRANCH=None TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Id612ace560207a7805e103465fd4035d46beed8f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2101220 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* dedede: Require >15W to boot without a batteryAseda Aboagye2020-03-121-0/+2
| | | | | | | | | | | | | | | | | | | | Waddledoo appears to have issues booting with just a 15W supply. Therefore, this commit sets the minimum power required to boot to be greater than 15W such that a PD contract is required. Otherwise, if the battery is present and has greater than 1% SOC, then booting is allowed. BUG=b:150702984 BRANCH=None TEST=build and flash waddledoo, plug in a 15W non PD charger, verify that the system does not attempt to boot the SoC. Signed-off-by: Aseda Aboagye <aaboagye@google.com> Change-Id: I165de0aa6c7185c8087328a427b0bb1eefb21e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2097137 Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org>
* dedede: add chargen to the set of CLI commandsNamyoon Woo2020-02-281-0/+3
| | | | | | | | | | | | | | | | This is needed to support CCD testing of UART to USB bridging. This patch occupies 448 and 428 bytes in flash usage of RO and RW respectively. BUG=b:38448364 BRANCH=none TEST=build waddledoo and waddledee, and checked that command is included in the symbol map. Signed-off-by: Namyoon Woo <namyoon@chromium.org> Change-Id: Id2f525b1a53042316f96e6374dee84e95c1f5c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2079709 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* waddledoo: Set CMPOUT as inverted to enable 5VAseda Aboagye2020-02-251-0/+1
| | | | | | | | | | | | | | | | | | | | The charger has a general comparator which is enabled by default. The output of this comparator enables the sub board power rails. This commit adds a mechanism to turn on the 5V on the sub board tied to when the system decides to enable 5V. BUG=b:149794574 BRANCH=None TEST=Build and flash waddledoo, boot to S0, plug in a sink, verify that VCONN is sourced. Change-Id: I05384bdbdde4ccc033c2057b3c45fcaeae4589cc Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2065495 Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Auto-Submit: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* TCPMV1/2: Make the PD Config Flags more consistentSam Hurst2020-02-221-1/+1
| | | | | | | | | | | | | | | | | | | | The current use of the PD Config Flags are a bit confusing and has been changed to the following: The CONFIG_USB_POWER_DELIVERY flag is used to enable and disable the TCPMv1 and TCPMv2 stacks. And when CONFIG_USB_POWER_DELIVERY is enabled, one of the following must be enabled: CONFIG_USB_PD_TCPMV1 - legacy power delivery state machine CONFIG_USB_PD_TCPMV2 - current power delivery state machine BUG=b:149993808 BRANCH=none TEST=make -j buildall Change-Id: Ie3f8615a75b15b4f1c703f57f3db9e152a471238 Signed-off-by: Sam Hurst <shurst@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2068519 Reviewed-by: Diana Z <dzigterman@chromium.org>
* dedede: Set pullup on PG_PP1050_ST_OD only after RSMRSTAseda Aboagye2020-02-212-0/+18
| | | | | | | | | | | | | | | | | | Per recommendation from the SoC vendor, we should only enable the pull up on PG_PP1050_ST_OD once RSMRST has been de-asserted. Otherwise, the pull up can inidicate a false power good. BUG=b:148688874 BRANCH=None TEST=Build and flash waddledoo, verify that PG_PP1050_ST_OD is actually valid. Change-Id: Icdd8ec08fc84954730ae2d80fed86af4f07f01ba Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2058694 Tested-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* waddledoo:Handle EC_AP_PCH_PWROK_OD and ALL_SYS_PWRGDSooraj Govindan2020-02-192-0/+12
| | | | | | | | | | | | | | | | | | | | | | As per Waddledoo power sequencing requirements, 1. ALL_SYS_PWRGD should be driven based on DRAM power good and the PP1050_ST power good. 2. the EC needs to assert EC_AP_PCH_PWROK_OD, with a 2ms minimum delay after receiving the DRAM power good and the PP1050_ST power good. 3. Enable CONFIG_BACKLIGHT_LID BUG=b:147257114 BRANCH=None TEST=make -j BOARD=waddledoo; flash waddledoo, verify that DUT can boot to S0. Change-Id: I5ad226faa15cfe8ae569524decf405bbd378a28c Signed-off-by: Sooraj Govindan <sooraj.govindan@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2044250 Tested-by: Sooraj Govindan <sooraj.govindan@intel.corp-partner.google.com> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* Waddledee: Initial board fileDiana Z2020-02-113-1/+93
| | | | | | | | | | | | | | | | | This commit contains the initial code for waddledee, the ITE reference board for dedede. All of the GPIOs are defined, and any tasks that can be enabled to begin with are. Since the charger driver is still in progress, this commit undefs any charger related baseboard features, and they will be re-enabled once the driver is ready. BUG=b:146557556 BRANCH=None TEST=builds Change-Id: Ie5901304f92bf9040f1c883fb738c9f3bda0e95e Signed-off-by: Diana Z <dzigterman@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2044359 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* dedede: Override power_signal_get_level()Aseda Aboagye2020-02-051-0/+17
| | | | | | | | | | | | | | | | | | | | The dedede EC's don't have GPIOs for some of the signals used for power sequencing but instead have other logic. The common chipset driver assumes that all these signals are either GPIOs or eSPI virtual wires therefore these signals were not being updated correctly for dedede. This commit adds an override for power_signal_get_level() in order to get the correct values for the signals from the baseboard specific code. BUG=b:148169171 BRANCH=None TEST=Build and flash waddledoo, verify that DUT can boot to S0. Change-Id: Ibccb35405d9e09bfe0873b3d080cfb6a81e61af3 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2032729 Tested-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* dedede: Change PP3300_A PGOOD update methodAseda Aboagye2020-02-053-2/+77
| | | | | | | | | | | | | | | | | | | | | | We cannot read the ADCs in interrupt context, therefore we are changing the method in which we determine the PP3300_A_PGOOD status. This commit adds a ADC threshold interrupt for the PP3300_A PGOOD signal which updates a variable in SRAM. This way, the chipset task can simply use that variable for the PGOOD status instead of performing an ADC conversion in interrupt context. BUG=b:148169171 BRANCH=None TEST=Build and flash waddledoo, verify that PP3300_A PGOOD is updated correctly. TEST=Verify that DUT does not panic while power sequencing Change-Id: Ia88e0d1d95ea97c41dc4094997c0633ca1027cac Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2030205 Tested-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* waddledoo: Change PP1050_ST power goodAseda Aboagye2020-01-312-11/+3
| | | | | | | | | | | | | | | | | | The power good for VCCST is actually now a digital signal as opposed to an analog signal that it used to be. This commit updates the waddledoo GPIO configuration to account for this fact. BUG=b:148169171 BRANCH=None TEST=`make -j BOARD=waddledoo`; flash waddledoo, verify EC boots okay. Change-Id: I0fe64c07705fa3652b79414a3ec451ebf7204aae Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2028354 Tested-by: Aseda Aboagye <aaboagye@chromium.org> Auto-Submit: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* dedede: Add z-state supportAseda Aboagye2020-01-211-0/+9
| | | | | | | | | | | | | | | | | | | | | | Dedede has support for the new low power "Z-state". In this state. the EC and H1 are unpowered, but power will be restored to the EC once one of the wakeup events occurs. These events are ACOK, lid open, and a power button press. This commit simply enables the Z-state when the EC hibernates. BUG=b:147819424 BRANCH=None TEST=build and flash waddledoo, enter `hibernate`, verify that EC power is turned off and can be restored by pressing the power button or plugging in a charger. Change-Id: I4f93efd0632f457354f4bf6bf0274b19a9cd799c Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2006215 Tested-by: Aseda Aboagye <aaboagye@chromium.org> Auto-Submit: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Diana Z <dzigterman@chromium.org>
* waddledoo: Add LED supportAseda Aboagye2020-01-212-0/+14
| | | | | | | | | | | | | | | | | This commit adds LED support to waddledoo utilizing the common PWM LED framework. Waddledoo has a single bi-color PWM LED with amber and white channels. BUG=b:147702767 BRANCH=None TEST=Build and flash on waddledoo, verify that LEDs are working. Change-Id: Ie870a6df194a9e1ccd6b91a96c6e95a390353a8a Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2001941 Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* waddledoo: Add keyboard supportAseda Aboagye2020-01-213-3/+37
| | | | | | | | | | | | | | | | | This commit adds keyboard support to waddledoo using the default keyboard config. BUG=b:147453459 BRANCH=None TEST=Flash waddledoo, connect keyboard, `ksstate on` verify that each key is registered. Change-Id: I0a10eeb3080170c731f90317d4a0b3c0fbfb9243 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2001940 Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* waddledoo: Add Type-C, PD, and charging supportAseda Aboagye2020-01-211-0/+69
| | | | | | | | | | | | | | | | | | | | This commit adds USB Type-C, Power Delivery and charging support to waddledoo. Waddledoo is using the new TCPMv2, low power mode has been disabled for the time being while we sort out issues with the TCPC. Currently in this state, we cannot actually receive any PD messages, but the PD task is running. BUG=b:147257992 BRANCH=None TEST=Build and flash on waddledoo, verify that we can detect Type-C chargers, and that it can charge a battery. Change-Id: Id30218ef685ed27a934bae3a580f47754f659ac6 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2001127 Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* Waddledoo: Add sensor supportDiana Z2020-01-141-20/+21
| | | | | | | | | | | | | | Waddledoo is using the BMI160 as a base accel and the BMA253 lid accel, which is compatible with the current bma2x2 driver. BUG=b:147258603 BRANCH=none TEST=builds Change-Id: Id76e826f11154f8b687021713a2bf176bd82fef4 Signed-off-by: Diana Z <dzigterman@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1993952 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* waddledoo: Add JSL supportAseda Aboagye2020-01-082-0/+51
| | | | | | | | | | | | | | | | | | | | | waddledoo is using the Intel Jasperlake chipset. This commit enables support for that chipset as well as adding the other related power sequencing signals. JSL uses the same chipset driver as ICL, but waddledoo doesn't have a couple of the power good pins that the driver assumes. Therefore, waddledoo overrides these power good signals using other logic. BUG=b:147257114,b:146172102 BRANCH=None TEST=`make -j BOARD=waddledoo` Change-Id: Ib4baa7ff38a4f59f751ecb16c22522eda71b6f4f Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1987837 Tested-by: Aseda Aboagye <aaboagye@chromium.org> Auto-Submit: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Diana Z <dzigterman@chromium.org>
* waddledoo: Add volume button supportAseda Aboagye2020-01-071-0/+1
| | | | | | | | | | | | | | | | waddledoo has dedicated volume buttons. BUG=b:146172102 BRANCH=None TEST=`make -j BOARD=waddledoo` Change-Id: I49c5f02d6e8ac66d4dac55208fb55aa16f83f5c4 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1989116 Tested-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Auto-Submit: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* waddledoo: Initial commitAseda Aboagye2020-01-074-3/+94
| | | | | | | | | | | | | | | | | | | This is the initial commit for waddledoo, the NPCX796FC variant of dedede. This commit adds ADC channels and i2c ports and some scaffolding such that the board will compile. More features will be coming in subsequent commits. BUG=b:146172102 BRANCH=None TEST=`make -j BOARD=waddledoo` Change-Id: I8277f6ce843fc155bd97f7f46fd96ab98cfe0881 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1988596 Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
* dedede: Add initial baseboard skeletonAseda Aboagye2020-01-033-0/+73
This commit simply adds the few baseboard files for dedede. It only contains support for the NPCX7 variant boards at the moment. BUG=b:146172102, b:146557556 BRANCH=None TEST=None Change-Id: I714dc44c5f54330f43fa20f31f982ac556eda9b9 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1986313 Tested-by: Aseda Aboagye <aaboagye@chromium.org> Auto-Submit: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Diana Z <dzigterman@chromium.org>
View Lorry Controller Status