summaryrefslogtreecommitdiff
path: root/baseboard/zork
Commit message (Collapse)AuthorAgeFilesLines
...
* morphius: update ps8818 usb rx settingZick Wei2020-10-152-0/+11
| | | | | | | | | | | | | | | | | | | This patch will update the ps8818 usb rx setting based on a CONFIG value. This will be set for all as the default of 112 Ohms and overridden by morphius to be 85 Ohms. BUG=b:169409479 BRANCH=zork TEST=verify that ps8818 register setting is as expected Signed-off-by: Denis Brockus <dbrockus@google.com> Change-Id: Iff492287efc9b12487ca0bb089f61486c4344c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2469613 Tested-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org> Auto-Submit: Denis Brockus <dbrockus@chromium.org>
* TBT:Add support for exit mode SOP'/SOP'' on chipset transitionAyushee2020-10-141-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When chipset is transitioning to a new state or on sysjump, the EC re-negotiates to enter an alternate mode on booting up. This commit adds support for exiting Thunderbolt mode for SOP' and SOP'' for active cable on chipset transition and also moves all the alternate mode exit rotines to their respective files. It also delays deleting the SVID data until after the EXIT_MODE message has ACKed and avoids pd_dfp_exit_mode() from changing the alternate mode's internal states. This commit also makes sure that the mux is set to safe state before exiting the alternate mode and it is reconfigured according to the port's current data role on receiving ACK/NAK from the cable/port partner. BUG=b:151169925, b:159717794 BRANCH=none TEST=On reboot, able to exit and re-enter into DisplayPort mode, Thunderbolt mode with passive cable and thunderbolt mode with active cable. Change-Id: If1e48e9f31cd678e23fe89bd3494551b5d1a78f1 Signed-off-by: Ayushee <ayushee.shah@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2415082 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* zork: Workaround VBUS=0 for charge_ramp_swEdward Hill2020-09-301-3/+22
| | | | | | | | | | | | | | | | | The ISL9241 sometimes incorrectly reports 0 for unknown reason, causing ramp to stop at 0.5A. Workaround this by ignoring 0. This partly defeats the point of ramping, but will still catch VBUS below 4.5V and above 0V. BUG=b:168569046 BRANCH=zork TEST=EC reboot with no battery and 65W charger, ramp to 3.25A @ 20V Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I2c08cc548b1fd67507865e7339e8168b0e53e628 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2438934 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* Revert "Zork: Workaround for bad ISL9241 CONTROL1 read"Edward Hill2020-09-291-30/+0
| | | | | | | | | | | | | | | | This reverts commit 61d40d6eaa88437d48e06fba9b773f7eb99f6ecc. Revert the workaround since CL:2393404 solved the problem. BUG=b:163076059 BRANCH=zork TEST=none Change-Id: I0397141b5b4e15736172474cb073842e18c3a71d Signed-off-by: Edward Hill <ecgh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2437194 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* berknip: Remove sensorsEdward Hill2020-09-291-0/+2
| | | | | | | | | | | | | | Remove motion sense (gyro + accel) drivers, since HW has none. BUG=b:166183179 BRANCH=zork TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I954bf491dd7cecf8a76d28b02ea100a0decb12d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2437191 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* zork: Ignore input current and always rampEdward Hill2020-09-231-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | CONFIG_CHARGE_RAMP_SW is designed to stop ramping if we are not using enough current (so we are actually testing that the supplier can give the current we ramp to). But this is checked using charge_is_consuming_full_input_current(), which only tests for battery charge between 2% and 95%. This fails to accurately reflect desire for input current, because the low battery might want to charge faster, and the AP might want extra power even with full battery. For zork, change charge_is_consuming_full_input_current() to always return true. This means we will always ramp. If we are not using the full input current, and the supplier cannot deliver it when we do, then we will detect the voltage drop and re-ramp, which seems fine. BUG=b:168569046 BRANCH=zork TEST=ramp with full battery Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Ic7c9b93bdd3856c9b05bd3a13e8c2a78aa883755 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2426950 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* zork: Update PS8802/PS8818 IN_HPD to match HW changesEdward Hill2020-09-232-4/+7
| | | | | | | | | | | | | | | | Add a global variable board_usbc1_retimer_inhpd that boards can set to IOEX_USB_C1_HPD_IN_DB or GPIO_USB_C1_HPD_IN_DB_V1 depending on board version, that is then used by board_ps8802/ps881_mux_set to enable/disable IN_HPD on the DB retimer. BUG=b:168884674 BRANCH=zork TEST=morphius dali + picasso USB-C1 display works Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Ifca733ce05a72cc095463b2b9365857232784d34 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2426959 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* zork: Disable CONFIG_KEYBOARD_VIVALDIEdward Hill2020-09-231-0/+1
| | | | | | | | | | | | | | | | | Disable Vivaldi keyboard for all Zork devices since Vivaldi currently does not allow for side volume buttons to be distinguished from keyboard volume F9/F10 keys. This is necessary so that Chrome can ignore F9/F10 in tablet mode, but side volume buttons still work. BUG=b:164207227 BRANCH=zork TEST=side buttons + F9/F10 in clamshell + tablet modes Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Ia3d9fa89e54e637e7cf61ac318e7cfe928923ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2426120 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* zork: move HDMI retimer setting to variantZick Wei2020-09-221-7/+0
| | | | | | | | | | | | | | This CL move HDMI retimer(pi3hdx1204) setting to variant. BUG=none BRANCH=zork TEST=make buildall Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I5b50058c44ccb9fd5d9403939d5f4ea9a9670b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2421391 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* zork: Adjust AP power limitsEdward Hill2020-09-171-11/+5
| | | | | | | | | | | | | | | | | | | | | | | | Adjust EC config settings that control how much battery charge and AC power is required to allow AP to boot, to align with how much power the HW actually needs. EC will boot AP to depthcharge if: (BAT >= 4%) || (AC >= 50W) CONFIG_CHARGER_LIMIT_* is not set, so there is no additional restriction on Depthcharge to boot OS. BUG=b:162938720 BRANCH=zork TEST=boot with: - various battery and AC levels, - plugged/unplugged battery, - locked/unlocked EC, - swsync GBB disabled/enabled Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I78aa84b8b0b18429d1301085ab878c62a4afd687 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2415629 Reviewed-by: Furquan Shaikh <furquan@chromium.org>
* zork: Re-Enable CONFIG_CHARGE_RAMP_SWEdward Hill2020-09-022-0/+27
| | | | | | | | | | | | | | | We would prefer to use CONFIG_CHARGE_RAMP_HW to enable legacy BC1.2 charging but that feature of ISL9241 is broken (b/160287056) so we have to use CONFIG_CHARGE_RAMP_SW instead. BUG=b:163864475,b:167257846 BRANCH=none TEST=ramp up to 1.5A from legacy charger Signed-off-by: Denis Brockus <dbrockus@chromium.org> Change-Id: I636e2bd6db57c11ce6da24cc2417b35bb59c6d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2388081 Reviewed-by: Edward Hill <ecgh@chromium.org>
* Revert "zork: Enable CONFIG_CHARGE_RAMP_SW"Denis Brockus2020-08-312-27/+0
| | | | | | | | | | | | | | | | | This reverts commit 8a768a06bc876f83427691d27b4e572418406875. Reason for revert: The code as it stands breaks PD charging, so no battery charging is functional when this is landed. BUG=b:163864475,b:167257846 BRANCH=none TEST=verify Zork PD charging works Change-Id: I2c8b006e6add2e328840647367068449be28f7a6 Signed-off-by: Denis Brockus <dbrockus@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2386024 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* zork: Remove debug printEdward Hill2020-08-311-1/+0
| | | | | | | | | | | | | | Remove print accidentally left in board_is_vbus_too_low in CL:2382635. BUG=b:163864475 BRANCH=zork TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I261e634fb0ddf7edf4484906d01cbf4c251aac2b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2384532 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* zork: Enable CONFIG_CHARGE_RAMP_SWEdward Hill2020-08-302-0/+28
| | | | | | | | | | | | | | We would prefer to use CONFIG_CHARGE_RAMP_HW to enable legacy BC1.2 charging but that feature of ISL9241 is broken (b/160287056) so we have to use CONFIG_CHARGE_RAMP_SW instead. BUG=b:163864475 BRANCH=zork TEST=ramp up to 1.5A from legacy charger Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Iec0a4b82f42fd388d738362ce9a8de4d31c61054 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2382635
* zork: Use gpio_or_ioex_set_level for PORT_TO_HPDEdward Hill2020-08-291-2/+2
| | | | | | | | | | | | | Fix a couple of places missed in CL:2366456 BUG=b:161860605 BRANCH=zork TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Icb49da01b3575cfd81f57f01efcafea534212d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2380160 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* zork: Delay between G3 exit and power buttonEdward Hill2020-08-292-0/+21
| | | | | | | | | | | | | | On G3->S5, wait for GPIO_EC_FCH_RSMRST_L to be deasserted before asserting GPIO_EC_FCH_PWR_BTN_L. BUG=b:164921478 BRANCH=zork TEST=power button timing Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Ib16f8ccf795382a26e70fd505e03c59db4eeaa88 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2378558 Reviewed-by: Furquan Shaikh <furquan@chromium.org>
* Ezkinil: Fix HDMI retimer suspend / resumeEdward Hill2020-08-222-16/+0
| | | | | | | | | | | | BUG=none BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I9eac47383695156ca0d222eb75f75492065720b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2364112 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* Zork: Workaround for bad ISL9241 CONTROL1 readSue Chen2020-08-221-0/+30
| | | | | | | | | | | | | | | | | | Sometimes CONTROL1 was read 0xFF03 for unknown reason when the state change from S0 to S3, but the second read will get the correct 0x0103. Retry CONTROL1 read before update learn mode to make sure write the correct value. BUG=b:163076059 b:163136699 BRANCH=none TEST=none Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: Iec56dab838b0aa362c543cce74d64615faf40bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2362386 Tested-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* trembyle: correctly pass USB-C1 HPD to the MST hubPeter Marheine2020-08-212-2/+32
| | | | | | | | | | | | | | | | | | | | | | | The RTD2141 MST hub on some daughterboard options requires the EC to drive its HPD input because HPD comes over USB-PD, but the MST hub then drives the AP's HPD input. The EC was incorrectly driving nothing, causing DP outputs on port C1 to not be detected. Because the MST's HPD input is connected to an IO expander on current hardware, configure the USB-C and Trembyle-specific HPD twiddling code to support regular or expander GPIOs. Experience says IO expanders tend to be too slow for reliable HPD, but this should allow some (possibly flaky) HPD support until hardware changes are completed to put the output directly on an EC GPIO. BUG=b:159051013,b:165622386 TEST=still builds (I have no v3 hardware to test against) BRANCH=None Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: I9e041ab7c222927a11b8972920b7e978ab30d751 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2366456 Reviewed-by: Edward Hill <ecgh@chromium.org>
* Zork: Add command to print temps periodicallyEdward Hill2020-08-202-0/+44
| | | | | | | | | | | BUG=b:162907613 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Iddbba7d7955f252cacf666528195bbfc7d9718e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2365633 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* Zork: Remove CONFIG_CHARGE_RAMP_HWEdward Hill2020-08-131-1/+0
| | | | | | | | | | | | | | | Remove CONFIG_CHARGE_RAMP_HW to disable ISL9241_CONTROL0_INPUT_VTG_REGULATION since the ISL9241 fails to detect charger unplug with input voltage loop enabled. BUG=b:160287056 BRANCH=none TEST=charging and ac on/off works Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Ib0cb366204562ad725b35d2e24a89831dce7b7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2340682 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* trembyle: Use board_version for I2C_PORT_CHARGER_V0Edward Hill2020-08-111-19/+0
| | | | | | | | | | | | | | Change to use CBI board_version for I2C_PORT_CHARGER_V0 instead of probing I2C. BUG=b:155214765 BRANCH=none TEST=boot to OS Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Id3e9d874439277af4d1c88acd6ab40a6bbea73ee Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2343742 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* Ezkinil: Add AOZ1380 for DB TYPEC C1Sue Chen2020-08-071-1/+1
| | | | | | | | | | | | | | | | | | | IOEX01 USB_C1_POWER_SWITCH_ID check which ppc chip is supported. 0 for NX20P3483UK 1 for AOZ1380DI IOEX10 USB_C1_PPC_ILIM_3A_EN to set vbus source current limit 3A BUG=b:159634750 BRANCH=none TEST=make sure C1 ppc_config setup correctly on AOZ board. USB_C1_PPC_ILIM_3A_EN change level as plugging device in/out port 1. Change-Id: I1211ba39a02b8e42488dc56f110bc736e66ff41d Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2253489 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* isl9241: Set AC prochotEdward Hill2020-08-052-0/+10
| | | | | | | | | | | | | | Allow AC prochot threshold to be increased to match PD max current. BUG=b:162376053 b:162565066 BRANCH=none TEST=prochot not asserted while battery charges Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I11761e8d2d15b52f7552e8d951c6633583ab5ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2334353 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Tested-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
* zork: move board_get_temp to variantZick Wei2020-08-033-32/+33
| | | | | | | | | | | | | | | This patch rename thermal sensor name by placement for morphius, and move board_get_temp from baseboard to variant BUG=b:162325433 BRANCH=none TEST=verify that thermal sensor name change in EC console Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I46dfe5c8ebef29ed6ee7fdf342cfad9d39fe6ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2325496 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* zork: don't turn off vbus if we aren't sourcing vbusDenis Brockus2020-07-281-10/+9
| | | | | | | | | | | | | | | | | | | Turning off vbus when we are not sourcing vbus causes a bad behavior when we are cold booting in a batterless manner. So made it conditional so we would be able to run correctly with and without battery BUG=b:162016100 BRANCH=none TEST=trembyle cold boot with only AC power Signed-off-by: Denis Brockus <dbrockus@google.com> Change-Id: I77ad0487887078d6dd7514fd375558f10737fccb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2317892 Tested-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Auto-Submit: Denis Brockus <dbrockus@chromium.org>
* zork: Re-enable CONFIG_KEYBOARD_VIVALDIEdward Hill2020-07-201-1/+0
| | | | | | | | | | | | | | | Enable Vivaldi keyboard for all Zork devices now that the related coreboot support is present. BUG=b:156200330 BRANCH=none TEST=enter recovery, enter VT2 Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Id64a1243aa3845bc61b05f62d888e6b84a8efda9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2307716 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* zork: Use CBI only and remove retimer probe codeDenis Brockus2020-07-172-12/+1
| | | | | | | | | | | | | | | | | | | Before CBI was being used, zork used I2C probing to detect basic hardware configuration. Now that CBI is supporting FW_CONFIG, this is being removed. BUG=b:151232257 BRANCH=none TEST=verify zork still boots with valid configuration Signed-off-by: Denis Brockus <dbrockus@google.com> Change-Id: I267d99f8f3894aff2f6301df167c470db373509e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2304380 Commit-Queue: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org> Auto-Submit: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org>
* zork: Enable 65W/3.25A PD adapter.Lu Zhang2020-07-171-2/+2
| | | | | | | | | | | BUG=b:161400534 BRANCH=none TEST=make buildall -j Signed-off-by: Lu Zhang <lu.zhang@bitland.corp-partner.google.com> Change-Id: I50c82ea82260e3ef67f19229854bfcc86f11a350 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2304236 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Commit-Queue: Peter Marheine <pmarheine@chromium.org>
* USB PD: Move board FRS configuration out of TCPCIEric Herrmann2020-07-172-5/+1
| | | | | | | | | | | | | | | | | Board FRS configuration is more board-specific than TCPC-specific. Move the board FRS configuration from TCPCI to usb_common. Implementing the board-level frs configuration is optional for each project. BUG=b:148144711 TEST=Can build volteer image with CONFIG_USB_PD_TCPC set BRANCH=none Change-Id: I43d13ec0b23f71273807f58db35e7dd333089efa Signed-off-by: Eric Herrmann <eherrmann@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2290838 Reviewed-by: Keith Short <keithshort@chromium.org>
* zork: Enable CONFIG_I2C_UPDATE_IF_CHANGEDEdward Hill2020-07-131-0/+1
| | | | | | | | | | | | | | Enable CONFIG_I2C_UPDATE_IF_CHANGED to reduce I2C traffic a little. BUG=none BRANCH=none TEST=USB-C source and sink still work. Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Id7ec18df00e421570d3e7c897be810014bbbbb5e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2294002 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* Zork: Handle USB_Cx_SBU_FAULT_ODLEdward Hill2020-07-123-0/+12
| | | | | | | | | | | | | | Connect up USB_Cx_SBU_FAULT_ODL to pd_handle_overcurrent(). BUG=b:138600586 b:157058003 BRANCH=none TEST=USB-C sink and source still works, forcing USB_Cx_SBU_FAULT_ODL low is reported as fault. Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I59ae65eed169fc5e18f72539a68017bb73c7d93e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2293102 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* Charger: Add dynamic charger chip countDiana Z2020-07-112-3/+0
| | | | | | | | | | | | | | | | Different DB options may cause different numbers of charger chips to be present on the system. Remove constant count for charger chips, and instead always call into the overridable function to query the count. BRANCH=None BUG=b:155963446 TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I0e65b8af351ecabe6f7b823e0e56f1932cc280a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2277833 Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* Zork: remove pd_snk_is_vbus_providedEdward Hill2020-07-101-5/+0
| | | | | | | | | | | | | | | Zork uses CONFIG_USB_PD_VBUS_DETECT_TCPC and ppc_is_vbus_present() doesn't exist. BUG=none BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I7eebf598a6bc3caf636111545a4c5e9511662d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2290662 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* Zork: Remove CONFIG_HOSTCMD_SKUIDEdward Hill2020-07-082-18/+9
| | | | | | | | | | | | | | | Coreboot has changed to use CBI, so CONFIG_HOSTCMD_SKUID is no longer needed and can be cleaned up. BUG=b:138600504 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Ib9fc1d190d994311f2efcae77821489eddf3cea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2288152 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* Revert "TCPMv2: make sure Vbus is not sourced in AttachWait.SRC"Denis Brockus2020-07-081-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | Commit sha 57b95363c05bdab7b7e57d553a9514128393247d Reverting a CL that was a temporary fix while a real solution was found. This will now be implemented with the following CLs https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2282691 https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2282699 https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2283697 BUG=none BRANCH=none TEST=make buildall Signed-off-by: Denis Brockus <dbrockus@google.com> Change-Id: I76b92388f5ee5bae4bdb945a82f18eb3df3ab1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2284728 Tested-by: Denis Brockus <dbrockus@chromium.org> Auto-Submit: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* woomax: Update USB-A and FW_CONFIGEdward Hill2020-07-032-15/+0
| | | | | | | | | | | | | Remove USB-A1 and correct FW_CONFIG. BUG=b:160293750 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I6e415c3dac85905af812ac5ce26ad3bbf4fcf869 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2277212 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* TCPMv2: make sure Vbus is not sourced in AttachWait.SRCDenis Brockus2020-07-011-2/+4
| | | | | | | | | | | | | | | | | | | | | | | The TCPC on zork appears to enable Vbus sourcing some of the time when we come out of auto-toggle. It looks like about a 60ms delay before it is enabled. We then go to AttachWait.SRC and since the exit condition to get to Attached.SRC is a debounced/valid Attached.SRC CC and Safe0V, it has to be disabled manually in order to move to Attached.SRC BUG=b:160227699,b:160253746 BRANCH=none TEST=dut-control servo_v4_role:snk should attach Signed-off-by: Denis Brockus <dbrockus@google.com> Change-Id: I1dfc5d2536aaa4d7a5ffc7bbb52c647b15764196 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2276463 Tested-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Auto-Submit: Denis Brockus <dbrockus@chromium.org>
* berknip/morphius: update gpio S0_PWROK_ODZick Wei2020-06-252-24/+25
| | | | | | | | | | | | | | | This patch update S0_PWROK_OD for schematic change. BUG=b:150278507, b:152841287 BRANCH=none TEST=make buildall, verify EC code can power on rework MB. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Iaf8f2458c2dfe49f40eada8dced1febe2c4c4687 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2255826 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org> Tested-by: Edward Hill <ecgh@chromium.org>
* npcx: Add a new flag to check for initial power-onAndrew McRae2020-06-231-4/+3
| | | | | | | | | | | | | | | | | | | | | The CR50 will reset the EC on some platforms after power-on. Add a reset flag to detect this and treat the second restart as a power-on restart rather than reset. Subsume the CONFIG_GPIO_INIT_POWER_ON_DELAY_MS config to make it clear what the behaviour will be. BUG=b:151329011 TEST=Confirm on dalboz, puff & variants that second reset is treated correctly. BRANCH=none Change-Id: Ib66de920403f08099b87d1eff797270606b44f8f Signed-off-by: Andrew McRae <amcrae@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2255830 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Commit-Queue: Andrew McRae <amcrae@chromium.org> Tested-by: Andrew McRae <amcrae@chromium.org>
* Zork: Don't KB_SCAN_DISABLE_LID_ANGLE in S0Edward Hill2020-06-201-2/+17
| | | | | | | | | | | | | | Keep keyboard scan enabled in tablet mode if the AP is in S0, so AP can decide whether to ignore input devices or not. BUG=b:159456704 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I7e71e2b8d593732315caa73cf585e5d20e5eb9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2254981 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* morphius: add ppc aoz1380Zick Wei2020-06-192-2/+2
| | | | | | | | | | | | | This patch add ppc aoz1380 on daughter board. BUG=b:156552519, b:159282505 BRANCH=none TEST=make buildall Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I5ca87a2d524ee265626e5b163754a33dcb31853d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2251127 Reviewed-by: Edward Hill <ecgh@chromium.org>
* TCPMv2: Add pathway to enable FRS from PPC driverEric Herrmann2020-06-181-2/+2
| | | | | | | | | | | | | | | Some PPCs have integrated CC line detection to trigger FRS faster, but this needs to be enabled from the USBC policy engine only after the sink capabilities have been exchanged. BUG=b:148144711 TEST=make buildall BRANCH=none Change-Id: Iaa64f64845c5ffdd32fa66a3eb6f6251abb7c157 Signed-off-by: Eric Herrmann <eherrmann@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2056493 Reviewed-by: Keith Short <keithshort@chromium.org>
* berknip: add 5V regulator temperature sensorDevin Lu2020-06-152-2/+4
| | | | | | | | | | | | | | | Add a thermistor which near to 5V regulator. BUG=b:157711232 BRANCH=none TEST=Verified console "temps" can read temperature. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: I0020fc74b9b4b3f16dae7a1263e793ec2783b665 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2234047 Commit-Queue: Edward Hill <ecgh@chromium.org> Tested-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org>
* zork/baseboard: move temperature sensors definition to board variantDevin Lu2020-06-153-70/+48
| | | | | | | | | | | | | | | | | There are some differences with temperature sensors for each zork variant. This patch move temperature sensors definition to board variant. BUG=b:157711232 BRANCH=none TEST=Verified console "temps" can read temperature. Build all zork board variant. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: Ib109ea5adc98e6b6825f8c91db19911dc682a52e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2227787 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org> Tested-by: Edward Hill <ecgh@chromium.org>
* Zork: Disable PI3HDX1204 when HDMI didn't connect.David Huang2020-06-132-2/+11
| | | | | | | | | | | | | | Disable PI3HDX1204 when HDMI didn't connect for saving 1W in S0. BUG=b:158136599 BRANCH=none TEST=check pi3hdx1204 register setting is correct. Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com> Change-Id: I9170cf56b34d71abcdd430bd7d8d7f3839de2558 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2234046 Reviewed-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Vincent Wang <vwang@chromium.org>
* TCPMv2: Support mode entry for SOP' and SOP''Abe Levkoy2020-06-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | Add a transmit type parameter to functions involved in mode entry; also add such a parameter to various functions calling those functions. For DisplayPort-specific definitions or calls, specify SOP; we do not currently support DisplayPort mode for cable plugs. For TCPMv1-specific code, specify SOP. TCPMv1 generally assumes that the discovery/mode structures are 1-dimensional, as they were previously, and changing that is outside the scope of this CL. BUG=b:155890173 TEST=Enter DP mode on Volteer with TCPMv2 TEST=Enter DP mode on Volteer with TCPMv1 TEST=Enter TBT mode on Volteer with TCPMV1 BRANCH=none Change-Id: I8afc75b3f3be8939c4645058ac4a31f24c88fb9e Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2229279 Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Diana Z <dzigterman@chromium.org>
* vilboz: Remove ioex C1 and config the ioexpander gpioLu Zhang2020-06-113-19/+21
| | | | | | | | | | | | BUG=b:158125500 BRANCH=none TEST=make buildall -j Signed-off-by: Lu Zhang <lu.zhang@bitland.corp-partner.google.com> Change-Id: Ica8cdd8f0b14f612f17018a3a95df5a23a6ad43f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2239593 Reviewed-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* vilboz: Split mux to dalboz and vilbozLu Zhang2020-06-104-91/+18
| | | | | | | | | | | | BUG=b:158125500 BRANCH=none TEST=make buildall -j Signed-off-by: Lu Zhang <lu.zhang@bitland.corp-partner.google.com> Change-Id: I0836daf254f1c1c1fb2d7fd45868b55517689cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2235236 Reviewed-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* Ezkinil: modify some gpio definitionSue2020-06-052-22/+0
| | | | | | | | | | | | | | | | | | | rename GPIO F4: DP1_HPD -> EC_DP1_HPD remove IOEX 10 HDMI_CONN_HPD_3V3_DB add GPIO 75: DP1_HPD_EC_IN move hdmi_hpd_interrupt and hdmi_hpd_handler from baseboard to board BUG=b:152512560, b:153397667, b:155797182 BRANCH=none TEST=make buildall -j Change-Id: I5cdbb42a8284c85104dbbbe7b3d557d51a11a074 Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2224693 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org> Tested-by: Edward Hill <ecgh@chromium.org>
View Lorry Controller Status