summaryrefslogtreecommitdiff
path: root/baseboard
Commit message (Collapse)AuthorAgeFilesLines
* ish: Trim down the release branchstabilize-wristpin-14469.59.B-ishstabilize-voshyr-14637.B-ishstabilize-quickfix-14695.187.B-ishstabilize-quickfix-14695.124.B-ishstabilize-quickfix-14526.91.B-ishstabilize-14695.85.B-ishstabilize-14695.107.B-ishstabilize-14682.B-ishstabilize-14633.B-ishstabilize-14616.B-ishstabilize-14589.B-ishstabilize-14588.98.B-ishstabilize-14588.14.B-ishstabilize-14588.123.B-ishstabilize-14536.B-ishstabilize-14532.B-ishstabilize-14528.B-ishstabilize-14526.89.B-ishstabilize-14526.84.B-ishstabilize-14526.73.B-ishstabilize-14526.67.B-ishstabilize-14526.57.B-ishstabilize-14498.B-ishstabilize-14496.B-ishstabilize-14477.B-ishstabilize-14469.9.B-ishstabilize-14469.8.B-ishstabilize-14469.58.B-ishstabilize-14469.41.B-ishstabilize-14442.B-ishstabilize-14438.B-ishstabilize-14411.B-ishstabilize-14396.B-ishstabilize-14395.B-ishstabilize-14388.62.B-ishstabilize-14388.61.B-ishstabilize-14388.52.B-ishstabilize-14385.B-ishstabilize-14345.B-ishstabilize-14336.B-ishstabilize-14333.B-ishrelease-R99-14469.B-ishrelease-R98-14388.B-ishrelease-R102-14695.B-ishrelease-R101-14588.B-ishrelease-R100-14526.B-ishfirmware-cherry-14454.B-ishfirmware-brya-14505.B-ishfirmware-brya-14505.71.B-ishfactory-kukui-14374.B-ishfactory-guybrush-14600.B-ishfactory-cherry-14455.B-ishfactory-brya-14517.B-ishJack Rosenthal2021-11-05181-25168/+0
| | | | | | | | | | | | | | | | | | | | | | In the interest of making long-term branch maintenance incur as little technical debt on us as possible, we should not maintain any files on the branch we are not actually using. This has the added effect of making it extremely clear when merging CLs from the main branch when changes have the possibility to affect us. The follow-on CL adds a convenience script to actually pull updates from the main branch and generate a CL for the update. BUG=b:204206272 BRANCH=ish TEST=make BOARD=arcada_ish && make BOARD=drallion_ish Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I17e4694c38219b5a0823e0a3e55a28d1348f4b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3262038 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* cherry: enable DPSEric Yilun Lin2021-09-281-0/+1
| | | | | | | | | | | | | | | Enable Dynamic PDO Selection to provide a more efficient charging. BUG=b:196911733 TEST=Pass PD FAFT and FAFT-EC BRANCH=none Change-Id: Ie615d63fbca54bf70412367e8f3befabd7db5832 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3124474 Tested-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com>
* zephyr: Fix broken volteer buildJeremy Bettis2021-09-271-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On github, the volteer build was failing with error: undefined reference to `ppc_is_vbus_present' but it was building in the chroot. It seems the chroot linker can determine that the pd_snk_is_vbus_provided function is never called, but the zephyr toolchain linker cannot, or perhaps it does missing function detection before removing unused functions. Remove pd_snk_is_vbus_provided if CONFIG_USB_PD_VBUS_DETECT_PPC is not set. BRANCH=None BUG=b:194375840 TEST=In docker container: PROJECT=volteer; PROJECT_SUBDIR=volteer/; VERSION=26; unset TOOLCHAIN zmake -j1 --zephyr-base "${ZEPHYR_BASE}${VERSION}" \ --modules-dir "${MODULES_DIR}" -l DEBUG configure -b \ -B "${BUILD_DIR}/${PROJECT}" -t ${TOOLCHAIN:-zephyr} \ zephyr/projects/${PROJECT_SUBDIR}${PROJECT} In chroot: zmake configure -b zephyr/projects/volteer/volteer Change-Id: I59679a12e89e8b2e5fa2f62dc5fa60d108234d23 Signed-off-by: Jeremy Bettis <jbettis@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3188214 Reviewed-by: Yuval Peress <peress@google.com> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Reviewed-by: Aaron Massey <aaronmassey@google.com> Reviewed-by: Parth Malkan <parthmalkan@google.com> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Yuval Peress <peress@google.com> Commit-Queue: Fabio Baltieri <fabiobaltieri@google.com> Tested-by: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
* tomato: board rev2 gpio updateTing Shen2021-09-231-1/+1
| | | | | | | | | | | | | | | | | | | GPA4/GPA5: kb backlight -> Programming I2C GPA3: Test point -> KB_BL_PWM GPA6: Test point -> EN_KB_BL Since the PWM pin changed, this CL breaks kb backlight on old boards. BUG=b:199829459 TEST=pass factory test BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I33c42708b7694aeb625ea5b0879b3ac08ec81f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3160457 Reviewed-by: Eric Yilun Lin <yllin@google.com> Tested-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org>
* cherry: enable CONFIG_USB_PORT_POWER_DUMB_CUSTOM_HOOKTing Shen2021-09-232-0/+4
| | | | | | | | | | | | | | | | | | | CL:3023017 does not work as expected because usb_port_power_dump module still controls the power power. This CL disables the hooks in usb_port_power_dump and enables the interrupt function usb_a0_interrupt instead. BUG=b:193499785 TEST=verify USB-A port works after this change BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I56196f2a062d6b3358a9a4330e7f33ab546f5d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3174606 Reviewed-by: Rong Chang <rongchang@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* board/guybrush-dewat: Minor cleanupGwendal Grignou2021-09-231-1/+2
| | | | | | | | | | | | | | | Remove g_bmi323 static variable, use same structure as bmi160. Fill motion_sensors array with index in order. BUG=b:195264765 BRANCH=none TEST=compile Change-Id: I2c16fa64db7786bf5ff977cd6626c3d9de9b66b4 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3172268 Reviewed-by: Rob Barnes <robbarnes@google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
* cherry: redesign RT1718S GPIO 1/2 behaviorTing Shen2021-09-223-48/+10
| | | | | | | | | | | | | | | | | | | | | | | Reimplement the logic of GPIO 1/2 such that the state of these pins does not tied together anymore. Instead, board_set_active_charge_port controls GPIO 1 only, and pd_power_supply_* functions controls GPIO 2 only. Also give these pins a readable name. BUG=b:198707662 TEST=1) pass faft_pd on port C1 2) able to boot with C1 plugged AC power and without battery BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: Id33160a0c3ed202cdfe3666c2444098a3031229f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3168036 Reviewed-by: Rong Chang <rongchang@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* byra: Disable ACPI messages on EC console by defaultGwendal Grignou2021-09-221-2/+5
| | | | | | | | | | | | | | | | | | When using sensors a lot of messages are sent, overwhelming the EC console port. BUG=none BRANCH=master TEST=When running "tast run <ip hardware.SensorIioserviceHard", check the EC console is not overflown with message like: 21-09-17 23:01:41.981 [444.007624 ACPI query = 27] 21-09-17 23:01:42.053 [444.086884 event set 0x0000000004000000] 21-09-17 23:01:42.057 [444.087864 event clear 0x0000000004000000] Change-Id: I825831d83ce468d719b4303abadec4e2e0a0d1af Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3170173 Reviewed-by: Keith Short <keithshort@chromium.org>
* mancomb: Delete board supportJack Rosenthal2021-09-207-1585/+0
| | | | | | | | | | | | | | | | | | Builders have been shutoff, and overlays are gone. EC board support can be dropped. BUG=b:190404616 BRANCH=none TEST=CQ Cq-Include-Trybots: luci.chromeos.cq:cq-orchestrator Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I0c7c3f003c9c3ec66101e6b16b17585bd85e70fb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3171108 Commit-Queue: Martin Roth <martinroth@google.com> Tested-by: Martin Roth <martinroth@google.com> Reviewed-by: Martin Roth <martinroth@google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
* adlrvp: Support EC_CMD_BATTERY_GET_STATIC version 1poornima tom2021-09-171-0/+8
| | | | | | | | | | | | | | | | | | | Support for EC_CMD_BATTERY_GET_STATIC version-1 is added to prevent an ioctl error, on entry of ectool battery command. BUG=none BRANCH=none TEST=Verify on adlrvp using ectool battery command ectool battery command returned correct battery information without any ioctl error. Signed-off-by: poornima tom <poornima.tom@intel.com> Change-Id: I359241e8696da0f83e649a920953bc25a88bb0a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3156318 Reviewed-by: Vijay Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* adlrvp: Remove retimer support for N SKUpoornima tom2021-09-172-0/+17
| | | | | | | | | | | | | | | | | | Type-C ports of ADL-N based RVP SKU do not have retimers. Hence, removed the reference for retimers based on board id of the ADL-N platform at run time. BUG=none BRANCH=none TEST=Tested on ADL-N Signed-off-by: poornima tom <poornima.tom@intel.com> Change-Id: I0e57fc199cc4a0192056eff35ba10fbac457cf4f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3143407 Reviewed-by: Vijay Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: caveh jalali <caveh@chromium.org> Tested-by: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com> Commit-Queue: caveh jalali <caveh@chromium.org>
* herobrine: Always enable the 5V railWai-Hong Tam2021-09-162-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Prepare the next hardware revision. It has a PPC chip which requires 5V rail in S5. The 5V rail enable pin should be turned on whenever the EC is powered. Since the existing 5V rail enabling is done inside the qcom power sequence. Trogdor and Herobrine both shares this qcom power sequence. For Trogdor, this CL moves the 5V rail enabling from the qcom power sequence to the board level hook. For Herobrine, this CL updates the GPIO name and modifies the default level to HIGH. The CONFIG of 5V control should be disabled. As no board level hook to modify the 5V rail, the 5V is always on. BRANCH=None BUG=b:199804198 TEST=Booted both Zephyr and EC-OS images on Herobrine. Checked the 5V rail is enabled in S0 and S5. TEST=Booted both Zephyr and EC-OS images on Lazor. Checked the 5V rail is enabled in S0 and disabled in S5. Change-Id: Ifa98ee0c4e970dd89952e94cc6a0e289798e6a57 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3163918 Reviewed-by: Keith Short <keithshort@chromium.org>
* BB Retimer: Add new HPD callback to boardsDiana Z2021-09-161-0/+6
| | | | | | | | | | | | | | | Now that the BB retimer has its own HPD interface, add this interface to every board using the bb_usb_retimer driver. BRANCH=None BUG=b:195773400 TEST=on voxel, pass tast typec.Mode*.manual Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Ia70d139431739e8f2c0577359cb3aaa7fb906d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3163930 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* USB MUX: Update mux HPD update interface to use mux_state_tDiana Z2021-09-1610-17/+46
| | | | | | | | | | | | | | | | | Since the drivers are now taking a mux_state_t set of flags to update, go ahead and unify the usb_mux API this way as well. It makes the parameters more apparent than the 1/0 inputs, and aligns the stack to use the same parameters. BRANCH=None BUG=b:172222942 TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Ie943dbdf03818d8497c0e328adf2b9794585d96e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3095438 Commit-Queue: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* keeby: Update USB PID to 0x5059Aseda Aboagye2021-09-151-1/+1
| | | | | | | | | | | | | | | | | | The allocation for keeby's USB PID never actually landed, so it was taken by another project. A new allocation has been made, and this commit updates the USB PID in the EC to match. BUG=None BRANCH=firmware-keeby-14119.B TEST=`make -j BOARD=lalala` Signed-off-by: Aseda Aboagye <aaboagye@google.com> Change-Id: Ie9e05de3fd2488c6f19b607e1323e9d193bb6753 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3163308 Tested-by: Aseda Aboagye <aaboagye@chromium.org> Auto-Submit: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Diana Z <dzigterman@chromium.org>
* brask: Add led controlDavid Huang2021-09-151-4/+1
| | | | | | | | | | | | | | | Add led control from puff. BUG=b:197471359 BRANCH=none TEST=make buildall -j succeeded. Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com> Change-Id: Iab7d9c207d72c18658c3345c4467b20a23e48b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3139714 Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> Commit-Queue: Boris Mittelberg <bmbm@google.com>
* cherry: code cleanupstabilize-rust-14220.B-mainTing Shen2021-09-142-83/+0
| | | | | | | | | | | | | | | | | | | | | 1) remove board_overcurrent_event since CL:2532676 added a default empty implementation 2) remove GPIO_EN_KB_BL control since it's already handled in keyboard_backlight.c 3) remove unused header includes 4) remove unused it5205 sbu handler BUG=none TEST=make BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I0231ba6c6bf16fa0fc1bf52fd77815271e79dcbb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3160456 Tested-by: Ting Shen <phoenixshen@chromium.org> Auto-Submit: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Rong Chang <rongchang@chromium.org> Commit-Queue: Rong Chang <rongchang@chromium.org>
* rt1718s: refactor: move gpio control to driver moduleTing Shen2021-09-141-39/+18
| | | | | | | | | | | | | | | | | | | | This CL moves RT1718S gpio control from board file to common driver codebase, and implements the set flag and get/set level functions. Note that this CL does not fully implement IOEX interface because TCPC has different init process than usual ioexpanders. BUG=none TEST=1) pass faft_pd 2) manually test pd source/sink/frs on port 1 BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: If2a0bca2b13ad4748eea54b4c8004da7dc6fc6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3159643 Reviewed-by: Rong Chang <rongchang@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* kukui: Enable brief asserts to free flash spaceRob Barnes2021-09-131-0/+1
| | | | | | | | | | | | | | Enable CONFIG_DEBUG_ASSERT_BRIEF in RO to free flash space. Brief asserts print only the file name and the line number. BUG=None TEST=Build all BRANCH=None Change-Id: I65334ad2c50e4c70f25af7dbbe03302d7d541bc7 Signed-off-by: Rob Barnes <robbarnes@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3157760 Reviewed-by: Keith Short <keithshort@chromium.org>
* cherry: adjust charger input voltage limitTing Shen2021-09-131-0/+12
| | | | | | | | | | | | | | | | | | | | When the system is powered by 5V/3A adapter from C1 port, the long PPVAR_VBUS_IN trace will cause large IR drop with high input current and PPVAR_VBUS_IN voltage will hit ISL9238C input voltage limit, then ISL9238C will decrease the sink current to make PPVAR_VBUS_IN valid. See b:198707662 comment#9 for more detail. BUG=b:198707662 TEST=check the register value of 0x4B BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I148e8943b295a73d27a9bc381309d074b053fb85 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3153621 Reviewed-by: Rong Chang <rongchang@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* asurada: move the hibernate routine into separate fileTim Lin2021-09-103-23/+38
| | | | | | | | | | | | | | | | | | Move the hibernate routine from baseboard.c to separate hibernate.c files. BUG=b:198305804 BRANCH=none TEST=make BOARD=asurada -j The interrupt of GPIO_AC_PRESENT can wake up CPU in hibernate mode. Signed-off-by: Tim Lin <tim2.lin@ite.corp-partner.google.com> Change-Id: I0aea0b812f535c907ac8963fc1f09206dfef5956 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3146773 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* brya: support EC_CMD_BATTERY_GET_STATIC version 1Deepti Deshatty2021-09-091-0/+7
| | | | | | | | | | | | | | | | | ectool battery command returns the battery information correctly but returns an ioctl error as EC_CMD_BATTERY_GET_STATIC do not support version 1. Changes enable the command version 1. BRANCH=none BUG=b:197836974 TEST=Verified ectool battery command on brya. Change-Id: I2b2c4068bce1b5150d089ba08596c1191c189c2b Signed-off-by: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3120611 Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: Vijay Hiremath <vijay.p.hiremath@intel.com> Commit-Queue: Boris Mittelberg <bmbm@google.com>
* intelrvp: Add MECC1.1 supportVijay Hiremath2021-09-081-2/+19
| | | | | | | | | | | | | | | | | MECC1.1 is defined for ADL+ platforms. To simplify the the BOM stuffing options and also to remove dependency on H1 by MECC vendors, H1 is added on RVP as AIC. BUG=b:197659347 BRANCH=none TEST=make buildall -j Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com> Change-Id: I5c3b4b2b2a116ec8dc5a7448c71a6b8654a78bba Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3114218 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Li Feng <li1.feng@intel.com> Commit-Queue: Keith Short <keithshort@chromium.org>
* guybrush: move thermal sensor/setting to variantZick Wei2021-09-072-171/+0
| | | | | | | | | | | | | | | | | This patch move thermal sensor and setting to variant, let variant have their own setting. BUG=none BRANCH=none TEST=make BOARD=dewatt, make BOARD=guybrush, make BOARD=nipperkin Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Ibf37a0a45d1a728abc5ed88dde230f0561698bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3132547 Reviewed-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-by: Rob Barnes <robbarnes@google.com> Commit-Queue: Rob Barnes <robbarnes@google.com>
* brya: Move charger config from baseboard to boardDavid Huang2021-09-022-1/+0
| | | | | | | | | | | | | | | Move charger config from baseboard to board. Change Kano charger to isl9241. BUG=none BRANCH=brya TEST=make buildall -j succeeded. Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com> Change-Id: Ia97424bbcf0654127e21c47d6834ad6c2c6163ee Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3132556 Reviewed-by: Boris Mittelberg <bmbm@google.com> Commit-Queue: Boris Mittelberg <bmbm@google.com>
* zephyr: Add BB retimer emulatorTomasz Michalec2021-09-021-1/+2
| | | | | | | | | | | | | | | | | | Add BB retimer emulator on i2c bus. Emulator properties can be defined using device tree or runtime emulator API. Emulator checks if RO registers and reserved bits are accessed correctly. API allows to set custom read/write i2c messagess handlers to emulate complex behaviour. BUG=b:184856919 BRANCH=none TEST=none Signed-off-by: Tomasz Michalec <tm@semihalf.com> Change-Id: I4b641a90e6fb55e89aaee388c0ac04ab7bf367ba Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3110085 Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Yuval Peress <peress@chromium.org>
* honeybuns: fix cbi write protect checkScott Collyer2021-09-021-0/+2
| | | | | | | | | | | | | | | | | | | This CL fixes the config options used to ignore the hardware write protection signal to the CBI EEPROM. Honeybuns is only using this to store the user MF prefence bit. The config option that had been used to flip the polarity of WP_L (the default write protect signal) has been removed. BRANCH=quiche BUG=b:164157329 TEST=Verfied that MF preference bit is stored in CBI. Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: I4f5cbe4b20dd2347e71429dadaf9f0c103b222de Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3139097 Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Scott Collyer <scollyer@chromium.org>
* kukui: Disable MFALLOW and TYPEC console commandsRob Barnes2021-09-011-0/+2
| | | | | | | | | | | | | | Disable CONFIG_CMD_MFALLOW and CONFIG_CMD_TYPEC commands to free up RO flash space on kukui boards. BUG=None TEST=Build all BRANCH=None Change-Id: I1d60355b4d1c60c848a3373ce7eadf74a1a73056 Signed-off-by: Rob Barnes <robbarnes@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3136037 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* cherry: Don't return error when disabling all charge portsTing Shen2021-09-011-1/+2
| | | | | | | | | | | | | | | | | | | | The line RETURN_ERROR(rt1718s_gpio_ctrl(...)) caused EC not able to turn on sink path on C0 when daughter board absent. To make C0 workable under this situation, ignore the error and print some error message instead like other boards do. BUG=b:198114418 BRANCH=none TEST=device charging when daughter board not connected Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I09941310370a60be6145e38395a4922df52c2b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3135516 Tested-by: Ting Shen <phoenixshen@chromium.org> Auto-Submit: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com>
* guybrush: move unuse/led gpio to varianetZick Wei2021-09-011-13/+0
| | | | | | | | | | | | | | | | | | Move test point and led gpio from base_gpio.inc to variant. BUG=none BRANCH=none TEST=make BOARD=guybrush, make BOARD=nipperkin, make BOARD=dewatt all pass. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Ic6ef1d74e1e751cbc39c2d63cd782c70f85d0644 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3122696 Reviewed-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-by: Rob Barnes <robbarnes@google.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Rob Barnes <robbarnes@google.com>
* TCPM: Rename enum tcpm_sop_type and its constantsAbe Levkoy2021-08-318-8/+8
| | | | | | | | | | | | | | | As a followup to CL:3104290, give the TCPCI TRANSMIT and RX_BUF_FRAME_TYPE types more consistent names. Most of them can be used for receiving, not just transmitting. Fix lint errors thus revealed. BUG=b:155476419 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I399ec479eacc18622fc4d3f55f8bdabf4560fcff Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3125995 Reviewed-by: Keith Short <keithshort@chromium.org>
* USB MUX: Convert usb_mux HPD functions to use mux_state_tDiana Z2021-08-301-1/+3
| | | | | | | | | | | | | | Since we have definitions for HPD IRQ and level in the mux flags, extend this to the HPD update function in the usb_mux structure as well. BRANCH=None BUG=b:172222942 TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I19c3a65fc821a341338d73fabd7876339b37fe7d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3095437 Reviewed-by: Keith Short <keithshort@chromium.org>
* Tomato: read C1 VBUS voltage from rt1718sSue Chen2021-08-272-0/+19
| | | | | | | | | | | | | | | For ADC_VBUS only for C0 VBUS voltage, C1 VBUS voltage should be read from rt1718s internal VBUS ADC. BUG=b:196001868 BRANCH=none TEST=show correct C1 vbus voltage on tomato Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: I6c90386e083a480ffaeacd7739d4ddebe0bd8e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3114326 Commit-Queue: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* adc: Remove adc_chip.h where adc.h is usedCaveh Jalali2021-08-2710-10/+0
| | | | | | | | | | | | | | This removes the use of adc_chip.h where adc.h is also used. In this case, adc_chip.h is redundant. BRANCH=none BUG=b:181271666 TEST=buildall passes Change-Id: Id7baf9aef949447a4d47934242f9bae97c971262 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3120317 Reviewed-by: Keith Short <keithshort@chromium.org>
* adc: Update board files to match adc.h refactorCaveh Jalali2021-08-272-2/+2
| | | | | | | | | | | | | | This updates a few board files that were including adc_chip.h instead of adc.h. adc_chip.h should not be included explicitly in most cases. BRANCH=none BUG=b:181271666 TEST=buildall passes Change-Id: I42f8b5b2129ebe18a96d089f0355b581cba1b274 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3120316 Reviewed-by: Keith Short <keithshort@chromium.org>
* honeybuns: fix check for fw_config from CBIScott Collyer2021-08-262-1/+7
| | | | | | | | | | | | | | | | | | | | This CL fixes a logic error where CBI FW_CONFIG field was being checked. In addition, the CBI config option to bypass the write protection check was added as the CBI is only being used to store the dock_mf preference and doesn't need to be write protected. BUG=b:164157329 BRANCH=quiche TEST=Verified on Gingerbread that the status LED color matches with the dock's MF preference. In addition, verified that following a power cycle, the MF preference is read properly from the CBI. Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: Ie3d5b8d4af73b1d09b3f58f1a990b7c77cb4a6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3116666 Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Scott Collyer <scollyer@chromium.org>
* honeybuns: override usb_ufp_check_usb3_enable()Scott Collyer2021-08-262-1/+6
| | | | | | | | | | | | | | | | | | This CL adds an override function for usb_ufp_check_usb3_enable() so that USB3.1 mode gets enabled by default when attaching as a SNK/UFP in a type-c only connection. BUG=b:195042155 BRANCH=quiche TEST=Verfied that when I connect USBC only source on gingerbread that the TUSB1064 usb mux gets configured to enable USB3.1 mode. Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: Ib1a12f1c221133d50dcbacb02bb3376ff11fc833 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3120065 Commit-Queue: Scott Collyer <scollyer@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* Guybrush: Flag that retimers will power off in G3Diana Z2021-08-261-0/+2
| | | | | | | | | | | | | | | | Both retimers for guybrush will power off in G3, so flag them as such. This is only functionally relevant to the ANX retimer, since it starts up in USB mode by default, but is true for both. BRANCH=None BUG=b:195045790 TEST=on guybrush, power down to G3 and then power back up and ensure retimer is turned off Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Ia23051ba65b232179cd3b7b3d7c1710487dcd5d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3095019 Reviewed-by: Rob Barnes <robbarnes@google.com>
* guybrush: Enable AMD STTRob Barnes2021-08-252-2/+4
| | | | | | | | | | | | | | | | Enable AMD STT driver. The AMD STT driver will read the SOC and ambient temperature sensors every second and send the result to the SOC via SB RMI on the i2c bus. BUG=b:176994331 TEST=stt debug BRANCH=None Signed-off-by: Rob Barnes <robbarnes@google.com> Change-Id: I45157acf172dcce00c24971be70c5ec609d460dd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3082326 Commit-Queue: Diana Z <dzigterman@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* tmp112: Support reading TMP112 in millikelvinRob Barnes2021-08-251-1/+1
| | | | | | | | | | | | | | | TMP112 supports .0625 degrees of resolution. Retain this resolution and support reading the temp in degrees millikelvin. BUG=b:176994331 TEST=Build and run on guybrush BRANCH=None Change-Id: I2802016b1edb08678953238e7f01acdd320c37cf Signed-off-by: Rob Barnes <robbarnes@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3001391 Commit-Queue: Diana Z <dzigterman@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* cherry: enable FRSTing Shen2021-08-252-3/+37
| | | | | | | | | | | | | BUG=b:190348051 TEST=Verify FRS workable BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: Ie612cb2e5448db4432772f32e2f84ea6a471d4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3084323 Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com>
* brask: modify the usbc settingZhuohao Lee2021-08-251-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | There are 3 usb typec ports in the brask. The configuration listed below: Port 0: TCPC NCT3808-1, TCPPC SYV682B, Burnside Bridge retimer. Port 1: TCPC RT1716, TCPPC SYV682B, Kandou KB8002. Port 2: TCPC NCT3808-2, TCPPC SYV682B, Burnside Bridge retimer. In order to support the above configuration, this patch modifies: 1. use syv682v instead of using nv20p3483. 2. use rt1716 instead of using ps8815. 3. use kb800x retimer. 4. remove the fw_config because we don't need it to switch the different DBs. BUG=b:191637086 BRANCH=None TEST=make BOARD=brask Change-Id: Ie09aef9dc7cc7a532b34d86ea022127099f7735e Signed-off-by: Zhuohao Lee <zhuohao@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3115807 Reviewed-by: caveh jalali <caveh@chromium.org> Reviewed-by: Boris Mittelberg <bmbm@google.com>
* brask: add the barrel jack supportZhuohao Lee2021-08-251-0/+3
| | | | | | | | | | | | | | This patch adds the barrel jack support. BUG=b:191637086 BRANCH=None TEST=make BOARD=brask Change-Id: Iea2df9c6a478b45cfc4a56e11f1aeb6d6b2adba2 Signed-off-by: Zhuohao Lee <zhuohao@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3114501 Reviewed-by: caveh jalali <caveh@chromium.org> Reviewed-by: Boris Mittelberg <bmbm@google.com>
* brask: add recovery button supportZhuohao Lee2021-08-251-4/+8
| | | | | | | | | | | | | | | | | There is a dedicated recovery button for the brask. This patch adds the CONFIG_DEDICATED_RECOVERY_BUTTON and CONFIG_DEDICATED_RECOVERY_BUTTON_2 to enable it. Besides, the CONFIG_EMULATED_SYSRQ and CONFIG_MKBP_INPUT_DEVICES are added to let the EC pass the button state to the AP BUG=b:191637086 BRANCH=None TEST=make BOARD=brask Change-Id: Ic6ea693bbbc0bcd0d502d2636636bc38e080b1e9 Signed-off-by: Zhuohao Lee <zhuohao@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3114500 Reviewed-by: Boris Mittelberg <bmbm@google.com>
* brask: remove unnecessary configurationZhuohao Lee2021-08-258-292/+35
| | | | | | | | | | | | | | | | | | | | | This patch removes the configuration for the battery, charger, fan control, board id, keyboard, keyboard backlight, sensor, hibernate and led. In order to make the build pass, the CONFIG_ADC, CONFIG_POWER_BUTTON_IGNORE_LID and CONFIG_POWER_BUTTON_INIT_IDLE are added to the board.h/baseboard.h. In additional, the function board_set_active_charge_port() and board_set_charge_limit() are added to the board.c to avoid build error. BUG=b:191637086 BRANCH=None TEST=make BOARD=brask Change-Id: I15c01820dbd2f58f5722c87de51ebf425ffca13a Signed-off-by: Zhuohao Lee <zhuohao@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3114497 Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: caveh jalali <caveh@chromium.org>
* Brask: Initial the baseboard and boardZhuohao Lee2021-08-258-0/+713
| | | | | | | | | | | | | | | | | | | | The baseboard/brask and board/brask are copied from the brya. Two difference are make: 1. change BASEBOARD to brask in the build.mk to point to the brask. 2. move the generated-gpio.inc to the gpio.inc BUG=b:191637086 BRANCH=None TEST=Build passed with: 1.make BOARD=brask 2.make buildall Change-Id: I57439cffa770b3e838f372f60ed1670ac0b435d8 Signed-off-by: Zhuohao Lee <zhuohao@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3115806 Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: caveh jalali <caveh@chromium.org>
* brya: moving buttons and switches to use MKBPBoris Mittelberg2021-08-241-0/+1
| | | | | | | | | | | | | | | | Switching config option to route buttons and switches over MKBP instead of 8042 driver BRANCH=main BUG=b:170966461 TEST=manual tested on Brya: volume keys and tablet mode Cq-Depend: chromium:3097939 Signed-off-by: Boris Mittelberg <bmbm@google.com> Change-Id: Ifc45a040565dcd248de0d1cabe853550cc10bf38 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3098574 Reviewed-by: caveh jalali <caveh@chromium.org> Reviewed-by: Rob Barnes <robbarnes@google.com>
* herobrine_npcx9: Enable PSL hibernate and define the PMU moduleWai-Hong Tam2021-08-241-0/+1
| | | | | | | | | | | | | | | | | Enable the PSL mode for EC hibernate and define the PMU module. After EC enters hibernate, the PSL_OUT is off and the PPC chip is powered off. So the PPC chip can be woken up from the dead battery mode when the external AC is plugged. BRANCH=None BUG=b:193583152, b:196405396 TEST=Entered EC hibernate, plugging AC can wake EC up. Change-Id: I976d7fa7b7dfa57ee8e79501d5973710ef2192e7 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3115436 Reviewed-by: Stephen Boyd <swboyd@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* mchp: Support RPM-PWM Fan controlmartin yan2021-08-201-1/+5
| | | | | | | | | | | | | | | | | | | Support RPM based Fan Control Algorithm via RPM-PWM hardware block BUG=none BRANCH=none TEST=Tested on ADL RVP and MCHP1727 MECC system via UART console faninfo, fanduty and fanset 1: Verify fan RPM from 3000 to 9000; 2: Verify 2-pole fan expected tach output (100Hz~300Hz) per RPM setting; 3: Verify expected PWM duty (3%~100%) per PWM duty setting; 4: Limit: can not reach 10000 RPM since RPM reaches 9000 in max as PWM duty is set as 100%; Signed-off-by: martin yan <martin.yan@microchip.corp-partner.google.com> Change-Id: Ib41a06a734821c9f70a45e25e2020c6492c61563 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3100926 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* treeya: add skuid 0xbe, 0xbf for treeya360arthur.lin2021-08-191-4/+7
| | | | | | | | | | | | | | | | Add skuid 0xbe(190), 0xbf(191) for treeya360 new audio codec sku. BRANCH=grunt BUG=b:185972050 TEST=make buildall -j Signed-off-by: arthur.lin <arthur.lin@lcfc.corp-partner.google.com> Change-Id: I8d9fb10af1d4ec5abb146561172180c23d327226 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3088958 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org>
View Lorry Controller Status