summaryrefslogtreecommitdiff
path: root/baseboard
Commit message (Collapse)AuthorAgeFilesLines
* volteer: Switch to TCPC VBUS detectAbe Levkoy2020-03-181-1/+1
| | | | | | | | | | | | | | | The SYV682 PPC does not interrupt when VBUS changes, which makes it difficult to use for VBUS detection. Use the TCPCs to do this. BUG=b:151102905 TEST=Charge using each Type-C port using TCPMv1 and TCPMv2 TEST=Observe no console spam when not charging with TCPMv1 and TCPMv2 BRANCH=none Change-Id: I4dd17294e756b94d844af3ed788eed7388120f3b Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2107880 Reviewed-by: Keith Short <keithshort@chromium.org>
* volteer: enable battery cutoffKeith Short2020-03-171-3/+1
| | | | | | | | | | | | | | | Enable battery cutoff from console and from AP. BUG=b:143809318 BRANCH=none TEST=make buildall TEST=run "cutoff" from EC console, verify voltage on battery is 0 TEST=run "ectool batterycutoff" from AP, verify voltage on battery is 0 Change-Id: If5902a2469201da97d29db6d2e15c6b8b053efda Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2042903 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* kukui: increase PD_POWER_SUPPLY_TURN_OFF_DELAYTing Shen2020-03-171-1/+1
| | | | | | | | | | | | | | | | | The default value (50ms) is not enough for kukui platform, increase it to 250ms. BUG=b:149808890 TEST=plug in usb hub, plug in power cable to the hub verify power role swap succeed. BRANCH=kukui Change-Id: I487f0aeea78f2fc5de9a7dcc4a9a38cb831944cf Signed-off-by: Ting Shen <phoenixshen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2102171 Reviewed-by: Eric Yilun Lin <yllin@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* Juniper: Return BP_NOT_SURE when DFET status is offDavid Huang2020-03-172-2/+22
| | | | | | | | | | | | | | | | | | Make battery_is_present and battery_check_present_status overridable for customize by device. Do not return BP_NO when DFET status is off. Battery might need more charge time to wake up from shutdown. Return BP_NOT_SURE to keep charge battery. BUG=b:149971271 BRANCH=jacuzzi TEST=Insert UVP/shutdown battery and check battery resume normally. Change-Id: I68841e4e6e0457711fc4f43e6346b54805b7217c Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2091131 Reviewed-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* Dedede: Configure PROCHOT as active lowDiana Z2020-03-161-0/+1
| | | | | | | | | | | | | PROCHOT for both waddledee and waddledoo is active low. BUG=None BRANCH=None TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I047be61dcd2b59269898c1f0da696b24520915d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2101221 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* OCPC: Introduce charger enumDiana Z2020-03-161-0/+6
| | | | | | | | | | | | | | | This enum will specify which charger is primary, and the number of total charger chips for the board. This will be pre-defined for boards using a single charger chip. BUG=b:147440290 BRANCH=None TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Id612ace560207a7805e103465fd4035d46beed8f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2101220 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* volteer: enable DRP auto toggle and TCPC low powerKeith Short2020-03-131-2/+4
| | | | | | | | | | | | | | Enable TCPC auto toggling and enable TCPC low power mode for Volteer. BUG=b:145250123, b:149974946 BRANCH=none TEST=make buildall TEST=Verify connection of SRC and SNK devices to USB C0 on Volteer. Change-Id: Ida0c62ac9488f01992ba4e0b1689a8f67ef81ae8 Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2073278 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* kukui/dynamic-pdo: setting input current limit correctlyEric Yilun Lin2020-03-131-7/+17
| | | | | | | | | | | | | | | | While the input current is restricted when charger throttling, we should consider the previous set current limit, rather than just only the PD_MAX_CURRENT_MA. Otherwise, the power source's ability would be ignored, and will request more than the power source can provide. BRANCH=kukui BUG=b:147852834 b:141903096 TEST=Plug 9V/2A PD charger, and ensure krane drains under 2A. Change-Id: I8a0c99cad1c61e556af13ca166fdd0e3664af55d Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2100370 Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* Mushu : enable GPU temperature sensor driver in Mushuloganliao2020-03-131-0/+3
| | | | | | | | | | | | | | BUG=b:148968367 BRANCH=none TEST=make BOARD=mushu Change-Id: I20e1ebd8714e3d4b3b990d6e2a38f415afd8b5c5 Signed-off-by: loganliao <Logan_Liao@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2082303 Reviewed-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Commit-Queue: Logan Liao <logan_liao@compal.corp-partner.google.com> Tested-by: Logan Liao <logan_liao@compal.corp-partner.google.com>
* baseboard/ite_evb: create ite_evb baseboardRuibin Chang2020-03-124-0/+397
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The development board of it83xx and it8xxx2 have common code and config options which are moved to baseboard ite_evb. And we create another board for PD EVB based on baseboard ite_evb. BUG=none BRANCH=none TEST=on baseboard ite_evb: 1.test board it83xx_evb and it8xxx2_evb: successfully Flash EC image and boot on chip it8320 and it83202. 2.flashrom by ite_spi test: $ sudo ./util/flash_ec --board=it8xxx2_evb --verbose INFO: Using servo_v2. INFO: Using ec image : /mnt/host/source/src/platform/ec/build/ it8xxx2_evb/ec.bin dut-control --port=9999 i2c_mux_en:on dut-control --port=9999 i2c_mux:remote_adc INFO: Flashing chip ite_spi. dut-control --port=9999 cold_reset:on dut-control --port=9999 fw_up:on dut-control --port=9999 cold_reset:off dut-control --port=9999 fw_up:off dut-control --port=9999 spi1_vref:pp1800 spi1_buf_en:on dut-control --port=9999 spi1_buf_on_flex_en:on INFO: Running flashrom: sudo /usr/sbin/flashrom -p ft2232_spi:type=servo-v2,port=B, serial=911416-00012 --flash-size flashrom v0.9.9 : : on Linux 4.15.0-76-generic (x86_64) flashrom v0.9.9 : : on Linux 4.15.0-76-generic (x86_64) INFO: Programming EC firmware image. INFO: Running flashrom: /usr/sbin/flashrom -p ft2232_spi:type=servo-v2,port=B, serial=911416-00012 -w /tmp/flash_spi_6163 flashrom v0.9.9 : : on Linux 4.15.0-76-generic (x86_64) flashrom v0.9.9 : : on Linux 4.15.0-76-generic (x86_64) Calibrating delay loop... OK. Erasing and writing flash chip... Verifying flash... VERIFIED. SUCCESS INFO: Flashing done. INFO: Restoring servo settings... dut-control --port=9999 cold_reset:off dut-control --port=9999 i2c_mux_en:on dut-control --port=9999 i2c_mux:remote_adc dut-control --port=9999 spi1_vref:off dut-control --port=9999 spi1_buf_en:off dut-control --port=9999 spi1_buf_on_flex_en:off dut-control --port=9999 cold_reset:on dut-control --port=9999 cold_reset:off 3.test board it8xxx2_pdevb: successfully Flash EC image and boot on chip it83202. Connection with adapter and dongle are able to ready state. Change-Id: Ib6371b61c27980eb9977548177efb8c896e72d47 Signed-off-by: Ruibin Chang <ruibin.chang@ite.com.tw> Signed-off-by: tim <tim2.lin@ite.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2071551 Reviewed-by: Jett Rink <jettrink@chromium.org>
* dedede: Require >15W to boot without a batteryAseda Aboagye2020-03-121-0/+2
| | | | | | | | | | | | | | | | | | | | Waddledoo appears to have issues booting with just a 15W supply. Therefore, this commit sets the minimum power required to boot to be greater than 15W such that a PD contract is required. Otherwise, if the battery is present and has greater than 1% SOC, then booting is allowed. BUG=b:150702984 BRANCH=None TEST=build and flash waddledoo, plug in a 15W non PD charger, verify that the system does not attempt to boot the SoC. Signed-off-by: Aseda Aboagye <aaboagye@google.com> Change-Id: I165de0aa6c7185c8087328a427b0bb1eefb21e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2097137 Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org>
* variant trembyle: use fw_config for mux initializationDenis Brockus2020-03-125-220/+22
| | | | | | | | | | | | | | | | Setup the usb_muxes table to the correct values based on fw_config instead of using probing. BUG=none BRANCH=none TEST=verify USB is still working Signed-off-by: Denis Brockus <dbrockus@chromium.org> Change-Id: I7550d15d563f987def4fe70d52a55e31b655b753 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2094743 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* trembyle: change set_mux calls to be board namesDenis Brockus2020-03-111-4/+6
| | | | | | | | | | | | | | | | ps8802_set_mux and ps8818_set_mux were confusing at the board level with the same names as the main driver function names. So added board_ in front BUG=none BRANCH=none TEST=make buildall -j Signed-off-by: Denis Brockus <dbrockus@chromium.org> Change-Id: I2123b0d11823b5a01e14a8efb58cf579dc513d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2095530 Reviewed-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* trembyle: move ps8811 from variant to boardDenis Brockus2020-03-111-56/+0
| | | | | | | | | | | | | | | The USBA retimer is only on the Zork:Trembyle:Trembyle board so don't include it in the Zork:Trembyle vriant BUG=b:151099955 BRANCH=none TEST=make buildall -j Signed-off-by: Denis Brockus <dbrockus@chromium.org> Change-Id: I3dae1fee52255bdc6f51dc4225e46d8f7a254a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2095529 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org>
* dalboz: add usbc1 hpd mux driverLu Zhang2020-03-111-0/+22
| | | | | | | | | | | | | | | | PS8740 needs HPD signal when enter DP mode. BUG=b:150099044 BRANCH=none CQ-DEPEND=CL:2094844 TEST=Plug in HDMI monitor through type-c dongle, it can display. Signed-off-by: Lu Zhang <lu.zhang@bitland.corp-partner.google.com> Change-Id: I1c706f9b0bf4367d54b9a27920ca70021eb31ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2094863 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Tested-by: Paul Ma <magf@bitland.corp-partner.google.com> Commit-Queue: Edward Hill <ecgh@chromium.org>
* dalboz: use ps874x and AP internal mux as primary/secondary muxPaul Ma2020-03-111-0/+9
| | | | | | | | | | | | | | | | | | Though AP c1 port mux only support usb, it must be programmed to to a work state rather than leaving it in safe state. BUG=b:150099044 BRANCH=none TEST=build and boot dalboz, usb3 function always work. Change-Id: Ic7e9ae7fd4df68539b42fbd61c23161189703899 Signed-off-by: Paul Ma <magf@bitland.crop-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2094844 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Peichao Li <peichao.wang@bitland.corp-partner.google.com> Tested-by: Paul Ma <magf@bitland.corp-partner.google.com> Tested-by: Peichao Li <peichao.wang@bitland.corp-partner.google.com> Commit-Queue: Paul Ma <magf@bitland.corp-partner.google.com>
* volteer: Disable Burnside Bridge with TCPMv2Abe Levkoy2020-03-112-1/+11
| | | | | | | | | | | | | | | | Burnside Bridge support has not yet been ported to TCPMv2. Don't build Burnside Bridge support with TCPMv2, but allow code that supports the USB3 daughter board to compile. BUG=b:145756626 TEST=make buildall TEST=make BOARD=volteer with TCPMv2 enabled BRANCH=none Change-Id: I949cabb26779a48ce3ca3f5f3a97ccdd3f30f58d Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1992485 Reviewed-by: Keith Short <keithshort@chromium.org>
* zork: add EC fw_config frameworkDenis Brockus2020-03-104-0/+201
| | | | | | | | | | | | BUG=none BRANCH=none TEST=verify adding a call to fw_config routines work Signed-off-by: Denis Brockus <dbrockus@chromium.org> Change-Id: Ib56bae5a0ce0b1078fdd235a3595fa059181dc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2090086 Reviewed-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* palkia: remove 1 typec port, enable USB A, remove all sensorsZhuohao Lee2020-03-102-7/+35
| | | | | | | | | | | | | | | | | | | | This patch includes the changes as below: 1. Change baseboard setting to adopt the change for the palkia 2. Modify GPIO according to the palkia schematics. 3. Remove all sensors 4. Remove USB typec port 1 5. Enable USB A Battery and keyboard setting are put to the separate CL. BUG=b:147078849 BRANCH=firmware-hatch-12669.B TEST=run on DUT Change-Id: I86a7eb4e9680bf66475d3a5331e870da01526128 Signed-off-by: Zhuohao Lee <zhuohao@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2040759 Reviewed-by: Jett Rink <jettrink@chromium.org>
* Revert "Ampton: Set the PS8751 to source mode before enter low power mode"Matthew Blecker2020-03-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 4ca73139635261ee1273fbe1767dcf06886d2208. Reason for revert: Breaks CCD with AP off https://issuetracker.google.com/150822168 Will work on a solution to address the original CL need, i.e. applying Rp in LPM. Follow the above bug. Some merge conflict happens. Resolved. Also change the usb_mux driver of Trogdor, as ps8xxx_usb_mux_driver is removed. Original change's description: > Ampton: Set the PS8751 to source mode before enter low power mode > > BUG=b:113830171 > BRANCH=octopus > TEST=check the power consumption is lower > > Change-Id: I527cdc5d1e4dd5de137ab0927e66c171696758ce > Signed-off-by: James_Chao <james_chao@asus.corp-partner.google.com> > Reviewed-on: https://chromium-review.googlesource.com/1426306 > Commit-Ready: James Chao <james_chao@asus.corp-partner.google.com> > Tested-by: James Chao <james_chao@asus.corp-partner.google.com> > Reviewed-by: Jett Rink <jettrink@chromium.org> BRANCH=None BUG=b:113830171,150822168 TEST=Build Trogdor, verified CCD with AP off working. Change-Id: I58c26e8466b70e035a1c396cfcba6a46da4bccc9 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2091519 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Matthew Blecker <matthewb@chromium.org>
* dalboz: add FSUSB42UMX driverPaul Ma2020-03-061-0/+36
| | | | | | | | | | | | | | | Add FSUSB42UMX support. This chip is used as SBU mux of usb c0 port. BUG=b:150398913 BRANCH=none TEST=build dalboz ec successfully. Change-Id: Ibd58c252b7e1256891df0626a0a7fb5292a9da84 Signed-off-by: Paul Ma <magf@bitland.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2089213 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* hatch/baseboard: Enable the Search key button in maskRajat Jain2020-03-031-1/+1
| | | | | | | | | | | | | Enable the search key located at Row-3, Col-0 BUG=b:146501925,b:148488560 TEST=Check search key while debugging BRANCH=firmware-hatch-12672.B Signed-off-by: Rajat Jain <rajatja@google.com> Change-Id: I3496d6413994f147839fbb29f6d666b5fc6c0914 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2080600 Reviewed-by: Scott Collyer <scollyer@chromium.org>
* zork: Split mux/retimer for trembyle/dalbozEdward Hill2020-02-294-358/+387
| | | | | | | | | | | BUG=b:150099043 b:150384642 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Ica9eda3f9d6a1332319b5c7ba56c0881d05eeebd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2079353 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* volteer: Prevent glitch on SLP_S3_L during power onKeith Short2020-02-291-0/+1
| | | | | | | | | | | | | | | | | Reconfigure the SLP_S3_L power interrupt as an output and drive this signal low while the PP3300_A rail comes up. This prevents a glitch on the SLP_S3_L signal that can affect the power sequencing. BUG=b:143346794 BRANCH=none TEST=make buildall TEST=Verify Volteer boots. With debug code enabled, verify SLP_S3_L drives low while PP3300 turns on. Change-Id: Ic8204874cb9e68a1af27fafcf5274d50ce5cb38f Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2068535 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* volteer: add chargen to the set of CLI commandsNamyoon Woo2020-02-281-0/+3
| | | | | | | | | | | | | | | | This is needed to support CCD testing of UART to USB bridging. This patch occupies 440 and 424 bytes in flash usage of RO and RW respectively. BUG=none BRANCH=none TEST=build volteer, and checked that command is included in the symbol map. Signed-off-by: Namyoon Woo <namyoon@chromium.org> Change-Id: Ife501d6a2da10840ad06ec025a6a2663021072cf Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2079871 Reviewed-by: Keith Short <keithshort@chromium.org>
* zork: add chargen to the set of CLI commandsNamyoon Woo2020-02-281-0/+3
| | | | | | | | | | | | | | | | This is needed to support CCD testing of UART to USB bridging. This patch occupies 536 and 524 bytes in flash usage of RO and RW respectively. BUG=none BRANCH=none TEST=build morphius, and checked that command is included in the symbol map. Signed-off-by: Namyoon Woo <namyoon@chromium.org> Change-Id: I4994df1e7826ccb11bbffb8874ddf5c5d75176ca Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2079872 Reviewed-by: Edward Hill <ecgh@chromium.org>
* usb_mux: retimer: mux as chained mux and retimerDenis Brockus2020-02-2815-159/+203
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes retimers appear as generic muxes. By allowing a chain of muxes they can be stacked up to the new configurations that zork requires and will continue to work as they did before on configurations that only have a single mux. The code used to have two different arrays, 1) muxes and 2) retimers. On one of the zork configurations the processor MUX stopped being the primary mux and the retimer took its place. In a different configuration of that same platform it left the primary and secondary alone but the mux_set FLIP operation had to be ignored. Since the same interfaces needed to be available for both it stopped making sense to have two different structures and two different methods of handling them. This consolodates the two into one. The platforms that do not have retimers, this change will not make any difference. For platforms like zork, it will remove the retimers and make them chained muxes. So testing on trembyle makes sense to verify, BUG=b:147593660 BRANCH=none TEST=verify USB still works on trembyle Change-Id: I286cf1e302f9bd3dd7e81098ec08514a2a009fe3 Signed-off-by: Denis Brockus <dbrockus@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2066794 Commit-Queue: Jett Rink <jettrink@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* dedede: add chargen to the set of CLI commandsNamyoon Woo2020-02-281-0/+3
| | | | | | | | | | | | | | | | This is needed to support CCD testing of UART to USB bridging. This patch occupies 448 and 428 bytes in flash usage of RO and RW respectively. BUG=b:38448364 BRANCH=none TEST=build waddledoo and waddledee, and checked that command is included in the symbol map. Signed-off-by: Namyoon Woo <namyoon@chromium.org> Change-Id: Id2f525b1a53042316f96e6374dee84e95c1f5c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2079709 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* hatch: Enable extpwrlimit option in ectoolShelley Chen2020-02-281-0/+1
| | | | | | | | | | | | | BUG=b:149997506 BRANCH=hatch TEST=ectool extpwrlimit 3000 5000 Signed-off-by: Shelley Chen <shchen@google.com> Change-Id: Ie133ac518f1a290ef04610a56c1d104d60254ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2079358 Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Commit-Queue: Shelley Chen <shchen@chromium.org> Tested-by: Shelley Chen <shchen@chromium.org>
* volteer: Configure EC_VOLUP_BTN_ODL for next buildKeith Short2020-02-272-0/+8
| | | | | | | | | | | | | | | | Update the GPIO assignment for the EC_VOLUP_BTN_ODL signal for the next board build. BUG=b:144933528 BRANCH=none TEST=make buildall TEST=Verify volume buttons with board ID=0 Change-Id: I28e53573b6a6a9ba7e5df0458ded8b988c25ac04 Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2065489 Reviewed-by: caveh jalali <caveh@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* dalboz: update GPIOsEdward Hill2020-02-273-22/+37
| | | | | | | | | | | | BUG=b:147297680 BRANCH=none TEST=able to boot dalboz AP Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I4a3ec2a77292e48672f5c6143990c36b9a80b6a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2073277 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* zork: Move fan into variant_trembyle.cEdward Hill2020-02-273-67/+66
| | | | | | | | | | | | BUG=b:147297680 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Icc77e0d27db794b1aed0d65c7d30de3ccc3747ca Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2071391 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* zork: Create baseboard variants for trembyle/dalbozEdward Hill2020-02-275-56/+100
| | | | | | | | | | | | BUG=b:150110428 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I30503a0416325fc8573a4a62b3bc3ff943b5008e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2071390 Commit-Queue: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* dalboz: Add base/lid sensor configurationLu Zhang2020-02-261-91/+0
| | | | | | | | | | | | | | | | Dalboz uses LSM6DS3TR/LIS2DWL instead of BMI160/KX022 BUG=b:149968926 BRANCH=none TEST=using ec console 'accelinfo on' to see if there is sensor data output. Change-Id: If385c5554b50795702736aa8e1e3090dcb8b618a Signed-off-by: Lu Zhang <lu.zhang@bitland.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2069965 Commit-Queue: Edward Hill <ecgh@chromium.org> Tested-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org>
* volteer: Update USB C1 reset for next buildstabilize-volteer-12931.B-masterKeith Short2020-02-262-3/+22
| | | | | | | | | | | | | | | | Update the GPIO assignment for the USB_C1_RT_RST_ODL signal for the next board build. BUG=b:144933528, b:148243971 BRANCH=none TEST=make buildall TEST=Check unassigned board ID or board ID=0 uses legacy GPIO setting. Otherwise new GPIO setting is used. Change-Id: I4621e039e4461a4e10ab87bc2d4e000b5dcaa885 Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2057496 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* nucleo-h743zi: Separated into baseboardCraig Hesling2020-02-257-0/+271
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows for creating multiple projects on top of the nucleo-h743zi platform. The intended use for this is to have a fingerprint board/project that pulls in all FPMCU specific config and libraries, while still maintaining another pure nucleo-h743zi board/project that can be used for platform testing and tuning. I suspect there will be more test boards/projects that use the nucleo-h743zi baseboard in the future. A project/board would be used as a way to create a specific test platform that can isolate an individual feature. Note, this does make use of recursively including the basboard gpio table. This requires the use of https://crrev.com/c/2056498 (gpio: Free gpio.inc from oppressive order). This also removes malloc support. BRANCH=none BUG=none TEST=make BOARD=nucleo-h743zi # Copy binary to mass storage # Connect to console and change clock sources Change-Id: I455274e0efb8ec374443314d351e254f1347a1a9 Signed-off-by: Craig Hesling <hesling@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2057498 Reviewed-by: Jett Rink <jettrink@chromium.org>
* waddledoo: Set CMPOUT as inverted to enable 5VAseda Aboagye2020-02-251-0/+1
| | | | | | | | | | | | | | | | | | | | The charger has a general comparator which is enabled by default. The output of this comparator enables the sub board power rails. This commit adds a mechanism to turn on the 5V on the sub board tied to when the system decides to enable 5V. BUG=b:149794574 BRANCH=None TEST=Build and flash waddledoo, boot to S0, plug in a sink, verify that VCONN is sourced. Change-Id: I05384bdbdde4ccc033c2057b3c45fcaeae4589cc Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2065495 Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Auto-Submit: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* TCPMV1/2: Make the PD Config Flags more consistentSam Hurst2020-02-2210-3/+13
| | | | | | | | | | | | | | | | | | | | The current use of the PD Config Flags are a bit confusing and has been changed to the following: The CONFIG_USB_POWER_DELIVERY flag is used to enable and disable the TCPMv1 and TCPMv2 stacks. And when CONFIG_USB_POWER_DELIVERY is enabled, one of the following must be enabled: CONFIG_USB_PD_TCPMV1 - legacy power delivery state machine CONFIG_USB_PD_TCPMV2 - current power delivery state machine BUG=b:149993808 BRANCH=none TEST=make -j buildall Change-Id: Ie3f8615a75b15b4f1c703f57f3db9e152a471238 Signed-off-by: Sam Hurst <shurst@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2068519 Reviewed-by: Diana Z <dzigterman@chromium.org>
* dedede: Set pullup on PG_PP1050_ST_OD only after RSMRSTAseda Aboagye2020-02-212-0/+18
| | | | | | | | | | | | | | | | | | Per recommendation from the SoC vendor, we should only enable the pull up on PG_PP1050_ST_OD once RSMRST has been de-asserted. Otherwise, the pull up can inidicate a false power good. BUG=b:148688874 BRANCH=None TEST=Build and flash waddledoo, verify that PG_PP1050_ST_OD is actually valid. Change-Id: Icdd8ec08fc84954730ae2d80fed86af4f07f01ba Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2058694 Tested-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* zork: enable usb-c FRSwapDenis Brockus2020-02-211-6/+3
| | | | | | | | | | | | | | Enabling FRSwap and removed the TODOs for enabling TCPMv2 and FRSwap. BUG=b:146393213 BRANCH=none TEST=make buildall -j Change-Id: I9c7ad30d675011614d383c3b4cd8fb1384a68841 Signed-off-by: Denis Brockus <dbrockus@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2064542 Reviewed-by: Diana Z <dzigterman@chromium.org>
* volteer: Increase I2C bus speed to 1 MHz for USB PDKeith Short2020-02-201-2/+2
| | | | | | | | | | | | | | Increase the I2C bus speed to 1 MHz for the USB C0 and USB C1 buses. BUG=b:144863533, b:149096109 BRANCH=none TEST=make buildall TEST=verify I2C device list on USB C0 and USB C1 buses. Change-Id: I4b66f49f0f9050c0db7005abc85282db9bfd0cdb Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2047623 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* waddledoo:Handle EC_AP_PCH_PWROK_OD and ALL_SYS_PWRGDSooraj Govindan2020-02-192-0/+12
| | | | | | | | | | | | | | | | | | | | | | As per Waddledoo power sequencing requirements, 1. ALL_SYS_PWRGD should be driven based on DRAM power good and the PP1050_ST power good. 2. the EC needs to assert EC_AP_PCH_PWROK_OD, with a 2ms minimum delay after receiving the DRAM power good and the PP1050_ST power good. 3. Enable CONFIG_BACKLIGHT_LID BUG=b:147257114 BRANCH=None TEST=make -j BOARD=waddledoo; flash waddledoo, verify that DUT can boot to S0. Change-Id: I5ad226faa15cfe8ae569524decf405bbd378a28c Signed-off-by: Sooraj Govindan <sooraj.govindan@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2044250 Tested-by: Sooraj Govindan <sooraj.govindan@intel.corp-partner.google.com> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* driver/tcpm/it8xxx2: PD driver for chip it8xxx1/8xxx2Ruibin Chang2020-02-194-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add PD driver for chip it8xxx1/8xxx2 series. BRANCH=none BUG=none TEST=test below functions on PDEVB port0, 1, 2 with TCPMv1 (set cc toggle by console cmd): 1.pin configuration console cmd "gpioget" check gpio settings. memory dump check cc pin alternate settings. 2.Tx data error handle Message discard, No GoodCRC, Tx not enable, Timeout errors happen, corresponding INT will be triggered then do properly handle. 3.basic pd connection SNK:connect with adaptor, request max power (15V,3A), state SNK_READY. SRC:enable DRP role, connect with dongle, provide power (5V,1.5A), source Vconn 5v, get ack of cable discover id, state SRC_READY. 4.pd module disable SNK:connect with adapter. console cmd "hibernate sec", driver disable pd module, check still connection with adapter via dead battery rd. And when resume from hibernate, pd init can re-enable pd module, re-connect with adapter. SRC:connect with dongle. console cmd "hibernate sec", driver disable pd module, check cc pin (not Vconn source pin) volt power down to ~0v. And when resume from hibernate, pd init can re-enable pd module, re-connect with dongle. 5.Tx hard reset console cmd "pd port hard", check hard reset message by lecroy analyzer. 6.Tx cable reset check cable reset message by lecroy analyzer. 7.SOP' enable SRC:connects to SNK via E-mark cable. Source Vconn successfully, and receives cable's ack of discover id request. Not source Vconn to cable, and receives nothing of discover id request (this isn't effect on request SNK flow). 8.power role swap console cmd "pd port swap power", check pd protocol by lecroy. Change-Id: I687e0e65e2687ebbb790eb1e1c8c459305f4dbc1 Signed-off-by: Ruibin Chang <Ruibin.Chang@ite.com.tw> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2009538 Reviewed-by: Jett Rink <jettrink@chromium.org>
* hatch: Add check for convertible SKUs in lid_angle_peripheral_enableTim Wawrzynczak2020-02-182-4/+6
| | | | | | | | | | | | | | | | Check for a convertible SKU before turning off the keyboard in the switch to tablet mode. See go/hatch-skus for the list. BUG=b:125936966 BRANCH=firmware-hatch-12672.B TEST=On Kohaku, artificially force SKU to both convertible and non-convertible SKUs, switch to tablet mode, and then check whether Alt-Volup-R reboots the EC. Change-Id: Id29644c4e050705203b860324f14b1b87bc4ccf4 Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2047630 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
* tcpci: Rename TCPC_FLAGS_TCPCI_V2_0 to TCPC_FLAGS_TCPCI_REV2_0Edward Hill2020-02-142-3/+3
| | | | | | | | | | | | | | | | | | Align naming of TCPC_FLAGS_TCPCI_V2_0 to match spec: "USB Type-C Port Controller Interface Specification" "Revision 2.0, Version 1.0" BUG=none BRANCH=none TEST=none Change-Id: I27752847581e449c3a2f6be438704d3e514c937d Signed-off-by: Edward Hill <ecgh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2057375 Reviewed-by: Diana Z <dzigterman@chromium.org> Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* trembyle: enable TCPMv2 USB-C PD stackDenis Brockus2020-02-141-1/+4
| | | | | | | | | | | | | | Charging is now working with/without AP running in both polarities. BUG=b:142284905 BRANCH=none TEST=Plug charger in Trembyle USB-C0/C1 Change-Id: I94cd7181a20d44b182516633a5fc0913e78dd482 Signed-off-by: Denis Brockus <dbrockus@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1982361 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* zork: HPD for DB OPT3 MST hubEdward Hill2020-02-142-0/+19
| | | | | | | | | | | | | | Add interrupt handler for MST_HPD_OUT from IO expander on DB OPT3 and connect to AP's DP1_HPD. BUG=b:146468096 BRANCH=none TEST=HDMI works with DB OPT3 Change-Id: I60a7932f3eb03b90b94354ce809e0d5e09e15247 Signed-off-by: Edward Hill <ecgh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2042680 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* zork: HPD for DB OPT1 HDMIEdward Hill2020-02-142-0/+21
| | | | | | | | | | | | | Add interrupt handler for HDMI_CONN_HPD_3V3_DB from IO expander on DB OPT1 and connect to AP's DP1_HPD. BUG=b:146468190 BRANCH=none TEST=HDMI works with DB OPT1 Change-Id: I2cfd1a630d046086594335a20c98ff77953f59eb Signed-off-by: Edward Hill <ecgh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2031651
* Kodama: delay to enable charger EOC and TE functionxiong.huang2020-02-141-0/+51
| | | | | | | | | | | | | | | | | | | | When the battery is activated in shutdown mode, the battery needs H/W Initialization and Cu Deposition Checking in 4.2 second. Meanwhile, if the charger EOC function is enabled, charger will close/open the charging path repeatedly and will pull PMIC's VSYSSNS power. It's a workaround to delay 4.5 second to enable charger EOC and TE function. BUG=b:148045048 TEST=The adapter can boot the DUT automatically when the battery enters shutdown mode or ship mode. BRANCH=kukui Change-Id: Ie00d0f7ad506a273dc1b51f03b5d28dfa582f14f Signed-off-by: Xiong Huang <xiong.huang@bitland.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2012102 Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
* baseboard/kukui: disable console cmd help in ROEric Yilun Lin2020-02-141-0/+1
| | | | | | | | | | | | | | The RO flash on kukui boards are tight. Disable the config to unblock development. BUG=none TEST=see krane RO free space increase from 1312 to 4128 BRANCH=master Change-Id: Ib8b6d69e99b94888892764bcb2f0f8db2f4bb5ba Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2055270 Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>