summaryrefslogtreecommitdiff
path: root/baseboard
Commit message (Collapse)AuthorAgeFilesLines
* krabby: refactor board.c/baseboard.cTing Shen2021-10-291-17/+0
| | | | | | | | | | | | | | | | | | Move some functions which is likely to be use by zephyr ec outside of board/baseboard.c. BUG=b:202808130 TEST=1) make BOARD=krabby 2) zmake -D -l DEBUG configure -b zephyr/projects/corsola/krabby/ BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I6ac4519bd9070cb8c54bce812dd62eaf8af21dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3246994 Auto-Submit: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* brya: add PROCHOT assertion/de-assertion ratioWill Tsai2021-10-291-1/+2
| | | | | | | | | | | | | | | | | This adds a de-assertion ratio for the total power consumption to compare when adapter wattage greater or equal to 60W and the battery is not present(or the battery energy is less than 10%). BUG=b:198689488 b:198722634 BRANCH=none TEST=make -j BOARD=gimble Signed-off-by: Will Tsai <will_tsai@wistron.corp-partner.google.com> Change-Id: Ie7d6ffa8f30a1f0b0aec24055e8d823d1d3395b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3251823 Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* brya: move prochot assertion/de-assertion ratio to variantWill Tsai2021-10-291-10/+0
| | | | | | | | | | | | | | | | Since each variant may have different prochot assertion/de-assertion configuration, the prochot assertion/de-assertion ratio setting will be moved from baseboard to variant. BUG=b:198689488 b:198722634 BRANCH=none TEST=make -j BOARD=gimble Signed-off-by: Will Tsai <will_tsai@wistron.corp-partner.google.com> Change-Id: I140e74e85fbec24e0e1759526d9c3b24152b68c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3247740 Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* kukui: Free up more spaceTing Shen2021-10-291-0/+1
| | | | | | | | | | | | | | | | TASK_PROFILING takes 800 bytes. BUG=none TEST=make BOARD=kodama BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: Ib2ba0f10463d5d598fb577aca99878a412c2a0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3250333 Tested-by: Ting Shen <phoenixshen@chromium.org> Auto-Submit: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com>
* brya: Update stack sizes based on stack analyzerCaveh Jalali2021-10-291-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adjusts the task stack sizes on brya and variants. Many task stacks had to be increased, only CONSOLE could be reduced. Task stack size constants are added at the baseboard level for several tasks that tend to behave very similarly among variants. before: Task: CHARGER, Max size: 932, Allocated size: 928 Task: CHG_RAMP, Max size: 900, Allocated size: 672 Task: CHIPSET, Max size: 988, Allocated size: 928 Task: CONSOLE, Max size: 612, Allocated size: 928 Task: HOOKS, Max size: 580, Allocated size: 800 Task: HOSTCMD, Max size: 612, Allocated size: 800 Task: KEYPROTO, Max size: 660, Allocated size: 672 Task: KEYSCAN, Max size: 708, Allocated size: 672 Task: MOTIONSENSE, Max size: 796, Allocated size: 928 Task: PD_C0, Max size: 1052, Allocated size: 1056 Task: PD_C1, Max size: 1052, Allocated size: 1056 Task: PD_C2, Max size: 1052, Allocated size: 1056 Task: PD_INT_C0, Max size: 644, Allocated size: 672 Task: PD_INT_C1, Max size: 644, Allocated size: 672 Task: POWERBTN, Max size: 964, Allocated size: 800 Task: USB_CHG_P0, Max size: 508, Allocated size: 672 Task: USB_CHG_P1, Max size: 508, Allocated size: 672 Task: USB_CHG_P2, Max size: 508, Allocated size: 672 after: Task: CHARGER, Max size: 932, Allocated size: 1088 Task: CHG_RAMP, Max size: 900, Allocated size: 1088 Task: CHIPSET, Max size: 988, Allocated size: 1152 Task: CONSOLE, Max size: 612, Allocated size: 800 Task: HOOKS, Max size: 580, Allocated size: 800 Task: HOSTCMD, Max size: 612, Allocated size: 800 Task: KEYPROTO, Max size: 660, Allocated size: 800 Task: KEYSCAN, Max size: 708, Allocated size: 928 Task: MOTIONSENSE, Max size: 796, Allocated size: 928 Task: PD_C0, Max size: 1052, Allocated size: 1216 Task: PD_C1, Max size: 1052, Allocated size: 1216 Task: PD_C2, Max size: 1052, Allocated size: 1216 Task: PD_INT_C0, Max size: 644, Allocated size: 800 Task: PD_INT_C1, Max size: 644, Allocated size: 800 Task: POWERBTN, Max size: 964, Allocated size: 1088 Task: USB_CHG_P0, Max size: 508, Allocated size: 672 Task: USB_CHG_P1, Max size: 508, Allocated size: 672 Task: USB_CHG_P2, Max size: 508, Allocated size: 672 BRANCH=none BUG=b:204362187,b:204102039,b:204280744 TEST=brya EC no longer reboots due to stack overflow in PD task TEST=task command now reports 200 bytes of stack headroom for chipset TEST=boots on brya Change-Id: I081228da6d850bf69b431475b81025045c1c521d Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3248976 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* adlrvp-n: Enable bq25720 charger driversDeepti Deshatty2021-10-282-2/+29
| | | | | | | | | | | | | | | | Changes enable drivers to support BQ25720 charger chip for ADL-N. ADLRVP variants uses ISL9241 drivers too. Hence both the driver files needs to be compiled. At boot time, depending on the board id read, right drivers are executed for the platform. BRANCH=none TEST=Battery charging verified on ADL-N board. Signed-off-by: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com> Change-Id: I952a3b7d23f52ec512f90a843db1f4db2fe0e95d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3204652 Reviewed-by: caveh jalali <caveh@chromium.org> Reviewed-by: Vijay Hiremath <vijay.p.hiremath@intel.com>
* cleanup: charger: Add BQ25710 sense resistor configsDeepti Deshatty2021-10-283-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | Defined different sense register configs for BQ25710. All the charger chip driver implementation uses common sense register configs i.e CONFIG_CHARGER_SENSE_RESISTOR and CONFIG_CHARGER_SENSE_RESISTOR_AC. When we enable a charger driver for a platform, it is expected that the platform define these sense register configs. But ADLRVP requires two different charger drivers i.e ISL9241 and BQ25720 to be enabled to support all the variant builds. Hence BQ25710 driver is changed to use different sense register configs so that the configs defined for ISL9241 are not affected. BRANCH=none TEST=make -j buildall has no issues Signed-off-by: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com> Change-Id: If1e1422246e2e3a5cb628d9a37c23790502b5ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3211773 Reviewed-by: Poornima Tom <poornima.tom@intel.com> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
* baseboard/kukui: Free up more space in kukui RO and RWTom Hughes2021-10-271-5/+9
| | | | | | | | | | | BRANCH=none BUG=b:172020503 TEST=CC=clang make BOARD=burnet Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I0cf7b1da3ad3e0546a7fb53c30721d04710a0947 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3245623 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* brya: fix prochot feature in AC onlyScott Chao2021-10-271-3/+2
| | | | | | | | | | | | | | | | In old version, we will return early in assert_prochot if no battery. Since we need to test under AC only as well, so add one judgment to let AC only work. BUG=b:198689488, b:198722634 BRANCH=none TEST=make -j BOARD=gimble Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: I999bd9f8d4d55a8c0c2f43017c4235df2565e45d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3243848 Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* kukui: Remove CMD_ACCELS to create spaceDaisuke Nojiri2021-10-261-1/+1
| | | | | | | | | | | BUG=None BRANCH=None TEST=buildall Change-Id: I69b2b5d7fc81852213661a7cb2d34d7c8cffe08f Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3229463 Reviewed-by: Eric Yilun Lin <yllin@google.com>
* Trogdor: Switch from battery v1 to v2Daisuke Nojiri2021-10-261-0/+3
| | | | | | | | | | | | | | Battery v2 supports full size strings for static info including manufacturer, model, chemistry. BUG=b:198722643 BRANCH=None TEST=buildall Change-Id: I7dc768eb5670bc89bc4f72a1bba3530f3f1753cf Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3227373 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* baseboard/zork: Unify enum typesTom Hughes2021-10-252-8/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | enum ec_ssfc_base_gyro_sensor and enum ec_cfg_base_gyro_sensor_type have the same values. clang warns that we're trying to convert between these two types: board/morphius/board.c:257:10: error: implicit conversion from enumeration type 'enum ec_ssfc_base_gyro_sensor' to different enumeration type 'enum ec_cfg_base_gyro_sensor_type' [-Werror,-Wenum-conversion] return get_cbi_ssfc_base_sensor(); Rather than duplicate the type (and it accidentally getting out of sync), just use the canonical base type. BRANCH=none BUG=b:172020503 TEST=./util/compare_builds.sh -b all -j 120 => All match, except ezkinil due to the change of the base_gyro_config variable from "int" to "enum" Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I8168518a87469004c33adebed89879225c470ace Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3238249 Reviewed-by: Keith Short <keithshort@chromium.org>
* Guybrush: Remove obsolete commentDiana Z2021-10-211-1/+0
| | | | | | | | | | | | | | FRS is enabled, so TODO is TODONE. BRANCH=None BUG=None TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I7d88e5e1098fd796927bd2982824314e3e8a82a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3237534 Commit-Queue: Rob Barnes <robbarnes@google.com> Reviewed-by: Rob Barnes <robbarnes@google.com>
* Guybrush: Add EN_PWR_S0_R to PCORE enableDiana Z2021-10-213-7/+38
| | | | | | | | | | | | | | | | | | | | Add in the signal for EN_PWR_S0_R to the AND we perform to produce EN_PWR_PCORE_S0_R. This will ensure that if leakage has caused unusual power sequencing, we still turn off the PCORE enable. Additionally, warn if PG_GROUPC_S0_OD is still high after EN_PWR_S0_R has been set to low. BRANCH=None BUG=b:202417065 TEST=on guybrush, confirm normal boot/suspend/shutdown. On faulty board, confirm we turn off EN_PWR_PCORE_S0_R even when PG_LPDDR4X_S3_OD and PG_GROUPC_S0_OD are still high Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I2046474f0fa321f0d3d273f12a2bc5ad20d1b0d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3213275 Reviewed-by: Rob Barnes <robbarnes@google.com>
* adlrvp-n : configure typec ports redriverDeepti Deshatty2021-10-212-2/+10
| | | | | | | | | | | | | | | | | ADL-N supports two typec ports. Typec port0 has TUSB1044 redriver and Port1 is a direct connection. Changes configure port0 usb mux driver to tusb1064 drivers and port1 usb mux drivers to none based on the ADL-N board id BRANCH=none TEST=type-c display verified on ADL-N ERB board Signed-off-by: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com> Change-Id: I78defe364efab5368f9fc6eda9c41cd900a4948d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3220931 Reviewed-by: caveh jalali <caveh@chromium.org> Reviewed-by: Vijay Hiremath <vijay.p.hiremath@intel.com> Commit-Queue: caveh jalali <caveh@chromium.org>
* cherry: config gpio properly to save powerTing Shen2021-10-211-0/+2
| | | | | | | | | | | | | | | | | | | | As suggested in the bug below: - Set unused pin to INPUT|PULLDOWN or OUT_LOW - Disable DP_DEMUX_EN in S3 - Disable unused ADC 1/2 BUG=b:203369223 TEST=measure power consumption BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I1798e6417820a84675509e960037b0503a41fa17 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3230468 Reviewed-by: Parker Lin <parkerlin@google.com> Reviewed-by: Eric Yilun Lin <yllin@google.com> Tested-by: Parker Lin <parkerlin@google.com> Tested-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org>
* ADL_RVP: Enable pre-task I2C transactionsVijay Hiremath2021-10-212-3/+22
| | | | | | | | | | | | | | | | | ADL-RVP needs to access IOEX based GPIOs pre-task to configure the SBU lines to CCD or AUX hence enabled pre-task I2C transactions. BUG=none BRANCH=none TEST=Able to configure config SBU lines for CCD pre-task Change-Id: I1512dc4c1837e769f39e1dd595ae2ba1b4cbdf17 Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3194986 Reviewed-by: caveh jalali <caveh@chromium.org> Reviewed-by: Poornima Tom <poornima.tom@intel.com> Commit-Queue: caveh jalali <caveh@chromium.org> Tested-by: caveh jalali <caveh@chromium.org>
* dedede : fix EC_DPWROK toggle after G3YongBeum.Ha2021-10-211-5/+8
| | | | | | | | | | | | | | | | | | | fix EC_DPWROK toggle after G3. BUG=b:202370937 BRANCH=None TEST=make -j BOARD=bugzzy 1. Check if there is no message that EC_DPWROK goes to high after G3 2. Check EC_PWROK when system goes off and there is no toggle in EC_DPWROK after RSMRST goes to low Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com> Change-Id: I36c03c75a67ad9de44b4f8c62d7c1502e904bc3c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3233460 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* brya: fix prochot mis-triggeredScott Chao2021-10-201-3/+3
| | | | | | | | | | | | | | | The adapter voltage unit should be V, if we used mV will let PROCHOT# mis-triggered. BUG=b:198689488, b:198722634 BRANCH=none TEST=make -j BOARD=gimble TEST=AC only/ AC+DC/ DC only Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: I1a4cad8f83e4adf2e7b1b086a244d8ce286166fb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3229050 Reviewed-by: Boris Mittelberg <bmbm@google.com>
* tree: Files should end with single newlineTom Hughes2021-10-185-5/+0
| | | | | | | | | | | | | | | | | | | | | | | One of the checks that runs as part of "repo upload" looks for a single newline at the end of each file. I'm getting warnings about this when I touch files that do not follow this, even though I didn't add the extra newlines. This commit fixes all files by running the following: for f in $(find . -name '*.[ch]'); do printf '%s\n' "$(cat ${f})" > ${f}; done BRANCH=none BUG=b:172020503 TEST=./util/compare_build.sh -b all -j 120 => MATCH Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Ia3ece5b64b549d21ca11708791368002bb6e9b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3229797 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* tree: Make all console commands staticTom Hughes2021-10-151-1/+1
| | | | | | | | | | | | | | Almost all of the console commands were already static. This change makes all of them static for consistency. BRANCH=none BUG=b:172020503 TEST=make buildall -j Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I0ac46358b6fbafa65504c648ce4de0365cdbf723 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3224372 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* brya: add control prochot featureWill Tsai2021-10-153-0/+264
| | | | | | | | | | | | | BUG=b:198689488 BRANCH=none TEST=make -j BOARD=gimble Signed-off-by: Will Tsai <will_tsai@wistron.corp-partner.google.com> Change-Id: I4be2dc8505baffaa8b7d0c9b6949711aca370778 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3201831 Tested-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Commit-Queue: Boris Mittelberg <bmbm@google.com> Reviewed-by: Boris Mittelberg <bmbm@google.com>
* cherry: powercycle VBUS after AP XHCI doneTing Shen2021-10-151-2/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | Implement VBUS cycle according to USB Type-C Spec R2.0: 10.3.1 Hub Downstream Facing Port State Descriptions 10.3.1.1 DSPORT.Powered-off A hub may provide power to its downstream ports all of the time to support power applications from a USB port. Such hubs must ensure that Enhanced SuperSpeed devices on its downstream-facing ports attempt Enhanced SuperSpeed connection once upstream VBUS is seen by the hub. The recommended method to achieve this is to cycle VBUS off for a duration or by actively discharging so that it is seen to be off by the downstream device. BUG=b:200772411 TEST=manually BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I674391622698b6e241b0a97063b3abbc8550e365 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3195205 Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* corsola: remove references to asurada inside source codeTing Shen2021-10-149-106/+10
| | | | | | | | | | | | | | | | | | | - Remove IS_DEFINED(BOARD_XXX) and board_get_version() calls, assume the default board is Hayato rev 4+. - Remove dynamic g-sensor probing, default to icm426xx. BUG=b:202808130 TEST=1) make BOARD=krabby 2) zmake -D -l DEBUG configure -b zephyr/projects/corsola/krabby/ 3) `ag '(asurada|hayato)' -i` in the board folders shows no match BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I15e4dbb81970052e5b524c4aff9f51ff4c9d89c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3222519 Reviewed-by: Rong Chang <rongchang@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* krabby: initial ECTing Shen2021-10-1412-0/+1318
| | | | | | | | | | | | | | | | | | Start from copying Asurada board. Modified baseboard name in krabby/build.mk and copyright header. Will cleanup in following CLs. BUG=b:202808130 TEST=make BOARD=krabby BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I200c8dec7714dfacc38aad1edbf236c1a6268e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3218585 Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* board: Rename RSMRST_L_PGOOD as PG_EC_RSMRST_ODLfirmware-chameleon-14280.B-mainDivya Sasidharan2021-10-123-2/+3
| | | | | | | | | | | | | | | | | GPIO_RSMRST_L_PGOOD is also used as GPIO_PG_EC_RSMRST_ODL creating redundancy. Removing it will help need for redefinitions for zephyr. Remove reference to GPIO_RSMRST_L_PGOOD in zephyr BUG=b:200975143 BRANCH=main TEST=make buildall -j, boot up on brya Change-Id: Iff46595174c54db347b69cff3ad9e266ba9fd535 Signed-off-by: Divya Sasidharan <divya.s.sasidharan@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3180808 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* cherry: enable EFS2Ting Shen2021-10-121-0/+7
| | | | | | | | | | | | | BUG=b:185726892 BRANCH=main TEST=Verify EFS2 works, see CL:3207813 Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I1e95cd1532abdcb097e4a81d30742dd08f77c46d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2845562 Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* honeybuns: Enable CONFIG_USB_MS_EXTENDED_COMPAT_ID_DESCRIPTORScott Collyer2021-10-111-0/+1
| | | | | | | | | | | | | | | | | This CL enables Extended Compat ID descriptor feature for USB-EP to make sure that Windows host machines will load a valid USB driver. BRANCH=None BUG=b:196174088 TEST=Verfied on Baklava that there is no yellow exclamation warning when connected to a Windows OS host machine. Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: I912dc35f75a673e5e71408b89d653b389ba29d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3165882 Commit-Queue: Scott Collyer <scollyer@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* intelrvp: Treat 2nd reset from H1 as Power-OnVijay Hiremath2021-10-081-0/+2
| | | | | | | | | | | | | | | | | | | on Intel RVP, H-1 resets twice upon fresh boot hence EC sees two resets. This blocks dead battery boot as TCPM treats reset as error recovery and tries TCPC in CC open state. To avoid this issue enabled CONFIG_BOARD_RESET_AFTER_POWER_ON config so that TCPM starts as TC_UNATTACHED_SNK state. BUG=none BRANCH=none TEST=Dead battery boot on ADLRVP works Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com> Change-Id: I6ccf0be4ab6dfcd7557c3228180c1df6bc640ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3214773 Reviewed-by: Tanu Malhotra <tanu.malhotra@intel.com> Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* Guybrush: Enable FRSDiana Z2021-10-081-0/+1
| | | | | | | | | | | | | Enable FRS for the guybrush family of boards. BRANCH=None BUG=b:183586640 TEST=tested FRS with the entire dongle pile, GRL testing passed Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I5022914f270c35ceae9c79f0b29df7122af0f2d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2989629 Reviewed-by: Rob Barnes <robbarnes@google.com>
* cherry: disable customized usb_a port power for Cherrystabilize-ambassador-14268.43.B-mainstabilize-14268.67.B-mainstabilize-14268.52.B-mainstabilize-14268.51.B-mainrelease-R96-14268.B-mainTing Shen2021-10-071-0/+2
| | | | | | | | | | | | | | | | | | Old Cherry board does not have AP_XHCI_INIT_DONE pin to trigger the interrupt. Use the default hooks in usb_port_power_dumb instead. BUG=b:201238487 TEST=Verify usb to ethernet dongle works BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: Ifca76c2f029f322fdafe28a36a2bd596d4cb1574 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3204565 Tested-by: Ting Shen <phoenixshen@chromium.org> Auto-Submit: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Rong Chang <rongchang@chromium.org> Commit-Queue: Rong Chang <rongchang@chromium.org>
* bugzzy : set VSN/VSP/VBSTYongBeum.Ha2021-10-071-1/+6
| | | | | | | | | | | | | | | | change VBST to 5.65V change VSN/VSP to 5.5V BUG=b:198072674 BRANCH=None TEST=make -j BOARD=bugzzy Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com> Change-Id: I108914d5a6171034047101d95eafb997b5a2abd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3207767 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* baseboard/cherry: don't reset rt1718s gpio state in every init() callTing Shen2021-10-051-4/+10
| | | | | | | | | | | | | | | | | | | | To make the device bootable without battery, board_rt1718s_init() enables sink path (GPIO1) at boot, but also incorrectly enables sink path on subsequent low-power-mode exits. Fix this incorrect behavior: board_rt1718s_init should keep the previous GPIO state on LPM exit. BUG=none TEST=verify that C1 sink path does not turn on by default when replug BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I8ae8f65e101fc66f828168237c136ca180189c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3195204 Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* kukui: Disable 'flashwp' console commands to save spaceVijay Hiremath2021-10-041-0/+1
| | | | | | | | | | | | | | | | | | | | Just preserving the build at ToT. Do not cherry pick. BRANCH=none BUG=none TEST=make BOARD=krane -j Before: 4180 bytes in flash and 11268 bytes in RAM still available on krane RO 80 bytes in flash and 8244 bytes in RAM still available on krane RW After: 4308 bytes in flash and 11268 bytes in RAM still available on krane RO 304 bytes in flash and 8244 bytes in RAM still available on krane RW Change-Id: I1d433999560ca9e176d1c420cda6dadb29ec7509 Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3200517 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* kukui: Disable 'chgsup & gettime' console commands to save spaceVijay Hiremath2021-10-011-0/+2
| | | | | | | | | | | | | | | | | | | | Just preserving the build at ToT. Do not cherry pick. BRANCH=none BUG=none TEST=make BOARD=kodama -j before: 236 bytes in flash and 11212 bytes in RAM still available on kodama RO 13696 bytes in flash and 8688 bytes in RAM still available on kodama RW After: 428 bytes in flash and 11212 bytes in RAM still available on kodama RO 13696 bytes in flash and 8688 bytes in RAM still available on kodama RW Change-Id: I42ffbf532d2a42b8d325692f20ca5f0c061e8969 Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3198233 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* brask: Add Barrel jack power supply handlingDavid Huang2021-09-301-0/+3
| | | | | | | | | | | | | | | Add Barrel jack power supply handling from puff. BUG=b:197514362 BRANCH=None TEST=booted on hardware, verified chgsup output with barrel jack Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com> Change-Id: Ifc138c8c9938d489044125437e515b898e01f362 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3139614 Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* brya family: fix keyboard wake in tablet modeBoris Mittelberg2021-09-291-1/+27
| | | | | | | | | | | | | Block keyscan in S0ix, when the device is in tablet mode BUG=b:199114579 BRANCH=none TEST=manual, as described in b:199114579 Signed-off-by: Boris Mittelberg <bmbm@google.com> Change-Id: I17c5fc55e5e07ae180275aba492ef491b2d116cc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3180270 Reviewed-by: caveh jalali <caveh@chromium.org>
* cherry: enable DPSEric Yilun Lin2021-09-281-0/+1
| | | | | | | | | | | | | | | Enable Dynamic PDO Selection to provide a more efficient charging. BUG=b:196911733 TEST=Pass PD FAFT and FAFT-EC BRANCH=none Change-Id: Ie615d63fbca54bf70412367e8f3befabd7db5832 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3124474 Tested-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com>
* zephyr: Fix broken volteer buildJeremy Bettis2021-09-271-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On github, the volteer build was failing with error: undefined reference to `ppc_is_vbus_present' but it was building in the chroot. It seems the chroot linker can determine that the pd_snk_is_vbus_provided function is never called, but the zephyr toolchain linker cannot, or perhaps it does missing function detection before removing unused functions. Remove pd_snk_is_vbus_provided if CONFIG_USB_PD_VBUS_DETECT_PPC is not set. BRANCH=None BUG=b:194375840 TEST=In docker container: PROJECT=volteer; PROJECT_SUBDIR=volteer/; VERSION=26; unset TOOLCHAIN zmake -j1 --zephyr-base "${ZEPHYR_BASE}${VERSION}" \ --modules-dir "${MODULES_DIR}" -l DEBUG configure -b \ -B "${BUILD_DIR}/${PROJECT}" -t ${TOOLCHAIN:-zephyr} \ zephyr/projects/${PROJECT_SUBDIR}${PROJECT} In chroot: zmake configure -b zephyr/projects/volteer/volteer Change-Id: I59679a12e89e8b2e5fa2f62dc5fa60d108234d23 Signed-off-by: Jeremy Bettis <jbettis@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3188214 Reviewed-by: Yuval Peress <peress@google.com> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Reviewed-by: Aaron Massey <aaronmassey@google.com> Reviewed-by: Parth Malkan <parthmalkan@google.com> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Yuval Peress <peress@google.com> Commit-Queue: Fabio Baltieri <fabiobaltieri@google.com> Tested-by: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
* tomato: board rev2 gpio updateTing Shen2021-09-231-1/+1
| | | | | | | | | | | | | | | | | | | GPA4/GPA5: kb backlight -> Programming I2C GPA3: Test point -> KB_BL_PWM GPA6: Test point -> EN_KB_BL Since the PWM pin changed, this CL breaks kb backlight on old boards. BUG=b:199829459 TEST=pass factory test BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I33c42708b7694aeb625ea5b0879b3ac08ec81f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3160457 Reviewed-by: Eric Yilun Lin <yllin@google.com> Tested-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org>
* cherry: enable CONFIG_USB_PORT_POWER_DUMB_CUSTOM_HOOKTing Shen2021-09-232-0/+4
| | | | | | | | | | | | | | | | | | | CL:3023017 does not work as expected because usb_port_power_dump module still controls the power power. This CL disables the hooks in usb_port_power_dump and enables the interrupt function usb_a0_interrupt instead. BUG=b:193499785 TEST=verify USB-A port works after this change BRANCH=main Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I56196f2a062d6b3358a9a4330e7f33ab546f5d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3174606 Reviewed-by: Rong Chang <rongchang@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* board/guybrush-dewat: Minor cleanupGwendal Grignou2021-09-231-1/+2
| | | | | | | | | | | | | | | Remove g_bmi323 static variable, use same structure as bmi160. Fill motion_sensors array with index in order. BUG=b:195264765 BRANCH=none TEST=compile Change-Id: I2c16fa64db7786bf5ff977cd6626c3d9de9b66b4 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3172268 Reviewed-by: Rob Barnes <robbarnes@google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
* cherry: redesign RT1718S GPIO 1/2 behaviorTing Shen2021-09-223-48/+10
| | | | | | | | | | | | | | | | | | | | | | | Reimplement the logic of GPIO 1/2 such that the state of these pins does not tied together anymore. Instead, board_set_active_charge_port controls GPIO 1 only, and pd_power_supply_* functions controls GPIO 2 only. Also give these pins a readable name. BUG=b:198707662 TEST=1) pass faft_pd on port C1 2) able to boot with C1 plugged AC power and without battery BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: Id33160a0c3ed202cdfe3666c2444098a3031229f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3168036 Reviewed-by: Rong Chang <rongchang@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* byra: Disable ACPI messages on EC console by defaultGwendal Grignou2021-09-221-2/+5
| | | | | | | | | | | | | | | | | | When using sensors a lot of messages are sent, overwhelming the EC console port. BUG=none BRANCH=master TEST=When running "tast run <ip hardware.SensorIioserviceHard", check the EC console is not overflown with message like: 21-09-17 23:01:41.981 [444.007624 ACPI query = 27] 21-09-17 23:01:42.053 [444.086884 event set 0x0000000004000000] 21-09-17 23:01:42.057 [444.087864 event clear 0x0000000004000000] Change-Id: I825831d83ce468d719b4303abadec4e2e0a0d1af Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3170173 Reviewed-by: Keith Short <keithshort@chromium.org>
* mancomb: Delete board supportJack Rosenthal2021-09-207-1585/+0
| | | | | | | | | | | | | | | | | | Builders have been shutoff, and overlays are gone. EC board support can be dropped. BUG=b:190404616 BRANCH=none TEST=CQ Cq-Include-Trybots: luci.chromeos.cq:cq-orchestrator Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I0c7c3f003c9c3ec66101e6b16b17585bd85e70fb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3171108 Commit-Queue: Martin Roth <martinroth@google.com> Tested-by: Martin Roth <martinroth@google.com> Reviewed-by: Martin Roth <martinroth@google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
* adlrvp: Support EC_CMD_BATTERY_GET_STATIC version 1poornima tom2021-09-171-0/+8
| | | | | | | | | | | | | | | | | | | Support for EC_CMD_BATTERY_GET_STATIC version-1 is added to prevent an ioctl error, on entry of ectool battery command. BUG=none BRANCH=none TEST=Verify on adlrvp using ectool battery command ectool battery command returned correct battery information without any ioctl error. Signed-off-by: poornima tom <poornima.tom@intel.com> Change-Id: I359241e8696da0f83e649a920953bc25a88bb0a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3156318 Reviewed-by: Vijay Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: caveh jalali <caveh@chromium.org> Commit-Queue: caveh jalali <caveh@chromium.org>
* adlrvp: Remove retimer support for N SKUpoornima tom2021-09-172-0/+17
| | | | | | | | | | | | | | | | | | Type-C ports of ADL-N based RVP SKU do not have retimers. Hence, removed the reference for retimers based on board id of the ADL-N platform at run time. BUG=none BRANCH=none TEST=Tested on ADL-N Signed-off-by: poornima tom <poornima.tom@intel.com> Change-Id: I0e57fc199cc4a0192056eff35ba10fbac457cf4f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3143407 Reviewed-by: Vijay Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: caveh jalali <caveh@chromium.org> Tested-by: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com> Commit-Queue: caveh jalali <caveh@chromium.org>
* herobrine: Always enable the 5V railWai-Hong Tam2021-09-162-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Prepare the next hardware revision. It has a PPC chip which requires 5V rail in S5. The 5V rail enable pin should be turned on whenever the EC is powered. Since the existing 5V rail enabling is done inside the qcom power sequence. Trogdor and Herobrine both shares this qcom power sequence. For Trogdor, this CL moves the 5V rail enabling from the qcom power sequence to the board level hook. For Herobrine, this CL updates the GPIO name and modifies the default level to HIGH. The CONFIG of 5V control should be disabled. As no board level hook to modify the 5V rail, the 5V is always on. BRANCH=None BUG=b:199804198 TEST=Booted both Zephyr and EC-OS images on Herobrine. Checked the 5V rail is enabled in S0 and S5. TEST=Booted both Zephyr and EC-OS images on Lazor. Checked the 5V rail is enabled in S0 and disabled in S5. Change-Id: Ifa98ee0c4e970dd89952e94cc6a0e289798e6a57 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3163918 Reviewed-by: Keith Short <keithshort@chromium.org>
* BB Retimer: Add new HPD callback to boardsDiana Z2021-09-161-0/+6
| | | | | | | | | | | | | | | Now that the BB retimer has its own HPD interface, add this interface to every board using the bb_usb_retimer driver. BRANCH=None BUG=b:195773400 TEST=on voxel, pass tast typec.Mode*.manual Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Ia70d139431739e8f2c0577359cb3aaa7fb906d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3163930 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* USB MUX: Update mux HPD update interface to use mux_state_tDiana Z2021-09-1610-17/+46
| | | | | | | | | | | | | | | | | Since the drivers are now taking a mux_state_t set of flags to update, go ahead and unify the usb_mux API this way as well. It makes the parameters more apparent than the 1/0 inputs, and aligns the stack to use the same parameters. BRANCH=None BUG=b:172222942 TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Ie943dbdf03818d8497c0e328adf2b9794585d96e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3095438 Commit-Queue: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
View Lorry Controller Status