summaryrefslogtreecommitdiff
path: root/baseboard
Commit message (Collapse)AuthorAgeFilesLines
* volteer: remove VSYNC sensorstabilize-lazor-13278.B-masterKeith Short2020-06-091-5/+0
| | | | | | | | | | | | | | | Remove VSYNC sensor support from all volteer boards. BUG=b:146452722 BRANCH=none TEST=make buildall TEST=Boot Volteer, run "ectool motionsense" Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I1662f510901fb99a45999f46b854e7ceb3874f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2238671 Commit-Queue: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* kukui: Disable TCPMv1 state names in ROKeith Short2020-06-091-0/+4
| | | | | | | | | | | | | | | | | | | Disable CONFIG_USB_PD_TCPMV1_DEBUG to save 900 bytes of RO flash space. This is to keep kukui buildig at ToT - do not pick this onto a release branch. BUG=b:156398243 BRANCH=none TEST=make buildall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I7bc9d84a0cd172e20399b51eb7cd73c89119a574 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2236866 Reviewed-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
* volteer: add USB overcurrent notification to APKeith Short2020-06-051-1/+9
| | | | | | | | | | | | | | | Enable the USB C0 and USB C1 overcurrent signals to the AP. BUG=b:140561826 BRANCH=none TEST=make buildall TEST=Force overcurrent event by manually setting PPC current limit below PD contract. Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I5eea4812c212496f1c483c4149697b2d53a16a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2222960 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* Ezkinil: modify some gpio definitionSue2020-06-052-22/+0
| | | | | | | | | | | | | | | | | | | rename GPIO F4: DP1_HPD -> EC_DP1_HPD remove IOEX 10 HDMI_CONN_HPD_3V3_DB add GPIO 75: DP1_HPD_EC_IN move hdmi_hpd_interrupt and hdmi_hpd_handler from baseboard to board BUG=b:152512560, b:153397667, b:155797182 BRANCH=none TEST=make buildall -j Change-Id: I5cdbb42a8284c85104dbbbe7b3d557d51a11a074 Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2224693 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org> Tested-by: Edward Hill <ecgh@chromium.org>
* zork: Move tcpc,ppc,bc12 from baseboard to boardLu Zhang2020-06-053-212/+210
| | | | | | | | | | | BUG=b:158125500 BRANCH=none TEST=Build all zork boards Signed-off-by: Lu Zhang <lu.zhang@bitland.corp-partner.google.com> Change-Id: I86a21a049f97c42d330be6c1bfbecbda10e1ebb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2230941 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* volteer: Enable CONFIG_USB_PD_USB32_DRDAyushee2020-06-051-0/+3
| | | | | | | | | | | | | BUG=b:148528713 BRANCH=None TEST=On connecting Gatkex Creek with DUT as UFP, the DUT enter into USB3 mode. Change-Id: I98d83ed14d92431b9e0392ffceb4e37792dde9f1 Signed-off-by: Ayushee <ayushee.shah@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2225602 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* vilboz: Remove PCAL6408 entirely and enable HDMILu Zhang2020-06-054-78/+25
| | | | | | | | | | | | | BUG=b:157182792, b:158125500 BRANCH=none TEST=make BOARD=vilboz Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I71e38117309277c39ed245535643d601e8759d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2227782 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Lu Zhang <lu.zhang@bitland.corp-partner.google.com> Commit-Queue: Lu Zhang <lu.zhang@bitland.corp-partner.google.com>
* baseboard/kukui: lower pd max voltage to 15V for jacuzziTing Shen2020-06-051-1/+2
| | | | | | | | | | | | | | | | Charging performance is better at 15V than 20V, see the analysis result in issue link below. BUG=b:157116471 TEST=make BRANCH=kukui Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I8113809372fc2e1e92be901025ee1ed4bd588a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2230219 Reviewed-by: Eric Yilun Lin <yllin@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* Bobba: add PPC syv682x configDavid Huang2020-06-042-3/+2
| | | | | | | | | | | | | Supoprt PPC SYV682X on bobba. BUG=b:154772847, b:156711950 BRANCH=octopus TEST=Check usb dongle/typec adapter worked properly in any power state. Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com> Change-Id: I1b87d3de4a749005b5bf4c1d42cb4bf1fa61f1ec Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2227772 Reviewed-by: Marco Chen <marcochen@chromium.org>
* zork: enable CONFIG_USB_PD_DISCHARGE_TCPCDenis Brockus2020-06-031-0/+1
| | | | | | | | | | | | | | | | | | | Add TCPC Vbus Forced Discharge to bring us to Safe0V faster when we should be disconnecting BUG=b:157755939 BRANCH=none TEST=look at Vbus after PR Swap for speed to Safe0V Signed-off-by: Denis Brockus <dbrockus@google.com> Change-Id: Idfc5771eb84a56ecab0879dd0a352a48c4c767ee Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2228088 Tested-by: Denis Brockus <dbrockus@chromium.org> Auto-Submit: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Jett Rink <jettrink@chromium.org>
* Zork: Switch PS8743 from IOEX_USB_C1_DATA_EN to I2CEdward Hill2020-06-031-22/+0
| | | | | | | | | | | | | | | | | Align all Zork devices on using I2C control of PS8743 mux mode, and stop using IOEX_USB_C1_DATA_EN signal/pin. This matches what we were already doing for Dalboz, and gives power savings in both S0 and S3 when nothing is plugged in and mux is set to none. BUG=b:157951317 BRANCH=none TEST=external display and i2ctrace on ezkinil Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Id1c8b172a99bb25bed8b57e90686d933447432f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2227589 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* Zork: Power off USB-A1 retimer in S3Edward Hill2020-06-031-2/+2
| | | | | | | | | | | | | | Fix from CL:2209659 for Trembyle is also needed for Dalboz and Ezkinil. BUG=b:156696798 BRANCH=none TEST=USB-A still works Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Id62bb9668042642eb3b0a64798a2aa4c763a604d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2227590 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* volteer: add support for USB4 Gen3Keith Short2020-06-022-7/+18
| | | | | | | | | | | | | | | | | | Latest Volteer motherboards and USB4 daughterboards support USB4 Gen3 speeds. Create new USB daughterboard type in CBI FW_CONFIG to support this configuration. BUG=b:157483704 BRANCH=none TEST=make buildall TEST=Set USB DB type to 3 (USB4_GEN3), verify TBT cable speed is reported as Gen3 to the kernel extcon-tcss-cros-ec driver. Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I7873db70436cb9500387620a0e800c3ee79a384d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2223912 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
* Dedede: Enable PD 3.0Diana Z2020-05-301-0/+1
| | | | | | | | | | | | | | Semantics to set PD 3.0 on the v2 stack changed recently, so enable PD 3.0 specifically (rather than it being default) BRANCH=None BUG=None TEST=make -j buidall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I681a406665f7f9673bdf96c0a7c8dfcd13a28186 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2219285 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* baseboard/kukui: move bitbang stability fix to common codeTing Shen2020-05-291-0/+77
| | | | | | | | | | | | | | | | | | All Kukui boards with bitbang enabled should have this board_battery_compensate_params() to make sure host side does not receiving bad data. BUG=b:156998242 TEST=make BRANCH=kukui Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I3cd6ec521fd9d7b6b985ba15f96f694fd9095cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2219711 Reviewed-by: Fei Shao <fshao@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* Volteer: Turn off display backlight on lid closeAyushee2020-05-291-0/+4
| | | | | | | | | | | | | | | Enable CONFIG_BACKLIGHT_LID so that EC can turn off display backlight when the lid is closed. BUG=b:155882590 BRANCH=None TEST=Backlight LED is turned off on lid close Change-Id: I4b9606d36c646bd3f5549bed05e8a4f7426e07c5 Signed-off-by: Ayushee <ayushee.shah@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2220155 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* dedede:Pull VCCIO_EXT low within 200us of SLP_S3_LSooraj Govindan2020-05-281-0/+3
| | | | | | | | | | | | | | | | | | | | | | There is a potential race condition where VCCST_PWRGD gets pulled LOW, while EN_VCCIO_EXT is still HIGH, during SLP_S3_L assertion. EN_VCCIO_EXT was not driven low in the baseboard_all_sys_pgood_interrupt(). So VCCST_PWRGD was getting SET again by the time EN_VCCIO_EXT is driven LOW in the switch case. This patch ensures that VCCST_PWRGD gets pulled low along with EN_VCCIO_EXT. BUG=b:153763236, b:157216597 BRANCH=none TEST=verify SLP_S3 entry and exit Signed-off-by: Sooraj Govindan <sooraj.govindan@intel.com> Change-Id: Iaf85b9ff6d4cb420dd330d5852b11e05e4401b54 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2217600 Tested-by: Sooraj Govindan <sooraj.govindan@intel.corp-partner.google.com> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* volteer: enable CONFIG_DPTFCaveh Jalali2020-05-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | this enables the handling of DPTF messages from the AP. BRANCH=none BUG=b:149722146,b:143768086 TEST=the EC no longer complains about ACPI write of 0x05, 0x06, 0x07. when we enabled DPTF on the AP side, we started getting unexpected messages on the EC: [24.693238 ACPI write 0x05 = 0x00 (ignored)] [24.694214 ACPI write 0x06 = 0x73 (ignored)] [24.695011 ACPI write 0x07 = 0x03 (ignored)] which correspond to: #define EC_ACPI_MEM_TEMP_ID 0x05 #define EC_ACPI_MEM_TEMP_THRESHOLD 0x06 #define EC_ACPI_MEM_TEMP_COMMIT 0x07 Change-Id: I29f21001e68ead0cf5d22dde692f73e830b65ba7 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2211842 Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com> Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Nick Vaccaro <nvaccaro@google.com> Commit-Queue: Keith Short <keithshort@chromium.org> Tested-by: Keith Short <keithshort@chromium.org>
* kukui: reduce image sizeKeith Short2020-05-271-1/+1
| | | | | | | | | | | | | | Remove the hcdebug from the Kukui board family RO images to reduce code size. BUG=b:156398243 BRANCH=none TEST=make buildall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I6b21aa2df6242bb0f384a107013f2a171d27416a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2216587 Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
* volteer: enable CONFIG_FPUCaveh Jalali2020-05-271-0/+1
| | | | | | | | | | | | | this enables FPU support on the EC. we have this enabled on other npcx7 devices, so there should be no surprises. BRANCH=none BUG=none TEST=booted on volteer Change-Id: Icba30fdac2c823b0fc4e1754a7de4bb83708bb51 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2211843
* Extend the tcpci register dump.Andrew McRae2020-05-273-3/+3
| | | | | | | | | | | | | | | | | Extend the tcpci register dump command to allow chip specific register dumps to be displayed. BUG=b:157206143 TEST=Display ANX3447 registers on Puff. BRANCH=none Change-Id: Ib2bf1adcbe3bce75ff54c36c4306b17356eae96f Signed-off-by: Andrew McRae <amcrae@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2208344 Tested-by: Andrew McRae <amcrae@chromium.org> Auto-Submit: Andrew McRae <amcrae@chromium.org> Reviewed-by: Peter Marheine <pmarheine@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: Andrew McRae <amcrae@chromium.org>
* zork: Enable USB PD Version 3.0Denis Brockus2020-05-261-0/+2
| | | | | | | | | | | | | | | BUG=none BRANCH=none TEST=verify USB is working Signed-off-by: Denis Brockus <dbrockus@google.com> Change-Id: I3b7ef4faa7cc535be2df597e0dd8b9a73388f36d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2212204 Tested-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Jett Rink <jettrink@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org> Auto-Submit: Denis Brockus <dbrockus@chromium.org>
* zork: Enable CC_PWM console channelEdward Hill2020-05-211-1/+1
| | | | | | | | | | | | | Now that "fan stalled" spam has been fixed. BUG=b:154938623 BRANCH=none TEST=no annoying console messages Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Ie5655cbfc53f74dbd3b6b0aa36d8fc7a91eafeaa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2210833 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* Waddledee: configure ECH1_PACKET_MODEDiana Z2020-05-211-0/+1
| | | | | | | | | | | | | | This GPIO will be used for communication with the cr50 when EFS2 is enabled. BRANCH=None BUG=b:156785198 TEST=make -j buildall, waddledee boots Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Ia1193bf61995ec0f1892a753570f28eaba64ab26 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2210863 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* Zork: Add pi3hdx1204 db tuning.David Huang2020-05-211-0/+7
| | | | | | | | | | | | | | | Add pi3hdx1204 db tuning by vendor suggestion. BUG=b:156058725 BRANCH=none TEST=check pi3hdx1204 register setting is correct. Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com> Change-Id: I14110b43ba3a008f88c31a80398a82fa34820970 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2192455 Commit-Queue: Edward Hill <ecgh@chromium.org> Tested-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* Zork: Check FW_CONFIG for keyboard backlightEdward Hill2020-05-211-0/+11
| | | | | | | | | | | | | | | Remove keyboard backlight feature EC_FEATURE_PWM_KEYB for devices that don't support it. BUG=b:154088311 BRANCH=none TEST=feature reported matches FW_CONFIG Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I99b11422cdd83c7d1def8494b30d5f70d40fb5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2209922 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* Ezkinil: Setting input current limit to 95%Sue2020-05-201-1/+1
| | | | | | | | | | | | | | Setting lower input current limit to make sure safety confirm test pass. BUG=b:156962946 BRANCH=none TEST=make buildall Change-Id: I3afa3c70076fcff319e47c08901616916c0a467b Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2172276 Reviewed-by: Edward Hill <ecgh@chromium.org>
* Trogdor: Disable the host command of EC SPI flash infoWai-Hong Tam2020-05-201-1/+0
| | | | | | | | | | | | | | | | | | | | | Flashrom first uses the host command to get EC SPI flash info. If not there, then uses the host command to get EC chip info. The factory process expects flashrom return the EC chip info in order to construct a HWID. Disable the host command of EC SPI flash info to be compliant with the factory flow. BRANCH=None BUG=b:156778746 TEST=Ran "flashrom -p ec --flash-name 2>/dev/null", which returned: vendor="Nuvoton" name="NPCX796F" Change-Id: I729ce40942283e41c38d70fcca38181613d9ed9c Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2209428 Reviewed-by: Philip Chen <philipchen@chromium.org> Reviewed-by: Bob Moragues <moragues@chromium.org>
* Trogdor: Enable debug features for USB PDWai-Hong Tam2020-05-161-0/+1
| | | | | | | | | | | | | | | Enable the I2C trace and TCPCI dump, which are useful for debugging USB Type-C related issues. TCPCI dump has no performance impact. It can still be enabled on production. BRANCH=None BUG=b:146075455 TEST=Tried the console commands i2ctrace and tcpci_dump. Change-Id: I2f39c8fb91db2a853eb4b9d5d159d5e137b3b087 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2204580 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* usb_pd: Rename CONFIG_CMD_PD_CONTROL to CONFIG_HOSTCMD_PD_CONTROLVijay Hiremath2020-05-159-8/+11
| | | | | | | | | | | | BUG=none BRANCH=none TEST=make buildall -j Change-Id: I33a63d6ac45bbd46da74db34a21d1bb130476362 Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2196946 Reviewed-by: Sooraj Govindan <sooraj.govindan@intel.corp-partner.google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* kakadu: modify charger and gauge parameter to reduce charging timeScott Chao2020-05-141-1/+1
| | | | | | | | | | | | | | | After power team experiment, change those parameter can reduce charging time. BUG=b:156398259 BRANCH=kukui TEST=make -j BOARD=kakadu TEST=make buildall Signed-off-by: Scott Chao <scott.chao@bitland.corp-partner.google.com> Change-Id: I636ac4608e7af4afcc8d1adbadeead75d3e6c3b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2198815 Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* Zork: Use FW_CONFIG for IOEX_HDMI_CONN_HPD_3V3_DB.Edward Hill2020-05-121-3/+0
| | | | | | | | | | | | | | | | Use FW_CONFIG to only enable IOEX_HDMI_CONN_HPD_3V3_DB interrupt when appropriate. BUG=b:156046102 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Ib12943e6ebbbd9af9c46ac548921aea5eb96f504 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2195187 Reviewed-by: David Huang <david.huang@quanta.corp-partner.google.com> Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* Zork: Use FW_CONFIG for IOEX_MST_HPD_OUT.Edward Hill2020-05-121-32/+0
| | | | | | | | | | | | | | | | | Move mst_hpd_interrupt() out of variant_trembyle.c into individual boards. Use FW_CONFIG to only enable IOEX_MST_HPD_OUT interrupt when appropriate. BUG=b:156046102 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I3f188088254208f01aea2094b7f2b57590b0d91b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2195186 Reviewed-by: David Huang <david.huang@quanta.corp-partner.google.com> Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* hatch: Remove the board keyscan_config definition and use the defaultWai-Hong Tam2020-05-112-22/+0
| | | | | | | | | | | | | | | | | | | The keyscan_config is the same as the default. Don't define the board custom keyscan_config. For the board.h, most of them have duplicated definitions from the baseboard.h. Remove them by the script: $ grep -rl 'BASEBOARD:=hatch' * | cut -f1 -d/ | xargs -IX sed -i \ '/#define CONFIG_KEYBOARD_BOARD_CONFIG/d' X/board.h BRANCH=hatch BUG=b:156007029 TEST=Build all the hatches boards, no error. Change-Id: Ib02550708d533ced77f5fad05b074291b66dd4fc Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2194160 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
* volteer: set H1 packet mode GPIO lowKeith Short2020-05-091-1/+0
| | | | | | | | | | | | | | | | | | GPIO75 on board version 1 is used for H1 packet mode and must be initialized low. This change disables the VOLUME_UP button on board version 0. BUG=b:156117916 BRANCH=none TEST=make buildall TEST=verify EC console is not read only. Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I58d70e833027a9bdb8d4f2463567820c2de1b590 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2191295 Reviewed-by: caveh jalali <caveh@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* zork: enable tcpci_dump console commandDenis Brockus2020-05-081-0/+1
| | | | | | | | | | | | | | | BUG=none BRANCH=none TEST=verify tcpci_dump works Signed-off-by: Denis Brockus <dbrockus@google.com> Change-Id: I11590e50139a8ff571bcd2f002b05c45f7f8f423 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2185870 Commit-Queue: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Diana Z <dzigterman@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org> Auto-Submit: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* Remove unused CONFIG macrosDaisuke Nojiri2020-05-081-1/+0
| | | | | | | | | | | | | | CONFIG_GPU, CONFIG_USB_SM_FRAMEWORK, CONFIG_BOARD_HAS_AFTER_RSMRST are no longer used. This patch removes them. BUG=b/155996358 BRANCH=none TEST=buildall Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Change-Id: Ia407850398c07b7cdb01cddb0288ae977b9dca82 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2189171 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* Zork: Disable vivaldi keyboardEdward Hill2020-05-081-0/+1
| | | | | | | | | | | | | | Undef CONFIG_KEYBOARD_VIVALDI to fix function keys on Zork. BUG=b:155941390 BRANCH=none TEST=ctrl+alt+f2 can enter VT2 Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I348044cceb8ba81e26d7af74cf95eaf1a3865edd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2188114 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* dedede: Pull VCCST_PWRGD low within 200us of SLP_S3_LWill Arthur2020-05-071-2/+5
| | | | | | | | | | | | | | | | Early protos have a hardware bug where VCCST_PWRGD may not get pulled below VIL with hardware logic. This patch ensures that VCCST_PWRGD gets pulled low strongly. BUG=b:153763236 BRANCH=none TEST=During shutdown, measured time from SLP_S3_L assertion to VCCST_PWRGD de-assertion should be <200us Signed-off-by: Will Arthur <wda@google.com> Change-Id: I29c42f29f9172c1ef083012d66b1fb3417bb790b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2182040 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* Zork: Enable EFS2Daisuke Nojiri2020-05-061-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | EFS v.1 allowed Chromeboxes to verify RW without AP. EFS v.2 will bring the benefits to Chromebooks, which are: - Immediate boot on deeply discharged battery. - Faster charge in S5/G3. - Reduce RO dependency. Allow more code to be updated by AU. - Remove jumptag and workarounds needed for late sysjump. - Can support recovery mode regardless of battery condition. Major improvements over v.1 are: - No A/B slot required. - No signature in RW or public key in RO. - Rollback-attack protection. - Verifies only used part of RW (instead of whole RW section) EC-Cr50 communication is based on the shared UART (go/ec-cr50-comm). EFS2 is documented in go/ec-efs2. Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> BUG=b/146393197 BRANCH=none TEST=Verify Trembyle boots and sync EC RW. AP FW: 13066.0.0 Cr50 FW: 0.6.1 Change-Id: Ib3c5b23817938ccd3a90c90cede8aeea26b37e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2171575 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Daisuke Nojiri <dnojiri@chromium.org> Auto-Submit: Daisuke Nojiri <dnojiri@chromium.org>
* malefor: enable lid anglexiong.huang2020-05-062-1/+33
| | | | | | | | | | | | | | | | Enable lid angle function to make peripherals get correct state on convertible SKUs. BUG=b:152434719 BRANCH=none TEST=boot malefor, test keyboard function when hinge is at 135, 180, 270, 360 degree when set bit #4 of CBI fw_config. No sensor data when clear bit #4 of CBI fw_config. Signed-off-by: xiong.huang <xiong.huang@bitland.corp-partner.google.com> Change-Id: I83797a4d4a16b2c2903ac7c6d9cc5597a9855ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2156685 Reviewed-by: Keith Short <keithshort@chromium.org>
* Zork: Add PI3HDX1204 power control.Edward Hill2020-05-052-0/+15
| | | | | | | | | | | | | | Power the PI3HDX1204 HDMI retimer on at resume and off at suspend. BUG=b:154874071 BRANCH=none TEST=HDMI still works Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I1753177db4b99d2c4a6af0720ace70ad3ba7f530 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2181794 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* volteer: configure USB virtual mux with USB3 DBKeith Short2020-05-031-3/+15
| | | | | | | | | | | | | | | | | The USB virtual mux must always be used with TGL so that the TCSS is configured correctly on USB mux (including HPD) changes. BUG=b:155145518 BRANCH=none TEST=make buildall TEST=verify DP operation on USB3 DB. Both cable orientations working. Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I337d520bd468082cd8c158c7a596bf775709307a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2177097 Tested-by: Eric Herrmann <eherrmann@chromium.org> Commit-Queue: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* dedede: Add support for S0ixAseda Aboagye2020-04-301-0/+3
| | | | | | | | | | | | | | | | | | Dedede will support S0ix, therefore this commit adds support such that the EC can track those sleep states. BUG=None BRANCH=None TEST=`make -j buildall` TEST=Flash waddledee, verify DUT still boots. Signed-off-by: Aseda Aboagye <aaboagye@google.com> Change-Id: I4dd60bfb91af1f1b257440fbd640b8667225d6da Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2171562 Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
* Zork: Move charger I2C to match HW changeEdward Hill2020-04-294-17/+59
| | | | | | | | | | | | | | | | | Split chg_chips[] into Trembyle and Dalboz variants. Change I2C_PORT_CHARGER to I2C4_1 for Trembyle V1 HW. Check for V0 HW on boot to re-map back to I2C2_0. BUG=b:155156669 BRANCH=none TEST=charger still works on V0 HW Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Ia90b9ed34551b2fea72b921bbdffe8e1a9249188 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2171044 Reviewed-by: Aaron Durbin <adurbin@google.com> Reviewed-by: Martin Roth <martinroth@google.com> Commit-Queue: Martin Roth <martinroth@google.com>
* Ampton: assert RSMRST to PCH while force shutdownDino Li2020-04-281-0/+14
| | | | | | | | | | | | | | | | | | This change was made to fix issue of PP3300_LDO dropped while force shutdown. And the dropping will cause EC exception due to EC's power rail is dropped. BUG=b:144548329 BRANCH=none TEST=On ampton, "apshutdown" can be run over 100 times and no exception triggered. Change-Id: I1b050b40bb91d123bb71a92261e98efd1db71628 Signed-off-by: Dino Li <Dino.Li@ite.com.tw> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2142840 Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: Jett Rink <jettrink@chromium.org> Tested-by: Jett Rink <jettrink@chromium.org>
* malefor: turn off USB4 and Thunderbolt supportxiong.huang2020-04-281-6/+0
| | | | | | | | | | | | | | Malefor board only support USB3, so turn off USB4 and Thunderbolt support. BUG=b:153996396 BRANCH=none TEST=male buildall Signed-off-by: xiong.huang <xiong.huang@bitland.corp-partner.google.com> Change-Id: Iff87d7cae7876656ac082cfe322dd63d87a74b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2167120 Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* volteer: move the PWM configuration and LED support from baseboard to boardsxiong.huang2020-04-284-168/+0
| | | | | | | | | | | | | | | | | Considering the LED circuits for the derived boards differ significantly from Volteer and every OEM would have different requirements for LED behavior. So move the PWM configuration and LED support from baseboard (volteer) to board (halvor, malefor and volteer), there will be happy to redefine LED behavior in boards. BUG=b:154447182 BRANCH=none TEST=make buildall Signed-off-by: xiong.huang <xiong.huang@bitland.corp-partner.google.com> Change-Id: I578459d4dd75abce4eed83e1f69a14886bb6a0f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2156688 Reviewed-by: Keith Short <keithshort@chromium.org>
* Volteer: enable battery optionsKeith Short2020-04-251-0/+3
| | | | | | | | | | | | | | | | | | | | | | Volteer design provides an EC input to check the battery presence. Enable the required configuration options for hardware battery presence. Battery revive disconnect is also enabled so the EC verifies the disconnect status on the first power on after a battery cut-off. BUG=b:153717444 BRANCH=none TEST=make buildall TEST=Verify Volteer boots with and without battery. Verify "chgstate" command shows correct battery status. TEST=Run 'ectool batterycutoff', verify battery disconnects and Volteer boots successfully after connecting charger. Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: Iab58a176c89a5d7a062e6f513c2c09d91ac7f939 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2166142 Tested-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* driver: Replace BMI160 to BMI in board configChing-Kang Yen2020-04-232-7/+7
| | | | | | | | | | | | | | | | | Replace some macro of BMI160 to BMI version for common function of BMI series. Make board config include the accelgyro_bmi_common.h instead of accel_gyro_bmi160.h. BRANCH=None BUG=b:146144827 TEST=make buildall -j Change-Id: I043ff8a92f15295ead3fa5c1e292319e2b4fa21a Signed-off-by: Ching-Kang Yen <chingkang@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2156525 Reviewed-by: Gwendal Grignou <gwendal@chromium.org>