| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Normalise the name of the tablet mode detection
GPIO so that everyboard does not need to redefine it.
BUG=none
TEST=zmake testall; make buildall
BRANCH=none
Signed-off-by: Andrew McRae <amcrae@google.com>
Change-Id: Ifb458e755d1e00c0cff66a02c78dfccaba2d070c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3397141
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
|int_signal| was used to check interrupt signal to
protect from interrupt coming while processing FIFO.
Instead, use loop until all FIFO samples are processed,
as used in linux kernel sensor fifo routine.
[See for example see st_lsm6dsx_handler_thread() in
driver/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c].
BUG=b:207055975,b:129159505
BRANCH="asurada atlas chameleon dedede drallion endeavour fpmcu grunt
hatch icarus kalista keeby kukui mistral nami nocturne octopus poppy
puff quiche rammus sarien trogdor volteer zork"
TEST=testall, both cros_ec and zephyr.
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Change-Id: I3cfd63c73a7361522ddf42a686dcffdac38d8741
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3328808
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:209528621
TEST=manually
BRANCH=asurada
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: Ia85a861f8895d055dea48463cb2bcdd93e8ea569
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3320081
Reviewed-by: Eric Yilun Lin <yllin@google.com>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because the configuration "icm426xx_base_gyro" miss setting "drv_data".
It will cause icm40608 will pending when gyro set offset value.
BUG=b:193752214
BRANCH=asurada
TEST=manual
1. ectool motionsense offset 1 0 0 0
2. watch ectool motionsense => Check icm40608 sesnor.
Signed-off-by: Michael5 Chen1 <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: I895df941192c86a447c552f3872c9156d61bec80
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3256731
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the use of adc_chip.h where adc.h is also used. In this
case, adc_chip.h is redundant.
BRANCH=none
BUG=b:181271666
TEST=buildall passes
Change-Id: Id7baf9aef949447a4d47934242f9bae97c971262
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3120317
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because rotation matrix will be overwritten by function
"update_rotation_matrix" when AP SW SYNC.
Modify update_rotation_matrix condition to fix it.
BUG=b:193752214
BRANCH=asurada
TEST=Run "watch ectool motionsense lid_angle"
Signed-off-by: Michael5 Chen1 <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: Ia39265ed7acc1f3cb2cbd2fa3971a8dc65362779
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3106633
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gyro sensor add 2nd source icm-40608
BUG=b:193752214
BRANCH=asurada
TEST=manual
Using command "watch ectool motionsense lid_angle" and check angle.
Signed-off-by: Michael5 Chen1 <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: I741d1ca86642d8949af23167b09867b98a3ad79b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3030601
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move this code into a new file so that zephyr can build it as well as
ECOS.
BUG=b:189855648
BRANCH=none
TEST=make BOARD=asurada -j30
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I86e10ff02154d09fb7c967cbe86034689d262e47
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2956087
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Modify PD_MAX_POWER_MW to 45000.
2. Modify PD_MAX_VOLTAGE_MV to 15000.
BUG=b:188373172
BRANCH=asurada
TEST=Manual
Connect 65W adapter and use command "ectool usbpdpower".
Signed-off-by: Michael5 Chen1 <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: I9e2fa7353b057409d2ee8f9c000dc52bb1c79471
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2895411
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
modify max power and max current to support 65w adapter,
SYV682X_HV_ILIM to 5.5A
BUG=b:183174897
BRANCH=asurada
TEST=make buildall PASS
Change-Id: I704ad3a647a2007b808d55928298fd38c34387fe
Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2793851
Reviewed-by: Eric Yilun Lin <yllin@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some Sandisk stickers would enter fault status (down-train
to USB2 or not detected) if Vbus is applied before xhci
initialization.
To fix this, copy usb_port_power_dumb.c to baseboard folder
to implement board-specific enable mechanic.
BUG=b:187149602
TEST=manually
BRANCH=asurada
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I80536b640b4f67a4c17a3da7b193c92ab2f7b3eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2909972
Tested-by: Ting Shen <phoenixshen@chromium.org>
Auto-Submit: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@google.com>
Commit-Queue: Eric Yilun Lin <yllin@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify HS detector threshold setting (0x3C) to 0x60 for USB-C C1 port
signal quality.
BUG=b:177980418
BRANCH=asurada
TEST=manual
Run command "ectool i2cread 8 4 0x20 0x3c" to check register value.
Signed-off-by: Michael5 Chen1 <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: I97b6bb16e7c5298ff42e35d936e0f9e60ec3b730
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2845564
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=make buildall
BRANCH=asurada
Change-Id: Ice2b4f5bf95fe88bd075fda892731ba0d6c96d0e
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2853086
Tested-by: Eric Yilun Lin <yllin@google.com>
Auto-Submit: Eric Yilun Lin <yllin@google.com>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=make buildall -j
BRANCH=asurada
Change-Id: I03bc55c3d55927866355b457ec4b17f75d32f60f
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2852359
Tested-by: Eric Yilun Lin <yllin@google.com>
Auto-Submit: Eric Yilun Lin <yllin@google.com>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, all boards using the LED On/Off module have battery LEDs.
However, if we'd like to expand support to Chromeboxes then the battery
LED must become optional.
BRANCH=None
BUG=b:185508707
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ieae098829ebe6c8b103f23d5abdbf70e7bcbdf2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2832692
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the LED on/off module towards using a more flexible LED support
approach. Define a weak power LED table and setter for boards to
override when needed. Note that during run-time these functions will
not get called since led_auto_control_is_enabled() will return false for
nonexistent LEDs.
This consumes an average of 165 additional bytes of flash space on
boards which do not use a power LED.
BRANCH=None
BUG=b:185508707
TEST=make -j buildall, load on guybrush (battery LED only) and confirm
no errors are seen. Load on Boten (both LEDs) and confirm behavior
appears normal
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Iaa1e22a7f5d8be39eb8792ee13d358087d7f7482
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2832691
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The power sequence status is stable now.
BUG=none
TEST=make buildall
BRANCH=asurada
Change-Id: Ibdf644336f1aaefd185d983cd36efde67614d951
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2835257
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To make the naming clearer that's pointed to C0 port.
BUG=none
TEST=make buildall
BRANCH=asurada
Change-Id: If9cb520114b893af995aa67a2281b8e7302c2771
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2814729
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove CONFIG_SYSTEM_UNLOCKED for asurada, hayato and spherion to avoid
unnecessary sysjump when flashing EC with write protect enabled.
BUG=b:160229421, b:185433646
TEST=emerge-asurada chromeos-ec
TEST=firmware_WriteProtectFunc passed on Hayato
BRANCH=asurada
Change-Id: I76c9f381a1dd3b4f0e4e3e990ceb7a8c3c0e4128
Signed-off-by: Yu-Ping Wu <yupingso@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2834754
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
config adc temp senosr enable, re-config KB_BL_EN
to gpioG3 from GPIOI7
BUG=b:184885443
BRANCH=asurada
TEST=make buildall PASS
Change-Id: Ia0d12724ca33295f2817ee2a9a32dbff09aba87a
Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2816939
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Dual VBUS ADC are supported since board revision >= 4.
This is to address the inaccurate VBUS present detection on SYV682x.
SYV682X assumes can only recognize VBUS equals Vsafe5V or Vsafe0V.
If the VBUS is not falling at the both range, it assume the VBUS >
vSafe5V and thus VBUS is presented. But if the votlage is fallint
between Vsafe5V and Vsafe0V, it still thinks VBUS presented, and this
is a false positive.
BUG=b:181203590
TEST=ensure VBUS ADC reports reasonable value
BRANCH=asurada
Change-Id: I1b57395216f1d6788bcd09306b503bdd3b49ddc8
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2793853
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL enables SYV682C for hayato revision > 2.
BUG=b:160548079
TEST=1. hayato meets tVconnOff
2. hayato meets tVBUSDischarge
BRANCH=asurada
Change-Id: I424b7785ba877b7cfdc413b8b253457a759b98d3
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2738507
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable USM to cancel the charging noise.
BUG=b:175168848
TEST=EN_5V_USM=1 in S0, =0 in S3.
BRANCH=asurada
Change-Id: I7cdfafee8b826c8cb165e3aa3d487afdf6625ff9
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2793850
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use board-specific override files when generating VIFs for boards.
BUG=b:172276715
TEST=make buildall
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: I197365018ceb8197c22d631cebf4cbce1c0119f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2785506
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch switches implementation of input voltage reduction to generic
one. It removes reduce_input_voltage_when_full() function from board
code and defines CONFIG_BATT_FULL_CHIPSET_OFF_INPUT_LIMIT_MV
with appropriate voltage.
Affected boards:
- Ampton
- Asurada
- Cherry
- Dratini
- Jinlon
- Liara
- Nocturne
BUG=b:182546058
BRANCH=none
TEST=Compile firmware for affected boards.
TEST=Flash EC ToT on one of affected boards. Charge battery to full.
Shutdown board and check if voltage is reduced. Power on board,
check if previous voltage is restored.
Signed-off-by: Patryk Duda <pdk@semihalf.com>
Change-Id: I8f285e75c11f84f4711d5e6a4008174b6fb639cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2773219
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move asurada baseboard PWM channels definition to board control.
Config gpio keyboard backlight en pin, and enable/disable
in power on/off sequence
BUG=b:181799718
BRANCH=none
TEST=make buildall
TEST=run 'kblight' EC console command to verify keyboard backight
TEST=run 'ectool verify pwmsetkblight' to verify keyboard backlight
Change-Id: If7afbd4f21dd6b0500525d08ec7786071c3523c1
Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2738494
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Yilin Yang (kerker) <kerker@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(This relands CL:2470378 with an additional system unlocked check,
original message below)
The data in b:162467514#comment3 shows that 9V input has lowest
power consumption in S5.
This CL forces PD to select 9V when S5 with full battery.
BUG=b:162467514
TEST=Verify dut chooses 9V when in S5 and battery full, and
chooses 15V in other states.
TEST=pass firmware_PDVbusRequest.shutdown
BRANCH=none
Change-Id: I8de113ccd40fc76aee2e4e4026ef213ec542cf3a
Signed-off-by: Ting Shen <phoenixshen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2705453
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
guidelines:
1. sensors are in the board, since this may changes most of the time
2. PPC/Charger/BC12/TCPC/PD are in the baseboard, this is unlikely
changing
3. sub-board detection is in the baseboard
4. power signals, power sequence are in the baseboard
5. ADC/PWM this might change, but we keep them in the baseboard for now
6. it5205_sbu is not currently used for now, move it to baseboard
7. battery, led are kept in the board
BUG=b:178439840
TEST=boot hayato to OS
BRANCH=none
Change-Id: I21bf5d1f7901a10c3538ad5646362f2b402652af
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2675328
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=`mux config:0, port:0, rv:36` disappear
BRANCH=main
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I514601b5c6e82805b861b9ca345052a76fcebb74
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2662513
Tested-by: Ting Shen <phoenixshen@chromium.org>
Auto-Submit: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename variables in MT6360 driver to match current i2c naming
conventions.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ifc7cae2f7cb012e4078c6a348219b51199811cc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2649356
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Almost every relevant board copy-pastes 5000 us. Make that the default
and get rid of the redundant definitions. This is the approximate result
of this command:
find . -type f -name *.h | xargs sed -i -E \
'/#define CONFIG_USBC_VCONN_SWAP_DELAY_US[[:space:]]+5000[[:space:]]/d'
BUG=b:144165680
TEST=make buildall
BRANCH=none
Change-Id: Ife86f9752971abcd7ab5ad5a5e607eb2ccbde2ba
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2628132
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace PD_VCONN_SWAP_DELAY with CONFIG_USBC_VCONN_SWAP_DELAY_US. This
is the approximate result of the following command, run from
platform/ec:
find . -type f -\( -name '*.c' -o -name '*.h' -\) | \
xargs sed -iE 's/PD_VCONN_SWAP_DELAY/CONFIG_USBC_VCONN_SWAP_DELAY/g'
Fix some latent formatting errors in usb_pd_protocol.c, because they
were preventing pre-upload hooks from passing.
BUG=b:144165680
TEST=make buildall
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: Icaf3b309c08fdcd162e960cf5dc88185016b5d2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2628131
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If we don't lower the priority, it may get the wrong board id. Then it
won't update the rotation matrix.
1. priority 1: update board id value
2. priority 2: update rotation matrix
BUG=b:177384512
TEST=DUT can pass all sensor related tests in factory toolkit
BRANCH=none
Signed-off-by: kerker <kerker@chromium.org>
Change-Id: Ie11f084375de6ec9f30c093051d48773931c32e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2626804
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Yilin Yang (kerker) <kerker@chromium.org>
Tested-by: Yilin Yang (kerker) <kerker@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The issue is that, when a port sink for 5V, and triggers FRS, and
the port would fail to source and the PPC is in a weird state
and unable to recover until a hard reset.
This CL disable the feature temporarily until we have a H/W fix.
BUG=b:176876036
TEST=make BOARD=asurada
BRANCH=none
Change-Id: Ieed93c5c1fc4acfbe2f9ac135cf90ab459ae8cdd
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2612241
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL increase the i2c freq to 400Khz to finish the i2c task, and
let it81202 enter the doze state faster.
BUG=b:173490375
TEST=ensure S3 power consumption drop to 5mw
BRANCH=none
Change-Id: Iee12f61075214b7f585a9b7d2c2ad6f64666d4f2
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2607967
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After HW fix implemented, we can finally enable lid accel interrupt.
This CL changes the hard-coded force mode mask to a runtime
computed value, such that polling mode still works on rev 1 boards,
and enable interrupt mode on rev 2+ boards.
BUG=b:157974230
TEST=Manually,
1) On rev2 board, verify lis2dw12_interrupt triggered.
2) On rev1 board, verify lid accel still works.
BRANCH=main
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: Ic64baed39db785c13e30a335c68d887dd3d3707d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2610744
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:174539768
BRANCH=none
TEST=manual
1. Check power LED under S0/S3/S5.
2. Check battery LED under full/low/error.
3. Check ectool led power command.
4. Check ectool led battery command.
Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: I67d6a07f7e1b2247291d9f34735d7bf7fbc6be72
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2607219
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change enables 1.8v selection for signals which are 1.8v to
prevent leakage in chip.
This change also change NC pins of ADC to output low due to they
don't have pull-down capability.
BUG=b:173490375
BRANCH=none
TEST=save ~3.5mw on asurada.
Signed-off-by: Dino Li <Dino.Li@ite.com.tw>
Change-Id: Ib31bd78beeda735ba49e3582b0c0dbb658c8c209
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2606180
Reviewed-by: Ayo Wu <ayowu@google.com>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To report the reset reasons to AP.
BUG=b:174443398
TEST=trigger AP WDT, and on next boot
> ectool --name=cros_ec uptimeinfo
EC uptime: 152.474 seconds
AP resets since EC boot: 2
Most recent AP reset causes:
41.587: reset: console command
127.186: reset: AP watchdog
EC reset flags at last EC boot: reset-pin | power-on
BRANCH=none
Change-Id: I124024b7e00caac9275fb90e9b1f986921e5f86b
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2607204
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Saves space and, in particular, makes division by zero more
efficient.
BRANCH=none
BUG=b:173969773
TEST=build and boot asurada
Change-Id: Ieb01c9c72987e7d05f6942fb95b71d53c25cc344
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2605038
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify base rotation matrix depend on schematic.
BUG=b:176137993
BRANCH=none
TEST=manual
1. Using "ectool motionsense" check x/y/z value.
2. Using "ectool motionsense lid_angle" check angle.
Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: Ib21b6a5b10d247047ef65b78e9c5ea3d919963d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2604801
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:173490375
BRANCH=none
TEST=save ~2mw on asurada.
Signed-off-by: Dino Li <Dino.Li@ite.com.tw>
Change-Id: I839e4b19b1c82583ae1c60ea2d6a463806bf4937
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2545917
Reviewed-by: Ayo Wu <ayowu@google.com>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL changes config option of EC's VCC connection to
CONFIG_IT83XX_VCC_1P8V for asurada baseboard.
BUG=b:173490375
BRANCH=none
TEST=boot to kernel on asurada. save ~1.5mw on rev1 board.
Signed-off-by: Dino Li <Dino.Li@ite.com.tw>
Change-Id: I208ef4224121f9f947d5459de15d50b40dffe7e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2600815
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the DPM will be handling source-out decisions for TCPMv2,
remove references to its old configuration options from TCPMv2 boards in
order to avoid any confusion as to what code is running now. Also
remove the charge manager notifications of sink attach/detach since the
policy is being centralized into the DPM.
Note that the previous configuration options only ever allocated one 3.0
A port, and so the default number of 3.0 A ports has been set to 1.
BRANCH=None
BUG=b:168862110,b:141690755
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ie452e3da32b04226503539daa67b6b9f4a58aa58
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2597431
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:173490375
BRANCH=none
TEST=On asurada, save ~7mw in S3 state.
Signed-off-by: Dino Li <Dino.Li@ite.com.tw>
Change-Id: I2f3961f7fddbaf87cb454c57f6ad7b6b3438d2f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2599639
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To correctly capture the signal.
BUG=b:174109011
TEST=ensure EC receiving AP_EC_WATCHDOG_L signal when reboot in AP
BRANCH=main
Change-Id: Ibb96149ae8dc4c5c48f1deeb3508b0c50ddea09a
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2596563
Reviewed-by: Dino Li <Dino.Li@ite.com.tw>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is an option in the task_set_event function which force
the calling task to wait for an event. However, the option is never
used thus remove it.
This also will help in the Zephyr migration process.
BUG=b:172360521
BRANCH=none
TEST=make buildall
Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com>
Change-Id: Ic152fd3d6862d487bcc0024c48d136556c0b81bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2521599
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 92f55b092e0a8b00496db89e3d129932aae0525a.
Reason for revert: This breaks "pd X dev Y" console command
Original change's description:
> asurada: set input voltage to 9V when S5 with full battery
>
> The data in b:162467514#comment3 shows that 9V input has lowest
> power consumption in S5.
>
> This CL forces PD to select 9V when S5 with full battery.
>
> BUG=b:162467514
> TEST=Verify dut chooses 9V when in S5 and battery full, and
> chooses 15V in other states.
> BRANCH=none
>
> Signed-off-by: Ting Shen <phoenixshen@google.com>
> Change-Id: I36106f773ec4648bd0d9d5a75d75c8cbc7ee5c43
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2470378
> Commit-Queue: Ting Shen <phoenixshen@chromium.org>
> Tested-by: Ting Shen <phoenixshen@chromium.org>
> Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Bug: b:162467514
Change-Id: I6941ccc4827bc9ab8a8eb167c5d88ebaf8686694
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2582434
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
usleep is unstable on asurada, we use udelay instead to prevent from
the pulse width over the spec (1ms).
BUG=b:171172053
TEST=ensure the pulse width is reliable.
BRANCH=none
Change-Id: I8b349b6d09dca3a116e6fc9a2552faa041664674
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2539262
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:169532537
TEST=amon; ensure the report current is accurate comapres to the
power meter
BRANCH=none
Change-Id: I43f98db84f362f0331b128475c9cea955c18f163
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2569082
Reviewed-by: Tzung-Bi Shih <tzungbi@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|