summaryrefslogtreecommitdiff
path: root/board/berknip
Commit message (Collapse)AuthorAgeFilesLines
* keyboard_scan: Add consts needed for factory test to headerRob Barnes2021-07-281-5/+0
| | | | | | | | | | | | | | | | | Add keyboard_factory_scan_pins and keyboard_factory_scan_pins_used to keyboard_scan header so they do not need to be declared as extern by individual boards. These constants need to be defined if CONFIG_KEYBOARD_FACTORY_TEST is enabled. BUG=None TEST=Build BRANCH=None Change-Id: I1a100f626b3cea251ca72703d17b2d27db0f8f28 Signed-off-by: Rob Barnes <robbarnes@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3053101 Commit-Queue: Diana Z <dzigterman@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* berknip: not read thermistor in S5Zick Wei2021-07-201-0/+10
| | | | | | | | | | | | | | | | The thermistor: TEMP_SENSOR_SOC and TEMP_SENSOR_5V_REGULATOR are powerd by S5 power rail, EC will get abnormal temperature: 100C when DUT get from G3 to S5, we ignore thermistor temperature in S5. BUG=none BRANCH=zork TEST=verify there's no shutdown/prochot message during EC power on. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Id686375aa50cbbe01384b629b1098a574b3c35fa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3015909 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* thermisor: move header to include dirDawid Niedzwiecki2021-04-221-1/+1
| | | | | | | | | | | | | | | | Move the "thermistor.h" header to the include/driver/temp_sensor directory. It is used by the Zephyr shim, so the change is useful to include the header. BUG=b:180403276 BRANCH=none TEST=make buildall Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: I0e83df97e50a3b324440b65ddb900ddf135f2439 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2843323 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* genvif: Use VIF overrides by defaultAbe Levkoy2021-03-301-0/+3
| | | | | | | | | | | | | | Use board-specific override files when generating VIFs for boards. BUG=b:172276715 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I197365018ceb8197c22d631cebf4cbce1c0119f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2785506 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* board/zork: Re-order includes so that enum definition comes before useTom Hughes2021-03-161-1/+1
| | | | | | | | | | | | | C++ doesn't allow forward enum references. BRANCH=none BUG=b:144959033 TEST=make buildall Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I7e1f8890005e05136eeb4e5084505988dbbb15b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2740566 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* zork: use MKBP GPIO & host event for wake on DPPeter Marheine2021-01-051-2/+0
| | | | | | | | | | | | | | | | | | | | | | | GPIO-only MKBP only works when the AP is awake; we need to use GPIO_AND_HOST_EVENT in order to support waking the AP in response to MKBP events; in particular DP_ALT_MODE_ENTERED. We also configure the MKBP wakeup mask so powerd can apply configuration at runtime per chromeos-config: if no mask is configured then the hostcmd to set the wakeup mask is not included in the firmware. Wake on MKBP (and thus wake on DP) also requires AP firmware support. https://review.coreboot.org/c/coreboot/+/48844 implements it for Zork. BUG=b:174121852 TEST=Generating DP event via EC console on morphius with patched AP firmware successfully wakes system from S3. BRANCH=zork Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: Ifb193399259674da17694aac5213bfd1f189ee59 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2607026 Reviewed-by: Edward Hill <ecgh@chromium.org>
* berknip: remove unuse thermal settingZick Wei2020-12-161-2/+0
| | | | | | | | | | | | | | | berknip not use cpu temperature to control fan, so we remove the setting. BUG=none BRANCH=zork TEST=make BOARD=berknip Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I9fbc9ec1116dcd480018c1e348ed124adcfa64f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2594754 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* berknip: remove retimer HPD controlZick Wei2020-12-111-14/+0
| | | | | | | | | | | | | | | | | | berknip dali sku will control HPD to mst when detect USB-C device has DP function, but when EC get attention command from device, HPD will not set high or low as attention required, so mst hub will not update display information when attach/de-attach display device from hub/dock/dongle. BUG=b:175163382 BRANCH=zork TEST=verify OS will update display information when remove display on hub/dock/dongle side. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I468692be11b41e914c66f6101f62a9c2a8a46262 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2581124 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* berknip: update tusb544 eq settingZick Wei2020-11-182-0/+62
| | | | | | | | | | | | | | This patch update tusb544 eq setting for berknip. BUG=b:170708727, b:170708972 BRANCH=zork TEST=verify USB type C 3.0 RX , DP eq can pass, make buildall. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Ief018e02090f5bc409a57a93da86f9ff095773aa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2467602 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* berknip: update led pulsing durationZick Wei2020-11-181-4/+8
| | | | | | | | | | | | | | | | | This path update suspend led pulsing duration : 1s on, 6s off for saving power. BUG=b:173072337 BRANCH=zork TEST=verify suspend led behavior as intended. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I7e4f937dee00e0e572c64bf6a6d7286f0be15a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2539711 Tested-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* berknip: update thermal settingZick Wei2020-10-291-3/+3
| | | | | | | | | | | | | | This patch update thermal setting. BUG=b:161470415 BRANCH=zork TEST=verify thermal setting as thermal team request. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Ib913b5959e15b6a7ea19fbab587a9a34ab6bb26e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2507189 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* berknip: use HPD to disable pi3hdx1204 in S0Zick Wei2020-10-153-4/+33
| | | | | | | | | | | | | | This patch use HPD HDMI HPD signal to enable/disable HDMI retimer pi3hdx1204 in S0 to save power. BUG=none BRANCH=zork TEST=verify HDMI display function normally Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I371e5a2ceb1474a038e92b3ff0122c327f41a39f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2467601 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* berknip: Remove sensorsEdward Hill2020-09-294-110/+2
| | | | | | | | | | | | | | Remove motion sense (gyro + accel) drivers, since HW has none. BUG=b:166183179 BRANCH=zork TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I954bf491dd7cecf8a76d28b02ea100a0decb12d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2437191 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* berknip: update mux hpd signalZick Wei2020-09-261-4/+4
| | | | | | | | | | | | | | This CL update USB_C1_HPD_IN_DB use gpio_or_ioex_set_level(). BUG=none BRANCH=zork TEST=verify EC not panic on board version>=3. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Ifc01005d0f974f1ab3f5f095156b516e0cba9ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2428355 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* zork: Update PS8802/PS8818 IN_HPD to match HW changesEdward Hill2020-09-231-5/+8
| | | | | | | | | | | | | | | | Add a global variable board_usbc1_retimer_inhpd that boards can set to IOEX_USB_C1_HPD_IN_DB or GPIO_USB_C1_HPD_IN_DB_V1 depending on board version, that is then used by board_ps8802/ps881_mux_set to enable/disable IN_HPD on the DB retimer. BUG=b:168884674 BRANCH=zork TEST=morphius dali + picasso USB-C1 display works Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Ifca733ce05a72cc095463b2b9365857232784d34 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2426959 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* zork: move HDMI retimer setting to variantZick Wei2020-09-221-0/+7
| | | | | | | | | | | | | | This CL move HDMI retimer(pi3hdx1204) setting to variant. BUG=none BRANCH=zork TEST=make buildall Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I5b50058c44ccb9fd5d9403939d5f4ea9a9670b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2421391 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* berknip: add mst function supportZick Wei2020-09-053-7/+49
| | | | | | | | | | | | | | | This patch add mst function support for board version >=3 dali sku. BUG=b:159304034 BRANCH=zork TEST=verify on rework dali DUT mst hub can work Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I09172b9355af8e50e636c84b564dd70bc86b1155 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2386693 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* berknip: update thermal tableZick Wei2020-09-021-17/+30
| | | | | | | | | | | | | | This patch update fan curve and thermal protect point. BUG=b:161470415 BRANCH=zork TEST=verify fan curve and thermal protect behavior as expected Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I842494acc62446be81b6df0f857c0e65e65380ae Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2389720 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* berknip: not read thermistor in G3Zick Wei2020-09-021-0/+4
| | | | | | | | | | | | | | | | This patch disable read thermistor:TEMP_SENSOR_5V_REGULATOR when DUT in G3, the thermistor is powered by PP3300_A, which is power off in G3. BUG=none BRANCH=zork TEST=verify EC not read TEMP_SENSOR_5V_REGULATOR in G3 Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Ifdbe81c963455e941ac8e907650f21a296da39ac Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2389721 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* zork: Re-Enable CONFIG_CHARGE_RAMP_SWEdward Hill2020-09-021-0/+1
| | | | | | | | | | | | | | | We would prefer to use CONFIG_CHARGE_RAMP_HW to enable legacy BC1.2 charging but that feature of ISL9241 is broken (b/160287056) so we have to use CONFIG_CHARGE_RAMP_SW instead. BUG=b:163864475,b:167257846 BRANCH=none TEST=ramp up to 1.5A from legacy charger Signed-off-by: Denis Brockus <dbrockus@chromium.org> Change-Id: I636e2bd6db57c11ce6da24cc2417b35bb59c6d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2388081 Reviewed-by: Edward Hill <ecgh@chromium.org>
* Revert "zork: Enable CONFIG_CHARGE_RAMP_SW"Denis Brockus2020-08-311-1/+0
| | | | | | | | | | | | | | | | | This reverts commit 8a768a06bc876f83427691d27b4e572418406875. Reason for revert: The code as it stands breaks PD charging, so no battery charging is functional when this is landed. BUG=b:163864475,b:167257846 BRANCH=none TEST=verify Zork PD charging works Change-Id: I2c8b006e6add2e328840647367068449be28f7a6 Signed-off-by: Denis Brockus <dbrockus@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2386024 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* zork: Enable CONFIG_CHARGE_RAMP_SWEdward Hill2020-08-301-0/+1
| | | | | | | | | | | | | | We would prefer to use CONFIG_CHARGE_RAMP_HW to enable legacy BC1.2 charging but that feature of ISL9241 is broken (b/160287056) so we have to use CONFIG_CHARGE_RAMP_SW instead. BUG=b:163864475 BRANCH=zork TEST=ramp up to 1.5A from legacy charger Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Iec0a4b82f42fd388d738362ce9a8de4d31c61054 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2382635
* berknip: fix HDMI_DATA_EN_DB on daliZick Wei2020-08-281-2/+4
| | | | | | | | | | | | | | | | | This patch fix HDMI_DATA_EN_DB not power on dali sku, which will cause MST hub not powered. BUG=b:152841287 BRANCH=zork TEST=verify MST hub work in S0 on dali sku. verify HDMI work in S0 on picasso sku. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I09177fc04d8255f84c4cd193404f5285d89979ff Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2379366 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* zork: Set HDMI DATA_EN with POWER_ENEdward Hill2020-08-262-1/+3
| | | | | | | | | | | | | | | Avoid setting IOEX_HDMI_DATA_EN_DB high when power is off. This prevents leakage in S3 and S5. BUG=b:158266701 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I9f1c02b3631887661905be1e65be5d4d8b9f8e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2375803 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* Berknip: Fix HDMI retimer suspend / resumeEdward Hill2020-08-221-9/+19
| | | | | | | | | | | | BUG=b:165191082 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: If0619e61faa36e67e4e73c1cc59b296f6a039075 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2364115 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* berknip: support V0 charger on board version 2Zick Wei2020-08-111-1/+1
| | | | | | | | | | | | | BUG=b:152841287 BRANCH=none TEST=verify charger can work on berknip board version 2 Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Ia3c4e8fae09ba20df583f5d291bc422175705888 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2348228 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* trembyle: Use board_version for I2C_PORT_CHARGER_V0Edward Hill2020-08-111-16/+24
| | | | | | | | | | | | | | Change to use CBI board_version for I2C_PORT_CHARGER_V0 instead of probing I2C. BUG=b:155214765 BRANCH=none TEST=boot to OS Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Id3e9d874439277af4d1c88acd6ab40a6bbea73ee Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2343742 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* zork: move board_get_temp to variantZick Wei2020-08-031-1/+1
| | | | | | | | | | | | | | | This patch rename thermal sensor name by placement for morphius, and move board_get_temp from baseboard to variant BUG=b:162325433 BRANCH=none TEST=verify that thermal sensor name change in EC console Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I46dfe5c8ebef29ed6ee7fdf342cfad9d39fe6ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2325496 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* berknip: add thermal table supportZick Wei2020-07-232-16/+92
| | | | | | | | | | | | | This patch add thermal control support for berknip. BUG=b:161470415 BRANCH=none TEST=verify fan rpm follow fan curve setting. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I5e67a43def0df046af860298a788aa0b3de2d1b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2306892 Reviewed-by: Edward Hill <ecgh@chromium.org>
* berknip: Allow MST hub to control HPD for OPT3 DBZick Wei2020-07-212-3/+6
| | | | | | | | | | | | | | Use an UNIMPLEMENTED GPIO for PORT_TO_HPD so that EC does not drive HPD for OPT3 DB. BUG=b:161105355 BRANCH=none TEST=HDMI/DP works on OPT3 DB. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I4f6ca8e9a74f18489c6ca20d2f10e9a6840719e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2306891 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* Zork: Handle USB_Cx_SBU_FAULT_ODLEdward Hill2020-07-121-5/+2
| | | | | | | | | | | | | | Connect up USB_Cx_SBU_FAULT_ODL to pd_handle_overcurrent(). BUG=b:138600586 b:157058003 BRANCH=none TEST=USB-C sink and source still works, forcing USB_Cx_SBU_FAULT_ODL low is reported as fault. Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I59ae65eed169fc5e18f72539a68017bb73c7d93e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2293102 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* Zork: Remove CONFIG_SYSTEM_UNLOCKEDEdward Hill2020-07-091-7/+0
| | | | | | | | | | | | | | Remove CONFIG_SYSTEM_UNLOCKED and CONFIG_I2C_DEBUG from all Zork boards. BUG=b:138601010 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I846335e8402b719bbbf5711aa805b727a0902919 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2288153 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* woomax: Update USB-A and FW_CONFIGEdward Hill2020-07-032-0/+10
| | | | | | | | | | | | | Remove USB-A1 and correct FW_CONFIG. BUG=b:160293750 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I6e415c3dac85905af812ac5ce26ad3bbf4fcf869 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2277212 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* berknip/morphius: update gpio S0_PWROK_ODZick Wei2020-06-253-2/+51
| | | | | | | | | | | | | | | This patch update S0_PWROK_OD for schematic change. BUG=b:150278507, b:152841287 BRANCH=none TEST=make buildall, verify EC code can power on rework MB. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Iaf8f2458c2dfe49f40eada8dced1febe2c4c4687 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2255826 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org> Tested-by: Edward Hill <ecgh@chromium.org>
* berknip: add HDMI_POWER_EN_DB to NCT3807Zick Wei2020-06-252-0/+19
| | | | | | | | | | | | | | The HDMI_POWER_EN_DB signal is set to power HDMI power rail. BUG=b:152841287 BRANCH=none TEST=make buildall Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I3b5ba82a670bd4308fa5fda36b81697000d526bb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2260172 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* berknip: remove mst/hdmi hpd functionZick Wei2020-06-252-56/+1
| | | | | | | | | | | | | | This CL remove mst/hdmi hpd function for schematic change. BUG=b:152841287 BRANCH=none TEST=make buildall Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Ifffd43ca682e5bdec103f87b52ed38934640fc15 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2260092 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* Zork: Change 3AXIS_INT_L to GPIO_PULL_DOWNEdward Hill2020-06-191-1/+1
| | | | | | | | | | | | | | | | 3AXIS_INT_L is unused (we use polling not interrupt for reading lid accel), and defaults to low, so change to GPIO_PULL_DOWN for a small power saving. BUG=b:157243373 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I7f5f3af692d0958237f9876ac9ad65fdd3696d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2253059 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* berknip: enable keyboard factory scanningZick Wei2020-06-162-0/+25
| | | | | | | | | | | | | | | This patch add for factory keyboard connector test. BUG=none BRANCH=none TEST=short keyboard pins and make sure "ectool kbfactorytest" works. Change-Id: I7c93322d6644163a58e2ec0890cd12b9d0c186b8 Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2246012 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* berknip: add 5V regulator temperature sensorDevin Lu2020-06-153-1/+51
| | | | | | | | | | | | | | | Add a thermistor which near to 5V regulator. BUG=b:157711232 BRANCH=none TEST=Verified console "temps" can read temperature. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: I0020fc74b9b4b3f16dae7a1263e793ec2783b665 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2234047 Commit-Queue: Edward Hill <ecgh@chromium.org> Tested-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org>
* zork/baseboard: move temperature sensors definition to board variantDevin Lu2020-06-152-0/+57
| | | | | | | | | | | | | | | | | There are some differences with temperature sensors for each zork variant. This patch move temperature sensors definition to board variant. BUG=b:157711232 BRANCH=none TEST=Verified console "temps" can read temperature. Build all zork board variant. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: Ib109ea5adc98e6b6825f8c91db19911dc682a52e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2227787 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org> Tested-by: Edward Hill <ecgh@chromium.org>
* Ezkinil: modify some gpio definitionSue2020-06-052-0/+19
| | | | | | | | | | | | | | | | | | | rename GPIO F4: DP1_HPD -> EC_DP1_HPD remove IOEX 10 HDMI_CONN_HPD_3V3_DB add GPIO 75: DP1_HPD_EC_IN move hdmi_hpd_interrupt and hdmi_hpd_handler from baseboard to board BUG=b:152512560, b:153397667, b:155797182 BRANCH=none TEST=make buildall -j Change-Id: I5cdbb42a8284c85104dbbbe7b3d557d51a11a074 Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2224693 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org> Tested-by: Edward Hill <ecgh@chromium.org>
* berknip: add Cosmx battery configurationZick Wei2020-06-052-0/+29
| | | | | | | | | | | BUG=b:157950071 BRANCH=none TEST=make buildall Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Icb01629d04be5f2b31a28d906d14095606e7b78d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2229899 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* Zork: Switch PS8743 from IOEX_USB_C1_DATA_EN to I2CEdward Hill2020-06-031-21/+4
| | | | | | | | | | | | | | | | | Align all Zork devices on using I2C control of PS8743 mux mode, and stop using IOEX_USB_C1_DATA_EN signal/pin. This matches what we were already doing for Dalboz, and gives power savings in both S0 and S3 when nothing is plugged in and mux is set to none. BUG=b:157951317 BRANCH=none TEST=external display and i2ctrace on ezkinil Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Id1c8b172a99bb25bed8b57e90686d933447432f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2227589 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* berknip: add SMP battery configurationZick Wei2020-06-032-19/+20
| | | | | | | | | | | | | | BUG=b:157950071 BRANCH=none TEST=test berknip can power on with battery only. Battery can charge, discharge, cut-off command work normally. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Ib8cbf7badca81103c7707dbb24f4f43f5d09d351 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2206938 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* berknip: add pi3usb221 driverZick Wei2020-06-032-0/+33
| | | | | | | | | | | | | | | | Add pi3usb221 support on berknip, this chip use as SBU mux of usb c0 port. BUG=b:148757952 BRANCH=none TEST=verify USB type C monitor can work on both side cable on USBC0 port. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: Ie800682fe12db3d2df1eb2da40fe9c39c996a580 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2216138 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* berknip: implement LED behaviorZick Wei2020-05-283-41/+178
| | | | | | | | | | | | | | | | | | | | | | | | | | berknip have two charging leds on left side and right side. each side have two colors amber and white. The led behavior define as following: Charging led: led on with charging port active, other port is off. Charging: Amber. Discharging: Off. Battery Error: Blinking white (0.4 sec on, 0.4 sec off) Fuel < 10%: Blinking white on right side port (1 sec on, 1 sec off) Force idle for factory: Blinking amber (1 sec on, 1 sec off) System suspend with non-charging state: Blinking both side LED white (1 sec on, 1 sec off) BUG=none BRANCH=none TEST=make sure led behavior intended. make sure ectool led left white/amber/off/auto work correctly. make sure ectool led right white/amber/off/auto work correctly. Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Change-Id: I84937e40c893b5db4e5c1e2999da9232c989adb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2212005 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* berknip: add redriver TUSB544 and PS8743Zick Wei2020-05-212-157/+104
| | | | | | | | | | | | | | | | berknip use TUSB544 on opt1 DB and PS8743 on opt3 DB. BUG=b:148757952 BRANCH=none TEST=verify on berknip opt1 and opt3 USB C1 port can work. Change-Id: Ic065c7bd9c575cd42e24512ff02548e8e07b1011 Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2183575 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org>
* PD: Remove unnecessary PDCMD taskDiana Z2020-05-201-1/+0
| | | | | | | | | | | | | | | | | | | The PDCMD task is only pulling interrupts from the TCPCs on most boards, which is unnecessary since the PD_INT tasks handle this job now. Remove it from any boards using the PD_INT command which are not using the older CONFIG_HOSTCMD_PD functionality (ex. samus, oak). Located boards using: find -name "ec.tasklist" | xargs grep -l PD_INT | xargs grep PDCMD BRANCH=None BUG=b:154959596 TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: I29be8ab1d7a2616603fb55236aed4329ed8654f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2208221 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* Zork: Use FW_CONFIG for IOEX_HDMI_CONN_HPD_3V3_DB.Edward Hill2020-05-122-0/+12
| | | | | | | | | | | | | | | | Use FW_CONFIG to only enable IOEX_HDMI_CONN_HPD_3V3_DB interrupt when appropriate. BUG=b:156046102 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Ib12943e6ebbbd9af9c46ac548921aea5eb96f504 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2195187 Reviewed-by: David Huang <david.huang@quanta.corp-partner.google.com> Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* Zork: Use FW_CONFIG for IOEX_MST_HPD_OUT.Edward Hill2020-05-122-0/+43
| | | | | | | | | | | | | | | | | Move mst_hpd_interrupt() out of variant_trembyle.c into individual boards. Use FW_CONFIG to only enable IOEX_MST_HPD_OUT interrupt when appropriate. BUG=b:156046102 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I3f188088254208f01aea2094b7f2b57590b0d91b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2195186 Reviewed-by: David Huang <david.huang@quanta.corp-partner.google.com> Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>