| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the interest of making long-term branch maintenance incur as little
technical debt on us as possible, we should not maintain any files on
the branch we are not actually using.
This has the added effect of making it extremely clear when merging CLs
from the main branch when changes have the possibility to affect us.
The follow-on CL adds a convenience script to actually pull updates from
the main branch and generate a CL for the update.
BUG=b:204206272
BRANCH=ish
TEST=make BOARD=arcada_ish && make BOARD=drallion_ish
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I17e4694c38219b5a0823e0a3e55a28d1348f4b18
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3262038
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable CONFIG_ASSERT_CCD_MODE_ON_DTS_CONNECT on all dedede boards. This
will assert GPIO_CCD_MODE_ODL when a debug device is connected to a CCD
port. GPIO_CCD_MODE_ODL must be configured as an open drain so EC and
Cr50 don't drive fight.
BUG=b:190189242
TEST=Build dedede
BRANCH=None
Change-Id: I2d71312967f2d4a693ac9753279f49478e8c092c
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2976759
Reviewed-by: Diana Z <dzigterman@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable CONFIG_USB_PORT_POWER_DUMB for enabling/disabling charging from
USB-A ports. This change also enables disables the USB1 low power limit
by default
BUG=b:182753927
BRANCH=dedede
TEST=make -j BOARD=boten
TEST=Run "test_that -b dedede firmware_ECUsbPorts"
Signed-off-by: amber.chen <amber.chen@lcfc.corp-partner.google.com>
Change-Id: I0d9721469cdd9744f24c36da3cf6d9185e46e630
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2852365
Reviewed-by: Diana Z <dzigterman@chromium.org>
Reviewed-by: Henry Sun <henrysun@google.com>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
From Boten HW circuit, some GPIO in EC side is NC or unused.
So, we can configure it as NC to optimize EC power consumption.
1. HDMI_EN_SUB_ODL (GPE0)
2. EC_SUB_IO_1 (GPF0)
3. EC_SUB_IO_1 (GPL3
4. EC_SUB_ANALOG (GPL0/ADC13)
BUG=b:182973699
BRANCH=boten
TEST=make buildall
Signed-off-by: reno.wang <reno.wang@lcfc.corp-partner.google.com>
Change-Id: I98875455a04ae58deb4a70a73ed2c73aafac0fe7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2767060
Reviewed-by: Henry Sun <henrysun@google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Henry Sun <henrysun@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add 500ms debounce for pen detect pin,
and new gpio PEN_DET_PCH.
BRANCH=dedede
BUG=b:175083024
TEST=make buildall -j
1. Plug out pen and check system can wake from S3.
Signed-off-by: arthur.lin <arthur.lin@lcfc.corp-partner.google.com>
Change-Id: Ib4b8b8a83cceef5ca77372170ffcad1c4771ab96
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2748207
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Will Lee <wwlee@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refer CL-2719104, adds a new gpio, EC_ENTERING_RW2 for boten.
BUG=b:181801177
BRANCH=dedede
TEST=make buildall
Signed-off-by: reno.wang <reno.wang@lcfc.corp-partner.google.com>
Change-Id: I1330525eae0e39ae84689b6e487b63bb34f80e18
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2734058
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Henry Sun <henrysun@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. EN_BL_OD should be configured as Open Drain, not Push Pull because
this gpio has external pull up.
2. In failure condition, EC configure it as Push Pull, and its power
leakage, pass to Panel, across CPU, then to PP3300_A.
3. EC monitor PP3300_A power rail by EC_VSNS_PP3300_A, and base on it to
control EC_AP_DPWROK.
4. Due to incorrect voltage level, and cause wrong power-off state.
BUG=b:174798347
BRANCH=dedede
TEST=make buildall, verify panel power leakage pass
Signed-off-by: jerry2.huang <jerry2.huang@lcfc.corp-partner.google.com>
Change-Id: I54ab12b8a74996d859b963e59568b706da36a729
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2603093
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Commit-Queue: Justin TerAvest <teravest@chromium.org>
Tested-by: Justin TerAvest <teravest@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
boten has garage stylus, this patch enables stylus charging when
stylus present.
BUG=b:155615390
BRANCH=none
TEST=make buildall -j
Signed-off-by: jerry2.huang <jerry2.huang@lcfc.corp-partner.google.com>
Change-Id: I601bb9c746774f3a410f83f322706ef4fb225830
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2455786
Reviewed-by: Justin TerAvest <teravest@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is an external pull-up on this signal, and so the EC pull-up is
unnecessary and may cause an intermediate voltage when the system enters
G3.
BRANCH=None
BUG=b:169179804
TEST=make -j buildall, boot to S0 on drawlat
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I82a513777018eb9a6cd86450612a5c943d7bd357
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2429385
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Naming for the C1 interrupt line varies slightly between variants due to
schematic name differences, and version or functional differences. This
change ensures all boards have GPIO_USB_C1_INT_ODL defined for baseboard
code to reference.
BRANCH=None
BUG=b:153684907
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I9303be2f9f142eed249da4f2f5e660985ceb7fdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2391213
Tested-by: Divagar Mohandass <divagar.mohandass@intel.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 27ee378bb78a299a0983379be83eb6d55860b4ae.
Reason for revert: b/162508724
A wake-up source from hibernation needs to be determined only by RO. Reverting back to the original implementation: CL:2236589.
Original change's description:
> power: Clear AP_IDLE when waking up by PB or LID
>
> Currently, AP_IDLE is cleared when EC wakes up by the power button or
> the lid open.
>
> This patch extends the logic from CONFIG_EXTPOWER_GPIO to
> CONFIG_EXTPOWER so that the bug (chromium:1073960) can be also fixed
> on the boards using non-GPIO method for extpower_is_present.
>
> Tested as follows on Trembyle:
> 1. Put DUT in hibernation.
> 2. Wake up DUT and observe:
> a. When waking up by power button, AP is turned on.
> b. When waking up by lid open, AP is turned on.
> c. When waking up by AC, AP is left idle.
>
> BUG=b:157077589, chromium:1073960, b:159350276
> BRANCH=none
> TEST=See above.
>
> Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
> Change-Id: I944aaac036ce58659e81b7021e52a3291f31e951
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2283946
> Reviewed-by: Jett Rink <jettrink@chromium.org>
Bug: b:157077589
Bug: chromium:1073960
Bug: b:159350276
Bug: b:162508724
Change-Id: Iaf9d0af2ca8c48bbf2529c4ba05493837dd76287
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2333106
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Auto-Submit: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Signal EC_AP_USB_C1_HDMI_HPD(EC->AP) status is opposite to signal
HDMI_HPD_SUB_ODL(HDMI->EC). Keep signal HDMI_EN_SUB_ODL low level.
BUG=b:160668999
BRANCH=none
TEST=make buildall -j
Signed-off-by: xiong.huang <xiong.huang@bitland.corp-partner.google.com>
Change-Id: I3d3d88e7be5543d49508bb7023c39764ab84abdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2284511
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Config volume +/- GPIOs as GPIO_INT_BOTH and GPIO_PULL_UP.
BUG=b:160671909
BRANCH=none
TEST=make buildall -j
Signed-off-by: xiong.huang <xiong.huang@bitland.corp-partner.google.com>
Change-Id: I63b7a7a5a0f1b75747cb25e46a512d19a08f6ffb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2284512
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove GPF4, GPF5, GPC7, GPF1, GPL2.
Configure GPL6 and GPE6, which control MB and DB USB-A power supply.
GPE0 and GPE7 are used for DB HDMI.
BUG=b:157626290, b:158658777
BRANCH=none
TEST=make buildall -j
Signed-off-by: xiong.huang <xiong.huang@bitland.corp-partner.google.com>
Change-Id: Idb04e9d93d30c4ff8792dc92e92888a771bd02ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2245588
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove I2C4.
BUG=b:157626290, b:158658777
BRANCH=none
TEST=make buildall -j
Signed-off-by: xiong.huang <xiong.huang@bitland.corp-partner.google.com>
Change-Id: Id1af7591e2bfcc39175470b93c27df257a5dff1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2245577
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use charger/TCPC RAA48900 instead of TCPC IT8320 + charger SM5803
combination at MB side.
BUG=b:157626290, b:158023819
BRANCH=none
TEST=make buildall -j
Signed-off-by: xiong.huang <xiong.huang@bitland.corp-partner.google.com>
Change-Id: Ibb97a41e1d280da7c92cf2c00202b5eb205f99b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2239599
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove chips:
Charge chip - SM5803
TCPC and USB mux chip - ANX7447
USB retimer chip - TUSB544
BC1.2 chip - PI3USB9201
BUG=b:157626290, b:158023819
BRANCH=none
TEST=make buildall -j
Signed-off-by: xiong.huang <xiong.huang@bitland.corp-partner.google.com>
Change-Id: Iac30f683774368b2b5706c5f804caf549a54139a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2235238
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
The starting point for the Boten EC image copied from waddledee
BUG=b:158023819
BRANCH=none
TEST=make BOARD=boten
Change-Id: Ie06c2b54b3b8c873c0b302561f5f86a9d8e8939a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2227769
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Reviewed-by: Peichao Li <peichao.wang@bitland.corp-partner.google.com>
Tested-by: Peichao Li <peichao.wang@bitland.corp-partner.google.com>
Auto-Submit: Peichao Li <peichao.wang@bitland.corp-partner.google.com>
Commit-Queue: Marco Chen <marcochen@chromium.org>
|