summaryrefslogtreecommitdiff
path: root/board/brya
Commit message (Collapse)AuthorAgeFilesLines
...
* brya: Modify lid and base accel standard refOwen_Ou2021-05-051-5/+5
| | | | | | | | | | | | | | | | Modify lid_standard_ref and base_lid_standard_ref xyz axis. BUG=b:184779333 BRANCH=none TEST=Use'watch -n 0.1 ectool motionsense'keep look xyz axis change. Signed-off-by: Owen_Ou <Owen_Ou@compal.corp-partner.google.com> Change-Id: Ifca138e3af5d65ccfc69052e59f5746e7e364c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2848058 Tested-by: Owen Ou <owen_ou@compal.corp-partner.google.com> Auto-Submit: Owen Ou <owen_ou@compal.corp-partner.google.com> Reviewed-by: Boris Mittelberg <bmbm@google.com> Commit-Queue: Boris Mittelberg <bmbm@google.com>
* brya: Add motionsense lid angleOwen_Ou2021-05-051-0/+3
| | | | | | | | | | | | | | | | | Add brya ectool motionsense lid_angle BUG=b:184779333 BRANCH=none TEST=Use 'ectool motionsense lid_angle' have value. Signed-off-by: Owen_Ou <Owen_Ou@compal.corp-partner.google.com> Change-Id: I21b50f341460c458a03c393e9d9fc9caa9ed371a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2848240 Tested-by: Owen Ou <owen_ou@compal.corp-partner.google.com> Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: caveh jalali <caveh@chromium.org> Auto-Submit: Owen Ou <owen_ou@compal.corp-partner.google.com> Commit-Queue: Boris Mittelberg <bmbm@google.com>
* brya: Update battery parametersCaveh Jalali2021-04-231-3/+3
| | | | | | | | | | | | | | | | | | This updates the brya PoR battery parameters to match the latest spec provided in b/177971846#comment16. - device name added - precharge current raised to 280mA - min. discharge temp raised to -10C BRANCH=none BUG=b:177971846 TEST=PoR battery is recognized and charges Change-Id: I9e3dcd47166cfd943f9f324802de9361d4da7ae6 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2837416 Reviewed-by: Boris Mittelberg <bmbm@google.com>
* thermisor: move header to include dirDawid Niedzwiecki2021-04-221-1/+1
| | | | | | | | | | | | | | | | Move the "thermistor.h" header to the include/driver/temp_sensor directory. It is used by the Zephyr shim, so the change is useful to include the header. BUG=b:180403276 BRANCH=none TEST=make buildall Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: I0e83df97e50a3b324440b65ddb900ddf135f2439 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2843323 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* brya: Define fw_config at board levelCaveh Jalali2021-04-215-10/+116
| | | | | | | | | | | | | | | | This updates the brya FW config fields based on the brya/config.star definitions. FW config fields and values are now defined at the project level rather than the program level. In other words each board (variant) defines its own FW config and no longer relies on baseboard definitions. BRANCH=none BUG=b:180434685 TEST=USB C1 port still works on brya for PD charging and SS data Change-Id: I055b0e2b051b7d41bbe116455274fe8b4a785741 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2837417 Reviewed-by: Keith Short <keithshort@chromium.org>
* brya: Remove debug outputCaveh Jalali2021-04-211-5/+2
| | | | | | | | | | | BRANCH=none BUG=b:180980490,b:184873747 TEST=debug message no longer present when using suzyQ Change-Id: I709588b4e08263b05e49dc3c537e6515e0617b31 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2837415 Reviewed-by: Alex Levin <levinale@google.com>
* brya: Tune mp2964 settingsCaveh Jalali2021-04-163-0/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This tunes some parameters in the MP2964 IMVP9 to improve system stability. In this round, the only tuning we have identified is to change the SVID alert delay time to 200ns. The tuning is applied to the PMIC registers, then committed to the PMIC non volatile memory. On subsequent boots (including power cycle), the tuned values are used and no further tuning is required. 1st boot: mp2964_on_startup: attempting to tune PMIC mp2964: tuning reg 0x3f from 0xe001 to 0xe081 mp2964: tuning reg 0x3f from 0xe001 to 0xe081 mp2964_store_user_all: updating persistent settings mp2964: reg 0x3f already 0xe081 mp2964: reg 0x3f already 0xe081 2nd+ boot, also after removing battery: mp2964_on_startup: attempting to tune PMIC mp2964: reg 0x3f already 0xe081 mp2964: reg 0x3f already 0xe081 BRANCH=none BUG=b:185424011 TEST=unplugged battery, verified new values are persistent Change-Id: Idcb540eed6f893586853b8fed6e84e24b4a2f9e3 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2823634 Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Commit-Queue: Tim Wawrzynczak <twawrzynczak@chromium.org>
* brya: add lid_open interruptBoris Mittelberg2021-04-152-1/+2
| | | | | | | | | | | | | | | | | | | Any change on LID_OPEN line coming from GMR will trigger an interrupt. Notes: on P0 there is no magnet, so the interrupt will never be triggered on P1 the magnet is upside down, so lidstate would always report "open" BRANCH=none BUG=b:185322560 TEST=manual test with a magnet: when magnet approaches the GMR sensor with correct orientation - lid close event happens. Depending on the OS state the system shuts down or enters sleep. When the magnet is removed the system wakes up Signed-off-by: Boris Mittelberg <bmbm@google.com> Change-Id: I427c15d4f75add34266701089e05f99a924a5b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2827411 Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
* brya: add function to enabled/disabled keyboard backlightJosh Tsai2021-04-151-0/+17
| | | | | | | | | | | | | | | | | Enabled keyboard backlight when system resume to S0 Disabled keyboard backlight when system suspend BUG=b:184103439 BRANCH=none TEST=Keyboard backlight can work normally Signed-off-by: Josh Tsai <Josh_Tsai@compal.corp-partner.google.com> Change-Id: Idd4454bfba48d92bdfd75144141afac34c3781c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2822275 Reviewed-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com> Reviewed-by: caveh jalali <caveh@chromium.org> Tested-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com> Commit-Queue: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
* brya: Enable EC hibernate using PSLCaveh Jalali2021-04-131-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | This adds the wake source pin definitions needed by the NPCX9 chip support code for brya board ID 1. Note that board ID 1 needs a rework on VCC1_RST to prevent it from falsely waking the board. BRANCH=none BUG=b:183246197 TEST=booted same image on old and new rev. of board Used "hibernate" on EC console hibernate the system. It woke up immediately (b/183412004) with cause "hibernate" indicating this was a PSL wake: --- UART initialized after reboot --- [Image: RO, brya_v2.0.8357-19a8f337db 2021-04-08 01:09:30 caveh@caveh] [Reset cause: power-on hibernate wake-pin] LID_OPEN was tested as a PSL wake source by artificially disabling CONFIG_HIBERNATE_PSL_VCC1_RST_WAKEUP to eliminate VCC1 as a false wake source. Change-Id: If4cca6d1e20ddc3c422697e6838c9df0ddd8cb15 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2728679 Reviewed-by: Furquan Shaikh <furquan@chromium.org>
* brya: Update EC GPIOs for board ID 1Caveh Jalali2021-04-131-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This updates the GPIO functional changes to support the new rev. (ID 1) of the brya board. EC_KB_BL_EN moved from GPIO85 to GPIOA3 (was EN_SLP_Z). EC_KB_BL_EN is set to low since that's the preferred setting for the initial keyboard backlight. This does not break the old board due to a hardware bug on the old board that causes it to come out of sleep unconditionally. GPIO85 does not need to be configured here when PSL is enabled. EN_SLP_Z is no longer used. EC_RST_ODL (VCC1_RST#/GPO77) has been removed from config. This was an unused input on the old board. This pin functions as a wake source when we enable HIBERNATE_PSL_VCC1_RST_WAKEUP and does not need to be configured here. finally, PSL is enabled on pins PSL_IN1-3. BRANCH=none BUG=b:184811017,b:183246197 TEST=both old new new revision of the brya board can boot Cq-Depend: chromium:2728679 Change-Id: I4b3ab17bb44d18167328faee1a1b604bf0428dd3 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2813460 Reviewed-by: Furquan Shaikh <furquan@chromium.org>
* brya: Rename GPIOs to match board ID 1Caveh Jalali2021-04-102-5/+4
| | | | | | | | | | | | | | | | | | | | | This renames some GPIOs to match the new board revision (ID 1): LID_OPEN_OD to LID_OPEN TABLET_MODE_ODL to TABLET_MODE_L PRB_EC_GPIOC0 to EC_PCH_WAKE_R_ODL Even though EC_PCH_WAKE_R_ODL looks like a new signal, in both cases, this pin is not connected to anything. So, there are no functional changes involved. BRANCH=none BUG=b:184811017 TEST=buildall passes Signed-off-by: Caveh Jalali <caveh@chromium.org> Change-Id: Ib8eb016f2a209bec8ffb547605c967985a38e232 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2813459 Reviewed-by: Boris Mittelberg <bmbm@google.com>
* brya: add ALS and ALS RGB sensorsBoris Mittelberg2021-04-084-2/+113
| | | | | | | | | | | | | | | | | | | | | | Add ambient light sensor (with RGB) to motionsense task BRANCH=none BUG=b:179648721 TEST=manual tests. ALS test from AP console: $ ectool motionsense calibrate 3 $ ectool motionsense See the reading for sensor #3 (clear light) and #4 (RGB) Sensor 3: 18366 0 0 Sensor 4: 9673 5656 3832 The values above change with light intensity and color. I've used Lifx RGB light bulb to verify each channel works. Signed-off-by: Boris Mittelberg <bmbm@google.com> Change-Id: I5f0c1529ae1e05f4df0b0ec6fa01808f64092466 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2808136 Reviewed-by: caveh jalali <caveh@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* brya: add motionsense task and IMU sensorsBoris Mittelberg2021-04-085-2/+163
| | | | | | | | | | | | | | | | | | | | | | | | | | Add motionsense task with following sensors: lid accel, base accel, base gyro. BRANCH=none BUG=b:179648721 TEST=manual tests were performed Base accel/gyro test on EC console: > accelread 1 Current data 1: -65461 65488 8163 > accelread 2 Current data 2: -2 2 65518 Lid accel test from AP console: $ ectool motionsense Sensor 0: 392 10548 12708 All the values above changed when I moved the boards Signed-off-by: Boris Mittelberg <bmbm@google.com> Change-Id: I03cddcf74611da6d2b5557a3998db6f0314a015a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2798977 Reviewed-by: caveh jalali <caveh@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* brya: Assert PROCHOT when VSYS droops too lowCaveh Jalali2021-04-081-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | This addresses a problem where brya shuts down when running without a battery. The root cause is that VSYS droops too much when SoC power demand spikes. The solution is to raise the VSYS_TH2 threshold in the bq25720 charger chip to provide an early throttle feedback signal to the SoC during high load. The default threshold is 5.9v which is low enough to cause problems. On Brya, we see VSYS drop all the way down to 5.4v at which point the SoC shuts down. The voltage should never be drawn down that low, so tune the charger to assert PROCHOT at 7.0v instead. This throttles the SoC sufficiently during high load to avoid instability. 7.0v was selected after consulting with EE team. BRANCH=none BUG=b:183474163 TEST=booted brya to the OS without a battery Change-Id: Id06e567b9f8a499da7ceb345e673e091c94d90c2 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2798980 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Will Arthur <wda@google.com> Commit-Queue: Keith Short <keithshort@chromium.org>
* brya: Update generated-gpio.inc from spreadsheetCaveh Jalali2021-04-071-1/+1
| | | | | | | | | | | | | | This refreshes generated-gpio.inc from the latest GPIO spreadsheet. The change is to configure EC_ACCEL_INT_R_L for 1.8v instead of 3.3v. BRANCH=none BUG=b:179648721 TEST=buildall passes, brya boots. accel interrupts tested by bmbm@ Signed-off-by: Caveh Jalali <caveh@chromium.org> Change-Id: Ib0c2667e7593329e533b47fdb1ce09a4eece6590 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2807252 Reviewed-by: Boris Mittelberg <bmbm@google.com>
* brya: Update generated-gpio.inc from spreadsheetCaveh Jalali2021-03-312-3/+2
| | | | | | | | | | | | | | | | | | | | | This refreshes generated-gpio.inc from the latest GPIO spreadsheet. * ACOK_EC_OD has been renamed to ACOK_OD (the name is now consistent with the next rev. of the board) * GPIO85 is not marked as ALT mode. NPCX9 support code ignores ALT on this pin as it should never be in ALT mode (i.e. no functional change). BRANCH=none BUG=b:173575131 TEST=buildall passes, brya boots Change-Id: I541c52e83ff169818edcbc0716a84193ae9bd6a4 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2780840 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* genvif: Use VIF overrides by defaultAbe Levkoy2021-03-301-0/+3
| | | | | | | | | | | | | | Use board-specific override files when generating VIFs for boards. BUG=b:172276715 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I197365018ceb8197c22d631cebf4cbce1c0119f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2785506 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* brya: add board configurations for TBTBoris Mittelberg2021-03-241-0/+9
| | | | | | | | | | | | | | Enable usb4 mode, usb TBT_COMPAT mode and usb-c retimer FW update configs. This allows reading correct TBT state via 'ectool usbpdmuxinfo' command. BUG=b:181840109 BRANCH=main TEST=manual Signed-off-by: Boris Mittelberg <bmbm@google.com> Change-Id: Id67af7b570438c7a2a7efd1aa7dd1a4173cf4905 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2780837 Reviewed-by: Furquan Shaikh <furquan@chromium.org>
* brya: enable EFS2Caveh Jalali2021-03-231-0/+1
| | | | | | | | | | | | | | | This enables EFS2 on brya. BRANCH=none BUG=b:183165732 TEST=the GSC returns a hash mismatch (expected). Change-Id: I9af09c7d03255e448aadc5462ced261ae4cd6dc2 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2774717 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org>
* bq25710: Consolidate NARROW_VDC definitionCaveh Jalali2021-03-231-1/+0
| | | | | | | | | | | | | | | | | This consolidates the selection of CONFIG_CHARGER_NARROW_VDC to config.h for the bq25710 and bq25720 charger chips. The driver requires NARROW_VDC to be enabled, so move this setting to config.h similar to other chargers. BRANCH=none BUG=b:173575131 TEST=buildall passes Change-Id: I6c1768aff5d581544c4b7182f32ec45851a3a243 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2780831 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
* brya: disable CONFIG_SYSTEM_UNLOCKEDCaveh Jalali2021-03-231-2/+0
| | | | | | | | | | | | | | | We should no longer rely on the system being hard-coded to be unlocked. This should be determined at runtime from the write-protect status of flash. So, remove CONFIG_SYSTEM_UNLOCKED. BRANCH=none BUG=b:173575131,b:183240080 TEST=system boots Change-Id: I19182d115af31e7748a0117d763d7e0d490183c2 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2774715 Reviewed-by: Keith Short <keithshort@chromium.org>
* brya: Fix EC_GSC_PACKET_MODE directionCaveh Jalali2021-03-191-1/+1
| | | | | | | | | | | | | | | This changes EC_GSC_PACKET_MODE to be an output pin instead of input pin. The GPIO spreadsheet has been updated and this list has been regenerated. BRANCH=none BUG=b:183165732 TEST=with EFS2 enabled, the GSC returns a hash mismatch (expected). Change-Id: I2f92a8724c9c4ea51c5a6f36a4741ed0d7380ef8 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2774716 Reviewed-by: Furquan Shaikh <furquan@chromium.org>
* brya: Update auto-generated GPIO listCaveh Jalali2021-03-161-13/+0
| | | | | | | | | | | | | | | | | This refreshes the generated GPIO list based on updates in the main GPIO definition spreadsheet. The only difference is that GPIOs are no longer marked as "alternate" even when GPIO functionality is the alternate function of a pin. The NPCX support code automatically puts all declared GPIO pins into GPIO mode even when that is a pin's alternate function. BRANCH=none BUG=b:173575131 TEST=buildall passes Signed-off-by: Caveh Jalali <caveh@chromium.org> Change-Id: Ib7ba12f45407f86dc5fac6a75f68dee14be02514 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2738548 Reviewed-by: Keith Short <keithshort@chromium.org>
* brya: Enable tablet modeBoris Mittelberg2021-03-123-1/+4
| | | | | | | | | | | | | Enable GMR sensor and tablet mode for Brya. BRANCH=none BUG=b:181368071 TEST=buildall passes, manually tested with a magnet Signed-off-by: Boris Mittelberg <bmbm@google.com> Change-Id: I3d408e6b6bdd2bc5da81203c0c4e80c2ff367c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2737240 Reviewed-by: Furquan Shaikh <furquan@chromium.org>
* brya: remove CONFIG_BRINGUPBoris Mittelberg2021-03-121-1/+0
| | | | | | | | | | | | | Remove BRINGUP flag to allow proper cold reboot BRANCH=none BUG=b:182443498 TEST=buildall passes, manual test via `ectool reboot_ec cold` Signed-off-by: Boris Mittelberg <bmbm@google.com> Change-Id: I5a9d25ea9125acdec3645a6566965988eedb3e94 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2752436 Reviewed-by: Furquan Shaikh <furquan@chromium.org>
* brya: Enable LEDsBoris Mittelberg2021-03-123-2/+101
| | | | | | | | | | | | | Enable control of right and left LEDs, display charging status. BRANCH=none BUG=b:182329831 TEST=buildall passes, manual test with ectool Signed-off-by: Boris Mittelberg <bmbm@google.com> Change-Id: I1463102924a6300843f3381e1b66d88ae0096157 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2752345 Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
* brya: Enable MKBP supportFurquan Shaikh2021-03-101-0/+1
| | | | | | | | | | | | | | | | | | | | | | | This change enables MKBP support by selecting the following configs: * CONFIG_MKBP_EVENT * CONFIG_MKBP_USE_GPIO - This is selected instead of CONFIG_MKBP_USE_GPIO_AND_HOST_EVENT because GPIO_EC_INT_L is also the wake pin for brya. Additionally, GPIO_EC_INT_L is defined to allow mkbp driver to trigger interrupt to AP for tight timestamps. BUG=b:173575131 BRANCH=None TEST=make -j buildall Signed-off-by: Caveh Jalali <caveh@chromium.org> Signed-off-by: Furquan Shaikh <furquan@google.com> Change-Id: Ia755671d943576ecd8da3a76260c8b87d2ab35ef Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2747460 Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Commit-Queue: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org>
* brya: Control display backlight based on state of lid switchFurquan Shaikh2021-03-101-0/+7
| | | | | | | | | | | | | | | | | | This change enables CONFIG_BACKLIGHT_LID so that the EC disables the panel backlight when lid is closed. GPIO_ENABLE_BACKLIGHT is defined to allow common code to control the required GPIO. BUG=b:173575131 BRANCH=None TEST=make -j buildall Signed-off-by: Caveh Jalali <caveh@chromium.org> Signed-off-by: Furquan Shaikh <furquan@google.com> Change-Id: I3c54287d716b66696cb41ba4433a9d704f01f674 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2747707 Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Commit-Queue: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org>
* brya: Enable bringup related configsFurquan Shaikh2021-03-101-0/+3
| | | | | | | | | | | | | | | | | | This change enables bringup related configs: CONFIG_BRINGUP CONFIG_SYSTEM_UNLOCKED BUG=b:173575131 BRANCH=None TEST=make -j buildall Signed-off-by: Caveh Jalali <caveh@chromium.org> Signed-off-by: Furquan Shaikh <furquan@google.com> Change-Id: I20256eca527ec11db9fd04ce84d960ad16d4401f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2747705 Tested-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Commit-Queue: Furquan Shaikh <furquan@chromium.org>
* brya: Enable switch supportFurquan Shaikh2021-03-101-1/+0
| | | | | | | | | | | | | | | | | This change enables switch support for baseboard brya by defining CONFIG_SWITCH. BUG=b:173575131 BRANCH=None TEST=make -j buildall Signed-off-by: Caveh Jalali <caveh@chromium.org> Signed-off-by: Furquan Shaikh <furquan@google.com> Change-Id: Ie8400bbe174fc3662282534f4027513e8c44b220 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2747417 Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Commit-Queue: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org>
* brya: Drop unnecessary undef of CONFIG_SPI_FLASHFurquan Shaikh2021-03-101-1/+0
| | | | | | | | | | | | | | | | | This change drops the unnecessary undef of CONFIG_SPI_FLASH from brya/board.h. This config is already undef'ed in include/config.h. BUG=b:173575131 BRANCH=None TEST=make -j buildall Signed-off-by: Caveh Jalali <caveh@chromium.org> Signed-off-by: Furquan Shaikh <furquan@google.com> Change-Id: I6074417c387f4aae3ae0999cd324b6c7bd1cf339 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2746920 Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Commit-Queue: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org>
* brya: Include button_interrupt declaration from button.hFurquan Shaikh2021-03-102-6/+1
| | | | | | | | | | | | | | | | | | This change includes button.h in brya/board.c and drops the declaration of `button_interrupt` from brya/board.h. This was missed when volume button support was added to brya in CL:2738398. BUG=b:173575131 BRANCH=None TEST=make -j buildall Signed-off-by: Caveh Jalali <caveh@chromium.org> Signed-off-by: Furquan Shaikh <furquan@google.com> Change-Id: I3174fb5662fe0bc9783057bc45b9e3e0be00ad08 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2747756 Tested-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Commit-Queue: Furquan Shaikh <furquan@chromium.org>
* Brya: Add usb_pd_policyCaveh Jalali2021-03-101-0/+19
| | | | | | | | | | | | | | | This adds the USB PD policy support code. BRANCH=none BUG=b:173575131 TEST=with reset of CQ-Depend patches, brya can charge using PD Change-Id: I55b2b0a9a68adf0eaa7ac95be0c6d9136adb6366 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2700317 Commit-Queue: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* Brya: Enable charger chipCaveh Jalali2021-03-103-0/+53
| | | | | | | | | | | | | | This adds the charger chip support code. BRANCH=none BUG=b:173575131,b:180784200 TEST=with reset of CQ-Depend patches, brya boots to AP Change-Id: I1b220376cb03197e13aad65f1e79692eaf8fb1e1 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2700316 Commit-Queue: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org>
* brya: Add USB-C supportCaveh Jalali2021-03-106-14/+408
| | | | | | | | | | | | | | | | This adds the USB-C support subsystem code. BRANCH=none BUG=b:173575131 TEST=with reset of CQ-Depend patches, brya boots to AP Cq-Depend: chromium:2700317 Change-Id: I9181b13c7ef4bb2f6bb93bd0d16369848779c198 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2700315 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Commit-Queue: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org>
* brya: Enable physical volume buttonsCaveh Jalali2021-03-052-8/+2
| | | | | | | | | | | | | | | This enables the config option for using physical volume up/down buttons. BRANCH=none BUG=b:173575131 TEST=buildall passes Signed-off-by: Caveh Jalali <caveh@chromium.org> Change-Id: Ib3bb088a88073bd80742e35d0b8a819100163351 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2738398 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Commit-Queue: Furquan Shaikh <furquan@chromium.org>
* brya: Enable RTC resetCaveh Jalali2021-03-051-0/+1
| | | | | | | | | | | | | This enables the RTC reset feature of the SoC. BRANCH=none BUG=b:173575131 TEST=buildall passes Change-Id: I29f7599fea831dd5751c5609b4e974059a8be2e7 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2738918 Reviewed-by: Furquan Shaikh <furquan@chromium.org>
* brya: Enable power buttonCaveh Jalali2021-03-053-14/+4
| | | | | | | | | | | | | This enables the power button feature form the EC to the SoC. BRANCH=none BUG=b:173575131 TEST=buildall passes Change-Id: Ife5eaa37d269ab4fa5a72be4fec1dec7c4536749 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2738917 Reviewed-by: Furquan Shaikh <furquan@chromium.org>
* brya: Add keyboard supportCaveh Jalali2021-03-054-1/+30
| | | | | | | | | | | | | | This adds keyboard support. Brya uses a non-vivaldi style keyboard. BRANCH=none BUG=b:173575131 TEST=buildall passes Change-Id: I6b703f37a773990d81530d4d99b76711efa238e0 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2737548 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Commit-Queue: Furquan Shaikh <furquan@chromium.org>
* brya: Use fixed fan speedsCaveh Jalali2021-03-043-7/+48
| | | | | | | | | | | | | | | | | | This sets the fan speed based on SoC power state. If the AP is off, run the fan at 33%. If the AP is on, run the fan at 100%. Our sensors are not yet calibrated and we don't have confirmed thermal thresholds for the SoC, so just keep the fan running at full speed when the AP is running. BRANCH=none BUG=b:179975706,b:180681346,b:181271666 TEST=fan is slow before AP boots, then speeds up as soon as AP starts Change-Id: Id10e1510496d94bd3cc8ea70e4661c52d15fe9ed Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2722552 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Sooraj Govindan <sooraj.govindan@intel.com>
* byra: Update POW-TECH battery device nameCaveh Jalali2021-03-041-1/+1
| | | | | | | | | | | | | | | | This removes the battery device name so that only the manufacturer name is used to distinguish batteries. There is some uncertainty in how these batteries identify themselves and we can avoid it as we can identify batteries by manufacturer name. BRANCH=none BUG=b:177971846,b:180784200 TEST=EC console reports battery is found Change-Id: Idd65a0dc9f5a00d61358ed1da2c876243095fdc1 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2722551 Reviewed-by: Furquan Shaikh <furquan@chromium.org>
* brya: Add CBI and FW_CONFIG supportstabilize-13821.B-mainCaveh Jalali2021-02-272-0/+11
| | | | | | | | | | | | | | This adds support for CBI and the first USB DB type field in FW_CONFIG. BUG=b:173575131,b:180434685 BRANCH=none TEST=buildall succeeds Signed-off-by: Caveh Jalali <caveh@chromium.org> Change-Id: If1d27fc100db9b814f90a9378d8dd19530a92bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2706964 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Sooraj Govindan <sooraj.govindan@intel.com>
* brya: tune fan parametersCaveh Jalali2021-02-271-9/+6
| | | | | | | | | | | | | | This tunes the fan parameters for the brya prototype fan. These are temporary parameters until a real fan is available. BRANCH=none BUG=b:173575131,b:180681346 TEST=observed fan speeds using EC CLI Change-Id: I74c1044c56a0ab7374f0fe52a757c33ede2aaa08 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2722553 Reviewed-by: Keith Short <keithshort@chromium.org>
* brya: Enable USB-A port power controlCaveh Jalali2021-02-272-0/+14
| | | | | | | | | | | | | | | This enables power control (i.e. "charging") of the USB-A port located on the USB daughtercard. This is required to power devices connected to the port. BRANCH=none BUG=b:173575131 TEST=USB LED flash light powers on Signed-off-by: Caveh Jalali <caveh@chromium.org> Change-Id: Id8bcf07a6632b909e7c28b5800d035f05fea0ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2717806 Reviewed-by: Keith Short <keithshort@chromium.org>
* brya: Add FRS and OC GPIOsCaveh Jalali2021-02-241-2/+9
| | | | | | | | | | | | | | | This adds the USB FRS and OC control signals to the GPIO expander located on the NCT 3808 TCPC. BRANCH=none BUG=b:173575131 TEST=buildall passes Change-Id: Id6e29541b266638ed5b11571ae5cdc2598e40f35 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2704032 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* brya: Enable AP throttlingCaveh Jalali2021-02-243-14/+53
| | | | | | | | | | | | | | | | This enables AP throttling based on thermal conditions. Brya has two thermistors - one near the SoC and one near the charger that can be used for deciding when to throttle. BRANCH=none BUG=b:173575131,b:180681346 TEST=buildall passes Change-Id: Ieaa6959ff9fc7ee5e505c13cff2150ad70a04e3b Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2686981 Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* brya: set up non-vivaldi keyboard layoutCaveh Jalali2021-02-241-0/+5
| | | | | | | | | | | | | | | This configures the brya keyboard layout support to match early boards. These boards set up for a non-vivaldi layout. BRANCH=none BUG=b:180973324 TEST=tested all keys Change-Id: I856c87c34db3dfda647de88577655b865f97ab93 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2713939 Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* brya: Add thermistor supportCaveh Jalali2021-02-243-1/+65
| | | | | | | | | | | | | | This adds support for the two thermistors on brya. BRANCH=none BUG=b:173575131 TEST=buildall passes Change-Id: I198e1ce72910d1798c51cf5c99c9f1f0601f3c31 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2706263 Commit-Queue: Keith Short <keithshort@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* brya: Update keyboard KSO02 pin definitionCaveh Jalali2021-02-241-1/+0
| | | | | | | | | | | | | | | | | | | | | | This updates the keyboard pin definitions. KSI02 is used in GPIO mode (i.e. ALTERNATE function), however the NPCX support code automatically puts all pins declared as GPIO into GPIO mode. No explicit ALTERNATE pin declaration is needed. Nuvoton support code interprets ALTERNATE declarations as a request for a pin to be configured as a function other than GPIO, regardless of whether the pin's primary or secondary function is GPIO. This put KSO02 into ALTERNATE (i.e. keyboard) mode when it actually needs to be in GPIO mode. BRANCH=none BUG=b:180759360 TEST=all keyboard keys respond on brya Change-Id: I15221eafde1682bae527bea8fe14280c78bb489b Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2713938 Reviewed-by: Keith Short <keithshort@chromium.org>
View Lorry Controller Status