| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable the USB mux task for volteer, since the virtual mux sets may take
significant time to complete.
BRANCH=None
BUG=b:186777984
TEST=on voxel, pass tast typec.Mode*.manual
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I634a6ef8029b8810ed0e08e11d2ab923af320175
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3078418
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clang warns:
error: initializer element is not a compile-time constant
There is an upstream LLVM review with proposed fix:
https://reviews.llvm.org/D76096.
In the meantime, we will work around it.
BRANCH=none
BUG=b:172020503, b:202062363
TEST=./util/compare_builds.sh -b all -j 120
=> MATCH
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I066e082870bcd726555a5f2461f09988d4e6ce55
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3237042
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GPIO_RSMRST_L_PGOOD is also used as GPIO_PG_EC_RSMRST_ODL
creating redundancy. Removing it will help need for
redefinitions for zephyr.
Remove reference to GPIO_RSMRST_L_PGOOD in zephyr
BUG=b:200975143
BRANCH=main
TEST=make buildall -j, boot up on brya
Change-Id: Iff46595174c54db347b69cff3ad9e266ba9fd535
Signed-off-by: Divya Sasidharan <divya.s.sasidharan@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3180808
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When building with clang, it reports:
board/chronicler/gpio.inc:178:1: error: initializer overrides prior
initialization of this subobject [-Werror,-Winitializer-overrides]
ALTERNATE(PIN(F, 1), 0, MODULE_ADC, 0) /* TEMP_SENSOR3 */
This expands to:
static const struct gpio_alt_func gpio_alt_funcs[] = {
...
{GPIO_PORT_F, (1U << (1)), .func = (0), .module_id = (MODULE_ADC), .flags =
(0)}
};
The problem is that struct gpio_alt_func has the order "module_id, func,
port, mask, flags", so in this case we are setting func to (1U << (1))
and then to (0).
It looks like the intent was to use the PIN_MASK macro instead of PIN,
which expands to:
static const struct gpio_alt_func gpio_alt_funcs[] = {
...
{.port = GPIO_PORT_F, .mask = ((1U << (1))), .func = (0), .module_id =
(MODULE_ADC), .flags = (0)},
};
The code appears to be repeated in several boards, which were found
with:
git grep --name-only TEMP_SENSOR3 | grep gpio.inc | sort | uniq
BRANCH=none
BUG=b:172020503
TEST=make CC=arm-none-eabi-clang BOARD=chronicler
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I66a097b761c0b15466a30e53a710d532cd48256c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3206478
Reviewed-by: Eric Yilun Lin <yllin@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the drivers are now taking a mux_state_t set of flags to update,
go ahead and unify the usb_mux API this way as well. It makes the
parameters more apparent than the 1/0 inputs, and aligns the stack to
use the same parameters.
BRANCH=None
BUG=b:172222942
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ie943dbdf03818d8497c0e328adf2b9794585d96e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3095438
Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add keyboard_factory_scan_pins and keyboard_factory_scan_pins_used to
keyboard_scan header so they do not need to be declared as extern by
individual boards. These constants need to be defined if
CONFIG_KEYBOARD_FACTORY_TEST is enabled.
BUG=None
TEST=Build
BRANCH=None
Change-Id: I1a100f626b3cea251ca72703d17b2d27db0f8f28
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3053101
Commit-Queue: Diana Z <dzigterman@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently keyboard_scan_config is defined by each board using
CONFIG_KEYBOARD_BOARD_CONFIG. This patch makes it defined as
__override hence removes CONFIG_KEYBOARD_BOARD_CONFIG.
BUG=None
BRANCH=None
TEST=buildall
Change-Id: I53a356741ba4d00e829ca59b74ee6dc704188728
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3044403
Tested-by: Gwendal Grignou <gwendal@chromium.org>
Commit-Queue: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tune compensate for channel loss up to 10dB.
BUG=b:189587527
BRANCH=firmware-volteer-13672.B-main
TEST=Attached USBC to HDMI dongle.
i2ctrace to make sure the EQ is 10dB.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: Ieff6d645cb88875efc3f828919a152180d605479
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2972523
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Vconn source should ready before PS_RDY.
BUG=b:186079130
BRANCH=firmware-volteer-13672.B-main
TEST=PDtrace to make sure the timing of Vconn_Swap.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: I3c60ea73219497c661b6fec5add77c73a7f116b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2847714
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use board-specific override files when generating VIFs for boards.
BUG=b:172276715
TEST=make buildall
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: I197365018ceb8197c22d631cebf4cbce1c0119f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2785506
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove CONFIG_SYSTEM_UNLOCKED for firmware qual.
BUG=none
BRANCH=volteer
TEST=make buildall
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: Iba80311009ebd0b78dee68d7184e892564c43c40
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2744557
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove CONFIG_BYPASS_CBI_EEPROM_WP_CHECK for firmware qual.
BUG=none
BRANCH=volteer
TEST=make buildall
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: Ie3af6ba0b6a2661c071150908a3748e3220c305c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2744556
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to bypass the cbi eeprom write protection, we add the config
CONFIG_BYPASS_CBI_EEPROM_WP_CHECK to bypass the write protection gpio
check.
BUG=b:169034911
BRANCH=volteer
TEST=`ectool cbi set` is working
Change-Id: Ibd1e8af4eb8f7ead506999c4ce3803fa0e341c10
Signed-off-by: Zhuohao Lee <zhuohao@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2719725
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch add for factory keyboard connector test.
BUG=none
BRANCH=firmware-volteer-13672.B-main
TEST=Short keyboard pins and make sure "ectool kbfactorytest" works.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: I2acd2df29e477a564dbb6a13039d14749f81f935
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2666555
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch changes thermal halt/alert, fan maximum/off temperature
point and fan minimum/maximum speed.
BUG=b:177635236
BRANCH=firmware-volteer-13672.B-main
TEST=Thermal team verified thermal policy is expected.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: I165dde7585aff055659187ab08511584c836cd4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2639432
Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Almost every relevant board copy-pastes 5000 us. Make that the default
and get rid of the redundant definitions. This is the approximate result
of this command:
find . -type f -name *.h | xargs sed -i -E \
'/#define CONFIG_USBC_VCONN_SWAP_DELAY_US[[:space:]]+5000[[:space:]]/d'
BUG=b:144165680
TEST=make buildall
BRANCH=none
Change-Id: Ife86f9752971abcd7ab5ad5a5e607eb2ccbde2ba
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2628132
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace PD_VCONN_SWAP_DELAY with CONFIG_USBC_VCONN_SWAP_DELAY_US. This
is the approximate result of the following command, run from
platform/ec:
find . -type f -\( -name '*.c' -o -name '*.h' -\) | \
xargs sed -iE 's/PD_VCONN_SWAP_DELAY/CONFIG_USBC_VCONN_SWAP_DELAY/g'
Fix some latent formatting errors in usb_pd_protocol.c, because they
were preventing pre-upload hooks from passing.
BUG=b:144165680
TEST=make buildall
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: Icaf3b309c08fdcd162e960cf5dc88185016b5d2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2628131
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
BRANCH=firmware-volteer-13672.B-main
TEST=make buildall
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: I18703b4ba24e0bbdda48504c3b77023f87fe2e5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2639421
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:177635229
BRANCH=firmware-volteer-13672.B-main
TEST=make buildall
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: I1c8bf9a0a6dead6ab1c0c1ad7f3b29e32c435c9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2635873
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit remove sensors and tablet mode, since Elemi doesn't
support that.
BUG=b:163012636
BRANCH=firmware-volteer-13521.B-master
TEST=Verified boot without sensors initial.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: Icf23456763699024d934d78ac2cc20fcfcc5b9bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2554171
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chagne EC chip to npcx7m7fc to board version 1.
BUG=b:169118044, b:174275667
BRANCH=firmware-volteer-13521.B-master
TEST=Verified boot with npcx7m7fc re-worked board.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: I334f56b2f47c21ff38aeccc346b6be43fb71b7ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2554172
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch remove unused daughterboard configuration since Elemi only
support USB3 active doughterboard.
BUG=b:173033778
BRANCH=firmware-volteer-13521.B-master
TEST=Make sure daughterboard C1 port still works.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: I1fd856488652aa0be8d4f1ed171609c0fcfedf8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2534438
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The TCSS port mapping is not used by the EC and the higher layers no
longer query the EC for this mapping. We can remove this feature and
disable CONFIG_INTEL_VIRTUAL_MUX which was added to enable it.
BRANCH=none
BUG=b:153941950
TEST=buildall passes
Change-Id: I2d7f51212f3e64d74827d7f82654eb93534b8db4
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2427632
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename CONFIG_I2C_CONTROLLER and related comments.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ied6a1829bf54a5c9a32e6772982a4b8aa31aaf23
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2518659
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:169409487
BRANCH=firmware-volteer-13521.B-master
TEST=make sure ec console kblight can adjust keyboard backlight
brightness.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: Ifbb31e76dec8b595e13717b382eef229b9dd934c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2491582
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:169409487
BRANCH=firmware-volteer-13521.B-master
TEST=Make sure TCPC C1 port initial passed.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: Ib989947f14feccb0ef4eaad8a2fa5556a4061fd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2491585
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add batteries configuration as following:
1. Simplo 996QA193H
2. Cosmx CA407792G
BUG=b:169409487
BRANCH=firmware-volteer-13521.B-master
TEST=make sure battery charging, battery cutoff works.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: I637b3bf1ea3faa5a7283de80ab9cffb196264c04
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2484114
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Elemi have two charging leds on left side and right side. Each side
have two colors amber and white.
The led behavior define as following:
1. Charging led: led on with charging port active, other port is off.
2. Charging: Amber.
3. Discharging: Off.
4. Battery Error: Blinking white (0.4 sec on, 0.4 sec off)
5. Fuel < 10%: Blinking white on right side port (1 sec on, 1 sec off)
6. Force idle for factory: Blinking amber (1 sec on, 1 sec off)
7. S0ix without charging state:
Blinking both side LED white (1 sec on, 1 sec off)
BUG=b:169409487
BRANCH=firmware-volteer-13521.B-master
TEST=make sure led behavior intended.
make sure ectool led left white/amber/off/auto work correctly.
make sure ectool led right white/amber/off/auto work correctly.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: I9e4837ddbf300ec7a6c0e0dc8660dc157f9228aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2484115
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable the ADC alternate function to reduce power usage.
BUG=b:155882590
TEST=make buildall
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: I2d76a8478bbe4fc7b1d4960edc29a7cede16cfdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2493405
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The volteer_tpcmv1 AP image has been removed, so the EC build based on
the TCPMv1 stack is no longer needed.
BUG=b:170658751
BRANCH=none
TEST=make buildall
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I8c5c3ffc95a588d4f24846eac3558184add9a444
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2481224
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since each variant may have different thermal sensor placement.
Move thermal params and configs from baseboard to variant.
BUG=b:170143672
BRANCH=none
TEST=make -j BOARD=eldrid
TEST=make buildall
Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Change-Id: Ie12f4cecad5f93c491e51a5fadfe856829f5b2e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2449510
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable CONFIG_CHARGE_RAMP_SW because hardware based charge ramping
doesn't work on the ISL9241.
BUG=b:169350714, b:168960587
BRANCH=none
TEST=make buildall
TEST=Connect 1.5A CDP device to Volteer and verify charge ramp from 0.5A
to 1.5A over about 7 seconds.
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I81e8a3913bd776d0d3fda6d294fdeabbde5df62a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2438912
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
|
|
Create the initial EC image for the elemi variant by copying the
volteer reference board EC files into a new directory named for
the variant.
(Auto-Generated by create_initial_ec_image.sh version 1.2.0).
BUG=b:169409487
BRANCH=none
TEST=make BOARD=elemi
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: I44ad440cbc63d05b3e14288a50fa499134fadfc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2431317
Reviewed-by: Keith Short <keithshort@chromium.org>
|