| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the interest of making long-term branch maintenance incur as little
technical debt on us as possible, we should not maintain any files on
the branch we are not actually using.
This has the added effect of making it extremely clear when merging CLs
from the main branch when changes have the possibility to affect us.
The follow-on CL adds a convenience script to actually pull updates from
the main branch and generate a CL for the update.
BUG=b:204206272
BRANCH=ish
TEST=make BOARD=arcada_ish && make BOARD=drallion_ish
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I17e4694c38219b5a0823e0a3e55a28d1348f4b18
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3262038
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the use of adc_chip.h where adc.h is also used. In this
case, adc_chip.h is redundant.
BRANCH=none
BUG=b:181271666
TEST=buildall passes
Change-Id: Id7baf9aef949447a4d47934242f9bae97c971262
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3120317
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, only the virtual mux driver uses the mux ACK feature, but the
actual wait for the host command ACK is a part of the usb_mux general
code. Generalize this mux ACK wait so it's available if needed in the
future for more muxes.
Additionally, moving this wait out of the mux set will allow us to lock
the muxes intelligently between tasks, without keeping the muxes locked
during the inactive ACK wait.
BRANCH=None
BUG=b:172222942,b:186777984
TEST=tast typec.Mode*.manual on voxel
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I61a043425a482cc6f3170548c888d91ec20c2a82
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3078411
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use SSFC bits 6-7 to choose which secondary MUX is used.
BUG=b:192523667
BRANCH=zork
TEST=After setting SSFC to 0x80 on the DUT with PS8818,
the typec on DB works fine.
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Change-Id: I8a66098d1e9b947acfb26b78f0cec7f835bf4c40
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3000894
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add keyboard_factory_scan_pins and keyboard_factory_scan_pins_used to
keyboard_scan header so they do not need to be declared as extern by
individual boards. These constants need to be defined if
CONFIG_KEYBOARD_FACTORY_TEST is enabled.
BUG=None
TEST=Build
BRANCH=None
Change-Id: I1a100f626b3cea251ca72703d17b2d27db0f8f28
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3053101
Commit-Queue: Diana Z <dzigterman@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
connector-to-GPIO map:
{-1, -1}, {0, 5}, {1, 1}, {1, 0}, {0, 6},
{0, 7}, {-1, -1}, {-1, -1}, {1, 4}, {1, 3},
{-1, -1}, {1, 6}, {1, 7}, {3, 1}, {2, 0},
{1, 5}, {2, 6}, {2, 7}, {2, 1}, {2, 4},
{2, 5}, {1, 2}, {2, 3},{2, 2}, {3, 0},
{-1, -1}, {0, 4}, {-1, -1}, {8, 2}, {-1, -1},
{-1, -1},
BUG=b:191931746
BRANCH=zork
TEST=`ectool kbfactorytest` PASS.
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Change-Id: I0354835b8b606fe735b1cef433e6e07bba658249
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2929062
Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, all boards using the LED On/Off module have battery LEDs.
However, if we'd like to expand support to Chromeboxes then the battery
LED must become optional.
BRANCH=None
BUG=b:185508707
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ieae098829ebe6c8b103f23d5abdbf70e7bcbdf2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2832692
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the "thermistor.h" header to the include/driver/temp_sensor
directory. It is used by the Zephyr shim, so the change is useful to
include the header.
BUG=b:180403276
BRANCH=none
TEST=make buildall
Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com>
Change-Id: I0e83df97e50a3b324440b65ddb900ddf135f2439
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2843323
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use board-specific override files when generating VIFs for boards.
BUG=b:172276715
TEST=make buildall
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: I197365018ceb8197c22d631cebf4cbce1c0119f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2785506
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
C++ doesn't allow forward enum references.
BRANCH=none
BUG=b:144959033
TEST=make buildall
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I7e1f8890005e05136eeb4e5084505988dbbb15b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2740566
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ifdef HAS_TASK_MOTIONSENSE is only necessary for board that may not
have sensor. Only oak board may be compiled without the sensor stack.
BUG=none
BRANCH=none
TEST=compile.
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Change-Id: I7d8e4ff1a647e73251b91a185780025bfae78187
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2693915
Reviewed-by: Alexandru M Stan <amstan@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For accelerometer presented to Android, set default range to 4g.
Required by Android CDD - Section 7.3.1 - Paragraph C.1.4.
mems_setup can correct it, but it is cleaner if the default setting is
right.
BUG=b:144004449
BRANCH=none
TEST=compile
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Change-Id: I781eafc003823e2595d46d7170f717aaee08dc6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2657956
Reviewed-by: Alexandru M Stan <amstan@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove thermal_cpu. Not using TEMP_SENSOR_CPU to do thermal shutdown
and throttle ap.
BUG=b:153937447
BRANCH=zork
TEST=none
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Change-Id: Ie953c2feddb6eed42002e408d9edd970af1e34bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2639000
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GPIO-only MKBP only works when the AP is awake; we need to use
GPIO_AND_HOST_EVENT in order to support waking the AP in response to
MKBP events; in particular DP_ALT_MODE_ENTERED.
We also configure the MKBP wakeup mask so powerd can apply configuration
at runtime per chromeos-config: if no mask is configured then the
hostcmd to set the wakeup mask is not included in the firmware.
Wake on MKBP (and thus wake on DP) also requires AP firmware support.
https://review.coreboot.org/c/coreboot/+/48844 implements it for Zork.
BUG=b:174121852
TEST=Generating DP event via EC console on morphius with patched AP
firmware successfully wakes system from S3.
BRANCH=zork
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Change-Id: Ifb193399259674da17694aac5213bfd1f189ee59
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2607026
Reviewed-by: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For the definition of orientation is different between BMI160
and ICM40608 so add base_standard_ref_1 for ICM40608.
BUG=b:175169469
BRANCH=zork
TEST="ectool motionsense" shows correct Senser 1 data.
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Change-Id: I81716bf44f80f7939cce2a8501a3b52a0295cc05
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2594729
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add new ec_cfg_base_gyro_sensor_type "BASE_GYRO_ICM426XX = 3" for
support ICM-426XX on ezkinil.
BUG=b:175169469
BRANCH=zork
TEST=Write fw_config bit15-11 to 011b on the Ezkinil DUT with ICM chip.
Check the motion function is workable.
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Change-Id: If72746a1b7b44714aa39f7d48fd94d0c63d4f876
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2581122
Reviewed-by: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch update pi3hdx1204 eq setting,
berknip use 0xAA on byte5, and keep other variant 0xFF.
BUG=b:170708732
BRANCH=zork
TEST=read back eq setting from i2c.
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: I543f1137dc63b5494cc2e170fa4da025d7fef03b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2452009
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Control the fan speed by the temperature read by TEMP_SENSOR_SOC.
thermal_soc: fan_off = 32C, fan_on = 75C
fan_rpm: min = 3200, start = 3200, max = 6000
fan_table:
on off rpm
0 1(32C) 0
9(36C) 1(32C) 3200
21(41C) 16(35C) 3500
28(44C) 29(39C) 3900
37(48C) 42(43C) 4200
47(52C) 55(47C) 4600
56(56C) 68(51C) 5100
72(63C) 84(58C) 5500
BUG=b:153937447
BRANCH=zork
TEST=none
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Change-Id: I97195bb027d292b0240bdcc140393f87399e7a55
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2528729
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL move HDMI retimer(pi3hdx1204) setting to variant.
BUG=none
BRANCH=zork
TEST=make buildall
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: I5b50058c44ccb9fd5d9403939d5f4ea9a9670b7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2421391
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Setting HDMI_DATA_EN_DB low to make PI3HDX1204 go into power
down mode before pi3hdx1204_enable would got "pi3hdx1204
enable failed: 1" error.
BUG=none
BRANCH=zork
TEST=EC log doesn't show "pi3hdx1204 enable failed: 1" while
the DUT is entering S3.
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Change-Id: I1a54264ebe515acd8ff334fee47f7e46ddffdd4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2397935
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We would prefer to use CONFIG_CHARGE_RAMP_HW to enable legacy BC1.2
charging but that feature of ISL9241 is broken (b/160287056) so we
have to use CONFIG_CHARGE_RAMP_SW instead.
BUG=b:163864475,b:167257846
BRANCH=none
TEST=ramp up to 1.5A from legacy charger
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Change-Id: I636e2bd6db57c11ce6da24cc2417b35bb59c6d07
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2388081
Reviewed-by: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 8a768a06bc876f83427691d27b4e572418406875.
Reason for revert: The code as it stands breaks PD charging,
so no battery charging is functional when this is landed.
BUG=b:163864475,b:167257846
BRANCH=none
TEST=verify Zork PD charging works
Change-Id: I2c8b006e6add2e328840647367068449be28f7a6
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2386024
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We would prefer to use CONFIG_CHARGE_RAMP_HW to enable legacy BC1.2
charging but that feature of ISL9241 is broken (b/160287056) so we
have to use CONFIG_CHARGE_RAMP_SW instead.
BUG=b:163864475
BRANCH=zork
TEST=ramp up to 1.5A from legacy charger
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Iec0a4b82f42fd388d738362ce9a8de4d31c61054
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2382635
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix mistake in CL:2375803. HDMI_DATA_EN_DB is needed for MST hub on
OPT3 DB, in addition to pi3hdx1204 retimer on OPT1 DB.
BUG=b:158266701
BRANCH=zork
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Ie97f6a59628177542b890bcd4327df1e0ffdc083
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2382631
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid setting IOEX_HDMI_DATA_EN_DB high when power is off.
This prevents leakage in S3 and S5.
BUG=b:158266701
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I9f1c02b3631887661905be1e65be5d4d8b9f8e66
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2375803
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HDMI EA 7-3 test fail because HDMI_DATA_EN_DB floating in S3/S5
cause 0.7V leakage. Therefore, pull HDMI_DATA_EN_DB low at suspend
and pull high when the system enter S0.
BUG=b:158062907
BRANCH=zork
TEST=make sure that fix 0.7V leakage
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Change-Id: I6e3e0f26f63a707670c270c522c3598dc0104a13
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2373851
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I9eac47383695156ca0d222eb75f75492065720b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2364112
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:162907613
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Iddbba7d7955f252cacf666528195bbfc7d9718e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2365633
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change to use CBI board_version for I2C_PORT_CHARGER_V0 instead
of probing I2C.
BUG=b:155214765
BRANCH=none
TEST=boot to OS
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Id3e9d874439277af4d1c88acd6ab40a6bbea73ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2343742
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IOEX01 USB_C1_POWER_SWITCH_ID check which ppc chip is supported.
0 for NX20P3483UK
1 for AOZ1380DI
IOEX10 USB_C1_PPC_ILIM_3A_EN to set vbus source current limit 3A
BUG=b:159634750
BRANCH=none
TEST=make sure C1 ppc_config setup correctly on AOZ board.
USB_C1_PPC_ILIM_3A_EN change level as plugging device in/out
port 1.
Change-Id: I1211ba39a02b8e42488dc56f110bc736e66ff41d
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2253489
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch rename thermal sensor name by placement for morphius,
and move board_get_temp from baseboard to variant
BUG=b:162325433
BRANCH=none
TEST=verify that thermal sensor name change in EC console
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: I46dfe5c8ebef29ed6ee7fdf342cfad9d39fe6ca3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2325496
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some gpio changed on v3, we should use board_ver to check
which pin is supported on the board.
board_ver=2 board_ver=3
ioex c1 pin(1, 0) gpio pin(7, 5)
HDMI_CONN_HPD_3V3_DB DP1_HPD_EC_IN
Both are interrupt pin to detect HDMI insertion.
BUG=b:159188404
BRANCH=none
TEST=HDMI do work on both v2 and v3 board.
Change-Id: Ibe4da36b8399250b3ee688220509bec3f2daed13
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2301553
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Connect up USB_Cx_SBU_FAULT_ODL to pd_handle_overcurrent().
BUG=b:138600586 b:157058003
BRANCH=none
TEST=USB-C sink and source still works,
forcing USB_Cx_SBU_FAULT_ODL low is reported as fault.
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I59ae65eed169fc5e18f72539a68017bb73c7d93e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2293102
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove CONFIG_SYSTEM_UNLOCKED and CONFIG_I2C_DEBUG from all
Zork boards.
BUG=b:138601010
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I846335e8402b719bbbf5711aa805b727a0902919
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2288153
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove USB-A1 and correct FW_CONFIG.
BUG=b:160293750
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I6e415c3dac85905af812ac5ce26ad3bbf4fcf869
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2277212
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch update S0_PWROK_OD for schematic change.
BUG=b:150278507, b:152841287
BRANCH=none
TEST=make buildall, verify EC code can power on rework MB.
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: Iaf8f2458c2dfe49f40eada8dced1febe2c4c4687
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2255826
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org>
Tested-by: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
3AXIS_INT_L is unused (we use polling not interrupt for reading lid
accel), and defaults to low, so change to GPIO_PULL_DOWN for a small
power saving.
BUG=b:157243373
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I7f5f3af692d0958237f9876ac9ad65fdd3696d1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2253059
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are some differences with temperature sensors for each zork variant.
This patch move temperature sensors definition to board variant.
BUG=b:157711232
BRANCH=none
TEST=Verified console "temps" can read temperature.
Build all zork board variant.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: Ib109ea5adc98e6b6825f8c91db19911dc682a52e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2227787
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org>
Tested-by: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disable PI3HDX1204 when HDMI didn't connect for saving 1W in S0.
BUG=b:158136599
BRANCH=none
TEST=check pi3hdx1204 register setting is correct.
Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com>
Change-Id: I9170cf56b34d71abcdd430bd7d8d7f3839de2558
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2234046
Reviewed-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Vincent Wang <vwang@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This new signal is set to power PI3HDX1204 HDMI retimer IC
on/off in S0/S3.
BUG=b:158266701
BRANCH=none
TEST=make buildall -j
Change-Id: Ie3ee0311553b587fb8686e5300f7a494b8571be3
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2234043
Reviewed-by: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rename GPIO F4: DP1_HPD -> EC_DP1_HPD
remove IOEX 10 HDMI_CONN_HPD_3V3_DB
add GPIO 75: DP1_HPD_EC_IN
move hdmi_hpd_interrupt and hdmi_hpd_handler from baseboard to board
BUG=b:152512560, b:153397667, b:155797182
BRANCH=none
TEST=make buildall -j
Change-Id: I5cdbb42a8284c85104dbbbe7b3d557d51a11a074
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2224693
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org>
Tested-by: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Align all Zork devices on using I2C control of PS8743 mux mode, and stop
using IOEX_USB_C1_DATA_EN signal/pin. This matches what we were already
doing for Dalboz, and gives power savings in both S0 and S3 when nothing
is plugged in and mux is set to none.
BUG=b:157951317
BRANCH=none
TEST=external display and i2ctrace on ezkinil
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Id1c8b172a99bb25bed8b57e90686d933447432f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2227589
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix from CL:2209659 for Trembyle is also needed for Dalboz and Ezkinil.
BUG=b:156696798
BRANCH=none
TEST=USB-A still works
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Id62bb9668042642eb3b0a64798a2aa4c763a604d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2227590
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The PDCMD task is only pulling interrupts from the TCPCs on most boards,
which is unnecessary since the PD_INT tasks handle this job now.
Remove it from any boards using the PD_INT command which are not using
the older CONFIG_HOSTCMD_PD functionality (ex. samus, oak).
Located boards using:
find -name "ec.tasklist" | xargs grep -l PD_INT | xargs grep PDCMD
BRANCH=None
BUG=b:154959596
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I29be8ab1d7a2616603fb55236aed4329ed8654f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2208221
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Setting lower input current limit to make sure safety
confirm test pass.
BUG=b:156962946
BRANCH=none
TEST=make buildall
Change-Id: I3afa3c70076fcff319e47c08901616916c0a467b
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2172276
Reviewed-by: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Power LED behavior
Charge Amber on (S0/S3/S5)
Full charge Blue on (S0/S3/S5)
Discharge in S3 Amber on 1sec off 3sec
Discharge in S5 Off
Error Amber on 1sec off 1sec
Discharge in S0 Blue on
BUG=b:156553303
BRANCH=none
TEST=check the led behavior meeting the spec.
Change-Id: I524734fa30cbe0df785654a80118a534fbeeaf5d
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2200836
Reviewed-by: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use FW_CONFIG to only enable IOEX_HDMI_CONN_HPD_3V3_DB interrupt
when appropriate.
BUG=b:156046102
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Ib12943e6ebbbd9af9c46ac548921aea5eb96f504
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2195187
Reviewed-by: David Huang <david.huang@quanta.corp-partner.google.com>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move mst_hpd_interrupt() out of variant_trembyle.c into individual
boards. Use FW_CONFIG to only enable IOEX_MST_HPD_OUT interrupt
when appropriate.
BUG=b:156046102
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I3f188088254208f01aea2094b7f2b57590b0d91b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2195186
Reviewed-by: David Huang <david.huang@quanta.corp-partner.google.com>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
EFS v.1 allowed Chromeboxes to verify RW without AP. EFS v.2 will bring
the benefits to Chromebooks, which are:
- Immediate boot on deeply discharged battery.
- Faster charge in S5/G3.
- Reduce RO dependency. Allow more code to be updated by AU.
- Remove jumptag and workarounds needed for late sysjump.
- Can support recovery mode regardless of battery condition.
Major improvements over v.1 are:
- No A/B slot required.
- No signature in RW or public key in RO.
- Rollback-attack protection.
- Verifies only used part of RW (instead of whole RW section)
EC-Cr50 communication is based on the shared UART (go/ec-cr50-comm).
EFS2 is documented in go/ec-efs2.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
BUG=b/146393197
BRANCH=none
TEST=Verify Trembyle boots and sync EC RW.
AP FW: 13066.0.0
Cr50 FW: 0.6.1
Change-Id: Ib3c5b23817938ccd3a90c90cede8aeea26b37e45
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2171575
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Auto-Submit: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Power the PI3HDX1204 HDMI retimer on at resume and off at suspend.
BUG=b:154874071
BRANCH=none
TEST=HDMI still works
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I1753177db4b99d2c4a6af0720ace70ad3ba7f530
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2181794
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|