| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The base gyro and base accel are the same chip and they are on in S3 and
S0 and off in S5. Update the active_make for all other octopus boards
that haven't already updated it.
BRANCH=none
BUG=none
TEST=build and sensors still work.
Change-Id: I96004ba0b20dd9366848bb2fe610c250e07850aa
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1302833
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Karthikeyan Ramasubramanian <kramasub@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds a call to the C0 TCPC reset for standalone TCPC boards
which have that pin hooked up in hardware, and adds the GPIO as
unimplemented for boards which do not have this yet.
BRANCH=None
BUG=b:112756630
TEST=Added a log print and rebooted EC on bobba to verify TCPC C0 reset,
then verified that charging on C0 worked. Also imaged yorp proto 2 and
rebooted, verifying C0 reset was not attempted.
Change-Id: I615861f0d9ce9b5a89692e3982ed2e19c7e0b237
Signed-off-by: Diana Z <dzigterman@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1257647
Reviewed-by: Jett Rink <jettrink@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For all NPCX boards, remove the CONFIG_SYSTEM_UNLOCKED option. The main
affect of this will be to prevent PD communication in RO. We are
starting to get into factory test that want to verify this behavior. As a
developer, one must remember to jump to RW before PD will negotiate.
BRANCH=none
BUG=b:117109816
TEST=flash on fleex and RO did not negotiate (when WP was asserted)
but RW did.
Change-Id: I2df575baad95a334a4a57a9f81600fc039157fd5
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1258568
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Scott Collyer <scollyer@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flash amber led when the battery critical low and discharge.
BUG=b:109872754
BRANCH=none
TEST=Verify on Fleex will flash amber led when the battery critical
low and discharge.
Change-Id: Ia883ca179e868ef825879c6abe3681f1f7471288
Signed-off-by: matt_wang <matt_wang@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/1247722
Commit-Ready: Raymond Chou <raymond_chou@compal.corp-partner.google.com>
Tested-by: Matt Wang <matt_wang@compal.corp-partner.google.com>
Reviewed-by: Raymond Chou <raymond_chou@compal.corp-partner.google.com>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The MAX14637 BC 1.2 USB charger detection chip is functionally similar
to the bq24392 and can use the same driver. Rather than have 2 copies
of the same driver, or a generic named driver than can be used for
both chips, rename the existing bq24392 driver to max14637 as that's
the BC 1.2 chip that our current designs are using.
BUG=b:113267982
BRANCH=none
TEST=make -j buildall
Change-Id: I03cfb4918513d756c2a41341001a8162652a29b6
Signed-off-by: Scott Collyer <scollyer@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1250031
Commit-Ready: Scott Collyer <scollyer@chromium.org>
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds CCD_MODE_ODL as an input for all octopus boards so it
will be present in the "gpioget" output for debugging.
BRANCH=None
BUG=b:116849648
TEST=builds, confirmed net showed up on bip and yorp proto 2
Change-Id: I0da194e433444f160f10573c27e5e463694adf38
Signed-off-by: Diana Z <dzigterman@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1254923
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Justin TerAvest <teravest@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Meep and Mimrock use same mother board,
Mimrock is clamshell sku only have Charge LED.
To meet LED spec:
System without Power LED, Suspend/S0ix without charge
blink White on Charge LED(1 sec on, 1 sec off).
BUG=none
BRANCH=none
TEST=manual
Set cbi sku id to clamshell sku,
Check Charge LED will blink(1 sec on, 1 sec off),
when system is Suspend/S0ix without charge.
Change-Id: Ib443d6176d929aad4b65c1cb0d4b40c102e6f67e
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/1226830
Reviewed-by: Jett Rink <jettrink@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All NPCX variants support PSL mode in hardware now; enable this at the
baseboard level.
This is adding support for Bobba; other boards are unaffected
BRANCH=none
BUG=b:115677776
TEST=bobba goes into PSL
Change-Id: I38974371b101c42841e4f11ba72b466415c754d9
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1227050
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Justin TerAvest <teravest@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All base sensor are off during S5 and turn on in S4. Update the active
mask to reflect this which also ensure that the sensor is getting
initialized at the correct time.
BRANCH=none
BUG=b:115278651
TEST=fleex base sensor now works.
Change-Id: Id4b30fbab02dadf55ed0809fefef3938474fe818
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1222091
Commit-Ready: Matt Wang <matt_wang@compal.corp-partner.google.com>
Tested-by: Matt Wang <matt_wang@compal.corp-partner.google.com>
Reviewed-by: Justin TerAvest <teravest@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change enables PSL hibernate mode on fleex by:
1. Selecting CONFIG_HIBERNATE_PSL
2. Configure alternate mode on PSL pins
3. Configuring EC_RST_ODL for wake
BUG=b:115660922
BRANCH=None
TEST=make -j buildall
Change-Id: Ic0e31f7fd1cc18061a819a61a5d5a8badcaed2ab
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1225351
Commit-Ready: Jett Rink <jettrink@chromium.org>
Tested-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Naming of many vector types and matrix types are not clear enough.
For example, we have:
vector_3_t, which is a vector of three int.
vec3_t, which is a vector of three float.
size4_t, which is a vector of four size_t.
mat33_t, which is a 3x3 matrix of float.
matrix_3x3_t, which is a 3x3 matrix of fixed point.
Besides, we have types like int8_t, uint16_t types.
To clearly distinguished types, the CL propose to,
For vector types, naming should be `$type + 'v' + $num + '_t'`:
vector_3_t becomes intv3_t
vec3_t becomes floatv3_t
vector 4 of uint16_t becomes uint16v4_t (which doesn't exist yet)
For matrix types, naming should be `mat$N$N_` + $type + '_t', where $N is the
matrix size:
matrix_3x3_t becomes mat33_fp_t # fp: fixed point
mat33_t becomes mat33_float_t
TEST=make buildall -j
BUG=b:114662791
Change-Id: I51d88d44252184e4b7b3564236833b0b892edc39
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1215449
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=b:113837268
TEST=verified that free magnet cannot put a clamshell SKU into tablet mode
Change-Id: I5d69ede2da04cb5d067b6ae5a483323054b584ab
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1204452
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See go/usb-pd-slow-response-time for more information
BRANCH=none
BUG=b:112088135
TEST=CL stack on fleex and bobba consistently meet PD timing spec
Change-Id: I9eabf8de8d866f5a0af7d1daba5ab585b418d26c
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1185729
Reviewed-by: Jonathan Brandmeyer <jbrandmeyer@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All of the octopus board define the table mode option the same, so move
them into baseboard.
BRANCH=none
BUG=none
TEST=fleex still works
Change-Id: Ibed874a609a2e5947d7aee39f915dc3046a0cc19
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1204700
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
change disable the keyboard for convertible
Get the motion sensor count by SKU
motion_sensor_count on clamshells is 0.
motion_sensor_count on convertibles is 2.
lid_angle_peripheral_enable() function disable
the keyboard for convertible systems.
BUG=b:112286331
BRANCH=none
TEST=Manual
change SKUID to 0x21 for convertible and verified the motion sensor
count and that the motion senors were initialized in the EC console log.
change SKUID to 0x01 for clamshell and the motion senors were
not initialized in the EC console log.
Change-Id: Ic9d6c910c9e56479414d30f1e2c53d73515842af
Signed-off-by: elthanhuang <elthan_huang@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/1192903
Commit-Ready: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
Tested-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
status register and data
Modify LGC/BYD board_battery_info of
shipping mode reg_addr and LGC/BYD/Simplo
FET status of reg_addr/reg_mask
BUG=b:112322236,b:112237278
BRANCH=none
TEST=Use "ectool batterycutoff", system can shutdown.
Plugin AC can power on system and battery return
BATTERY_NOT_DISCONNECTED.
Change-Id: I0d7a2b2c9d27a058b67f7b48970aaaab2ebee9b8
Signed-off-by: elthanhuang <elthan_huang@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/1170669
Commit-Ready: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
Tested-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Scott Collyer <scollyer@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change sets GPIO83 to the new USB_C0_PD_RST. The GPIO flags are
set according to whether the board is a proto (where it is acting as
USB_OTG and needs to be open drain) or EVT (where it is an active-high
signal). This also adds CAM_SOC_EC_SYNC as an input for now.
BRANCH=None
BUG=b:112458646
TEST=Loaded onto fleex proto to verify proto board was detected and
USB_OTG set to open drain
Change-Id: Iffa4762f46d545a0431a27f2c1893f219695d367
Signed-off-by: Diana Z <dzigterman@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1180354
Commit-Ready: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable adc vbus sensing
ADC CH9 read real USB_PD_PORT_ANX7447 input voltage
ADC CH4 read real USB_PD_PORT_PS8751 input voltage
BUG=b:112576391
BRANCH=none
TEST=Excute "ectool usbpdpower" to check
SNK Charger PD voltage.
Change-Id: Ia7ef58905219e0392e4ca4fba4694c144741b0a8
Signed-off-by: elthanhuang <elthan_huang@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/1177528
Commit-Ready: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
Tested-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
Reviewed-by: Jett Rink <jettrink@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL doesn't change any functionality, but renames the driver from
3483 to 348x. The motivation for this is that we need to support the
NX20P3481 PPC as well. Those chips use the same registers, but the
3481 adds FRS support and sink/source control is done via I2C writes
instead of gpio controls.
Because the chips are slighlty different the config option
CONFIG_USBC_PPC_NX20P3483 needs to remain.
BUG=b:111281797
BRANCH=none
TEST=make -j buildall
Change-Id: Ie1085140eb2ef23c0b6e1a79a6f2d7f823326c6d
Signed-off-by: Scott Collyer <scollyer@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1176382
Commit-Ready: Scott Collyer <scollyer@chromium.org>
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fleex should blink its amber LED if the battery is critically low and
charging (less than 10%)
BRANCH=None
BUG=b:109872754
TEST=Let fleex's battery deplete to critical level, plugged in charger
to verify it blinked the amber LED until charged past critical level
Change-Id: I1f9295c37cc10b7173d442c005bd53e015d67e38
Signed-off-by: Diana Z <dzigterman@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1171515
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and initial x,y,z-axis direction of lid and base g-sensor
Enable CONFIG_ACCEL_LIS2DE and motion_sensors struct of
LID_ACCEL meet LIS2ED12 accelerometer.
Modify standard reference frame to fit Fleex shell design.
(base_standard_ref and lid_standard_ref)
BUG=b:112399626
BRANCH=none
TEST=Use "ectool motionsense" to check sensor0/1/2 value.
Use "watch -n 1 ectool motionsense" to check x,y,z-axis.
1. When x-axis face up, get x value of sensor0 and sensor1 more than 10000
2. When y-axis face up, get y value of sensor0 and sensor1 more than 10000
3. When z-axis face up, get z value of sensor0 and sensor1 more than 10000
Change-Id: I1f4409ef634ed4849aad7017cad598588b0637d9
Signed-off-by: elthanhuang <elthan_huang@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/1169040
Commit-Ready: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
Tested-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bip board has had issues with running out of task space in the
USB_CHG_P[0,1] tasks when it runs into I2C errors and needs to run
resets. Performing a full stack analysis should happen when the
firmware branches for octopus, but for now this change increases the
stack sizes for all of the USB_CHG_P[0,1] tasks.
BRANCH=None
BUG=b:111840286
TEST=builds, bip no longer hit stack overflows with the larger space
during i2c resets
Change-Id: Ib10e052bb89202cbedfe23345c8335f1e0a8e16b
Signed-off-by: Diana Z <dzigterman@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1167653
Reviewed-by: Jett Rink <jettrink@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds the charger LED behavior for fleex. Since fleex isn't
actually using a power LED, removed the GPIO referencing it.
BRANCH=none
BUG=b:109872754
TEST=ran through all charger and power states on the fleex to confirm
correct LED behavior
Change-Id: Ia0952587075026c6e2cbe20dcd7ccc6746442df1
Signed-off-by: Diana Z <dzigterman@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1159355
Reviewed-by: Jett Rink <jettrink@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch makes EC configure battery parameters differently based
on manufacturer name
BUG=b:111330630,b:110076440
BRANCH=none
TEST=Verify BYD/LGC/Simplo battery can be found via EC console
Change-Id: Ic963dd203d89371dd6915992157c51398cf700d6
Signed-off-by: elthanhuang <elthan_huang@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/1148023
Commit-Ready: Jett Rink <jettrink@chromium.org>
Tested-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
Reviewed-by: Raymond Chou <raymond_chou@compal.corp-partner.google.com>
Reviewed-by: Jett Rink <jettrink@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add define EC_VOLUP_BTN and EC_VOLDN_BTN
in gpio.inc and enable CONFIG_VOLUME_BUTTONS
function in board.h
BUG=b:111670874
BRANCH=none
TEST=Verify volume control bar can be pop
up and down.
Change-Id: I0ef527b0023238c080c130ad86f98b88b03cfec2
Signed-off-by: Raymond Chou <raymond_chou@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/1145149
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
USB2_OTG_ID is 3.3V pin on the EC whereas the SoC expects
USB2_DUALROLE and USB2_VBUS_SNS to be 1.8V. Since there is an
internal pull-up on USB2_DUALROLE from the SoC side, this change
configures USB2_OTG_ID to be open drain so that it is actively
driven from the EC when it wants to pull it low. Otherwise, the
pin would be tri-stated from the EC side allowing it to be pulled
up to 1.8V because of the SoC internal pull-up.
BUG=None
BRANCH=None
TEST=None
Change-Id: Icfe9f4ca6982d70f0e42bee589b68b7c4b768d9f
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1140501
Commit-Ready: Furquan Shaikh <furquan@chromium.org>
Tested-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
accelgyro_lsm6dsm driver use lsm6dsm_data as its driver specific
data type rather than stprivate_data. Wrong data type will lead
to random corrupted runtime data.
Signed-off-by: Paul Ma <magf@bitland.corp-partner.google.com>
BRANCH=none
BUG=b:110013316
TEST=make buildall -j
Change-Id: I50e0da293921c2662e97aa6f47c83519609186b5
Reviewed-on: https://chromium-review.googlesource.com/1105797
Commit-Ready: Paul Ma <magf@bitland.corp-partner.google.com>
Tested-by: Paul Ma <magf@bitland.corp-partner.google.com>
Reviewed-by: Jett Rink <jettrink@chromium.org>
|
|
The is based off of current yorp (V1) on ToT without the LED
implementation.
BRANCH=none
BUG=b:110085182
TEST=builds
Change-Id: Ic95fdf19be60637cf9effa8b34cb4659ad45952a
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1098020
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Justin TerAvest <teravest@chromium.org>
|