| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the interest of making long-term branch maintenance incur as little
technical debt on us as possible, we should not maintain any files on
the branch we are not actually using.
This has the added effect of making it extremely clear when merging CLs
from the main branch when changes have the possibility to affect us.
The follow-on CL adds a convenience script to actually pull updates from
the main branch and generate a CL for the update.
BUG=b:204206272
BRANCH=ish
TEST=make BOARD=arcada_ish && make BOARD=drallion_ish
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I17e4694c38219b5a0823e0a3e55a28d1348f4b18
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3262038
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the LED on/off module towards using a more flexible LED support
approach. Define a weak power LED table and setter for boards to
override when needed. Note that during run-time these functions will
not get called since led_auto_control_is_enabled() will return false for
nonexistent LEDs.
This consumes an average of 165 additional bytes of flash space on
boards which do not use a power LED.
BRANCH=None
BUG=b:185508707
TEST=make -j buildall, load on guybrush (battery LED only) and confirm
no errors are seen. Load on Boten (both LEDs) and confirm behavior
appears normal
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Iaa1e22a7f5d8be39eb8792ee13d358087d7f7482
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2832691
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Almost every relevant board copy-pastes 5000 us. Make that the default
and get rid of the redundant definitions. This is the approximate result
of this command:
find . -type f -name *.h | xargs sed -i -E \
'/#define CONFIG_USBC_VCONN_SWAP_DELAY_US[[:space:]]+5000[[:space:]]/d'
BUG=b:144165680
TEST=make buildall
BRANCH=none
Change-Id: Ife86f9752971abcd7ab5ad5a5e607eb2ccbde2ba
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2628132
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace PD_VCONN_SWAP_DELAY with CONFIG_USBC_VCONN_SWAP_DELAY_US. This
is the approximate result of the following command, run from
platform/ec:
find . -type f -\( -name '*.c' -o -name '*.h' -\) | \
xargs sed -iE 's/PD_VCONN_SWAP_DELAY/CONFIG_USBC_VCONN_SWAP_DELAY/g'
Fix some latent formatting errors in usb_pd_protocol.c, because they
were preventing pre-upload hooks from passing.
BUG=b:144165680
TEST=make buildall
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: Icaf3b309c08fdcd162e960cf5dc88185016b5d2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2628131
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the DPM will be handling source-out decisions for TCPMv2,
remove references to its old configuration options from TCPMv2 boards in
order to avoid any confusion as to what code is running now. Also
remove the charge manager notifications of sink attach/detach since the
policy is being centralized into the DPM.
Note that the previous configuration options only ever allocated one 3.0
A port, and so the default number of 3.0 A ports has been set to 1.
BRANCH=None
BUG=b:168862110,b:141690755
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ie452e3da32b04226503539daa67b6b9f4a58aa58
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2597431
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To support USB4, source a total of 6A on the type-C ports. This
ensures that if the first device requests 3A (15W), the chromebook
continues to source 3A even after a second device is connected.
BUG=none
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I22bd1f0cd645b74587479ee4b18181ef82ffcb87
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2533492
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The TCSS port mapping is not used by the EC and the higher layers no
longer query the EC for this mapping. We can remove this feature and
disable CONFIG_INTEL_VIRTUAL_MUX which was added to enable it.
BRANCH=none
BUG=b:153941950
TEST=buildall passes
Change-Id: I2d7f51212f3e64d74827d7f82654eb93534b8db4
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2427632
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename CONFIG_I2C_CONTROLLER and related comments.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ied6a1829bf54a5c9a32e6772982a4b8aa31aaf23
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2518659
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 6ed9b65ae38977118f0d5f02d6f5c61da23c5f24.
Reason for revert: Historically, Octopus variants used the baseboard
VID and PID.
Original change's description:
> volteer: Move USB PID to board files
>
> Add TODOs to update variants boards.
>
> BUG=none
> TEST=make buildall
> BRANCH=none
>
> Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
> Change-Id: If0d8d0dd544c06114f355dcf281b2841a8397aee
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2417348
> Reviewed-by: Keith Short <keithshort@chromium.org>
BUG=b:168826898,b:168827570,b:168827133,b:168827128,b:168827420
BUG=b:168827418,b:168826886,b:168826868,b:168827029,b:168826914
Change-Id: I5b9b1cee25e34a4b922fd604b49deabc9591b4e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2431687
Tested-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-by: YH Lin <yueherngl@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add TODOs to update variants boards.
BUG=none
TEST=make buildall
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: If0d8d0dd544c06114f355dcf281b2841a8397aee
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2417348
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The charging current value needs to be reduced by half.
BUG=b:158257062
BRANCH=none
TEST=halvor test
Change-Id: Iefa736ffbbe9a4d6893682c10cc65e26c9022b0f
Signed-off-by: Samsp_Liu <Samsp_Liu@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2311999
Tested-by: SamSP Liu <samsp_liu@compal.corp-partner.google.com>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: SamSP Liu <samsp_liu@compal.corp-partner.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The PD function can be enabled.
BUG=b:153705222
BRANCH=none
TEST=Enable Halvor PD Port 0,Port 1 and Port 2
Change-Id: Id171e7c9f900098b2b727e4f69479ee49ea995b3
Signed-off-by: Samsp_Liu <Samsp_Liu@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2311998
Tested-by: SamSP Liu <samsp_liu@compal.corp-partner.google.com>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: SamSP Liu <samsp_liu@compal.corp-partner.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On halvor, we have a LED indicator with following:
Power LED:
System S0: White.
System S3: Blinking white (1 sec on, 1 sec off)
System S5/G3: Off.
Battery LED:
DC mode:
System S0: off.
System S5/G3: Off.
System battery low: Blinking Amber (1 sec on, 1 sec off)
AC mode:
Charging: Amber.
Full charged: White.
BUG=b/166057836
BRANCH=none
TEST=halvor test
1. Check battery LED on full charging / charging / discharging.
2. Check power LED on s0 / suspend / s5.
3. Check "ectool led" command for battery and power LED control.
4. Check battery LED on low battery state.
Change-Id: Ie6d6661c2b249336798099679635682e43aff5f3
Signed-off-by: Samsp_Liu <Samsp_Liu@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2366418
Tested-by: SamSP Liu <samsp_liu@compal.corp-partner.google.com>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: SamSP Liu <samsp_liu@compal.corp-partner.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Separate tcpc_config from volteer baseboard to each
project board.
To meet different configurations on each board.
BUG=b:153705222
BRANCH=none
TEST=make buildall
Change-Id: Iea59518123a542ebe38be195eaf71b4a8f796550
Signed-off-by: Samsp_Liu <Samsp_Liu@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2342183
Tested-by: SamSP Liu <samsp_liu@compal.corp-partner.google.com>
Commit-Queue: Keith Short <keithshort@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch makes EC configure power parameters
BUG=b:159282888
BRANCH=none
TEST=halvor test
Change-Id: I3e890218e64811273ef393dcdf56f0eb2d045be6
Signed-off-by: Samsp_Liu <Samsp_Liu@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2348240
Reviewed-by: SamSP Liu <samsp_liu@compal.corp-partner.google.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
Tested-by: SamSP Liu <samsp_liu@compal.corp-partner.google.com>
Commit-Queue: SamSP Liu <samsp_liu@compal.corp-partner.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Separate CONFIG_CHARGER_SENSE_RESISTOR and
CONFIG_CHARGER_SENSE_RESISTOR_AC from volteer baseboard
to each project board.
To meet different configurations on each board.
BUG=b:158257062
BRANCH=none
TEST=make buildall
Change-Id: Ib8290bd54d45054b82d7849e84119d419cbc8586
Signed-off-by: Samsp_Liu <Samsp_Liu@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2346088
Tested-by: SamSP Liu <samsp_liu@compal.corp-partner.google.com>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: SamSP Liu <samsp_liu@compal.corp-partner.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Halvor support AEC new battery.
This patch makes EC configure battery parameters differently based
on manufacturer name.
BUG=b:162908664
BRANCH=none
TEST=Verify AEC battery can charge/discharge/cutoff.
Change-Id: I65fb9ab5ae0d13393d649d0a16f9fa714f9122b7
Signed-off-by: Samsp_Liu <Samsp_Liu@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2224682
Tested-by: SamSP Liu <samsp_liu@compal.corp-partner.google.com>
Reviewed-by: SamSP Liu <samsp_liu@compal.corp-partner.google.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: SamSP Liu <samsp_liu@compal.corp-partner.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Separate usb pd power config from volteer baseboard to each
project board.
To meet different configurations on each board.
BUG=b:159282888
BRANCH=none
TEST=halvor test
Change-Id: I5aba9c7c59ababd34e51906365b1ae2a28c256ea
Signed-off-by: Samsp_Liu <Samsp_Liu@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2312001
Tested-by: SamSP Liu <samsp_liu@compal.corp-partner.google.com>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The board/AP can handle power sequencing without EC intervention. This
support was already disabled by default in configuration.
BUG=b:143375057
TEST=make buildall
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: I4311b7b8d27dc8b6958a23f3a516f3407436f9b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2330571
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move ppc_chips[] to board for board customize.
BUG=b:151978872
BRANCH=master
TEST=check ppc init succeed and switch source/sink correct with type c
device.
Change-Id: I287bbe44b163d72c19a3764dca431c84d86bbdec
Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2275971
Commit-Queue: Keith Short <keithshort@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update Halvor USB daughterboard options to match project configuration.
BUG=b:155497872
BRANCH=none
TEST=make BOARD=halvor
Cq-Depend: chromium:2247617, chromium:2248239, chromium:2248240
Cq-Depend: chromium:2248241, chromium:2248242, chromium:2252484
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I3e0d0bcb00ba71cc9b7be6fa3944606b427cdc1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2248238
Reviewed-by: caveh jalali <caveh@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove VSYNC sensor support from all volteer boards.
BUG=b:146452722
BRANCH=none
TEST=make buildall
TEST=Boot Volteer, run "ectool motionsense"
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I1662f510901fb99a45999f46b854e7ceb3874f03
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2238671
Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Malefor board only support USB3, so turn off USB4 and Thunderbolt support.
BUG=b:153996396
BRANCH=none
TEST=male buildall
Signed-off-by: xiong.huang <xiong.huang@bitland.corp-partner.google.com>
Change-Id: Iff87d7cae7876656ac082cfe322dd63d87a74b50
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2167120
Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Considering the LED circuits for the derived boards differ significantly
from Volteer and every OEM would have different requirements for LED
behavior. So move the PWM configuration and LED support from baseboard
(volteer) to board (halvor, malefor and volteer), there will be happy to
redefine LED behavior in boards.
BUG=b:154447182
BRANCH=none
TEST=make buildall
Signed-off-by: xiong.huang <xiong.huang@bitland.corp-partner.google.com>
Change-Id: I578459d4dd75abce4eed83e1f69a14886bb6a0f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2156688
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because Halvor is support three USB-C
So add the 3rd USB-C GPIO and interrupt function
BUG=none
BRANCH=none
TEST=make BOARD=halvor
Change-Id: Ia4d4aa13f0a43f15f24d6d8321fd7a111fdb3ea5
Signed-off-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2148982
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Configure I2C pins and i2c_ports for Halvor
BUG=none
BRANCH=none
TEST=make buildall, make BOARD=halvor
Change-Id: Ie80723563e39af07907cca5d5a0fc50ec0851032
Signed-off-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2147765
Reviewed-by: Ruby Lee <ruby_lee@compal.corp-partner.google.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because the Halvor I2C bus setup is different than other Volteer boards
Use this change to move I2c configure from baseboard to variant.
BUG=none
BRANCH=none
TEST=make buildall
Change-Id: I3a5e0c885f2e0c609a2456c6b493af9e6ecee4f9
Signed-off-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2147760
Reviewed-by: Ruby Lee <ruby_lee@compal.corp-partner.google.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update GPIO to match schematic.
First pass at CONFIG_* definitions.
Just enough [base]board.c changes to build.
BUG=none
BRANCH=none
TEST=make BOARD=halvor
Change-Id: Ic5b48581b860833e6d9e74600f807b4875862ad4
Signed-off-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2120757
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL move fan configure from baseboard to variant.
BUG=none
BRANCH=none
TEST=make buildall
Change-Id: I5109a0b18e5e3f740db67c13cf6473ab2c926b42
Signed-off-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2142835
Reviewed-by: Ruby Lee <ruby_lee@compal.corp-partner.google.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Considering every OEM would have different requirements for the use of
sensors and sensors have kinds of models. So move sensors support from
baseboard (volteer) to board (halvor, malefor and volteer), there will
be happy to add/change sensors in boards.
BUG=b:150653745
BRANCH=none
TEST=make buildall
Signed-off-by: xiong.huang <xiong.huang@bitland.corp-partner.google.com>
Change-Id: Ib8d38c823b26a0b1b3838c6d72daf61a10bae680
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2120115
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
Create the initial EC image for the halvor variant of the
volteer baseboard by copying the baseboard EC files into a new
directory named for the variant.
(Auto-Generated by create_initial_ec_image.sh version 1.0.1).
BUG=b:151399850
BRANCH=none
TEST=make BOARD=halvor
Signed-off-by: Frank Wu <frank_wu@compal.corp-partner.google.com>
Change-Id: I550203d26368c96b1223e232b7430f0f7b2a5b79
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2109437
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Ruby Lee <ruby_lee@compal.corp-partner.google.com>
Tested-by: Ruby Lee <ruby_lee@compal.corp-partner.google.com>
Commit-Queue: Keith Short <keithshort@chromium.org>
|