summaryrefslogtreecommitdiff
path: root/board/jerry
Commit message (Collapse)AuthorAgeFilesLines
* jerry: Enable LTO to save spaceDouglas Anderson2019-10-081-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | We're outta space on jerry. Builders are failing. It seems like we can magically save space like CL:1663540 by turning on LTO. Let's do it! Before on my local build: *** 28 bytes in flash and 5380 bytes in RAM still available on jerry RO **** *** 4476 bytes in flash and 5380 bytes in RAM still available on jerry RW **** After on my local build: *** 3168 bytes in flash and 5448 bytes in RAM still available on jerry RO **** *** 7616 bytes in flash and 5448 bytes in RAM still available on jerry RW **** BRANCH=None BUG=chromium:1011621 TEST=See above Change-Id: I2de0e6474a6d561fa4c44cc12d904a7c6339712f Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1846231 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
* config: Merge CONFIG_CHARGER_V2 into CONFIG_CHARGERKeith Short2019-09-181-1/+0
| | | | | | | | | | | | | | | | For all boards that defined CONFIG_CHARGER, CONFIG_CHARGER_V2 is also defined. Remove references to CONFIG_CHARGER_V2 from board header files. Replace CONFIG_CHARGER_V2 in common C modules with CONFIG_CHARGER when appropriate. BUG=b:139699769 BRANCH=none TEST=make buildall -j Change-Id: I6b54baf4ad2406bbed629b6b272dad9ea6a81280 Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1789420 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* common: Add uptime host commandTom Hughes2019-09-031-0/+3
| | | | | | | | | | | | | | | | | | This moves the EC_CMD_GET_UPTIME_INFO command from behind the CONFIG_CMD_AP_RESET_LOG config in chipset.c into the generic common/uptime.c file, so that all boards in the codebase can use it. If CONFIG_CMD_AP_RESET_LOG is enabled, the "AP reset stats" will be filled. Otherwise, ap_reset_stats is a no-op and recent_ap_reset is filled with zero. BRANCH=none BUG=chromium:997314 TEST=cat /sys/kernel/debug/cros_fp/uptime Change-Id: I3b6f91b2dd22d3d55b707309ec1fdfd26d42fd70 Signed-off-by: Tom Hughes <tomhughes@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1769393 Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
* LICENSE: remove unnecessary (c) after CopyrightTom Hughes2019-06-196-6/+6
| | | | | | | | | | | | | | | | Ran the following command: git grep -l 'Copyright (c)' | \ xargs sed -i 's/Copyright (c)/Copyright/g' BRANCH=none BUG=none TEST=make buildall -j Change-Id: I6cc4a0f7e8b30d5b5f97d53c031c299f3e164ca7 Signed-off-by: Tom Hughes <tomhughes@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1663262 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* ec.tasklist: Consolidate duplicate commentsDaisuke Nojiri2019-04-081-9/+1
| | | | | | | | | | | | | | | | | | | | | | | It's simply a bad idea to describe a macro in multiple locations. It'll make it hard to change. It'll be difficult to keep all locations in sync. This patch replaces the comment duplicated in all ec.tasklist with a pointer to the CONFIG_TASK_LIST definition. The macro will be described in a single place (just like all/most other macros). Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> BUG=none BRANCH=none TEST=buildall Change-Id: Id658b9d68e742e4334c692b804d9c98c8de21313 Reviewed-on: https://chromium-review.googlesource.com/1551579 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* common: replace 1 << digits, with BIT(digits)Gwendal Grignou2019-03-261-2/+2
| | | | | | | | | | | | | | | | Requested for linux integration, use BIT instead of 1 << First step replace bit operation with operand containing only digits. Fix an error in motion_lid try to set bit 31 of a signed integer. BUG=None BRANCH=None TEST=compile Change-Id: Ie843611f2f68e241f0f40d4067f7ade726951d29 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1518659 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* mkbp_event,include/config.h: Clarify MKBP delivery method.Yilun Lin2019-03-071-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now we have two MKBP delivery methods: 1. define CONFIG_MKBP_USE_HOST_EVENT to notify via host event 2. undef CONFIG_MKBP_USE_HOST_EVENT to notify via GPIO interrupt It may become more complicated if new notification methods introduced. e.g.: mt_scp uses IPI, rather than host event and GPIO interrupt. This CL does: 1. add CONFIG_MKBP_USE_GPIO to explicilty declare that MKBP event are sent via GPIO interrupt. 2. CONFIG_MKBP_USE_CUSTOM for boards which have custmized methods. 3. Remove weak attribute in mkbp_set_host_active (which can be done with CONFIG_MKBP_USE_CUSTOM now. 4. Removes mkbp_set_host_active function in board Nocturne. It only deliver MKBP events through GPIO interrupt now. BRANCH=None BUG=b:120808999 TEST=grep -rn "CONFIG_MKBP_USE_GPIO\|EC_INT_L" board/ baseboard/ and see the result is reasonable: 1. EC_INT_L must be 1-to-1 mapped to define CONFIG_MKBP_USE_GPIO in every board, except that meep, yorp, ampton which are defined in baseboard octopus. 2. undef CONFIG_MKBP_USE_GPIO in bip and casta, which use host event, but also have baseboard octopus. Change-Id: I4af6110e4fd3c009968075c3623ef2d91cbd770b Signed-off-by: Yilun Lin <yllin@google.com> Reviewed-on: https://chromium-review.googlesource.com/1490794 Commit-Ready: Jett Rink <jettrink@chromium.org> Tested-by: Yilun Lin <yllin@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* Jerry: Remove keyboard console commandDaisuke Nojiri2018-11-081-0/+1
| | | | | | | | | | | | | | | | This patch removes keyboard console command to create space. Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> BUG=none BRANCH=none TEST=build Change-Id: Ie662ef7cf5d02b815a04283c11e883db2f78edcb Reviewed-on: https://chromium-review.googlesource.com/1313476 Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* power: Rename rockchip to rk3288Nicolas Boichat2018-06-071-1/+1
| | | | | | | | | | | | | Get rid of a TODO. BRANCH=none BUG=b:35569119 TEST=make buildall -j Change-Id: Ia918c90519220a348f8c65b6b6f14b6d3129a63a Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1090523 Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
* stm32: Fix bkpdata accountingShawn Nematbakhsh2018-01-301-0/+1
| | | | | | | | | | | | | | | | | | stm32f0 has 20 bytes (not 20 words) of VBAT-backed RAM. Make more efficient use of our limited storage to prevent trying to use storage that doesn't exist. BUG=b:71333840 BRANCH=None TEST=Negotiate PD, run "reboot" on scarlet EC console, verify reset path is taken in pd_partner_port_reset(). Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Change-Id: Ie4c303b74a1b82b84ec971cdcc19c2b21a0032e7 Reviewed-on: https://chromium-review.googlesource.com/885461 Commit-Ready: Shawn N <shawnn@chromium.org> Tested-by: Shawn N <shawnn@chromium.org> Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
* jerry: Use HOSTCMD_ALIGNED instead of GPIO_SHORTNAMESFurquan Shaikh2017-11-161-1/+1
| | | | | | | | | | | | | | | This is required to allow bumping up of host events to 64-bit by making space in the rodata. CL 770923 had initially used GPIO_SHORTNAMES, but HOSTCMD_ALIGNED seems to be a better option. BUG=b:69329196 BRANCH=None TEST=make -j buildall Change-Id: I63699f9cec244925c031d81f50889851c6da8b5c Signed-off-by: Furquan Shaikh <furquan@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/771931 Reviewed-by: Shawn N <shawnn@chromium.org>
* jerry: Enable CONFIG_COMMON_GPIO_SHORTNAMESFurquan Shaikh2017-11-151-0/+2
| | | | | | | | | | | | | Turn on CONFIG_COMMON_GPIO_SHORTNAMES to save some space in rodata. BUG=b:69329196 BRANCH=None TEST=make -j BOARD=jerry Change-Id: Ib1e4cb13c013cce7b0d6422b842ca47c0f4ff62c Signed-off-by: Furquan Shaikh <furquan@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/770923 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* power: Add flags parameter to power_signal_infoFurquan Shaikh2017-10-031-2/+2
| | | | | | | | | | | | | | | | | | | | | | Replace structure member "level" in power_signal_info with "flags". "level" has been used on all boards to indicate active-high or active-low levels. Addition of "flags" allows easy extension of power_signal_info structure to define various flags that might be applicable to power signals (e.g. "level"). Going forward, additional flag will be added in follow-up CLs. Also, provide a helper function power_signal_is_asserted that checks the actual level of a signal and compares it to the flags level to identify if a power signal is asserted. BUG=b:65421825 BRANCH=None TEST=make -j buildall Change-Id: Iacaabd1185b347c17b5159f05520731505b824b8 Signed-off-by: Furquan Shaikh <furquan@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/679979 Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
* hostcmd: Remove EC_CMD_VBNV_CONTEXT handler for most boardsShawn Nematbakhsh2017-02-251-0/+1
| | | | | | | | | | | | | | | | | Most boards do not keep VBNV storage on the EC, so leave out the host command handler by default. BUG=chromium:693210 BRANCH=None TEST=`make buildall -j` Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Change-Id: Ia202ec7d73d1804d8430fe7516cc783afd86e89a Reviewed-on: https://chromium-review.googlesource.com/446716 Commit-Ready: Shawn N <shawnn@chromium.org> Tested-by: Shawn N <shawnn@chromium.org> Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org>
* jerry: Increase HC task stack size.Aseda Aboagye2017-02-101-1/+1
| | | | | | | | | | | | | | | | With ToT images, we were hitting a stack overflow in the host command task. BUG=none BRANCH=none TEST=disable EC SW sync, flash jerry, verify it boots to login screen. Change-Id: I978b768c1619b4f0dfe862e96c31a91cebce8b87 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/440396 Commit-Ready: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Shelley Chen <shchen@chromium.org>
* Remove Makefile symlinks under board directoryDaisuke Nojiri2016-07-091-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | This feature is inconsistent. Not all boards have such a symlink (for a obvious reason). This feature is fragile. It's most likely not tested and going to be broken if not already. Developers won't like it if they have to test two different ways to build boards before submitting patches. This feature is not necessary. If you build EC in the standard way (e.g. make BOARD=samus), these symlinks are not needed. This feature is wasteful. Extra disk spaces are used and extra lines are added to Makefile (increasing code complexity slightly). BUG=chromium:626776 BRANCH=none TEST=make buildall Change-Id: Id5444284d773cb0e9225f39abd877441b8f61440 Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/359321 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* jerry: Free up flash spaceShawn Nematbakhsh2016-05-311-1/+3
| | | | | | | | | | | | | | Remove console command help strings to free flash space. BUG=None TEST=Build for jerry, verify free flash space goes from ~40 bytes to ~2500 bytes. BRANCH=None Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Change-Id: I3e250c86420978446ae0b348ded7646b13272486 Reviewed-on: https://chromium-review.googlesource.com/348073 Reviewed-by: Mary Ruthven <mruthven@chromium.org>
* cleanup: Add warning comment to gpio.inc filesBill Richardson2016-02-251-1/+3
| | | | | | | | | | | | | | | | | | | | | | | With commit e9883124ff16, a GPIO_INT macro was added. That change also required that all instances of GPIO_INT in a board's gpio.inc file come before any GPIO macros, or the interrupt handler wouldn't work properly. This CL just adds a warning comment about requirement to all gpio.inc files. BUG=chromium:471331 BRANCH=none TEST=make buildall, test image on Cr50 This is a change to comments only. There is no new behavior to verify, although I did run try out one new image just to be sure nothing stupid happened. Change-Id: I83f7819929a53bce3a8bae04d15b3ee3bda11738 Signed-off-by: Bill Richardson <wfrichar@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/329334 Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
* jerry: Increase UART TX buffer size.Aseda Aboagye2016-02-231-0/+4
| | | | | | | | | | | | | | | | | | | | | | | Found out that the string that is printed from console_init() doesn't show up on the EC console for jerry. It seems that perhaps due to the priority of the console task and the numerous prints during boot, that print never makes it to the TX buffer. Currently, there's about 7200 bytes available in the shared memory region, which indicates that there's still a lot of free space. Therefore, increase the UART TX buffer size. BUG=None BRANCH=None TEST=Flash jerry and verify that 'console is enabled' string shows up on the EC console. TEST=make -j buildall tests Change-Id: Id0603a3b758b5c600d0b59f27040ead2ce48bbaf Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/329180 Commit-Ready: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Randall Spangler <rspangler@chromium.org>
* GPIO: Move definitions of GPIO_KB_INPUT and OUTPUTAnton Staaf2016-02-222-5/+3
| | | | | | | | | | | | | | | | | | | | Previously these were often done in board.c files, which made it impossible to include the gpio.inc anywhere else. As part of refactoring the GPIO code we now need to be able to include gpio.inc from common/gpio.c. Moving these defines into gpio.inc makes them available wherever gpio.inc is included. Signed-off-by: Anton Staaf <robotboy@chromium.org> BRANCH=None BUG=None TEST=make buildall -j Change-Id: I28e7b5a1d40b113ae824b18f020b2d1e51e0c08a Reviewed-on: https://chromium-review.googlesource.com/328822 Commit-Ready: Anton Staaf <robotboy@chromium.org> Tested-by: Anton Staaf <robotboy@chromium.org> Reviewed-by: Bill Richardson <wfrichar@chromium.org>
* cleanup: Standardize use of CONFIG_I2C and add MASTER/SLAVE CONFIGsShawn Nematbakhsh2015-11-031-0/+1
| | | | | | | | | | | | | | | | | | | Some chips previously defined CONFIG_I2C and others didn't. Standardize the usage by removing CONFIG_I2C from all config_chip files and force it to be defined at the board level. Also, make boards define CONFIG_I2C_MASTER and/or CONFIG_I2C_SLAVE based on the I2C interfaces they will use - this will assist with some later cleanup. BUG=chromium:550206 TEST=`make buildall -j` BRANCH=None Change-Id: I2f0970e494ea49611abc315587c7c9aa0bc2d14a Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/310070 Commit-Ready: Shawn N <shawnn@chromium.org> Tested-by: Shawn N <shawnn@chromium.org> Reviewed-by: Alec Berg <alecaberg@chromium.org>
* Jerry: enable virtual batteryMary Ruthven2015-10-291-0/+3
| | | | | | | | | | | | BUG=chromium:484841 BRANCH=none TEST=check power_supply_info works properly on Jerry Change-Id: I166fd4fc876b2d71f82e8fc7b33e4268a30be567 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/309264 Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-by: Alec Berg <alecaberg@chromium.org>
* oak: enable MBKP events for PD eventsBen Lok2015-08-311-1/+1
| | | | | | | | | | | | | | | | | | | (refer to CL:273620) enable the MKBP event feature to send host event and wire up the PD specific events. But, CONFIG_MKBP_EVENT conflicts with CONFIG_KEYBOARD_PROTOCOL_MKBP, due to the GPIO name of EC interrupt pin. Align the GPIO naming of EC interrupt pin to EC_INT_L. BRANCH=none BUG=chrome-os-partner:44643 TEST=On Oak rev3, plug/unplug USB devices and add kernel trace to see the PD events happening. Change-Id: I10de9c6611583bb6165bdc1848e542d4b8bba954 Signed-off-by: Ben Lok <ben.lok@mediatek.com> Reviewed-on: https://chromium-review.googlesource.com/296012 Reviewed-by: Vincent Palatin <vpalatin@chromium.org> Reviewed-by: Rong Chang <rongchang@chromium.org>
* Jerry: add "cleanup: fix all the header guards"Myles Watson2015-07-251-3/+3
| | | | | | | | | | | | | 104f811e6730e129a98fac6fc3941bbe0d0e857f BUG=chromium:511324 TEST=make buildall -j BRANCH=none Change-Id: I994e11c94413d7b8683b64e86807ba45b61c7eea Signed-off-by: Myles Watson <mylesgw@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/288239 Reviewed-by: Wai-Hong Tam <waihong@chromium.org>
* Jerry: add "cleanup: remove board_discharge_on_ac"Myles Watson2015-07-252-11/+0
| | | | | | | | | | | | | | Apply ac1cba419ab507163dcb6dc9d6be1401f3f1f518 to Jerry. BUG=chromium:511324 TEST=make buildall -j BRANCH=none Change-Id: I04f168f8e1a8e6a1e7c21cc3ce8c06315d9e7495 Signed-off-by: Myles Watson <mylesgw@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/288238 Reviewed-by: Wai-Hong Tam <waihong@chromium.org> Reviewed-by: Alec Berg <alecaberg@chromium.org>
* Jerry: Revert "Remove obsolete EC targets"Myles Watson2015-07-257-0/+316
| | | | | | | | | | | | | | | | Jerry is being used for FAFT in the lab. Remove Pinky instead. This reverts part of commit bdc680d8ed7ea24cdfb1b5498f73a1008c71ad37. BUG=chromium:511324 TEST=make buildall -j BRANCH=none Change-Id: I034a814ffe3397728e443f99ed270d412be1bc1d Signed-off-by: Myles Watson <mylesgw@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/288236 Reviewed-by: Dan Shi <dshi@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@chromium.org>
* Remove obsolete EC targetsRandall Spangler2015-06-057-316/+0
| | | | | | | | | | | | | | | | | | | | | | | | This is needed to allow cleanup and refactoring of the EC codebase in ToT. All of these boards use firmware from branches and uploaded to BCS, so they don't actually care that ToT can't build their firmware. BUG=chromium:493866 TEST=build on the following using cbuildbot: daisy-paladin falco-paladin link-paladin nyan-paladin peppy-paladin samus-paladin squawks-paladin daisy_spring-paladin CQ-DEPEND=CL:274121,CL:274127 BRANCH=none Change-Id: I19598843755ded7b2385cc712ef463e5de4411b8 Signed-off-by: Randall Spangler <rspangler@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/274121 Reviewed-by: Bill Richardson <wfrichar@chromium.org>
* mec1322: Simplify GPIO listsSteven Jian2015-05-271-44/+44
| | | | | | | | | | | | | | | Our existing GPIO macros use port# / gpio#, but the concept of different GPIO ports does not exist on the mec1322. Therefore, add new GPIO macros for chips which do not have distinct GPIO ports. BUG=None BRANCH=None TEST=make buildall -j Change-Id: Ibda97c6563ad447d16dab39ecadab43ccb25174b Signed-off-by: Steven Jian <steven.jian@intel.com> Reviewed-on: https://chromium-review.googlesource.com/262841 Reviewed-by: Anton Staaf <robotboy@chromium.org>
* gpio: Refactor IRQ handler pointer out of gpio_listAseda Aboagye2015-04-101-41/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the gpio_info struct, we had a irq_handler pointer defined even though a majority of the GPIOs did not have irq handlers associated. By removing the irq_handler pointer out of the struct, we can save some space with some targets saving more than others. (For example, ~260 bytes for samus_pd). This change also brings about a new define: GPIO_INT(name, port, pin, flags, signal) And the existing GPIO macro has had the signal parameter removed since they were just NULL. GPIO(name, port, pin, flags) In each of the gpio.inc files, all the GPIOs with irq handlers must be defined at the top of the file. This is because their enum values from gpio_signal are used as the index to the gpio_irq_handlers table. BUG=chromium:471331 BRANCH=none TEST=Flashed ec to samus and samus_pd, verified lightbar tap, lid, power button, keyboard, charging, all still working. TEST=Moved a GPIO_INT declaration after a GPIO declaration and watched the build fail. TEST=make -j BOARD=peppy tests TEST=make -j BOARD=auron tests TEST=make -j BOARD=link tests Change-Id: Id6e261b0a3cd63223ca92f2e96a80c95e85cdefb Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/263973 Reviewed-by: Randall Spangler <rspangler@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Trybot-Ready: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Alec Berg <alecaberg@chromium.org>
* jerry: Switch led to CONFIG_LED_POLICY_STDAlexandru M Stan2015-01-144-156/+7
| | | | | | | | | | | BUG=chrome-os-partner:35355, TEST=The led behavior should match the cros spec BRANCH=None Change-Id: I360e30ff72d8c874651544ea41479189a0ac7e08 Signed-off-by: Alexandru M Stan <amstan@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/240706 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* rockchip: Enable UART RX DMAAlexandru M Stan2014-12-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | UART with no DMA is likely to drop RX characters when system is busy. This is because the UART interrupt is lower priority than the spi_event GPIO interrupt. We can work around this by enabling the DMA, so no UART interrupts are required while recieving, since everything will happen in DMA. This replaces the other patch(CL 236089) which suggested changing UART IRQ priority. BUG=chrome-os-partner:33451 TEST=get firmware to poll the EC for keyboard presses, type really fast on the keyboard, note how no character is lost anymore TEST=faft dev mode test now passes, faft is able to type "kbpress $(insert args for Ctrl+D) 1" correctly without missing characters because firmware is loading the EC with keyboard polls TEST=While '+'s are scrolling on the EC terminal paste something big like this: "kbpress 1 1 1 kbpress 1 1 0 123456789012345678901234567890 ". Both kbpresses should be interpreted/executed properly(no "kbprss") and there should be no missing digits in the echo back. BRANCH=None Change-Id: I01d4eaa23f10f07083875846ea48c34da2e2f6ce Signed-off-by: Alexandru M Stan <amstan@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/236365 Reviewed-by: Randall Spangler <rspangler@chromium.org>
* Jerry: Move AC_PRESENT for the new boardAlexandru M Stan2014-12-111-1/+1
| | | | | | | | | | | | | | | The new board will move AC_PRESENT to another pin in order to avoid the [1.052524 Overriding AC_PRESENT with KB_IN00 on EXTI8] problem. BUG=chrome-os-partner:34024 TEST=EC should react to AC events BRANCH=None Change-Id: I5c1110f10a3ed2704593c749cef35ab73fceb3e8 Signed-off-by: Alexandru M Stan <amstan@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/234586 Reviewed-by: Chris Zhong <zyw@rock-chips.com> Reviewed-by: Jerry Parson <jwp@chromium.org>
* Jerry: modify the power led polarityChris Zhong2014-11-171-1/+1
| | | | | | | | | | | | | | | | the power led polarity is wrong, so reverse it BRANCH=None BUG=chrome-os-partner:33269 chrome-os-partner:32782 TEST=power led is works correctly Change-Id: I4e91ea185ee5cb1f5b5202832a967244313062b4 Signed-off-by: Chris Zhong <zyw@rock-chips.com> Reviewed-on: https://chromium-review.googlesource.com/230170 Reviewed-by: Lin Huang <hl@rock-chips.com> Tested-by: Lin Huang <hl@rock-chips.com> Reviewed-by: Wei-Ning Huang <wnhuang@chromium.org> Commit-Queue: Lin Huang <hl@rock-chips.com>
* Jerry: modify gpio config, hibernateChris Zhong2014-11-133-13/+29
| | | | | | | | | | | | | | | | | | | Added hibernate wakeup pin(EC_WAKE) that covers both AC_PRESENT and LID_OPEN. It pulses a rising edge when either of them have a rising edge. The power button was also inverted to handle hibernation better, now it's low except when pressed it temporarly goes high. BRANCH=None BUG=chrome-os-partner:33269 chrome-os-partner:32782 TEST=make BOARD=jerry Try hibernating, all wakeup sources should work, it shouldn't stay hibernated. All signals(AC, lid, power button) should work equally well as in pinky. Change-Id: I894135bdfd5600919296f7510dc9cd1acd567ddc Signed-off-by: Chris Zhong <zyw@rock-chips.com> Signed-off-by: Alexandru M Stan <amstan@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/228763
* Add initial support for jerryKatie Roberts-Hoffman2014-10-258-0/+448
BUG=chrome-os-partner:33269 TEST=make BOARD=jerry; ./util/flash_ec BOARD=jerry (on a pinky rev2 as a sanity) Change-Id: I2c54e4044a65a0014adb32dd46f74bf5ed11b02d Signed-off-by: Katie Roberts-Hoffman <katierh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/225300 Reviewed-by: Alexandru Stan <amstan@chromium.org>