| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the interest of making long-term branch maintenance incur as little
technical debt on us as possible, we should not maintain any files on
the branch we are not actually using.
This has the added effect of making it extremely clear when merging CLs
from the main branch when changes have the possibility to affect us.
The follow-on CL adds a convenience script to actually pull updates from
the main branch and generate a CL for the update.
BUG=b:204206272
BRANCH=ish
TEST=make BOARD=arcada_ish && make BOARD=drallion_ish
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I17e4694c38219b5a0823e0a3e55a28d1348f4b18
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3262038
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add keyboard_factory_scan_pins and keyboard_factory_scan_pins_used to
keyboard_scan header so they do not need to be declared as extern by
individual boards. These constants need to be defined if
CONFIG_KEYBOARD_FACTORY_TEST is enabled.
BUG=None
TEST=Build
BRANCH=None
Change-Id: I1a100f626b3cea251ca72703d17b2d27db0f8f28
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3053101
Commit-Queue: Diana Z <dzigterman@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the screen brightness is changed, DP sends signal on AUX channel.
This causes CCD mode to be disconnected.
This patch sets the MUX to aux+ <-> sbu2, aux- <-> sbu1 to fix it.
Same change as I3dba1bdfd44a921077a2f60dec17119bb0077238
BUG=b:185137814
BRANCH=hatch
TEST=manually verify servod doesn't exit when screen turns off due
to the device being idle for too long
Signed-off-by: Shelley Chen <shchen@google.com>
Change-Id: Ie1edef535297c68b7e91e247caaeb7ad00d19392
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2831053
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Shelley Chen <shchen@chromium.org>
Tested-by: Shelley Chen <shchen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
config motion sensor icm/kx022/bmi160/bma255
driver by chip id value.
BUG=b:175918382
BRANCH=main
TEST=Work on DUT with ICM/KX022/BMA255/BMI160,
check the motion function is workable.
Change-Id: Ie76dc49f2e102c230ddb5675a52639acb22b2da4
Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2592541
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ensure wake up from MURATA battery takes some seconds,
to come back out of its disconnect. Setting
CONFIG_POWER_BUTTON_INIT_TIMEOUT to 2 second.
BUG=b:146914669
BRANCH=hatch
TEST=check power on, plug in AC after battery cutoff
Change-Id: I55e1f1957ebbe6800cf01e347e9ed29d57ab1280
Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1984153
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The keyscan_config is the same as the default. Don't define the board
custom keyscan_config.
For the board.h, most of them have duplicated definitions from the
baseboard.h. Remove them by the script:
$ grep -rl 'BASEBOARD:=hatch' * | cut -f1 -d/ | xargs -IX sed -i \
'/#define CONFIG_KEYBOARD_BOARD_CONFIG/d' X/board.h
BRANCH=hatch
BUG=b:156007029
TEST=Build all the hatches boards, no error.
Change-Id: Ib02550708d533ced77f5fad05b074291b66dd4fc
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2194160
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PD_MAX_VOLTAGE/PD_MAX_CURRENT/PD_MAX_POWER/PD_OPERATING_POWER/"
This reverts commit 89197aceaf26ccf33b143c7a5e95eb07ba4c7464.
Reason for revert: It is not necessary to change the PD setting, so revert it.
Original change's description:
> hatch: refactor PD_MAX_VOLTAGE/PD_MAX_CURRENT/PD_MAX_POWER/PD_OPERATING_POWER/
>
> 1) The four config is determined by board, move it into board.h.
> 2) Update the config variables above for stryke.
>
> BUG=b:145257655
> BRANCH=hatch
> TEST=make buildall
>
> Change-Id: I1dd6a4f2a78b5196006821bc5d2686f68206c2e1
> Signed-off-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1950270
> Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Bug: b:145257655
Change-Id: Ib2cb2db51b15f0974d2b22ef8e0e3e6d4e6b60d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1958299
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Commit-Queue: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Tested-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently board_override_features_flags0/1 are enabled by
CONFIG_EC_FEATURE_BOARD_OVERRIDE.
This patch defines the callbacks as overridable. It will
allow us to remove CONFIG_EC_FEATURE_BOARD_OVERRIDE and
the redundancy it incurs.
Signed-off-by: dnojiri <dnojiri@chromium.org>
BUG=none
BRANCH=none
TEST=buildall
Change-Id: I0c2870b746879b272ada35b9615b611627a9f426
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1951810
Reviewed-by: Jett Rink <jettrink@chromium.org>
Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Auto-Submit: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) The four config is determined by board, move it into board.h.
2) Update the config variables above for stryke.
BUG=b:145257655
BRANCH=hatch
TEST=make buildall
Change-Id: I1dd6a4f2a78b5196006821bc5d2686f68206c2e1
Signed-off-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1950270
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
connector-to-GPIO map:
{-1, -1}, {0, 5}, {1, 1}, {1, 0}, {0, 6},
{0, 7}, {-1, -1}, {-1, -1}, {1, 4}, {1, 3},
{-1, -1}, {1, 6}, {1, 7}, {3, 1}, {2, 0},
{1, 5}, {2, 6}, {2, 7}, {2, 1}, {2, 4},
{2, 5}, {1, 2}, {2, 3},{2, 2}, {3, 0},
{-1, -1}, {-1, -1}, {-1, -1}, {-1, -1},
{-1, -1}, {-1, -1},
BUG=b:143927624
BRANCH=master
TEST=`ectool kbfactorytest` PASS.
Change-Id: I67b8ebd1edb238a265bd6f9e5e98100b5635a2d6
Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1898256
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Commit-Queue: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL enables the config option CONFIG_USB_PD_TCPM_ANX7447_AUX_PU_PD
for hatch variants that have the ANX7447 TCPC.
BUG=b:124410548
BRANCH=None
TEST=On hatch, connect external monitor,usb device or CCD cable to
type-c port0. Verifed each worked as expected.
Change-Id: I7cd6ce65dac42dffd41a0f75fc844b634d7d312f
Signed-off-by: Scott Collyer <scollyer@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1788333
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Nitin Kolluru <nkolluru@google.com>
Commit-Queue: Scott Collyer <scollyer@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change GPIO_EC_PCH_SYS_PWROK to GPIO_PCH_SYS_PWROK on cometlake to
conform with naming convention used on other Intel processors.
Leave gpio.inc files unchanged and add a mapping from
GPIO_EC_PCH_SYS_PWROK to GPIO_PCH_SYS_PWROK in the board files.
BUG=none
BRANCH=none
TEST=make buildall -j
TEST=boot kohaku
Change-Id: I722cb06dd90ee5d7e426664508f54a5cbe19de4a
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1848251
Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds the config option CONFIG_DYNAMIC_MOTION_SENSOR_COUNT and
the variable motion_sensor_count based on
CLAMSHELL or CONVERTIBLE designation by the SKU ID.
BUG=b:140217139
BRANCH=Master
TEST=use ectool set cbi sku id, ensure the motion sensors enable or not.
Change-Id: Idadc455417f9b4ae58fadcb6ddbc7c1f3a7feb8b
Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1780966
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Philip Chen <philipchen@chromium.org>
Commit-Queue: Furquan Shaikh <furquan@chromium.org>
Tested-by: Furquan Shaikh <furquan@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch enable temp sensor 3 near by WIFI.
BUG=b:140127035
BRANCH=master
TEST=run 'temps', verify that temp sensor is
present and reasonable.
Change-Id: I266cb1ecd92a8727d65c33bae686f5b6848ca168
Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1751304
Reviewed-by: David Wu <david_wu@quanta.corp-partner.google.com>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: David Wu <david_wu@quanta.corp-partner.google.com>
Commit-Queue: Tim Wawrzynczak <twawrzynczak@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable keyboard backlight control by SKU ID of kled, which
number is 1,2,3,4.
BUG=b:138326244
BRANCH=master
TEST=Use console command "kblight 0-100" to check keyboard backlight
works.
Change-Id: I96047b991850a54ce4a600a273d0bcdac0e8a053
Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1731209
Reviewed-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the CONFIG_SYSTEM_UNLOCKED option from some board
configurations and enable CONFIG_USB_PD_COMM_LOCKED.
The main affect of this will be to prevent PD communication in RO.
BRANCH=master
BUG=b:138992459
TEST=flash on kindred and RO did not negotiate (when WP was asserted)
but RW did.
Change-Id: I10fee6005da46a1432e61e1fa79e5b8360b642cc
Signed-off-by: ben.chen2@quanta.corp-partner.google.com
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1751305
Reviewed-by: Philip Chen <philipchen@chromium.org>
Tested-by: David Huang <David.Huang@quantatw.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All hatch-family hardware uses a 30.9K resistor in the temperature
sensor with the 47K thermistor. Update Hatch reference, Helios, and
Kindred.
BRANCH=none
BUG=b:124316213
TEST=Rebuild EC for each board:
``cd ~/trunk/src/platform/ec``
``make -j BOARD=hatch``
``make -j BOARD=helios``
``make -j BOARD=kindred``
Change-Id: I71cb0b8db79f64e4809a2ef66db6fb1f0607ed53
Signed-off-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1749740
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All the hatch platforms had a typo with the config option guarding the
configuration of the SLP_S3_L and SLP_S4_L signals. Changed
CONFIG_HOSTCMD_ESPI_VW_SIGNALS to CONFIG_HOSTCMD_ESPI_VW_SLP_SIGNALS.
BUG=b:139198212
BRANCH=none
TEST=make buildall -j
Change-Id: I96c01fb8e1903585f3bc19a30b2f9c0596e9edad
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1745655
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clean up unused sensors for kindred/kled.
BUG=b:138262676
BRANCH=none
TEST=make buildall -j
Change-Id: I7b4f7693fc2c7f7ae72f20381a1ec8d1a71dbad7
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1730371
Reviewed-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Tested-by: David Huang <David.Huang@quantatw.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The extentions were added to make the compiler perform most
of the verification that the conversion was being done correctly
to remove 8bit addressing as the standard I2C/SPI address type.
Now that the compiler has verified the code, the extra
extentions are being removed
BUG=chromium:971296
BRANCH=none
TEST=make buildall -j
TEST=verify sensor functionality on arcada_ish
Change-Id: I36894f8bb9daefb5b31b5e91577708f6f9af2a4f
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1704792
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Opt for 7bit slave addresses in EC code. If 8bit is
expected by a driver, make it local and show this in
the naming.
Use __7b, __7bf and __8b as name extensions for i2c/spi
addresses used in the EC codebase. __7b indicates a
7bit address by itself. __7bf indicates a 7bit address
with optional flags attached. __8b indicates a 8bit
address by itself.
Allow space for 10bit addresses, even though this is
not currently being used by any of our attached
devices.
These extensions are for verification purposes only and
will be removed in the last pass of this ticket. I want
to make sure the variable names reflect the type to help
eliminate future 7/8/7-flags confusion.
BUG=chromium:971296
BRANCH=none
TEST=make buildall -j
Change-Id: I2fc3d1b52ce76184492b2aaff3060f486ca45f45
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1699893
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
new battery: LGC KT0030G020,Murata KT00304012
BUG=b:131126718,b:131126717
BRANCH=master
TEST=Make sure battery can cutoff by console "cutoff" or "ectool cutoff"
Signed-off-by: ben.chen2@quanta.corp-partner.google.com
Change-Id: Ic8d216cea8cdc085a536df5e0d1dfaf940390c5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1657850
Reviewed-by: David Huang <David.Huang@quantatw.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Philip Chen <philipchen@chromium.org>
Tested-by: David Huang <David.Huang@quantatw.com>
Commit-Queue: Paul Fagerburg <pfagerburg@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL cleans up the dependence on the MST support
in hatch baseboard.
Subboards can optionally define USB_PD_PORT_TCPC_MST when
MST support is needed.
BUG=b:133788856
BRANCH=none
TEST=make buildall
Change-Id: Ia83e31e68881ce419056716df4776e4be6786c45
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1657320
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
Commit-Queue: Philip Chen <philipchen@chromium.org>
|
|
The starting point for the Kindred EC image
BUG=b:133181366
BRANCH=none
TEST=make BOARD=kindred
Change-Id: Ie5e976f426537fc0994c43d033a1b595d21095fc
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1648602
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Paul Fagerburg <pfagerburg@chromium.org>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Allen Webb <allenwebb@google.com>
|