| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's little point in providing the PWM API, which needs a channel
id _everywhere_ when the corresponding enum defines to channels.
gcc 11 complains about trying to access something in a zero-sized
pwm_res array.
BUG=none
BRANCH=none
TEST=one class of error less with gcc 11
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Change-Id: I366650c4cecc85493bce626091aba5eecc034039
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2959920
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Commit-Queue: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the last remaining reference to metaknight_light. We
already removed the board.
BRANCH=None
BUG=None
TEST=buildall passes
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Change-Id: Id230d32dbe51d3c7d1aedaf2b41e0d491c3fa627
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2964388
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
modify voltage range of ADC button
Before: After:
^
| No pressed
-------2.7v -> 2.78v
|
-------2.69v -> 2.74v
| V-
-------2.6v
|
-------2.49v -> 2.54v
| V+
-------2.4v
|
-------2.29v -> 2.3v
| V+ and V-
v
BUG=b:190330515
BRANCH=dedede
TEST=factory check 4 fail device pass
Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
Change-Id: Ibee2977086b57818588e60ff5d35291ddc2e5827
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2940335
Reviewed-by: Raymond Wong <wongraymond@google.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CTS tests are failing because sensor values from axis 1 and 2 are
negated. When the test expects 360 degrees, -360 degrees gets reported.
Set the standard base translation matrix to resolve this.
BUG=b:186141913
BRANCH=dedede
TEST=CTS PASS
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: Ic56fd73a0c9e382aa83ddf1f8fb5a660920ccd11
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2850293
Reviewed-by: Henry Sun <henrysun@google.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, all boards using the LED On/Off module have battery LEDs.
However, if we'd like to expand support to Chromeboxes then the battery
LED must become optional.
BRANCH=None
BUG=b:185508707
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ieae098829ebe6c8b103f23d5abdbf70e7bcbdf2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2832692
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support motion sensor 2nd source:
-Base : ICM-426xx
BUG=b:177868819
BRANCH=dedede
TEST=rework ICM-426xx to DUT, check ectool motionsense
lid_angle is correct.
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: I8aa344662654d2f02d8cdd5101fcfe568931085f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2825720
Tested-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
Auto-Submit: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the previous change to disable the ASGATE from the charger side,
this actually ended up breaking sourcing VBUS.
This commit enables the ASGATE when we are attempting to source VBUS.
BUG=b:183220414
BRANCH=dedede
TEST=Build and flash madoo, plug in a Type-C sink, verify that VBUS is
sourced.
TEST=Verify that DUT can PR_Swap with peripheral.
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Change-Id: I1938f2b827e57a04ef72e2ad35ad6ff29ce18712
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2795073
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of f7fbc629f0655229cc7ffdadfb18c9e13118e3d2
Original change's description:
> dedede/raa489000: Disable ASGATE from READY state
>
> On the boards which use the RAA489000, we keep the ADC enabled while
> giving VBUS control to the charger side. This can cause a situation
> where VBUS is not quite zero volts when a charger is removed. This
> commit uses the charger side registers to control the ASGATE when
> selecting our active charge port. This is done in addition to the
> existing implementation which uses the TCPCI registers to control
> ASGATE. When we place the parts into low power mode, we move the VBUS
> control from the TCPC side of the IC to the charger side. It should
> be safe to issue both commands as if the TCPC side has control, the IC
> ignores the setting from the charger side registers.
>
> BUG=b:183220414
> BRANCH=dedede
> TEST=Build and flash madoo, plug in charger to port, unplug, verify
> that VBUS falls to < 200mV and decays from there.
>
> Signed-off-by: Aseda Aboagye <aaboagye@google.com>
> Change-Id: I8e8c8cc32575d18c9d3d1210ed3c5cf69ad5ca4b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2793058
> Tested-by: Aseda Aboagye <aaboagye@chromium.org>
> Reviewed-by: Diana Z <dzigterman@chromium.org>
> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Bug: b:183220414
Change-Id: I36db53f3e13ba848308cd7e0c94a1b5a3551c600
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2797549
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This function prototype is defined in lots of files, none of which is
visible to Zephyr.
Add a prototype in one place and remove the others.
BUG=b:183296099
BRANCH=none
TEST=make buildall
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: Ia324327a69b117483ab9ee5c85eba93c0fb5ad9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2789799
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit f7fbc629f0655229cc7ffdadfb18c9e13118e3d2.
Reason for revert: Breaks sourcing of VBUS.
Original change's description:
> dedede/raa489000: Disable ASGATE from READY state
>
> On the boards which use the RAA489000, we keep the ADC enabled while
> giving VBUS control to the charger side. This can cause a situation
> where VBUS is not quite zero volts when a charger is removed. This
> commit uses the charger side registers to control the ASGATE when
> selecting our active charge port. This is done in addition to the
> existing implementation which uses the TCPCI registers to control
> ASGATE. When we place the parts into low power mode, we move the VBUS
> control from the TCPC side of the IC to the charger side. It should
> be safe to issue both commands as if the TCPC side has control, the IC
> ignores the setting from the charger side registers.
>
> BUG=b:183220414
> BRANCH=dedede
> TEST=Build and flash madoo, plug in charger to port, unplug, verify
> that VBUS falls to < 200mV and decays from there.
>
> Signed-off-by: Aseda Aboagye <aaboagye@google.com>
> Change-Id: I8e8c8cc32575d18c9d3d1210ed3c5cf69ad5ca4b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2793058
> Tested-by: Aseda Aboagye <aaboagye@chromium.org>
> Reviewed-by: Diana Z <dzigterman@chromium.org>
> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Bug: b:183220414
Change-Id: Ibf6c161adca9981a065e969b6c3b73dd408ef1ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2796411
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On the boards which use the RAA489000, we keep the ADC enabled while
giving VBUS control to the charger side. This can cause a situation
where VBUS is not quite zero volts when a charger is removed. This
commit uses the charger side registers to control the ASGATE when
selecting our active charge port. This is done in addition to the
existing implementation which uses the TCPCI registers to control
ASGATE. When we place the parts into low power mode, we move the VBUS
control from the TCPC side of the IC to the charger side. It should
be safe to issue both commands as if the TCPC side has control, the IC
ignores the setting from the charger side registers.
BUG=b:183220414
BRANCH=dedede
TEST=Build and flash madoo, plug in charger to port, unplug, verify
that VBUS falls to < 200mV and decays from there.
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Change-Id: I8e8c8cc32575d18c9d3d1210ed3c5cf69ad5ca4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2793058
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use board-specific override files when generating VIFs for boards.
BUG=b:172276715
TEST=make buildall
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: I197365018ceb8197c22d631cebf4cbce1c0119f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2785506
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move GPIO00,GPIO40,GPIO73,GPIO80,GPIO92,GPIOE0 to NC pin.
Rename EC_I2C_SUB_C1_SDA_HDMI_HPD_ODL to HDMI_HPD_SUB_ODL.
Add "HDMI plug-in/out" message in ec console.
Remove hdmi_enable/disable function due to GPIO92 not used.
Add "SSFC" tag in init g-sensor console message.
BUG=None
BRANCH=dedede
TEST=check DUT can boot, HDMI log correct
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: I0d600408171de68dfa025065845dd55e59e8a6dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2780863
Tested-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
Auto-Submit: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Metaknight keyboard not support backlight
Disable keyboard backlight function
BUG=b:172146031
BRANCH=dedede
TEST=check DUT can boot
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: I3f286100d728cd69c53e8efe3304208bc5fe39c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2777934
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some reason, when the RAA489000 TCPC exits low power mode, CC
status doesn't appear changed when using a servo v4. This causes us
to think no connection is present and immediately but the IC back into
low power mode. If we wait 100ms before querying the CC status reg,
it seems that then the right values are reported.
This commit adds a workaround by setting the LPM exit debounce time to
100ms.
BUG=b:182429150,b:181308089
BRANCH=dedede
TEST=Build and flash a board, verify that servo v4 with an external
charger is detected.
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Change-Id: Ic0c2406fa20d0dad82adee865cd87c46d7126b9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2752250
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEMP_SENSOR_1 -> TEMP_SENSOR_MEMORY
TEMP_SENSOR_2 -> TEMP_SENSOR_CPU
BUG=None
BRANCH=dedede
TEST=check ec console temps, temperature is correct.
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: I8b47cc39ee2fc226b8f50b76fe440b0bd68d11af
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2751319
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add CONFIG_TEMP_SENSOR_FIRST_READ_DELAY_MS to adjustment
delay time of thermal sensor first read.
Add 500 ms delay of thermal sensor first read in metaknight.
BUG=b:181202521
BRANCH=dedede
TEST=DUT do [ec reset|boot from G3] 20 time pass
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: I12f5411c8ac3866d7a52807c4eface9e6bdfd5a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2738505
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Progressed enough in development that we no longer need to
force an unlocked state on the EC.
BRANCH=dedede
BUG=b:179635951
TEST=make BOARD=metaknight
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: I4a0ba1a966f84b7b126c6553f6938d209565a7d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2706662
Reviewed-by: Henry Sun <henrysun@google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Recently, metaknight was cleaned up to remove all C1 related items,
but one thing was forgotten, the C1 USB charger task. This caused a
watchdog reset to happen upon init with the new changes.
This commit simply removes the C1 USB charger task from metaknight.
BUG=b:180678923
BRANCH=dedede
TEST=Build and flash metaknight, verify that DUT boots and does not
watchdog reset.
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Change-Id: I3280ee112858e057acb69619ac2072e362636dad
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2708667
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit cleans up the remnants of a 2nd charger IC as metaknight
does not plan to support one.
BUG=b:169813211
BRANCH=dedede
TEST=`make -j BOARD=metaknight`
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Change-Id: I9368cd831cf134f39741a46f2a9ee511bdeeb7cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2698375
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Thus far, it seems that boards that use the same OCPC PID constants
behave similarly. Therefore, this commit updates the constants that
were most recently used on madoo to the other OCPC boards that use the
same charger IC such that the behaviour meets the criteria at
go/ocpc-testing.
- Converges around the target current.
- Average steady state error is less than 4% of target.
- Current is reduced to target level in less than 5s when load is
suddenly released.
BUG=None
BRANCH=dedede
TEST=Build and flash magolor. Verify that battery can charge to 100%.
Verify that it meets or exceeds the constraints above.
TEST=Verify that DUT can come out of battery cutoff from sub board.
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Change-Id: I206854c097c307b941a64547f9b74c8259a7d499
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2691585
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add setup_thermal for setting thermal table
BUG=b:178678269
BRANCH=main
TEST=thermal team verify value on AP
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: I8b55a6e8c488e3a5eee713e6d73f908def3bec00
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2666558
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Boards using the RAA489000 TCPC should set output current on their ports
through the TCPC driver. This commit adds a board function to do this
for every dedede board currently using the RAA489000.
BRANCH=None
BUG=b:178064507
TEST=on madoo, verify OCP occurs if more than 1.5A is drawn on a non-PD
port, verify register is set to allow 3.0A for port partners requesting
that current in their sink capabilities
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ieb7df916c122d5de1adaa7371a58ad5cf2954ee4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2658377
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix g-sensor name
BUG=b:177868819
BRANCH=main
TEST=check ectool motionsense info 1, return name is lsm6ds3
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: I8ba64c39e05e8b1fcf8f18ee285cbf3db1c484f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2657914
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix wrong words.
BUG=None
BRANCH=main
TEST=None
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: I9af86d352d00403dd66012fdac2c639454ca1518
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2644789
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CtsSensorTestCases is failing on Drawcia because it requests 100
events from accelerometer and gyroscope but gets zero. We can
read sensor events just fine, but they never seem to push to the
kernel. Add CONFIG_MKBP_EVENT into the baseboard, and then clean up
all the one-off variants that have added this themselves. Also, add
some accel commands specific to drawcia for easier debugging.
BUG=b:171939568
BRANCH=none
TEST=Use amstan's script, which amounts to cat /dev/iio:deviceN
Signed-off-by: Evan Green <evgreen@chromium.org>
Change-Id: Ia796ec2f9a08d3628dcabb4b5fca425693af4099
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2638636
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add temp sensor for reading temperature.
BUG=b:177854439
BRANCH=main
TEST=In console input "temps" to check temperature.
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: Ifc9c3d5c2e93ddd8267353fa9fd31367e539c3d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2637154
Reviewed-by: Henry Sun <henrysun@google.com>
Commit-Queue: Henry Sun <henrysun@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support motion sensor 2nd source:
-Lid : KX022
-Base : LSM6DSM
BUG=b:177868819
BRANCH=main
TEST=rework KX022/LSM6DSM on DUT, check ectool
motionsense lid_angle is correct.
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: If61addd7ca182ff9c3d3e87e1f77076236a006d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2641705
Tested-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Henry Sun <henrysun@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In madoo's design, there is a protection IC between USB
connector and TCPC. When EC is hibernate, the CC lines will
be disconnected, which cause the result that TCPC can't
detect AC power and Chromebook won't wake the system.
Enalbing ADC for all modes by setting 0x4C bit 0 to 1 (to be
more precise is that we don't clear bit 0 during hibernation)
can prevent issue mention above.
BUG=b:174971576
BRANCH=dedede
TEST=flash code and make sure ac in can wake system from hibernation
Signed-off-by: Ko_Ko <Ko_Ko@compal.corp-partner.google.com>
Change-Id: I2a83c69e34cbc4bfdff90d760f32817a7924dc26
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2626803
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Reviewed-by: Ko Ko <ko_ko@compal.corp-partner.google.com>
Tested-by: Ko Ko <ko_ko@compal.corp-partner.google.com>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Early versions of waddledoo had to have their 5V GPIO remapped between
versions. As variants of waddledoo are created, they end up copying
the same code which is not applicable to their board.
This commit restricts the remap to the waddledoo board only.
BUG=None
BRANCH=dedede
TEST=`make -j BOARD=metaknight`
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Change-Id: Id4903ea492753666725fbc03cc24eab2b9017150
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2625796
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix motion sensor rotation matrices
BUG=b:173984659
BRANCH=main
TEST=make BOARD=metaknight
TEST=check factory test item can pass
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: I970249a4b0292fb0eba73df3c19239bcf89821f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2620718
Tested-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
Reviewed-by: Henry Sun <henrysun@google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add DB_LTE_HDMI in dedede fw_config_db
Remove metaknight USB C1 port
Remove C1 PD task and PD int task
Remove OCPC
BUG=b:176275423
BRANCH=main
TEST=make BOARD=metaknight
TEST=make BOARD=metaknight_legacy
TEST=make buildall -j4
TEST=check EC console ,EC will not init DB raa489000.
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: Ibd86ee852ba870a95e5b552588c7f81ce77a122d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2603095
Tested-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
Auto-Submit: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disable pen charge when system in S5/G3.
BUG=b:176202016
BRANCH=master
TEST=make BOARD=metaknight
TEST=make BOARD=metaknight_legacy
TEST=check EC console ,works as expected.
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: I156961a54364f4e04b71e269218ca37a1bf4520a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2600808
Tested-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Auto-Submit: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit revises the USB-C interrupt handlers. Sometimes the
interrupt line can remain asserted once we've finished handling the
interrupt. This commit leverages the work that was done for the other
dedede boards to check if the interrupt is still asserted and rerun
the interrupt handlers if needed.
BUG=b:143166332
BRANCH=dedede
TEST=`make -j BOARD=metaknight`
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Change-Id: If6d05594887590ded83aa65146674912da8004d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2601172
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the DPM will be handling source-out decisions for TCPMv2,
remove references to its old configuration options from TCPMv2 boards in
order to avoid any confusion as to what code is running now. Also
remove the charge manager notifications of sink attach/detach since the
policy is being centralized into the DPM.
Note that the previous configuration options only ever allocated one 3.0
A port, and so the default number of 3.0 A ports has been set to 1.
BRANCH=None
BUG=b:168862110,b:141690755
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ie452e3da32b04226503539daa67b6b9f4a58aa58
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2597431
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is an option in the task_set_event function which force
the calling task to wait for an event. However, the option is never
used thus remove it.
This also will help in the Zephyr migration process.
BUG=b:172360521
BRANCH=none
TEST=make buildall
Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com>
Change-Id: Ic152fd3d6862d487bcc0024c48d136556c0b81bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2521599
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Metaknight_legacy is running out of space. This commit simply enables
CONFIG_DEBUG_ASSERT_BRIEF in order to free up some flash space.
BUG=None
BRANCH=dedede
TEST=`make -j buildall`
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Change-Id: Icfb16548913a271d571c993d1fefbe1cea9c3403
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2582593
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change EC chip from NPCX796FC0BX to NPCX797FC0BX
BUG=b:173464184
BRANCH=master
TEST=make BOARD=metaknight
TEST=make BOARD=metaknight_legacy
TEST=new ec is working after rework.
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: Icb81a4a89c71db183994d3737fa8ed807353e06c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2557775
Reviewed-by: Henry Sun <henrysun@google.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support pen charge function:
GPIO50 low -> pen charge enable
GPIO50 high -> pen charge disable
BUG=b:169615752
BRANCH=master
TEST=make BOARD=metaknight
TEST=check pen charge pin voltage ,works as expected.
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: Ifd3d2535df6bbd071045cef8f6f6dae90f28da94
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2557299
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add Vol +- volume up/down by ADC HOOK function
BUG=b:169615752
BRANCH=master
TEST=make BOARD=metaknight
TEST=Press Vol+- button function work.
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: I70a10dd867ee1e1e24f34857f8097fbcd0a76350
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2552332
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change rotations matrices of accel sensor
BUG=b:173984659
BRANCH=master
TEST=make BOARD=metaknight
TEST=Using ectool 'motionsense' verified lid angle now goes
from 0 to 360 and swtiches to tablet mode after crossing 200
threshold.
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: I3aa6857d5d152296e2bc35a6ffc073b6fa7b7db6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2553949
Reviewed-by: Henry Sun <henrysun@google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The RAA48900 charger IC seems to over draw its contract by roughly 4%.
This commit simply modifies our input current limit to account for
that.
BUG=b:147463641
BRANCH=dedede
TEST=Build and flash waddledoo, verify that input current limit is
reduced and is under the contract.
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Change-Id: I70ab15ea24d789a7a1696217efae784f537ca014
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2548692
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
config USB-A pin define, and enable USB SMART function
BUG=b:169615752
BRANCH=master
TEST=make BOARD=metaknight
Signed-off-by: Yu-An.Chen@quanta.corp-partner.google.com
Change-Id: I1a4d45952f40304ea8374991dc4ee2e648e566c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2505404
Tested-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
Reviewed-by: Henry Sun <henrysun@google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
Auto-Submit: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support new battery PC-VP-BP144
BUG=b:172390536
BRANCH=master
TEST=Make sure battery can cutoff by console "cutoff" or "ectool
batterycutoff" and resume by plug in adapter.
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: I11db98f37a27afd513a0f5adf04ff57a5eb2fbfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2526040
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Config GPIOC3, GPIOC4 to control LED.
Move GPIOC2 to NC pins.
Modify Led behavior.
BUG=b:172845491
BRANCH=master
TEST=make BOARD=metaknight PASS
TEST=Led behavior is correct after change.
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: Icc86b6e6c7e6541c73d70c0903a609be419782ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2528730
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
Create the initial EC image for the metaknight variant by copying
the waddledoo reference board EC files into a new directory named
for the variant.
(Auto-Generated by create_initial_ec_image.sh version 1.2.0).
BUG=b:169813211
BRANCH=none
TEST=make BOARD=metaknight
Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
Change-Id: I25cf60b45dfdfb50ec7a3e2c057e71eb7cbcaf5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2488951
Reviewed-by: Henry Sun <henrysun@google.com>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Commit-Queue: Paul Fagerburg <pfagerburg@chromium.org>
|